excellent 1.7.2 → 2.0.0

data/spec/checks/method_name_check_spec.rb

@@ -1,112 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::MethodNameCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::MethodNameCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept method names with underscores' do
-      code = <<-END
-        def good_method_name
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept method names with numbers' do
-      code = <<-END
-        def good_method_name_1
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept method names ending with a question mark' do
-      code = <<-END
-        def good_method_name?
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept method names ending with an exclamation mark' do
-      code = <<-END
-        def good_method_name!
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept method names ending an equals sign' do
-      code = <<-END
-        def good_method_name=
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    ['<<', '>>', '==', '<', '<=', '>', '>=', '[]', '[]=', '+', '-', '*', '~', '/', '%', '&', '^', '|'].each do |operator|
-
-      it "should accept #{operator} as a method name" do
-        code = <<-END
-          def #{operator}
-          end
-        END
-        @excellent.check_code(code)
-
-        @excellent.warnings.should be_empty
-      end
-
-    end
-
-  end
-
-  it 'should reject camel cased method names' do
-    code = <<-END
-      def badMethodName
-      end
-    END
-    @excellent.check_code(code)
-    warnings = @excellent.warnings
-
-    warnings.should_not be_empty
-    warnings[0].info.should        == { :method => 'badMethodName' }
-    warnings[0].line_number.should == 1
-    warnings[0].message.should     == 'Bad method name badMethodName.'
-  end
-
-  it "should correctly return the method's full name" do
-    code = <<-END
-      class Class
-        def badMethodName
-        end
-        def self.badMethodName2
-        end
-      end
-    END
-    @excellent.check_code(code)
-    warnings = @excellent.warnings
-
-    warnings.should_not be_empty
-    warnings[0].info.should        == { :method => 'Class#badMethodName' }
-    warnings[0].line_number.should == 2
-    warnings[0].message.should     == 'Bad method name Class#badMethodName.'
-    warnings[1].info.should        == { :method => 'Class.badMethodName2' }
-    warnings[1].line_number.should == 4
-    warnings[1].message.should     == 'Bad method name Class.badMethodName2.'
-  end
-
-end

data/spec/checks/module_line_count_check_spec.rb

@@ -1,48 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::ModuleLineCountCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::ModuleLineCountCheck.new({ :threshold => 2 }))
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept modules with less lines than the threshold' do
-      code = <<-END
-        module OneLineModule; end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept modules with the same number of lines as the threshold' do
-      code = <<-END
-        module TwoLinesModule
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should reject modules with more lines than the threshold' do
-      code = <<-END
-        module FourLinesModule
-          @foo = 1
-          @bar = 2
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :module => 'FourLinesModule', :count => 4 }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'FourLinesModule has 4 lines.'
-    end
-
-  end
-
-end

data/spec/checks/module_name_check_spec.rb

@@ -1,61 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::ModuleNameCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::ModuleNameCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept camel case module names starting in capitals' do
-      code = <<-END
-        module GoodModuleName 
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept namespaced modules' do
-      code = <<-END
-        module Outer::Inner::GoodModuleName 
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should reject module names with underscores' do
-      code = <<-END
-        module Bad_ModuleName 
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :module => 'Bad_ModuleName' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'Bad module name Bad_ModuleName.'
-    end
-
-    it 'should correctly report bad names of namespaced modules' do
-      code = <<-END
-        module Outer::Inner::Bad_ModuleName
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :module => 'Outer::Inner::Bad_ModuleName' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'Bad module name Outer::Inner::Bad_ModuleName.'
-    end
-
-  end
-
-end

data/spec/checks/nested_iterators_check_spec.rb

@@ -1,44 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::NestedIteratorsCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::NestedIteratorsCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should reject a block inside a block' do
-      code = <<-END
-        method1 do
-          method2 do
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :block => 'block', :parent => 'block' }
-      warnings[0].line_number.should == 2
-      warnings[0].message.should     == 'block inside of block.'
-    end
-
-    it 'should accept 2 blocks inside a method that are not nested' do
-      code = <<-END
-        def method
-          method1 do
-          end
-          method2 do
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-  end
-
-end

data/spec/checks/parameter_number_check_spec.rb

@@ -1,97 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::ParameterNumberCheck do
-
-  before(:each) do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::ParameterNumberCheck.new({ :threshold => 1 }))
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept methods with less parameters than the threshold' do
-      code = <<-END
-        def zero_parameter_method
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept methods with the same number of parameters as the threshold' do
-      code = <<-END
-        def one_parameter_method(first_parameter)
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should reject methods with more parameters than the threshold' do
-      code = <<-END
-        def two_parameter_method(first_parameter, second_parameter)
-        end
-      END
-
-      verify_warning_found(code, 'two_parameter_method')
-    end
-
-    it 'should work with default values on parameters' do
-      code = <<-END
-        def two_parameter_method(first_parameter = 1, second_parameter = 2)
-        end
-      END
-
-      verify_warning_found(code, 'two_parameter_method')
-    end
-
-    it 'should work with methods defined on objects' do
-      code = <<-END
-        def object.two_parameter_method(first_parameter = 1, second_parameter = 2)
-        end
-      END
-
-      verify_warning_found(code, 'object.two_parameter_method')
-    end
-
-    it 'should work with methods defined directly on classes' do
-      code = <<-END
-        def Class.two_parameter_method(first_parameter = 1, second_parameter = 2)
-        end
-      END
-
-      verify_warning_found(code, 'Class.two_parameter_method')
-    end
-
-    it 'should reject yield calls with more parameters than the threshold' do
-      code = <<-END
-        two_parameter_method do |first_parameter, second_parameter|
-        end
-      END
-
-      verify_warning_found(code, 'block')
-    end
-
-    it 'should reject yield calls on a receiver with more parameters than the threshold' do
-      code = <<-END
-        receiver.two_parameter_method do |first_parameter, second_parameter|
-        end
-      END
-
-      verify_warning_found(code, 'block')
-    end
-
-  end
-
-  def verify_warning_found(code, name)
-    @excellent.check_code(code)
-    warnings = @excellent.warnings
-
-    warnings.should_not be_empty
-    warnings[0].info.should        == { :method => name, :parameters => 2 }
-    warnings[0].line_number.should == 1
-    warnings[0].message.should     == "#{name} has 2 parameters."
-  end
-
-end

data/spec/checks/rails/attr_accessible_check_spec.rb

@@ -1,79 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Simplabs::Excellent::Checks::Rails::AttrAccessibleCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::AttrAccessibleCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should ignore classes that are not active record models' do
-      code = <<-END
-        class Test
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should reject an active record model that does not specify attr_accessible' do
-      code = <<-END
-        class User < ActiveRecord::Base
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'User does not specify attr_accessible.'
-    end
-
-    it 'should reject an active record model that does specify attr_protected' do
-      code = <<-END
-        class User < ActiveRecord::Base
-          attr_protected :first_name
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'User does not specify attr_accessible.'
-    end
-
-    it 'should accept an active record model that does specify attr_accessible' do
-      code = <<-END
-        class User < ActiveRecord::Base
-          attr_accessible :first_name
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should also work with namespaced models' do
-      code = <<-END
-        class Backend::User < ActiveRecord::Base
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'Backend::User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'Backend::User does not specify attr_accessible.'
-    end
-
-  end
-
-end