excellent 1.7.2 → 2.0.0

data/spec/checks/empty_rescue_body_check_spec.rb

@@ -1,170 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::EmptyRescueBodyCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::EmptyRescueBodyCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept a rescue body with content and no parameter' do
-      code = <<-END
-        begin
-          call_method
-        rescue
-          puts "Recover from the call"
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept a rescue body with a return' do
-      code = <<-END
-        begin
-          call_method
-        rescue
-          return true
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it "should accept a virtual method call" do
-      code = <<-END
-        begin
-          call_method
-        rescue
-          show_error
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept a rescue body with code and a parameter' do
-      code = <<-END
-        begin
-          call_method
-        rescue Exception => e
-          puts "Recover from the call"
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept a rescue body with an assignment' do
-      code = <<-END
-        begin
-          call_method
-        rescue Exception => e
-          my_var = 1
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept a rescue body with an attribute assignment' do
-      code = <<-END
-        begin
-          call_method
-        rescue Exception => e
-          self.var = 1
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept an inline rescue statement' do
-      code = <<-END
-        value = call_method rescue 1
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept an empty array as a statement' do
-      code = <<-END
-        value = call_method rescue []
-      END
-
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept an empty hash as a statement' do
-      code = <<-END
-        value = call_method rescue {}
-      END
-
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept a boolean as a statement' do
-      code = <<-END
-        value = call_method rescue false
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept nil as a statement' do
-      code = <<-END
-        value = call_method rescue nil
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should reject an empty rescue block with no parameter' do
-      code = <<-END
-        begin
-          call_method
-        rescue
-        end
-      END
-
-      verify_warning_found(code)
-    end
-
-    it 'should reject an empty rescue block with a parameter' do
-      code = <<-END
-        begin
-          call_method
-        rescue Exception => e
-        end
-      END
-
-      verify_warning_found(code)
-    end
-
-  end
-
-  def verify_warning_found(code)
-    @excellent.check_code(code)
-    warnings = @excellent.warnings
-
-    warnings.should_not be_empty
-    warnings[0].info.should        == {}
-    warnings[0].line_number.should == 3
-    warnings[0].message.should     == 'Rescue block is empty.'
-  end
-
-end

data/spec/checks/flog_block_check_spec.rb

@@ -1,28 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::FlogBlockCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::FlogBlockCheck.new({ :threshold => 0 }))
-  end
-
-  describe '#evaluate' do
-
-    it 'should calculate the score correctly' do
-      code = <<-END
-        method_name do
-          puts 'test'
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :block => 'block', :score => 3 }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == "block has flog score of 3."
-    end
-
-  end
-
-end

data/spec/checks/flog_class_check_spec.rb

@@ -1,28 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::FlogClassCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::FlogClassCheck.new({ :threshold => 0 }))
-  end
-
-  describe '#evaluate' do
-
-    it 'should calculate the score correctly' do
-      code = <<-END
-        class User < ActiveRecord::Base
-          has_many :projects
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'User', :score => 1 }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == "User has flog score of 1."
-    end
-
-  end
-
-end

data/spec/checks/flog_method_check_spec.rb

@@ -1,46 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::FlogMethodCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::FlogMethodCheck.new({ :threshold => 0 }))
-  end
-
-  describe '#evaluate' do
-
-    it 'should calculate the score correctly' do
-      code = <<-END
-        def method_name
-          puts 'test'
-        end
-      END
-
-      verify_code_score(code, 1)
-    end
-
-    it 'should calculate the score that uses special metaprogramming methods correctly' do
-      code = <<-END
-        def method_name
-          @instance.instance_eval do
-            def some_method
-            end
-          end
-        end
-      END
-
-      verify_code_score(code, 6)
-    end
-
-  end
-
-  def verify_code_score(code, score)
-    @excellent.check_code(code)
-    warnings = @excellent.warnings
-
-    warnings.should_not be_empty
-    warnings[0].info.should        == { :method => 'method_name', :score => score }
-    warnings[0].line_number.should == 1
-    warnings[0].message.should     == "method_name has flog score of #{score}."
-  end
-
-end

data/spec/checks/for_loop_check_spec.rb

@@ -1,52 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::ForLoopCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::ForLoopCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept iterators' do
-      code = <<-END
-        [:sym1, :sym2].each do |sym|
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should reject for loops on ranges' do
-      code = <<-END
-        for i in 1..2
-        end
-      END
-
-      verify_warning_found(code)
-    end
-
-    it 'should reject for loops on enumerations' do
-      code = <<-END
-        for symbol in [:sym1, :sym2]
-        end
-      END
-
-      verify_warning_found(code)
-    end
-
-  end
-
-  def verify_warning_found(code)
-    @excellent.check_code(code)
-    warnings = @excellent.warnings
-
-    warnings.should_not be_empty
-    warnings[0].info.should        == {}
-    warnings[0].line_number.should == 1
-    warnings[0].message.should     == 'For loop used.'
-  end
-
-end

data/spec/checks/global_variable_check_spec.rb

@@ -1,66 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::GlobalVariableCheck do
-
-  before(:each) do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::GlobalVariableCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should reject global variables' do
-      code = <<-END
-        $foo = 'bar'
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :variable => 'foo' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'Global variable foo used.'
-    end
-
-    it 'should also work in modules' do
-      code = <<-END
-        module Outer
-          module Inner
-            class Class
-              $foo = 'bar'
-            end
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :variable => 'foo' }
-      warnings[0].line_number.should == 4
-      warnings[0].message.should     == 'Global variable foo used.'
-    end
-
-    it 'should also work for global variables that occur within methods' do
-      code = <<-END
-        module Outer
-          module Inner
-            class Class
-              def method
-                $foo == 'bar'
-              end
-            end
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :variable => 'foo' }
-      warnings[0].line_number.should == 5
-      warnings[0].message.should     == 'Global variable foo used.'
-    end
-
-  end
-
-end

data/spec/checks/method_line_count_check_spec.rb

@@ -1,49 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::MethodLineCountCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::MethodLineCountCheck.new({ :threshold => 2 }))
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept methods with less lines than the threshold' do
-      code = <<-END
-        def one_line_method
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should accept methods with the same number of lines as the threshold' do
-      code = <<-END
-        def two_line_method
-        end
-      END
-      @excellent.check_code(code)
-
-      @excellent.warnings.should be_empty
-    end
-
-    it 'should reject methods with more lines than the threshold' do
-      code = <<-END
-        def four_line_method
-          puts 1
-          puts 2
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :method => 'four_line_method', :count => 4 }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'four_line_method has 4 lines.'
-    end
-
-  end
-
-end