enju_biblio 0.2.5 → 0.3.0.beta.2

data/spec/models/manifestation_relationship_spec.rb

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
 describe ManifestationRelationship do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
 
 end
 

data/spec/models/manifestation_relationship_type_spec.rb

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
 describe ManifestationRelationshipType do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
 
 end
 

data/spec/models/manifestation_spec.rb

@@ -1,165 +1,164 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
-describe Manifestation, :solr => true do
+describe Manifestation, solr: true do
   fixtures :all
   before do
     Manifestation.reindex
   end
 
   it "should set year_of_publication" do
-    manifestation = FactoryBot.create(:manifestation, :pub_date => '2000')
+    manifestation = FactoryBot.create(:manifestation, pub_date: '2000')
     manifestation.year_of_publication.should eq 2000
     manifestation.date_of_publication.should eq Time.zone.parse('2000-01-01')
   end
 
   it "should set date_of_publication" do
-    manifestation = FactoryBot.create(:manifestation, :pub_date => '2000-01')
+    manifestation = FactoryBot.create(:manifestation, pub_date: '2000-01')
     manifestation.year_of_publication.should eq 2000
     manifestation.month_of_publication.should eq 1
     manifestation.date_of_publication.should eq Time.zone.parse('2000-01-01')
   end
 
   it "should set volume_number" do
-    manifestation = FactoryBot.create(:manifestation, :volume_number_string => '第1巻', :issue_number_string => '20号分冊1', :edition_string => '第3版')
+    manifestation = FactoryBot.create(:manifestation, volume_number_string: '第1巻', issue_number_string: '20号分冊1', edition_string: '第3版')
     manifestation.volume_number.should eq 1
     manifestation.issue_number.should eq 20
     manifestation.edition.should eq 3
   end
 
   it "should search title in openurl" do
-    openurl = Openurl.new({:title => "プログラミング"})
+    openurl = Openurl.new({title: "プログラミング"})
     results = openurl.search
     openurl.query_text.should eq "btitle_text:プログラミング"
     results.size.should eq 7
-    openurl = Openurl.new({:jtitle => "テスト"})
+    openurl = Openurl.new({jtitle: "テスト"})
     results = openurl.search
     results.size.should eq 3
     openurl.query_text.should eq "jtitle_text:テスト"
-    openurl = Openurl.new({:atitle => "2005"})
+    openurl = Openurl.new({atitle: "2005"})
     results = openurl.search
     results.size.should eq 1
     openurl.query_text.should eq "atitle_text:2005"
-    openurl = Openurl.new({:atitle => "テスト", :jtitle => "テスト雑誌"})
+    openurl = Openurl.new({atitle: "テスト", jtitle: "テスト雑誌"})
     results = openurl.search
     results.size.should eq 2
   end
 
   it "should search agent in openurl" do
-    openurl = Openurl.new({:aulast => "Administrator"})
+    openurl = Openurl.new({aulast: "Administrator"})
     results = openurl.search
     openurl.query_text.should eq "au_text:Administrator"
     results.size.should eq 2
-    openurl = Openurl.new({:aufirst => "名称"})
+    openurl = Openurl.new({aufirst: "名称"})
     results = openurl.search
     openurl.query_text.should eq "au_text:名称"
     results.size.should eq 1
-    openurl = Openurl.new({:au => "テスト"})
+    openurl = Openurl.new({au: "テスト"})
     results = openurl.search
     openurl.query_text.should eq "au_text:テスト"
     results.size.should eq 1
-    openurl = Openurl.new({:pub => "Administrator"})
+    openurl = Openurl.new({pub: "Administrator"})
     results = openurl.search
     openurl.query_text.should eq "publisher_text:Administrator"
     results.size.should eq 4
   end
 
   it "should search isbn in openurl" do
-    openurl = Openurl.new({:api => "openurl", :isbn => "4798"})
+    openurl = Openurl.new({api: "openurl", isbn: "4798"})
     results = openurl.search
     openurl.query_text.should eq "isbn_sm:4798*"
     results.size.should eq 2
   end
 
   it "should search issn in openurl" do
-    openurl = Openurl.new({:api => "openurl", :issn => "0913"})
+    openurl = Openurl.new({api: "openurl", issn: "0913"})
     results = openurl.search
     openurl.query_text.should eq "issn_sm:0913*"
     results.size.should eq 1
   end
 
   it "should search any in openurl" do
-    openurl = Openurl.new({:any => "テスト"})
+    openurl = Openurl.new({any: "テスト"})
     results = openurl.search
     results.size.should eq 9
   end
 
   it "should search multi in openurl" do
-    openurl = Openurl.new({:btitle => "CGI Perl プログラミング"})
+    openurl = Openurl.new({btitle: "CGI Perl プログラミング"})
     results = openurl.search
     results.size.should eq 2
-    openurl = Openurl.new({:jtitle => "テスト", :pub => "テスト"})
+    openurl = Openurl.new({jtitle: "テスト", pub: "テスト"})
     results = openurl.search
     results.size.should eq 2
   end
 
   it "shoulld get search_error in openurl" do
-    lambda{Openurl.new({:isbn => "12345678901234"})}.should raise_error(OpenurlQuerySyntaxError)
-    lambda{Openurl.new({:issn => "1234abcd"})}.should raise_error(OpenurlQuerySyntaxError)
-    lambda{Openurl.new({:aufirst => "テスト 名称"})}.should raise_error(OpenurlQuerySyntaxError)
+    lambda{Openurl.new({isbn: "12345678901234"})}.should raise_error(OpenurlQuerySyntaxError)
+    lambda{Openurl.new({issn: "1234abcd"})}.should raise_error(OpenurlQuerySyntaxError)
+    lambda{Openurl.new({aufirst: "テスト 名称"})}.should raise_error(OpenurlQuerySyntaxError)
   end
 
   it "should search in sru" do
-    sru = Sru.new({:query => "title=Ruby"})
+    sru = Sru.new({query: "title=Ruby"})
     sru.search
     sru.manifestations.size.should eq 18
     sru.manifestations.first.titles.first.should eq 'Ruby'
-    sru = Sru.new({:query => "title=^ruby"})
+    sru = Sru.new({query: "title=^ruby"})
     sru.search
     sru.manifestations.size.should eq 9
-    sru = Sru.new({:query => 'title ALL "awk sed"'})
+    sru = Sru.new({query: 'title ALL "awk sed"'})
     sru.search
     sru.manifestations.size.should eq 2
     sru.manifestations.collect{|m| m.id}.should eq [184, 116]
-    sru = Sru.new({:query => 'title ANY "ruby awk sed"'})
+    sru = Sru.new({query: 'title ANY "ruby awk sed"'})
     sru.search
     sru.manifestations.size.should eq 22
-    sru = Sru.new({:query => 'isbn=9784756137470'})
+    sru = Sru.new({query: 'isbn=9784756137470'})
     sru.search
     sru.manifestations.first.id.should eq 114
-    sru = Sru.new({:query => "creator=テスト"})
+    sru = Sru.new({query: "creator=テスト"})
     sru.search
     sru.manifestations.size.should eq 1
   end
 
   it "should search date in sru" do
-    sru = Sru.new({:query => "from = 2000-09 AND until = 2000-11-01"})
+    sru = Sru.new({query: "from = 2000-09 AND until = 2000-11-01"})
     sru.search
     sru.manifestations.size.should eq 1
     sru.manifestations.first.id.should eq 120
-    sru = Sru.new({:query => "from = 1993-02-24"})
+    sru = Sru.new({query: "from = 1993-02-24"})
     sru.search
     sru.manifestations.size.should eq 5
-    sru = Sru.new({:query => "until = 2006-08-06"})
+    sru = Sru.new({query: "until = 2006-08-06"})
     sru.search
     sru.manifestations.size.should eq 4
   end
 
   it "should accept sort_by in sru" do
-    sru = Sru.new({:query => "title=Ruby"})
-    sru.sort_by.should eq({:sort_by => 'created_at', :order => 'desc'})
-    sru = Sru.new({:query => 'title=Ruby AND sortBy="title/sort.ascending"', :sortKeys => 'creator,0', :version => '1.2'})
-    sru.sort_by.should eq({:sort_by => 'sort_title', :order => 'asc'})
-    sru = Sru.new({:query => 'title=Ruby AND sortBy="title/sort.ascending"', :sortKeys => 'creator,0', :version => '1.1'})
-    sru.sort_by.should eq({:sort_by => 'creator', :order => 'desc'})
-    sru = Sru.new({:query => 'title=Ruby AND sortBy="title/sort.ascending"', :sortKeys => 'creator,1', :version => '1.1'})
-    sru.sort_by.should eq({:sort_by => 'creator', :order => 'asc'})
-    sru = Sru.new({:query => 'title=Ruby AND sortBy="title'})
-    sru.sort_by.should eq({:sort_by => 'sort_title', :order => 'asc'})
-    #TODO ソート基準が入手しやすさの場合の処理
+    sru = Sru.new({query: "title=Ruby"})
+    sru.sort_by.should eq({sort_by: 'created_at', order: 'desc'})
+    sru = Sru.new({query: 'title=Ruby AND sortBy="title/sort.ascending"', sortKeys: 'creator,0', version: '1.2'})
+    sru.sort_by.should eq({sort_by: 'sort_title', order: 'asc'})
+    sru = Sru.new({query: 'title=Ruby AND sortBy="title/sort.ascending"', sortKeys: 'creator,0', version: '1.1'})
+    sru.sort_by.should eq({sort_by: 'creator', order: 'desc'})
+    sru = Sru.new({query: 'title=Ruby AND sortBy="title/sort.ascending"', sortKeys: 'creator,1', version: '1.1'})
+    sru.sort_by.should eq({sort_by: 'creator', order: 'asc'})
+    sru = Sru.new({query: 'title=Ruby AND sortBy="title'})
+    sru.sort_by.should eq({sort_by: 'sort_title', order: 'asc'})
+    # TODO ソート基準が入手しやすさの場合の処理
   end
 
   it "should accept ranges in sru" do
-    sru = Sru.new({:query => "from = 1993-02-24 AND until = 2006-08-06 AND title=プログラミング"})
+    sru = Sru.new({query: "from = 1993-02-24 AND until = 2006-08-06 AND title=プログラミング"})
     sru.search
     sru.manifestations.size.should eq 2
-    sru = Sru.new({:query => "until = 2000 AND title=プログラミング"})
+    sru = Sru.new({query: "until = 2000 AND title=プログラミング"})
     sru.search
     sru.manifestations.size.should eq 1
-    sru = Sru.new({:query => "from = 2006 AND title=プログラミング"})
+    sru = Sru.new({query: "from = 2006 AND title=プログラミング"})
     sru.search
     sru.manifestations.size.should eq 1
-    sru = Sru.new({:query => "from = 2007 OR title=awk"})
+    sru = Sru.new({query: "from = 2007 OR title=awk"})
     sru.search
     sru.manifestations.size.should eq 6
   end
@@ -201,7 +200,7 @@ describe Manifestation, :solr => true do
   end
 
   it "should respond to pickup" do
-    lambda{Manifestation.pickup}.should_not raise_error #(ActiveRecord::RecordNotFound)
+    lambda{Manifestation.pickup}.should_not raise_error # (ActiveRecord::RecordNotFound)
   end
 
   it "should be periodical if its series_statement is periodical" do
@@ -214,14 +213,14 @@ describe Manifestation, :solr => true do
     manifestation.should_not be_valid
   end
 
-  #it "should set series_statement if the manifestation is periodical" do
+  # it "should set series_statement if the manifestation is periodical" do
   #  manifestation = series_statements(:two).manifestations.new
   #  manifestation.set_series_statements([series_statements(:two)])
   #  #manifestation.original_title.should eq 'テスト雑誌２月号'
   #  #manifestation.serial_number.should eq 3
   #  #manifestation.issue_number.should eq 3
   #  #manifestation.volume_number.should eq 1
-  #end
+  # end
 
   context ".export" do
     it "should export a header line" do
@@ -268,6 +267,16 @@ describe Manifestation, :solr => true do
       expect(m["volume_number"]).to eq "15"
       expect(m["volume_number_string"]).to eq "Vol.15"
     end
+    it "should export multiple identifiers" do
+      manifestation = FactoryBot.create(:manifestation)
+      isbn_type = IdentifierType.where(name: :isbn).first
+      manifestation.identifiers << FactoryBot.create(:identifier, body: "978-4043898039", identifier_type: isbn_type)
+      manifestation.identifiers << FactoryBot.create(:identifier, body: "978-4840239219", identifier_type: isbn_type)
+      lines = Manifestation.export()
+      csv = CSV.parse(lines, headers: true, col_sep: "\t")
+      m = csv.find{|row| row["manifestation_id"].to_i == manifestation.id }
+      expect(m["isbn"]).to eq "9784043898039//9784840239219"
+    end
 
     it "should respect the role of the user" do
       FactoryBot.create(:item, bookstore_id: 1, price: 100, budget_type_id: 1)

data/spec/models/medium_of_performance_spec.rb

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
 describe MediumOfPerformance do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
 
 end
 

data/spec/models/own_spec.rb

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
 describe Own do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
 
 end
 

data/spec/models/picture_file_spec.rb

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
 describe PictureFile do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
 
 end
 

data/spec/models/produce_spec.rb

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
 describe Produce do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
 
 end
 

data/spec/models/realize_spec.rb

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
 describe Realize do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
 
 end
 

data/spec/models/resource_export_file_spec.rb

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
   
 describe ResourceExportFile do

data/spec/models/resource_import_file_spec.rb

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
   
 describe ResourceImportFile do
@@ -7,8 +6,11 @@ describe ResourceImportFile do
   describe "when its mode is 'create'" do
     describe "when it is written in utf-8" do
       before(:each) do
-        @file = ResourceImportFile.create resource_import: File.new("#{Rails.root.to_s}/../../examples/resource_import_file_sample1.tsv"), default_shelf_id: 3
-        @file.user = users(:admin)
+        @file = ResourceImportFile.create(
+          resource_import: File.new("#{Rails.root}/../../examples/resource_import_file_sample1.tsv"),
+          default_shelf_id: 3,
+          user: users(:admin)
+        )
       end
 
       it "should be imported", vcr: true do
@@ -16,8 +18,8 @@ describe ResourceImportFile do
         old_items_count = Item.count
         old_agents_count = Agent.count
         old_import_results_count = ResourceImportResult.count
-        @file.import_start.should eq({:manifestation_imported => 9, :item_imported => 9, :manifestation_found => 6, :item_found => 3, :failed => 7})
-        manifestation = Item.where(item_identifier: '11111').first.manifestation
+        @file.import_start.should eq({manifestation_imported: 9, item_imported: 9, manifestation_found: 6, item_found: 3, failed: 7})
+        manifestation = Item.find_by(item_identifier: '11111').manifestation
         manifestation.publishers.first.full_name.should eq 'test4'
         manifestation.publishers.first.full_name_transcription.should eq 'てすと4'
         manifestation.publishers.second.full_name_transcription.should eq 'てすと5'
@@ -30,7 +32,7 @@ describe ResourceImportFile do
         @file.resource_import_results.order(:id).first.body.split("\t").first.should eq 'manifestation_identifier'
         ResourceImportResult.count.should eq old_import_results_count + 22
 
-        manifestation_101 = Manifestation.where(manifestation_identifier: '101').first
+        manifestation_101 = Manifestation.find_by(manifestation_identifier: '101')
         manifestation_101.series_statements.count.should eq 1
         manifestation_101.series_statements.first.original_title.should eq '主シリーズ'
         manifestation_101.series_statements.first.title_transcription.should eq 'しゅしりーず'
@@ -38,7 +40,7 @@ describe ResourceImportFile do
         manifestation_101.series_statements.first.title_subseries_transcription.should eq 'ふくしりーず'
         manifestation_101.items.order(:id).last.call_number.should eq '007|A'
 
-        item_10101 = Item.where(item_identifier: '10101').first
+        item_10101 = Item.find_by(item_identifier: '10101')
         item_10101.manifestation.creators.size.should eq 2
         item_10101.manifestation.creates.order(:id).first.create_type.name.should eq 'author'
         item_10101.manifestation.creates.order(:id).second.agent.full_name.should eq 'test1'
@@ -64,7 +66,7 @@ describe ResourceImportFile do
         item_10101.manifestation.extent.should eq 'xv, 213 pages'
         item_10101.manifestation.dimensions.should eq '20cm'
 
-        item_10102 = Item.where(item_identifier: '10102').first
+        item_10102 = Item.find_by(item_identifier: '10102')
         item_10102.manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
         item_10102.manifestation.language.name.should eq 'Japanese'
         item_10102.manifestation.height.should eq 257
@@ -75,18 +77,18 @@ describe ResourceImportFile do
         item_10102.manifestation.series_statements.first.creator_string.should eq 'シリーズの著者'
         item_10102.manifestation.series_statements.first.volume_number_string.should eq 'シリーズ1号'
 
-        Manifestation.where(manifestation_identifier: '103').first.original_title.should eq 'ダブル"クォート"を含む資料'
-        item = Item.where(item_identifier: '11111').first
+        Manifestation.find_by(manifestation_identifier: '103').original_title.should eq 'ダブル"クォート"を含む資料'
+        item = Item.find_by(item_identifier: '11111')
         item.shelf.name.should eq Shelf.find(3).name
         item.manifestation.price.should eq 1000
         item.price.should eq 0
         item.manifestation.publishers.size.should eq 2
 
-        item_10103 = Item.where(item_identifier: '10103').first
+        item_10103 = Item.find_by(item_identifier: '10103')
         item_10103.budget_type.should be_nil
         item_10103.bookstore.name.should eq 'Example store'
 
-        item_10104 = Item.where(item_identifier: '10104').first
+        item_10104 = Item.find_by(item_identifier: '10104')
         item_10104.manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
         item_10104.budget_type.name.should eq 'Public fund'
         item_10104.bookstore.should be_nil
@@ -108,7 +110,7 @@ describe ResourceImportFile do
         item_10104.manifestation.subjects.order(:id).map{|s| {s.subject_heading_type.name => s.term}}.should eq [{"ndlsh" => "コンピュータ"}, {"ndlsh" => "図書館"}]
         item_10104.manifestation.classifications.order(:id).map{|c| {c.classification_type.name => c.category}}.should eq [{"ndc9" => "007"}, {"ddc" => "003"}, {"ddc" => "004"}]
 
-        manifestation_104 = Manifestation.where(manifestation_identifier: '104').first
+        manifestation_104 = Manifestation.find_by(manifestation_identifier: '104')
         manifestation_104.identifier_contents(:isbn).should eq ['9784797327038']
         manifestation_104.original_title.should eq 'test10'
         manifestation_104.creators.collect(&:full_name).should eq ['test3']
@@ -117,8 +119,8 @@ describe ResourceImportFile do
         ResourceImportResult.where(manifestation_id: manifestation_101.id).order(:id).last.error_message.should eq "line 22: #{I18n.t('import.manifestation_found')}"
         ResourceImportResult.where(item_id: item_10101.id).order(:id).last.error_message.should eq "line 9: #{I18n.t('import.item_found')}"
 
-        Item.where(item_identifier: '11113').first.manifestation.original_title.should eq 'test10'
-        Item.where(item_identifier: '11114').first.manifestation.id.should eq 1
+        Item.find_by(item_identifier: '11113').manifestation.original_title.should eq 'test10'
+        Item.find_by(item_identifier: '11114').manifestation.id.should eq 1
 
         @file.resource_import_fingerprint.should be_truthy
         @file.executed_at.should be_truthy
@@ -137,9 +139,20 @@ describe ResourceImportFile do
       it "should be searchable right after the import", solr: true, vcr: true do
         @file.import_start
         Manifestation.search{ keywords "10101" }.total.should > 0
-        Manifestation.search{ keywords "10101", :fields => [:item_identifier] }.total.should > 0
+        Manifestation.search{ keywords "10101", fields: [:item_identifier] }.total.should > 0
         Manifestation.search{ keywords "item_identifier_sm:10101" }.total.should > 0
       end
+
+      it "should import multiple ISBNs", vcr: true do
+        file = ResourceImportFile.create resource_import: StringIO.new("original_title\tisbn\noriginal_title_multiple_isbns\t978-4840239219//978-4043898039\n"), user: users(:admin)
+        result = file.import_start
+        expect(result[:manifestation_imported]).to eq 1
+        resource_import_result = file.resource_import_results.last
+        expect(resource_import_result.manifestation).not_to be_blank
+        manifestation = resource_import_result.manifestation
+        expect(manifestation.identifier_contents(:isbn)).to include("9784840239219")
+        expect(manifestation.identifier_contents(:isbn)).to include("9784043898039")
+      end
     end
 
     describe "ISBN import" do
@@ -176,10 +189,23 @@ describe ResourceImportFile do
       end
     end
 
+    describe "NDLBibID" do
+      it "should import NDLBibID", vcr: true do
+        file = ResourceImportFile.create resource_import: StringIO.new("ndl_bib_id\n000000471440\n"), user: users(:admin)
+        result = file.import_start
+        expect(result[:manifestation_imported]).to eq 1
+        resource_import_result = file.resource_import_results.last
+        manifestation = resource_import_result.manifestation
+        expect(manifestation.manifestation_identifier).to eq "http://iss.ndl.go.jp/books/R100000002-I000000471440-00"
+      end
+    end
+
     describe "when it is written in shift_jis" do
       before(:each) do
-        @file = ResourceImportFile.create resource_import: File.new("#{Rails.root.to_s}/../../examples/resource_import_file_sample2.tsv")
-        @file.user = users(:admin)
+        @file = ResourceImportFile.create!(
+          resource_import: File.new("#{Rails.root}/../../examples/resource_import_file_sample2.tsv"),
+          user: users(:admin)
+        )
       end
 
       it "should be imported", vcr: true do
@@ -187,8 +213,8 @@ describe ResourceImportFile do
         old_items_count = Item.count
         old_agents_count = Agent.count
         old_import_results_count = ResourceImportResult.count
-        @file.import_start.should eq({:manifestation_imported => 9, :item_imported => 8, :manifestation_found => 5, :item_found => 3, :failed => 7})
-        manifestation = Item.where(item_identifier: '11111').first.manifestation
+        @file.import_start.should eq({manifestation_imported: 9, item_imported: 8, manifestation_found: 5, item_found: 3, failed: 7})
+        manifestation = Item.find_by(item_identifier: '11111').manifestation
         manifestation.publishers.first.full_name.should eq 'test4'
         manifestation.publishers.first.full_name_transcription.should eq 'てすと4'
         manifestation.publishers.second.full_name_transcription.should eq 'てすと5'
@@ -196,13 +222,13 @@ describe ResourceImportFile do
         Item.count.should eq old_items_count + 8
         Agent.count.should eq old_agents_count + 9
         ResourceImportResult.count.should eq old_import_results_count + 21
-        Item.where(item_identifier: '10101').first.manifestation.creators.size.should eq 2
-        Item.where(item_identifier: '10101').first.manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
-        Item.where(item_identifier: '10102').first.manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
-        Item.where(item_identifier: '10104').first.manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
-        Manifestation.where(manifestation_identifier: '103').first.original_title.should eq 'ダブル"クォート"を含む資料'
-        item = Item.where(item_identifier: '11111').first
-        item.shelf.name.should eq Shelf.where(name: 'web').first.name
+        Item.find_by(item_identifier: '10101').manifestation.creators.size.should eq 2
+        Item.find_by(item_identifier: '10101').manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
+        Item.find_by(item_identifier: '10102').manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
+        Item.find_by(item_identifier: '10104').manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
+        Manifestation.find_by(manifestation_identifier: '103').original_title.should eq 'ダブル"クォート"を含む資料'
+        item = Item.find_by(item_identifier: '11111')
+        item.shelf.name.should eq Shelf.find_by(name: 'web').name
         item.manifestation.price.should eq 1000
         item.price.should eq 0
         item.manifestation.publishers.size.should eq 2
@@ -214,8 +240,10 @@ describe ResourceImportFile do
 
     describe "when it has only isbn" do
       before(:each) do
-        @file = ResourceImportFile.create resource_import: File.new("#{Rails.root.to_s}/../../examples/isbn_sample.txt")
-        @file.user = users(:admin)
+        @file = ResourceImportFile.create!(
+          resource_import: File.new("#{Rails.root}/../../examples/isbn_sample.txt"),
+          user: users(:admin)
+        )
       end
 
       it "should be imported", vcr: true do
@@ -234,8 +262,10 @@ describe ResourceImportFile do
 original_title	call_number	item_note
 resource_import_file_test1	007.6	note for the item.
         EOF
-        file = ResourceImportFile.create(resource_import: StringIO.new(import_file))
-        file.user = users(:admin)
+        file = ResourceImportFile.create(
+          resource_import: StringIO.new(import_file),
+          user: users(:admin)
+        )
         old_manifestations_count = Manifestation.count
         old_items_count = Item.count
         result = file.import_start
@@ -253,8 +283,10 @@ resource_import_file_test1	007.6	note for the item.
 original_title	edition	edition_string
 resource_import_file_test_edition	2	Revised Ed.
         EOF
-        file = ResourceImportFile.create(resource_import: StringIO.new(import_file))
-        file.user = users(:admin)
+        file = ResourceImportFile.create(
+          resource_import: StringIO.new(import_file),
+          user: users(:admin)
+        )
         old_manifestations_count = Manifestation.count
         result = file.import_start
         expect(Manifestation.count).to eq old_manifestations_count + 1
@@ -269,8 +301,10 @@ resource_import_file_test_edition	2	Revised Ed.
 original_title	title_transcription
 resource_import_file_test_transcription	transcription
         EOF
-        file = ResourceImportFile.create(resource_import: StringIO.new(import_file))
-        file.user = users(:admin)
+        file = ResourceImportFile.create(
+          resource_import: StringIO.new(import_file),
+          user: users(:admin)
+        )
         old_manifestations_count = Manifestation.count
         result = file.import_start
         expect(Manifestation.count).to eq old_manifestations_count + 1
@@ -285,15 +319,16 @@ resource_import_file_test_transcription	transcription
 original_title	description	note	call_number	item_note
 resource_import_file_test_description	test\\ntest	test\\ntest	test_description	test\\ntest
         EOF
-        file = ResourceImportFile.create(resource_import: StringIO.new(import_file))
-        file.user = users(:admin)
+        file = ResourceImportFile.create(
+          resource_import: StringIO.new(import_file),
+          user: users(:admin)
+        )
         old_manifestations_count = Manifestation.count
         result = file.import_start
         expect(Manifestation.count).to eq old_manifestations_count + 1
         manifestation = Manifestation.all.find{|m| m.original_title == "resource_import_file_test_description" }
         expect(manifestation.description).to eq "test\ntest"
         expect(manifestation.note).to eq "test\ntest"
-        p manifestation.items
         expect(manifestation.items.first.note).to eq "test\ntest"
       end
     end
@@ -301,40 +336,44 @@ resource_import_file_test_description	test\\ntest	test\\ntest	test_description	t
 
   describe "when its mode is 'update'" do
     it "should update items", vcr: true do
-      @file = ResourceImportFile.create resource_import: File.new("#{Rails.root.to_s}/../../examples/item_update_file.tsv"), edit_mode: 'update'
-      @file.modify
-      expect(@file.resource_import_results.first).to be_truthy
-      expect(@file.resource_import_results.first.body).to match /item_identifier/
-      item_00001 = Item.where(item_identifier: '00001').first
+      file = ResourceImportFile.create!(
+        resource_import: File.new("#{Rails.root}/../../examples/item_update_file.tsv"),
+        user: users(:admin),
+        edit_mode: 'update'
+      )
+      file.modify
+      expect(file.resource_import_results.first).to be_truthy
+      expect(file.resource_import_results.first.body).to match /item_identifier/
+      item_00001 = Item.find_by(item_identifier: '00001')
       item_00001.manifestation.creators.order('agents.id').collect(&:full_name).should eq ['たなべ', 'こうすけ']
       item_00001.binding_item_identifier.should eq '900001'
       item_00001.binding_call_number.should eq '336|A'
       item_00001.binded_at.should eq Time.zone.parse('2014-08-16')
       item_00001.manifestation.subjects.order(:id).map{|subject| {subject.subject_heading_type.name => subject.term}}.should eq [{"ndlsh" => "test1"}, {"ndlsh" => "test2"}]
       item_00001.manifestation.identifier_contents(:isbn).should eq ["4798002062", "12345678"]
-      Item.where(item_identifier: '00002').first.manifestation.publishers.collect(&:full_name).should eq ['test2']
+      Item.find_by(item_identifier: '00002').manifestation.publishers.collect(&:full_name).should eq ['test2']
 
-      item_00003 = Item.where(item_identifier: '00003').first
+      item_00003 = Item.find_by(item_identifier: '00003')
       item_00003.acquired_at.should eq Time.zone.parse('2012-01-01')
       item_00003.include_supplements.should be_truthy
 
-      Item.where(item_identifier: '00004').first.include_supplements.should be_falsy
-      Item.where(item_identifier: '00025').first.call_number.should eq "547|ヤ"
+      Item.find_by(item_identifier: '00004').include_supplements.should be_falsy
+      Item.find_by(item_identifier: '00025').call_number.should eq "547|ヤ"
     end
 
-    #it "should update series_statement", vcr: true do
+    # it "should update series_statement", vcr: true do
     #  manifestation = Manifestation.find(10)
     #  file = ResourceImportFile.create resource_import: File.new("#{Rails.root.to_s}/../../examples/update_series_statement.tsv"), edit_mode: 'update'
     #  file.modify
     #  manifestation.reload
     #  manifestation.series_statements.should eq [SeriesStatement.find(2)]
-    #end
+    # end
 
     describe "NCID import" do
       it "should import ncid value" do
         file = ResourceImportFile.create resource_import: StringIO.new("manifestation_id\tncid\n1\tBA67656964\n"), user: users(:admin), edit_mode: 'update'
         result = file.import_start
-        #expect(result[:manifestation_found]).to eq 1
+        # expect(result[:manifestation_found]).to eq 1
         expect(file.error_message).to be_nil
         resource_import_result = file.resource_import_results.last
         expect(resource_import_result.error_message).to be_blank
@@ -348,16 +387,21 @@ resource_import_file_test_description	test\\ntest	test\\ntest	test_description	t
   describe "when its mode is 'destroy'" do
     it "should remove items", vcr: true do
       old_count = Item.count
-      @file = ResourceImportFile.create resource_import: File.new("#{Rails.root.to_s}/../../examples/item_delete_file.tsv"), edit_mode: 'destroy'
-      @file.remove
+      file = ResourceImportFile.create!(
+        resource_import: File.new("#{Rails.root}/../../examples/item_delete_file.tsv"),
+        user: users(:admin),
+        edit_mode: 'destroy'
+      )
+      file.remove
       Item.count.should eq old_count - 2
     end
   end
 
   it "should import in background", vcr: true do
-    file = ResourceImportFile.create resource_import: File.new("#{Rails.root.to_s}/../../examples/resource_import_file_sample1.tsv")
-    file.user = users(:admin)
-    file.save
+    file = ResourceImportFile.create!(
+      resource_import: File.new("#{Rails.root}/../../examples/resource_import_file_sample1.tsv"),
+      user: users(:admin)
+    )
     ResourceImportFileJob.perform_later(file).should be_truthy
   end
 end