enju_biblio 0.2.5 → 0.3.0.beta.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 602b8c263c907d28748c84402650976d1146392e
-  data.tar.gz: baa96bc8efbf265dad0ea1164de3b5113838720d
+  metadata.gz: 25fc5c4cd37ac1cc66f8f33fbfb55693805d0240
+  data.tar.gz: 3b2d80afdf3fe2daab6b5a1a5ce9b990f28483d1
 SHA512:
-  metadata.gz: 91eb7ab31bc0e35f5f7d3403d599b9e1f0b01ed7a800d15ca798ff71b6327bd0f6bcc263909e2cb3361d4553a7c10dfc05455c74f61a638a57b1b0ea27ad7c5b
-  data.tar.gz: 88d933b451e126316fedf8fe2991910dfbb2a519f7da841a25c912379bf34824693842eb5724d2f5fb8c046d59f9fef3ccf8fb1f35bd60901c406678c8771f06
+  metadata.gz: '0692545023822f16ca689ed781bf409af492e05569306781cd9d8c6de88a85465d1d62346a07b348de8cf4a10c61ca1292f2d4bef9148908b90fbdd0bd817a91'
+  data.tar.gz: e1a387efd4e521e86a392ca68e008fcd3459c8a814b390fc101bdc14f99c38c3164f909fe17dd9c7db2dac891a94e9bdc3c8fe98b8c126b4f29fed94b5034979

data/README.rdoc

@@ -1,7 +1,7 @@
 = EnjuBiblio
-{<img src="https://travis-ci.org/next-l/enju_biblio.svg?branch=1.2" alt="Build Status" />}[https://travis-ci.org/next-l/enju_biblio]
-{<img src="https://coveralls.io/repos/next-l/enju_biblio/badge.svg?branch=1.2&service=github" alt="Coverage Status" />}[https://coveralls.io/github/next-l/enju_biblio?branch=1.2]
-{<img src="https://hakiri.io/github/next-l/enju_biblio/1.2.svg" alt="security" />}[https://hakiri.io/github/next-l/enju_biblio/1.2]
+{<img src="https://travis-ci.org/next-l/enju_biblio.svg?branch=1.3" alt="Build Status" />}[https://travis-ci.org/next-l/enju_biblio]
+{<img src="https://coveralls.io/repos/next-l/enju_biblio/badge.svg?branch=1.3&service=github" alt="Coverage Status" />}[https://coveralls.io/github/next-l/enju_biblio?branch=1.3]
+{<img src="https://hakiri.io/github/next-l/enju_biblio/1.3.svg" alt="security" />}[https://hakiri.io/github/next-l/enju_biblio/1.3]
 
 This project rocks and uses MIT-LICENSE.
 

data/Rakefile

@@ -43,4 +43,4 @@ RSpec::Core::RakeTask.new(:spec) do |spec|
     spec.pattern = FileList['spec/**/*_spec.rb']
 end
 
-task :default => :spec
+task default: :spec

data/app/controllers/agent_import_files_controller.rb

@@ -74,7 +74,7 @@ class AgentImportFilesController < ApplicationController
   # PUT /agent_import_files/1.json
   def update
     respond_to do |format|
-      if @agent_import_file.update_attributes(agent_import_file_params)
+      if @agent_import_file.update(agent_import_file_params)
         if @agent_import_file.mode == 'import'
           AgentImportFileJob.perform_later(@agent_import_file)
         end

data/app/controllers/agent_merge_lists_controller.rb

@@ -58,7 +58,7 @@ class AgentMergeListsController < ApplicationController
   # PUT /agent_merge_lists/1.json
   def update
     respond_to do |format|
-      if @agent_merge_list.update_attributes(agent_merge_list_params)
+      if @agent_merge_list.update(agent_merge_list_params)
         if params[:mode] == 'merge'
           selected_agent = Agent.where(id: params[:selected_agent_id]).first
           if selected_agent

data/app/controllers/agent_merges_controller.rb

@@ -65,7 +65,7 @@ class AgentMergesController < ApplicationController
   # PUT /agent_merges/1.json
   def update
     respond_to do |format|
-      if @agent_merge.update_attributes(agent_merge_params)
+      if @agent_merge.update(agent_merge_params)
         format.html { redirect_to(@agent_merge, notice: t('controller.successfully_updated', model: t('activerecord.models.agent_merge'))) }
         format.json { head :no_content }
       else

data/app/controllers/agent_relationship_types_controller.rb

@@ -62,7 +62,7 @@ class AgentRelationshipTypesController < ApplicationController
     end
 
     respond_to do |format|
-      if @agent_relationship_type.update_attributes(agent_relationship_type_params)
+      if @agent_relationship_type.update(agent_relationship_type_params)
         format.html { redirect_to @agent_relationship_type, notice: t('controller.successfully_updated', model: t('activerecord.models.agent_relationship_type')) }
         format.json { head :no_content }
       else

data/app/controllers/agent_relationships_controller.rb

@@ -72,7 +72,7 @@ class AgentRelationshipsController < ApplicationController
     end
 
     respond_to do |format|
-      if @agent_relationship.update_attributes(agent_relationship_params)
+      if @agent_relationship.update(agent_relationship_params)
         format.html { redirect_to @agent_relationship, notice: t('controller.successfully_updated', model: t('activerecord.models.agent_relationship')) }
         format.json { head :no_content }
       else

data/app/controllers/agent_types_controller.rb

@@ -62,7 +62,7 @@ class AgentTypesController < ApplicationController
     end
 
     respond_to do |format|
-      if @agent_type.update_attributes(agent_type_params)
+      if @agent_type.update(agent_type_params)
         format.html { redirect_to @agent_type, notice: t('controller.successfully_updated', model: t('activerecord.models.agent_type')) }
         format.json { head :no_content }
       else

data/app/controllers/agents_controller.rb

@@ -41,7 +41,7 @@ class AgentsController < ApplicationController
     if params[:mode] == 'recent'
       query = "#{query} created_at_d:[NOW-1MONTH TO NOW]"
     end
-    unless query.blank?
+    if query.present?
       search.build do
         fulltext query
       end
@@ -175,7 +175,7 @@ class AgentsController < ApplicationController
   # PUT /agents/1.json
   def update
     respond_to do |format|
-      if @agent.update_attributes(agent_params)
+      if @agent.update(agent_params)
         format.html { redirect_to @agent, notice: t('controller.successfully_updated', model: t('activerecord.models.agent')) }
         format.json { head :no_content }
       else

data/app/controllers/carrier_types_controller.rb

@@ -80,7 +80,7 @@ class CarrierTypesController < ApplicationController
     end
 
     respond_to do |format|
-      if @carrier_type.update_attributes(carrier_type_params)
+      if @carrier_type.update(carrier_type_params)
         format.html { redirect_to @carrier_type, notice: t('controller.successfully_updated', model: t('activerecord.models.carrier_type')) }
         format.json { head :no_content }
       else
@@ -118,7 +118,7 @@ class CarrierTypesController < ApplicationController
       :attachment,
       # EnjuCirculation
       {
-        :carrier_type_has_checkout_types_attributes => [
+        carrier_type_has_checkout_types_attributes: [
           :id, :checkout_type_id, :_destroy
         ]
       }

data/app/controllers/concerns/enju_biblio/controller.rb

@@ -71,23 +71,23 @@ module EnjuBiblio
           with(:publisher_ids).equal_to agent.id if agent
           with(:original_manifestation_ids).equal_to manifestation.id if manifestation
           with(:reservable).equal_to reservable unless reservable.nil?
-          unless carrier_type.blank?
+          if carrier_type.present?
             with(:carrier_type).equal_to carrier_type
           end
-          unless library.blank?
+          if library.present?
             library_list = library.split.uniq
             library_list.each do |lib|
               with(:library).equal_to lib
             end
           end
-          unless language.blank?
+          if language.present?
             language_list = language.split.uniq
             language_list.each do |language|
               with(:language).equal_to language
             end
           end
           if defined?(EnjuSubject)
-            unless subject.blank?
+            if subject.present?
               with(:subject).equal_to subject_by_term.term
             end
           end

data/app/controllers/content_types_controller.rb

@@ -62,7 +62,7 @@ class ContentTypesController < ApplicationController
     end
 
     respond_to do |format|
-      if @content_type.update_attributes(content_type_params)
+      if @content_type.update(content_type_params)
         format.html { redirect_to @content_type, notice: t('controller.successfully_updated', model: t('activerecord.models.content_type')) }
         format.json { head :no_content }
       else

data/app/controllers/countries_controller.rb

@@ -62,7 +62,7 @@ class CountriesController < ApplicationController
     end
 
     respond_to do |format|
-      if @country.update_attributes(country_params)
+      if @country.update(country_params)
         format.html { redirect_to @country, notice: t('controller.successfully_updated', model: t('activerecord.models.country')) }
         format.json { head :no_content }
       else

data/app/controllers/create_types_controller.rb

@@ -62,7 +62,7 @@ class CreateTypesController < ApplicationController
     end
 
     respond_to do |format|
-      if @create_type.update_attributes(create_type_params)
+      if @create_type.update(create_type_params)
         format.html { redirect_to @create_type, notice: t('controller.successfully_updated', model: t('activerecord.models.create_type')) }
         format.json { head :no_content }
       else

data/app/controllers/creates_controller.rb

@@ -78,7 +78,7 @@ class CreatesController < ApplicationController
     end
 
     respond_to do |format|
-      if @create.update_attributes(create_params)
+      if @create.update(create_params)
         format.html { redirect_to @create, notice: t('controller.successfully_updated', model: t('activerecord.models.create')) }
         format.json { head :no_content }
       else

data/app/controllers/donates_controller.rb

@@ -57,7 +57,7 @@ class DonatesController < ApplicationController
   # PUT /donates/1.json
   def update
     respond_to do |format|
-      if @donate.update_attributes(donate_params)
+      if @donate.update(donate_params)
         format.html { redirect_to @donate, notice: t('controller.successfully_updated', model: t('activerecord.models.donate')) }
         format.json { head :no_content }
       else

data/app/controllers/form_of_works_controller.rb

@@ -62,7 +62,7 @@ class FormOfWorksController < ApplicationController
     end
 
     respond_to do |format|
-      if @form_of_work.update_attributes(form_of_work_params)
+      if @form_of_work.update(form_of_work_params)
         format.html { redirect_to @form_of_work, notice: t('controller.successfully_updated', model: t('activerecord.models.form_of_work')) }
         format.json { head :no_content }
       else

data/app/controllers/frequencies_controller.rb

@@ -62,7 +62,7 @@ class FrequenciesController < ApplicationController
     end
 
     respond_to do |format|
-      if @frequency.update_attributes(frequency_params)
+      if @frequency.update(frequency_params)
         format.html { redirect_to @frequency, notice: t('controller.successfully_updated', model: t('activerecord.models.frequency')) }
         format.json { head :no_content }
       else

data/app/controllers/identifier_types_controller.rb

@@ -62,7 +62,7 @@ class IdentifierTypesController < ApplicationController
     end
 
     respond_to do |format|
-      if @identifier_type.update_attributes(identifier_type_params)
+      if @identifier_type.update(identifier_type_params)
         format.html { redirect_to @identifier_type, notice: t('controller.successfully_updated', model: t('activerecord.models.identifier_type')) }
         format.json { head :no_content }
       else

data/app/controllers/import_requests_controller.rb

@@ -77,7 +77,7 @@ class ImportRequestsController < ApplicationController
   # PUT /import_requests/1.json
   def update
     respond_to do |format|
-      if @import_request.update_attributes(import_request_params)
+      if @import_request.update(import_request_params)
         @import_request.import!
         format.html { redirect_to @import_request, notice: t('controller.successfully_updated', model: t('activerecord.models.import_request')) }
         format.json { head :no_content }

data/app/controllers/items_controller.rb

@@ -54,7 +54,7 @@ class ItemsController < ApplicationController
       set_role_query(current_user, search)
 
       @query = query.dup
-      unless query.blank?
+      if query.present?
         search.build do
           fulltext query
         end
@@ -226,7 +226,7 @@ class ItemsController < ApplicationController
   # PUT /items/1.json
   def update
     respond_to do |format|
-      if @item.update_attributes(item_params)
+      if @item.update(item_params)
         format.html { redirect_to @item, notice: t('controller.successfully_updated', model: t('activerecord.models.item')) }
         format.json { head :no_content }
       else
@@ -273,7 +273,7 @@ class ItemsController < ApplicationController
       :lock_version, :manifestation_id, :library_id, :required_role_id,
       :binding_item_identifier, :binding_call_number, :binded_at,
       :use_restriction_id,
-      :item_has_use_restriction_attributes => :use_restriction_id # EnjuCirculation
+      item_has_use_restriction_attributes: :use_restriction_id # EnjuCirculation
     )
   end
 

data/app/controllers/languages_controller.rb

@@ -62,7 +62,7 @@ class LanguagesController < ApplicationController
     end
 
     respond_to do |format|
-      if @language.update_attributes(language_params)
+      if @language.update(language_params)
         format.html { redirect_to @language, notice: t('controller.successfully_updated', model: t('activerecord.models.language')) }
         format.json { head :no_content }
       else

data/app/controllers/licenses_controller.rb

@@ -62,7 +62,7 @@ class LicensesController < ApplicationController
     end
 
     respond_to do |format|
-      if @license.update_attributes(license_params)
+      if @license.update(license_params)
         format.html { redirect_to @license, notice: t('controller.successfully_updated', model: t('activerecord.models.license')) }
         format.json { head :no_content }
       else

data/app/controllers/manifestation_relationship_types_controller.rb

@@ -62,7 +62,7 @@ class ManifestationRelationshipTypesController < ApplicationController
     end
 
     respond_to do |format|
-      if @manifestation_relationship_type.update_attributes(manifestation_relationship_type_params)
+      if @manifestation_relationship_type.update(manifestation_relationship_type_params)
         format.html { redirect_to @manifestation_relationship_type, notice: t('controller.successfully_updated', model: t('activerecord.models.manifestation_relationship_type')) }
         format.json { head :no_content }
       else

data/app/controllers/manifestation_relationships_controller.rb

@@ -72,7 +72,7 @@ class ManifestationRelationshipsController < ApplicationController
     end
 
     respond_to do |format|
-      if @manifestation_relationship.update_attributes(manifestation_relationship_params)
+      if @manifestation_relationship.update(manifestation_relationship_params)
         format.html { redirect_to @manifestation_relationship, notice: t('controller.successfully_updated', model: t('activerecord.models.manifestation_relationship')) }
         format.json { head :no_content }
       else

data/app/controllers/manifestations_controller.rb

@@ -92,7 +92,7 @@ class ManifestationsController < ApplicationController
       end
 
       search.build do
-        fulltext query unless query.blank?
+        fulltext query if query.present?
         order_by sort[:sort_by], sort[:order]
         if defined?(EnjuSubject)
           with(:subject_ids).equal_to subject.id if subject
@@ -430,7 +430,7 @@ class ManifestationsController < ApplicationController
   def update
     creators_params = manifestation_params[:creators_attributes]
     Manifestation.transaction do
-      @manifestation.update_attributes(manifestation_params.delete_if{|k, v|
+      @manifestation.update(manifestation_params.delete_if{|k, v|
         k == 'creators_attributes'
       })
       @manifestation.creators = Agent.new_agents(creators_params)
@@ -492,7 +492,7 @@ class ManifestationsController < ApplicationController
       :dimensions, :fulltext_content, :extent,
       :parent_id,
       :serial, :statement_of_responsibility,
-      {:creators_attributes => [
+      {creators_attributes: [
         :id, :last_name, :middle_name, :first_name,
         :last_name_transcription, :middle_name_transcription,
         :first_name_transcription, :corporate_name,
@@ -504,7 +504,7 @@ class ManifestationsController < ApplicationController
         :agent_identifier, :agent_id,
         :_destroy
       ]},
-      {:contributors_attributes => [
+      {contributors_attributes: [
         :id, :last_name, :middle_name, :first_name,
         :last_name_transcription, :middle_name_transcription,
         :first_name_transcription, :corporate_name,
@@ -516,7 +516,7 @@ class ManifestationsController < ApplicationController
         :agent_identifier,
         :_destroy
       ]},
-      {:publishers_attributes => [
+      {publishers_attributes: [
         :id, :last_name, :middle_name, :first_name,
         :last_name_transcription, :middle_name_transcription,
         :first_name_transcription, :corporate_name,
@@ -528,23 +528,23 @@ class ManifestationsController < ApplicationController
         :agent_identifier,
         :_destroy
       ]},
-      {:series_statements_attributes => [
+      {series_statements_attributes: [
         :id, :original_title, :numbering, :title_subseries,
         :numbering_subseries, :title_transcription, :title_alternative,
         :title_subseries_transcription, :creator_string, :volume_number_string,
         :volume_number_transcription_string, :series_master,
         :_destroy
       ]},
-      {:subjects_attributes => [
+      {subjects_attributes: [
         :id, :parent_id, :use_term_id, :term, :term_transcription,
         :subject_type_id, :note, :required_role_id, :subject_heading_type_id,
         :_destroy
       ]},
-      {:classifications_attributes => [
+      {classifications_attributes: [
         :id, :parent_id, :category, :note, :classification_type_id,
         :_destroy
       ]},
-      {:identifiers_attributes => [
+      {identifiers_attributes: [
         :id, :body, :identifier_type_id,
         :_destroy
       ]}
@@ -567,7 +567,7 @@ class ManifestationsController < ApplicationController
     #  query = "#{query} carrier_type_s:#{options[:carrier_type]}"
     #end
 
-    unless options[:library_adv].blank?
+    if options[:library_adv].present?
       library_list = options[:library_adv].split.uniq.join(' OR ')
       query = "#{query} library_sm:(#{library_list})"
     end
@@ -578,7 +578,7 @@ class ManifestationsController < ApplicationController
         shelf_list << "#{library_name}_#{shelf}"
       end
     end
-    unless shelf_list.blank?
+    if shelf_list.present?
       query += " shelf_sm:(#{shelf_list.join(" OR ")})"
     end
 
@@ -586,10 +586,10 @@ class ManifestationsController < ApplicationController
     #  query = "#{query} language_sm:#{options[:language]}"
     #end
 
-    unless options[:subject].blank?
+    if options[:subject].present?
       query = "#{query} subject_sm:#{options[:subject]}"
     end
-    unless options[:subject_text].blank?
+    if options[:subject_text].present?
       query = "#{query} subject_text:#{options[:subject_text]}"
     end
     if options[:classification].present? and options[:classification_type].present?

data/app/controllers/medium_of_performances_controller.rb

@@ -62,7 +62,7 @@ class MediumOfPerformancesController < ApplicationController
     end
 
     respond_to do |format|
-      if @medium_of_performance.update_attributes(medium_of_performance_params)
+      if @medium_of_performance.update(medium_of_performance_params)
         format.html { redirect_to @medium_of_performance, notice: t('controller.successfully_updated', model: t('activerecord.models.medium_of_performance')) }
         format.json { head :no_content }
       else

data/app/controllers/owns_controller.rb

@@ -74,7 +74,7 @@ class OwnsController < ApplicationController
     end
 
     respond_to do |format|
-      if @own.update_attributes(own_params)
+      if @own.update(own_params)
         format.html { redirect_to @own, notice: t('controller.successfully_updated', model: t('activerecord.models.own')) }
         format.json { head :no_content }
       else

data/app/controllers/picture_files_controller.rb

@@ -116,7 +116,7 @@ class PictureFilesController < ApplicationController
     end
 
     respond_to do |format|
-      if @picture_file.update_attributes(picture_file_params)
+      if @picture_file.update(picture_file_params)
         format.html { redirect_to @picture_file, notice: t('controller.successfully_updated', model: t('activerecord.models.picture_file')) }
         format.json { head :no_content }
       else

data/app/controllers/produce_types_controller.rb

@@ -62,7 +62,7 @@ class ProduceTypesController < ApplicationController
     end
 
     respond_to do |format|
-      if @produce_type.update_attributes(produce_type_params)
+      if @produce_type.update(produce_type_params)
         format.html { redirect_to @produce_type, notice: t('controller.successfully_updated', model: t('activerecord.models.produce_type')) }
         format.json { head :no_content }
       else