enju_biblio 0.2.5 → 0.3.0.beta.2

data/spec/controllers/manifestation_relationships_controller_spec.rb

@@ -55,7 +55,7 @@ describe ManifestationRelationshipsController do
 
       it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
         manifestation_relationship = FactoryBot.create(:manifestation_relationship)
-        get :show, id: manifestation_relationship.id
+        get :show, params: { id: manifestation_relationship.id }
         expect(assigns(:manifestation_relationship)).to eq(manifestation_relationship)
       end
     end
@@ -65,7 +65,7 @@ describe ManifestationRelationshipsController do
 
       it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
         manifestation_relationship = FactoryBot.create(:manifestation_relationship)
-        get :show, id: manifestation_relationship.id
+        get :show, params: { id: manifestation_relationship.id }
         expect(assigns(:manifestation_relationship)).to eq(manifestation_relationship)
       end
     end
@@ -75,7 +75,7 @@ describe ManifestationRelationshipsController do
 
       it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
         manifestation_relationship = FactoryBot.create(:manifestation_relationship)
-        get :show, id: manifestation_relationship.id
+        get :show, params: { id: manifestation_relationship.id }
         expect(assigns(:manifestation_relationship)).to eq(manifestation_relationship)
       end
     end
@@ -83,7 +83,7 @@ describe ManifestationRelationshipsController do
     describe 'When not logged in' do
       it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
         manifestation_relationship = FactoryBot.create(:manifestation_relationship)
-        get :show, id: manifestation_relationship.id
+        get :show, params: { id: manifestation_relationship.id }
         expect(assigns(:manifestation_relationship)).to eq(manifestation_relationship)
       end
     end
@@ -135,7 +135,7 @@ describe ManifestationRelationshipsController do
 
       it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
         manifestation_relationship = FactoryBot.create(:manifestation_relationship)
-        get :edit, id: manifestation_relationship.id
+        get :edit, params: { id: manifestation_relationship.id }
         expect(assigns(:manifestation_relationship)).to eq(manifestation_relationship)
       end
     end
@@ -145,7 +145,7 @@ describe ManifestationRelationshipsController do
 
       it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
         manifestation_relationship = FactoryBot.create(:manifestation_relationship)
-        get :edit, id: manifestation_relationship.id
+        get :edit, params: { id: manifestation_relationship.id }
         expect(assigns(:manifestation_relationship)).to eq(manifestation_relationship)
       end
     end
@@ -155,7 +155,7 @@ describe ManifestationRelationshipsController do
 
       it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
         manifestation_relationship = FactoryBot.create(:manifestation_relationship)
-        get :edit, id: manifestation_relationship.id
+        get :edit, params: { id: manifestation_relationship.id }
         expect(response).to be_forbidden
       end
     end
@@ -163,7 +163,7 @@ describe ManifestationRelationshipsController do
     describe 'When not logged in' do
       it 'should not assign the requested manifestation_relationship as @manifestation_relationship' do
         manifestation_relationship = FactoryBot.create(:manifestation_relationship)
-        get :edit, id: manifestation_relationship.id
+        get :edit, params: { id: manifestation_relationship.id }
         expect(response).to redirect_to(new_user_session_url)
       end
     end
@@ -180,24 +180,24 @@ describe ManifestationRelationshipsController do
 
       describe 'with valid params' do
         it 'assigns a newly created manifestation_relationship as @manifestation_relationship' do
-          post :create, manifestation_relationship: @attrs
+          post :create, params: { manifestation_relationship: @attrs }
           expect(assigns(:manifestation_relationship)).to be_valid
         end
 
         it 'redirects to the created manifestation' do
-          post :create, manifestation_relationship: @attrs
+          post :create, params: { manifestation_relationship: @attrs }
           expect(response).to redirect_to(assigns(:manifestation_relationship))
         end
       end
 
       describe 'with invalid params' do
         it 'assigns a newly created but unsaved manifestation_relationship as @manifestation_relationship' do
-          post :create, manifestation_relationship: @invalid_attrs
+          post :create, params: { manifestation_relationship: @invalid_attrs }
           expect(assigns(:manifestation_relationship)).not_to be_valid
         end
 
         it "re-renders the 'new' template" do
-          post :create, manifestation_relationship: @invalid_attrs
+          post :create, params: { manifestation_relationship: @invalid_attrs }
           expect(response).to render_template('new')
         end
       end
@@ -208,24 +208,24 @@ describe ManifestationRelationshipsController do
 
       describe 'with valid params' do
         it 'assigns a newly created manifestation_relationship as @manifestation_relationship' do
-          post :create, manifestation_relationship: @attrs
+          post :create, params: { manifestation_relationship: @attrs }
           expect(assigns(:manifestation_relationship)).to be_valid
         end
 
         it 'redirects to the created manifestation' do
-          post :create, manifestation_relationship: @attrs
+          post :create, params: { manifestation_relationship: @attrs }
           expect(response).to redirect_to(assigns(:manifestation_relationship))
         end
       end
 
       describe 'with invalid params' do
         it 'assigns a newly created but unsaved manifestation_relationship as @manifestation_relationship' do
-          post :create, manifestation_relationship: @invalid_attrs
+          post :create, params: { manifestation_relationship: @invalid_attrs }
           expect(assigns(:manifestation_relationship)).not_to be_valid
         end
 
         it "re-renders the 'new' template" do
-          post :create, manifestation_relationship: @invalid_attrs
+          post :create, params: { manifestation_relationship: @invalid_attrs }
           expect(response).to render_template('new')
         end
       end
@@ -236,24 +236,24 @@ describe ManifestationRelationshipsController do
 
       describe 'with valid params' do
         it 'assigns a newly created manifestation_relationship as @manifestation_relationship' do
-          post :create, manifestation_relationship: @attrs
+          post :create, params: { manifestation_relationship: @attrs }
           expect(assigns(:manifestation_relationship)).to be_nil
         end
 
         it 'should be forbidden' do
-          post :create, manifestation_relationship: @attrs
+          post :create, params: { manifestation_relationship: @attrs }
           expect(response).to be_forbidden
         end
       end
 
       describe 'with invalid params' do
         it 'assigns a newly created but unsaved manifestation_relationship as @manifestation_relationship' do
-          post :create, manifestation_relationship: @invalid_attrs
+          post :create, params: { manifestation_relationship: @invalid_attrs }
           expect(assigns(:manifestation_relationship)).to be_nil
         end
 
         it 'should be forbidden' do
-          post :create, manifestation_relationship: @invalid_attrs
+          post :create, params: { manifestation_relationship: @invalid_attrs }
           expect(response).to be_forbidden
         end
       end
@@ -262,24 +262,24 @@ describe ManifestationRelationshipsController do
     describe 'When not logged in' do
       describe 'with valid params' do
         it 'assigns a newly created manifestation_relationship as @manifestation_relationship' do
-          post :create, manifestation_relationship: @attrs
+          post :create, params: { manifestation_relationship: @attrs }
           expect(assigns(:manifestation_relationship)).to be_nil
         end
 
         it 'should be forbidden' do
-          post :create, manifestation_relationship: @attrs
+          post :create, params: { manifestation_relationship: @attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
 
       describe 'with invalid params' do
         it 'assigns a newly created but unsaved manifestation_relationship as @manifestation_relationship' do
-          post :create, manifestation_relationship: @invalid_attrs
+          post :create, params: { manifestation_relationship: @invalid_attrs }
           expect(assigns(:manifestation_relationship)).to be_nil
         end
 
         it 'should be forbidden' do
-          post :create, manifestation_relationship: @invalid_attrs
+          post :create, params: { manifestation_relationship: @invalid_attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
@@ -298,24 +298,24 @@ describe ManifestationRelationshipsController do
 
       describe 'with valid params' do
         it 'updates the requested manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs }
         end
 
         it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs }
           expect(assigns(:manifestation_relationship)).to eq(@manifestation_relationship)
           expect(response).to redirect_to(@manifestation_relationship)
         end
 
         it 'moves its position when specified' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs, move: 'lower', manifestation_id: @manifestation_relationship.parent.id
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs, move: 'lower', manifestation_id: @manifestation_relationship.parent.id }
           expect(response).to redirect_to(manifestation_relationships_url(manifestation_id: @manifestation_relationship.parent_id))
         end
       end
 
       describe 'with invalid params' do
         it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @invalid_attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @invalid_attrs }
           expect(response).to render_template('edit')
         end
       end
@@ -326,11 +326,11 @@ describe ManifestationRelationshipsController do
 
       describe 'with valid params' do
         it 'updates the requested manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs }
         end
 
         it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs }
           expect(assigns(:manifestation_relationship)).to eq(@manifestation_relationship)
           expect(response).to redirect_to(@manifestation_relationship)
         end
@@ -338,7 +338,7 @@ describe ManifestationRelationshipsController do
 
       describe 'with invalid params' do
         it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @invalid_attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @invalid_attrs }
           expect(response).to render_template('edit')
         end
       end
@@ -349,11 +349,11 @@ describe ManifestationRelationshipsController do
 
       describe 'with valid params' do
         it 'updates the requested manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs }
         end
 
         it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs }
           expect(assigns(:manifestation_relationship)).to eq(@manifestation_relationship)
           expect(response).to be_forbidden
         end
@@ -361,7 +361,7 @@ describe ManifestationRelationshipsController do
 
       describe 'with invalid params' do
         it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @invalid_attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @invalid_attrs }
           expect(response).to be_forbidden
         end
       end
@@ -370,18 +370,18 @@ describe ManifestationRelationshipsController do
     describe 'When not logged in' do
       describe 'with valid params' do
         it 'updates the requested manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs }
         end
 
         it 'should be forbidden' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
 
       describe 'with invalid params' do
         it 'assigns the requested manifestation_relationship as @manifestation_relationship' do
-          put :update, id: @manifestation_relationship.id, manifestation_relationship: @invalid_attrs
+          put :update, params: { id: @manifestation_relationship.id, manifestation_relationship: @invalid_attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
@@ -397,11 +397,11 @@ describe ManifestationRelationshipsController do
       login_fixture_admin
 
       it 'destroys the requested manifestation_relationship' do
-        delete :destroy, id: @manifestation_relationship.id
+        delete :destroy, params: { id: @manifestation_relationship.id }
       end
 
       it 'redirects to the manifestation_relationships list' do
-        delete :destroy, id: @manifestation_relationship.id
+        delete :destroy, params: { id: @manifestation_relationship.id }
         expect(response).to redirect_to(manifestation_relationships_url)
       end
     end
@@ -410,11 +410,11 @@ describe ManifestationRelationshipsController do
       login_fixture_librarian
 
       it 'destroys the requested manifestation_relationship' do
-        delete :destroy, id: @manifestation_relationship.id
+        delete :destroy, params: { id: @manifestation_relationship.id }
       end
 
       it 'redirects to the manifestation_relationships list' do
-        delete :destroy, id: @manifestation_relationship.id
+        delete :destroy, params: { id: @manifestation_relationship.id }
         expect(response).to redirect_to(manifestation_relationships_url)
       end
     end
@@ -423,22 +423,22 @@ describe ManifestationRelationshipsController do
       login_fixture_user
 
       it 'destroys the requested manifestation_relationship' do
-        delete :destroy, id: @manifestation_relationship.id
+        delete :destroy, params: { id: @manifestation_relationship.id }
       end
 
       it 'should be forbidden' do
-        delete :destroy, id: @manifestation_relationship.id
+        delete :destroy, params: { id: @manifestation_relationship.id }
         expect(response).to be_forbidden
       end
     end
 
     describe 'When not logged in' do
       it 'destroys the requested manifestation_relationship' do
-        delete :destroy, id: @manifestation_relationship.id
+        delete :destroy, params: { id: @manifestation_relationship.id }
       end
 
       it 'should be forbidden' do
-        delete :destroy, id: @manifestation_relationship.id
+        delete :destroy, params: { id: @manifestation_relationship.id }
         expect(response).to redirect_to(new_user_session_url)
       end
     end

data/spec/controllers/manifestations_controller_spec.rb

@@ -66,48 +66,48 @@ describe ManifestationsController do
       end
 
       it 'assigns all manifestations as @manifestations in sru format with operation' do
-        get :index, format: 'sru', operation: 'searchRetrieve', query: 'ruby'
+        get :index, params: { format: 'sru', operation: 'searchRetrieve', query: 'ruby' }
         expect(assigns(:manifestations)).to_not be_nil
         expect(response).to render_template('manifestations/index')
       end
 
       it 'assigns all manifestations as @manifestations in sru format with operation and title' do
-        get :index, format: 'sru', query: 'title=ruby', operation: 'searchRetrieve'
+        get :index, params: { format: 'sru', query: 'title=ruby', operation: 'searchRetrieve' }
         expect(assigns(:manifestations)).to_not be_nil
         expect(response).to render_template('manifestations/index')
       end
 
       it 'assigns all manifestations as @manifestations in openurl' do
-        get :index, api: 'openurl', title: 'ruby'
+        get :index, params: { api: 'openurl', title: 'ruby' }
         expect(assigns(:manifestations)).to_not be_nil
       end
 
       it 'assigns all manifestations as @manifestations when pub_date_from and pub_date_until are specified' do
-        get :index, pub_date_from: '2000', pub_date_until: '2007'
+        get :index, params: { pub_date_from: '2000', pub_date_until: '2007' }
         assigns(:query).should eq "date_of_publication_d:[#{Time.zone.parse('2000-01-01').beginning_of_day.utc.iso8601} TO #{Time.zone.parse('2007-12-31').end_of_year.utc.iso8601}]"
         expect(assigns(:manifestations)).to_not be_nil
       end
 
       it 'assigns all manifestations as @manifestations when old pub_date_from and pub_date_until are specified' do
-        get :index, pub_date_from: '200', pub_date_until: '207'
+        get :index, params: { pub_date_from: '200', pub_date_until: '207' }
         assigns(:query).should eq "date_of_publication_d:[#{Time.zone.parse('200-01-01').utc.iso8601} TO #{Time.zone.parse('207-12-31').end_of_year.utc.iso8601}]"
         expect(assigns(:manifestations)).to_not be_nil
       end
 
       it 'assigns all manifestations as @manifestations when acquired_from and pub_date_until are specified' do
-        get :index, acquired_from: '2000', acquired_until: '2007'
+        get :index, params: { acquired_from: '2000', acquired_until: '2007' }
         assigns(:query).should eq "acquired_at_d:[#{Time.zone.parse('2000-01-01').beginning_of_day.utc.iso8601} TO #{Time.zone.parse('2007-12-31').end_of_year.utc.iso8601}]"
         expect(assigns(:manifestations)).to_not be_nil
       end
 
       it 'assigns all manifestations as @manifestations when old acquired_from and pub_date_until are specified' do
-        get :index, acquired_from: '200', acquired_until: '207'
+        get :index, params: { acquired_from: '200', acquired_until: '207' }
         assigns(:query).should eq "acquired_at_d:[#{Time.zone.parse('200-01-01').utc.iso8601} TO #{Time.zone.parse('207-12-31').end_of_day.utc.iso8601}]"
         expect(assigns(:manifestations)).to_not be_nil
       end
 
       it 'assigns all manifestations as @manifestations when number_of_pages_at_least and number_of_pages_at_most are specified' do
-        get :index, number_of_pages_at_least: '100', number_of_pages_at_most: '200'
+        get :index, params: { number_of_pages_at_least: '100', number_of_pages_at_most: '200' }
         expect(assigns(:manifestations)).to_not be_nil
       end
 
@@ -124,64 +124,58 @@ describe ManifestationsController do
       end
 
       it 'should get index with manifestation_id' do
-        get :index, manifestation_id: 1
+        get :index, params: { manifestation_id: 1 }
         expect(response).to be_success
         expect(assigns(:manifestation)).to eq Manifestation.find(1)
         assigns(:manifestations).collect(&:id).should eq assigns(:manifestation).derived_manifestations.collect(&:id)
       end
 
       it 'should get index with query' do
-        get :index, query: '2005'
+        get :index, params: { query: '2005' }
         expect(response).to be_success
         expect(assigns(:manifestations)).to_not be_blank
       end
 
       it 'should get index with page number' do
-        get :index, query: '2005', number_of_pages_at_least: 1, number_of_pages_at_most: 100
+        get :index, params: { query: '2005', number_of_pages_at_least: 1, number_of_pages_at_most: 100 }
         expect(response).to be_success
         assigns(:query).should eq '2005 number_of_pages_i:[1 TO 100]'
       end
 
       it 'should get index with pub_date_from' do
-        get :index, query: '2005', pub_date_from: '2000'
+        get :index, params: { query: '2005', pub_date_from: '2000' }
         expect(response).to be_success
         expect(assigns(:manifestations)).to be_truthy
         assigns(:query).should eq '2005 date_of_publication_d:[2000-01-01T00:00:00Z TO *]'
       end
 
       it 'should get index with pub_date_until' do
-        get :index, query: '2005', pub_date_until: '2000'
+        get :index, params: { query: '2005', pub_date_until: '2000' }
         expect(response).to be_success
         expect(assigns(:manifestations)).to be_truthy
         assigns(:query).should eq '2005 date_of_publication_d:[* TO 2000-12-31T23:59:59Z]'
       end
 
-      it 'should get tag_cloud' do
-        get :index, query: '2005', view: 'tag_cloud'
-        expect(response).to be_success
-        expect(response).to render_template('manifestations/_tag_cloud')
-      end
-
       it 'should show manifestation with isbn', solr: true do
-        get :index, isbn: '4798002062'
+        get :index, params: { isbn: '4798002062' }
         expect(response).to be_success
         expect(assigns(:manifestations).count).to eq 1
       end
 
       it 'should not show missing manifestation with isbn', solr: true do
-        get :index, isbn: '47980020620'
+        get :index, params: { isbn: '47980020620' }
         expect(response).to be_success
         expect(assigns(:manifestations)).to be_empty
       end
 
       it 'should show manifestation with library 3', solr: true do
-        get :index, library_adv: ['hachioji']
+        get :index, params: { library_adv: ['hachioji'] }
         expect(response).to be_success
         expect(assigns(:manifestations).size).to eq 1
       end
 
       it 'should show manifestation with library 2 or 3', solr: true do
-        get :index, library_adv: %w(hachioji kamata)
+        get :index, params: { library_adv: %w(hachioji kamata) }
         expect(response).to be_success
         expect(assigns(:manifestations).size).to eq 2
       end
@@ -190,14 +184,14 @@ describe ManifestationsController do
         shelf = FactoryBot.create(:shelf)
         library = shelf.library
         item = FactoryBot.create(:item, shelf: shelf)
-        get :index, :"#{library.name}_shelf" => [shelf.name]
+        get :index, params: { :"#{library.name}_shelf" => [shelf.name] }
         expect(response).to be_success
         expect(assigns(:manifestations).size).to eq 1
         expect(assigns(:manifestations).first).to eq item.manifestation
       end
 
       it 'should show manifestation with call_number', solr: true do
-        get :index, call_number: '547|ヤ'
+        get :index, params: { call_number: '547|ヤ' }
         expect(response).to be_success
         expect(assigns(:manifestations)).not_to be_empty
       end
@@ -205,13 +199,13 @@ describe ManifestationsController do
       it 'should show manifestation with NDC', solr: true do
         classification = FactoryBot.create(:classification, category: '007.3', classification_type_id: 1)
         Manifestation.first.classifications << classification
-        get :index, classification: '007', classification_type: 1
+        get :index, params: { classification: '007', classification_type: 1 }
         expect(response).to be_success
         expect(assigns(:manifestations)).not_to be_empty
       end
 
       it 'should not search with classification if classification is blank' do
-        get :index, classification: '', classification_type: 1
+        get :index, params: { classification: '', classification_type: 1 }
         expect(response).to be_success
         expect(assigns(:query)).not_to match /classification/
       end
@@ -220,14 +214,14 @@ describe ManifestationsController do
         subject = FactoryBot.create(:subject, term: 'test_subject')
         manifestation = FactoryBot.create(:manifestation)
         manifestation.subjects << subject
-        get :index, subject_text: 'test_subject'
+        get :index, params: { subject_text: 'test_subject' }
         expect(response).to be_success
         expect(assigns(:manifestations)).not_to be_empty
         expect(assigns(:manifestations).first).to eq manifestation
       end
 
       it 'should accept per_page params' do
-        get :index, per_page: 3
+        get :index, params: { per_page: 3 }
         expect(assigns(:manifestations).count).to eq 3
         expect(assigns(:manifestations).total_count).to eq 118
       end
@@ -236,17 +230,17 @@ describe ManifestationsController do
         get :index
         original_manifestations = assigns(:manifestations)
         expect(original_manifestations.count).to eq 10
-        get :index, page: 2
+        get :index, params: { page: 2 }
         manifestations_page2 = assigns(:manifestations)
         expect(manifestations_page2.count).to eq 10
         expect(original_manifestations.first).not_to eq manifestations_page2.first
       end
 
       it 'should accept sort_by parameter' do
-        get :index, sort_by: 'created_at:desc'
+        get :index, params: { sort_by: 'created_at:desc' }
         manifestations = assigns(:manifestations)
         expect(manifestations.first.created_at).to be >= manifestations.last.created_at
-        get :index, sort_by: 'created_at:asc'
+        get :index, params: { sort_by: 'created_at:asc' }
         manifestations = assigns(:manifestations)
         expect(manifestations.first.created_at).to be <= manifestations.last.created_at
       end
@@ -256,7 +250,7 @@ describe ManifestationsController do
         manifestation = FactoryBot.create(:manifestation, description: "foo")
         periodical.derived_manifestations << manifestation
         periodical.save!
-        get :index, query: "foo"
+        get :index, params: { query: "foo" }
         manifestations = assigns(:manifestations)
         expect(manifestations).not_to be_blank
         expect(manifestations.map{|e| e.id }).to include periodical.id
@@ -265,12 +259,12 @@ describe ManifestationsController do
       describe "with render_views" do
         render_views
         it "should accept query & language parameters" do
-          get :index, query: "test"
+          get :index, params: { query: "test" }
           expect(response.body).to have_link "unknown (1)", href: "/manifestations?language=unknown&query=test"
         end
 
         it "should accept facets and query parameters in sort_by menu" do
-          get :index, query: "test", carrier_type: "volume"
+          get :index, params: { query: "test", carrier_type: "volume" }
           expect(response.body).to have_selector "div.right input[type=hidden][name=query][value=test]", visible: false
           expect(response.body).to have_selector "div.right input[type=hidden][name=carrier_type][value=volume]", visible: false
         end
@@ -283,7 +277,7 @@ describe ManifestationsController do
       login_fixture_admin
 
       it 'assigns the requested manifestation as @manifestation' do
-        get :show, id: 1
+        get :show, params: { id: 1 }
         expect(assigns(:manifestation)).to eq(Manifestation.find(1))
       end
     end
@@ -292,19 +286,19 @@ describe ManifestationsController do
       login_fixture_librarian
 
       it 'assigns the requested manifestation as @manifestation' do
-        get :show, id: 1
+        get :show, params: { id: 1 }
         expect(assigns(:manifestation)).to eq(Manifestation.find(1))
       end
 
       it 'should show manifestation with agent who does not produce it' do
-        get :show, id: 3, agent_id: 3
+        get :show, params: { id: 3, agent_id: 3 }
         expect(assigns(:manifestation)).to eq assigns(:agent).manifestations.find(3)
         expect(response).to be_success
       end
 
       it 'should not show manifestation with required_role of admin' do
         manifestation = FactoryBot.create(:manifestation, required_role_id: 4)
-        get :show, id: manifestation.id
+        get :show, params: { id: manifestation.id }
         expect(response).not_to be_success
       end
     end
@@ -313,12 +307,12 @@ describe ManifestationsController do
       login_fixture_user
 
       it 'assigns the requested manifestation as @manifestation' do
-        get :show, id: 1
+        get :show, params: { id: 1 }
         expect(assigns(:manifestation)).to eq(Manifestation.find(1))
       end
 
       it 'should send manifestation detail email' do
-        get :show, id: 1, mode: 'send_email'
+        get :show, params: { id: 1, mode: 'send_email' }
         expect(response).to redirect_to manifestation_url(assigns(:manifestation))
       end
 
@@ -330,53 +324,41 @@ describe ManifestationsController do
 
     describe 'When not logged in' do
       it 'assigns the requested manifestation as @manifestation' do
-        get :show, id: 1
+        get :show, params: { id: 1 }
         expect(assigns(:manifestation)).to eq(Manifestation.find(1))
       end
 
       it 'guest should show manifestation mods template' do
-        get :show, id: 22, format: 'mods'
+        get :show, params: { id: 22, format: 'mods' }
         expect(assigns(:manifestation)).to eq Manifestation.find(22)
         expect(response).to render_template('manifestations/show')
       end
 
       it 'should show manifestation rdf template' do
-        get :show, id: 22, format: 'rdf'
+        get :show, params: { id: 22, format: 'rdf' }
         expect(assigns(:manifestation)).to eq Manifestation.find(22)
         expect(response).to render_template('manifestations/show')
       end
 
       it 'should show manifestation with holding' do
-        get :show, id: 1, mode: 'holding'
-        expect(response).to be_success
-      end
-
-      it 'should show manifestation with tag_edit' do
-        get :show, id: 1, mode: 'tag_edit'
-        expect(response).to render_template('manifestations/_tag_edit')
-        expect(response).to be_success
-      end
-
-      it 'should show manifestation with tag_list' do
-        get :show, id: 1, mode: 'tag_list'
-        expect(response).to render_template('manifestations/_tag_list')
+        get :show, params: { id: 1, mode: 'holding' }
         expect(response).to be_success
       end
 
       it 'should show manifestation with show_creators' do
-        get :show, id: 1, mode: 'show_creators'
+        get :show, params: { id: 1, mode: 'show_creators' }
         expect(response).to render_template('manifestations/_show_creators')
         expect(response).to be_success
       end
 
       it 'should show manifestation with show_all_creators' do
-        get :show, id: 1, mode: 'show_all_creators'
+        get :show, params: { id: 1, mode: 'show_all_creators' }
         expect(response).to render_template('manifestations/_show_creators')
         expect(response).to be_success
       end
 
       it "should not send manifestation's detail email" do
-        get :show, id: 1, mode: 'send_email'
+        get :show, params: { id: 1, mode: 'send_email' }
         expect(response).to redirect_to new_user_session_url
       end
     end
@@ -397,7 +379,7 @@ describe ManifestationsController do
       end
 
       it 'should get new template with expression_id' do
-        get :new, expression_id: 1
+        get :new, params: { expression_id: 1 }
         expect(response).to be_success
       end
     end
@@ -416,7 +398,7 @@ describe ManifestationsController do
       end
 
       it 'should get new template with expression_id' do
-        get :new, expression_id: 1
+        get :new, params: { expression_id: 1 }
         expect(response).to be_success
       end
 
@@ -436,10 +418,11 @@ describe ManifestationsController do
         serial.creators << FactoryBot.create(:agent)
         serial.contributors << FactoryBot.create(:agent)
         serial.publishers << FactoryBot.create(:agent)
+        serial.reload
         serial.subjects << FactoryBot.create(:subject)
         serial.classifications << FactoryBot.create(:classification)
         serial.save!
-        get :new, parent_id: serial.id
+        get :new, params: { parent_id: serial.id }
         expect(response).to be_success
         manifestation = assigns(:manifestation)
         parent = assigns(:parent)
@@ -489,7 +472,7 @@ describe ManifestationsController do
 
       it 'assigns the requested manifestation as @manifestation' do
         manifestation = FactoryBot.create(:manifestation)
-        get :edit, id: manifestation.id
+        get :edit, params: { id: manifestation.id }
         expect(assigns(:manifestation)).to eq(manifestation)
       end
     end
@@ -499,7 +482,7 @@ describe ManifestationsController do
 
       it 'assigns the requested manifestation as @manifestation' do
         manifestation = FactoryBot.create(:manifestation)
-        get :edit, id: manifestation.id
+        get :edit, params: { id: manifestation.id }
         expect(assigns(:manifestation)).to eq(manifestation)
       end
 
@@ -508,7 +491,7 @@ describe ManifestationsController do
         manifestation = FactoryBot.create(:manifestation)
         identifier = FactoryBot.create(:identifier)
         manifestation.identifiers << identifier
-        get :edit, id: manifestation.id
+        get :edit, params: { id: manifestation.id }
         expect(assigns(:manifestation)).to eq manifestation
         expect(assigns(:manifestation).identifiers).to eq manifestation.identifiers
         expect(response).to render_template(partial: 'manifestations/_identifier_fields')
@@ -520,20 +503,15 @@ describe ManifestationsController do
 
       it 'assigns the requested manifestation as @manifestation' do
         manifestation = FactoryBot.create(:manifestation)
-        get :edit, id: manifestation.id
+        get :edit, params: { id: manifestation.id }
         expect(response).to be_forbidden
       end
-
-      it 'should edit manifestation with tag_edit' do
-        get :edit, id: 1, mode: 'tag_edit'
-        expect(response).to be_success
-      end
     end
 
     describe 'When not logged in' do
       it 'should not assign the requested manifestation as @manifestation' do
         manifestation = FactoryBot.create(:manifestation)
-        get :edit, id: manifestation.id
+        get :edit, params: { id: manifestation.id }
         expect(response).to redirect_to(new_user_session_url)
       end
     end
@@ -550,30 +528,30 @@ describe ManifestationsController do
 
       describe 'with valid params' do
         it 'assigns a newly created manifestation as @manifestation' do
-          post :create, manifestation: @attrs
+          post :create, params: { manifestation: @attrs }
           expect(assigns(:manifestation)).to be_valid
         end
 
         it 'assigns a series_statement' do
-          post :create, manifestation: @attrs.merge(series_statements_attributes: { '0' => { original_title: SeriesStatement.find(1).original_title } })
+          post :create, params: { manifestation: @attrs.merge(series_statements_attributes: { '0' => { original_title: SeriesStatement.find(1).original_title } }) }
           assigns(:manifestation).reload
           assigns(:manifestation).series_statements.pluck(:original_title).include?(series_statements(:one).original_title).should be_truthy
         end
 
         it 'redirects to the created manifestation' do
-          post :create, manifestation: @attrs
+          post :create, params: { manifestation: @attrs }
           expect(response).to redirect_to(manifestation_url(assigns(:manifestation)))
         end
       end
 
       describe 'with invalid params' do
         it 'assigns a newly created but unsaved manifestation as @manifestation' do
-          post :create, manifestation: @invalid_attrs
+          post :create, params: { manifestation: @invalid_attrs }
           expect(assigns(:manifestation)).to_not be_valid
         end
 
         it "re-renders the 'new' template" do
-          post :create, manifestation: @invalid_attrs
+          post :create, params: { manifestation: @invalid_attrs }
           expect(response).to render_template('new')
         end
       end
@@ -584,29 +562,29 @@ describe ManifestationsController do
 
       describe 'with valid params' do
         it 'assigns a newly created manifestation as @manifestation' do
-          post :create, manifestation: @attrs
+          post :create, params: { manifestation: @attrs }
           expect(assigns(:manifestation)).to be_valid
         end
 
         it 'redirects to the created manifestation' do
-          post :create, manifestation: @attrs
+          post :create, params: { manifestation: @attrs }
           expect(response).to redirect_to(manifestation_url(assigns(:manifestation)))
         end
 
         it 'accepts an attachment file' do
-          post :create, manifestation: @attrs.merge(attachment: fixture_file_upload('/../../examples/resource_import_file_sample1.tsv', 'text/csv'))
+          post :create, params: { manifestation: @attrs.merge(attachment: fixture_file_upload('/../../examples/resource_import_file_sample1.tsv', 'text/csv')) }
           expect(assigns(:manifestation)).to be_valid
         end
       end
 
       describe 'with invalid params' do
         it 'assigns a newly created but unsaved manifestation as @manifestation' do
-          post :create, manifestation: @invalid_attrs
+          post :create, params: { manifestation: @invalid_attrs }
           expect(assigns(:manifestation)).to_not be_valid
         end
 
         it "re-renders the 'new' template" do
-          post :create, manifestation: @invalid_attrs
+          post :create, params: { manifestation: @invalid_attrs }
           expect(response).to render_template('new')
         end
       end
@@ -617,24 +595,24 @@ describe ManifestationsController do
 
       describe 'with valid params' do
         it 'assigns a newly created manifestation as @manifestation' do
-          post :create, manifestation: @attrs
+          post :create, params: { manifestation: @attrs }
           expect(assigns(:manifestation)).to be_nil
         end
 
         it 'should be forbidden' do
-          post :create, manifestation: @attrs
+          post :create, params: { manifestation: @attrs }
           expect(response).to be_forbidden
         end
       end
 
       describe 'with invalid params' do
         it 'assigns a newly created but unsaved manifestation as @manifestation' do
-          post :create, manifestation: @invalid_attrs
+          post :create, params: { manifestation: @invalid_attrs }
           expect(assigns(:manifestation)).to be_nil
         end
 
         it 'should be forbidden' do
-          post :create, manifestation: @invalid_attrs
+          post :create, params: { manifestation: @invalid_attrs }
           expect(response).to be_forbidden
         end
       end
@@ -643,24 +621,24 @@ describe ManifestationsController do
     describe 'When not logged in' do
       describe 'with valid params' do
         it 'assigns a newly created manifestation as @manifestation' do
-          post :create, manifestation: @attrs
+          post :create, params: { manifestation: @attrs }
           expect(assigns(:manifestation)).to be_nil
         end
 
         it 'should be forbidden' do
-          post :create, manifestation: @attrs
+          post :create, params: { manifestation: @attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
 
       describe 'with invalid params' do
         it 'assigns a newly created but unsaved manifestation as @manifestation' do
-          post :create, manifestation: @invalid_attrs
+          post :create, params: { manifestation: @invalid_attrs }
           expect(assigns(:manifestation)).to be_nil
         end
 
         it 'should be forbidden' do
-          post :create, manifestation: @invalid_attrs
+          post :create, params: { manifestation: @invalid_attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
@@ -680,24 +658,24 @@ describe ManifestationsController do
 
       describe 'with valid params' do
         it 'updates the requested manifestation' do
-          put :update, id: @manifestation.id, manifestation: @attrs
+          put :update, params: { id: @manifestation.id, manifestation: @attrs }
         end
 
         it 'assigns a series_statement' do
-          put :update, id: @manifestation.id, manifestation: @attrs.merge(series_statements_attributes: { '0' => { :original_title => series_statements(:two).original_title, '_destroy' => 'false' } })
+          put :update, params: { id: @manifestation.id, manifestation: @attrs.merge(series_statements_attributes: { '0' => { :original_title => series_statements(:two).original_title, '_destroy' => 'false' } }) }
           assigns(:manifestation).reload
           assigns(:manifestation).series_statements.pluck(:original_title).include?(series_statements(:two).original_title).should be_truthy
         end
 
         it 'assigns the requested manifestation as @manifestation' do
-          put :update, id: @manifestation.id, manifestation: @attrs
+          put :update, params: { id: @manifestation.id, manifestation: @attrs }
           expect(assigns(:manifestation)).to eq(@manifestation)
         end
       end
 
       describe 'with invalid params' do
         it 'assigns the requested manifestation as @manifestation' do
-          put :update, id: @manifestation.id, manifestation: @invalid_attrs
+          put :update, params: { id: @manifestation.id, manifestation: @invalid_attrs }
           expect(response).to render_template('edit')
         end
       end
@@ -708,11 +686,11 @@ describe ManifestationsController do
 
       describe 'with valid params' do
         it 'updates the requested manifestation' do
-          put :update, id: @manifestation.id, manifestation: @attrs
+          put :update, params: { id: @manifestation.id, manifestation: @attrs }
         end
 
         it 'assigns the requested manifestation as @manifestation' do
-          put :update, id: @manifestation.id, manifestation: @attrs
+          put :update, params: { id: @manifestation.id, manifestation: @attrs }
           expect(assigns(:manifestation)).to eq(@manifestation)
           expect(response).to redirect_to(@manifestation)
         end
@@ -721,19 +699,19 @@ describe ManifestationsController do
           identifiers_attrs = {
             identifier_attributes: [FactoryBot.create(:identifier)]
           }
-          put :update, id: @manifestation.id, manifestation: @attrs.merge(identifiers_attrs)
+          put :update, params: { id: @manifestation.id, manifestation: @attrs.merge(identifiers_attrs) }
           expect(assigns(:manifestation)).to eq @manifestation
         end
       end
 
       describe 'with invalid params' do
         it 'assigns the manifestation as @manifestation' do
-          put :update, id: @manifestation, manifestation: @invalid_attrs
+          put :update, params: { id: @manifestation, manifestation: @invalid_attrs }
           expect(assigns(:manifestation)).to_not be_valid
         end
 
         it "re-renders the 'edit' template" do
-          put :update, id: @manifestation, manifestation: @invalid_attrs
+          put :update, params: { id: @manifestation, manifestation: @invalid_attrs }
           expect(response).to render_template('edit')
         end
       end
@@ -744,11 +722,11 @@ describe ManifestationsController do
 
       describe 'with valid params' do
         it 'updates the requested manifestation' do
-          put :update, id: @manifestation.id, manifestation: @attrs
+          put :update, params: { id: @manifestation.id, manifestation: @attrs }
         end
 
         it 'assigns the requested manifestation as @manifestation' do
-          put :update, id: @manifestation.id, manifestation: @attrs
+          put :update, params: { id: @manifestation.id, manifestation: @attrs }
           expect(assigns(:manifestation)).to eq(@manifestation)
           expect(response).to be_forbidden
         end
@@ -756,7 +734,7 @@ describe ManifestationsController do
 
       describe 'with invalid params' do
         it 'assigns the requested manifestation as @manifestation' do
-          put :update, id: @manifestation.id, manifestation: @invalid_attrs
+          put :update, params: { id: @manifestation.id, manifestation: @invalid_attrs }
           expect(response).to be_forbidden
         end
       end
@@ -765,18 +743,18 @@ describe ManifestationsController do
     describe 'When not logged in' do
       describe 'with valid params' do
         it 'updates the requested manifestation' do
-          put :update, id: @manifestation.id, manifestation: @attrs
+          put :update, params: { id: @manifestation.id, manifestation: @attrs }
         end
 
         it 'should be forbidden' do
-          put :update, id: @manifestation.id, manifestation: @attrs
+          put :update, params: { id: @manifestation.id, manifestation: @attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
 
       describe 'with invalid params' do
         it 'assigns the requested manifestation as @manifestation' do
-          put :update, id: @manifestation.id, manifestation: @invalid_attrs
+          put :update, params: { id: @manifestation.id, manifestation: @invalid_attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
@@ -792,21 +770,21 @@ describe ManifestationsController do
       login_fixture_admin
 
       it 'destroys the requested manifestation' do
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
       end
 
       it 'redirects to the manifestations list' do
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
         expect(response).to redirect_to(manifestations_url)
       end
 
       it 'should not destroy the reserved manifestation' do
-        delete :destroy, id: 2
+        delete :destroy, params: { id: 2 }
         expect(response).to be_forbidden
       end
 
       it 'should not destroy manifestation contains items' do
-        delete :destroy, id: 1
+        delete :destroy, params: { id: 1 }
         expect(response).to be_forbidden
       end
 
@@ -814,7 +792,7 @@ describe ManifestationsController do
         @manifestation = FactoryBot.create(:manifestation_serial)
         child = FactoryBot.create(:manifestation)
         @manifestation.derived_manifestations << child
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
         expect(response).to be_forbidden
       end
     end
@@ -823,11 +801,11 @@ describe ManifestationsController do
       login_fixture_librarian
 
       it 'destroys the requested manifestation' do
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
       end
 
       it 'should be forbidden' do
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
         expect(response).to redirect_to(manifestations_url)
       end
     end
@@ -836,22 +814,22 @@ describe ManifestationsController do
       login_fixture_user
 
       it 'destroys the requested manifestation' do
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
       end
 
       it 'should be forbidden' do
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
         expect(response).to be_forbidden
       end
     end
 
     describe 'When not logged in' do
       it 'destroys the requested manifestation' do
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
       end
 
       it 'should be forbidden' do
-        delete :destroy, id: @manifestation.id
+        delete :destroy, params: { id: @manifestation.id }
         expect(response).to redirect_to(new_user_session_url)
       end
     end