draper 1.0.0 → 1.1.0

data/spec/dummy/config/routes.rb

@@ -4,4 +4,6 @@ Dummy::Application.routes.draw do
       get "mail", on: :member
     end
   end
+
+  devise_for :users, :admins if defined?(Devise)
 end

data/spec/dummy/fast_spec/post_decorator_spec.rb

@@ -0,0 +1,38 @@
+require 'draper'
+require 'rspec'
+
+require 'active_model/naming'
+require_relative '../app/decorators/post_decorator'
+
+Draper::ViewContext.test_strategy :fast
+
+Post = Struct.new(:id) { extend ActiveModel::Naming }
+
+describe PostDecorator do
+  let(:decorator) { PostDecorator.new(source) }
+  let(:source) { Post.new(42) }
+
+  it "can use built-in helpers" do
+    expect(decorator.truncated).to eq "Once upon a..."
+  end
+
+  it "can use built-in private helpers" do
+    expect(decorator.html_escaped).to eq "<script>danger</script>"
+  end
+
+  it "can't use user-defined helpers from app/helpers" do
+    expect{decorator.hello_world}.to raise_error NoMethodError, /hello_world/
+  end
+
+  it "can't use path helpers" do
+    expect{decorator.path_with_model}.to raise_error NoMethodError, /post_path/
+  end
+
+  it "can't use url helpers" do
+    expect{decorator.url_with_model}.to raise_error NoMethodError, /post_url/
+  end
+
+  it "can't be passed implicitly to url_for" do
+    expect{decorator.link}.to raise_error
+  end
+end

data/spec/dummy/lib/tasks/test.rake

@@ -1,10 +1,16 @@
-require 'rspec/core/rake_task'
 require 'rake/testtask'
+require 'rspec/core/rake_task'
+
+Rake::Task[:test].clear
+Rake::TestTask.new :test do |t|
+  t.libs << "test"
+  t.pattern = "test/**/*_test.rb"
+end
 
-RSpec::Core::RakeTask.new :rspec
+RSpec::Core::RakeTask.new :spec
 
-Rake::TestTask.new :mini_test do |t|
-  t.test_files = ["mini_test/mini_test_integration_test.rb"]
+RSpec::Core::RakeTask.new :fast_spec do |t|
+  t.pattern = "fast_spec/**/*_spec.rb"
 end
 
-task :default => [:rspec, :mini_test]
+task :default => [:test, :spec, :fast_spec]

data/spec/dummy/spec/decorators/devise_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+if defined?(Devise)
+  describe "A decorator spec" do
+    it "can sign in a real user" do
+      user = User.new
+      sign_in user
+
+      expect(helper.current_user).to be user
+    end
+
+    it "can sign in a mock user" do
+      user = double("User")
+      sign_in :user, user
+
+      expect(helper.current_user).to be user
+    end
+
+    it "can sign in a real admin" do
+      admin = Admin.new
+      sign_in admin
+
+      expect(helper.current_admin).to be admin
+    end
+
+    it "can sign in a mock admin" do
+      admin = double("Admin")
+      sign_in :admin, admin
+
+      expect(helper.current_admin).to be admin
+    end
+
+    it "can sign out a real user" do
+      user = User.new
+      sign_in user
+      sign_out user
+
+      expect(helper.current_user).to be_nil
+    end
+
+    it "can sign out a mock user" do
+      user = double("User")
+      sign_in :user, user
+      sign_out :user
+
+      expect(helper.current_user).to be_nil
+    end
+
+    it "can sign out without a user" do
+      sign_out :user
+
+      expect(helper.current_user).to be_nil
+    end
+
+    it "is backwards-compatible" do
+      user = double("User")
+      ActiveSupport::Deprecation.silence do
+        sign_in user
+      end
+
+      expect(helper.current_user).to be user
+    end
+  end
+end

data/spec/dummy/spec/decorators/helpers_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe "A decorator spec" do
+  it "can access helpers through `helper`" do
+    expect(helper.content_tag(:p, "Help!")).to eq "<p>Help!</p>"
+  end
+
+  it "can access helpers through `helpers`" do
+    expect(helpers.content_tag(:p, "Help!")).to eq "<p>Help!</p>"
+  end
+
+  it "can access helpers through `h`" do
+    expect(h.content_tag(:p, "Help!")).to eq "<p>Help!</p>"
+  end
+
+  it "gets the same helper object as a decorator" do
+    decorator = Draper::Decorator.new(Object.new)
+
+    expect(helpers).to be decorator.helpers
+  end
+end

data/spec/dummy/spec/decorators/post_decorator_spec.rb

@@ -1,26 +1,46 @@
 require 'spec_helper'
 
 describe PostDecorator do
-  subject { PostDecorator.new(source) }
+  let(:decorator) { PostDecorator.new(source) }
   let(:source) { Post.create }
 
+  it "can use built-in helpers" do
+    expect(decorator.truncated).to eq "Once upon a..."
+  end
+
+  it "can use built-in private helpers" do
+    expect(decorator.html_escaped).to eq "<script>danger</script>"
+  end
+
+  it "can use user-defined helpers from app/helpers" do
+    expect(decorator.hello_world).to eq "Hello, world!"
+  end
+
   it "can use path helpers with its model" do
-    subject.path_with_model.should == "/en/posts/#{source.id}"
+    expect(decorator.path_with_model).to eq "/en/posts/#{source.id}"
   end
 
   it "can use path helpers with its id" do
-    subject.path_with_id.should == "/en/posts/#{source.id}"
+    expect(decorator.path_with_id).to eq "/en/posts/#{source.id}"
   end
 
   it "can use url helpers with its model" do
-    subject.url_with_model.should == "http://www.example.com:12345/en/posts/#{source.id}"
+    expect(decorator.url_with_model).to eq "http://www.example.com:12345/en/posts/#{source.id}"
   end
 
   it "can use url helpers with its id" do
-    subject.url_with_id.should == "http://www.example.com:12345/en/posts/#{source.id}"
+    expect(decorator.url_with_id).to eq "http://www.example.com:12345/en/posts/#{source.id}"
   end
 
   it "can be passed implicitly to url_for" do
-    subject.link.should == "<a href=\"/en/posts/#{source.id}\">#{source.id}</a>"
+    expect(decorator.link).to eq "<a href=\"/en/posts/#{source.id}\">#{source.id}</a>"
+  end
+
+  it "serializes overriden attributes" do
+    expect(decorator.serializable_hash["updated_at"]).to be :overridden
+  end
+
+  it "uses a test view context from ApplicationController" do
+    expect(Draper::ViewContext.current.controller).to be_an ApplicationController
   end
 end

data/spec/dummy/spec/decorators/spec_type_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe "A spec in this folder" do
+  it "is a decorator spec" do
+    expect(example.metadata[:type]).to be :decorator
+  end
+end

data/spec/dummy/spec/decorators/view_context_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+def it_does_not_leak_view_context
+  2.times do
+    it "has an independent view context" do
+      expect(Draper::ViewContext.current).not_to be :leaked
+      Draper::ViewContext.current = :leaked
+    end
+  end
+end
+
+describe "A decorator spec", type: :decorator do
+  it_does_not_leak_view_context
+end
+
+describe "A controller spec", type: :controller do
+  it_does_not_leak_view_context
+end
+
+describe "A mailer spec", type: :mailer do
+  it_does_not_leak_view_context
+end

data/spec/dummy/spec/mailers/post_mailer_spec.rb

@@ -2,28 +2,32 @@ require 'spec_helper'
 
 describe PostMailer do
   describe "#decorated_email" do
-    subject { Capybara.string(email.body.to_s) }
+    let(:email_body) { Capybara.string(email.body.to_s) }
     let(:email) { PostMailer.decorated_email(post).deliver }
     let(:post) { Post.create }
 
     it "decorates" do
-      subject.should have_content "Today"
+      expect(email_body).to have_content "Today"
     end
 
     it "can use path helpers with a model" do
-      subject.should have_css "#path_with_model", text: "/en/posts/#{post.id}"
+      expect(email_body).to have_css "#path_with_model", text: "/en/posts/#{post.id}"
     end
 
     it "can use path helpers with an id" do
-      subject.should have_css "#path_with_id", text: "/en/posts/#{post.id}"
+      expect(email_body).to have_css "#path_with_id", text: "/en/posts/#{post.id}"
     end
 
     it "can use url helpers with a model" do
-      subject.should have_css "#url_with_model", text: "http://www.example.com:12345/en/posts/#{post.id}"
+      expect(email_body).to have_css "#url_with_model", text: "http://www.example.com:12345/en/posts/#{post.id}"
     end
 
     it "can use url helpers with an id" do
-      subject.should have_css "#url_with_id", text: "http://www.example.com:12345/en/posts/#{post.id}"
+      expect(email_body).to have_css "#url_with_id", text: "http://www.example.com:12345/en/posts/#{post.id}"
+    end
+
+    it "uses the correct view context controller" do
+      expect(email_body).to have_css "#controller", text: "PostMailer"
     end
   end
 end

data/spec/dummy/spec/models/mongoid_post_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+if defined?(Mongoid)
+  describe MongoidPost do
+    it "is decoratable" do
+      expect(MongoidPost).to respond_to :decorator_class
+      expect(MongoidPost.new).to respond_to :decorate
+    end
+  end
+end

data/spec/dummy/spec/models/post_spec.rb

@@ -2,13 +2,13 @@ require 'spec_helper'
 
 describe Post do
   describe "#==" do
-    before { Post.create }
-    subject { Post.first }
-
     it "is true for other instances' decorators" do
+      Post.create
+      one = Post.first
       other = Post.first
-      subject.should_not be other
-      (subject == other.decorate).should be_true
+
+      expect(one).not_to be other
+      expect(one == other.decorate).to be_true
     end
   end
 end

data/spec/dummy/spec/spec_helper.rb

@@ -4,5 +4,6 @@ require 'rspec/rails'
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.expect_with(:rspec) {|c| c.syntax = :expect}
   config.order = :random
 end

data/spec/dummy/test/decorators/minitest/devise_test.rb

@@ -0,0 +1,64 @@
+require 'minitest_helper'
+
+if defined?(Devise)
+  describe "A decorator test" do
+    it "can sign in a real user" do
+      user = User.new
+      sign_in user
+
+      assert_same user, helper.current_user
+    end
+
+    it "can sign in a mock user" do
+      user = Object.new
+      sign_in :user, user
+
+      assert_same user, helper.current_user
+    end
+
+    it "can sign in a real admin" do
+      admin = Admin.new
+      sign_in admin
+
+      assert_same admin, helper.current_admin
+    end
+
+    it "can sign in a mock admin" do
+      admin = Object.new
+      sign_in :admin, admin
+
+      assert_same admin, helper.current_admin
+    end
+
+    it "can sign out a real user" do
+      user = User.new
+      sign_in user
+      sign_out user
+
+      assert helper.current_user.nil?
+    end
+
+    it "can sign out a mock user" do
+      user = Object.new
+      sign_in :user, user
+      sign_out :user
+
+      assert helper.current_user.nil?
+    end
+
+    it "can sign out without a user" do
+      sign_out :user
+
+      assert helper.current_user.nil?
+    end
+
+    it "is backwards-compatible" do
+      user = Object.new
+      ActiveSupport::Deprecation.silence do
+        sign_in user
+      end
+
+      assert_same user, helper.current_user
+    end
+  end
+end

data/spec/dummy/test/decorators/minitest/helpers_test.rb

@@ -0,0 +1,21 @@
+require 'minitest_helper'
+
+describe "A decorator test" do
+  it "can access helpers through `helper`" do
+    assert_equal "<p>Help!</p>", helper.content_tag(:p, "Help!")
+  end
+
+  it "can access helpers through `helpers`" do
+    assert_equal "<p>Help!</p>", helpers.content_tag(:p, "Help!")
+  end
+
+  it "can access helpers through `h`" do
+    assert_equal "<p>Help!</p>", h.content_tag(:p, "Help!")
+  end
+
+  it "gets the same helper object as a decorator" do
+    decorator = Draper::Decorator.new(Object.new)
+
+    assert_same decorator.helpers, helpers
+  end
+end

data/spec/dummy/{mini_test/mini_test_integration_test.rb → test/decorators/minitest/spec_type_test.rb}

@@ -1,6 +1,4 @@
-require File.expand_path('../../config/environment', __FILE__)
-require 'minitest/autorun'
-require 'minitest/rails'
+require 'minitest_helper'
 
 def it_is_a_decorator_test
   it "is a decorator test" do
@@ -33,6 +31,14 @@ describe "AnyDecorator" do
   it_is_a_decorator_test
 end
 
+describe "Any decorator" do
+  it_is_a_decorator_test
+end
+
+describe "AnyDecoratorTest" do
+  it_is_a_decorator_test
+end
+
 describe "Any decorator test" do
   it_is_a_decorator_test
 end

data/spec/dummy/test/decorators/minitest/view_context_test.rb

@@ -0,0 +1,24 @@
+require 'minitest_helper'
+
+def it_does_not_leak_view_context
+  2.times do
+    it "has an independent view context" do
+      refute_equal :leaked, Draper::ViewContext.current
+      Draper::ViewContext.current = :leaked
+    end
+  end
+end
+
+describe "A decorator test" do
+  it_does_not_leak_view_context
+end
+
+describe "A controller test" do
+  tests Class.new(ActionController::Base)
+
+  it_does_not_leak_view_context
+end
+
+describe "A mailer test" do
+  it_does_not_leak_view_context
+end