draper 1.0.0 → 1.1.0

data/spec/draper/view_context_spec.rb

@@ -0,0 +1,154 @@
+require 'spec_helper'
+
+module Draper
+  describe ViewContext do
+    describe "#view_context" do
+      let(:base) { Class.new { def view_context; :controller_view_context; end } }
+      let(:controller) { Class.new(base) { include ViewContext } }
+
+      it "saves the superclass's view context" do
+        ViewContext.should_receive(:current=).with(:controller_view_context)
+        controller.new.view_context
+      end
+
+      it "returns the superclass's view context" do
+        expect(controller.new.view_context).to be :controller_view_context
+      end
+    end
+
+    describe ".controller" do
+      it "returns the stored controller from RequestStore" do
+        RequestStore.stub store: {current_controller: :stored_controller}
+
+        expect(ViewContext.controller).to be :stored_controller
+      end
+    end
+
+    describe ".controller=" do
+      it "stores a controller in RequestStore" do
+        store = {}
+        RequestStore.stub store: store
+
+        ViewContext.controller = :stored_controller
+        expect(store[:current_controller]).to be :stored_controller
+      end
+    end
+
+    describe ".current" do
+      it "returns the stored view context from RequestStore" do
+        RequestStore.stub store: {current_view_context: :stored_view_context}
+
+        expect(ViewContext.current).to be :stored_view_context
+      end
+
+      context "when no view context is stored" do
+        it "builds a view context" do
+          RequestStore.stub store: {}
+          ViewContext.stub build_strategy: ->{ :new_view_context }
+          HelperProxy.stub(:new).with(:new_view_context).and_return(:new_helper_proxy)
+
+          expect(ViewContext.current).to be :new_helper_proxy
+        end
+
+        it "stores the built view context" do
+          store = {}
+          RequestStore.stub store: store
+          ViewContext.stub build_strategy: ->{ :new_view_context }
+          HelperProxy.stub(:new).with(:new_view_context).and_return(:new_helper_proxy)
+
+          ViewContext.current
+          expect(store[:current_view_context]).to be :new_helper_proxy
+        end
+      end
+    end
+
+    describe ".current=" do
+      it "stores a helper proxy for the view context in RequestStore" do
+        store = {}
+        RequestStore.stub store: store
+        HelperProxy.stub(:new).with(:stored_view_context).and_return(:stored_helper_proxy)
+
+        ViewContext.current = :stored_view_context
+        expect(store[:current_view_context]).to be :stored_helper_proxy
+      end
+    end
+
+    describe ".clear!" do
+      it "clears the stored controller and view controller" do
+        store = {current_controller: :stored_controller, current_view_context: :stored_view_context}
+        RequestStore.stub store: store
+
+        ViewContext.clear!
+        expect(store).not_to have_key :current_controller
+        expect(store).not_to have_key :current_view_context
+      end
+    end
+
+    describe ".build" do
+      it "returns a new view context using the build strategy" do
+        ViewContext.stub build_strategy: ->{ :new_view_context }
+
+        expect(ViewContext.build).to be :new_view_context
+      end
+    end
+
+    describe ".build!" do
+      it "returns a helper proxy for the new view context" do
+        ViewContext.stub build_strategy: ->{ :new_view_context }
+        HelperProxy.stub(:new).with(:new_view_context).and_return(:new_helper_proxy)
+
+        expect(ViewContext.build!).to be :new_helper_proxy
+      end
+
+      it "stores the helper proxy" do
+        store = {}
+        RequestStore.stub store: store
+        ViewContext.stub build_strategy: ->{ :new_view_context }
+        HelperProxy.stub(:new).with(:new_view_context).and_return(:new_helper_proxy)
+
+        ViewContext.build!
+        expect(store[:current_view_context]).to be :new_helper_proxy
+      end
+    end
+
+    describe ".build_strategy" do
+      it "defaults to full" do
+        expect(ViewContext.build_strategy).to be_a ViewContext::BuildStrategy::Full
+      end
+
+      it "memoizes" do
+        expect(ViewContext.build_strategy).to be ViewContext.build_strategy
+      end
+    end
+
+    describe ".test_strategy" do
+      protect_module ViewContext
+
+      context "with :fast" do
+        it "creates a fast strategy" do
+          ViewContext.test_strategy :fast
+          expect(ViewContext.build_strategy).to be_a ViewContext::BuildStrategy::Fast
+        end
+
+        it "passes a block to the strategy" do
+          ViewContext::BuildStrategy::Fast.stub(:new).and_return{|&block| block.call}
+
+          expect(ViewContext.test_strategy(:fast){:passed}).to be :passed
+        end
+      end
+
+      context "with :full" do
+        it "creates a full strategy" do
+          ViewContext.test_strategy :full
+          expect(ViewContext.build_strategy).to be_a ViewContext::BuildStrategy::Full
+        end
+
+        it "passes a block to the strategy" do
+          ViewContext::BuildStrategy::Full.stub(:new).and_return{|&block| block.call}
+
+          expect(ViewContext.test_strategy(:full){:passed}).to be :passed
+        end
+      end
+    end
+  end
+end

data/spec/draper/view_helpers_spec.rb

@@ -1,41 +1,8 @@
 require 'spec_helper'
+require 'support/shared_examples/view_helpers'
 
-describe Draper::ViewHelpers do
-  subject(:view_helpers_class) { Class.new { include Draper::ViewHelpers } }
-
-  let(:view_helpers) { view_helpers_class.new }
-  let(:helper_proxy) { Draper::HelperProxy.new }
-  let(:view_context) { Object.new }
-
-  before { view_helpers.helpers.stub(:view_context).and_return(view_context) }
-
-  describe "#helpers" do
-    it "returns a HelperProxy" do
-      view_helpers.helpers.should be_a Draper::HelperProxy
-    end
-
-    it "is aliased to #h" do
-      view_helpers.h.should be view_helpers_class.helpers
-    end
-  end
-
-  it "delegates #localize to #helpers" do
-    view_context.should_receive(:localize).with(Date.new)
-    view_helpers.localize(Date.new)
-  end
-
-  it "aliases #l to #localize" do
-    view_context.should_receive(:localize).with(Date.new)
-    view_helpers.l(Date.new)
-  end
-
-  describe ".helpers" do
-    it "returns a HelperProxy" do
-      view_helpers_class.helpers.should be_a Draper::HelperProxy
-    end
-
-    it "is aliased to #h" do
-      view_helpers_class.h.should be view_helpers_class.helpers
-    end
+module Draper
+  describe ViewHelpers do
+    it_behaves_like "view helpers", Class.new{include ViewHelpers}.new
   end
 end

data/spec/dummy/app/controllers/posts_controller.rb

@@ -8,4 +8,11 @@ class PostsController < ApplicationController
     email = PostMailer.decorated_email(post).deliver
     render text: email.body
   end
+
+  private
+
+  def goodnight_moon
+    "Goodnight, moon!"
+  end
+  helper_method :goodnight_moon
 end

data/spec/dummy/app/decorators/post_decorator.rb

@@ -1,9 +1,13 @@
 class PostDecorator < Draper::Decorator
+  # don't delegate_all here because it helps to identify things we
+  # have to delegate for ActiveModel compatibility
+
+  # need to delegate attribute methods for AM::Serialization
   # need to delegate id and new_record? for AR::Base#== (Rails 3.0 only)
-  delegate :id, :new_record?
+  delegate :id, :created_at, :new_record?
 
   def posted_date
-    if source.created_at.to_date == DateTime.now.utc.to_date
+    if created_at.to_date == DateTime.now.utc.to_date
       "Today"
     else
       "Not Today"
@@ -29,4 +33,24 @@ class PostDecorator < Draper::Decorator
   def link
     h.link_to id.to_s, self
   end
+
+  def truncated
+    h.truncate("Once upon a time in a world far far away", length: 17, separator: ' ')
+  end
+
+  def html_escaped
+    h.html_escape("<script>danger</script>")
+  end
+
+  def hello_world
+    h.hello_world
+  end
+
+  def goodnight_moon
+    h.goodnight_moon
+  end
+
+  def updated_at
+    :overridden
+  end
 end

data/spec/dummy/app/helpers/application_helper.rb

@@ -1,2 +1,5 @@
 module ApplicationHelper
+  def hello_world
+    "Hello, world!"
+  end
 end

data/spec/dummy/app/mailers/post_mailer.rb

@@ -2,8 +2,18 @@ class PostMailer < ApplicationMailer
   default from: "from@example.com"
   layout "application"
 
+  # Mailers don't import app/helpers automatically
+  helper :application
+
   def decorated_email(post)
     @post = post.decorate
     mail to: "to@example.com", subject: "A decorated post"
   end
+
+  private
+
+  def goodnight_moon
+    "Goodnight, moon!"
+  end
+  helper_method :goodnight_moon
 end

data/spec/dummy/app/models/admin.rb

@@ -0,0 +1,5 @@
+if defined?(Devise)
+  class Admin
+    extend Devise::Models
+  end
+end

data/spec/dummy/app/models/mongoid_post.rb

@@ -0,0 +1,5 @@
+if defined?(Mongoid)
+  class MongoidPost
+    include Mongoid::Document
+  end
+end

data/spec/dummy/app/models/user.rb

@@ -0,0 +1,5 @@
+if defined?(Devise)
+  class User
+    extend Devise::Models
+  end
+end

data/spec/dummy/app/views/posts/_post.html.erb

@@ -2,9 +2,24 @@
   <dt>Environment:</dt>
   <dd id="environment"><%= Rails.env %></dd>
 
+  <dt>Draper view context controller:</dt>
+  <dd id="controller"><%= Draper::ViewContext.current.controller.class %></dd>
+
   <dt>Posted:</dt>
   <dd id="posted_date"><%= post.posted_date %></dd>
 
+  <dt>Built-in helpers:</dt>
+  <dd id="truncated"><%= post.truncated %></dd>
+
+  <dt>Built-in private helpers:</dt>
+  <dd id="html_escaped"><%= post.html_escaped %></dd>
+
+  <dt>Helpers from app/helpers:</dt>
+  <dd id="hello_world"><%= post.hello_world %></dd>
+
+  <dt>Helpers from the controller:</dt>
+  <dd id="goodnight_moon"><%= post.goodnight_moon %></dd>
+
   <dt>Path with model:</dt>
   <dd id="path_with_model"><%= post.path_with_model %></dd>
 

data/spec/dummy/bin/rails

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+APP_PATH = File.expand_path('../../config/application',  __FILE__)
+require_relative '../config/boot'
+require 'rails/commands'

data/spec/dummy/config/application.rb

@@ -1,9 +1,14 @@
 require File.expand_path('../boot', __FILE__)
 
-require 'rails/all'
+def attempt_require(file)
+  require file
+rescue LoadError
+end
 
-Bundler.require
-require "draper"
+require 'rails/all'
+require 'draper'
+attempt_require 'mongoid'
+attempt_require 'devise'
 
 module Dummy
   class Application < Rails::Application
@@ -62,3 +67,4 @@ module Dummy
   end
 end
 
+ActiveRecord::Migration.verbose = false

data/spec/dummy/config/boot.rb

@@ -1,10 +1,5 @@
 require 'rubygems'
-gemfile = File.expand_path('../../../../Gemfile', __FILE__)
 
-if File.exist?(gemfile)
-  ENV['BUNDLE_GEMFILE'] = gemfile
-  require 'bundler'
-  Bundler.setup
-end
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
 
-$:.unshift File.expand_path('../../../../lib', __FILE__)
+require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])

data/spec/dummy/config/environments/development.rb

@@ -6,9 +6,6 @@ Dummy::Application.configure do
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
@@ -19,6 +16,8 @@ Dummy::Application.configure do
   # Only use best-standards-support built into browsers
   config.action_dispatch.best_standards_support = :builtin
 
+  config.eager_load = false
+
   # Raise exception on mass assignment protection for Active Record models
   # config.active_record.mass_assignment_sanitizer = :strict
 

data/spec/dummy/config/environments/production.rb

@@ -11,6 +11,8 @@ Dummy::Application.configure do
   # Disable Rails's static asset server (Apache or nginx will already do this)
   config.serve_static_assets = false
 
+  config.eager_load = true
+
   # Defaults to nil and saved in location specified by config.assets.prefix
   # config.assets.manifest = YOUR_PATH
 

data/spec/dummy/config/environments/test.rb

@@ -9,10 +9,7 @@ Dummy::Application.configure do
 
   # Configure static asset server for tests with Cache-Control for performance
   # config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
-
-  # Log error messages when you accidentally call methods on nil
-  config.whiny_nils = true
+  # config.static_cache_control = "public, max-age=3600"
 
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
@@ -29,4 +26,6 @@ Dummy::Application.configure do
 
   # Print deprecation notices to the stderr
   config.active_support.deprecation = :stderr
+
+  config.eager_load = false
 end

data/spec/dummy/config/initializers/secret_token.rb

@@ -4,4 +4,5 @@
 # If you change this key, all old signed cookies will become invalid!
 # Make sure the secret is at least 30 characters and all random,
 # no regular words or you'll be exposed to dictionary attacks.
+Dummy::Application.config.secret_key_base = 'c2e3474d3816f60bf6dd0f3b983e7283c7ff5373e11a96935340b544a31964dbe5ee077136165ee2975e0005f5e80207c0059e6d5589699031242ba5a06dcb87'
 Dummy::Application.config.secret_token = 'c2e3474d3816f60bf6dd0f3b983e7283c7ff5373e11a96935340b544a31964dbe5ee077136165ee2975e0005f5e80207c0059e6d5589699031242ba5a06dcb87'

data/spec/dummy/config/mongoid.yml

@@ -0,0 +1,80 @@
+development:
+  # Configure available database sessions. (required)
+  sessions:
+    # Defines the default session. (required)
+    default:
+      # Defines the name of the default database that Mongoid can connect to.
+      # (required).
+      database: dummy_development
+      # Provides the hosts the default session can connect to. Must be an array
+      # of host:port pairs. (required)
+      hosts:
+        - localhost:27017
+      options:
+        # Change whether the session persists in safe mode by default.
+        # (default: false)
+        # safe: false
+
+        # Change the default consistency model to :eventual or :strong.
+        # :eventual will send reads to secondaries, :strong sends everything
+        # to master. (default: :eventual)
+        # consistency: :eventual
+
+        # How many times Moped should attempt to retry an operation after
+        # failure. (default: 30)
+        # max_retries: 30
+
+        # The time in seconds that Moped should wait before retrying an
+        # operation on failure. (default: 1)
+        # retry_interval: 1
+  # Configure Mongoid specific options. (optional)
+  options:
+    # Configuration for whether or not to allow access to fields that do
+    # not have a field definition on the model. (default: true)
+    # allow_dynamic_fields: true
+
+    # Enable the identity map, needed for eager loading. (default: false)
+    # identity_map_enabled: false
+
+    # Includes the root model name in json serialization. (default: false)
+    # include_root_in_json: false
+
+    # Include the _type field in serializaion. (default: false)
+    # include_type_for_serialization: false
+
+    # Preload all models in development, needed when models use
+    # inheritance. (default: false)
+    # preload_models: false
+
+    # Protect id and type from mass assignment. (default: true)
+    # protect_sensitive_fields: true
+
+    # Raise an error when performing a #find and the document is not found.
+    # (default: true)
+    # raise_not_found_error: true
+
+    # Raise an error when defining a scope with the same name as an
+    # existing method. (default: false)
+    # scope_overwrite_exception: false
+
+    # Skip the database version check, used when connecting to a db without
+    # admin access. (default: false)
+    # skip_version_check: false
+
+    # User Active Support's time zone in conversions. (default: true)
+    # use_activesupport_time_zone: true
+
+    # Ensure all times are UTC in the app side. (default: false)
+    # use_utc: false
+test:
+  sessions:
+    default:
+      database: dummy_test
+      hosts:
+        - localhost:27017
+      options:
+        consistency: :strong
+        # In the test environment we lower the retries and retry interval to
+        # low amounts for fast failures.
+        max_retries: 1
+        retry_interval: 0