draper 1.0.0 → 1.1.0

data/spec/draper/finders_spec.rb

@@ -1,132 +1,166 @@
 require 'spec_helper'
 
-describe Draper::Finders do
-  describe ".find" do
-    it "proxies to the model class" do
-      Product.should_receive(:find).with(1)
-      ProductDecorator.find(1)
+module Draper
+  describe Finders do
+    protect_class ProductDecorator
+    before { ProductDecorator.decorates_finders }
+
+    describe ".find" do
+      it "proxies to the model class" do
+        Product.should_receive(:find).with(1)
+        ProductDecorator.find(1)
+      end
+
+      it "decorates the result" do
+        found = Product.new
+        Product.stub(:find).and_return(found)
+        decorator = ProductDecorator.find(1)
+        expect(decorator).to be_a ProductDecorator
+        expect(decorator.source).to be found
+      end
+
+      it "passes context to the decorator" do
+        Product.stub(:find)
+        context = {some: "context"}
+        decorator = ProductDecorator.find(1, context: context)
+
+        expect(decorator.context).to be context
+      end
+    end
+
+    describe ".find_by_(x)" do
+      it "proxies to the model class" do
+        Product.should_receive(:find_by_name).with("apples")
+        ProductDecorator.find_by_name("apples")
+      end
+
+      it "decorates the result" do
+        found = Product.new
+        Product.stub(:find_by_name).and_return(found)
+        decorator = ProductDecorator.find_by_name("apples")
+        expect(decorator).to be_a ProductDecorator
+        expect(decorator.source).to be found
+      end
+
+      it "proxies complex ProductDecorators" do
+        Product.should_receive(:find_by_name_and_size).with("apples", "large")
+        ProductDecorator.find_by_name_and_size("apples", "large")
+      end
+
+      it "proxies find_last_by_(x) ProductDecorators" do
+        Product.should_receive(:find_last_by_name_and_size).with("apples", "large")
+        ProductDecorator.find_last_by_name_and_size("apples", "large")
+      end
+
+      it "proxies find_or_initialize_by_(x) ProductDecorators" do
+        Product.should_receive(:find_or_initialize_by_name_and_size).with("apples", "large")
+        ProductDecorator.find_or_initialize_by_name_and_size("apples", "large")
+      end
+
+      it "proxies find_or_create_by_(x) ProductDecorators" do
+        Product.should_receive(:find_or_create_by_name_and_size).with("apples", "large")
+        ProductDecorator.find_or_create_by_name_and_size("apples", "large")
+      end
+
+      it "passes context to the decorator" do
+        Product.stub(:find_by_name_and_size)
+        context = {some: "context"}
+        decorator = ProductDecorator.find_by_name_and_size("apples", "large", context: context)
+
+        expect(decorator.context).to be context
+      end
+    end
+
+    describe ".find_all_by_" do
+      it "proxies to the model class" do
+        Product.should_receive(:find_all_by_name_and_size).with("apples", "large").and_return([])
+        ProductDecorator.find_all_by_name_and_size("apples", "large")
+      end
+
+      it "decorates the result" do
+        found = [Product.new, Product.new]
+        Product.stub(:find_all_by_name).and_return(found)
+        decorator = ProductDecorator.find_all_by_name("apples")
+
+        expect(decorator).to be_a Draper::CollectionDecorator
+        expect(decorator.decorator_class).to be ProductDecorator
+        expect(decorator).to eq found
+      end
+
+      it "passes context to the decorator" do
+        Product.stub(:find_all_by_name)
+        context = {some: "context"}
+        decorator = ProductDecorator.find_all_by_name("apples", context: context)
+
+        expect(decorator.context).to be context
+      end
+    end
+
+    describe ".all" do
+      it "returns a decorated collection" do
+        found = [Product.new, Product.new]
+        Product.stub all: found
+        decorator = ProductDecorator.all
+
+        expect(decorator).to be_a Draper::CollectionDecorator
+        expect(decorator.decorator_class).to be ProductDecorator
+        expect(decorator).to eq found
+      end
+
+      it "passes context to the decorator" do
+        Product.stub(:all)
+        context = {some: "context"}
+        decorator = ProductDecorator.all(context: context)
+
+        expect(decorator.context).to be context
+      end
+    end
+
+    describe ".first" do
+      it "proxies to the model class" do
+        Product.should_receive(:first)
+        ProductDecorator.first
+      end
+
+      it "decorates the result" do
+        first = Product.new
+        Product.stub(:first).and_return(first)
+        decorator = ProductDecorator.first
+        expect(decorator).to be_a ProductDecorator
+        expect(decorator.source).to be first
+      end
+
+      it "passes context to the decorator" do
+        Product.stub(:first)
+        context = {some: "context"}
+        decorator = ProductDecorator.first(context: context)
+
+        expect(decorator.context).to be context
+      end
+    end
+
+    describe ".last" do
+      it "proxies to the model class" do
+        Product.should_receive(:last)
+        ProductDecorator.last
+      end
+
+      it "decorates the result" do
+        last = Product.new
+        Product.stub(:last).and_return(last)
+        decorator = ProductDecorator.last
+        expect(decorator).to be_a ProductDecorator
+        expect(decorator.source).to be last
+      end
+
+      it "passes context to the decorator" do
+        Product.stub(:last)
+        context = {some: "context"}
+        decorator = ProductDecorator.last(context: context)
+
+        expect(decorator.context).to be context
+      end
     end
 
-    it "decorates the result" do
-      found = Product.new
-      Product.stub(:find).and_return(found)
-      decorator = ProductDecorator.find(1)
-      decorator.should be_a ProductDecorator
-      decorator.source.should be found
-    end
-
-    it "passes context to the decorator" do
-      decorator = ProductDecorator.find(1, context: {some: 'context'})
-      decorator.context.should == {some: 'context'}
-    end
-  end
-
-  describe ".find_by_(x)" do
-    it "proxies to the model class" do
-      Product.should_receive(:find_by_name).with("apples")
-      ProductDecorator.find_by_name("apples")
-    end
-
-    it "decorates the result" do
-      found = Product.new
-      Product.stub(:find_by_name).and_return(found)
-      decorator = ProductDecorator.find_by_name("apples")
-      decorator.should be_a ProductDecorator
-      decorator.source.should be found
-    end
-
-    it "proxies complex finders" do
-      Product.should_receive(:find_by_name_and_size).with("apples", "large")
-      ProductDecorator.find_by_name_and_size("apples", "large")
-    end
-
-    it "proxies find_last_by_(x) finders" do
-      Product.should_receive(:find_last_by_name_and_size).with("apples", "large")
-      ProductDecorator.find_last_by_name_and_size("apples", "large")
-    end
-
-    it "proxies find_or_initialize_by_(x) finders" do
-      Product.should_receive(:find_or_initialize_by_name_and_size).with("apples", "large")
-      ProductDecorator.find_or_initialize_by_name_and_size("apples", "large")
-    end
-
-    it "proxies find_or_create_by_(x) finders" do
-      Product.should_receive(:find_or_create_by_name_and_size).with("apples", "large")
-      ProductDecorator.find_or_create_by_name_and_size("apples", "large")
-    end
-
-    it "passes context to the decorator" do
-      Product.should_receive(:find_by_name_and_size).with("apples", "large", context: {some: 'context'})
-      decorator = ProductDecorator.find_by_name_and_size("apples", "large", context: {some: 'context'})
-      decorator.context.should == {some: 'context'}
-    end
-  end
-
-  describe ".find_all_by_" do
-    it "proxies to the model class" do
-      Product.should_receive(:find_all_by_name_and_size).with("apples", "large").and_return([])
-      ProductDecorator.find_all_by_name_and_size("apples", "large")
-    end
-
-    it "decorates the result" do
-      found = [Product.new, Product.new]
-      Product.stub(:find_all_by_name).and_return(found)
-      decorator = ProductDecorator.find_all_by_name("apples")
-      decorator.should be_a Draper::CollectionDecorator
-      decorator.should == found
-    end
-  end
-
-  describe ".all" do
-    it "returns a decorated collection" do
-      collection = ProductDecorator.all
-      collection.should be_a Draper::CollectionDecorator
-      collection.first.should be_a ProductDecorator
-    end
-
-    it "passes context to the collection decorator" do
-      collection = ProductDecorator.all(context: {some: 'context'})
-      collection.context.should == {some: 'context'}
-    end
-  end
-
-  describe ".first" do
-    it "proxies to the model class" do
-      Product.should_receive(:first)
-      ProductDecorator.first
-    end
-
-    it "decorates the result" do
-      first = Product.new
-      Product.stub(:first).and_return(first)
-      decorator = ProductDecorator.first
-      decorator.should be_a ProductDecorator
-      decorator.source.should be first
-    end
-
-    it "passes context to the decorator" do
-      decorator = ProductDecorator.first(context: {some: 'context'})
-      decorator.context.should == {some: 'context'}
-    end
-  end
-
-  describe ".last" do
-    it "proxies to the model class" do
-      Product.should_receive(:last)
-      ProductDecorator.last
-    end
-
-    it "decorates the result" do
-      last = Product.new
-      Product.stub(:last).and_return(last)
-      decorator = ProductDecorator.last
-      decorator.should be_a ProductDecorator
-      decorator.source.should be last
-    end
-
-    it "passes context to the decorator" do
-      decorator = ProductDecorator.last(context: {some: 'context'})
-      decorator.context.should == {some: 'context'}
-    end
   end
 end

data/spec/draper/helper_proxy_spec.rb

@@ -1,12 +1,42 @@
 require 'spec_helper'
 
-describe Draper::HelperProxy do
-  subject(:helper_proxy) { Draper::HelperProxy.new }
-  let(:view_context) { Object.new }
-  before { helper_proxy.stub(:view_context).and_return(view_context) }
-
-  it "proxies methods to the view context" do
-    view_context.should_receive(:foo).with("bar")
-    helper_proxy.foo("bar")
+module Draper
+  describe HelperProxy do
+    describe "#initialize" do
+      it "sets the view context" do
+        view_context = double
+        helper_proxy = HelperProxy.new(view_context)
+
+        expect(helper_proxy.send(:view_context)).to be view_context
+      end
+    end
+
+    describe "#method_missing" do
+      protect_class HelperProxy
+
+      it "proxies methods to the view context" do
+        view_context = double
+        helper_proxy = HelperProxy.new(view_context)
+
+        view_context.stub(:foo).and_return{|arg| arg}
+        expect(helper_proxy.foo(:passed)).to be :passed
+      end
+
+      it "passes blocks" do
+        view_context = double
+        helper_proxy = HelperProxy.new(view_context)
+
+        view_context.stub(:foo).and_return{|&block| block.call}
+        expect(helper_proxy.foo{:yielded}).to be :yielded
+      end
+
+      it "defines the method for better performance" do
+        helper_proxy = HelperProxy.new(double(foo: "bar"))
+
+        expect(HelperProxy.instance_methods).not_to include :foo
+        helper_proxy.foo
+        expect(HelperProxy.instance_methods).to include :foo
+      end
+    end
   end
 end

data/spec/draper/view_context/build_strategy_spec.rb

@@ -0,0 +1,116 @@
+require 'spec_helper'
+
+def fake_view_context
+  double("ViewContext")
+end
+
+def fake_controller(view_context = fake_view_context)
+  double("Controller", view_context: view_context, request: double("Request"))
+end
+
+module Draper
+  describe ViewContext::BuildStrategy::Full do
+    describe "#call" do
+      context "when a current controller is set" do
+        it "returns the controller's view context" do
+          view_context = fake_view_context
+          ViewContext.stub controller: fake_controller(view_context)
+          strategy = ViewContext::BuildStrategy::Full.new
+
+          expect(strategy.call).to be view_context
+        end
+      end
+
+      context "when a current controller is not set" do
+        it "uses ApplicationController" do
+          view_context = fake_view_context
+          stub_const "ApplicationController", double(new: fake_controller(view_context))
+          strategy = ViewContext::BuildStrategy::Full.new
+
+          expect(strategy.call).to be view_context
+        end
+      end
+
+      it "adds a request if one is not defined" do
+        controller = Class.new(ActionController::Base).new
+        ViewContext.stub controller: controller
+        strategy = ViewContext::BuildStrategy::Full.new
+
+        expect(controller.request).to be_nil
+        strategy.call
+        expect(controller.request).to be_an ActionController::TestRequest
+        expect(controller.params).to eq({})
+
+        # sanity checks
+        expect(controller.view_context.request).to be controller.request
+        expect(controller.view_context.params).to be controller.params
+      end
+
+      it "adds methods to the view context from the constructor block" do
+        ViewContext.stub controller: fake_controller
+        strategy = ViewContext::BuildStrategy::Full.new do
+          def a_helper_method; end
+        end
+
+        expect(strategy.call).to respond_to :a_helper_method
+      end
+
+      it "includes modules into the view context from the constructor block" do
+        view_context = Object.new
+        ViewContext.stub controller: fake_controller(view_context)
+        helpers = Module.new do
+          def a_helper_method; end
+        end
+        strategy = ViewContext::BuildStrategy::Full.new do
+          include helpers
+        end
+
+        expect(strategy.call).to respond_to :a_helper_method
+      end
+    end
+  end
+
+  describe ViewContext::BuildStrategy::Fast do
+    describe "#call" do
+      it "returns an instance of a subclass of ActionView::Base" do
+        strategy = ViewContext::BuildStrategy::Fast.new
+
+        returned = strategy.call
+
+        expect(returned).to be_an ActionView::Base
+        expect(returned.class).not_to be ActionView::Base
+      end
+
+      it "returns different instances each time" do
+        strategy = ViewContext::BuildStrategy::Fast.new
+
+        expect(strategy.call).not_to be strategy.call
+      end
+
+      it "returns the same subclass each time" do
+        strategy = ViewContext::BuildStrategy::Fast.new
+
+        expect(strategy.call.class).to be strategy.call.class
+      end
+
+      it "adds methods to the view context from the constructor block" do
+        strategy = ViewContext::BuildStrategy::Fast.new do
+          def a_helper_method; end
+        end
+
+        expect(strategy.call).to respond_to :a_helper_method
+      end
+
+      it "includes modules into the view context from the constructor block" do
+        helpers = Module.new do
+          def a_helper_method; end
+        end
+        strategy = ViewContext::BuildStrategy::Fast.new do
+          include helpers
+        end
+
+        expect(strategy.call).to respond_to :a_helper_method
+      end
+    end
+  end
+end