dorsale 3.20.0 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40c57412c903d5b5e12ca0c7fb7abc5103325840da2f27a624d4bdeace505ee4
-  data.tar.gz: a65375f0c67fd74790657e085a8b974cff8eca322e45c31d69bbb6577856b97a
+  metadata.gz: cc2541a790ad9accc9357974989a05d31777d70f259049ec7c1683bdb2add396
+  data.tar.gz: 892004495e28a5f6cc6036a774cfd04bb30b50c1b2c05ba2a74290f8c6f9cd7e
 SHA512:
-  metadata.gz: 18694d47b193684c2f80e486fbad25d375e70b2d7b3e63b8fca836a1dd2950c2f2c62a049efc9eec99f2d566f68c624a7654c913dfc7f4dec272b1a6a8617224
-  data.tar.gz: 848df210eb6928360cd50cb254c6d6c905263d8ac46af11d8806166dd5aa89d99d12a03afff0d5d95580cb60e4ac6c0ec9456314677d3c0c5d470951f62cec67
+  metadata.gz: 64919f579cf03f0d412dca7bd63b71ab0e6e53a304ab4309a6dc7b67add09d1068c1747221344429a8a8d173535edf8613f76de5a9cbac0b8e2fd8bd27c0acb7
+  data.tar.gz: dd5b5989add23e93c8c253d4538ffea84bb19e39714e80de21576f2741e853f96de1e10d7e851fe6409c34d109243b6d0b14a9e31d26736e14e6abffac322b19

data/CHANGELOG.md

@@ -1,17 +1,32 @@
 # Changelog
 
-# 3.20.0
 ## Next version
+
+## 4.1.0
+- Ruby 3.2 compatibility
+- Rails 7.1 compatibility
+- Ruby 3.3 compatibility
+- Rails 7.2 compatibility
+- Ruby 3.4 compatibility
+- Rails 8.0 compatibility
+- Rails 8.1 compatibility
+
+## 4.0.0
+- Ruby 3.1 required
+- Rails 7.0
+- Zeitwerk compatibility
+
+## 3.20.0
 - Change email deliver_now to deliver_later on save
 
-# 3.19.1
+## 3.19.1
 - Expenses : add colors to list
 
 # 3.19.0
 - Change expenses state machine
 - Change expenses list view
 
-# 3.18.0
+## 3.18.0
 - Change uploaders `extension_whitelist` to `extension_allowlist`
 - Rails 6.1 compatibility
 

data/app/controllers/dorsale/alexandrie/attachments_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::Alexandrie::AttachmentsController < ::Dorsale::ApplicationController
+class Dorsale::Alexandrie::AttachmentsController < Dorsale::ApplicationController
   layout false
 
   before_action :set_attachment, only: [

data/app/controllers/dorsale/application_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::ApplicationController < ::ApplicationController
+class Dorsale::ApplicationController < ApplicationController
   include Pundit::Authorization
   include Agilibox::BackUrlConcern
   include Agilibox::SortingHelper

data/app/controllers/dorsale/billing_machine/application_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::ApplicationController < ::Dorsale::ApplicationController
+class Dorsale::BillingMachine::ApplicationController < Dorsale::ApplicationController
   before_action :set_common_variables
 
   private
@@ -25,6 +25,6 @@ class Dorsale::BillingMachine::ApplicationController < ::Dorsale::ApplicationCon
   def email_params
     params.fetch(:email, {})
       .permit(email_permitted_params)
-      .merge(current_user: current_user)
+      .merge(current_user:)
   end
 end

data/app/controllers/dorsale/billing_machine/invoices_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::InvoicesController < ::Dorsale::BillingMachine::ApplicationController
+class Dorsale::BillingMachine::InvoicesController < Dorsale::BillingMachine::ApplicationController
   before_action :set_objects, only: [
     :show,
     :edit,

data/app/controllers/dorsale/billing_machine/payment_terms_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::PaymentTermsController < ::Dorsale::BillingMachine::ApplicationController
+class Dorsale::BillingMachine::PaymentTermsController < Dorsale::BillingMachine::ApplicationController
   before_action :set_objects, only: [:edit, :update]
 
   def index

data/app/controllers/dorsale/billing_machine/quotations_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::QuotationsController < ::Dorsale::BillingMachine::ApplicationController
+class Dorsale::BillingMachine::QuotationsController < Dorsale::BillingMachine::ApplicationController
   before_action :set_objects, only: [
     :show,
     :edit,

data/app/controllers/dorsale/comments_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::CommentsController < ::Dorsale::ApplicationController
+class Dorsale::CommentsController < Dorsale::ApplicationController
   before_action :set_objects, only: [
     :edit,
     :update,

data/app/controllers/dorsale/customer_vault/activity_types_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::ActivityTypesController < ::Dorsale::CustomerVault::ApplicationController
+class Dorsale::CustomerVault::ActivityTypesController < Dorsale::CustomerVault::ApplicationController
   before_action :set_objects, only: [:edit, :update]
 
   def index

data/app/controllers/dorsale/customer_vault/application_controller.rb

@@ -1,2 +1,2 @@
-class Dorsale::CustomerVault::ApplicationController < ::Dorsale::ApplicationController
+class Dorsale::CustomerVault::ApplicationController < Dorsale::ApplicationController
 end

data/app/controllers/dorsale/customer_vault/events_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::EventsController < ::Dorsale::CustomerVault::ApplicationController
+class Dorsale::CustomerVault::EventsController < Dorsale::CustomerVault::ApplicationController
   before_action :set_objects
 
   def index

data/app/controllers/dorsale/customer_vault/links_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::LinksController < ::Dorsale::CustomerVault::ApplicationController
+class Dorsale::CustomerVault::LinksController < Dorsale::CustomerVault::ApplicationController
   before_action :set_objects
 
   def index

data/app/controllers/dorsale/customer_vault/origins_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::OriginsController < ::Dorsale::CustomerVault::ApplicationController
+class Dorsale::CustomerVault::OriginsController < Dorsale::CustomerVault::ApplicationController
   before_action :set_objects, only: [:edit, :update]
 
   def index

data/app/controllers/dorsale/customer_vault/people_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::PeopleController < ::Dorsale::CustomerVault::ApplicationController
+class Dorsale::CustomerVault::PeopleController < Dorsale::CustomerVault::ApplicationController
   before_action :set_objects
 
   def index

data/app/controllers/dorsale/expense_gun/application_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::ExpenseGun::ApplicationController < ::Dorsale::ApplicationController
+class Dorsale::ExpenseGun::ApplicationController < Dorsale::ApplicationController
   before_action :set_form_variables
 
   def set_form_variables

data/app/controllers/dorsale/expense_gun/categories_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::ExpenseGun::CategoriesController < ::Dorsale::ExpenseGun::ApplicationController
+class Dorsale::ExpenseGun::CategoriesController < Dorsale::ExpenseGun::ApplicationController
   before_action :set_objects, only: [:edit, :update]
 
   def index

data/app/controllers/dorsale/flyboy/application_controller.rb

@@ -1,2 +1,2 @@
-class Dorsale::Flyboy::ApplicationController < ::Dorsale::ApplicationController
+class Dorsale::Flyboy::ApplicationController < Dorsale::ApplicationController
 end

data/app/controllers/dorsale/flyboy/task_comments_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::Flyboy::TaskCommentsController < ::Dorsale::Flyboy::ApplicationController
+class Dorsale::Flyboy::TaskCommentsController < Dorsale::Flyboy::ApplicationController
   def create
     skip_policy_scope
 

data/app/controllers/dorsale/flyboy/tasks_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::Flyboy::TasksController < ::Dorsale::Flyboy::ApplicationController
+class Dorsale::Flyboy::TasksController < Dorsale::Flyboy::ApplicationController
   include Dorsale::Flyboy::TasksSummaryConcern
 
   before_action :set_objects, only: [

data/app/controllers/dorsale/users_controller.rb

@@ -1,4 +1,4 @@
-class Dorsale::UsersController < ::Dorsale::ApplicationController
+class Dorsale::UsersController < Dorsale::ApplicationController
   before_action :set_objects, only: [
     :show,
     :edit,

data/app/filters/dorsale/billing_machine/small_data/filter_for_invoices.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::SmallData::FilterForInvoices < ::Agilibox::SmallData::Filter
+class Dorsale::BillingMachine::SmallData::FilterForInvoices < Agilibox::SmallData::Filter
   STRATEGIES = {
     "bm_time_period"    => ::Agilibox::SmallData::FilterStrategyByDatePeriod.new(:date),
     "bm_date_begin"     => ::Agilibox::SmallData::FilterStrategyByDateBegin.new(:date),

data/app/filters/dorsale/billing_machine/small_data/filter_for_quotations.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::SmallData::FilterForQuotations < ::Agilibox::SmallData::Filter
+class Dorsale::BillingMachine::SmallData::FilterForQuotations < Agilibox::SmallData::Filter
   STRATEGIES = {
     "bm_time_period"     => ::Agilibox::SmallData::FilterStrategyByDatePeriod.new(:date),
     "bm_date_begin"      => ::Agilibox::SmallData::FilterStrategyByDateBegin.new(:date),

data/app/filters/dorsale/billing_machine/small_data/filter_strategy_by_customer.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::SmallData::FilterStrategyByCustomer < ::Agilibox::SmallData::FilterStrategy
+class Dorsale::BillingMachine::SmallData::FilterStrategyByCustomer < Agilibox::SmallData::FilterStrategy
   def apply(query, value)
     type, id = value.split("-", 2)
     query.where(customer_type: type, customer_id: id)

data/app/filters/dorsale/billing_machine/small_data/filter_strategy_by_payment_status.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::SmallData::FilterStrategyByPaymentStatus < ::Agilibox::SmallData::FilterStrategy
+class Dorsale::BillingMachine::SmallData::FilterStrategyByPaymentStatus < Agilibox::SmallData::FilterStrategy
   def apply(query, value)
     table_name = query.model.table_name
 

data/app/filters/dorsale/billing_machine/small_data/filter_strategy_by_state.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::SmallData::FilterStrategyByState < ::Agilibox::SmallData::FilterStrategy
+class Dorsale::BillingMachine::SmallData::FilterStrategyByState < Agilibox::SmallData::FilterStrategy
   def apply(query, value)
     if (m = value.to_s.match(/not_(.+)/))
       query.where.not(state: m[1])

data/app/filters/dorsale/customer_vault/small_data/filter_for_events.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::SmallData::FilterForEvents < ::Agilibox::SmallData::Filter
+class Dorsale::CustomerVault::SmallData::FilterForEvents < Agilibox::SmallData::Filter
   STRATEGIES = {
     "event_action" => ::Agilibox::SmallData::FilterStrategyByKeyValues.new(:action),
   }

data/app/filters/dorsale/customer_vault/small_data/filter_for_people.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::SmallData::FilterForPeople < ::Agilibox::SmallData::Filter
+class Dorsale::CustomerVault::SmallData::FilterForPeople < Agilibox::SmallData::Filter
   STRATEGIES = {
     "person_type"     => ::Agilibox::SmallData::FilterStrategyByKeyValue.new(:type),
     "person_tags"     => ::Agilibox::SmallData::FilterStrategyByTags.new,

data/app/filters/dorsale/customer_vault/small_data/filter_strategy_by_activity_type.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::SmallData::FilterStrategyByActivityType < ::Agilibox::SmallData::FilterStrategy
+class Dorsale::CustomerVault::SmallData::FilterStrategyByActivityType < Agilibox::SmallData::FilterStrategy
   def apply(query, value)
     corporations_id = query.where(activity_type_id: value).pluck(:id)
     individuals_id  = query.where(corporation_id: corporations_id).pluck(:id)

data/app/filters/dorsale/expense_gun/small_data/filter_for_expenses.rb

@@ -1,4 +1,4 @@
-class Dorsale::ExpenseGun::SmallData::FilterForExpenses < ::Agilibox::SmallData::Filter
+class Dorsale::ExpenseGun::SmallData::FilterForExpenses < Agilibox::SmallData::Filter
   STRATEGIES = {
     "expense_state"       => ::Agilibox::SmallData::FilterStrategyByKeyValue.new("state"),
     "expense_user_id"     => ::Agilibox::SmallData::FilterStrategyByKeyValue.new("user_id"),

data/app/filters/dorsale/flyboy/small_data/filter_for_tasks.rb

@@ -1,4 +1,4 @@
-class Dorsale::Flyboy::SmallData::FilterForTasks < ::Agilibox::SmallData::Filter
+class Dorsale::Flyboy::SmallData::FilterForTasks < Agilibox::SmallData::Filter
   STRATEGIES = {
     "fb_state" => ::Dorsale::Flyboy::SmallData::FilterStrategyByTaskState.new,
     "fb_owner" => ::Agilibox::SmallData::FilterStrategyByKeyValue.new(:owner_id),

data/app/filters/dorsale/flyboy/small_data/filter_strategy_by_task_state.rb

@@ -1,5 +1,5 @@
-class Dorsale::Flyboy::SmallData::FilterStrategyByTaskState < ::Agilibox::SmallData::FilterStrategy
-  STATES = Dorsale::Flyboy::Task::STATES + %w(on_warning_or_alert)
+class Dorsale::Flyboy::SmallData::FilterStrategyByTaskState < Agilibox::SmallData::FilterStrategy
+  STATES = Dorsale::Flyboy::Task::STATES + %w[on_warning_or_alert]
 
   def apply(query, value)
     if value.in?(STATES)

data/app/helpers/dorsale/alexandrie/attachments_helper.rb

@@ -1,5 +1,5 @@
 module Dorsale::Alexandrie::AttachmentsHelper
   def attachments_for(attachable)
-    render "dorsale/alexandrie/attachments/loader", attachable: attachable
+    render "dorsale/alexandrie/attachments/loader", attachable:
   end
 end

data/app/helpers/dorsale/comments_helper.rb

@@ -1,6 +1,6 @@
 module Dorsale::CommentsHelper
   def comments_for(commentable)
-    comments    = policy_scope(::Dorsale::Comment).where(commentable: commentable)
+    comments    = policy_scope(::Dorsale::Comment).where(commentable:)
     new_comment = new_comment_for(commentable)
 
     render(
@@ -13,7 +13,7 @@ module Dorsale::CommentsHelper
   end
 
   def new_comment_for(commentable)
-    policy_scope(Dorsale::Comment).new(commentable: commentable, author: current_user)
+    policy_scope(Dorsale::Comment).new(commentable:, author: current_user)
   end
 
   def truncate_comments_in_this_page?

data/app/helpers/dorsale/customer_vault/application_helper.rb

@@ -55,7 +55,7 @@ module Dorsale::CustomerVault::ApplicationHelper
   end
 
   def new_event_for(person)
-    policy_scope(Dorsale::CustomerVault::Event).new(person: person, author: current_user)
+    policy_scope(Dorsale::CustomerVault::Event).new(person:, author: current_user)
   end
 
   def customer_vault_tag_list

data/app/helpers/dorsale/flyboy/application_helper.rb

@@ -14,11 +14,11 @@ module Dorsale::Flyboy::ApplicationHelper
       end
     end
 
-    tasks = ::Dorsale::Flyboy::Task.where(taskable: taskable)
+    tasks = ::Dorsale::Flyboy::Task.where(taskable:)
     tasks = @filters.apply(tasks)
     tasks = tasks.order(order)
 
-    render "dorsale/flyboy/tasks/tasks_for_taskable", tasks: tasks, taskable: taskable
+    render "dorsale/flyboy/tasks/tasks_for_taskable", tasks:, taskable:
   end
 
   def show_tasks_summary

data/app/mailers/dorsale/application_mailer.rb

@@ -1,3 +1,3 @@
-class Dorsale::ApplicationMailer < ::ApplicationMailer
+class Dorsale::ApplicationMailer < ApplicationMailer
   helper Dorsale::AllHelpers
 end

data/app/mailers/dorsale/flyboy/task_mailer.rb

@@ -1,4 +1,4 @@
-class Dorsale::Flyboy::TaskMailer < ::Dorsale::ApplicationMailer
+class Dorsale::Flyboy::TaskMailer < Dorsale::ApplicationMailer
   def new_task(task, author)
     @task = task
 

data/app/mailers/dorsale/user_mailer.rb

@@ -1,4 +1,4 @@
-class Dorsale::UserMailer < ::Dorsale::ApplicationMailer
+class Dorsale::UserMailer < Dorsale::ApplicationMailer
   def new_account(user, password)
     @user     = user
     @password = password

data/app/models/dorsale/address.rb

@@ -1,10 +1,10 @@
-class Dorsale::Address < ::Dorsale::ApplicationRecord
+class Dorsale::Address < Dorsale::ApplicationRecord
   belongs_to :addressable, polymorphic: true, inverse_of: :address
 
   validates :addressable, presence: true
 
   def one_line
-    zip_city = [zip, city].select(&:present?).join(" ")
-    [street, street_bis, zip_city, country].select(&:present?).join(", ")
+    zip_city = [zip, city].compact_blank.join(" ")
+    [street, street_bis, zip_city, country].compact_blank.join(", ")
   end
 end

data/app/models/dorsale/alexandrie/attachment.rb

@@ -1,4 +1,4 @@
-class Dorsale::Alexandrie::Attachment < ::Dorsale::ApplicationRecord
+class Dorsale::Alexandrie::Attachment < Dorsale::ApplicationRecord
   self.table_name = "dorsale_alexandrie_attachments"
 
   belongs_to :attachable, polymorphic: true

data/app/models/dorsale/alexandrie/attachment_type.rb

@@ -1,4 +1,4 @@
-class Dorsale::Alexandrie::AttachmentType < ::Dorsale::ApplicationRecord
+class Dorsale::Alexandrie::AttachmentType < Dorsale::ApplicationRecord
   self.table_name = "dorsale_alexandrie_attachment_types"
 
   has_many :attachments, dependent: :nullify

data/app/models/dorsale/billing_machine/invoice.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::Invoice < ::Dorsale::ApplicationRecord
+class Dorsale::BillingMachine::Invoice < Dorsale::ApplicationRecord
   self.table_name = "dorsale_billing_machine_invoices"
 
   belongs_to :customer, polymorphic: true

data/app/models/dorsale/billing_machine/invoice_line.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::InvoiceLine < ::Dorsale::ApplicationRecord
+class Dorsale::BillingMachine::InvoiceLine < Dorsale::ApplicationRecord
   self.table_name = "dorsale_billing_machine_invoice_lines"
 
   belongs_to :invoice, inverse_of: :lines

data/app/models/dorsale/billing_machine/payment_term.rb

@@ -1,3 +1,3 @@
-class Dorsale::BillingMachine::PaymentTerm < ::Dorsale::ApplicationRecord
+class Dorsale::BillingMachine::PaymentTerm < Dorsale::ApplicationRecord
   self.table_name = "dorsale_billing_machine_payment_terms"
 end

data/app/models/dorsale/billing_machine/quotation.rb

@@ -1,7 +1,7 @@
-class Dorsale::BillingMachine::Quotation < ::Dorsale::ApplicationRecord
+class Dorsale::BillingMachine::Quotation < Dorsale::ApplicationRecord
   self.table_name = "dorsale_billing_machine_quotations"
 
-  STATES = %w(draft pending accepted refused canceled)
+  STATES = %w[draft pending accepted refused canceled]
 
   belongs_to :customer, polymorphic: true
   belongs_to :payment_term
@@ -85,12 +85,6 @@ class Dorsale::BillingMachine::Quotation < ::Dorsale::ApplicationRecord
     self.total_including_taxes = total_excluding_taxes + vat_amount
   end
 
-  # rubocop:disable Style/SingleLineMethods
-  private def total_excluding_taxes=(*); super; end
-  private def vat_amount=(*);            super; end
-  private def total_including_taxes=(*); super; end
-  # rubocop:enable Style/SingleLineMethods
-
   def balance
     total_including_taxes
   end
@@ -124,4 +118,10 @@ class Dorsale::BillingMachine::Quotation < ::Dorsale::ApplicationRecord
   def on_attachment_action(_attachment, _action)
     Dorsale::BillingMachine::PdfFileGenerator.(self)
   end
+
+  # rubocop:disable Style/SingleLineMethods
+  private def total_excluding_taxes=(*); super; end
+  private def vat_amount=(*);            super; end
+  private def total_including_taxes=(*); super; end
+  # rubocop:enable Style/SingleLineMethods
 end

data/app/models/dorsale/billing_machine/quotation_line.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::QuotationLine < ::Dorsale::ApplicationRecord
+class Dorsale::BillingMachine::QuotationLine < Dorsale::ApplicationRecord
   self.table_name = "dorsale_billing_machine_quotation_lines"
 
   belongs_to :quotation, inverse_of: :lines

data/app/models/dorsale/comment.rb

@@ -1,4 +1,4 @@
-class Dorsale::Comment < ::Dorsale::ApplicationRecord
+class Dorsale::Comment < Dorsale::ApplicationRecord
   belongs_to :author, class_name: "User"
   belongs_to :commentable, polymorphic: true
 

data/app/models/dorsale/customer_vault/activity_type.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::ActivityType < ::Dorsale::ApplicationRecord
+class Dorsale::CustomerVault::ActivityType < Dorsale::ApplicationRecord
   self.table_name = "dorsale_customer_vault_activity_types"
 
   validates :name, presence: true

data/app/models/dorsale/customer_vault/corporation.rb

@@ -1,5 +1,5 @@
 class Dorsale::CustomerVault::Corporation < Dorsale::CustomerVault::Person
-  data_attributes = %i(
+  data_attributes = %i[
     legal_form
     immatriculation_number
     naf
@@ -8,7 +8,7 @@ class Dorsale::CustomerVault::Corporation < Dorsale::CustomerVault::Person
     capital
     revenue
     number_of_employees
-  )
+  ]
   store :data, accessors: data_attributes, coder: JSON
 
   validates :corporation_name, presence: true

data/app/models/dorsale/customer_vault/event.rb

@@ -1,8 +1,8 @@
-class Dorsale::CustomerVault::Event < ::Dorsale::ApplicationRecord
+class Dorsale::CustomerVault::Event < Dorsale::ApplicationRecord
   self.table_name = :dorsale_customer_vault_events
 
-  ACTIONS       = %w(create update comment)
-  CONTACT_TYPES = %w(contact r1 r2)
+  ACTIONS       = %w[create update comment]
+  CONTACT_TYPES = %w[contact r1 r2]
 
   belongs_to :author,  class_name: "User"
   belongs_to :person,  class_name: "Dorsale::CustomerVault::Person"

data/app/models/dorsale/customer_vault/individual.rb

@@ -1,7 +1,7 @@
 class Dorsale::CustomerVault::Individual < Dorsale::CustomerVault::Person
-  data_attributes = %i(
+  data_attributes = %i[
     title
-  )
+  ]
   store :data, accessors: data_attributes, coder: JSON
 
   validates :first_name, presence: true

data/app/models/dorsale/customer_vault/link.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::Link < ::Dorsale::ApplicationRecord
+class Dorsale::CustomerVault::Link < Dorsale::ApplicationRecord
   self.table_name = "dorsale_customer_vault_links"
 
   belongs_to :alice, class_name: "Dorsale::CustomerVault::Person"

data/app/models/dorsale/customer_vault/origin.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::Origin < ::Dorsale::ApplicationRecord
+class Dorsale::CustomerVault::Origin < Dorsale::ApplicationRecord
   self.table_name = "dorsale_customer_vault_origins"
 
   validates :name, presence: true

data/app/models/dorsale/customer_vault/person.rb

@@ -1,4 +1,4 @@
-class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
+class Dorsale::CustomerVault::Person < Dorsale::ApplicationRecord
   self.table_name = "dorsale_customer_vault_people"
 
   extend Forwardable
@@ -57,8 +57,8 @@ class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
 
   def taken_emails
     taken_emails = {}
-    ([email] + secondary_emails).select(&:present?).each do |e|
-      person = Dorsale::CustomerVault::Person.where.not(id: id).having_email(e).first
+    ([email] + secondary_emails).compact_blank.each do |e|
+      person = Dorsale::CustomerVault::Person.where.not(id:).having_email(e).first
       taken_emails[e] = person if person.present?
     end
     taken_emails
@@ -71,7 +71,7 @@ class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
       errors.add(:email, :taken)
     end
 
-    if (taken_emails.keys & secondary_emails).any?
+    if taken_emails.keys.intersect?(secondary_emails)
       errors.add(:secondary_emails, :taken)
       errors.add(:secondary_emails_str, :taken)
     end
@@ -101,8 +101,8 @@ class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
     person_type == :individual
   end
 
-  def tags_on(*args)
-    super(*args).order(:name)
+  def tags_on(*)
+    super.order(:name)
   end
 
   def links

data/app/models/dorsale/expense_gun/category.rb

@@ -1,4 +1,4 @@
-class Dorsale::ExpenseGun::Category < ::Dorsale::ApplicationRecord
+class Dorsale::ExpenseGun::Category < Dorsale::ApplicationRecord
   self.table_name = "dorsale_expense_gun_categories"
 
   validates :name, presence: true

data/app/models/dorsale/expense_gun/expense.rb

@@ -1,7 +1,7 @@
-class Dorsale::ExpenseGun::Expense < ::Dorsale::ApplicationRecord
+class Dorsale::ExpenseGun::Expense < Dorsale::ApplicationRecord
   self.table_name = "dorsale_expense_gun_expenses"
 
-  STATES = %w(draft pending paid canceled)
+  STATES = %w[draft pending paid canceled]
 
   has_many :expense_lines, inverse_of: :expense, dependent: :destroy, class_name: "Dorsale::ExpenseGun::ExpenseLine"
 

data/app/models/dorsale/expense_gun/expense_line.rb

@@ -1,4 +1,4 @@
-class Dorsale::ExpenseGun::ExpenseLine < ::Dorsale::ApplicationRecord
+class Dorsale::ExpenseGun::ExpenseLine < Dorsale::ApplicationRecord
   self.table_name = "dorsale_expense_gun_expense_lines"
 
   belongs_to :expense,  class_name: "Dorsale::ExpenseGun::Expense"

data/app/models/dorsale/flyboy/task.rb

@@ -1,11 +1,11 @@
-class Dorsale::Flyboy::Task < ::Dorsale::ApplicationRecord
+class Dorsale::Flyboy::Task < Dorsale::ApplicationRecord
   include ::Agilibox::Search
 
   self.table_name = "dorsale_flyboy_tasks"
 
-  REMINDER_TYPES = %w(duration custom)
-  REMINDER_UNITS = %w(days weeks months)
-  STATES         = %w(done undone ontime onwarning onalert)
+  REMINDER_TYPES = %w[duration custom]
+  REMINDER_UNITS = %w[days weeks months]
+  STATES         = %w[done undone ontime onwarning onalert]
 
   paginates_per 50
 
@@ -120,7 +120,7 @@ class Dorsale::Flyboy::Task < ::Dorsale::ApplicationRecord
 
     comments.create!(
       :progress    => progress,
-      :description => I18n.t("messages.tasks.snoozed", old_date: old_date, new_date: new_date),
+      :description => I18n.t("messages.tasks.snoozed", old_date:, new_date:),
       :author      => author,
     )
   end

data/app/models/dorsale/flyboy/task_comment.rb

@@ -1,4 +1,4 @@
-class Dorsale::Flyboy::TaskComment < ::Dorsale::ApplicationRecord
+class Dorsale::Flyboy::TaskComment < Dorsale::ApplicationRecord
   self.table_name = "dorsale_flyboy_task_comments"
 
   belongs_to :task

data/app/pdfs/dorsale/application_pdf.rb

@@ -9,7 +9,7 @@ class Dorsale::ApplicationPdf < Prawn::Document
   # Pour le dev
   def open!
     build
-    f = Tempfile.new(%w(pdf pdf))
+    f = Tempfile.new(%w[pdf pdf])
     f.binmode
     f.write(render_with_attachments)
     Launchy.open(f.path)