dorsale 3.20.0 → 4.1.0

data/lib/dorsale/engine.rb

@@ -23,7 +23,7 @@ require "axlsx"
 
 require "agilibox"
 
-if Rails.env.test? || Rails.env.development?
+if Rails.env.local?
   require "pry"
   require "factory_bot_rails"
   require "factory_bot"
@@ -35,8 +35,14 @@ module Dorsale
   class Engine < ::Rails::Engine
     isolate_namespace Dorsale
 
+    initializer "inflections" do
+      ActiveSupport::Inflector.inflections(:en) do |inflect|
+        inflect.acronym "DH"
+      end
+    end
+
     initializer "factory_bot" do
-      if Rails.env.test? || Rails.env.development?
+      if Rails.env.local?
         FactoryBot.definition_file_paths.unshift Dorsale::Engine.root.join("spec/factories/").to_s
       end
     end
@@ -48,13 +54,13 @@ module Dorsale
     end
 
     config.after_initialize do
-      Dorsale::PolicyChecker.check! if Rails.env.test? || Rails.env.development?
+      Dorsale::PolicyChecker.check! if Rails.env.local?
     end
 
     initializer "assets" do
-      Rails.application.config.assets.precompile += %w(
+      Rails.application.config.assets.precompile += %w[
         dorsale/avatar.png
-      )
+      ]
     end
 
     initializer "simple_form" do

data/lib/dorsale/version.rb

@@ -1,3 +1,3 @@
 module Dorsale
-  VERSION = "3.20.0"
+  VERSION = "4.1.0"
 end

data/spec/controllers/dorsale/alexandrie/attachments_controller_spec.rb

@@ -133,7 +133,7 @@ describe Dorsale::Alexandrie::AttachmentsController, type: :controller do
     it "should delete attachment" do
       expect {
         delete :destroy, params: {id: attachment}
-      }.to change(::Dorsale::Alexandrie::Attachment, :count).by(-1)
+      }.to change(Dorsale::Alexandrie::Attachment, :count).by(-1)
     end
 
     it "should render list" do

data/spec/controllers/dorsale/customer_vault/events_controller_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-describe ::Dorsale::CustomerVault::EventsController, type: :controller do
+describe Dorsale::CustomerVault::EventsController, type: :controller do
   routes { Dorsale::Engine.routes }
 
   let(:user) { create(:user) }

data/spec/controllers/dorsale/customer_vault/people_controller_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe ::Dorsale::CustomerVault::PeopleController, type: :controller do
+RSpec.describe Dorsale::CustomerVault::PeopleController, type: :controller do
   routes { Dorsale::Engine.routes }
 
   let(:user) { create(:user) }
@@ -57,7 +57,7 @@ RSpec.describe ::Dorsale::CustomerVault::PeopleController, type: :controller do
 
       it "should filter by person origin" do
         origin      = create(:customer_vault_origin)
-        individual1 = create(:customer_vault_individual, origin: origin)
+        individual1 = create(:customer_vault_individual, origin:)
         individual2 = create(:customer_vault_individual)
 
         cookies[:filters] = {person_origin: origin.id}.to_json
@@ -68,7 +68,7 @@ RSpec.describe ::Dorsale::CustomerVault::PeopleController, type: :controller do
 
       it "should filter by person activity_type" do
         activity_type = create(:customer_vault_activity_type)
-        corporation1  = create(:customer_vault_corporation, activity_type: activity_type)
+        corporation1  = create(:customer_vault_corporation, activity_type:)
         corporation2  = create(:customer_vault_corporation)
 
         cookies[:filters] = {person_activity: activity_type.id}.to_json

data/spec/controllers/dorsale/expense_gun/expenses_controller_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe ::Dorsale::ExpenseGun::ExpensesController, type: :controller do
+RSpec.describe Dorsale::ExpenseGun::ExpensesController, type: :controller do
   routes { Dorsale::Engine.routes }
   let(:user) { create(:user) }
   before(:each) { sign_in(user) }
@@ -66,7 +66,7 @@ RSpec.describe ::Dorsale::ExpenseGun::ExpensesController, type: :controller do
     render_views
 
     it "should be ok as PDF" do
-      expense = create(:expense_gun_expense, user: user)
+      expense = create(:expense_gun_expense, user:)
       get :show, params: {id: expense, format: :pdf}
       expect(response).to be_ok
     end
@@ -74,7 +74,7 @@ RSpec.describe ::Dorsale::ExpenseGun::ExpensesController, type: :controller do
 
   describe "#go_to_pending" do
     it "should go to pending and redirect" do
-      expense = create(:expense_gun_expense, user: user, state: "draft")
+      expense = create(:expense_gun_expense, user:, state: "draft")
       post :go_to_pending, params: {id: expense}
       expect(response).to be_redirect
       expect(flash.notice).to be_present
@@ -84,7 +84,7 @@ RSpec.describe ::Dorsale::ExpenseGun::ExpensesController, type: :controller do
 
   describe "#go_to_paid" do
     it "should go to paid and redirect" do
-      expense = create(:expense_gun_expense, user: user, state: "pending")
+      expense = create(:expense_gun_expense, user:, state: "pending")
       post :go_to_paid, params: {id: expense}
       expect(response).to be_redirect
       expect(flash.notice).to be_present
@@ -94,7 +94,7 @@ RSpec.describe ::Dorsale::ExpenseGun::ExpensesController, type: :controller do
 
   describe "#go_to_canceled" do
     it "should go to canceled and redirect" do
-      expense = create(:expense_gun_expense, user: user, state: "draft")
+      expense = create(:expense_gun_expense, user:, state: "draft")
       post :go_to_canceled, params: {id: expense}
       expect(response).to be_redirect
       expect(flash.notice).to be_present

data/spec/controllers/dorsale/flyboy/task_comments_controller_spec.rb

@@ -8,7 +8,7 @@ describe Dorsale::Flyboy::TaskCommentsController, type: :controller do
   before(:each) { sign_in(user) }
 
   let(:task)         { create(:flyboy_task) }
-  let(:task_comment) { create(:flyboy_task_comment, task: task) }
+  let(:task_comment) { create(:flyboy_task_comment, task:) }
 
   describe "#create" do
     let(:valid_params) { {task_id: task.id, task_comment: task_comment.attributes} }

data/spec/controllers/dorsale/flyboy/tasks_controller_spec.rb

@@ -20,7 +20,7 @@ describe Dorsale::Flyboy::TasksController, type: :controller do
 
   describe "#complete" do
     before(:each) do
-      request.env["HTTP_REFERER"] = "where_i_came_from"
+      request.env["HTTP_REFERER"] = "/where_i_came_from"
     end
 
     it "should mark the task as done" do
@@ -42,7 +42,7 @@ describe Dorsale::Flyboy::TasksController, type: :controller do
 
     it "should redirect to the referer page" do
       patch :complete, params: {id: task.id}
-      expect(response).to redirect_to "where_i_came_from"
+      expect(response).to redirect_to "/where_i_came_from"
     end
   end
 

data/spec/factories/alexandrie_attachment_types.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :alexandrie_attachment_type, class: ::Dorsale::Alexandrie::AttachmentType do
+  factory :alexandrie_attachment_type, class: Dorsale::Alexandrie::AttachmentType do
     name { Faker::Lorem.words.join(" ") }
   end
 end

data/spec/factories/alexandrie_attachments.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :alexandrie_attachment, class: ::Dorsale::Alexandrie::Attachment do
+  factory :alexandrie_attachment, class: Dorsale::Alexandrie::Attachment do
     attachable {
       DummyModel.create!(name: "abc")
     }

data/spec/factories/billing_machine_invoice_lines.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :billing_machine_invoice_line, class: ::Dorsale::BillingMachine::InvoiceLine do
+  factory :billing_machine_invoice_line, class: Dorsale::BillingMachine::InvoiceLine do
     invoice    { create(:billing_machine_invoice) }
     label      { "Invoice line" + Faker::Lorem.words.join(" ") }
     quantity   { 10 }

data/spec/factories/billing_machine_invoices.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :billing_machine_invoice, class: ::Dorsale::BillingMachine::Invoice do
+  factory :billing_machine_invoice, class: Dorsale::BillingMachine::Invoice do
     customer     { create(:customer_vault_corporation) }
     payment_term { create(:billing_machine_payment_term) }
     date         { "2014-02-19" }

data/spec/factories/billing_machine_payment_terms.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :billing_machine_payment_term, class: ::Dorsale::BillingMachine::PaymentTerm do
+  factory :billing_machine_payment_term, class: Dorsale::BillingMachine::PaymentTerm do
     label { "Payment term " + Faker::Lorem.words.join(" ") }
   end
 end

data/spec/factories/billing_machine_quotation_lines.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :billing_machine_quotation_line, class: ::Dorsale::BillingMachine::QuotationLine do
+  factory :billing_machine_quotation_line, class: Dorsale::BillingMachine::QuotationLine do
     quotation  { create(:billing_machine_quotation) }
     label      { "Quotation line" + Faker::Lorem.words.join(" ") }
     quantity   { 10 }

data/spec/factories/billing_machine_quotations.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :billing_machine_quotation, class: ::Dorsale::BillingMachine::Quotation do
+  factory :billing_machine_quotation, class: Dorsale::BillingMachine::Quotation do
     customer     { create(:customer_vault_corporation) }
     payment_term { create(:billing_machine_payment_term) }
     date         { "2014-02-19" }

data/spec/factories/customer_vault_activity_types.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :customer_vault_activity_type, class: ::Dorsale::CustomerVault::ActivityType do
+  factory :customer_vault_activity_type, class: Dorsale::CustomerVault::ActivityType do
     name { Faker::Lorem.word }
   end
 end

data/spec/factories/customer_vault_corporations.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :customer_vault_corporation, class: ::Dorsale::CustomerVault::Corporation do
+  factory :customer_vault_corporation, class: Dorsale::CustomerVault::Corporation do
     activity_type { create(:customer_vault_activity_type)             }
     origin        { create(:customer_vault_origin)                    }
     name          { "#{Faker::Company.name} #{Faker::Company.suffix}" }

data/spec/factories/customer_vault_event.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :customer_vault_event, class: ::Dorsale::CustomerVault::Event do
+  factory :customer_vault_event, class: Dorsale::CustomerVault::Event do
     author { build(:user)                       }
     person { build(:customer_vault_corporation) }
     action { "create"                           }

data/spec/factories/customer_vault_individuals.rb

@@ -1,10 +1,10 @@
 FactoryBot.define do
-  factory :customer_vault_individual, class: ::Dorsale::CustomerVault::Individual do
+  factory :customer_vault_individual, class: Dorsale::CustomerVault::Individual do
     origin     { create(:customer_vault_origin)    }
     first_name { Faker::Name.first_name            }
     last_name  { Faker::Name.last_name             }
     short_name { "SN"                              }
-    email      { Faker::Internet.email(name: name) }
+    email      { Faker::Internet.email(name:) }
     title      { "Individual-Title"                }
     twitter    { "#{first_name}#{last_name}"       }
     www        { Faker::Internet.url               }

data/spec/factories/customer_vault_links.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :customer_vault_link, class: ::Dorsale::CustomerVault::Link do
+  factory :customer_vault_link, class: Dorsale::CustomerVault::Link do
     association :alice, factory: :customer_vault_individual
     association :bob,   factory: :customer_vault_corporation
     title { "Manager" }

data/spec/factories/customer_vault_origins.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :customer_vault_origin, class: ::Dorsale::CustomerVault::Origin do
+  factory :customer_vault_origin, class: Dorsale::CustomerVault::Origin do
     name { Faker::Lorem.word }
   end
 end

data/spec/factories/dorsale_addresses.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :dorsale_address, class: ::Dorsale::Address do
+  factory :dorsale_address, class: Dorsale::Address do
     street     { "3 Rue Marx Dormoy" }
     street_bis { "1er étage" }
     city       { "Marseille" }

data/spec/factories/dorsale_comments.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :dorsale_comment, class: ::Dorsale::Comment do
+  factory :dorsale_comment, class: Dorsale::Comment do
     commentable { create(:customer_vault_corporation) }
     author      { create(:user)                       }
     text        { Faker::Lorem.paragraph              }

data/spec/factories/expense_gun_categories.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :expense_gun_category, class: ::Dorsale::ExpenseGun::Category do
+  factory :expense_gun_category, class: Dorsale::ExpenseGun::Category do
     name           { Faker::Lorem.word               }
     code           { Faker::Number.number(digits: 4) }
     vat_deductible { [true, false].sample            }

data/spec/factories/expense_gun_expense_lines.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :expense_gun_expense_line, class: ::Dorsale::ExpenseGun::ExpenseLine do
+  factory :expense_gun_expense_line, class: Dorsale::ExpenseGun::ExpenseLine do
     expense         { build(:expense_gun_expense)          }
     name            { Faker::Lorem.sentence(word_count: 3) }
     category        { build(:expense_gun_category)         }

data/spec/factories/expense_gun_expenses.rb

@@ -1,12 +1,12 @@
 FactoryBot.define do
-  factory :expense_gun_expense, class: ::Dorsale::ExpenseGun::Expense do
+  factory :expense_gun_expense, class: Dorsale::ExpenseGun::Expense do
     name { Faker::Lorem.sentence(word_count: 3) }
     date { Date.current }
     user { create(:user) }
 
     after(:create) { |expense|
       rand(2..5).times {
-        create(:expense_gun_expense_line, expense: expense)
+        create(:expense_gun_expense_line, expense:)
       }
     }
   end

data/spec/factories/flyboy_task_comments.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :flyboy_task_comment, class: ::Dorsale::Flyboy::TaskComment do
+  factory :flyboy_task_comment, class: Dorsale::Flyboy::TaskComment do
     task { create(:flyboy_task) }
     date { Time.zone.now }
     progress { 95 }

data/spec/factories/flyboy_tasks.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :flyboy_task, class: ::Dorsale::Flyboy::Task do
+  factory :flyboy_task, class: Dorsale::Flyboy::Task do
     name        { "I-am-a-task#{Kernel.rand(1_000..9_999)}" }
     description { "I-am-the-task-description_#{Kernel.rand(1_000..9_999)}" }
     progress    { Kernel.rand(0..99) }

data/spec/mailers/user_mailer_spec.rb

@@ -1,9 +1,9 @@
 require "rails_helper"
 
-describe ::Dorsale::UserMailer do
+describe Dorsale::UserMailer do
   describe "New Account" do
     let(:user) { create(:user) }
-    let(:email) { ::Dorsale::UserMailer.new_account(user, user.password) }
+    let(:email) { Dorsale::UserMailer.new_account(user, user.password) }
 
     it "should send to the right person" do
       expect(email.to).to eq([user.email])

data/spec/models/dorsale/alexandrie/attachment_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-describe ::Dorsale::Alexandrie::Attachment, type: :model do
+describe Dorsale::Alexandrie::Attachment, type: :model do
   it { is_expected.to belong_to :attachable }
   it { is_expected.to belong_to :sender }
   it { is_expected.to belong_to :attachment_type }

data/spec/models/dorsale/alexandrie/attachment_type_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-describe ::Dorsale::Alexandrie::AttachmentType, type: :model do
+describe Dorsale::Alexandrie::AttachmentType, type: :model do
   it { is_expected.to have_many(:attachments).dependent(:nullify) }
 
   it { is_expected.to validate_presence_of :name }

data/spec/models/dorsale/billing_machine/invoice_line_spec.rb

@@ -30,11 +30,11 @@ describe Dorsale::BillingMachine::InvoiceLine, type: :model do
   end
 
   it "should be sorted by created_at" do
-    line1 = create(:billing_machine_invoice_line, :created_at => Time.zone.now + 1.minute)
-    line2 = create(:billing_machine_invoice_line, :created_at => Time.zone.now + 2.minutes)
-    line3 = create(:billing_machine_invoice_line, :created_at => Time.zone.now + 3.minutes)
-    line4 = create(:billing_machine_invoice_line, :created_at => Time.zone.now + 4.minutes)
-    line3.update!(:created_at => Time.zone.now + 5.minutes)
+    line1 = create(:billing_machine_invoice_line, :created_at => 1.minute.from_now)
+    line2 = create(:billing_machine_invoice_line, :created_at => 2.minutes.from_now)
+    line3 = create(:billing_machine_invoice_line, :created_at => 3.minutes.from_now)
+    line4 = create(:billing_machine_invoice_line, :created_at => 4.minutes.from_now)
+    line3.update!(:created_at => 5.minutes.from_now)
 
     lines = described_class.all
     expect(lines).to eq [line1, line2, line4, line3]

data/spec/models/dorsale/billing_machine/invoice_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 describe Dorsale::BillingMachine::Invoice, type: :model do
   # Reset to default mode before each test
   before :each do
-    ::Dorsale::BillingMachine.vat_mode = :single
+    Dorsale::BillingMachine.vat_mode = :single
   end
 
   it { is_expected.to belong_to :customer }
@@ -105,8 +105,8 @@ describe Dorsale::BillingMachine::Invoice, type: :model do
 
     it "should work fine upon creation" do
       invoice = build(:billing_machine_invoice)
-      invoice.lines << ::Dorsale::BillingMachine::InvoiceLine.new(quantity: 1, unit_price: 10)
-      invoice.lines << ::Dorsale::BillingMachine::InvoiceLine.new(quantity: 1, unit_price: 10)
+      invoice.lines << Dorsale::BillingMachine::InvoiceLine.new(quantity: 1, unit_price: 10)
+      invoice.lines << Dorsale::BillingMachine::InvoiceLine.new(quantity: 1, unit_price: 10)
       invoice.save!
     end
   end
@@ -120,7 +120,7 @@ describe Dorsale::BillingMachine::Invoice, type: :model do
 
   describe "vat rate" do
     it "default vat rate should be 20" do
-      expect(described_class.new.vat_rate).to eq ::Dorsale::BillingMachine.default_vat_rate
+      expect(described_class.new.vat_rate).to eq Dorsale::BillingMachine.default_vat_rate
     end
 
     it "it should be specified vat rate" do
@@ -129,22 +129,22 @@ describe Dorsale::BillingMachine::Invoice, type: :model do
 
     it "it should be first line vat rate" do
       invoice = create(:billing_machine_invoice)
-      line1   = create(:billing_machine_invoice_line, invoice: invoice, vat_rate: 10)
-      line2   = create(:billing_machine_invoice_line, invoice: invoice, vat_rate: 10)
+      line1   = create(:billing_machine_invoice_line, invoice:, vat_rate: 10)
+      line2   = create(:billing_machine_invoice_line, invoice:, vat_rate: 10)
       expect(invoice.vat_rate).to eq 10
     end
 
     it "it should raise if multiple vat_rates" do
       invoice = create(:billing_machine_invoice)
-      line1   = create(:billing_machine_invoice_line, invoice: invoice, vat_rate: 10)
+      line1   = create(:billing_machine_invoice_line, invoice:, vat_rate: 10)
 
       expect {
-        line2 = create(:billing_machine_invoice_line, invoice: invoice, vat_rate: 15)
+        line2 = create(:billing_machine_invoice_line, invoice:, vat_rate: 15)
       }.to raise_error(RuntimeError)
     end
 
     it "it should raise when vat mode is multiple" do
-      ::Dorsale::BillingMachine.vat_mode = :multiple
+      Dorsale::BillingMachine.vat_mode = :multiple
       invoice = build(:billing_machine_invoice)
       expect { invoice.vat_rate }.to raise_error(RuntimeError)
     end
@@ -247,7 +247,7 @@ describe Dorsale::BillingMachine::Invoice, type: :model do
     it "should work fine even with empty lines" do
       invoice = create(:billing_machine_invoice)
 
-      create(:billing_machine_invoice_line, invoice: invoice, quantity: nil, unit_price: nil)
+      create(:billing_machine_invoice_line, invoice:, quantity: nil, unit_price: nil)
 
       expect(invoice.total_excluding_taxes).to eq(0.0)
       expect(invoice.vat_amount).to eq(0)

data/spec/models/dorsale/billing_machine/quotation_line_spec.rb

@@ -25,16 +25,16 @@ describe Dorsale::BillingMachine::QuotationLine do
     end
 
     it "vat_rate should be 0" do
-      expect(described_class.new.vat_rate).to eq ::Dorsale::BillingMachine.default_vat_rate
+      expect(described_class.new.vat_rate).to eq Dorsale::BillingMachine.default_vat_rate
     end
   end
 
   it "should be sorted by created_at" do
-    line1 = create(:billing_machine_quotation_line, :created_at => Time.zone.now + 1.minute)
-    line2 = create(:billing_machine_quotation_line, :created_at => Time.zone.now + 2.minutes)
-    line3 = create(:billing_machine_quotation_line, :created_at => Time.zone.now + 3.minutes)
-    line4 = create(:billing_machine_quotation_line, :created_at => Time.zone.now + 4.minutes)
-    line3.update!(:created_at => Time.zone.now + 5.minutes)
+    line1 = create(:billing_machine_quotation_line, :created_at => 1.minute.from_now)
+    line2 = create(:billing_machine_quotation_line, :created_at => 2.minutes.from_now)
+    line3 = create(:billing_machine_quotation_line, :created_at => 3.minutes.from_now)
+    line4 = create(:billing_machine_quotation_line, :created_at => 4.minutes.from_now)
+    line3.update!(:created_at => 5.minutes.from_now)
     lines = described_class.all
     expect(lines).to eq [line1, line2, line4, line3]
   end

data/spec/models/dorsale/billing_machine/quotation_spec.rb

@@ -42,8 +42,8 @@ describe Dorsale::BillingMachine::Quotation do
 
   it "should work fine upon creation" do
     quotation = build(:billing_machine_quotation)
-    quotation.lines << ::Dorsale::BillingMachine::QuotationLine.new(quantity: 1, unit_price: 10)
-    quotation.lines << ::Dorsale::BillingMachine::QuotationLine.new(quantity: 1, unit_price: 10)
+    quotation.lines << Dorsale::BillingMachine::QuotationLine.new(quantity: 1, unit_price: 10)
+    quotation.lines << Dorsale::BillingMachine::QuotationLine.new(quantity: 1, unit_price: 10)
     quotation.save!
   end
 
@@ -74,7 +74,7 @@ describe Dorsale::BillingMachine::Quotation do
 
   describe "vat rate" do
     it "default vat rate should be 20" do
-      expect(described_class.new.vat_rate).to eq ::Dorsale::BillingMachine.default_vat_rate
+      expect(described_class.new.vat_rate).to eq Dorsale::BillingMachine.default_vat_rate
     end
 
     it "it should be specified vat rate" do
@@ -83,22 +83,22 @@ describe Dorsale::BillingMachine::Quotation do
 
     it "it should be first line vat rate" do
       quotation = create(:billing_machine_quotation)
-      line1 = create(:billing_machine_quotation_line, quotation: quotation, vat_rate: 10)
-      line2 = create(:billing_machine_quotation_line, quotation: quotation, vat_rate: 10)
+      line1 = create(:billing_machine_quotation_line, quotation:, vat_rate: 10)
+      line2 = create(:billing_machine_quotation_line, quotation:, vat_rate: 10)
       expect(quotation.vat_rate).to eq 10
     end
 
     it "it should raise if multiple vat_rates" do
       quotation = create(:billing_machine_quotation)
-      line1     = create(:billing_machine_quotation_line, quotation: quotation, vat_rate: 10)
+      line1     = create(:billing_machine_quotation_line, quotation:, vat_rate: 10)
 
       expect {
-        line2 = create(:billing_machine_quotation_line, quotation: quotation, vat_rate: 15)
+        line2 = create(:billing_machine_quotation_line, quotation:, vat_rate: 15)
       }.to raise_error(RuntimeError)
     end
 
     it "it should raise when vat mode is multiple" do
-      ::Dorsale::BillingMachine.vat_mode = :multiple
+      Dorsale::BillingMachine.vat_mode = :multiple
       quotation = build(:billing_machine_quotation)
       expect { quotation.vat_rate }.to raise_error(RuntimeError)
     end

data/spec/models/dorsale/billing_machine_spec.rb

@@ -2,7 +2,7 @@ require "rails_helper"
 
 RSpec.describe Dorsale::BillingMachine do
   let(:bm) {
-    ::Dorsale::BillingMachine
+    Dorsale::BillingMachine
   }
 
   describe "::vat_mode" do

data/spec/models/dorsale/customer_vault/activity_type_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe ::Dorsale::CustomerVault::ActivityType, type: :model do
+RSpec.describe Dorsale::CustomerVault::ActivityType, type: :model do
   it { is_expected.to validate_presence_of :name }
 
   it "should have a valid factory" do

data/spec/models/dorsale/customer_vault/corporation_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe ::Dorsale::CustomerVault::Corporation, type: :model do
+RSpec.describe Dorsale::CustomerVault::Corporation, type: :model do
   it { is_expected.to have_one(:address).dependent(:destroy) }
   it { is_expected.to have_many :comments }
   it { is_expected.to have_many :taggings }

data/spec/models/dorsale/customer_vault/event_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe ::Dorsale::CustomerVault::Event, type: :model do
+RSpec.describe Dorsale::CustomerVault::Event, type: :model do
   it { is_expected.to belong_to :author }
   it { is_expected.to belong_to :person }
 

data/spec/models/dorsale/customer_vault/individual_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe ::Dorsale::CustomerVault::Individual, :type => :model do
+RSpec.describe Dorsale::CustomerVault::Individual, :type => :model do
   it "should have a valid factory" do
     individual = create(:customer_vault_individual)
     expect(individual).to be_valid
@@ -26,7 +26,7 @@ RSpec.describe ::Dorsale::CustomerVault::Individual, :type => :model do
   describe "activity type" do
     it "should have the same activity than his corporation" do
       corporation = create(:customer_vault_corporation)
-      individual = create(:customer_vault_individual, corporation: corporation)
+      individual = create(:customer_vault_individual, corporation:)
       expect(individual.activity_type).to eq corporation.activity_type
     end
 
@@ -37,7 +37,7 @@ RSpec.describe ::Dorsale::CustomerVault::Individual, :type => :model do
 
     it "should have no activity if his corporation has no activity" do
       corporation = create(:customer_vault_corporation, activity_type: nil)
-      individual = create(:customer_vault_individual, corporation: corporation)
+      individual = create(:customer_vault_individual, corporation:)
       expect(individual.activity_type).to eq nil
     end
   end

data/spec/models/dorsale/customer_vault/link_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe ::Dorsale::CustomerVault::Link, type: :model do
+RSpec.describe Dorsale::CustomerVault::Link, type: :model do
   it "should have a valid factory" do
     link = build(:customer_vault_link)
     expect(link).to be_valid

data/spec/models/dorsale/customer_vault/origin_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe ::Dorsale::CustomerVault::Origin, type: :model do
+RSpec.describe Dorsale::CustomerVault::Origin, type: :model do
   it { is_expected.to validate_presence_of :name }
 
   it "should have a valid factory" do

data/spec/models/dorsale/customer_vault/person_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe ::Dorsale::CustomerVault::Person, type: :model do
+RSpec.describe Dorsale::CustomerVault::Person, type: :model do
   describe "#links" do
     let!(:c)     { create(:customer_vault_corporation) }
     let!(:i)     { create(:customer_vault_individual)  }
@@ -28,7 +28,7 @@ RSpec.describe ::Dorsale::CustomerVault::Person, type: :model do
 
   it "should return self_and_related_events" do
     corporation       = create(:customer_vault_corporation)
-    individual        = create(:customer_vault_individual, corporation: corporation)
+    individual        = create(:customer_vault_individual, corporation:)
     corporation_event = create(:customer_vault_event, person: corporation)
     individual_event  = create(:customer_vault_event, person: individual)