dorsale 3.20.0 → 4.1.0

data/app/pdfs/dorsale/billing_machine/invoice_multiple_vat_pdf.rb

@@ -1,11 +1,11 @@
-class Dorsale::BillingMachine::InvoiceMultipleVatPdf < ::Dorsale::BillingMachine::InvoiceSingleVatPdf
-  # rubocop:disable Style/SingleLineMethods, Layout/EmptyLineBetweenDefs
+class Dorsale::BillingMachine::InvoiceMultipleVatPdf < Dorsale::BillingMachine::InvoiceSingleVatPdf
+  # rubocop:disable Style/SingleLineMethods
   def first_column_width;  64.mm; end
   def second_column_width; 22.mm; end
   def third_column_width;  20.mm; end
   def fourth_column_width; 20.mm; end
   def fifth_column_width;  29.mm; end
-  # rubocop:enable Style/SingleLineMethods, Layout/EmptyLineBetweenDefs
+  # rubocop:enable Style/SingleLineMethods
 
   def last_column_width
     bounds.width - first_column_width - second_column_width - third_column_width - fourth_column_width - fifth_column_width
@@ -32,14 +32,16 @@ class Dorsale::BillingMachine::InvoiceMultipleVatPdf < ::Dorsale::BillingMachine
 
     # Products table
     bb height: height do
-      table_products = [[
-        main_document.t(:designation).mb_chars.upcase.to_s,
-        main_document.t(:quantity).mb_chars.upcase.to_s,
-        main_document.t(:unit).mb_chars.upcase.to_s,
-        main_document.t(:tax).mb_chars.upcase.to_s,
-        main_document.t(:unit_price).mb_chars.upcase.to_s,
-        main_document.t(:line_total).mb_chars.upcase.to_s,
-      ]]
+      table_products = [
+        [
+          main_document.t(:designation).upcase.to_s,
+          main_document.t(:quantity).upcase.to_s,
+          main_document.t(:unit).upcase.to_s,
+          main_document.t(:tax).upcase.to_s,
+          main_document.t(:unit_price).upcase.to_s,
+          main_document.t(:line_total).upcase.to_s,
+        ],
+      ]
 
       main_document.lines.each do |line|
         table_products.push [
@@ -81,34 +83,34 @@ class Dorsale::BillingMachine::InvoiceMultipleVatPdf < ::Dorsale::BillingMachine
 
       if has_discount
         table_totals.push [
-          main_document.t(:commercial_discount).mb_chars.upcase.to_s,
+          main_document.t(:commercial_discount).upcase.to_s,
           bm_currency(-main_document.commercial_discount),
         ]
       end
 
       table_totals.push [
-        main_document.t(:total_excluding_taxes).mb_chars.upcase.to_s,
+        main_document.t(:total_excluding_taxes).upcase.to_s,
         bm_currency(main_document.total_excluding_taxes),
       ]
 
       table_totals.push [
-        main_document.t(:vat_amount).mb_chars.upcase.to_s,
+        main_document.t(:vat_amount).upcase.to_s,
         bm_currency(main_document.vat_amount),
       ]
 
       if has_advance
         table_totals.push [
-          main_document.t(:advance).mb_chars.upcase.to_s,
+          main_document.t(:advance).upcase.to_s,
           bm_currency(main_document.advance),
         ]
 
         table_totals.push [
-          main_document.t(:total_including_taxes).mb_chars.upcase.to_s,
+          main_document.t(:total_including_taxes).upcase.to_s,
           bm_currency(main_document.balance),
         ]
       else
         table_totals.push [
-          main_document.t(:total_including_taxes).mb_chars.upcase.to_s,
+          main_document.t(:total_including_taxes).upcase.to_s,
           bm_currency(main_document.total_including_taxes),
         ]
       end

data/app/pdfs/dorsale/billing_machine/invoice_single_vat_pdf.rb

@@ -24,7 +24,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
     currency(n, Dorsale::BillingMachine.default_currency)
   end
 
-  # rubocop:disable Style/SingleLineMethods, Layout/EmptyLineBetweenDefs
+  # rubocop:disable Style/SingleLineMethods
   def header_height;         90.mm; end
   def logo_height;           32.mm; end
   def logo_width;            50.mm; end
@@ -42,7 +42,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
   def second_column_width; 2.4.cm; end
   def third_column_width;  2.5.cm; end
   def fourth_column_width; 2.9.cm; end
-  # rubocop:enable Style/SingleLineMethods, Layout/EmptyLineBetweenDefs
+  # rubocop:enable Style/SingleLineMethods
 
   def last_column_width
     bounds.width - first_column_width - second_column_width - third_column_width - fourth_column_width
@@ -110,7 +110,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
 
   def build_contact_infos
     top    = bounds.top - 4.cm
-    width  = bounds.width / 2 - 1.1.cm
+    width  = (bounds.width / 2) - 1.1.cm
     height = contact_infos_height
 
     bb top: top, width: width, height: height do
@@ -120,7 +120,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
 
   def build_subject
     top    = bounds.top - 7.5.cm
-    width  = bounds.width / 2 - 1.1.cm
+    width  = (bounds.width / 2) - 1.1.cm
     height = 15.mm
 
     bb top: top, width: width, height: height do
@@ -146,17 +146,17 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
     content << main_document.customer.address.country
 
     if main_document.customer.try(:european_union_vat_number).present?
-      content << main_document.customer.t(:european_union_vat_number) + " : "
+      content << (main_document.customer.t(:european_union_vat_number) + " : ")
       content << main_document.customer.european_union_vat_number
     end
 
-    content.select(&:present?).join("\n")
+    content.compact_blank.join("\n")
   end
 
   def build_customer
     top     = bounds.top - 4.cm
-    left    = bounds.width / 2 + 1.1.cm
-    width   = bounds.width / 2 - 1.1.cm
+    left    = (bounds.width / 2) + 1.1.cm
+    width   = (bounds.width / 2) - 1.1.cm
     height  = 4.5.cm
     padding = 3.mm
 
@@ -177,11 +177,11 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
   end
 
   def has_advance
-    main_document.try(:advance) && main_document.advance.to_d != 0.0.to_d
+    main_document.try(:advance) && main_document.advance.to_d != BigDecimal("0.0")
   end
 
   def has_discount
-    main_document.try(:commercial_discount) && main_document.commercial_discount.to_d != 0.0.to_d
+    main_document.try(:commercial_discount) && main_document.commercial_discount.to_d != BigDecimal("0.0")
   end
 
   def build_table
@@ -199,7 +199,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
               fourth_column_width,
               last_column_width,
             ],
-            :cell_style => {height: height} \
+            :cell_style => {height:} \
           do
             row(0).style       :text_color => BLACK
             row(0).style       :font_style => :bold
@@ -212,13 +212,15 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
 
     # Products table
     bb height: height do
-      table_products = [[
-        main_document.t(:designation).mb_chars.upcase.to_s,
-        main_document.t(:quantity).mb_chars.upcase.to_s,
-        main_document.t(:unit).mb_chars.upcase.to_s,
-        main_document.t(:unit_price).mb_chars.upcase.to_s,
-        main_document.t(:line_total).mb_chars.upcase.to_s,
-      ]]
+      table_products = [
+        [
+          main_document.t(:designation).upcase.to_s,
+          main_document.t(:quantity).upcase.to_s,
+          main_document.t(:unit).upcase.to_s,
+          main_document.t(:unit_price).upcase.to_s,
+          main_document.t(:line_total).upcase.to_s,
+        ],
+      ]
 
       main_document.lines.each do |line|
         table_products.push [
@@ -258,35 +260,35 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
 
       if has_discount
         table_totals.push [
-          main_document.t(:commercial_discount).mb_chars.upcase.to_s,
+          main_document.t(:commercial_discount).upcase.to_s,
           bm_currency(-main_document.commercial_discount),
         ]
       end
 
       table_totals.push [
-        main_document.t(:total_excluding_taxes).mb_chars.upcase.to_s,
+        main_document.t(:total_excluding_taxes).upcase.to_s,
         bm_currency(main_document.total_excluding_taxes),
       ]
 
       vat_rate = number(main_document.vat_rate)
       table_totals.push [
-        "#{main_document.t(:vat).mb_chars.upcase} #{percentage vat_rate}",
+        "#{main_document.t(:vat).upcase} #{percentage vat_rate}",
         bm_currency(main_document.vat_amount),
       ]
 
       if has_advance
         table_totals.push [
-          main_document.t(:advance).mb_chars.upcase.to_s,
+          main_document.t(:advance).upcase.to_s,
           bm_currency(main_document.advance),
         ]
 
         table_totals.push [
-          main_document.t(:total_including_taxes).mb_chars.upcase.to_s,
+          main_document.t(:total_including_taxes).upcase.to_s,
           bm_currency(main_document.balance),
         ]
       else
         table_totals.push [
-          main_document.t(:total_including_taxes).mb_chars.upcase.to_s,
+          main_document.t(:total_including_taxes).upcase.to_s,
           bm_currency(main_document.total_including_taxes),
         ]
       end
@@ -323,7 +325,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
 
     txt << main_document.comments
 
-    txt.select(&:present?).join("\n\n")
+    txt.compact_blank.join("\n\n")
   end
 
   def build_document_infos
@@ -331,7 +333,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
     height = middle_height - products_table_height - 5.mm
     width  = 10.cm
 
-    btb document_infos_content, top: top, height: height, width: width
+    btb document_infos_content, top:, height:, width:
   end
 
   def build_footer
@@ -355,7 +357,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
   end
 
   def build_footer_line
-    top = bounds.top - footer_top_height - (footer_height - footer_top_height - footer_bottom_height - footer_pagination_height) / 2
+    top = bounds.top - footer_top_height - ((footer_height - footer_top_height - footer_bottom_height - footer_pagination_height) / 2)
     stroke do
       horizontal_line bounds.left, bounds.right, at: top
     end
@@ -369,7 +371,7 @@ class Dorsale::BillingMachine::InvoiceSingleVatPdf < Dorsale::ApplicationPdf
     height = footer_bottom_height
     top    = bounds.bottom + height + footer_pagination_height
 
-    btb footer_bottom_content, top: top, height: height, size: 9
+    btb footer_bottom_content, top:, height:, size: 9
   end
 
   def build_page_numbers

data/app/pdfs/dorsale/billing_machine/quotation_multiple_vat_pdf.rb

@@ -1,3 +1,3 @@
-class Dorsale::BillingMachine::QuotationMultipleVatPdf < ::Dorsale::BillingMachine::InvoiceMultipleVatPdf
+class Dorsale::BillingMachine::QuotationMultipleVatPdf < Dorsale::BillingMachine::InvoiceMultipleVatPdf
   include ::Dorsale::BillingMachine::QuotationPdfCommonMethods
 end

data/app/pdfs/dorsale/billing_machine/quotation_single_vat_pdf.rb

@@ -1,3 +1,3 @@
-class Dorsale::BillingMachine::QuotationSingleVatPdf < ::Dorsale::BillingMachine::InvoiceSingleVatPdf
+class Dorsale::BillingMachine::QuotationSingleVatPdf < Dorsale::BillingMachine::InvoiceSingleVatPdf
   include ::Dorsale::BillingMachine::QuotationPdfCommonMethods
 end

data/app/pdfs/dorsale/expense_gun/expense_pdf.rb

@@ -34,11 +34,11 @@ class Dorsale::ExpenseGun::ExpensePdf < Dorsale::ApplicationPdf
 
   private
 
-  def info(obj, attribute, helper: nil, **options)
+  def info(obj, attribute, helper: nil, **)
     key = obj.t(attribute)
     value = obj.public_send(attribute)
     value = helper ? H.public_send(helper, value) : value.to_s
-    text "<b>#{key} :</b> #{value}", inline_format: true, **options
+    text("<b>#{key} :</b> #{value}", inline_format: true, **)
   end
 
   def table_data

data/app/pdfs/dorsale/prawn_helpers.rb

@@ -13,8 +13,8 @@ module Dorsale::PrawnHelpers
     transparent(0.5) { stroke_bounds } if draw_debug_bounds?
   end
 
-  def t(*args)
-    I18n.t(*args)
+  def t(*)
+    I18n.t(*)
   end
 
   def page_height

data/app/policies/dorsale/application_policy.rb

@@ -19,7 +19,7 @@ class Dorsale::ApplicationPolicy
   end
 
   def self.inherited(klass)
-    super(klass)
+    super
     klass.define_subject_accessor!
   end
 

data/app/services/dorsale/billing_machine/invoice/copy.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::Invoice::Copy < ::Dorsale::Service
+class Dorsale::BillingMachine::Invoice::Copy < Dorsale::Service
   attr_accessor :invoice, :copy
 
   def initialize(invoice)

data/app/services/dorsale/billing_machine/invoice/statistics.rb

@@ -8,25 +8,25 @@ class Dorsale::BillingMachine::Invoice::Statistics
   def total_excluding_taxes
     @total_excluding_taxes ||= @invoices
       .pluck(:total_excluding_taxes)
-      .delete_if(&:blank?)
+      .compact
       .sum
   end
 
   def vat_amount
     @vat_amount ||= @invoices
       .pluck(:vat_amount)
-      .delete_if(&:blank?)
+      .compact
       .sum
   end
 
   def total_including_taxes
     @total_including_taxes ||= @invoices
       .pluck(:total_including_taxes)
-      .delete_if(&:blank?)
+      .compact
       .sum
   end
 
-  def t(*args)
-    ::Dorsale::BillingMachine::Invoice.t(*args)
+  def t(*)
+    ::Dorsale::BillingMachine::Invoice.t(*)
   end
 end

data/app/services/dorsale/billing_machine/quotation/copy.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::Quotation::Copy < ::Dorsale::Service
+class Dorsale::BillingMachine::Quotation::Copy < Dorsale::Service
   attr_accessor :quotation, :copy
 
   def initialize(quotation)

data/app/services/dorsale/billing_machine/quotation/statistics.rb

@@ -9,7 +9,7 @@ class Dorsale::BillingMachine::Quotation::Statistics
     @total_excluding_taxes ||= @quotations
       .where.not(state: "canceled")
       .pluck(:total_excluding_taxes)
-      .delete_if(&:blank?)
+      .compact
       .sum
   end
 
@@ -17,7 +17,7 @@ class Dorsale::BillingMachine::Quotation::Statistics
     @vat_amount ||= @quotations
       .where.not(state: "canceled")
       .pluck(:vat_amount)
-      .delete_if(&:blank?)
+      .compact
       .sum
   end
 
@@ -25,11 +25,11 @@ class Dorsale::BillingMachine::Quotation::Statistics
     @total_including_taxes ||= @quotations
       .where.not(state: "canceled")
       .pluck(:total_including_taxes)
-      .delete_if(&:blank?)
+      .compact
       .sum
   end
 
-  def t(*args)
-    ::Dorsale::BillingMachine::Quotation.t(*args)
+  def t(*)
+    ::Dorsale::BillingMachine::Quotation.t(*)
   end
 end

data/app/services/dorsale/billing_machine/quotation/to_invoice.rb

@@ -1,4 +1,4 @@
-class Dorsale::BillingMachine::Quotation::ToInvoice < ::Dorsale::Service
+class Dorsale::BillingMachine::Quotation::ToInvoice < Dorsale::Service
   attr_accessor :quotation, :invoice
 
   def initialize(quotation)
@@ -12,8 +12,8 @@ class Dorsale::BillingMachine::Quotation::ToInvoice < ::Dorsale::Service
     quotation.attributes.each do |k, v|
       next if ignored_key?(k)
 
-      if invoice.respond_to?("#{k}=")
-        invoice.public_send("#{k}=", v)
+      if invoice.respond_to?(:"#{k}=")
+        invoice.public_send(:"#{k}=", v)
       end
     end
 
@@ -23,8 +23,8 @@ class Dorsale::BillingMachine::Quotation::ToInvoice < ::Dorsale::Service
       quotation_line.attributes.each do |k, v|
         next if ignored_key?(k)
 
-        if invoice_line.respond_to?("#{k}=")
-          invoice_line.public_send("#{k}=", v)
+        if invoice_line.respond_to?(:"#{k}=")
+          invoice_line.public_send(:"#{k}=", v)
         end
       end
     end

data/app/services/dorsale/expense_gun/expense/copy.rb

@@ -1,4 +1,4 @@
-class Dorsale::ExpenseGun::Expense::Copy < ::Dorsale::Service
+class Dorsale::ExpenseGun::Expense::Copy < Dorsale::Service
   attr_accessor :expense, :copy
 
   def initialize(expense)

data/app/services/dorsale/flyboy/task/copy.rb

@@ -1,4 +1,4 @@
-class Dorsale::Flyboy::Task::Copy < ::Dorsale::Service
+class Dorsale::Flyboy::Task::Copy < Dorsale::Service
   attr_accessor :task, :copy
 
   def initialize(task)

data/app/services/dorsale/flyboy/task/snoozer.rb

@@ -1,4 +1,4 @@
-class Dorsale::Flyboy::Task::Snoozer < ::Dorsale::Service
+class Dorsale::Flyboy::Task::Snoozer < Dorsale::Service
   attr_reader :task
 
   def initialize(task)

data/app/services/dorsale/service.rb

@@ -1,5 +1,5 @@
 class Dorsale::Service
-  def self.call(*args)
-    new(*args).call
+  def self.call(*)
+    new(*).call
   end
 end

data/app/services/dorsale/tag_list_for_model.rb

@@ -1,4 +1,4 @@
-class Dorsale::TagListForModel < ::Dorsale::Service
+class Dorsale::TagListForModel < Dorsale::Service
   attr_reader :model
 
   def initialize(model)

data/app/uploaders/dorsale/alexandrie/file_uploader.rb

@@ -1,2 +1,2 @@
-class Dorsale::Alexandrie::FileUploader < ::Dorsale::ApplicationUploader
+class Dorsale::Alexandrie::FileUploader < Dorsale::ApplicationUploader
 end

data/app/uploaders/dorsale/application_uploader.rb

@@ -1,2 +1,2 @@
-class Dorsale::ApplicationUploader < ::ApplicationUploader
+class Dorsale::ApplicationUploader < ApplicationUploader
 end

data/app/uploaders/dorsale/avatar_uploader.rb

@@ -1,6 +1,6 @@
 require "mini_magick"
 
-class Dorsale::AvatarUploader < ::Dorsale::ImageUploader
+class Dorsale::AvatarUploader < Dorsale::ImageUploader
   include CarrierWave::MiniMagick
 
   process resize_to_fill: [200, 200]

data/app/uploaders/dorsale/image_uploader.rb

@@ -1,5 +1,5 @@
-class Dorsale::ImageUploader < ::Dorsale::ApplicationUploader
+class Dorsale::ImageUploader < Dorsale::ApplicationUploader
   def extension_allowlist
-    %w(jpg jpeg gif png)
+    %w[jpg jpeg gif png]
   end
 end

data/app/uploaders/dorsale/pdf_uploader.rb

@@ -1,5 +1,5 @@
-class Dorsale::PdfUploader < ::Dorsale::ApplicationUploader
+class Dorsale::PdfUploader < Dorsale::ApplicationUploader
   def extension_allowlist
-    %w(pdf)
+    %w[pdf]
   end
 end

data/app/views/dorsale/customer_vault/people/index.xlsx.ruby

@@ -1,4 +1,4 @@
-fields = %w(
+fields = %w[
   person_type
   first_name
   last_name
@@ -26,7 +26,7 @@ fields = %w(
   address.city
   address.zip
   address.country
-)
+]
 
 data = []
 
@@ -41,7 +41,7 @@ data << fields.map { |field| model.t(field) }
     elsif field.include?("address.")
       line << person.address.public_send(field.gsub("address.", ""))
     else
-      line << person.public_send(:try, field)
+      line << person.try(field)
     end
   end
 

data/features/step_definitions/billing_machine_invoices_steps.rb

@@ -23,7 +23,7 @@ Given(/^an existing paid invoice$/) do
 end
 
 Given(/^billing machine in single vat mode$/) do
-  ::Dorsale::BillingMachine.vat_mode = :single
+  Dorsale::BillingMachine.vat_mode = :single
 end
 
 Given(/^a bunch of existing invoices$/) do
@@ -149,7 +149,7 @@ When(/^he changes the advance to "(.*?)"€$/) do |value|
 end
 
 When(/^he goes to the newly created invoice page$/) do
-  @invoice = ::Dorsale::BillingMachine::Invoice.last_created
+  @invoice = Dorsale::BillingMachine::Invoice.last_created
   visit dorsale.edit_billing_machine_invoice_path(@invoice)
 end
 
@@ -178,7 +178,7 @@ When(/^the user download the pdf$/) do
 end
 
 Then(/^he should see (\d+) invoices?$/) do |count|
-  expect(page).to have_selector ".invoice", count: count
+  expect(page).to have_selector ".invoice", count:
 end
 
 Then(/^the invoice is displayed correctly$/) do
@@ -205,7 +205,7 @@ Then(/^it's added to the invoice list$/) do
   step("the user goes to the invoices page")
   expect(page).to have_selector ".invoice .date", text: @date
   # There are no other invoices for this test so we should get the right number
-  tracking_id = ::Dorsale::BillingMachine::Invoice.first.tracking_id
+  tracking_id = Dorsale::BillingMachine::Invoice.first.tracking_id
   expect(page).to have_selector ".invoice .tracking_id", text: tracking_id
   expect(page).to have_selector ".invoice .customer_name", text: @customer.name
   expect(page).to have_selector ".invoice .total_excluding_taxes", text: "180,00 €"

data/features/step_definitions/billing_machine_multiple_vat.rb

@@ -1,5 +1,5 @@
 Given(/^billing machine in multiple vat mode$/) do
-  ::Dorsale::BillingMachine.vat_mode = :multiple
+  Dorsale::BillingMachine.vat_mode = :multiple
 end
 
 When(/^he fills the reference, the date and the payment terms$/) do

data/features/step_definitions/billing_machine_quotations_steps.rb

@@ -18,7 +18,7 @@ end
 
 Given(/^(\d+) associated documents to this quotation$/) do |n|
   n.to_i.times do |i|
-    instance_variable_set "@document#{i}", create(:alexandrie_attachment, attachable: @quotation)
+    instance_variable_set :"@document#{i}", create(:alexandrie_attachment, attachable: @quotation)
   end
 end
 
@@ -165,7 +165,7 @@ Then(/^he will see links to the documents$/) do
 end
 
 Then(/^the quotation informations are visible on the quotation details$/) do
-  @quotation = ::Dorsale::BillingMachine::Quotation.last_created
+  @quotation = Dorsale::BillingMachine::Quotation.last_created
   visit dorsale.billing_machine_quotation_path(@quotation)
   expect(page).to have_content @payment_term.label
   expect(page).to have_content "I-am-a-comment"

data/features/step_definitions/customer_vault_corporations_steps.rb

@@ -47,7 +47,7 @@ Then(/^i see an error message for the missing name$/) do
 end
 
 Then(/^he can see (\d+) corporate$/) do |count|
-  expect(page).to have_selector ".person", count: count
+  expect(page).to have_selector ".person", count:
 end
 
 Then(/^the corporation is created$/) do
@@ -182,7 +182,7 @@ Given(/^a closed task to this corporation$/) do
 end
 
 Given(/^a link between this individual and this corporation$/) do
-  @link = ::Dorsale::CustomerVault::Link.create!(
+  @link = Dorsale::CustomerVault::Link.create!(
     :alice => @corporation,
     :bob   => @individual,
     :title => "I-am-a-link",
@@ -203,14 +203,14 @@ Then(/^I am on the corporation page$/) do
 end
 
 When(/^I delete this corporation$/) do
-  @corporations_count = ::Dorsale::CustomerVault::Corporation.count
+  @corporations_count = Dorsale::CustomerVault::Corporation.count
 
   find(".context [href$=edit]").click
   find(".context [data-method=delete]").click
 end
 
 Then(/^the corporation is deleted$/) do
-  expect(::Dorsale::CustomerVault::Corporation.count).to eq(@corporations_count - 1)
+  expect(Dorsale::CustomerVault::Corporation.count).to eq(@corporations_count - 1)
 end
 
 Then(/^I am on the people page$/) do

data/features/step_definitions/customer_vault_people_steps.rb

@@ -8,7 +8,7 @@ end
 
 Given(/^a very long comment on this person$/) do
   text = Faker::Lorem.paragraph(sentence_count: 30)
-  @comment = create(:customer_vault_event_comment, person: @person, text: text)
+  @comment = create(:customer_vault_event_comment, person: @person, text:)
 end
 
 Then(/^I see the truncated comment$/) do

data/features/step_definitions/customer_vault_tasks_steps.rb

@@ -3,7 +3,7 @@ When(/^I go on the tasks section$/) do
 end
 
 When(/^I create a task on this person$/) do
-  @tasks_count = ::Dorsale::Flyboy::Task.count
+  @tasks_count = Dorsale::Flyboy::Task.count
   find("#context-main a[href*='tasks/new']").click
   fill_in :task_name, with: "YepYep"
   fill_in :task_description, with: "Trololo"
@@ -11,8 +11,8 @@ When(/^I create a task on this person$/) do
 end
 
 Then(/^the person task is created$/) do
-  expect(::Dorsale::Flyboy::Task.count).to eq(@tasks_count + 1)
-  @task = ::Dorsale::Flyboy::Task.last_created
+  expect(Dorsale::Flyboy::Task.count).to eq(@tasks_count + 1)
+  @task = Dorsale::Flyboy::Task.last_created
   person = @corporation || @individual || @person
   expect(current_path).to eq dorsale.tasks_customer_vault_person_path(person)
 end

data/features/step_definitions/flyboy_tasks_steps.rb

@@ -7,7 +7,7 @@ Given(/^an existing undone task$/) do
 end
 
 Given(/^an existing task named "(.*?)"$/) do |name|
-  create(:flyboy_task, name: name)
+  create(:flyboy_task, name:)
 end
 
 Given(/^an existing task$/) do