dm-validations 0.9.9 → 0.9.10

data/spec/integration/required_field_validator/string_type_value_spec.rb

@@ -0,0 +1,164 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+require __dir__.parent.parent + 'spec_helper'
+require __dir__ + 'spec_helper'
+
+if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+  # keep in mind any ScmOperation has a default value for brand property
+  # so it is used
+  describe GitOperation do
+    before :each do
+      @operation = GitOperation.new(:network_connection => true,
+                                    :clean_working_copy => true,
+                                    :message            => "I did it! I did it!! Hell yeah!!!")
+    end
+
+    describe "without explicitly specified committer name" do
+      before :each do
+        # no specific actions for this case! yay!
+      end
+
+      it "is valid for committing (because default value jumps in)" do
+        @operation.should be_valid_for_committing
+        @operation.should be_valid(:committing)
+      end
+
+      it "is not valid in default context" do
+        # context here is :default
+        @operation.should_not be_valid
+      end
+
+      it "has default value set" do
+        # this is more of a sanity check since
+        # this sort of functionality clearly needs to be
+        # tested in
+        @operation.committer_name.should == "Just another Ruby hacker"
+      end
+    end # describe "without explicitly specified committer name"
+
+    describe "WITH explicitly specified committer name" do
+      before :each do
+        @operation.committer_name = "Core Team Guy"
+      end
+
+      it "is valid for committing" do
+        @operation.should be_valid_for_committing
+        @operation.should be_valid(:committing)
+      end
+
+      it "is not valid in default context" do
+        @operation.should_not be_valid
+        @operation.should_not be_valid(:default)
+      end
+
+      it "has value set" do
+        # this is more of a sanity check since
+        # this sort of functionality clearly needs to be
+        # tested in
+        @operation.committer_name.should == "Core Team Guy"
+      end
+    end # describe "with explicitly specified committer name"
+
+
+
+    describe "without explicitly specified author name" do
+      before :each do
+        # no specific actions for this case! yay!
+      end
+
+      it "is valid for committing (because default value jumps in)" do
+        @operation.should be_valid_for_committing
+        @operation.should be_valid(:committing)
+      end
+
+      it "is not valid in default context" do
+        # context here is :default
+        @operation.should_not be_valid
+        @operation.should_not be_valid(:default)
+      end
+
+      it "has default value set" do
+        @operation.author_name.should == "Just another Ruby hacker"
+      end
+    end # describe "without explicitly specified author name"
+
+    describe "WITH explicitly specified author name" do
+      before :each do
+        @operation.author_name = "Random contributor"
+      end
+
+      it "is valid for committing" do
+        @operation.should be_valid_for_committing
+      end
+
+      it "is not valid in default context" do
+        # context here is :default
+        @operation.should_not be_valid
+      end
+
+      it "has value set" do
+        @operation.author_name.should == "Random contributor"
+      end
+    end # describe "with explicitly specified author name"
+
+    describe "with empty committer name" do
+      before(:each) do
+        @operation.committer_name = ""
+      end
+
+      it "is NOT valid for committing" do
+        # empty string is not considered present for
+        # a String value
+        @operation.should_not be_valid_for_committing
+
+        # sanity check since this empty vs blank vs nil
+        # thing is a shaky ground
+        @operation.committer_name = "l33t k0dr"
+        @operation.should be_valid_for_committing
+      end
+
+      it "IS valid for pushing" do
+        @operation.should be_valid_for_pushing
+      end
+
+      it "IS valid for pulling" do
+        @operation.should be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        @operation.should_not be_valid
+      end
+    end # describe "with empty committer field"
+
+
+    describe "with empty author name" do
+      before(:each) do
+        @operation.author_name = ""
+      end
+
+      it "is NOT valid for committing" do
+        # empty string is not considered present for
+        # a String value
+        @operation.should_not be_valid_for_committing
+
+        # sanity check since this empty vs blank vs nil
+        # thing is a shaky ground
+        @operation.author_name = "l33t k0dr"
+        @operation.should be_valid_for_committing
+      end
+
+      it "IS valid for pushing" do
+        @operation.should be_valid_for_pushing
+      end
+
+      it "IS valid for pulling" do
+        @operation.should be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        @operation.should_not be_valid
+      end
+    end # describe "with empty author field"
+  end # describe GitOperation
+end # if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES

data/spec/integration/required_field_validator/text_type_value_spec.rb

@@ -0,0 +1,46 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+require __dir__.parent.parent + 'spec_helper'
+require __dir__ + 'spec_helper'
+
+if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+  # keep in mind any ScmOperation has a default value for brand property
+  # so it is used
+  describe GitOperation do
+    before :each do
+      @operation = GitOperation.new(:network_connection => true,
+                                    :clean_working_copy => true,
+                                    :message            => "I did it! I did it!! Hell yeah!!!")
+    end
+
+    describe "with empty message" do
+      before(:each) do
+        @operation.message = ""
+      end
+
+      it "is NOT valid for committing" do
+        # empty string is not considered present for
+        # a text value
+        @operation.should_not be_valid_for_committing
+
+        # sanity check since this empty vs blank vs nil
+        # thing is a shaky ground
+        @operation.message = "RUBY ON RAILS CAN SCALE NOW!!! w00t!!!"
+        @operation.should be_valid_for_committing
+      end
+
+      it "IS valid for pushing" do
+        @operation.should be_valid_for_pushing
+      end
+
+      it "IS valid for pulling" do
+        @operation.should be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        @operation.should_not be_valid
+      end
+    end # describe "with empty message"
+  end # describe GitOperation
+end # if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES

data/spec/integration/uniqueness_validator_spec.rb

@@ -5,7 +5,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   describe DataMapper::Validate::UniquenessValidator do
 
     before do
-      class Organisation
+      class ::Organisation
         include DataMapper::Resource
         property :id, Serial
         property :name, String
@@ -14,7 +14,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
         validates_is_unique :domain, :allow_nil => true
       end
 
-      class User
+      class ::User
         include DataMapper::Resource
         property :id, Serial
         property :organisation_id, Integer
@@ -33,7 +33,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
          Organisation.new(:id=>1, :name=>'Org One', :domain=>'taken').save
          Organisation.new(:id=>2, :name=>'Org Two', :domain=>'two').save
 
-         User.new(:id=>1,:organisation_id=>1,:user_name=>'guy').save
+         User.new(:id=>1, :organisation_id=>1, :user_name=>'guy').save
       end
     end
 
@@ -42,11 +42,11 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
         o = Organisation.get!(1)
         o.should be_valid
 
-        o = Organisation.new(:id=>20,:name=>"Org Twenty", :domain=>nil)
+        o = Organisation.new(:id=>20, :name=>"Org Twenty", :domain=>nil)
         o.should be_valid
         o.save
 
-        o = Organisation.new(:id=>30,:name=>"Org Thirty", :domain=>nil)
+        o = Organisation.new(:id=>30, :name=>"Org Thirty", :domain=>nil)
         o.should be_valid
       end
     end
@@ -56,17 +56,17 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
         o = Organisation.get!(1)
         o.should be_valid
 
-        o = Organisation.new(:id=>2,:name=>"Org Two", :domain=>"taken")
+        o = Organisation.new(:id=>2, :name=>"Org Two", :domain=>"taken")
         o.should_not be_valid
         o.errors.on(:domain).should include('Domain is already taken')
 
-        o = Organisation.new(:id=>2,:name=>"Org Two", :domain=>"not_taken")
+        o = Organisation.new(:id=>2, :name=>"Org Two", :domain=>"not_taken")
         o.should be_valid
       end
     end
 
     it 'should validate uniqueness on a string key' do
-      class Department
+      class ::Department
         include DataMapper::Resource
         property :name, String, :key => true
 
@@ -83,7 +83,9 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
       repository do
         u = User.new(:id => 2, :organisation_id=>1, :user_name => 'guy')
         u.should_not be_valid_for_testing_property
+        u.errors.on(:user_name).should include('User name is already taken')
         u.should_not be_valid_for_testing_association
+        u.errors.on(:user_name).should include('User name is already taken')
 
 
         u = User.new(:id => 2, :organisation_id => 2, :user_name  => 'guy')

data/spec/integration/validation_spec.rb

@@ -3,7 +3,7 @@ require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
 
 describe DataMapper::Validate do
   before :all do
-    class Yacht
+    class ::Yacht
       include DataMapper::Resource
       property :id, Integer, :serial => true
       property :name, String, :auto_validation => false
@@ -15,7 +15,7 @@ describe DataMapper::Validate do
   describe '#validations' do
       it 'should support more different validations of a different type' do
           number_of_validators_before = Yacht.validators.contexts[:default].length
-            class Yacht
+            class ::Yacht
                 validates_is_unique :name
             end
           number_of_validators_after = Yacht.validators.contexts[:default].length
@@ -59,7 +59,7 @@ describe DataMapper::Validate do
 
     describe 'with context specified' do
       before :all do
-        class Yacht
+        class ::Yacht
           validates_length :name, :min => 2, :context => [ :strict_name ]
         end
       end
@@ -143,7 +143,7 @@ describe DataMapper::Validate do
   end
 
   it "should allow multiple user defined contexts for a validator" do
-    class Yacht
+    class ::Yacht
       property :port, String, :auto_validation => false
       validates_present :port, :context => [:at_sea, :in_harbor]
     end
@@ -154,7 +154,7 @@ describe DataMapper::Validate do
   end
 
   it "should alias :on and :when for :context" do
-    class Yacht
+    class ::Yacht
       property :owner, String, :auto_validation => false
       property :bosun, String, :auto_validation => false
 
@@ -166,7 +166,7 @@ describe DataMapper::Validate do
   end
 
   it "should alias :group for :context (backward compat with Validatable??)" do
-    class Yacht
+    class ::Yacht
       property :captain, String, :auto_validation => false
       validates_present :captain, :group => [:captained_vessel]
     end
@@ -174,7 +174,7 @@ describe DataMapper::Validate do
   end
 
   it "should add a method valid_for_<context_name>? for each context" do
-    class Yacht
+    class ::Yacht
       property :engine_size, String, :auto_validation => false
       validates_present :engine_size, :when => :power_boat
     end
@@ -189,7 +189,7 @@ describe DataMapper::Validate do
   end
 
   it "should add a method all_valid_for_<context_name>? for each context" do
-    class Yacht
+    class ::Yacht
       property :mast_height, String, :auto_validation => false
       validates_present :mast_height, :when => :sailing_vessel
     end
@@ -200,7 +200,7 @@ describe DataMapper::Validate do
   it "should be able to translate the error message" # needs String::translations
 
   it "should be able to get the error message for a given field" do
-    class Yacht
+    class ::Yacht
       property :wood_type, String, :auto_validation => false
       validates_present :wood_type, :on => :wooden_boats
     end
@@ -212,7 +212,7 @@ describe DataMapper::Validate do
   end
 
   it "should be able to specify a custom error message" do
-    class Yacht
+    class ::Yacht
       property :year_built, String, :auto_validation => false
       validates_present :year_built, :when => :built, :message => 'Year built is a must enter field'
     end
@@ -223,7 +223,7 @@ describe DataMapper::Validate do
   end
 
   it "should execute a Proc when provided in an :if clause and run validation if the Proc returns true" do
-    class Dingy
+    class ::Dingy
       include DataMapper::Resource
       property :id, Integer, :serial => true
       property :owner, String, :auto_validation => false
@@ -236,7 +236,7 @@ describe DataMapper::Validate do
 
     Dingy.new.valid?.should == true
 
-    class Dingy
+    class ::Dingy
       def owned?
         true
       end
@@ -246,7 +246,7 @@ describe DataMapper::Validate do
   end
 
   it "should execute a symbol or method name provided in an :if clause and run validation if the method returns true" do
-    class Dingy
+    class ::Dingy
       validators.clear!
       validates_present :owner, :if => :owned?
 
@@ -257,7 +257,7 @@ describe DataMapper::Validate do
 
     Dingy.new.valid?.should == true
 
-    class Dingy
+    class ::Dingy
       def owned?
         true
       end
@@ -267,7 +267,7 @@ describe DataMapper::Validate do
   end
 
   it "should execute a Proc when provided in an :unless clause and not run validation if the Proc returns true" do
-    class RowBoat
+    class ::RowBoat
       include DataMapper::Resource
       property :id, Integer, :serial => true
       validates_present :salesman, :unless => Proc.new{|resource| resource.sold?}
@@ -279,7 +279,7 @@ describe DataMapper::Validate do
 
     RowBoat.new.valid?.should_not == true
 
-    class RowBoat
+    class ::RowBoat
       def sold?
         true
       end
@@ -289,7 +289,7 @@ describe DataMapper::Validate do
   end
 
   it "should execute a symbol or method name provided in an :unless clause and not run validation if the method returns true" do
-    class Dingy
+    class ::Dingy
       validators.clear!
       validates_present :salesman, :unless => :sold?
 
@@ -300,7 +300,7 @@ describe DataMapper::Validate do
 
     Dingy.new.valid?.should_not == true  #not sold and no salesman
 
-    class Dingy
+    class ::Dingy
       def sold?
         true
       end
@@ -310,7 +310,7 @@ describe DataMapper::Validate do
   end
 
   it "should perform automatic recursive validation #all_valid? checking all instance variables (and ivar.each items if valid)" do
-    class Invoice
+    class ::Invoice
       include DataMapper::Resource
       property :id, Integer, :serial => true
       property :customer, String, :auto_validation => false
@@ -329,7 +329,7 @@ describe DataMapper::Validate do
       end
     end
 
-    class LineItem
+    class ::LineItem
       include DataMapper::Resource
       property :id, Integer, :serial => true
       property :price, String, :auto_validation => false
@@ -340,7 +340,7 @@ describe DataMapper::Validate do
       end
     end
 
-    class Comment
+    class ::Comment
       include DataMapper::Resource
       property :id, Integer, :serial => true
       property :note, String, :auto_validation => false
@@ -370,7 +370,7 @@ describe DataMapper::Validate do
   end
 
   it "should retrieve private instance variables for validation" do
-    class Raft
+    class ::Raft
       include DataMapper::Resource
       property :length, Integer, :accessor => :private
 
@@ -383,7 +383,7 @@ describe DataMapper::Validate do
   end
 
   it "should duplicate validations to STI models" do
-    class Company
+    class ::Company
       include DataMapper::Resource
 
       validates_present :title, :message => "Company name is a required field"
@@ -393,10 +393,10 @@ describe DataMapper::Validate do
       property :type,     Discriminator
     end
 
-    class ServiceCompany < Company
+    class ::ServiceCompany < Company
     end
 
-    class ProductCompany < Company
+    class ::ProductCompany < Company
     end
     company = ServiceCompany.new
     company.should_not be_valid