dm-validations 0.9.9 → 0.9.10

data/spec/integration/length_validator/minimum_spec.rb

@@ -0,0 +1,31 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+# global first, then local to length validators
+require __dir__.parent.parent + "spec_helper"
+require __dir__ + 'spec_helper'
+
+describe DataMapper::Validate::LengthValidator do
+  it "lets user specify a minimum length of a string field" do
+    class ::MotorLaunch
+      validates_length :name, :min => 3
+    end
+
+    launch = MotorLaunch.new
+    launch.name = 'Ab'
+    launch.should_not be_valid
+    launch.errors.on(:name).should include('Name must be more than 3 characters long')
+  end
+
+  it "aliases :minimum for :min" do
+    class ::MotorLaunch
+      validators.clear!
+      validates_length :name, :minimum => 3
+    end
+
+    launch = MotorLaunch.new
+    launch.name = 'Ab'
+    launch.should_not be_valid
+    launch.errors.on(:name).should include('Name must be more than 3 characters long')
+  end
+end

data/spec/integration/length_validator/range_spec.rb

@@ -0,0 +1,95 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+# global first, then local to length validators
+require __dir__.parent.parent + "spec_helper"
+require __dir__ + 'spec_helper'
+
+class MotorLaunch
+  validators.clear!
+  validates_length :name, :in => (3..5)
+end
+
+
+describe MotorLaunch do
+  before :each do
+    @launch = MotorLaunch.new
+  end
+
+  describe "with a value that is out of range bounds (too long)" do
+    before :each do
+      @launch.name = 'a'
+      @launch.valid?
+    end
+
+    it "is invalid" do
+      @launch.should_not be_valid
+    end
+    it "includes range bounds and field name in error message" do
+      @launch.errors.on(:name).should include('Name must be between 3 and 5 characters long')
+    end
+  end
+
+
+  describe "with a value that is out of range bounds (too short)" do
+    before :each do
+      @launch.name = 'L'
+      @launch.valid?
+    end
+
+    it "is invalid" do
+      @launch.should_not be_valid
+    end
+    it "includes range bounds and field name in error message" do
+      @launch.errors.on(:name).should include('Name must be between 3 and 5 characters long')
+    end
+  end
+
+
+  # arguable but reasonable for 80% of cases
+  # to treat nil as a 0 lengh value
+  # reported in
+  # http://datamapper.lighthouseapp.com/projects/20609/tickets/646
+  describe "with a nil value" do
+    before :each do
+      @launch.name = nil
+      @launch.valid?
+    end
+
+    it "is invalid" do
+      @launch.should_not be_valid
+    end
+    it "includes range bounds and field name in error message" do
+      @launch.errors.on(:name).should include('Name must be between 3 and 5 characters long')
+    end
+  end
+
+
+
+  describe "with a value that is within range bounds" do
+    before :each do
+      @launch.name = 'Lisp'
+      @launch.valid?
+    end
+
+    it "is valid" do
+      @launch.should be_valid
+    end
+    it "has blank error message" do
+      @launch.errors.on(:name).should be_blank
+    end
+  end
+
+
+
+  it "aliases :within for :in" do
+    class ::MotorLaunch
+      validators.clear!
+      validates_length :name, :within => (3..5)
+    end
+
+    launch = MotorLaunch.new
+    launch.name = 'Ride'
+    launch.valid?.should == true
+  end
+end

data/spec/integration/length_validator/spec_helper.rb

@@ -0,0 +1,12 @@
+class MotorLaunch
+  include DataMapper::Resource
+  property :id, Integer, :serial => true
+  property :name, String, :auto_validation => false
+end
+
+class BoatDock
+  include DataMapper::Resource
+  property :id, Integer, :serial => true
+  property :name, String, :auto_validation => false, :default => "I'm a long string"
+  validates_length :name, :min => 3
+end

data/spec/integration/length_validator/valid_objects_spec.rb

@@ -0,0 +1,13 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+# global first, then local to length validators
+require __dir__.parent.parent + "spec_helper"
+require __dir__ + 'spec_helper'
+
+describe DataMapper::Validate::LengthValidator do
+  it "passes if a default fulfills the requirements" do
+    doc = BoatDock.new
+    doc.should be_valid
+  end
+end

data/spec/integration/method_validator_spec.rb

@@ -3,7 +3,7 @@ require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
 
 describe DataMapper::Validate::MethodValidator do
   before(:all) do
-    class Ship
+    class ::Ship
       include DataMapper::Resource
       property :id, Integer, :key => true
       property :name, String
@@ -41,13 +41,13 @@ describe DataMapper::Validate::MethodValidator do
     Ship.new.valid_for_testing_success?.should == true
     ship = Ship.new
     ship.valid_for_testing_failure?.should == false
-    ship.errors.full_messages.include?('Validation failed').should == true
+    ship.errors.on(:fail_validation).should include('Validation failed')
   end
 
   it "should run multiple validation methods" do
     ship = Ship.new
     ship.valid_for_multiple_validations?.should == false
-    ship.errors.full_messages.should include('Second Validation was false')
+    ship.errors.on(:second_validation).should include('Second Validation was false')
   end
 
   it "should validate via a method and add error to field" do

data/spec/integration/numeric_validator/float_type_spec.rb

@@ -0,0 +1,102 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+require __dir__.parent.parent + 'spec_helper'
+require __dir__ + 'spec_helper'
+
+describe BasketballPlayer do
+  before(:each) do
+    @mj = BasketballPlayer.new(:name => "Michael Jordan", :height => 198.1, :weight => 97.2)
+  end
+
+  describe "with height as float" do
+    before(:each) do
+      # no op in this case
+    end
+
+    it "is valid" do
+      @mj.should be_valid
+    end
+  end
+
+
+  describe "with height as integer" do
+    before(:each) do
+      @mj.height = 198
+    end
+
+    it "is valid" do
+      @mj.should be_valid
+    end
+  end
+
+
+  describe "with height as string containing only integers" do
+    before(:each) do
+      @mj.height = "198"
+    end
+
+    it "is valid" do
+      @mj.should be_valid
+    end
+  end
+
+
+  describe "with height as string containing a float" do
+    before(:each) do
+      @mj.height = "198.1"
+    end
+
+    it "is valid" do
+      @mj.should be_valid
+    end
+  end
+
+
+  describe "with height as string containing random alphanumeric characters" do
+    before(:each) do
+      @mj.height = "height=198.1"
+    end
+
+    it "is set to 0.0" do
+      @mj.height.should == 0.0
+    end
+
+    it "IS  valid" do
+      # float property is set to 0.0 here
+      @mj.should be_valid
+    end
+  end
+
+
+  describe "with height as string containing random punctuation characters" do
+    before(:each) do
+      @mj.height = "$$ * $?"
+    end
+
+    it "is set to 0.0" do
+      @mj.height.should == 0.0
+    end
+
+    it "IS  valid" do
+      # float property is set to 0.0 here
+      @mj.should be_valid
+    end
+  end
+
+
+  describe "with nil height" do
+    before(:each) do
+      @mj.height = nil
+    end
+
+    it "is NOT valid" do
+      @mj.should_not be_valid
+    end
+
+    it "has a meaningful error message on for the property" do
+      @mj.valid?
+      @mj.errors.on(:height).should include("Height must be a number")
+    end
+  end
+end

data/spec/integration/numeric_validator/integer_only_true_spec.rb

@@ -0,0 +1,92 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+require __dir__.parent.parent + 'spec_helper'
+require __dir__ + 'spec_helper'
+
+describe Country do
+  before(:each) do
+    @country = Country.new(:name => "Italy", :area => "301318")
+  end
+
+  describe "with area as integer" do
+    before(:each) do
+      # no op in this case
+    end
+
+    it "is valid" do
+      @country.should be_valid
+    end
+  end
+
+
+  describe "with area as integer" do
+    before(:each) do
+      @country.area = 1603
+    end
+
+    it "is valid" do
+      @country.should be_valid
+    end
+  end
+
+
+  describe "with area as string containing only integers" do
+    before(:each) do
+      @country.area = "301318"
+    end
+
+    it "is valid" do
+      @country.should be_valid
+    end
+  end
+
+
+  describe "with area as string containing a float" do
+    before(:each) do
+      @country.area = "301318.6"
+    end
+
+    it "IS valid" do
+      @country.should be_valid
+    end
+  end
+
+
+  describe "with area as string containing random alphanumeric characters" do
+    before(:each) do
+      @country.area = "area=51"
+    end
+
+    it "IS NOT valid" do
+      @country.should_not be_valid
+    end
+  end
+
+
+  describe "with area as string containing random punctuation characters" do
+    before(:each) do
+      @country.area = "$$ * $?"
+    end
+
+    it "IS NOT valid" do
+      @country.should_not be_valid
+    end
+  end
+
+
+  describe "with unknown area" do
+    before(:each) do
+      @country.area = nil
+    end
+
+    it "is NOT valid" do
+      @country.should_not be_valid
+    end
+
+    it "has a meaningful error message on for the property" do
+      @country.valid?
+      @country.errors.on(:area).should include("Please use integers to specify area")
+    end
+  end
+end

data/spec/integration/numeric_validator/integer_type_spec.rb

@@ -0,0 +1,100 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+require __dir__.parent.parent + 'spec_helper'
+require __dir__ + 'spec_helper'
+
+describe City do
+  before(:each) do
+    @city = City.new(:name => "Tokyo", :founded_in => 1603)
+  end
+
+  describe "with foundation year as integer" do
+    before(:each) do
+      # no op in this case
+    end
+
+    it "is valid" do
+      @city.should be_valid
+    end
+  end
+
+
+  describe "with foundation year as integer" do
+    before(:each) do
+      @city.founded_in = 1603
+    end
+
+    it "is valid" do
+      @city.should be_valid
+    end
+  end
+
+
+  describe "with foundation year as string containing only integers" do
+    before(:each) do
+      @city.founded_in = "1603"
+    end
+
+    it "is valid" do
+      @city.should be_valid
+    end
+  end
+
+
+  describe "with foundation year as string containing a float" do
+    before(:each) do
+      @city.founded_in = "1603.6"
+    end
+
+    it "is valid" do
+      @city.should be_valid
+    end
+  end
+
+
+  describe "with foundation year as string containing random alphanumeric characters" do
+    before(:each) do
+      @city.founded_in = "founded-in=1603"
+    end
+
+    it "is set to nil" do
+      @city.founded_in.should be(nil)
+    end
+
+    it "IS NOT valid" do
+      @city.should_not be_valid
+    end
+  end
+
+
+  describe "with foundation year as string containing random punctuation characters" do
+    before(:each) do
+      @city.founded_in = "$$ * $?"
+    end
+
+    it "is set to nil" do
+      @city.founded_in.should be(nil)
+    end
+
+    it "IS NOT valid" do
+      @city.should_not be_valid
+    end
+  end
+
+
+  describe "with unknown foundation date" do
+    before(:each) do
+      @city.founded_in = nil
+    end
+
+    it "is NOT valid" do
+      @city.should_not be_valid
+    end
+
+    it "has a meaningful error message on for the property" do
+      @city.valid?
+      @city.errors.on(:founded_in).should include("Foundation year must be an integer")
+    end
+  end
+end