dm-validations 0.9.9 → 0.9.10

data/spec/integration/numeric_validator/spec_helper.rb

@@ -0,0 +1,77 @@
+# -*- coding: utf-8 -*-
+class BasketballPlayer
+  #
+  # Behaviors
+  #
+
+  include DataMapper::Resource
+
+  #
+  # Properties
+  #
+
+  property :id,     Serial
+  property :name,   String
+
+  property :height, Float, :auto_validation => false
+  property :weight, Float, :auto_validation => false
+
+  #
+  # Validations
+  #
+
+  validates_is_number :height, :weight
+end
+BasketballPlayer.auto_migrate!
+
+
+
+class City
+  #
+  # Behaviors
+  #
+
+  include DataMapper::Resource
+
+  #
+  # Properties
+  #
+
+  property :id,         Serial
+  property :name,       String
+
+  property :founded_in, Integer, :auto_validation => false
+
+  #
+  # Validations
+  #
+
+  validates_is_number :founded_in, :message => "Foundation year must be an integer"
+end
+City.auto_migrate!
+
+
+
+class Country
+  #
+  # Behaviors
+  #
+
+  include DataMapper::Resource
+
+  #
+  # Properties
+  #
+
+  property :id,         Serial
+  property :name,       String
+
+  property :area,       String, :integer_only => true
+
+  #
+  # Validations
+  #
+
+  validates_is_number :area, :message => "Please use integers to specify area"
+end
+Country.auto_migrate!

data/spec/integration/numeric_validator_spec.rb

@@ -20,15 +20,18 @@ describe DataMapper::Validate::NumericValidator do
   it "should validate a floating point value on the instance of a resource" do
     b = Bill.new
     b.should_not be_valid
+    b.errors.on(:amount_1).should include('Amount 1 must be a number')
+    b.errors.on(:amount_2).should include('Amount 2 must be a number')
     b.amount_1 = 'ABC'
     b.amount_2 = 27.343
     b.should_not be_valid
+    b.errors.on(:amount_1).should include('Amount 1 must be a number')
     b.amount_1 = '34.33'
     b.should be_valid
   end
 
   it "should validate an integer value on the instance of a resource" do
-    class Bill
+    class ::Bill
       property :quantity_1, String, :auto_validation => false
       property :quantity_2, Integer, :auto_validation => false
 
@@ -37,12 +40,22 @@ describe DataMapper::Validate::NumericValidator do
     end
     b = Bill.new
     b.valid?.should_not == true
+    b.errors.on(:quantity_1).should include('Quantity 1 must be an integer')
+    b.errors.on(:quantity_2).should include('Quantity 2 must be an integer')
     b.quantity_1 = '12.334'
     b.quantity_2 = 27.343
     b.valid?.should_not == true
+    b.errors.on(:quantity_1).should include('Quantity 1 must be an integer')
+    pending 'dm-core truncates float to integer' do
+      # FIXME: The next line should pass, but :quantity_2 has no errors. This is
+      #        because 27.343 has been truncated to 27 by the time it reaches the
+      #        validation. Is this a bug?
+      b.errors.on(:quantity_2).should include('Quantity 2 must be an integer')
+    end
     b.quantity_1 = '34.33'
     b.quantity_2 = 22
     b.valid?.should_not == true
+    b.errors.on(:quantity_1).should include('Quantity 1 must be an integer')
     b.quantity_1 = '34'
     b.valid?.should == true
 
@@ -55,7 +68,7 @@ describe DataMapper::Validate::NumericValidator do
 
   describe 'auto validation' do
     before :all do
-      class Fish
+      class ::Fish
         include DataMapper::Resource
         property :id,     Integer, :serial => true
         property :scales, Integer
@@ -65,7 +78,7 @@ describe DataMapper::Validate::NumericValidator do
     describe 'Float' do
       describe 'with default precision and scale' do
         before :all do
-          class CloudFish < Fish
+          class ::CloudFish < Fish
             property :average_weight, Float
           end
         end
@@ -109,7 +122,7 @@ describe DataMapper::Validate::NumericValidator do
 
       describe 'with default precision and scaleof 0' do
         before :all do
-          class RobotFish < Fish
+          class ::RobotFish < Fish
             property :average_weight, Float, :scale => 0
           end
         end
@@ -148,7 +161,7 @@ describe DataMapper::Validate::NumericValidator do
 
       describe 'with a precision of 4 and a scale of 2' do
         before :all do
-          class GoldFish < Fish
+          class ::GoldFish < Fish
             property :average_weight, Float, :precision => 4, :scale => 2
           end
         end
@@ -195,7 +208,7 @@ describe DataMapper::Validate::NumericValidator do
 
       describe 'with a precision of 2 and a scale of 2' do
         before :all do
-          class SilverFish < Fish
+          class ::SilverFish < Fish
             property :average_weight, Float, :precision => 2, :scale => 2
           end
         end

data/spec/integration/primitive_validator_spec.rb

@@ -16,10 +16,11 @@ describe DataMapper::Validate::PrimitiveValidator do
 
     b.birth_date = 'ABC'
     b.should_not be_valid
+    b.errors.on(:birth_date).should include('Birth date must be of type Date')
     b.birth_date.should eql('ABC')
     b.birth_date = '2008-01-01'
     b.should be_valid
-    b.birth_date.should eql(Date.civil(2008,1,1))
+    b.birth_date.should eql(Date.civil(2008, 1, 1))
   end
   it "should accept FalseClass even when the property type is TrueClass" do
     b = Monica.new

data/spec/integration/required_field_validator/association_spec.rb

@@ -0,0 +1,98 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+require __dir__.parent.parent + 'spec_helper'
+require __dir__ + 'spec_helper'
+
+if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+  class Artist
+    #
+    # Behaviors
+    #
+
+    include DataMapper::Resource
+
+    #
+    # Properties
+    #
+
+    property :id,   Integer, :serial => true
+    property :name, String,  :auto_validation => false
+
+    #
+    # Associations
+    #
+
+    has n, :albums
+
+    #
+    # Validations
+    #
+
+    validates_present :name
+  end
+
+  class Album
+    #
+    # Behaviors
+    #
+
+    include DataMapper::Resource
+
+    #
+    # Properties
+    #
+
+    property :id,        Integer, :serial => true
+    property :name,      String,  :auto_validation => false
+    property :artist_id, Integer, :index => :artist
+
+    #
+    # Associations
+    #
+
+    belongs_to :artist
+
+    #
+    # Validations
+    #
+
+    validates_present :name, :artist
+  end
+  Artist.auto_migrate!
+  Album.auto_migrate!
+
+
+
+  describe Album do
+    before :each do
+      @artist = Artist.create(:name => "Oceanlab")
+      @album  = @artist.albums.new(:name => "Sirens of the sea")
+    end
+
+    describe 'with a missing artist' do
+      before :each do
+        @album.artist = nil
+      end
+
+      it 'is not valid' do
+        @album.should_not be_valid
+      end
+
+      it 'has a meaninful error messages on association key property' do
+        @album.valid?
+        @album.errors.on(:artist).should include("Artist must not be blank")
+      end
+    end
+
+    describe 'with specified artist and name' do
+      before :each do
+        # no op
+      end
+
+      it 'is valid' do
+        @album.should be_valid
+      end
+    end
+  end
+end

data/spec/integration/required_field_validator/boolean_type_value_spec.rb

@@ -0,0 +1,149 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+require __dir__.parent.parent + 'spec_helper'
+require __dir__ + 'spec_helper'
+
+if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+  # keep in mind any ScmOperation has a default value for brand property
+  # so it is used
+  describe GitOperation do
+    before :each do
+      @operation = GitOperation.new(:network_connection => true,
+                                    :clean_working_copy => true,
+                                    :message            => "I did it! I did it!! Hell yeah!!!")
+    end
+
+    describe "without operation name" do
+      before(:each) do
+        @operation.name = nil
+      end
+      it_should_behave_like "unnamed SCM operation"
+    end
+
+
+
+    describe "without network connection" do
+      before(:each) do
+        # now note that false make sense from readability
+        # point of view but is incorrect from validator
+        # point of view ;)
+        @operation.network_connection = nil
+      end
+
+      it "is valid for committing" do
+        @operation.should be_valid_for_committing
+        @operation.errors.on(:network_connection).should be_blank
+      end
+
+      it "is not valid for pushing" do
+        @operation.should_not be_valid_for_pushing
+        @operation.errors.on(:network_connection).
+          first[:pushing].should include("cannot push without network connectivity")
+      end
+
+      it "is not valid for pulling" do
+        @operation.should_not be_valid_for_pulling
+        @operation.errors.on(:network_connection).
+          first[:pulling].should include("you must have network connectivity to pull from others")
+      end
+
+      it "is not valid in default context" do
+        @operation.should_not be_valid
+      end
+    end # describe "without network connection"
+
+    describe "with a network connection" do
+      before(:each) do
+        @operation.network_connection = false
+      end
+
+      it "is valid for committing" do
+        @operation.should be_valid_for_committing
+      end
+
+      it "is valid for pushing" do
+        @operation.should be_valid_for_pushing
+      end
+
+      it "is valid for pulling" do
+        @operation.should be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        @operation.should_not be_valid
+      end
+    end # describe "with a network connection"
+
+
+    describe "WITHOUT a clean working copy" do
+      before(:each) do
+        @operation.clean_working_copy = nil
+      end
+
+      it "is valid for committing" do
+        @operation.should be_valid_for_committing
+      end
+
+      it "is valid for pushing" do
+        @operation.should be_valid_for_pushing
+      end
+
+      it "is not valid for pulling" do
+        @operation.should_not be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        @operation.should_not be_valid
+      end
+    end # describe "without network connection"
+
+    describe "with a clean working copy" do
+      before(:each) do
+        @operation.clean_working_copy = true
+      end
+
+      it "is valid for committing" do
+        @operation.should be_valid_for_committing
+      end
+
+      it "is valid for pushing" do
+        @operation.should be_valid_for_pushing
+      end
+
+      it "is valid for pulling" do
+        @operation.should be_valid_for_pulling
+      end
+
+      it "is not valid in default context" do
+        @operation.should_not be_valid
+      end
+    end # describe "with a network connection"
+  end # describe GitOperation
+
+
+  describe SubversionOperation do
+    before(:each) do
+      @operation = SubversionOperation.new :name    => "ci", :network_connection => true,
+                                           :message => "v1.5.8", :clean_working_copy => true
+    end
+
+    describe "without operation name" do
+      before(:each) do
+        @operation.name = nil
+      end
+      it_should_behave_like "unnamed SCM operation"
+    end
+
+    describe "without network connection" do
+      before(:each) do
+        @operation.network_connection = nil
+      end
+
+      it "virtually useless" do
+        @operation.should_not be_valid_for_committing
+        @operation.should_not be_valid_for_log_viewing
+      end
+    end # describe "without network connection"
+  end
+end # if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES

data/spec/integration/required_field_validator/date_type_value_spec.rb

@@ -0,0 +1,126 @@
+require 'pathname'
+__dir__ = Pathname(__FILE__).dirname.expand_path
+
+require __dir__.parent.parent + 'spec_helper'
+require __dir__ + 'spec_helper'
+
+if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+  class Holiday
+    #
+    # Behaviors
+    #
+
+    include DataMapper::Resource
+
+    #
+    # Properties
+    #
+
+    property :id, Integer, :serial          => true
+    property :on, Date,    :auto_validation => false
+
+    #
+    # Validations
+    #
+
+    validates_present :on
+  end
+  Holiday.auto_migrate!
+
+
+  describe Holiday do
+    before :each do
+      @ny09 = Holiday.new(:on => Date.new(2008, 12, 31))
+      @ny09.should be_valid
+    end
+
+
+    describe "with on = nil" do
+      before(:each) do
+        @ny09.on = nil
+      end
+
+      it "is NOT valid" do
+        # nil = missing for Date value
+        # and Holiday only has default validation context
+        @ny09.should_not be_valid
+
+        # sanity check
+        @ny09.on = Date.new(2008, 12, 31)
+        @ny09.should be_valid
+      end
+    end # describe "with on = nil"
+
+
+    describe "with on = valid date" do
+      before(:each) do
+        @ny09.on = 0.0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        @ny09.should be_valid
+      end
+    end # describe "with on = 0.0"
+
+
+
+    describe "with on = 0" do
+      before(:each) do
+        @ny09.on = 0
+      end
+
+      it "IS valid" do
+        # yes, presence validator does not care
+        @ny09.should be_valid
+      end
+    end # describe "with on = 0"
+
+
+
+    describe "with on = 100" do
+      before(:each) do
+        @ny09.on = 100
+      end
+
+      it "IS valid" do
+        @ny09.should be_valid
+      end
+    end # describe "with on = 100"
+
+
+    describe "with on = 100.0" do
+      before(:each) do
+        @ny09.on = 100.0
+      end
+
+      it "IS valid" do
+        @ny09.should be_valid
+      end
+    end # describe "with on = 100.0"
+
+
+    describe "with on = -1100" do
+      before(:each) do
+        # presence validator does not care
+        @ny09.on = -1100
+      end
+
+      it "IS valid" do
+        @ny09.should be_valid
+      end
+    end # describe "with on = -1100"
+
+
+    describe "with on = -1100.5" do
+      before(:each) do
+        # presence validator does not care
+        @ny09.on = -1100.5
+      end
+
+      it "IS valid" do
+        @ny09.should be_valid
+      end
+    end # describe "with on = -1100.5"
+  end # describe Holiday
+end # if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES