dm-core 0.10.2 → 1.0.0.rc1

data/spec/public/resource_spec.rb

@@ -76,5 +76,106 @@ describe DataMapper::Resource do
 
     it_should_behave_like 'A public Resource'
     it_should_behave_like 'A Resource supporting Strategic Eager Loading'
+
+    it 'A resource should respond to raise_on_save_failure' do
+      @user.should respond_to(:raise_on_save_failure)
+    end
+
+    describe '#raise_on_save_failure' do
+      after do
+        # reset to the default value
+        reset_raise_on_save_failure(@user_model)
+        reset_raise_on_save_failure(@user)
+      end
+
+      subject { @user.raise_on_save_failure }
+
+      describe 'when model.raise_on_save_failure has not been set' do
+        it { should be(false) }
+      end
+
+      describe 'when model.raise_on_save_failure has been set to true' do
+        before do
+          @user_model.raise_on_save_failure = true
+        end
+
+        it { should be(true) }
+      end
+
+      describe 'when resource.raise_on_save_failure has been set to true' do
+        before do
+          @user.raise_on_save_failure = true
+        end
+
+        it { should be(true) }
+      end
+    end
+
+    it 'A model should respond to raise_on_save_failure=' do
+      @user_model.should respond_to(:raise_on_save_failure=)
+    end
+
+    describe '#raise_on_save_failure=' do
+      after do
+        # reset to the default value
+        @user_model.raise_on_save_failure = false
+      end
+
+      subject { @user_model.raise_on_save_failure = @value }
+
+      describe 'with a true value' do
+        before do
+          @value = true
+        end
+
+        it { should be(true) }
+
+        it 'should set raise_on_save_failure' do
+          method(:subject).should change {
+            @user_model.raise_on_save_failure
+          }.from(false).to(true)
+        end
+      end
+
+      describe 'with a false value' do
+        before do
+          @value = false
+        end
+
+        it { should be(false) }
+
+        it 'should set raise_on_save_failure' do
+          method(:subject).should_not change {
+            @user_model.raise_on_save_failure
+          }
+        end
+      end
+    end
+
+    [ :save, :save! ].each do |method|
+      describe "##{method}" do
+        subject { @user.__send__(method) }
+
+        describe 'when raise_on_save_failure is true' do
+          before do
+            @user.raise_on_save_failure = true
+          end
+
+          describe 'and it is a savable resource' do
+            it { should be(true) }
+          end
+
+          describe 'and it is an invalid resource' do
+            before do
+              @user.name = nil  # name is required
+            end
+
+            it 'should raise an exception' do
+              method(:subject).should raise_error(DataMapper::SaveFailureError, "Blog::User##{method} returned false, Blog::User was not saved")
+            end
+          end
+        end
+      end
+    end
   end
 end

data/spec/public/sel_spec.rb

@@ -34,22 +34,12 @@ describe 'SEL', 'with STI subclasses' do
 
   supported_by :all do
     before :all do
-      @skip = defined?(DataMapper::Adapters::YamlAdapter) && @adapter.kind_of?(DataMapper::Adapters::YamlAdapter)
-    end
-
-    before :all do
-      rescue_if 'TODO: fix YAML serialization/deserialization', @skip do
-        author1 = @author_model.create(:name => 'Dan Kubb')
-        author2 = @author_model.create(:name => 'Sindre Aarsaether')
-
-        @article_model.create(:title => 'SEL',               :author => author1)
-        @article_model.create(:title => 'STI',               :author => author1)
-        @comment_model.create(:title => 'SEL and STI error', :author => author2)
-      end
-    end
+      author1 = @author_model.create(:name => 'Dan Kubb')
+      author2 = @author_model.create(:name => 'Sindre Aarsaether')
 
-    before do
-      pending if @skip
+      @article_model.create(:title => 'SEL',               :author => author1)
+      @article_model.create(:title => 'STI',               :author => author1)
+      @comment_model.create(:title => 'SEL and STI error', :author => author2)
     end
 
     it 'should allow STI loading of mixed relationships' do

data/spec/public/shared/collection_shared_spec.rb

@@ -51,13 +51,13 @@ share_examples_for 'A public Collection' do
   describe '#blank?' do
     describe 'when the collection is empty' do
       it 'should be true' do
-        @articles.clear.blank?.should be_true
+        @articles.clear.blank?.should be(true)
       end
     end
 
     describe 'when the collection is not empty' do
       it 'should be false' do
-        @articles.blank?.should be_false
+        @articles.blank?.should be(false)
       end
     end
   end
@@ -67,7 +67,7 @@ share_examples_for 'A public Collection' do
   describe '#clean?' do
     describe 'with all clean resources in the collection' do
       it 'should return true' do
-        @articles.clean?.should be_true
+        @articles.clean?.should be(true)
       end
     end
 
@@ -77,7 +77,7 @@ share_examples_for 'A public Collection' do
       end
 
       it 'should return true' do
-        @articles.clean?.should be_false
+        @articles.clean?.should be(false)
       end
     end
   end
@@ -422,7 +422,7 @@ share_examples_for 'A public Collection' do
         end
 
         it 'should return true' do
-          @return.should be_true
+          @return.should be(true)
         end
 
         it 'should remove the Resources from the datasource' do
@@ -443,7 +443,7 @@ share_examples_for 'A public Collection' do
         end
 
         it 'should return true' do
-          @return.should be_true
+          @return.should be(true)
         end
 
         it 'should remove the Resources from the datasource' do
@@ -466,7 +466,7 @@ share_examples_for 'A public Collection' do
   describe '#dirty?' do
     describe 'with all clean resources in the collection' do
       it 'should return false' do
-        @articles.dirty?.should be_false
+        @articles.dirty?.should be(false)
       end
     end
 
@@ -476,7 +476,7 @@ share_examples_for 'A public Collection' do
       end
 
       it 'should return true' do
-        @articles.dirty?.should be_true
+        @articles.dirty?.should be(true)
       end
     end
   end
@@ -874,7 +874,7 @@ share_examples_for 'A public Collection' do
 
       [ :id, :content, :title ].each do |attribute|
         it "should have query field #{attribute.inspect} loaded" do
-          @collection.each { |resource| resource.attribute_loaded?(attribute).should be_true }
+          @collection.each { |resource| resource.attribute_loaded?(attribute).should be(true) }
         end
       end
     end
@@ -906,7 +906,7 @@ share_examples_for 'A public Collection' do
 
       [ :id, :content, :title ].each do |attribute|
         it "should have query field #{attribute.inspect} loaded" do
-          @collection.each { |resource| resource.attribute_loaded?(attribute).should be_true }
+          @collection.each { |resource| resource.attribute_loaded?(attribute).should be(true) }
         end
       end
     end
@@ -1004,7 +1004,7 @@ share_examples_for 'A public Collection' do
         end
 
         it 'should return true' do
-          @return.should be_true
+          @return.should be(true)
         end
 
         it 'should save each Resource' do
@@ -1021,7 +1021,7 @@ share_examples_for 'A public Collection' do
         end
 
         it 'should return true' do
-          @return.should be_true
+          @return.should be(true)
         end
       end
     end
@@ -1572,20 +1572,6 @@ share_examples_for 'A public Collection' do
     it { should respond_to(method) }
 
     describe "##{method}" do
-      describe 'with no arguments' do
-        before :all do
-          @return = @articles.send(method)
-        end
-
-        if method == :update!
-          should_not_be_a_kicker
-        end
-
-        it 'should return true' do
-          @return.should be_true
-        end
-      end
-
       describe 'with attributes' do
         before :all do
           @attributes = { :title => 'Updated Title' }
@@ -1598,7 +1584,7 @@ share_examples_for 'A public Collection' do
         end
 
         it 'should return true' do
-          @return.should be_true
+          @return.should be(true)
         end
 
         it 'should update attributes of all Resources' do
@@ -1623,7 +1609,7 @@ share_examples_for 'A public Collection' do
         end
 
         it 'should return true' do
-          @return.should be_true
+          @return.should be(true)
         end
 
         it 'should update attributes of all Resources' do
@@ -1646,7 +1632,7 @@ share_examples_for 'A public Collection' do
         end
 
         it 'should return false' do
-          @return.should be_false
+          @return.should be(false)
         end
       end
 
@@ -1664,7 +1650,7 @@ share_examples_for 'A public Collection' do
         end
 
         it 'should return true' do
-          @return.should be_true
+          @return.should be(true)
         end
 
         it 'should bypass validation' do

data/spec/public/shared/finder_shared_spec.rb

@@ -1325,8 +1325,7 @@ share_examples_for 'Finder Interface' do
         @article.previous = @new
         @new.previous     = @other
 
-        @article.save
-        @new.save
+        @article.save.should be(true)
       end
 
       describe 'with no arguments' do
@@ -1388,8 +1387,7 @@ share_examples_for 'Finder Interface' do
         @article.revisions << @new
         @new.revisions     << @other
 
-        @article.save
-        @new.save
+        @article.save.should be(true)
       end
 
       describe 'with no arguments' do

data/spec/public/shared/property_shared_spec.rb

@@ -0,0 +1,176 @@
+share_examples_for 'A public Property' do
+  before :all do
+    %w[ @type @primitive @name @value @other_value ].each do |ivar|
+      raise "+#{ivar}+ should be defined in before block" unless instance_variable_defined?(ivar)
+    end
+
+    module ::Blog
+      class Article
+        include DataMapper::Resource
+        property :id, Serial
+      end
+    end
+
+    @model = Blog::Article
+  end
+
+  describe "with a sub-type" do
+    before :all do
+      class ::SubType < @type; end
+      @subtype = ::SubType
+      @type.accept_options :foo, :bar
+    end
+
+    after :all do
+      Object.send(:remove_const, :SubType)
+    end
+
+    describe ".accept_options" do
+      describe "when provided :foo, :bar" do
+        it "should add new options" do
+          [@type, @subtype].each do |type|
+            type.accepted_options.include?(:foo).should be(true)
+            type.accepted_options.include?(:bar).should be(true)
+          end
+        end
+
+        it "should create predefined option setters" do
+          [@type, @subtype].each do |type|
+            type.should respond_to(:foo)
+            type.should respond_to(:bar)
+          end
+        end
+
+        describe "auto-generated option setters" do
+          before :all do
+            [@type, @subtype].each do |type|
+              type.foo true
+              type.bar 1
+              @property = type.new(@model, @name)
+            end
+          end
+
+          it "should set the pre-defined option values" do
+            @property.options[:foo].should == true
+            @property.options[:bar].should == 1
+          end
+        end
+      end
+    end
+
+    describe ".descendants" do
+      it "should include the sub-type" do
+        @type.descendants.include?(SubType).should be(true)
+      end
+    end
+
+    describe ".primitive" do
+      it "should return the primitive class" do
+        [@type, @subtype].each do |type|
+          type.primitive.should be(@primitive)
+        end
+      end
+
+      it "should change the primitive class" do
+        @subtype.primitive Object
+        @subtype.primitive.should be(Object)
+      end
+    end
+  end
+
+  [:allow_blank, :allow_nil].each do |opt|
+    describe "##{method = "#{opt}?"}" do
+      [true, false].each do |value|
+        describe "when created with :#{opt} => #{value}" do
+          before :all do
+            @property = @type.new(@model, @name, opt => value)
+          end
+
+          it "should return #{value}" do
+            @property.send(method).should be(value)
+          end
+        end
+      end
+
+      describe "when created with :#{opt} => true and :required => true" do
+        it "should fail with ArgumentError" do
+          lambda {
+            @property = @type.new(@model, @name, opt => true, :required => true)
+          }.should raise_error(ArgumentError,
+            "options[:required] cannot be mixed with :allow_nil or :allow_blank")
+        end
+      end
+    end
+  end
+
+  [:key?, :required?, :index, :unique_index, :unique?].each do |method|
+    describe "##{method}" do
+      [true, false].each do |value|
+        describe "when created with :#{method} => #{value}" do
+          before :all do
+            opt = method.to_s.sub('?', '').to_sym
+            @property = @type.new(@model, @name, opt => value)
+          end
+
+          it "should return #{value}" do
+            @property.send(method).should be(value)
+          end
+        end
+      end
+    end
+  end
+
+  describe "#lazy?" do
+    describe "when created with :lazy => true, :key => false" do
+      before :all do
+        @property = @type.new(@model, @name, :lazy => true, :key => false)
+      end
+
+      it "should return true" do
+        @property.lazy?.should be(true)
+      end
+    end
+
+    describe "when created with :lazy => true, :key => true" do
+      before :all do
+        @property = @type.new(@model, @name, :lazy => true, :key => true)
+      end
+
+      it "should return false" do
+        @property.lazy?.should be(false)
+      end
+    end
+  end
+
+  describe "#custom?" do
+    describe "when DM::Type is not provided" do
+      before :all do
+        @property = @type.new(@model, @name)
+      end
+
+      it "should be false" do
+        @property.custom?.should be(false)
+      end
+    end
+  end
+
+  [:instance_of?, :kind_of?].each do |method|
+    describe "##{method}" do
+      before :all do
+        @property = @type.new(@model, @name)
+      end
+
+      describe "when provided Property" do
+        it "should return true" do
+          @property.send(method, DataMapper::Property).should be(true)
+        end
+      end
+
+      describe "when provided property class" do
+        it "should return true" do
+          @property.send(method, @type).should be(true)
+        end
+      end
+    end
+  end
+end