dm-core 0.10.2 → 1.0.0.rc1

data/spec/public/property/binary_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Binary do
+  before :all do
+    @name  = :title
+    @type  = DataMapper::Property::Binary
+    @primitive = String
+    @value = 'value'
+    @other_value = 'return value'
+    @invalid_value = 1
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/boolean_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Boolean do
+  before :all do
+    @name  = :active
+    @type  = DataMapper::Property::Boolean
+    @primitive = TrueClass
+    @value = true
+    @other_value = false
+    @invalid_value = 1
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/class_spec.rb

@@ -0,0 +1,20 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Class do
+  before :all do
+    Object.send(:remove_const, :Foo) if defined?(Foo)
+    Object.send(:remove_const, :Bar) if defined?(Bar)
+
+    class ::Foo; end
+    class ::Bar; end
+
+    @name  = :type
+    @type  = DataMapper::Property::Class
+    @primitive = Class
+    @value = Foo
+    @other_value = Bar
+    @invalid_value = 1
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/date_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Date do
+  before :all do
+    @name  = :created_on
+    @type  = DataMapper::Property::Date
+    @primitive = Date
+    @value = Date.today
+    @other_value = Date.today+1
+    @invalid_value = 1
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/date_time_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::DateTime do
+  before :all do
+    @name  = :created_at
+    @type  = DataMapper::Property::DateTime
+    @primitive = DateTime
+    @value = DateTime.now
+    @other_value = DateTime.now+15
+    @invalid_value = 1
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/decimal_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Decimal do
+  before :all do
+    @name  = :rate
+    @type  = DataMapper::Property::Decimal
+    @primitive = BigDecimal
+    @value = BigDecimal('1.0')
+    @other_value = BigDecimal('2.0')
+    @invalid_value = true
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/{types → property}/discriminator_spec.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'spec_helper'))
 
-describe DataMapper::Types::Discriminator do
+describe DataMapper::Property::Discriminator do
   before :all do
     module ::Blog
       class Article
@@ -98,17 +98,7 @@ describe DataMapper::Types::Discriminator do
 
   supported_by :all do
     before :all do
-      @skip = defined?(DataMapper::Adapters::YamlAdapter) && @adapter.kind_of?(DataMapper::Adapters::YamlAdapter)
-    end
-
-    before do
-      pending if @skip
-    end
-
-    before :all do
-      rescue_if 'TODO: fix YAML serialization/deserialization', @skip do
-        @announcement = @announcement_model.create(:title => 'Announcement')
-      end
+      @announcement = @announcement_model.create(:title => 'Announcement')
     end
 
     it 'should persist the type' do

data/spec/public/property/float_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Float do
+  before :all do
+    @name  = :rating
+    @type  = DataMapper::Property::Float
+    @primitive = Float
+    @value = 0.1
+    @other_value = 0.2
+    @invalid_value = '1'
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/integer_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Integer do
+  before :all do
+    @name  = :age
+    @type  = DataMapper::Property::Integer
+    @primitive = Integer
+    @value = 1
+    @other_value = 2
+    @invalid_value = '1'
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/object_spec.rb

@@ -32,19 +32,19 @@ describe DataMapper::Property, 'Object type' do
 
   it { should respond_to(:value) }
 
-  describe '#value' do
+  describe '#dump' do
     describe 'with a value' do
       before do
         @value = { 'lang' => 'en_CA' }
       end
 
-      subject { @property.value(@value) }
+      subject { @property.dump(@value) }
 
-      it { @property.type.load(subject, @property).should == @value }
+      it { @property.load(subject).should == @value }
     end
 
     describe 'with nil' do
-      subject { @property.value(nil) }
+      subject { @property.dump(nil) }
 
       it { should be_nil }
     end
@@ -56,7 +56,7 @@ describe DataMapper::Property, 'Object type' do
     describe 'with a valid primitive' do
       subject { @property.valid?('lang' => 'en_CA') }
 
-      it { should be_true }
+      it { should be(true) }
     end
 
     describe 'with nil and property is not required' do
@@ -66,28 +66,24 @@ describe DataMapper::Property, 'Object type' do
 
       subject { @property.valid?(nil) }
 
-      it { should be_true }
+      it { should be(true) }
     end
 
     describe 'with nil and property is required' do
       subject { @property.valid?(nil) }
 
-      it { should be_false }
+      it { should be(false) }
     end
 
     describe 'with nil and property is required, but validity is negated' do
       subject { @property.valid?(nil, true) }
 
-      it { should be_true }
+      it { should be(true) }
     end
   end
 
   describe 'persistable' do
     supported_by :all do
-      before :all do
-        @do_adapter = defined?(DataMapper::Adapters::DataObjectsAdapter) && @adapter.kind_of?(DataMapper::Adapters::DataObjectsAdapter)
-      end
-
       before :all do
         @resource = @model.create(:title => 'Test', :meta => { 'lang' => 'en_CA' })
       end
@@ -95,11 +91,7 @@ describe DataMapper::Property, 'Object type' do
       subject { @resource.reload.meta }
 
       it 'should load the correct value' do
-        pending_if 'Fix adapters to use different serialization methods', !@do_adapter do
-          pending_if 'Fix DO adapter to send String for Text primitive', !!(RUBY_PLATFORM =~ /java/) do
-            should == { 'lang' => 'en_CA' }
-          end
-        end
+        should == { 'lang' => 'en_CA' }
       end
     end
   end

data/spec/public/property/serial_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Serial do
+  before :all do
+    @name  = :id
+    @type  = DataMapper::Property::Serial
+    @primitive = Integer
+    @value = 1
+    @other_value = 2
+    @invalid_value = 'foo'
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/string_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::String do
+  before :all do
+    @name  = :name
+    @type  = DataMapper::Property::String
+    @primitive = String
+    @value = 'value'
+    @other_value = 'return value'
+    @invalid_value = 1
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property/text_spec.rb

@@ -0,0 +1,52 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'spec_helper'))
+
+describe DataMapper::Property::Text do
+  before :all do
+    @name  = :title
+    @type  = DataMapper::Property::Text
+    @primitive = String
+    @value = 'value'
+    @other_value = 'return value'
+    @invalid_value = 1
+  end
+
+  it_should_behave_like "A public Property"
+
+  describe 'migration with an index' do
+    supported_by :all do
+      before do
+        @model = DataMapper::Model.new do
+          storage_names[:default] = 'anonymous'
+
+          property :id,   DataMapper::Property::Serial
+          property :body, DataMapper::Property::Text, :index => true
+        end
+      end
+
+      it 'should allow a migration' do
+        lambda {
+          @model.auto_migrate!
+        }.should_not raise_error(DataObjects::SyntaxError)
+      end
+    end
+  end if defined?(DataObjects::SyntaxError)
+
+  describe 'migration with a unique index' do
+    supported_by :all do
+      before do
+        @model = DataMapper::Model.new do
+          storage_names[:default] = 'anonymous'
+
+          property :id,   DataMapper::Property::Serial
+          property :body, DataMapper::Property::Text, :unique_index => true
+        end
+      end
+
+      it 'should allow a migration' do
+        lambda {
+          @model.auto_migrate!
+        }.should_not raise_error(DataObjects::SyntaxError)
+      end
+    end
+  end if defined?(DataObjects::SyntaxError)
+end

data/spec/public/property/time_spec.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '../..', 'spec_helper'))
+
+describe DataMapper::Property::Time do
+  before :all do
+    @name  = :deleted_at
+    @type  = DataMapper::Property::Time
+    @primitive = Time
+    @value = Time.now
+    @other_value = Time.now+15
+    @invalid_value = 1
+  end
+
+  it_should_behave_like "A public Property"
+end

data/spec/public/property_spec.rb

@@ -69,36 +69,6 @@ describe DataMapper::Property do
       end
     end
 
-    describe '#get' do
-      before :all do
-        @image = Image.create(:md5hash     => '5268f0f3f452844c79843e820f998869',
-                              :title       => 'Rome at the sunset',
-                              :description => 'Just wow')
-
-        @image.should be_saved
-
-        @image = Image.first(:fields => [ :md5hash, :title ], :md5hash => @image.md5hash)
-      end
-
-      it 'triggers loading for lazy loaded properties' do
-        Image.properties[:description].get(@image)
-        Image.properties[:description].loaded?(@image).should be(true)
-      end
-
-      it 'assigns loaded value to @ivar' do
-        Image.properties[:description].get(@image)
-        @image.instance_variable_get(:@description).should == 'Just wow'
-      end
-
-      it 'sets default value for new records with nil value' do
-        Image.properties[:format].get(@image).should == 'jpeg'
-      end
-
-      it 'returns property value' do
-        Image.properties[:description].get(@image).should == 'Just wow'
-      end
-    end
-
     describe '#get!' do
       before :all do
         @image = Image.new
@@ -116,7 +86,7 @@ describe DataMapper::Property do
 
     describe '#index' do
       it 'returns true when property has an index' do
-        Track.properties[:title].index.should be_true
+        Track.properties[:title].index.should be(true)
       end
 
       it 'returns index name when property has a named index' do
@@ -155,27 +125,27 @@ describe DataMapper::Property do
     describe '#key?' do
       describe 'returns true when property is a ' do
         it 'serial key' do
-          Track.properties[:id].key?.should be_true
+          Track.properties[:id].key?.should be(true)
         end
         it 'natural key' do
-          Image.properties[:md5hash].key?.should be_true
+          Image.properties[:md5hash].key?.should be(true)
         end
       end
 
       it 'returns true when property is a part of composite key'
 
       it 'returns false when property does not relate to a key' do
-        Track.properties[:title].key?.should be_false
+        Track.properties[:title].key?.should be(false)
       end
     end
 
     describe '#lazy?' do
       it 'returns true when property is lazy loaded' do
-        Image.properties[:description].lazy?.should be_true
+        Image.properties[:description].lazy?.should be(true)
       end
 
       it 'returns false when property is not lazy loaded' do
-        Track.properties[:artist].lazy?.should be_false
+        Track.properties[:artist].lazy?.should be(false)
       end
     end
 
@@ -257,59 +227,21 @@ describe DataMapper::Property do
 
     describe '#allow_nil?' do
       it 'returns true when property can accept nil as its value' do
-        Track.properties[:artist].allow_nil?.should be_true
+        Track.properties[:artist].allow_nil?.should be(true)
       end
 
       it 'returns false when property nil value is prohibited for this property' do
-        Image.properties[:title].allow_nil?.should be_false
+        Image.properties[:title].allow_nil?.should be(false)
       end
     end
 
     describe '#serial?' do
       it 'returns true when property is serial (auto incrementing)' do
-        Track.properties[:id].serial?.should be_true
+        Track.properties[:id].serial?.should be(true)
       end
 
       it 'returns false when property is NOT serial (auto incrementing)' do
-        Image.properties[:md5hash].serial?.should be_false
-      end
-    end
-
-    # What's going on here:
-    #
-    # we first set original value and make an assertion on it
-    # then we try to set it again, which clears original value
-    # (since original value is set, property is no longer dirty)
-    describe '#set_original_value' do
-      before :all do
-        @image = Image.create(
-          :md5hash     => '5268f0f3f452844c79843e820f998869',
-          :title       => 'Rome at the sunset',
-          :description => 'Just wow'
-        )
-
-        @property = Image.properties[:title]
-      end
-
-      describe 'when value changes' do
-        before :all do
-          @property.set_original_value(@image, 'New title')
-        end
-
-        it 'sets original value of the property' do
-          @image.original_attributes[@property].should == 'Rome at the sunset'
-        end
-      end
-
-      describe 'when value stays the same' do
-        before :all do
-          @property.set_original_value(@image, 'Rome at the sunset')
-        end
-
-        it 'only sets original value when it has changed' do
-          @property.set_original_value(@image, 'Rome at the sunset')
-          @image.original_attributes.should_not have_key(@property)
-        end
+        Image.properties[:md5hash].serial?.should be(false)
       end
     end
 
@@ -334,11 +266,6 @@ describe DataMapper::Property do
         @image.title.should == 'http://test.example/'
       end
 
-      it 'stores original value' do
-        @property.set(@image, 'Updated value')
-        @image.original_attributes[@property].should == 'Rome at the sunset'
-      end
-
       it 'sets new property value' do
         @property.set(@image, 'Updated value')
         @image.title.should == 'Updated value'
@@ -362,28 +289,42 @@ describe DataMapper::Property do
 
     describe '#unique?' do
       it 'is true for fields that explicitly given uniq index' do
-        Track.properties[:musicbrainz_hash].unique?.should be_true
+        Track.properties[:musicbrainz_hash].unique?.should be(true)
       end
 
       it 'is true for serial fields' do
         pending do
-          Track.properties[:title].unique?.should be_true
+          Track.properties[:title].unique?.should be(true)
         end
       end
 
       it 'is true for keys' do
-        Image.properties[:md5hash].unique?.should be_true
+        Image.properties[:md5hash].unique?.should be(true)
       end
     end
 
     describe '#unique_index' do
       it 'returns true when property has unique index' do
-        Track.properties[:musicbrainz_hash].unique_index.should be_true
+        Track.properties[:musicbrainz_hash].unique_index.should be(true)
       end
 
       it 'returns nil when property has no unique index' do
         Image.properties[:title].unique_index.should be_nil
       end
     end
+
+    describe "exception on bad property names" do
+      it "is raised for 'model'" do
+        lambda {
+          Track.property :model, String
+        }.should raise_error(ArgumentError)
+      end
+
+      it "is raised for 'repository_name'" do
+        lambda {
+          Track.property :repository_name, String
+        }.should raise_error(ArgumentError)
+      end
+    end
   end
 end # DataMapper::Property