dm-core 0.10.2 → 1.0.0.rc1

data/spec/public/model/hook_spec.rb

@@ -0,0 +1,209 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'spec_helper'))
+
+describe DataMapper::Model::Hook do
+  before :all do
+    class ::ModelHookSpecs
+      include DataMapper::Resource
+
+      property :id, Serial
+
+      def an_instance_method
+      end
+    end
+
+    class ::ModelHookSpecsSubclass < ModelHookSpecs; end
+  end
+
+  before :all do
+    @resource = ModelHookSpecs.new
+  end
+
+  describe '#before' do
+    describe 'an instance method' do
+      before do
+        @hooks = hooks = []
+        ModelHookSpecs.before(:an_instance_method) { hooks << :before_instance_method }
+
+        @resource.an_instance_method
+      end
+
+      it 'should execute before instance method hook' do
+        @hooks.should == [ :before_instance_method ]
+      end
+    end
+
+    describe 'save' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.before(:save) { hooks << :before_save }
+
+          @resource.save
+        end
+
+        it 'should execute before save hook' do
+          @hooks.should == [ :before_save ]
+        end
+      end
+    end
+
+    describe 'create' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.before(:create) { hooks << :before_create }
+
+          @resource.save
+        end
+
+        it 'should execute before create hook' do
+          @hooks.should == [ :before_create ]
+        end
+      end
+    end
+
+    describe 'update' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.before(:update) { hooks << :before_update }
+
+          @resource.save
+          @resource.update(:id => 2)
+        end
+
+        it 'should execute before update hook' do
+          @hooks.should == [ :before_update ]
+        end
+      end
+    end
+
+    describe 'destroy' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.before(:destroy) { hooks << :before_destroy }
+
+          @resource.save
+          @resource.destroy
+        end
+
+        it 'should execute before destroy hook' do
+          @hooks.should == [ :before_destroy ]
+        end
+      end
+    end
+
+    describe 'with an inherited hook' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.before(:create) { hooks << :inherited_hook }
+        end
+
+        it 'should execute inherited hook' do
+          ModelHookSpecsSubclass.create
+          @hooks.should == [ :inherited_hook ]
+        end
+      end
+    end
+
+    describe 'with a hook declared in the subclasss' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecsSubclass.before(:create) { hooks << :hook }
+        end
+
+        it 'should execute hook' do
+          ModelHookSpecsSubclass.create
+          @hooks.should == [ :hook ]
+        end
+
+        it 'should not alter hooks in the parent class' do
+          @hooks.should be_empty
+          ModelHookSpecs.create
+          @hooks.should == []
+        end
+      end
+    end
+
+  end
+
+  describe '#after' do
+    describe 'an instance method' do
+      before do
+        @hooks = hooks = []
+        ModelHookSpecs.after(:an_instance_method) { hooks << :after_instance_method }
+
+        @resource.an_instance_method
+      end
+
+      it 'should execute after instance method hook' do
+        @hooks.should == [ :after_instance_method ]
+      end
+    end
+
+    describe 'save' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.after(:save) { hooks << :after_save }
+
+          @resource.save
+        end
+
+        it 'should execute after save hook' do
+          @hooks.should == [ :after_save ]
+        end
+      end
+    end
+
+    describe 'create' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.after(:create) { hooks << :after_create }
+
+          @resource.save
+        end
+
+        it 'should execute after create hook' do
+          @hooks.should == [ :after_create ]
+        end
+      end
+    end
+
+    describe 'update' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.after(:update) { hooks << :after_update }
+
+          @resource.save
+          @resource.update(:id => 2)
+        end
+
+        it 'should execute after update hook' do
+          @hooks.should == [ :after_update ]
+        end
+      end
+    end
+
+    describe 'destroy' do
+      supported_by :all do
+        before do
+          @hooks = hooks = []
+          ModelHookSpecs.after(:destroy) { hooks << :after_destroy }
+
+          @resource.save
+          @resource.destroy
+        end
+
+        it 'should execute after destroy hook' do
+          @hooks.should == [ :after_destroy ]
+        end
+      end
+    end
+  end
+end

data/spec/public/model/property_spec.rb

@@ -0,0 +1,35 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'spec_helper'))
+
+describe DataMapper::Model::Property do
+  before :each do
+    Object.send(:remove_const, :ModelPropertySpecs) if defined?(ModelPropertySpecs)
+    class ::ModelPropertySpecs
+      include DataMapper::Resource
+
+      property :id, Serial
+    end
+  end
+
+  describe '#property' do
+
+    subject { ModelPropertySpecs.property(:name, String) }
+
+    it 'should define a name accessor' do
+      ModelPropertySpecs.should_not be_method_defined(:name)
+      subject
+      ModelPropertySpecs.should be_method_defined(:name)
+    end
+
+    it 'should define a name= mutator' do
+      ModelPropertySpecs.should_not be_method_defined(:name=)
+      subject
+      ModelPropertySpecs.should be_method_defined(:name=)
+    end
+
+    it 'should raise an exception if the method exists' do
+      lambda {
+        ModelPropertySpecs.property(:key, String)
+      }.should raise_error(ArgumentError, '+name+ was :key, which cannot be used as a property name since it collides with an existing method')
+    end
+  end
+end

data/spec/public/model/relationship_spec.rb

@@ -110,12 +110,12 @@ share_examples_for 'it creates a one mutator' do
       end
 
       it 'should persist the Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @car.model.get(*@car.key).__send__(@name).should == @expected
       end
 
       it 'should persist the associated Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @expected.should be_saved
         @expected.model.get(*@expected.key).car.should == @car
       end
@@ -150,12 +150,12 @@ share_examples_for 'it creates a one mutator' do
       end
 
       it 'should persist the Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @car.model.get(*@car.key).__send__(@name).should == @return
       end
 
       it 'should persist the associated Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @return.should be_saved
         @return.model.get(*@return.key).car.should == @car
       end
@@ -177,7 +177,7 @@ share_examples_for 'it creates a one mutator' do
       end
 
       it 'should persist as nil' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @car.model.get(*@car.key).__send__(@name).should be_nil
       end
     end
@@ -209,12 +209,12 @@ share_examples_for 'it creates a one mutator' do
       end
 
       it 'should persist the Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @car.model.get(*@car.key).__send__(@name).should == @expected
       end
 
       it 'should persist the associated Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @expected.should be_saved
         @expected.model.get(*@expected.key).car.should == @car
       end
@@ -226,7 +226,7 @@ share_examples_for 'it creates a many accessor' do
   describe 'accessor' do
     describe 'when there is no child resource and the source is saved' do
       before :all do
-        @car.save.should be_true
+        @car.save.should be(true)
         @return = @car.__send__(@name)
       end
 
@@ -278,6 +278,7 @@ share_examples_for 'it creates a many accessor' do
         @car.save
 
         @expected = @car.__send__(@name).first
+        @expected.should_not be_nil
 
         # set the model scope to only return the first record
         @model.default_scope.update(@model.key(@repository.name).zip(@expected.key).to_hash)
@@ -321,12 +322,12 @@ share_examples_for 'it creates a many mutator' do
       end
 
       it 'should persist the Collection' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @car.model.get(*@car.key).__send__(@name).should == @expected
       end
 
       it 'should persist the associated Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @expected.each { |resource| resource.should be_saved }
         @expected.each { |resource| resource.model.get(*resource.key).car.should == @car }
       end
@@ -356,12 +357,12 @@ share_examples_for 'it creates a many mutator' do
       end
 
       it 'should persist the Collection' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @car.model.get(*@car.key).__send__(@name).should == @return
       end
 
       it 'should persist the associated Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @return.each { |resource| resource.should be_saved }
         @return.each { |resource| resource.model.get(*resource.key).car.should == @car }
       end
@@ -383,7 +384,7 @@ share_examples_for 'it creates a many mutator' do
       end
 
       it 'should persist as an empty Collection' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @car.model.get(*@car.key).__send__(@name).should be_empty
       end
     end
@@ -413,12 +414,12 @@ share_examples_for 'it creates a many mutator' do
       end
 
       it 'should persist the Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @car.model.get(*@car.key).__send__(@name).should == @expected
       end
 
       it 'should persist the associated Resource' do
-        @car.save.should be_true
+        @car.save.should be(true)
         @expected.each { |resource| resource.should be_saved }
         @expected.each { |resource| resource.model.get(*resource.key).car.should == @car }
       end
@@ -481,6 +482,18 @@ describe DataMapper::Associations do
       it { @car.should respond_to("#{@name}=") }
 
       it_should_behave_like 'it creates a one mutator'
+
+      describe 'with a :key option' do
+        before :all do
+          @relationship = Car.belongs_to("#{@name}_with_key".to_sym, @model, :required => false, :key => true)
+        end
+
+        it 'should create a foreign key that is part of the key' do
+          @relationship.child_key.each do |property|
+            property.should be_key
+          end
+        end
+      end
     end
 
     # TODO: refactor these specs into above structure once they pass
@@ -847,7 +860,7 @@ describe DataMapper::Associations do
     describe 'when a relationship is inherited' do
       describe 'has an inverse' do
         before :all do
-          Car.property(:type, DataMapper::Types::Discriminator)
+          Car.property(:type, DataMapper::Property::Discriminator)
 
           class ::ElectricCar < Car; end
 
@@ -871,7 +884,7 @@ describe DataMapper::Associations do
 
       describe 'does not have an inverse' do
         before :all do
-          Car.property(:type, DataMapper::Types::Discriminator)
+          Car.property(:type, DataMapper::Property::Discriminator)
 
           class ::ElectricCar < Car; end
 
@@ -897,7 +910,7 @@ describe DataMapper::Associations do
     describe "when a subclass defines it's own relationship" do
       describe 'has an inverse' do
         before :all do
-          Car.property(:type, DataMapper::Types::Discriminator)
+          Car.property(:type, DataMapper::Property::Discriminator)
 
           class ::ElectricCar < Car; end
 
@@ -921,7 +934,7 @@ describe DataMapper::Associations do
 
       describe 'does not have an inverse' do
         before :all do
-          Car.property(:type, DataMapper::Types::Discriminator)
+          Car.property(:type, DataMapper::Property::Discriminator)
 
           class ::ElectricCar < Car; end
 
@@ -976,7 +989,7 @@ describe DataMapper::Associations do
       it 'should save the child as a parent' do
         lambda {
           @company.owner = @employee
-          @company.save.should be_true
+          @company.save.should be(true)
         }.should_not raise_error
       end
     end

data/spec/public/model_spec.rb

@@ -37,7 +37,7 @@ describe DataMapper::Model do
       with_alternate_adapter do
         describe 'between identical models' do
           before :all do
-            @return = @resources = @article_model.copy(@repository.name, @alternate_adapter.name)
+            @return = @resources = @article_model.copy(@repository.name, @adapter.name)
           end
 
           it 'should return a Collection' do
@@ -49,11 +49,11 @@ describe DataMapper::Model do
           end
 
           it 'should have each Resource set to the expected Repository' do
-            @resources.each { |resource| resource.repository.name.should == @alternate_adapter.name }
+            @resources.each { |resource| resource.repository.name.should == @adapter.name }
           end
 
           it 'should create the Resources in the expected Repository' do
-            @article_model.all(:repository => DataMapper.repository(@alternate_adapter.name)).should == @resources
+            @article_model.all(:repository => DataMapper.repository(@adapter.name)).should == @resources
           end
         end
 
@@ -67,21 +67,22 @@ describe DataMapper::Model do
             @article_model.all(:repository => @repository).should be_empty
 
             # add an extra property to the alternate model
-            DataMapper.repository(@alternate_adapter.name) do
+            DataMapper.repository(@adapter.name) do
               @article_model.property :status, String, :default => 'new'
             end
 
             if @article_model.respond_to?(:auto_migrate!)
-              @article_model.auto_migrate!(@alternate_adapter.name)
+              @article_model.auto_migrate!(@adapter.name)
             end
 
             # add new resources to the alternate repository
-            DataMapper.repository(@alternate_adapter.name) do
-              @heff1 = @article_model.create(:title => 'Alternate Repository', :author => @author)
+            DataMapper.repository(@adapter.name) do
+              # use an id value that is unique
+              @heff1 = @article_model.create(:id => 99, :title => 'Alternate Repository', :author => @author)
             end
 
             # copy from the alternate to the default repository
-            @return = @resources = @article_model.copy(@alternate_adapter.name, :default)
+            @return = @resources = @article_model.copy(@adapter.name, :default)
           end
 
           it 'should return a Collection' do
@@ -96,8 +97,13 @@ describe DataMapper::Model do
             @resources.each { |resource| resource.repository.name.should == :default }
           end
 
-          it 'should create the Resources in the expected Repository' do
-            @article_model.all.should == @resources
+          it 'should return the expected resources' do
+            # match on id because resources from different repositories are different
+            @resources.map { |resource| resource.id }.should == [ @heff1.id ]
+          end
+
+          it 'should add the resources to the alternate repository' do
+            @article.model.get(*@heff1.key).should_not be_nil
           end
         end
       end
@@ -155,5 +161,131 @@ describe DataMapper::Model do
     end
 
     it_should_behave_like 'Finder Interface'
+
+    it 'DataMapper::Model should respond to raise_on_save_failure' do
+      DataMapper::Model.should respond_to(:raise_on_save_failure)
+    end
+
+    describe '.raise_on_save_failure' do
+      subject { DataMapper::Model.raise_on_save_failure }
+
+      it { should be(false) }
+    end
+
+    it 'DataMapper::Model should respond to raise_on_save_failure=' do
+      DataMapper::Model.should respond_to(:raise_on_save_failure=)
+    end
+
+    describe '.raise_on_save_failure=' do
+      after do
+        # reset to the default value
+        reset_raise_on_save_failure(DataMapper::Model)
+      end
+
+      subject { DataMapper::Model.raise_on_save_failure = @value }
+
+      describe 'with a true value' do
+        before do
+          @value = true
+        end
+
+        it { should be(true) }
+
+        it 'should set raise_on_save_failure' do
+          method(:subject).should change {
+            DataMapper::Model.raise_on_save_failure
+          }.from(false).to(true)
+        end
+      end
+
+      describe 'with a false value' do
+        before do
+          @value = false
+        end
+
+        it { should be(false) }
+
+        it 'should set raise_on_save_failure' do
+          method(:subject).should_not change {
+            DataMapper::Model.raise_on_save_failure
+          }
+        end
+      end
+    end
+
+    it 'A model should respond to raise_on_save_failure' do
+      @article_model.should respond_to(:raise_on_save_failure)
+    end
+
+    describe '#raise_on_save_failure' do
+      after do
+        # reset to the default value
+        reset_raise_on_save_failure(DataMapper::Model)
+        reset_raise_on_save_failure(@article_model)
+      end
+
+      subject { @article_model.raise_on_save_failure }
+
+      describe 'when DataMapper::Model.raise_on_save_failure has not been set' do
+        it { should be(false) }
+      end
+
+      describe 'when DataMapper::Model.raise_on_save_failure has been set to true' do
+        before do
+          DataMapper::Model.raise_on_save_failure = true
+        end
+
+        it { should be(true) }
+      end
+
+      describe 'when model.raise_on_save_failure has been set to true' do
+        before do
+          @article_model.raise_on_save_failure = true
+        end
+
+        it { should be(true) }
+      end
+    end
+
+    it 'A model should respond to raise_on_save_failure=' do
+      @article_model.should respond_to(:raise_on_save_failure=)
+    end
+
+    describe '#raise_on_save_failure=' do
+      after do
+        # reset to the default value
+        reset_raise_on_save_failure(@article_model)
+      end
+
+      subject { @article_model.raise_on_save_failure = @value }
+
+      describe 'with a true value' do
+        before do
+          @value = true
+        end
+
+        it { should be(true) }
+
+        it 'should set raise_on_save_failure' do
+          method(:subject).should change {
+            @article_model.raise_on_save_failure
+          }.from(false).to(true)
+        end
+      end
+
+      describe 'with a false value' do
+        before do
+          @value = false
+        end
+
+        it { should be(false) }
+
+        it 'should set raise_on_save_failure' do
+          method(:subject).should_not change {
+            @article_model.raise_on_save_failure
+          }
+        end
+      end
+    end
   end
 end