decidim-proposals 0.20.1 → 0.23.1

data/app/commands/decidim/proposals/admin/publish_answers.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Proposals
+    module Admin
+      # A command with all the business logic to publish many answers at once.
+      class PublishAnswers < Rectify::Command
+        # Public: Initializes the command.
+        #
+        # component - The component that contains the answers.
+        # user - the Decidim::User that is publishing the answers.
+        # proposal_ids - the identifiers of the proposals with the answers to be published.
+        def initialize(component, user, proposal_ids)
+          @component = component
+          @user = user
+          @proposal_ids = proposal_ids
+        end
+
+        # Executes the command. Broadcasts these events:
+        #
+        # - :ok when everything is valid.
+        # - :invalid if there are not proposals to publish.
+        #
+        # Returns nothing.
+        def call
+          return broadcast(:invalid) unless proposals.any?
+
+          proposals.each do |proposal|
+            transaction do
+              mark_proposal_as_answered(proposal)
+              notify_proposal_answer(proposal)
+            end
+          end
+
+          broadcast(:ok)
+        end
+
+        private
+
+        attr_reader :component, :user, :proposal_ids
+
+        def proposals
+          @proposals ||= Decidim::Proposals::Proposal
+                         .published
+                         .answered
+                         .state_not_published
+                         .where(component: component)
+                         .where(id: proposal_ids)
+        end
+
+        def mark_proposal_as_answered(proposal)
+          Decidim.traceability.perform_action!(
+            "publish_answer",
+            proposal,
+            user
+          ) do
+            proposal.update!(state_published_at: Time.current)
+          end
+        end
+
+        def notify_proposal_answer(proposal)
+          NotifyProposalAnswer.call(proposal, nil)
+        end
+      end
+    end
+  end
+end

data/app/commands/decidim/proposals/admin/publish_participatory_text.rb

@@ -65,7 +65,12 @@ module Decidim
           body = proposal.body
 
           PaperTrail.request(enabled: false) do
-            proposal.update_columns(title: "", body: "") # rubocop:disable Rails/SkipsModelValidations
+            # rubocop:disable Rails/SkipsModelValidations
+            proposal.update_columns(
+              title: { I18n.locale => "" },
+              body: { I18n.locale => "" }
+            )
+            # rubocop:enable Rails/SkipsModelValidations
           end
 
           [title, body]

data/app/commands/decidim/proposals/admin/unassign_proposals_from_valuator.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Proposals
+    module Admin
+      # A command with all the business logic to unassign proposals from a given
+      # valuator.
+      class UnassignProposalsFromValuator < Rectify::Command
+        # Public: Initializes the command.
+        #
+        # form - A form object with the params.
+        def initialize(form)
+          @form = form
+        end
+
+        # Executes the command. Broadcasts these events:
+        #
+        # - :ok when everything is valid.
+        # - :invalid if the form wasn't valid and we couldn't proceed.
+        #
+        # Returns nothing.
+        def call
+          return broadcast(:invalid) unless form.valid?
+
+          unassign_proposals
+          broadcast(:ok)
+        end
+
+        private
+
+        attr_reader :form
+
+        def unassign_proposals
+          transaction do
+            form.proposals.flat_map do |proposal|
+              assignment = find_assignment(proposal)
+              unassign(assignment) if assignment
+            end
+          end
+        end
+
+        def find_assignment(proposal)
+          Decidim::Proposals::ValuationAssignment.find_by(
+            proposal: proposal,
+            valuator_role: form.valuator_role
+          )
+        end
+
+        def unassign(assignment)
+          Decidim.traceability.perform_action!(
+            :delete,
+            assignment,
+            form.current_user,
+            proposal_title: assignment.proposal.title
+          ) do
+            assignment.destroy!
+          end
+        end
+      end
+    end
+  end
+end

data/app/commands/decidim/proposals/admin/update_participatory_text.rb

@@ -5,6 +5,8 @@ module Decidim
     module Admin
       # A command with all the business logic when an admin updates participatory text proposals.
       class UpdateParticipatoryText < Rectify::Command
+        include Decidim::TranslatableAttributes
+
         # Public: Initializes the command.
         #
         # form - A PreviewParticipatoryTextForm form object with the params.
@@ -40,10 +42,16 @@ module Decidim
         def update_contents_and_resort_proposals(form)
           PaperTrail.request(enabled: false) do
             form.proposals.each do |prop_form|
+              add_failure(prop_form) if prop_form.invalid?
+
               proposal = Proposal.where(component: form.current_component).find(prop_form.id)
               proposal.set_list_position(prop_form.position) if proposal.position != prop_form.position
-              proposal.title = prop_form.title
-              proposal.body = prop_form.body if proposal.participatory_text_level == ParticipatoryTextSection::LEVELS[:article]
+              proposal.title = { I18n.locale => translated_attribute(prop_form.title) }
+              proposal.body = if proposal.participatory_text_level == ParticipatoryTextSection::LEVELS[:article]
+                                { I18n.locale => translated_attribute(prop_form.body) }
+                              else
+                                { I18n.locale => "" }
+                              end
 
               add_failure(proposal) unless proposal.save
             end

data/app/commands/decidim/proposals/admin/update_proposal.rb

@@ -5,7 +5,7 @@ module Decidim
     module Admin
       # A command with all the business logic when a user updates a proposal.
       class UpdateProposal < Rectify::Command
-        include AttachmentMethods
+        include ::Decidim::AttachmentMethods
         include GalleryMethods
         include HashtagsMethods
 
@@ -56,11 +56,13 @@ module Decidim
         attr_reader :form, :proposal, :attachment, :gallery
 
         def update_proposal
+          parsed_title = Decidim::ContentProcessor.parse_with_processor(:hashtag, form.title, current_organization: form.current_organization).rewrite
+          parsed_body = Decidim::ContentProcessor.parse_with_processor(:hashtag, form.body, current_organization: form.current_organization).rewrite
           Decidim.traceability.update!(
             proposal,
             form.current_user,
-            title: title_with_hashtags,
-            body: body_with_hashtags,
+            title: parsed_title,
+            body: parsed_body,
             category: form.category,
             scope: form.scope,
             address: form.address,

data/app/commands/decidim/proposals/admin/update_proposal_scope.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Proposals
+    module Admin
+      #  A command with all the business logic when an admin batch updates proposals scope.
+      class UpdateProposalScope < Rectify::Command
+        include TranslatableAttributes
+        # Public: Initializes the command.
+        #
+        # scope_id - the scope id to update
+        # proposal_ids - the proposals ids to update.
+        def initialize(scope_id, proposal_ids)
+          @scope = Decidim::Scope.find_by id: scope_id
+          @proposal_ids = proposal_ids
+          @response = { scope_name: "", successful: [], errored: [] }
+        end
+
+        # Executes the command. Broadcasts these events:
+        #
+        # - :update_proposals_scope - when everything is ok, returns @response.
+        # - :invalid_scope - if the scope is blank.
+        # - :invalid_proposal_ids - if the proposal_ids is blank.
+        #
+        # Returns @response hash:
+        #
+        # - :scope_name - the translated_name of the scope assigned
+        # - :successful - Array of names of the updated proposals
+        # - :errored - Array of names of the proposals not updated because they already had the scope assigned
+        def call
+          return broadcast(:invalid_scope) if @scope.blank?
+          return broadcast(:invalid_proposal_ids) if @proposal_ids.blank?
+
+          update_proposals_scope
+
+          broadcast(:update_proposals_scope, @response)
+        end
+
+        private
+
+        attr_reader :scope, :proposal_ids
+
+        def update_proposals_scope
+          @response[:scope_name] = translated_attribute(scope.name, scope.organization)
+          Proposal.where(id: proposal_ids).find_each do |proposal|
+            if scope == proposal.scope
+              @response[:errored] << proposal.title
+            else
+              transaction do
+                update_proposal_scope proposal
+                notify_author proposal if proposal.coauthorships.any?
+              end
+              @response[:successful] << proposal.title
+            end
+          end
+        end
+
+        def update_proposal_scope(proposal)
+          proposal.update!(
+            scope: scope
+          )
+        end
+
+        def notify_author(proposal)
+          Decidim::EventsManager.publish(
+            event: "decidim.events.proposals.proposal_update_scope",
+            event_class: Decidim::Proposals::Admin::UpdateProposalScopeEvent,
+            resource: proposal,
+            affected_users: proposal.notifiable_identities
+          )
+        end
+      end
+    end
+  end
+end

data/app/commands/decidim/proposals/create_collaborative_draft.rb

@@ -4,7 +4,7 @@ module Decidim
   module Proposals
     # A command with all the business logic when a user creates a new collaborative draft.
     class CreateCollaborativeDraft < Rectify::Command
-      include AttachmentMethods
+      include ::Decidim::AttachmentMethods
       include HashtagsMethods
 
       # Public: Initializes the command.

data/app/commands/decidim/proposals/create_proposal.rb

@@ -4,7 +4,7 @@ module Decidim
   module Proposals
     # A command with all the business logic when a user creates a new proposal.
     class CreateProposal < Rectify::Command
-      include AttachmentMethods
+      include ::Decidim::AttachmentMethods
       include HashtagsMethods
 
       # Public: Initializes the command.
@@ -57,8 +57,12 @@ module Decidim
             visibility: "public-only"
           ) do
             proposal = Proposal.new(
-              title: title_with_hashtags,
-              body: body_with_hashtags,
+              title: {
+                I18n.locale => title_with_hashtags
+              },
+              body: {
+                I18n.locale => body_with_hashtags
+              },
               component: form.component
             )
             proposal.add_coauthor(@current_user, user_group: user_group)

data/app/commands/decidim/proposals/gallery_methods.rb

@@ -6,62 +6,13 @@ module Decidim
     # and collaborative draft commands.
     # Allows to create several image attachments at once
     module GalleryMethods
-      private
-
-      def build_gallery
-        @gallery = []
-        @form.add_photos.each do |photo|
-          next unless image? photo
-
-          @gallery << Attachment.new(
-            title: photo.original_filename,
-            file: photo,
-            attached_to: @attached_to
-          )
-        end
-      end
+      include ::Decidim::GalleryMethods
 
-      def image?(image)
-        return unless image.respond_to? :content_type
-
-        image.content_type.start_with? "image"
-      end
-
-      def gallery_invalid?
-        gallery.each do |photo|
-          if photo.invalid? && photo.errors.has_key?(:file)
-            @form.errors.add(:add_photos, photo.errors[:file])
-            return true
-          end
-        end
-        false
-      end
-
-      def create_gallery
-        @gallery.map! do |photo|
-          photo.attached_to = @attached_to
-          photo.save!
-          @form.photos << photo.id.to_s
-        end
-      end
-
-      def photo_cleanup!
-        @attached_to.photos.each do |photo|
-          photo.destroy! if @form.photos.exclude? photo.id.to_s
-        end
-        # manually reset cached photos
-        @attached_to.reload
-        @attached_to.instance_variable_set(:@photos, nil)
-      end
+      private
 
-      # maybe a custom settings options would be nice
       def gallery_allowed?
         @form.current_component.settings.attachments_allowed?
       end
-
-      def process_gallery?
-        gallery_allowed? && @form.add_photos.any?
-      end
     end
   end
 end

data/app/commands/decidim/proposals/publish_collaborative_draft.rb

@@ -59,8 +59,8 @@ module Decidim
         parsed_title = Decidim::ContentProcessor.parse_with_processor(:hashtag, @collaborative_draft.title, current_organization: @collaborative_draft.organization).rewrite
         parsed_body = Decidim::ContentProcessor.parse_with_processor(:hashtag, @collaborative_draft.body, current_organization: @collaborative_draft.organization).rewrite
 
-        fields[:title] = parsed_title
-        fields[:body] = parsed_body
+        fields[:title] = { I18n.locale => parsed_title }
+        fields[:body] = { I18n.locale => parsed_body }
         fields[:component] = @collaborative_draft.component
         fields[:scope] = @collaborative_draft.scope
         fields[:address] = @collaborative_draft.address

data/app/commands/decidim/proposals/update_proposal.rb

@@ -4,7 +4,8 @@ module Decidim
   module Proposals
     # A command with all the business logic when a user updates a proposal.
     class UpdateProposal < Rectify::Command
-      include AttachmentMethods
+      include ::Decidim::MultipleAttachmentsMethods
+      include GalleryMethods
       include HashtagsMethods
 
       # Public: Initializes the command.
@@ -26,15 +27,18 @@ module Decidim
       #
       # Returns nothing.
       def call
-        return broadcast(:invalid) if form.invalid?
-        return broadcast(:invalid) unless proposal.editable_by?(current_user)
-        return broadcast(:invalid) if proposal_limit_reached?
+        return broadcast(:invalid) if invalid?
 
         if process_attachments?
           @proposal.attachments.destroy_all
 
-          build_attachment
-          return broadcast(:invalid) if attachment_invalid?
+          build_attachments
+          return broadcast(:invalid) if attachments_invalid?
+        end
+
+        if process_gallery?
+          build_gallery
+          return broadcast(:invalid) if gallery_invalid?
         end
 
         transaction do
@@ -43,7 +47,11 @@ module Decidim
           else
             update_proposal
           end
-          create_attachment if process_attachments?
+          create_gallery if process_gallery?
+          create_attachments if process_attachments?
+
+          photo_cleanup!
+          document_cleanup!
         end
 
         broadcast(:ok, proposal)
@@ -53,6 +61,10 @@ module Decidim
 
       attr_reader :form, :proposal, :current_user, :attachment
 
+      def invalid?
+        form.invalid? || !proposal.editable_by?(current_user) || proposal_limit_reached?
+      end
+
       # Prevent PaperTrail from creating an additional version
       # in the proposal multi-step creation process (step 3: complete)
       #
@@ -79,8 +91,12 @@ module Decidim
 
       def attributes
         {
-          title: title_with_hashtags,
-          body: body_with_hashtags,
+          title: {
+            I18n.locale => title_with_hashtags
+          },
+          body: {
+            I18n.locale => body_with_hashtags
+          },
           category: form.category,
           scope: form.scope,
           address: form.address,