decidim-participatory_processes 0.15.2 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a8db0c2f1ef72dc0bed95c83b5a6305de106ff0eee4cca89dca3a5f10d9cebe
-  data.tar.gz: 4d092227cc5c8f230d992ac25245eefbb5453128b0316d85e4c4490917980c3e
+  metadata.gz: dcc7482dcc0d05dd5b2736b409fe3c21cac93daa281b3742e3aac4b84af0e8b7
+  data.tar.gz: 25445b48ad99ad7b91ad4dd96107c74435499f80ac0cdb9dada9d0b6cbe54e1c
 SHA512:
-  metadata.gz: 843e3216dff264fe2cf9439d3573de4407e0a3259fb3c5aaa4c6422542380fe8fdfa39a24e3831f64b74bcea8c866d450e4a401e2e4d330b662840ae01aa8d02
-  data.tar.gz: 0451b42520e1216e11c9a111cff97b7d4b4c3757ff17f15c4a339b658b546831ebaedc364934b7fa8a49941060cb34d83c80ed026656248420c226ce146fb14c
+  metadata.gz: 1a2f754d7e05d3ad0c1daca4681d5e927cf4620661be5e6b57c7cfe695b37d402876a8ab39719fe270365030c107d6dff5057295db977b9e4b0ad940ccfe5a01
+  data.tar.gz: f4770fbfa28e7f8598bef52e10cb6685b8aaeddfc8037f1e28b929f16a039e62a907a4e573af87832254e748a85c2f536dbe0debde4a9803c440fa0086482edc

data/README.md

@@ -2,11 +2,18 @@
 
 Participatory processes are the standard Decidim's participatory space.
 
-A participatory process can define its own steps, and attach different components
-(such as meetings or proposals) with different configurations to each of them.
-
-A participatory process can have attachments, be associated to custom
-categories, and are fully manageable via an administration UI.
+A participatory process:
+
+* can define its own steps
+* can define helper text
+* can attach different components (such as meetings or proposals) with different configurations to each of them.
+* can have attachments
+* can be associated to custom categories
+* can be promoted
+* can be a private process, and only users with permissions can see the process
+* special content can be added to the process or superprocess home
+* can show statistics on process home.
+* are fully manageable via an administration UI.
 
 ## Usage
 
@@ -14,22 +21,21 @@ This module provides:
 
 * A CRUD engine to manage participatory processes.
 
-* Public views for participatory process via a high level section in the main
-  menu.
+* Public views for participatory process via a high level section in the main menu.
 
 ## Installation
 
-Add this line to your application's Gemfile:
+This is on the default Decidim installation so you shouldn't change anything to use this participatory space.
+
+## Screenshots
+
+![Public View](docs/screenshot01.png)
 
-```ruby
-gem 'decidim-participatory_processes'
-```
+![Admin View](docs/screenshot02.png)
 
-And then execute:
+## Documentation
 
-```bash
-bundle
-```
+Read more about this Space on [Admin Manual](https://docs.decidim.org/admin-manual/en/processess/).
 
 ## Contributing
 

data/app/commands/decidim/participatory_processes/admin/activate_participatory_process_step.rb

@@ -60,7 +60,7 @@ module Decidim
             event: "decidim.events.participatory_process.step_activated",
             event_class: Decidim::ParticipatoryProcessStepActivatedEvent,
             resource: step,
-            recipient_ids: step.participatory_process.followers.pluck(:id)
+            followers: step.participatory_process.followers
           )
         end
 

data/app/commands/decidim/participatory_processes/admin/update_participatory_process_step.rb

@@ -60,7 +60,7 @@ module Decidim
             event: "decidim.events.participatory_process.step_changed",
             event_class: Decidim::ParticipatoryProcessStepChangedEvent,
             resource: step,
-            recipient_ids: step.participatory_process.followers.pluck(:id)
+            followers: step.participatory_process.followers
           )
         end
       end

data/app/controllers/decidim/participatory_processes/admin/participatory_processes_controller.rb

@@ -68,15 +68,6 @@ module Decidim
           end
         end
 
-        def destroy
-          enforce_permission_to :destroy, :process, process: current_participatory_process
-          current_participatory_process.destroy!
-
-          flash[:notice] = I18n.t("participatory_processes.destroy.success", scope: "decidim.admin")
-
-          redirect_to participatory_processes_path
-        end
-
         def copy
           enforce_permission_to :create, Decidim::ParticipatoryProcess
         end

data/app/controllers/decidim/participatory_processes/participatory_processes_controller.rb

@@ -6,7 +6,7 @@ module Decidim
     # public layout.
     class ParticipatoryProcessesController < Decidim::ParticipatoryProcesses::ApplicationController
       include ParticipatorySpaceContext
-      participatory_space_layout only: :show
+      participatory_space_layout only: [:show, :statistics]
 
       helper Decidim::AttachmentsHelper
       helper Decidim::IconHelper
@@ -16,7 +16,7 @@ module Decidim
 
       helper ParticipatoryProcessHelper
 
-      helper_method :collection, :promoted_participatory_processes, :participatory_processes, :stats, :filter
+      helper_method :collection, :promoted_participatory_processes, :participatory_processes, :stats, :metrics, :filter
       helper_method :process_count_by_filter
 
       def index
@@ -27,7 +27,11 @@ module Decidim
       end
 
       def show
-        check_current_user_can_visit_space
+        enforce_permission_to :read, :process, process: current_participatory_space
+      end
+
+      def statistics
+        enforce_permission_to :read, :process, process: current_participatory_space
       end
 
       private
@@ -57,11 +61,11 @@ module Decidim
       end
 
       def participatory_processes
-        @participatory_processes ||= filtered_participatory_processes(filter)
+        @participatory_processes ||= filtered_participatory_processes(filter).query.where(decidim_participatory_process_group_id: nil)
       end
 
       def promoted_participatory_processes
-        @promoted_participatory_processes ||= filtered_participatory_processes | PromotedParticipatoryProcesses.new
+        @promoted_participatory_processes ||= filtered_participatory_processes("all") | PromotedParticipatoryProcesses.new
       end
 
       def filtered_participatory_process_groups(filter_name = filter)
@@ -76,6 +80,10 @@ module Decidim
         @stats ||= ParticipatoryProcessStatsPresenter.new(participatory_process: current_participatory_space)
       end
 
+      def metrics
+        @metrics ||= ParticipatoryProcessMetricChartsPresenter.new(participatory_process: current_participatory_space)
+      end
+
       def filter
         @filter = params[:filter] || default_filter
       end
@@ -91,7 +99,7 @@ module Decidim
         return @process_count_by_filter if @process_count_by_filter
 
         @process_count_by_filter = %w(active upcoming past).inject({}) do |collection_by_filter, filter_name|
-          processes = filtered_participatory_processes(filter_name)
+          processes = filtered_participatory_processes(filter_name).query.where(decidim_participatory_process_group_id: nil)
           groups = filtered_participatory_process_groups(filter_name)
           collection_by_filter.merge(filter_name.to_s => processes.count + groups.count)
         end

data/app/events/decidim/participatory_process_step_activated_event.rb

@@ -0,0 +1,23 @@
+# frozen-string_literal: true
+
+module Decidim
+  class ParticipatoryProcessStepActivatedEvent < Decidim::Events::SimpleEvent
+    include Rails.application.routes.mounted_helpers
+
+    def resource_path
+      @resource_path ||= decidim_participatory_processes.participatory_process_participatory_process_steps_path(participatory_process_slug: participatory_space.slug)
+    end
+
+    def resource_url
+      @resource_url ||= decidim_participatory_processes
+                        .participatory_process_participatory_process_steps_url(
+                          participatory_process_slug: participatory_space.slug,
+                          host: participatory_space.organization.host
+                        )
+    end
+
+    def participatory_space
+      resource.participatory_process
+    end
+  end
+end

data/app/events/decidim/participatory_process_step_changed_event.rb

@@ -0,0 +1,23 @@
+# frozen-string_literal: true
+
+module Decidim
+  class ParticipatoryProcessStepChangedEvent < Decidim::Events::SimpleEvent
+    include Rails.application.routes.mounted_helpers
+
+    def resource_path
+      @resource_path ||= decidim_participatory_processes.participatory_process_participatory_process_steps_path(participatory_process_slug: participatory_space.slug)
+    end
+
+    def resource_url
+      @resource_url ||= decidim_participatory_processes
+                        .participatory_process_participatory_process_steps_url(
+                          participatory_process_slug: participatory_space.slug,
+                          host: participatory_space.organization.host
+                        )
+    end
+
+    def participatory_space
+      resource.participatory_process
+    end
+  end
+end

data/app/models/decidim/participatory_process.rb

@@ -66,6 +66,22 @@ module Decidim
       where(promoted: true)
     end
 
+    def self.private_processes
+      where(private_space: true)
+    end
+
+    def self.active_spaces
+      active
+    end
+
+    def self.future_spaces
+      upcoming
+    end
+
+    def self.past_spaces
+      past
+    end
+
     def self.log_presenter_class_for(_log)
       Decidim::ParticipatoryProcesses::AdminLog::ParticipatoryProcessPresenter
     end
@@ -83,10 +99,6 @@ module Decidim
       slug
     end
 
-    def self.private_processes
-      where(private_space: true)
-    end
-
     def can_participate?(user)
       return true unless private_space?
       return true if private_space? && users.include?(user)

data/app/models/decidim/participatory_process_step.rb

@@ -21,7 +21,7 @@ module Decidim
     validates :position, numericality: { greater_than_or_equal_to: 0, only_integer: true }, allow_blank: true
     validates :position, uniqueness: { scope: :decidim_participatory_process_id }
 
-    before_create :set_position
+    before_validation :set_position, on: :create
 
     def self.log_presenter_class_for(_log)
       Decidim::ParticipatoryProcesses::AdminLog::StepPresenter
@@ -42,7 +42,7 @@ module Decidim
       return if position.present?
       return self.position = 0 if participatory_process.steps.select(&:persisted?).empty?
 
-      self.position = participatory_process.steps.pluck(:position).last + 1
+      self.position = participatory_process.steps.maximum(:position) + 1
     end
   end
 end

data/app/permissions/decidim/participatory_processes/permissions.rb

@@ -35,7 +35,6 @@ module Decidim
         user_can_read_process_list?
         user_can_read_current_process?
         user_can_create_process?
-        user_can_destroy_process?
 
         # org admins and space admins can do everything in the admin section
         org_admin_action?
@@ -102,11 +101,17 @@ module Decidim
                       [:process, :participatory_space].include?(permission_action.subject) &&
                       process
 
+        return disallow! if cannot_view_private_space
         return allow! if user&.admin?
         return allow! if process.published?
         toggle_allow(can_manage_process?)
       end
 
+      def cannot_view_private_space
+        return unless process.private_space
+        !user || !user.admin && !process.users.include?(user)
+      end
+
       def public_report_content_action?
         return unless permission_action.action == :create &&
                       permission_action.subject == :moderation
@@ -164,14 +169,6 @@ module Decidim
         toggle_allow(user.admin?)
       end
 
-      # Only organization admins can destroy a process
-      def user_can_destroy_process?
-        return unless permission_action.action == :destroy &&
-                      permission_action.subject == :process
-
-        toggle_allow(user.admin?)
-      end
-
       # Everyone can read the process list
       def user_can_read_process_list?
         return unless read_process_list_permission_action?
@@ -201,14 +198,12 @@ module Decidim
 
       # Process admins can eprform everything *inside* that process. They cannot
       # create a process or perform actions on process groups or other
-      # processes. They cannot destroy their process either.
+      # processes.
       def process_admin_action?
         return unless can_manage_process?(role: :admin)
         return if user.admin?
         return disallow! if permission_action.action == :create &&
                             permission_action.subject == :process
-        return disallow! if permission_action.action == :destroy &&
-                            permission_action.subject == :process
 
         is_allowed = [
           :attachment,

data/app/presenters/decidim/participatory_processes/participatory_process_metric_charts_presenter.rb

@@ -0,0 +1,83 @@
+# frozen_string_literal: true
+
+module Decidim
+  module ParticipatoryProcesses
+    # A presenter to render metrics in ParticipatoryProcesses statistics page
+    class ParticipatoryProcessMetricChartsPresenter < Decidim::MetricChartsPresenter
+      attribute :participatory_process, Decidim::ParticipatoryProcess
+
+      def params
+        capture do
+          concat(content_tag(:input, nil, type: :hidden, id: :"metrics-space_type", value: participatory_process.class))
+          concat(content_tag(:input, nil, type: :hidden, id: :"metrics-space_id", value: participatory_process.id))
+        end
+      end
+
+      def highlighted
+        render_highlighted(Decidim.metrics_registry.filtered(highlight: true, scope: "participatory_process"))
+      end
+
+      def not_highlighted
+        render_not_highlighted(Decidim.metrics_registry.filtered(highlight: false, scope: "participatory_process"))
+      end
+
+      def big_stats
+        safe_join(
+          Decidim.metrics_registry.filtered(scope: "participatory_process", block: "big", sort: true).map do |metric_manifest|
+            content_tag :div, class: "row" do
+              render_metrics_descriptive(metric_manifest.metric_name,
+                                         klass: "column",
+                                         graph_klass: "small",
+                                         title: I18n.t("decidim.metrics.#{metric_manifest.metric_name}.title"),
+                                         description: I18n.t("decidim.metrics.#{metric_manifest.metric_name}.description"),
+                                         download: true,
+                                         data: { ratio: "11:4", axis: true })
+            end
+          end
+        )
+      end
+
+      def medium_stats
+        safe_join(
+          Decidim.metrics_registry.filtered(scope: "participatory_process", block: "medium", sort: true).in_groups_of(2).map do |metrics_group|
+            content_tag :div, class: "row" do
+              safe_join(
+                metrics_group.map do |metric_manifest|
+                  next "" if metric_manifest.blank?
+                  render_metrics_descriptive(metric_manifest.metric_name,
+                                             klass: "column medium-6",
+                                             graph_klass: "small",
+                                             title: I18n.t("decidim.metrics.#{metric_manifest.metric_name}.title"),
+                                             description: I18n.t("decidim.metrics.#{metric_manifest.metric_name}.description"),
+                                             download: true,
+                                             data: { ratio: "16:9", axis: true })
+                end
+              )
+            end
+          end
+        )
+      end
+
+      def small_stats
+        safe_join(
+          Decidim.metrics_registry.filtered(scope: "participatory_process", block: "small", sort: true).in_groups_of(3).map do |metrics_group|
+            content_tag :div, class: "row" do
+              safe_join(
+                metrics_group.map do |metric_manifest|
+                  next "" if metric_manifest.blank?
+                  render_metrics_data(metric_manifest.metric_name,
+                                      klass: "column medium-4",
+                                      ratio: "16:9",
+                                      margin: "margin-top: 30px",
+                                      graph_klass: "small",
+                                      download: true,
+                                      data: { ratio: "16:9" })
+                end
+              )
+            end
+          end
+        )
+      end
+    end
+  end
+end

data/app/queries/decidim/participatory_processes/metrics/participatory_process_followers_metric_measure.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module Decidim
+  module ParticipatoryProcesses
+    module Metrics
+      # Searches for unique Users following the next objects
+      #  - ParticipatoryProcesses
+      class ParticipatoryProcessFollowersMetricMeasure < Decidim::MetricMeasure
+        def valid?
+          super && @resource.is_a?(Decidim::Participable)
+        end
+
+        def calculate
+          participatory_process = @resource
+
+          process_followers = Decidim::Follow.where(followable: participatory_process).joins(:user)
+                                             .where("decidim_follows.created_at <= ?", end_time)
+          cumulative_users = process_followers.pluck(:decidim_user_id)
+
+          process_followers = process_followers.where("decidim_follows.created_at >= ?", start_time)
+          quantity_users = process_followers.pluck(:decidim_user_id)
+
+          {
+            cumulative_users: cumulative_users.uniq,
+            quantity_users: quantity_users.uniq
+          }
+        end
+      end
+    end
+  end
+end

data/app/queries/decidim/participatory_processes/visible_participatory_processes.rb

@@ -12,6 +12,7 @@ module Decidim
         processes = Decidim::ParticipatoryProcess.all
 
         if @current_user
+          return processes if @current_user.admin
           processes.visible_for(@current_user.id)
         else
           processes.public_spaces