decidim-meetings 0.28.2 → 0.29.0.rc2

data/app/controllers/decidim/meetings/polls/answers_controller.rb

@@ -9,11 +9,19 @@ module Decidim
 
         helper_method :question
 
+        def admin
+          enforce_permission_to(:update, :poll, meeting:)
+        end
+
+        def index
+          enforce_permission_to(:reply_poll, :meeting, meeting:)
+        end
+
         def create
           enforce_permission_to(:create, :answer, question:)
-          @form = form(AnswerForm).from_params(params, question:, current_user:)
+          @form = form(AnswerForm).from_params(params.merge(question:, current_user:))
 
-          CreateAnswer.call(@form, current_user, questionnaire) do
+          CreateAnswer.call(@form, questionnaire) do
             # Both :ok and :invalid render the same template, because
             # validation errors are displayed in the template
             respond_to do |format|

data/app/controllers/decidim/meetings/registrations_controller.rb

@@ -11,7 +11,7 @@ module Decidim
 
         @form = form(Decidim::Forms::QuestionnaireForm).from_params(params, session_token:)
 
-        JoinMeeting.call(meeting, current_user, @form) do
+        JoinMeeting.call(meeting, @form) do
           on(:ok) do
             flash[:notice] = I18n.t("registrations.create.success", scope: "decidim.meetings")
             redirect_to after_answer_path
@@ -32,9 +32,9 @@ module Decidim
       def create
         enforce_permission_to(:register, :meeting, meeting:)
 
-        @form = JoinMeetingForm.from_params(params)
+        @form = JoinMeetingForm.from_params(params).with_context(current_user:)
 
-        JoinMeeting.call(meeting, current_user, @form) do
+        JoinMeeting.call(meeting, @form) do
           on(:ok) do
             flash[:notice] = I18n.t("registrations.create.success", scope: "decidim.meetings")
             redirect_after_path

data/app/forms/decidim/meetings/admin/meeting_registrations_form.rb

@@ -37,7 +37,7 @@ module Decidim
 
         # We need this method to ensure the form object will always have an ID,
         # and thus its `to_param` method will always return a significant value.
-        # If we remove this method, get an error onn the `update` action and try
+        # If we remove this method, get an error on the `update` action and try
         # to resubmit the form, the form will not hold an ID, so the `to_param`
         # method will return an empty string and Rails will treat this as a
         # `create` action, thus raising an error since this action is not defined

data/app/forms/decidim/meetings/admin/question_form.rb

@@ -18,10 +18,10 @@ module Decidim
         translatable_attribute :description, String
 
         validates :position, numericality: { greater_than_or_equal_to: 0 }
-        validates :question_type, inclusion: { in: Decidim::Meetings::Question::QUESTION_TYPES }
-        validates :max_choices, numericality: { only_integer: true, greater_than: 1, less_than_or_equal_to: ->(form) { form.number_of_options } }, allow_blank: true
+        validates :question_type, inclusion: { in: Decidim::Meetings::Question::QUESTION_TYPES }, if: :editable?
+        validates :max_choices, numericality: { only_integer: true, greater_than: 1, less_than_or_equal_to: ->(form) { form.number_of_options } }, allow_blank: true, if: :editable?
         validates :body, translatable_presence: true, if: :requires_body?
-        validates :answer_options, presence: true
+        validates :answer_options, presence: true, if: :editable?
 
         def to_param
           return id if id.present?
@@ -29,6 +29,10 @@ module Decidim
           "questionnaire-question-id"
         end
 
+        def editable?
+          @editable ||= id.blank? || Decidim::Meetings::Question.unpublished.unanswered.exists?(id:)
+        end
+
         def number_of_options
           answer_options.size
         end
@@ -36,7 +40,7 @@ module Decidim
         private
 
         def requires_body?
-          !deleted
+          editable? && !deleted
         end
       end
     end

data/app/forms/decidim/meetings/answer_form.rb

@@ -24,8 +24,8 @@ module Decidim
         @answer ||= Decidim::Meetings::Answer.find_by(decidim_user_id: current_user.id, decidim_question_id: question_id) if current_user
       end
 
-      def label(idx)
-        base = "#{idx + 1}. #{translated_attribute(question.body)}"
+      def label
+        base = translated_attribute(question.body)
         base += " (#{max_choices_label})" if question.max_choices
         base
       end
@@ -43,13 +43,13 @@ module Decidim
       end
 
       def selected_choices
-        choices.select(&:body)
+        choices.select(&:answer_option_id)
       end
 
       private
 
       def max_choices
-        errors.add(:choices, :too_many) if selected_choices.size > question.max_choices
+        errors.add(:choices, :too_many, count: question.max_choices) if selected_choices.size > question.max_choices
       end
 
       def mandatory_label

data/app/forms/decidim/meetings/meeting_form.rb

@@ -56,7 +56,7 @@ module Decidim
 
       alias component current_component
 
-      # Finds the Scope from the given decidim_scope_id, uses the compoenent scope if missing.
+      # Finds the Scope from the given decidim_scope_id, uses the component scope if missing.
       #
       # Returns a Decidim::Scope
       def scope

data/app/mailers/decidim/meetings/close_meeting_reminder_mailer.rb

@@ -27,7 +27,7 @@ module Decidim
             to: @user.email,
             subject: I18n.t(
               "decidim.meetings.close_meeting_reminder_mailer.close_meeting_reminder.subject",
-              organization_name: @organization.name
+              meeting_title: decidim_sanitize_translated(@meeting.title)
             )
           )
         end

data/app/models/decidim/meetings/meeting.rb

@@ -61,13 +61,14 @@ module Decidim
       scope :past, -> { where(arel_table[:end_time].lteq(Time.current)) }
       scope :upcoming, -> { where(arel_table[:end_time].gteq(Time.current)) }
       scope :withdrawn, -> { where(state: "withdrawn") }
-      scope :except_withdrawn, -> { where.not(state: "withdrawn").or(where(state: nil)) }
+      scope :withdrawn, -> { where.not(withdrawn_at: nil) }
+      scope :not_withdrawn, -> { where(withdrawn_at: nil) }
       scope :with_availability, lambda { |state_key|
         case state_key
         when "withdrawn"
           withdrawn
         else
-          except_withdrawn
+          not_withdrawn
         end
       }
       scope_search_multi :with_any_date, [:upcoming, :past]
@@ -271,7 +272,7 @@ module Decidim
       #
       # Returns Boolean.
       def withdrawn?
-        state == "withdrawn"
+        withdrawn_at.present?
       end
 
       # Checks whether the user can withdraw the given meeting.
@@ -282,6 +283,11 @@ module Decidim
         user && !withdrawn? && !past? && authored_by?(user)
       end
 
+      def withdraw!
+        self.withdrawn_at = Time.zone.now
+        save
+      end
+
       # Overwrites method from Paddable to add custom rules in order to know
       # when to display a pad or not.
       def pad_is_visible?
@@ -323,7 +329,7 @@ module Decidim
 
       # Public: Overrides the `reported_searchable_content_extras` Reportable concern method.
       def reported_searchable_content_extras
-        [normalized_author.name]
+        [author_name]
       end
 
       def has_contributions?

data/app/models/decidim/meetings/poll.rb

@@ -14,6 +14,14 @@ module Decidim
       delegate :organization, to: :meeting
 
       QUESTION_TYPES = %w(single_option multiple_option).freeze
+
+      def has_questions?
+        questionnaire&.questions&.exists?
+      end
+
+      def has_open_questions?
+        has_questions? && questionnaire.questions.not_closed.exists?
+      end
     end
   end
 end

data/app/models/decidim/meetings/question.rb

@@ -28,6 +28,7 @@ module Decidim
       validates :question_type, inclusion: { in: QUESTION_TYPES }
 
       scope :visible, -> { where(status: [:published, :closed]) }
+      scope :unanswered, -> { where.missing(:answers) }
 
       def multiple_choice?
         %w(single_option multiple_option).include?(question_type)

data/app/models/decidim/meetings/questionnaire.rb

@@ -11,12 +11,6 @@ module Decidim
       has_many :questions, -> { order(:position) }, class_name: "Question", foreign_key: "decidim_questionnaire_id", dependent: :destroy
       has_many :answers, class_name: "Answer", foreign_key: "decidim_questionnaire_id", dependent: :destroy
 
-      # Public: returns whether the questionnaire questions can be modified or not.
-      def questions_editable?
-        has_component = questionnaire_for.meeting.respond_to? :component
-        (has_component && !questionnaire_for.meeting.component.published?) || answers.empty?
-      end
-
       def all_questions_unpublished?
         questions.all?(&:unpublished?)
       end

data/app/packs/src/decidim/meetings/admin/meetings_form.js

@@ -117,9 +117,9 @@ $(() => {
     toggleDependsOnSelect($meetingRegistrationType, $meetingRegistrationUrl, "on_different_platform");
 
     const $meetingTypeOfMeeting = $form.find("#meeting_type_of_meeting");
-    const $meetingOnlineFields = $form.find(".field[data-meeting-type='online']");
-    const $meetingInPersonFields = $form.find(".field[data-meeting-type='in_person']");
-    const $meetingOnlineAccessLevelFields = $form.find(".field[data-meeting-type='online-access-level']");
+    const $meetingOnlineFields = $form.find("[data-meeting-type='online']");
+    const $meetingInPersonFields = $form.find("[data-meeting-type='in_person']");
+    const $meetingOnlineAccessLevelFields = $form.find("[data-meeting-type='online-access-level']");
     const $meetingIframeEmbedType = $form.find("#meeting_iframe_embed_type");
 
     const toggleTypeDependsOnSelect = ($target, $showDiv, type) => {

data/app/packs/src/decidim/meetings/meetings_form.js

@@ -11,9 +11,9 @@ $(() => {
   const $form = $(".meetings_form");
   if ($form.length > 0) {
     const $meetingTypeOfMeeting = $form.find("#meeting_type_of_meeting");
-    const $meetingOnlineFields = $form.find(".field[data-meeting-type='online']");
-    const $meetingInPersonFields = $form.find(".field[data-meeting-type='in_person']");
-    const $meetingOnlineAccessLevelFields = $form.find(".field[data-meeting-type='online-access-level']");
+    const $meetingOnlineFields = $form.find("[data-meeting-type='online']");
+    const $meetingInPersonFields = $form.find("[data-meeting-type='in_person']");
+    const $meetingOnlineAccessLevelFields = $form.find("[data-meeting-type='online-access-level']");
 
     const toggleDependsOnSelect = ($target, $showDiv, type) => {
       const value = $target.val();

data/app/packs/src/decidim/meetings/meetings_polls.js

@@ -9,6 +9,8 @@ $(() => {
   if ($container.length) {
     const poll = new MeetingsPollComponent($container, $container.data("decidim-meetings-poll"), $counter);
 
+    poll.mountComponent();
+
     $(".meeting-polls__action-list").on("click", (event) => {
       event.preventDefault();
 
@@ -29,6 +31,9 @@ $(() => {
 
   if ($adminContainer.length) {
     const adminPoll = new MeetingsPollComponent($adminContainer, $adminContainer.data("decidim-admin-meetings-poll"));
+
+    adminPoll.mountComponent();
+
     $(".meeting-polls__action-administrate").on("click", (event) => {
       event.preventDefault();
 

data/app/packs/src/decidim/meetings/poll.component.js

@@ -4,7 +4,7 @@ import createOptionAttachedInputs from "src/decidim/forms/option_attached_inputs
 import createMaxChoicesAlertComponent from "src/decidim/forms/max_choices_alert.component"
 
 /**
- * A plain Javascript component that handles questions from polls in meetings:
+ * A plain JavaScript component that handles questions from polls in meetings:
  *   - fetches them via Ajax
  *   - enables a polling to automatically update them
  *
@@ -24,9 +24,11 @@ export default class PollComponent {
     this.$element = $element;
     this.$counter = $counter;
     this.questionsUrl = config.questionsUrl;
-    this.pollingInterval = config.pollingInterval || 5000;
+    this.pollingInterval = config.pollingInterval || 10000;
     this.mounted = false;
     this.questions = {};
+    this.questionsStatuses = {};
+    this.answersStatuses = {};
   }
 
   /**
@@ -66,7 +68,9 @@ export default class PollComponent {
    * @returns {Void} - Returns nothing
    */
   _fetchQuestions() {
-    // Store current questions state (open / closed) before overwritting them with the Ajax call
+    $("#content").addClass("spinner-container")
+
+    // Store current questions state (open / closed) before overwriting them with the Ajax call
     // response.
     this._storeQuestionState(this.$element);
 
@@ -79,6 +83,8 @@ export default class PollComponent {
       this._setQuestionsState(this.$element);
       this._pollQuestions();
       this._addValidations();
+
+      $("#content").removeClass("spinner-container")
     });
   }
 
@@ -92,6 +98,12 @@ export default class PollComponent {
     $("[data-question]", $parent).each((_i, el) => {
       const $el = $(el);
       const questionId = $el.data("question");
+      const elForm = $el.find("form");
+
+      this.questionsStatuses[questionId] = $el.data("status");
+      if (elForm.length > 0) {
+        this.answersStatuses[questionId] = Object.fromEntries(new FormData(elForm[0]));
+      }
       if ($el[0].open === true) {
         this.questions[questionId] = OPEN;
       } else {
@@ -124,12 +136,28 @@ export default class PollComponent {
     const questionId = $el.data("question");
     // Current question state
     const state = this.questions[questionId];
+    const questionStatus = this.questionsStatuses[questionId];
+    const answersStatuses = this.answersStatuses[questionId];
+
     // New questions have a special class
     if (!state) {
       $el.addClass("is-new");
     } else if (state === OPEN) {
       $el.prop(OPEN, true);
     }
+
+    if ($el.data("status") === CLOSED && $el.data("status") !== questionStatus) {
+      $el.data("status", `${CLOSED}-new`);
+      document.getElementById(`closed-announcement-${questionId}`).hidden = false;
+    }
+
+    if (answersStatuses) {
+      for (const [key, value] of Object.entries(answersStatuses)) {
+        if (key.includes("[choices]")) {
+          $el.find(`[name='${key}'][value='${value}']`).prop("checked", true);
+        }
+      }
+    }
   }
 
   /**
@@ -177,7 +205,7 @@ export default class PollComponent {
       });
     });
 
-    $.unique($(".js-check-box-collection").parents(".answer")).each((idx, el) => {
+    $.unique($(".js-check-box-collection").parents("[data-max-choices]")).each((idx, el) => {
       const maxChoices = $(el).data("max-choices");
       if (maxChoices) {
         createMaxChoicesAlertComponent({

data/app/packs/stylesheets/decidim/meetings/_item.scss

@@ -125,13 +125,17 @@
         }
 
         &::-webkit-progress-bar {
-          @apply bg-white;
+          @apply bg-gray lg:bg-white;
         }
 
         &::-moz-progress-bar {
           @apply bg-success;
         }
       }
+
+      &-label {
+        @apply text-sm font-bold lg:hidden;
+      }
     }
 
     &-block {
@@ -175,3 +179,107 @@
     }
   }
 }
+
+// layout reset stuff
+.meeting-poll__layout {
+  header,
+  main h1,
+  footer {
+    @apply hidden md:block;
+  }
+
+  .layout-1col {
+    padding: 0;
+  }
+}
+
+.meeting-polls {
+  @apply m-0 md:mt-10 md:mb-24;
+
+  counter-reset: question;
+
+  &__question {
+    @apply bg-white;
+
+    summary {
+      @apply p-4 font-normal text-black text-md transition bg-background cursor-pointer marker:text-secondary;
+
+      transition: background-color 0.2s ease-in-out;
+
+      & > span:first-child::after {
+        counter-increment: question;
+        content: "#" counter(question);
+      }
+
+      & > span:last-child:not(:only-child) {
+        @apply text-sm font-semibold float-right;
+      }
+
+      & + * {
+        @apply mt-4 mb-8 md:mb-16 pr-4 pl-[calc(1rem+14px)] md:px-0 space-y-6;
+      }
+    }
+
+    &[open] summary {
+      @apply bg-secondary md:bg-background marker:text-white md:marker:text-secondary text-white md:text-black;
+    }
+
+    &.is-new {
+      animation: animateHighlight 5s ease-in-out forwards;
+    }
+
+    & + & {
+      @apply mt-4;
+    }
+
+    @keyframes animateHighlight {
+      0%,
+      80% {
+        background-color: rgba(var(--warning-rgb), 0.1);
+      }
+    }
+  }
+
+  &__answer {
+    label {
+      @apply block p-4 ring-4 ring-background rounded transition;
+
+      &:not(:has([disabled])) {
+        @apply hover:ring-tertiary hover:cursor-pointer;
+      }
+    }
+
+    label + label,
+    & + & {
+      @apply mt-4;
+    }
+
+    &--value {
+      @apply flex gap-2 justify-between text-gray-2 text-lg;
+
+      > *:last-child {
+        @apply w-1/6 flex-none text-gray text-right;
+      }
+    }
+
+    &--bar {
+      @apply w-full h-2.5 overflow-hidden rounded bg-background;
+
+      > * {
+        @apply bg-success h-full rounded;
+      }
+    }
+  }
+
+  &__admin-action {
+    @apply py-4 grid grid-cols-2 gap-x-4 gap-y-8 border-t border-t-gray [&>*:nth-child(2)]:ml-auto [&>*:nth-child(3)]:col-span-2;
+  }
+
+  &__topbar {
+    @apply my-4 md:my-0 px-4 md:px-0 py-2 md:py-10 flex justify-between gap-4 bg-background md:bg-transparent;
+
+    &.is-admin {
+      @apply mt-0 bg-tertiary md:bg-transparent text-black;
+    }
+  }
+}

data/app/packs/stylesheets/decidim/meetings/_live_event.scss

@@ -18,8 +18,6 @@
   &__aside {
     @apply flex-none bg-background-2;
 
-    counter-reset: question;
-
     &.is-open {
       @apply w-1/5 [&+div]:w-4/5;
 
@@ -33,96 +31,4 @@
       }
     }
   }
-
-  &__question {
-    @apply bg-white;
-
-    summary {
-      @apply p-4 cursor-pointer font-bold text-secondary text-md transition border-b border-b-background hover:bg-background;
-
-      transition: background-color 0.2s ease-in-out;
-
-      &::after {
-        counter-increment: question;
-        content: "#" counter(question);
-      }
-
-      & ~ * {
-        @apply p-4;
-
-        // dynamic content
-        > :first-child {
-          @apply font-bold;
-        }
-
-        label {
-          @apply flex items-baseline cursor-pointer;
-        }
-
-        label + label {
-          @apply mt-4;
-        }
-        // end dynamic content
-      }
-    }
-
-    &[open] .meeting-polls__answer--bar > * {
-      opacity: 1;
-      transform: translateX(0);
-    }
-
-    &.is-new {
-      animation: animateHighlight 5s ease-in-out forwards;
-    }
-
-    @keyframes animateHighlight {
-      0%,
-      80% {
-        background-color: rgba(var(--warning-rgb), 0.1);
-      }
-    }
-  }
-
-  &__question--admin {
-    summary ~ * {
-      @apply border-t border-t-background p-4 bg-background-2;
-
-      a {
-        @apply my-4 block text-sm underline;
-      }
-
-      > :first-child {
-        @apply font-normal;
-      }
-    }
-  }
-
-  &__answer {
-    @apply flex items-center gap-2;
-
-    &--value {
-      @apply w-1/5 font-bold;
-    }
-
-    &--bar {
-      @apply w-4/5 h-2.5 overflow-hidden;
-
-      > * {
-        @apply bg-primary h-full opacity-0;
-      }
-    }
-  }
-
-  // vertical flow
-  label + &__answer + label {
-    @apply mt-6;
-  }
-
-  &__admin-label {
-    @apply p-4 bg-secondary text-white font-bold text-sm;
-  }
-
-  &__admin-action {
-    @apply py-2 flex items-center border-t-background [&>*]:flex-none first:[&>*]:w-2/5 last:[&>*]:w-3/5;
-  }
 }

data/app/permissions/decidim/meetings/permissions.rb

@@ -39,6 +39,13 @@ module Decidim
             toggle_allow(can_close_meeting?)
           when :register
             toggle_allow(can_register_invitation_meeting?)
+          when :reply_poll
+            toggle_allow(can_reply_poll?)
+          end
+        when :poll
+          case permission_action.action
+          when :update
+            toggle_allow(can_update_poll?)
           end
         else
           return permission_action
@@ -112,6 +119,19 @@ module Decidim
           authorized?(:register, resource: meeting)
       end
 
+      def can_reply_poll?
+        meeting.present? &&
+          meeting.poll.present? &&
+          authorized?(:reply_poll, resource: meeting)
+      end
+
+      def can_update_poll?
+        user.present? &&
+          user.admin? &&
+          meeting.present? &&
+          meeting.poll.present?
+      end
+
       def can_answer_question?
         question.present? && user.present? && !question.answered_by?(user)
       end

data/app/services/decidim/meetings/calendar/component_calendar.rb

@@ -31,7 +31,7 @@ module Decidim
         #
         # Returns a collection of Meetings filtered based on provided params.
         def filtered_meetings
-          meetings.not_hidden.published.except_withdrawn.ransack(@filters).result
+          meetings.not_hidden.published.not_withdrawn.ransack(@filters).result
         end
       end
     end

data/app/services/decidim/meetings/calendar/meeting_to_event.rb

@@ -22,7 +22,7 @@ module Decidim
       class MeetingToEvent
         include ActionView::Helpers::SanitizeHelper
 
-        # Initializes the converteer for the given meeting.
+        # Initializes the converter for the given meeting.
         #
         # meeting - the Meeting to convert
         def initialize(meeting)

data/app/services/decidim/meetings/close_meeting_reminder_generator.rb

@@ -27,7 +27,7 @@ module Decidim
         Decidim::Meetings::Meeting
           .published
           .not_hidden
-          .except_withdrawn
+          .not_withdrawn
           .where(
             "decidim_component_id = ? AND end_time >= ? AND end_time <= ? AND closed_at IS NULL",
             component_id,

data/app/services/decidim/meetings/meeting_iframe_embedder.rb

@@ -5,7 +5,7 @@ require "cgi"
 module Decidim
   module Meetings
     # This class handles the streaming url to be included in the iframe present
-    # in the live event. For some services it is required to transforma a bit
+    # in the live event. For some services it is required to transform a bit
     # the structure of the URL.
     class MeetingIframeEmbedder
       # Public: Initializes the service.
@@ -55,7 +55,7 @@ module Decidim
         @embeddable_services ||= Meetings.embeddable_services
       end
 
-      # Youtube transformation consists on:
+      # YouTube transformation consists on:
       # 1. extract the video id from the parameter v
       # 2. Create a new URL using the domain youtube-nocookie.com, converting it to an embed
       #    and appending the video id