decidim-initiatives 0.9.1 → 0.11.0.pre1

data/app/assets/stylesheet/decidim/initiatives/social_share.css.scss

@@ -1,15 +1,16 @@
-/*= require social-share-button */
+//= require social-share-button
 $size: 45px;
 
-.share-link:hover {
+.share-link:hover{
   text-decoration: underline;
   cursor: pointer;
 }
 
-.social-share-button {
+.social-share-button{
   display: inline-block;
   vertical-align: top;
-  .ssb-icon {
+
+  .ssb-icon{
     margin-right: 5px;
     background-size: $size $size;
     height: $size;

data/app/assets/stylesheet/decidim/initiatives/statistics.css.scss

@@ -1,15 +1,15 @@
-.initiative-statistics {
+.initiative-statistics{
   margin-top: 25px;
 
-  .definition-data__item {
+  .definition-data__item{
     flex-basis: 50%;
   }
 
-  .definition-data__item:nth-child(odd) {
+  .definition-data__item:nth-child(odd){
     border-right: 1px solid #e8e8e8;
   }
 
-  .definition-data__item:nth-last-child(2) {
+  .definition-data__item:nth-last-child(2){
     border-bottom: none;
   }
 }

data/app/commands/decidim/initiatives/admin/create_initiative_type.rb

@@ -25,10 +25,7 @@ module Decidim
           if initiative_type.persisted?
             broadcast(:ok, initiative_type)
           else
-            if initiative_type.errors.include? :banner_image
-              form.errors.add(:banner_image, initiative_type.errors[:banner_image])
-            end
-
+            form.errors.add(:banner_image, initiative_type.errors[:banner_image]) if initiative_type.errors.include? :banner_image
             broadcast(:invalid)
           end
         end

data/app/commands/decidim/initiatives/admin/publish_initiative.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    module Admin
+      # A command with all the business logic that publishes an
+      # existing initiative.
+      class PublishInitiative < Rectify::Command
+        # Public: Initializes the command.
+        #
+        # initiative - Decidim::Initiative
+        # current_user - the user performing the action
+        def initialize(initiative, current_user)
+          @initiative = initiative
+          @current_user = current_user
+        end
+
+        # Executes the command. Broadcasts these events:
+        #
+        # - :ok when everything is valid.
+        # - :invalid if the form wasn't valid and we couldn't proceed.
+        #
+        # Returns nothing.
+        def call
+          return broadcast(:invalid) if initiative.published?
+
+          @initiative = Decidim.traceability.perform_action!(
+            :publish,
+            initiative,
+            current_user
+          ) do
+            initiative.publish!
+            initiative
+          end
+          broadcast(:ok, initiative)
+        end
+
+        private
+
+        attr_reader :initiative, :current_user
+      end
+    end
+  end
+end

data/app/commands/decidim/initiatives/admin/send_initiative_to_technical_validation.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    module Admin
+      # A command with all the business logic that sends an
+      # existing initiative to technical validation.
+      class SendInitiativeToTechnicalValidation < Rectify::Command
+        # Public: Initializes the command.
+        #
+        # initiative - Decidim::Initiative
+        # current_user - the user performing the action
+        def initialize(initiative, current_user)
+          @initiative = initiative
+          @current_user = current_user
+        end
+
+        # Executes the command. Broadcasts these events:
+        #
+        # - :ok when everything is valid.
+        # - :invalid if the form wasn't valid and we couldn't proceed.
+        #
+        # Returns nothing.
+        def call
+          @initiative = Decidim.traceability.perform_action!(
+            :send_to_technical_validation,
+            initiative,
+            current_user
+          ) do
+            initiative.validating!
+            initiative
+          end
+          broadcast(:ok, initiative)
+        end
+
+        private
+
+        attr_reader :initiative, :current_user
+      end
+    end
+  end
+end

data/app/commands/decidim/initiatives/admin/unpublish_initiative.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    module Admin
+      # A command with all the business logic that unpublishes an
+      # existing initiative.
+      class UnpublishInitiative < Rectify::Command
+        # Public: Initializes the command.
+        #
+        # initiative - Decidim::Initiative
+        # current_user - the user performing the action
+        def initialize(initiative, current_user)
+          @initiative = initiative
+          @current_user = current_user
+        end
+
+        # Executes the command. Broadcasts these events:
+        #
+        # - :ok when everything is valid.
+        # - :invalid if the form wasn't valid and we couldn't proceed.
+        #
+        # Returns nothing.
+        def call
+          return broadcast(:invalid) unless initiative.published?
+
+          @initiative = Decidim.traceability.perform_action!(
+            :unpublish,
+            initiative,
+            current_user
+          ) do
+            initiative.unpublish!
+            initiative
+          end
+          broadcast(:ok, initiative)
+        end
+
+        private
+
+        attr_reader :initiative, :current_user
+      end
+    end
+  end
+end

data/app/commands/decidim/initiatives/admin/update_initiative.rb

@@ -24,13 +24,15 @@ module Decidim
         # Returns nothing.
         def call
           return broadcast(:invalid) if form.invalid?
-          initiative.update(attributes)
 
-          if initiative.valid?
-            broadcast(:ok, initiative)
-          else
-            broadcast(:invalid, initiative)
-          end
+          @initiative = Decidim.traceability.update!(
+            initiative,
+            current_user,
+            attributes
+          )
+          broadcast(:ok, initiative)
+        rescue ActiveRecord::RecordInvalid
+          broadcast(:invalid, initiative)
         end
 
         private
@@ -47,7 +49,7 @@ module Decidim
             answer_url: form.answer_url
           }
 
-          attrs[:answered_at] = DateTime.now unless form.answer.blank?
+          attrs[:answered_at] = DateTime.current if form.answer.present?
 
           if current_user.admin?
             attrs[:signature_start_time] = form.signature_start_time

data/app/commands/decidim/initiatives/admin/update_initiative_type.rb

@@ -42,10 +42,7 @@ module Decidim
             description: form.description
           }
 
-          unless form.banner_image.nil?
-            result[:banner_image] = form.banner_image
-          end
-
+          result[:banner_image] = form.banner_image unless form.banner_image.nil?
           result
         end
       end

data/app/commands/decidim/initiatives/create_initiative.rb

@@ -36,15 +36,16 @@ module Decidim
 
       attr_reader :form, :current_user
 
-      # Creates the initiative and all default features
+      # Creates the initiative and all default components
       def create_initiative
         initiative = build_initiative
         return initiative unless initiative.valid?
 
         initiative.transaction do
           initiative.save!
-          create_features_for(initiative)
+          create_components_for(initiative)
           send_notification(initiative)
+          add_author_as_follower(initiative)
         end
 
         initiative
@@ -59,7 +60,7 @@ module Decidim
           decidim_user_group_id: form.decidim_user_group_id,
           scoped_type: scoped_type,
           signature_type: form.signature_type,
-          state: 'created'
+          state: "created"
         )
       end
 
@@ -70,23 +71,21 @@ module Decidim
         )
       end
 
-      def create_features_for(initiative)
-        Decidim::Initiatives.default_features.each do |feature_name|
-          feature = Decidim::Feature.create!(
-            name: Decidim::Features::Namer.new(
-              initiative.organization.available_locales,
-              feature_name).i18n_name,
-            manifest_name: feature_name,
+      def create_components_for(initiative)
+        Decidim::Initiatives.default_components.each do |component_name|
+          component = Decidim::Component.create!(
+            name: Decidim::Components::Namer.new(initiative.organization.available_locales, component_name).i18n_name,
+            manifest_name: component_name,
             published_at: Time.current,
             participatory_space: initiative
           )
 
-          initialize_pages(feature) if feature_name == :pages
+          initialize_pages(component) if component_name == :pages
         end
       end
 
-      def initialize_pages(feature)
-        Decidim::Pages::CreatePage.call(feature) do
+      def initialize_pages(component)
+        Decidim::Pages::CreatePage.call(component) do
           on(:invalid) { raise "Can't create page" }
         end
       end
@@ -99,6 +98,17 @@ module Decidim
           recipient_ids: initiative.author.followers.pluck(:id)
         )
       end
+
+      def add_author_as_follower(initiative)
+        form = Decidim::FollowForm
+               .from_params(followable_gid: initiative.to_signed_global_id.to_s)
+               .with_context(
+                 current_organization: initiative.organization,
+                 current_user: current_user
+               )
+
+        Decidim::CreateFollow.new(form, current_user).call
+      end
     end
   end
 end

data/app/commands/decidim/initiatives/spawn_committee_request.rb

@@ -38,7 +38,7 @@ module Decidim
         request = InitiativesCommitteeMember.new(
           decidim_initiatives_id: initiative&.id,
           decidim_users_id: current_user&.id,
-          state: 'requested'
+          state: "requested"
         )
         return request unless request.valid?
 

data/app/constraints/decidim/initiatives/current_component.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    # This class infers the current component on an initiative context
+    # request parameters and injects it into the environment.
+    class CurrentComponent
+      # Public: Initializes the class.
+      #
+      # manifest - The manifest of the component to check against.
+      def initialize(manifest)
+        @manifest = manifest
+      end
+
+      # Public: Matches the request against a component and injects it into the
+      #         environment.
+      #
+      # request - The request that holds the current component relevant information.
+      #
+      # Returns a true if the request matches an initiative and a
+      # component belonging to that initiative, false otherwise
+      def matches?(request)
+        CurrentInitiative.new.matches?(request) &&
+          Decidim::CurrentComponent.new(@manifest).matches?(request)
+      end
+    end
+  end
+end

data/app/constraints/decidim/initiatives/current_initiative.rb

@@ -18,7 +18,7 @@ module Decidim
       def matches?(request)
         env = request.env
 
-        @organization = env['decidim.current_organization']
+        @organization = env["decidim.current_organization"]
         return false unless @organization
 
         current_initiative(env, request.params) ? true : false
@@ -27,7 +27,7 @@ module Decidim
       private
 
       def current_initiative(env, params)
-        env['decidim.current_participatory_space'] ||= Initiative.find_by(id: id_from_slug(params[:initiative_slug]))
+        env["decidim.current_participatory_space"] ||= Initiative.find_by(id: id_from_slug(params[:initiative_slug]))
       end
     end
   end

data/app/controllers/concerns/decidim/initiatives/action_authorization.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'active_support/concern'
+require "active_support/concern"
 
 module Decidim
   module Initiatives

data/app/controllers/concerns/decidim/initiatives/admin/initiative_admin.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'active_support/concern'
+require "active_support/concern"
 
 module Decidim
   module Initiatives
@@ -18,8 +18,6 @@ module Decidim
           include Decidim::Admin::ParticipatorySpaceAdminContext
           participatory_space_admin_layout
 
-          helper Decidim::Initiatives::PartialTranslationsHelper
-
           alias_method :current_participatory_space, :current_initiative
         end
 

data/app/controllers/concerns/decidim/initiatives/orderable.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'active_support/concern'
+require "active_support/concern"
 
 module Decidim
   module Initiatives
@@ -26,22 +26,22 @@ module Decidim
         # Available orders based on enabled settings
         def available_orders
           @available_orders ||= begin
-            available_orders = %w[random recent most_voted most_commented]
+            available_orders = %w(random recent most_voted most_commented)
             available_orders
           end
         end
 
         def default_order
-          'random'
+          "random"
         end
 
         def reorder(initiatives)
           case order
-          when 'most_voted'
+          when "most_voted"
             initiatives.order_by_supports
-          when 'most_commented'
+          when "most_commented"
             initiatives.order_by_most_commented
-          when 'recent'
+          when "recent"
             initiatives.order_by_most_recent
           else
             initiatives.order_randomly(random_seed)

data/app/controllers/concerns/decidim/initiatives/type_selector_options.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'active_support/concern'
+require "active_support/concern"
 
 module Decidim
   module Initiatives

data/app/controllers/decidim/initiatives/admin/application_controller.rb

@@ -5,7 +5,7 @@ module Decidim
     module Admin
       # The main admin application controller for initiatives
       class ApplicationController < Decidim::Admin::ApplicationController
-        layout 'decidim/admin/initiatives'
+        layout "decidim/admin/initiatives"
       end
     end
   end