decidim-forms 0.30.2 → 0.31.0.rc1

data/app/views/decidim/forms/admin/questionnaires/answers/index.html.erb

@@ -1,49 +0,0 @@
-<div class="card" id="answers">
-  <div class="item_show__header">
-    <h1 class="item_show__header-title">
-      <%= t ".title", total: @total %>
-      <%= link_to t("actions.back", scope: "decidim.forms.admin.questionnaires"), questionnaire_url, class: "button button__sm button__secondary new" %>
-    </h1>
-  </div>
-  <div class="table-scroll">
-    <table class="table-list">
-      <thead>
-        <tr>
-          <th>#</th>
-          <th><%= first_table_th(@participants.first) %></th>
-          <th><%= t("user_status", scope: "decidim.forms.user_answers_serializer") %></th>
-          <th><%= t("ip_hash", scope: "decidim.forms.user_answers_serializer") %></th>
-          <th><%= t("completion", scope: "decidim.forms.user_answers_serializer") %></th>
-          <th><%= t("created_at", scope: "decidim.forms.user_answers_serializer") %></th>
-          <th></th>
-        </tr>
-      </thead>
-      <tbody>
-        <% @participants.each_with_index do |participant, idx| %>
-          <tr>
-            <td><%= idx + 1 + page_offset %></td>
-            <td>
-              <% if allowed_to? :show, :questionnaire_answers %>
-                <%= link_to first_table_td(participant), questionnaire_participant_answers_url(participant.session_token) %>
-              <% else %>
-                <%= first_table_td(participant) %></td>
-              <% end %>
-            <td><%= participant.status %></td>
-            <td><%= participant.ip_hash %></td>
-            <td><%= display_percentage(participant.completion) %></td>
-            <td><%= l participant.answered_at, format: :short %></td>
-            <td class="table-list__actions">
-              <% if allowed_to? :show, :questionnaire_answers %>
-                <%= icon_link_to "eye-line", questionnaire_participant_answers_url(participant.session_token), t("actions.show", scope: "decidim.forms.admin.questionnaires.answers"), class: "action-icon--eye", target: "_blank", data: { "external-link": false } %>
-              <% end %>
-              <% if allowed_to? :export_response, :questionnaire_answers %>
-                <%= icon_link_to "download-line", questionnaire_export_response_url(participant.session_token), t("actions.export", scope: "decidim.forms.admin.questionnaires.answers"), class: "action-icon--data-transfer-download" %>
-              <% end %>
-            </td>
-          </tr>
-        <% end %>
-      </tbody>
-    </table>
-  </div>
-</div>
-<%= decidim_paginate @query %>

data/app/views/decidim/forms/admin/questionnaires/answers/show.html.erb

@@ -1,43 +0,0 @@
-<div class="card" id="answers">
-  <div class="item_show__header">
-    <h1 class="item_show__header-title">
-      <%= t ".title", number: current_idx %>
-
-      <%= link_to t("actions.next", scope: "decidim.forms.admin.questionnaires.answers").html_safe, next_url, rel: "next", class: "button button__sm button__secondary next" unless last? %>
-      <%= link_to t("actions.previous", scope: "decidim.forms.admin.questionnaires.answers").html_safe, prev_url, rel: "prev", class: "button button__sm button__secondary prev" unless first? %>
-      <%= link_to t("actions.export", scope: "decidim.forms.admin.questionnaires.answers"), questionnaire_export_response_url(@participant.session_token), class: "button button__sm button__secondary export" %>
-      <%= link_to t("actions.back", scope: "decidim.forms.admin.questionnaires.answers"), questionnaire_participants_url, class: "button button__sm button__secondary back" %>
-    </h1>
-  </div>
-  <div class="card-section">
-     <div class="table">
-      <table class="table-list">
-        <thead>
-          <tr>
-            <th><%= t("session_token", scope: "decidim.forms.user_answers_serializer") %></th>
-            <th><%= t("user_status", scope: "decidim.forms.user_answers_serializer") %></th>
-            <th><%= t("ip_hash", scope: "decidim.forms.user_answers_serializer") %></th>
-            <th><%= t("completion", scope: "decidim.forms.user_answers_serializer") %></th>
-            <th><%= t("created_at", scope: "decidim.forms.user_answers_serializer") %></th>
-            <th></th>
-          </tr>
-        </thead>
-        <tbody>
-          <tr>
-            <td><%= @participant.session_token %></td>
-            <td><%= @participant.status %></td>
-            <td><%= @participant.ip_hash %></td>
-            <td><%= display_percentage(@participant.completion) %></td>
-            <td><%= l @participant.answered_at, format: :short %></td>
-          </tr>
-        </tbody>
-      </table>
-    </div>
-    <dl class="p-4 [&_ul]:list-disc [&_ul]:pl-4">
-      <% @participant.answers.each do |answer| %>
-        <dt class="font-semibold"><%= answer.question %></dt>
-        <dd><%= answer.body %></dd>
-      <% end %>
-    </dl>
-  </div>
-</div>

data/app/views/decidim/forms/questionnaires/_answer.html.erb

@@ -1,61 +0,0 @@
-<% field_id = "questionnaire_responses_#{answer_idx}" %>
-
-<% if answer.question.separator? %>
-
-  <%= render partial: "decidim/forms/questionnaires/answers/#{answer.question.question_type}", locals: { answer:, answer_form:, answer_idx:, field_id:, disabled: } %>
-  <%= answer_form.hidden_field :question_id %>
-
-<% elsif answer.question.title_and_description? %>
-
-  <div class="answer-questionnaire__step-heading">
-    <h3 class="h3"><%= translated_attribute(answer.question.body) %></h3>
-    <% if translated_attribute(answer.question.description).present? %>
-      <div>
-        <%= decidim_sanitize_editor_admin translated_attribute(answer.question.description) %>
-      </div>
-    <% end %>
-  </div>
-
-  <%= render partial: "decidim/forms/questionnaires/answers/#{answer.question.question_type}", locals: { answer:, answer_form:, answer_idx:, field_id:, disabled: } %>
-  <%= answer_form.hidden_field :question_id %>
-
-<% else %>
-
-  <div class="answer-questionnaire__question">
-    <%
-    label_options = {
-      class: "answer-questionnaire__question-label questionnaire-question",
-      data: { "answer-idx": cleaned_answer_idx }
-    }
-    label_options[:for] = nil if %w(matrix_single matrix_multiple single_option multiple_option).include?(answer.question.question_type)
-    %>
-
-    <%= label_tag field_id, **label_options do %>
-      <%= translated_attribute(answer.question.body) %>
-      <% if answer.question.mandatory? %>
-        <%= answer_form.send(:required_indicator) %>
-      <% end %>
-      <% if answer.question.max_choices %>
-        <%= " (#{answer.send(:max_choices_label)})" %>
-      <% end %>
-    <% end %>
-
-    <% if translated_attribute(answer.question.description).present? %>
-      <div class="answer-questionnaire__question-description">
-        <%= decidim_sanitize_editor_admin translated_attribute(answer.question.description) %>
-      </div>
-    <% end %>
-
-    <% if answer.question.max_choices %>
-      <small class="form-error max-choices-alert"><%= t(".max_choices_alert") %></small>
-    <% end %>
-
-    <% %w(short_answer long_answer).exclude?(answer&.question&.question_type) && answer.errors.full_messages.each do |msg| %>
-      <small class="form-error is-visible"><%= msg %></small>
-    <% end %>
-
-    <%= render partial: "decidim/forms/questionnaires/answers/#{answer.question.question_type}", locals: { answer:, answer_form:, answer_idx:, field_id:, disabled:, maxlength: (answer.question.max_characters if answer.question.max_characters.positive?) } %>
-    <%= answer_form.hidden_field :question_id %>
-  </div>
-
-<% end %>

data/app/views/decidim/forms/questionnaires/answers/_files.html.erb

@@ -1 +0,0 @@
-<%= answer_form.upload :add_documents, attachments: answer.documents, label: false, multiple: true, id: field_id, disabled:, button_class: "button button__lg button__transparent-secondary w-full" %>

data/app/views/decidim/forms/questionnaires/answers/_long_answer.html.erb

@@ -1,3 +0,0 @@
-<div>
-  <%= answer_form.text_area :body, label: false, id: field_id, rows: 10, disabled:, maxlength:, class: "w-full", required: false %>
-</div>

data/app/views/decidim/forms/questionnaires/answers/_multiple_option.html.erb

@@ -1,25 +0,0 @@
-<div class="answer-questionnaire__single-option js-check-box-collection">
-  <% answer.question.answer_options.each_with_index do |answer_option, idx| %>
-    <% choice = answer.selected_choices.find { |choice| choice.answer_option_id == answer_option.id } %>
-
-    <div class="js-collection-input">
-      <%= label_tag do %>
-        <%= check_box_tag "questionnaire[responses][#{answer_idx}][choices][#{idx}][body]",
-                          translated_attribute(answer_option.body),
-                          choice.present?, disabled: %>
-
-        <%= translated_attribute(answer_option.body) %>
-
-        <%= hidden_field_tag "questionnaire[responses][#{answer_idx}][choices][#{idx}][answer_option_id]", answer_option.id %>
-      <% end %>
-
-      <% if answer_option.free_text %>
-        <%= text_field_tag "questionnaire[responses][#{answer_idx}][choices][#{idx}][custom_body]",
-                           choice.try(:custom_body),
-                           disabled: true,
-                           maxlength:,
-                           class: "w-full" %>
-      <% end %>
-    </div>
-  <% end %>
-</div>

data/app/views/decidim/forms/questionnaires/answers/_separator.html.erb

@@ -1 +0,0 @@
-<%= answer_form.hidden_field :body, value: "separator", id: field_id, disabled: %>

data/app/views/decidim/forms/questionnaires/answers/_short_answer.html.erb

@@ -1,3 +0,0 @@
-<div>
-  <%= answer_form.text_field :body, label: false, id: field_id, disabled:, maxlength:, class: "w-full", required: false %>
-</div>

data/app/views/decidim/forms/questionnaires/answers/_single_option.html.erb

@@ -1,32 +0,0 @@
-<div class="answer-questionnaire__single-option js-radio-button-collection">
-  <% choice = answer.choices.first %>
-
-  <% answer.question.answer_options.each_with_index do |answer_option, idx| %>
-    <% choice_id = "#{field_id}_choices_#{idx}" %>
-
-    <div class="js-collection-input">
-      <%= label_tag "#{choice_id}_body" do %>
-        <%= radio_button_tag "questionnaire[responses][#{answer_idx}][choices][][body]",
-                             translated_attribute(answer_option.body),
-                             answer_option.id == choice.try(:answer_option_id),
-                             id: "#{choice_id}_body", disabled: %>
-
-        <%= translated_attribute(answer_option.body) %>
-
-        <%= hidden_field_tag "questionnaire[responses][#{answer_idx}][choices][][answer_option_id]",
-                             answer_option.id,
-                             id: "#{choice_id}_answer_option",
-                             disabled: true %>
-      <% end %>
-
-      <% if answer_option.free_text %>
-        <%= text_field_tag "questionnaire[responses][#{answer_idx}][choices][][custom_body]",
-                           choice.try(:custom_body),
-                           id: "#{choice_id}_custom_body",
-                           disabled: true,
-                           maxlength:,
-                           class: "w-full" %>
-      <% end %>
-    </div>
-  <% end %>
-</div>

data/app/views/decidim/forms/questionnaires/answers/_sorting.html.erb

@@ -1,26 +0,0 @@
-<div class="answer-questionnaire__sorting-container js-sortable-check-box-collection">
-  <%
-    # This is a block that aims to identify the order to the answer questions, and if there is an user answer, use that
-    # to order the date that needs to be displayed. It is done like this to help with edit user answer form
-  %>
-  <% ordering = answer.question.answer_options.pluck(:id) %>
-  <% if answer.selected_choices.present? %>
-    <% ordering = answer.selected_choices.map(&:answer_option_id) %>
-  <% end %>
-
-  <% ids_for_order = ordering.map.with_index { |id, index| "#{id}=#{index + 1}" }.join(", ") %>
-
-  <% answer.question.reload.answer_options.reorder(Arel.sql("POSITION(id::text in '#{ids_for_order}')")).each_with_index do |answer_option, idx| %>
-    <% choice = answer.selected_choices.find { |choice| choice.answer_option_id == answer_option.id } %>
-
-    <div class="answer-questionnaire__sorting js-collection-input" role="button">
-      <%= translated_attribute(answer_option.body) %>
-
-      <%= icon "drag-move-2-line" %>
-
-      <%= hidden_field_tag "questionnaire[responses][#{answer_idx}][choices][#{idx}][position]", choice.try(:position) %>
-      <%= hidden_field_tag "questionnaire[responses][#{answer_idx}][choices][#{idx}][body]", translated_attribute(answer_option.body) %>
-      <%= hidden_field_tag "questionnaire[responses][#{answer_idx}][choices][#{idx}][answer_option_id]", answer_option.id %>
-    </div>
-  <% end %>
-</div>

data/app/views/decidim/forms/questionnaires/answers/_title_and_description.html.erb

@@ -1 +0,0 @@
-<%= answer_form.hidden_field :body, value: "title-and-description", id: field_id, disabled: %>

data/lib/decidim/api/answer_option_type.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Forms
-    class AnswerOptionType < Decidim::Api::Types::BaseObject
-      description "An answer option for a multi-choice question in a questionnaire"
-
-      field :body, Decidim::Core::TranslatedFieldType, "The text answer response option.", null: false
-      field :free_text, GraphQL::Types::Boolean, "Whether if this answer accepts any free text from the user.", null: false
-      field :id, GraphQL::Types::ID, "ID of this answer option", null: false
-    end
-  end
-end

data/lib/decidim/forms/test/shared_examples/manage_questionnaire_answers.rb

@@ -1,149 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-shared_examples_for "manage questionnaire answers" do
-  let(:first_type) { "short_answer" }
-  let!(:first) do
-    create(:questionnaire_question, questionnaire:, position: 1, question_type: first_type)
-  end
-  let!(:second) do
-    create(:questionnaire_question, questionnaire:, position: 2, question_type: "single_option")
-  end
-  let!(:third) do
-    create(:questionnaire_question, questionnaire:, position: 3, question_type: "files")
-  end
-  let(:questions) do
-    [first, second, third]
-  end
-
-  context "when there are no answers" do
-    it "do not answer admin link" do
-      click_on "Manage questions"
-      expect(page).to have_content("No answers yet")
-    end
-  end
-
-  context "when there are answers" do
-    let!(:answer1) { create(:answer, questionnaire:, question: first) }
-    let!(:answer2) { create(:answer, body: "second answer", questionnaire:, question: first) }
-    let!(:answer3) { create(:answer, questionnaire:, question: second) }
-    let!(:file_answer) { create(:answer, :with_attachments, questionnaire:, question: third, body: nil, user: answer3.user, session_token: answer3.session_token) }
-
-    it "shows the answer admin link" do
-      click_on "Manage questions"
-      expect(page).to have_content("Show responses")
-    end
-
-    context "and managing answers page" do
-      before do
-        click_on "Manage questions"
-        click_on "Show responses"
-      end
-
-      it "shows the answers page" do
-        expect(page).to have_content(answer1.body)
-        expect(page).to have_content(answer1.question.body["en"])
-        expect(page).to have_content(answer2.body)
-        expect(page).to have_content(answer2.question.body["en"])
-      end
-
-      it "shows the percentage" do
-        expect(page).to have_content("33%")
-      end
-
-      it "has a detail link" do
-        expect(page).to have_link("Show answers")
-      end
-
-      it "has an export link" do
-        expect(page).to have_link(answer1.body)
-        expect(page).to have_link(answer2.body)
-        expect(page).to have_link("Export")
-      end
-
-      context "when no short answer exist" do
-        let(:first_type) { "long_answer" }
-
-        it "shows session token" do
-          expect(page).to have_no_content(answer1.body)
-          expect(page).to have_content(answer1.session_token)
-          expect(page).to have_content(answer2.session_token)
-          expect(page).to have_content(answer3.session_token)
-          expect(page).to have_content("User identifier")
-        end
-      end
-
-      context "when multiple answer choice" do
-        let(:first_type) { "multiple_option" }
-        let!(:answer1) { create(:answer, questionnaire:, question: first, body: nil) }
-        let!(:answer_option) { create(:answer_option, question: first) }
-        let!(:answer_choice) { create(:answer_choice, answer: answer1, answer_option:, body: translated(answer_option.body, locale: I18n.locale)) }
-
-        it "shows the answers page with custom body" do
-          new_window = window_opened_by { find_all("a.action-icon.action-icon--eye").first.click }
-
-          page.within_window(new_window) do
-            within "#answers" do
-              expect(page).to have_css("dt", text: translated(first.body))
-              expect(page).to have_css("li", text: translated(answer_option.body))
-            end
-          end
-        end
-      end
-    end
-
-    context "and managing individual answer page" do
-      let!(:answer11) { create(:answer, questionnaire:, body: "", user: answer1.user, question: second) }
-
-      before do
-        click_on "Manage questions"
-        click_on "Show responses"
-      end
-
-      it "shows all the questions and responses" do
-        click_on answer1.body, match: :first
-        expect(page).to have_content(first.body["en"])
-        expect(page).to have_content(second.body["en"])
-        expect(page).to have_content(answer1.body)
-      end
-
-      it "first answer has a next link" do
-        click_on answer1.body, match: :first
-        expect(page).to have_link("Next ›")
-        expect(page).to have_no_link("‹ Prev")
-      end
-
-      it "second answer has prev/next links" do
-        click_on answer2.body, match: :first
-        expect(page).to have_link("Next ›")
-        expect(page).to have_link("‹ Prev")
-      end
-
-      it "third answer has prev link" do
-        click_on answer3.session_token, match: :first
-        expect(page).to have_no_link("Next ›")
-        expect(page).to have_link("‹ Prev")
-      end
-
-      it "third answer has download link for the attachments" do
-        click_on answer3.session_token, match: :first
-        expect(page).to have_content(translated(file_answer.attachments.first.title))
-        expect(page).to have_content(translated(file_answer.attachments.second.title))
-      end
-
-      context "when the file answer does not have a title for the attachment" do
-        let!(:file_answer) { create(:answer, questionnaire:, question: third, body: nil, user: answer3.user, session_token: answer3.session_token) }
-
-        before do
-          create(:attachment, :with_image, attached_to: file_answer, title: {}, description: {})
-        end
-
-        it "third answer has download link for the attachments" do
-          click_on answer3.session_token, match: :first
-          expect(page).to have_content("Download attachment")
-        end
-      end
-    end
-  end
-end

data/lib/decidim/forms/user_answers_serializer.rb

@@ -1,105 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Forms
-    # This class serializes the answers given by a User for questionnaire so can be
-    # exported to CSV, JSON or other formats.
-    class UserAnswersSerializer < Decidim::Exporters::Serializer
-      include Decidim::TranslationsHelper
-
-      # Public: Initializes the serializer with a collection of Answers.
-      def initialize(answers)
-        @answers = answers
-      end
-
-      # Public: Exports a hash with the serialized data for the user answers.
-      def serialize
-        answers_hash = hash_for(@answers.first)
-        answers_hash.merge!(questions_hash)
-
-        @answers.each do |answer|
-          answers_hash[translated_question_key(answer.question.position, answer.question.body)] = normalize_body(answer)
-        end
-
-        answers_hash
-      end
-
-      private
-
-      attr_reader :answers
-      alias resource answers
-
-      def hash_for(answer)
-        {
-          answer_translated_attribute_name(:id) => answer&.session_token,
-          answer_translated_attribute_name(:created_at) => answer&.created_at,
-          answer_translated_attribute_name(:ip_hash) => answer&.ip_hash,
-          answer_translated_attribute_name(:user_status) => answer_translated_attribute_name(answer&.decidim_user_id.present? ? "registered" : "unregistered")
-        }
-      end
-
-      def questions_hash
-        questionnaire_id = @answers.first&.decidim_questionnaire_id
-        return {} unless questionnaire_id
-
-        questions = Decidim::Forms::Question.where(decidim_questionnaire_id: questionnaire_id).order(:position)
-        return {} if questions.none?
-
-        questions.each.inject({}) do |serialized, question|
-          serialized.update(
-            translated_question_key(question.position, question.body) => ""
-          )
-        end
-      end
-
-      def translated_question_key(idx, body)
-        "#{idx + 1}. #{translated_attribute(body)}"
-      end
-
-      def normalize_body(answer)
-        answer.body ||
-          normalize_attachments(answer) ||
-          normalize_choices(answer, answer.choices)
-      end
-
-      def normalize_attachments(answer)
-        return if answer.attachments.blank?
-
-        answer.attachments.map(&:url)
-      end
-
-      def normalize_choices(answer, choices)
-        if answer.question.matrix?
-          normalize_matrix_choices(answer, choices)
-        else
-          choices.map do |choice|
-            format_free_text_for choice
-          end
-        end
-      end
-
-      def normalize_matrix_choices(answer, choices)
-        answer.question.matrix_rows.to_h do |matrix_row|
-          row_body = translated_attribute(matrix_row.body)
-
-          row_choices = answer.question.answer_options.map do |answer_option|
-            choice = choices.find_by(matrix_row:, answer_option:)
-            choice.try(:custom_body) || choice.try(:body)
-          end
-
-          [row_body, row_choices]
-        end
-      end
-
-      def answer_translated_attribute_name(attribute)
-        I18n.t(attribute.to_sym, scope: "decidim.forms.user_answers_serializer")
-      end
-
-      def format_free_text_for(choice)
-        return choice.try(:body) if choice.try(:custom_body).blank?
-
-        "#{choice.try(:body)} (#{choice.try(:custom_body)})"
-      end
-    end
-  end
-end