decidim-forms 0.30.2 → 0.31.0.rc1

data/lib/decidim/forms/test/shared_examples/manage_questionnaire_responses.rb

@@ -0,0 +1,159 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "manage questionnaire responses" do
+  let(:first_type) { "short_response" }
+  let!(:first) do
+    create(:questionnaire_question, questionnaire:, position: 1, question_type: first_type)
+  end
+  let!(:second) do
+    create(:questionnaire_question, questionnaire:, position: 2, question_type: "single_option")
+  end
+  let!(:third) do
+    create(:questionnaire_question, questionnaire:, position: 3, question_type: "files")
+  end
+  let(:questions) do
+    [first, second, third]
+  end
+
+  context "when there are responses" do
+    let!(:response1) { create(:response, questionnaire:, question: first) }
+    let!(:response2) { create(:response, body: "second response", questionnaire:, question: first) }
+    let!(:response3) { create(:response, questionnaire:, question: second) }
+    let!(:file_response) { create(:response, :with_attachments, questionnaire:, question: third, body: nil, user: response3.user, session_token: response3.session_token) }
+
+    it "shows the response admin link" do
+      within "tr", text: decidim_sanitize_translated(survey.title) do
+        find("button[data-controller='dropdown']").click
+        click_on "Questions"
+      end
+      expect(page).to have_content("Responses")
+    end
+
+    context "and managing responses page" do
+      before do
+        within "tr", text: decidim_sanitize_translated(survey.title) do
+          find("button[data-controller='dropdown']").click
+          click_on "Questions"
+        end
+        click_on "Responses"
+      end
+
+      it "shows the responses page" do
+        expect(page).to have_content(response1.body)
+        expect(page).to have_content(response1.question.body["en"])
+        expect(page).to have_content(response2.body)
+        expect(page).to have_content(response2.question.body["en"])
+      end
+
+      it "shows the percentage" do
+        expect(page).to have_content("33%")
+      end
+
+      it "has a detail link" do
+        within "tr", text: decidim_sanitize_translated(response1.body) do
+          find("button[data-controller='dropdown']").click
+          expect(page).to have_link("Show responses")
+        end
+      end
+
+      it "has an export link" do
+        expect(page).to have_link(response1.body)
+        expect(page).to have_link(response2.body)
+        within "tr", text: decidim_sanitize_translated(response1.body) do
+          find("button[data-controller='dropdown']").click
+          expect(page).to have_link("Export")
+        end
+      end
+
+      context "when no short response exist" do
+        let(:first_type) { "long_response" }
+
+        it "shows session token" do
+          expect(page).to have_no_content(response1.body)
+          expect(page).to have_content(response1.session_token)
+          expect(page).to have_content(response2.session_token)
+          expect(page).to have_content(response3.session_token)
+          expect(page).to have_content("User identifier")
+        end
+      end
+
+      context "when multiple response choice" do
+        let(:first_type) { "multiple_option" }
+        let!(:response1) { create(:response, questionnaire:, question: first, body: nil) }
+        let!(:response_option) { create(:response_option, question: first) }
+        let!(:response_choice) { create(:response_choice, response: response1, response_option:, body: translated(response_option.body, locale: I18n.locale)) }
+
+        it "shows the responses page with custom body" do
+          within "tr", text: decidim_sanitize_translated(response1.session_token) do
+            find("button[data-controller='dropdown']").click
+            new_window = window_opened_by { click_on "Show responses" }
+            page.within_window(new_window) do
+              within "#responses" do
+                expect(page).to have_css("dt", text: translated(first.body))
+                expect(page).to have_css("li", text: translated(response_option.body))
+              end
+            end
+          end
+        end
+      end
+    end
+
+    context "and managing individual response page" do
+      let!(:response11) { create(:response, questionnaire:, body: "", user: response1.user, question: second) }
+
+      before do
+        within "tr", text: decidim_sanitize_translated(survey.title) do
+          find("button[data-controller='dropdown']").click
+          click_on "Questions"
+        end
+        click_on "Responses"
+      end
+
+      it "shows all the questions and responses" do
+        click_on response1.body, match: :first
+        expect(page).to have_content(first.body["en"])
+        expect(page).to have_content(second.body["en"])
+        expect(page).to have_content(response1.body)
+      end
+
+      it "first response has a next link" do
+        click_on response1.body, match: :first
+        expect(page).to have_link("Next ›")
+        expect(page).to have_no_link("‹ Prev")
+      end
+
+      it "second response has prev/next links" do
+        click_on response2.body, match: :first
+        expect(page).to have_link("Next ›")
+        expect(page).to have_link("‹ Prev")
+      end
+
+      it "third response has prev link" do
+        click_on response3.session_token, match: :first
+        expect(page).to have_no_link("Next ›")
+        expect(page).to have_link("‹ Prev")
+      end
+
+      it "third response has download link for the attachments" do
+        click_on response3.session_token, match: :first
+        expect(page).to have_content(translated(file_response.attachments.first.title))
+        expect(page).to have_content(translated(file_response.attachments.second.title))
+      end
+
+      context "when the file response does not have a title for the attachment" do
+        let!(:file_response) { create(:response, questionnaire:, question: third, body: nil, user: response3.user, session_token: response3.session_token) }
+
+        before do
+          create(:attachment, :with_image, attached_to: file_response, title: {}, description: {})
+        end
+
+        it "third response has download link for the attachments" do
+          click_on response3.session_token, match: :first
+          expect(page).to have_content("Download attachment")
+        end
+      end
+    end
+  end
+end

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_display_conditions.rb

@@ -4,7 +4,7 @@ require "spec_helper"
 
 shared_examples_for "add display conditions" do
   context "when adding display conditions to a question" do
-    let!(:answer_options) do
+    let!(:response_options) do
       3.times.to_a.map do |x|
         {
           "body" => Decidim::Faker::Localized.sentence,
@@ -14,7 +14,7 @@ shared_examples_for "add display conditions" do
     end
 
     context "when questionnaire has only one question" do
-      let!(:question) { create(:questionnaire_question, questionnaire:, body:, question_type: "short_answer") }
+      let!(:question) { create(:questionnaire_question, questionnaire:, body:, question_type: "short_response") }
 
       before do
         click_on "Save"
@@ -36,19 +36,19 @@ shared_examples_for "add display conditions" do
     end
 
     context "when questionnaire has more than one question" do
-      let!(:question_short_answer) do
+      let!(:question_short_response) do
         create(:questionnaire_question,
                position: 0,
                questionnaire:,
                body: Decidim::Faker::Localized.sentence,
-               question_type: "short_answer")
+               question_type: "short_response")
       end
-      let!(:question_long_answer) do
+      let!(:question_long_response) do
         create(:questionnaire_question,
                position: 1,
                questionnaire:,
                body: Decidim::Faker::Localized.sentence,
-               question_type: "long_answer")
+               question_type: "long_response")
       end
       let!(:question_single_option) do
         create(:questionnaire_question,
@@ -56,7 +56,7 @@ shared_examples_for "add display conditions" do
                questionnaire:,
                body: Decidim::Faker::Localized.sentence,
                question_type: "single_option",
-               options: answer_options)
+               options: response_options)
       end
       let!(:question_multiple_option) do
         create(:questionnaire_question,
@@ -64,10 +64,10 @@ shared_examples_for "add display conditions" do
                questionnaire:,
                body: Decidim::Faker::Localized.sentence,
                question_type: "multiple_option",
-               options: answer_options)
+               options: response_options)
       end
 
-      let(:questions) { [question_short_answer, question_long_answer, question_single_option, question_multiple_option] }
+      let(:questions) { [question_short_response, question_long_response, question_single_option, question_multiple_option] }
 
       before do
         click_on "Save"
@@ -82,15 +82,15 @@ shared_examples_for "add display conditions" do
             expect(page).to have_css("[id$=mandatory]")
 
             select question_single_option.body["en"], from: "Question"
-            select "Answered", from: "Condition"
+            select "Responded", from: "Condition"
 
-            expect(page).to have_no_select("Answer option")
+            expect(page).to have_no_select("Response option")
             expect(page).to have_no_css("[id$=condition_value_en]", visible: :visible)
 
             select question_single_option.body["en"], from: "Question"
             select "Equal", from: "Condition"
 
-            expect(page).to have_select("Answer option")
+            expect(page).to have_select("Response option")
             expect(page).to have_no_css("[id$=condition_value_en]", visible: :visible)
           end
         end
@@ -112,9 +112,9 @@ shared_examples_for "add display conditions" do
         context "when a text question is selected" do
           it "fills condition_type select with correct options" do
             within_add_display_condition do
-              select question_short_answer.body["en"], from: "Question"
+              select question_short_response.body["en"], from: "Question"
 
-              options = ["Select a condition type", "Answered", "Not answered", "Includes text"]
+              options = ["Select a condition type", "Responded", "Not responded", "Includes text"]
 
               option_elements = page.all("select[id$=condition_type] option")
               option_elements = option_elements.to_a.reject { |option| option[:style].match? "display: none" }
@@ -129,7 +129,7 @@ shared_examples_for "add display conditions" do
             within_add_display_condition do
               select question_single_option.body["en"], from: "Question"
 
-              options = ["Select a condition type", "Answered", "Not answered", "Equal", "Not equal", "Includes text"]
+              options = ["Select a condition type", "Responded", "Not responded", "Equal", "Not equal", "Includes text"]
 
               option_elements = page.all("select[id$=condition_type] option")
               option_elements = option_elements.to_a.reject { |option| option[:style].match? "display: none" }
@@ -139,15 +139,15 @@ shared_examples_for "add display conditions" do
           end
         end
 
-        it "fills answer_options select with correct options" do
+        it "fills response_options select with correct options" do
           within_add_display_condition do
             select question_single_option.body["en"], from: "Question"
             select "Equal", from: "Condition"
 
-            options = answer_options.map { |option| option["body"]["en"] }
-            options << "Select answer option"
+            options = response_options.map { |option| option["body"]["en"] }
+            options << "Select response option"
 
-            expect(page).to have_select("Answer option", options:, wait: 5)
+            expect(page).to have_select("Response option", options:, wait: 5)
           end
         end
 

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_questions.rb

@@ -10,16 +10,16 @@ shared_examples_for "add questions" do
       select "Multiple option", from: "Type"
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
 
-      click_on "Add answer option"
+      click_on "Add response option"
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
 
-      click_on "Add answer option"
+      click_on "Add response option"
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3 4))
 
-      within(".questionnaire-question-answer-option:last-of-type") { click_on "Remove" }
+      within(".questionnaire-question-response-option:last-of-type") { click_on "Remove" }
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
 
-      within(".questionnaire-question-answer-option:last-of-type") { click_on "Remove" }
+      within(".questionnaire-question-response-option:last-of-type") { click_on "Remove" }
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
 
       click_on "Add question"
@@ -108,9 +108,9 @@ shared_examples_for "add questions" do
     expect(page).to have_css("strong", text: "Superkalifragilistic description")
   end
 
-  it "adds a question with answer options" do
+  it "adds a question with response options" do
     question_body = ["This is the first question", "This is the second question"]
-    answer_options_body = [
+    response_options_body = [
       [
         "This is the Q1 first option",
         "This is the Q1 second option",
@@ -133,19 +133,19 @@ shared_examples_for "add questions" do
       end
     end
 
-    expect(page).to have_no_content "Add answer option"
+    expect(page).to have_no_content "Add response option"
 
     page.all(".questionnaire-question").each do |question|
       within question do
         select "Single option", from: "Type"
-        click_on "Add answer option"
+        click_on "Add response option"
       end
     end
 
     page.all(".questionnaire-question").each_with_index do |question, question_idx|
-      question.all(".questionnaire-question-answer-option").each_with_index do |question_answer_option, answer_option_idx|
-        within question_answer_option do
-          fill_in find_nested_form_field_locator("body_en"), with: answer_options_body[question_idx][answer_option_idx]
+      question.all(".questionnaire-question-response-option").each_with_index do |question_response_option, response_option_idx|
+        within question_response_option do
+          fill_in find_nested_form_field_locator("body_en"), with: response_options_body[question_idx][response_option_idx]
         end
       end
     end
@@ -170,57 +170,57 @@ shared_examples_for "add questions" do
     click_on "Add question"
     expand_all_questions
 
-    select "Long answer", from: "Type"
-    expect(page).to have_no_css(".questionnaire-question-answer-option")
+    select "Long response", from: "Type"
+    expect(page).to have_no_css(".questionnaire-question-response-option")
     expect(page).to have_no_css(".questionnaire-question-matrix-row")
 
     select "Single option", from: "Type"
-    expect(page).to have_css(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_css(".questionnaire-question-response-option", count: 2)
     expect(page).to have_no_css(".questionnaire-question-matrix-row")
 
     select "Multiple option", from: "Type"
-    expect(page).to have_css(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_css(".questionnaire-question-response-option", count: 2)
     expect(page).to have_no_css(".questionnaire-question-matrix-row")
 
     select "Matrix (Multiple option)", from: "Type"
-    expect(page).to have_css(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_css(".questionnaire-question-response-option", count: 2)
     expect(page).to have_css(".questionnaire-question-matrix-row", count: 2)
 
-    select "Short answer", from: "Type"
-    expect(page).to have_no_css(".questionnaire-question-answer-option")
+    select "Short response", from: "Type"
+    expect(page).to have_no_css(".questionnaire-question-response-option")
     expect(page).to have_no_css(".questionnaire-question-matrix-row")
 
     select "Matrix (Single option)", from: "Type"
-    expect(page).to have_css(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_css(".questionnaire-question-response-option", count: 2)
     expect(page).to have_css(".questionnaire-question-matrix-row", count: 2)
   end
 
-  it "does not incorrectly reorder when clicking answer options" do
+  it "does not incorrectly reorder when clicking response options" do
     click_on "Add question"
     expand_all_questions
 
     select "Single option", from: "Type"
-    2.times { click_on "Add answer option" }
+    2.times { click_on "Add response option" }
 
-    within ".questionnaire-question-answer-option:first-of-type" do
+    within ".questionnaire-question-response-option:first-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Something"
     end
 
-    within ".questionnaire-question-answer-option:last-of-type" do
+    within ".questionnaire-question-response-option:last-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Else"
     end
 
     # If JS events for option reordering are incorrectly bound, clicking on
     # the field to gain focus can cause the options to get inverted... :S
-    within ".questionnaire-question-answer-option:first-of-type" do
+    within ".questionnaire-question-response-option:first-of-type" do
       find_nested_form_field("body_en").click
     end
 
-    within ".questionnaire-question-answer-option:first-of-type" do
+    within ".questionnaire-question-response-option:first-of-type" do
       expect(page).to have_nested_field("body_en", with: "Something")
     end
 
-    within ".questionnaire-question-answer-option:last-of-type" do
+    within ".questionnaire-question-response-option:last-of-type" do
       expect(page).to have_nested_field("body_en", with: "Else")
     end
   end
@@ -260,24 +260,24 @@ shared_examples_for "add questions" do
     expand_all_questions
 
     expect(page).to have_text("Type")
-    select "Long answer", from: "Type"
+    select "Long response", from: "Type"
     click_on "Save"
 
     expand_all_questions
-    expect(page).to have_select("Type", selected: "Long answer", wait: 10)
+    expect(page).to have_select("Type", selected: "Long response", wait: 10)
   end
 
-  it "does not preserve spurious answer options from previous type selections" do
+  it "does not preserve spurious response options from previous type selections" do
     click_on "Add question"
     expand_all_questions
 
     select "Single option", from: "Type"
 
-    within ".questionnaire-question-answer-option:first-of-type" do
+    within ".questionnaire-question-response-option:first-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Something"
     end
 
-    select "Long answer", from: "Type"
+    select "Long response", from: "Type"
 
     click_on "Save"
     expand_all_questions
@@ -285,7 +285,7 @@ shared_examples_for "add questions" do
     expect(page).to have_text("Type")
     select "Single option", from: "Type"
 
-    within ".questionnaire-question-answer-option:first-of-type" do
+    within ".questionnaire-question-response-option:first-of-type" do
       expect(page).to have_no_nested_field("body_en", with: "Something")
     end
   end
@@ -300,7 +300,7 @@ shared_examples_for "add questions" do
       fill_in find_nested_form_field_locator("body_en"), with: "Something"
     end
 
-    select "Long answer", from: "Type"
+    select "Long response", from: "Type"
 
     click_on "Save"
     expand_all_questions
@@ -313,19 +313,19 @@ shared_examples_for "add questions" do
     end
   end
 
-  it "preserves answer options form across submission failures" do
+  it "preserves response options form across submission failures" do
     click_on "Add question"
     expand_all_questions
 
     select "Multiple option", from: "Type"
 
-    within ".questionnaire-question-answer-option:first-of-type" do
+    within ".questionnaire-question-response-option:first-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Something"
     end
 
-    click_on "Add answer option"
+    click_on "Add response option"
 
-    within ".questionnaire-question-answer-option:last-of-type" do
+    within ".questionnaire-question-response-option:last-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Else"
     end
 
@@ -334,12 +334,12 @@ shared_examples_for "add questions" do
     click_on "Save"
     expand_all_questions
 
-    expect(page).to have_css(".questionnaire-question-answer-option")
-    within ".questionnaire-question-answer-option:first-of-type" do
+    expect(page).to have_css(".questionnaire-question-response-option")
+    within ".questionnaire-question-response-option:first-of-type" do
       expect(page).to have_nested_field("body_en", with: "Something")
     end
 
-    within ".questionnaire-question-answer-option:last-of-type" do
+    within ".questionnaire-question-response-option:last-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Else"
     end
 
@@ -397,7 +397,7 @@ shared_examples_for "add questions" do
         fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
       end
 
-      expect(page).to have_no_content "Add answer option"
+      expect(page).to have_no_content "Add response option"
       expect(page).to have_no_select("Maximum number of choices")
     end
 
@@ -407,7 +407,7 @@ shared_examples_for "add questions" do
       select "Multiple option", from: "Type"
       expect(page).to have_css("input[type=checkbox][id$=_free_text]")
 
-      select "Short answer", from: "Type"
+      select "Short response", from: "Type"
       expect(page).to have_no_css("input[type=checkbox][id$=_free_text]")
 
       select "Single option", from: "Type"
@@ -429,7 +429,7 @@ shared_examples_for "add questions" do
         fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
       end
 
-      expect(page).to have_no_content "Add answer option"
+      expect(page).to have_no_content "Add response option"
       expect(page).to have_no_content "Add row"
       expect(page).to have_no_select("Maximum number of choices")
     end
@@ -440,7 +440,7 @@ shared_examples_for "add questions" do
       select "Matrix (Multiple option)", from: "Type"
       expect(page).to have_css("input[type=checkbox][id$=_free_text]")
 
-      select "Short answer", from: "Type"
+      select "Short response", from: "Type"
       expect(page).to have_no_css("input[type=checkbox][id$=_free_text]")
 
       select "Matrix (Single option)", from: "Type"

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/update_display_conditions.rb

@@ -4,18 +4,18 @@ require "spec_helper"
 
 shared_examples_for "update display conditions" do
   context "when loading a saved display condition" do
-    let!(:condition_question_type) { "short_answer" }
+    let!(:condition_question_type) { "short_response" }
     let!(:condition_question) { create(:questionnaire_question, questionnaire:, question_type: condition_question_type, position: 1) }
-    let!(:question) { create(:questionnaire_question, questionnaire:, question_type: "short_answer", position: 2) }
-    let!(:condition_type) { :answered }
-    let!(:answer_option) { nil }
+    let!(:question) { create(:questionnaire_question, questionnaire:, question_type: "short_response", position: 2) }
+    let!(:condition_type) { :responded }
+    let!(:response_option) { nil }
 
     let!(:display_condition) do
       create(:display_condition,
              question:,
              condition_question:,
              condition_type:,
-             answer_option:)
+             response_option:)
     end
 
     before do
@@ -35,20 +35,20 @@ shared_examples_for "update display conditions" do
 
     it "loads condition_type in select" do
       within ".questionnaire-question-display-condition" do
-        expect(page).to have_select("Condition", selected: "Answered")
+        expect(page).to have_select("Condition", selected: "Responded")
       end
     end
 
     context "when condition_type is :equal" do
       let!(:condition_question_type) { "single_option" }
-      let!(:answer_options) { create_list(:answer_option, 3, question: condition_question) }
-      let!(:answer_option) { answer_options.third }
+      let!(:response_options) { create_list(:response_option, 3, question: condition_question) }
+      let!(:response_option) { response_options.third }
       let!(:condition_type) { :equal }
 
-      it "loads answer_option in select" do
+      it "loads response_option in select" do
         within ".questionnaire-question-display-condition" do
           expect(page).to have_select("Condition", selected: "Equal")
-          expect(page).to have_select("Answer option", selected: answer_option.body["en"])
+          expect(page).to have_select("Response option", selected: response_option.body["en"])
         end
       end
     end