decidim-elections 0.27.2 → 0.27.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0e0726f771ccc1c15ad50d007e1a7ca22309c4710c1ee26092db56866ff996aa
-  data.tar.gz: ce6be8d2ae93611a2020c5a8cf1891f8a27c7c725cee6be99492b9c854c19508
+  metadata.gz: 86f9af4eb56a517eb85ce45e079ba761c916040de349fb52b878886a3ad5b27c
+  data.tar.gz: '0436869e21f87e86847c41940ffd617cfcfbe6516e86bff3d2d6e2f7b9e6308b'
 SHA512:
-  metadata.gz: e457526bc556190676e4c3aa0115efcbb5d72c8c6e8752246e4e6b7fc5f94628a13679a7a044e42a16faae1445c629460599b11e12c0626eb23312b139218b55
-  data.tar.gz: ecad851a410f49fc81d4df6e3f5cba6c9fce2802b9e6a5fb789cd38f559f6eef717965bd5430fd4e32e7a4f549ab179205a9634ab1caf640649ca4282da6e26f
+  metadata.gz: 798f01f86d2c7a1d3232c8e76d6a2fe9289c585265d6f488178f0e1fa71931a7ae49d2f645b4ec42d0b44fd890094908e644315f31c6f8c003ddf618abd09b4a
+  data.tar.gz: b87ebc1509c74e59911917343b529498c3ba163ae35d691e90ff10cfbc337a4d4eca1654f4176033a4bb85c15948515cbe0e0c898975f8e7d14e3eb5522b10fb

data/app/commands/decidim/elections/admin/create_answer.rb

@@ -38,7 +38,7 @@ module Decidim
         attr_reader :form, :answer, :gallery
 
         def invalid?
-          form.election.started? || form.invalid?
+          form.election.blocked? || form.invalid?
         end
 
         def create_answer

data/app/commands/decidim/elections/admin/create_question.rb

@@ -14,7 +14,7 @@ module Decidim
         #
         # Broadcasts :ok if successful, :invalid otherwise.
         def call
-          return broadcast(:election_started) if form.election.started?
+          return broadcast(:election_started) if form.election.blocked?
           return broadcast(:invalid) if form.invalid?
 
           create_question!

data/app/commands/decidim/elections/admin/destroy_answer.rb

@@ -31,7 +31,7 @@ module Decidim
         attr_reader :answer, :current_user
 
         def invalid?
-          answer.question.election.started?
+          answer.question.election.blocked?
         end
 
         def destroy_answer

data/app/commands/decidim/elections/admin/destroy_election.rb

@@ -31,7 +31,7 @@ module Decidim
         attr_reader :election, :current_user
 
         def invalid?
-          election.started?
+          election.blocked?
         end
 
         def destroy_election!

data/app/commands/decidim/elections/admin/destroy_question.rb

@@ -27,7 +27,7 @@ module Decidim
         attr_reader :question, :current_user
 
         def invalid?
-          question.election.started?
+          question.election.blocked?
         end
 
         def destroy_question!

data/app/commands/decidim/elections/admin/import_proposals_to_elections.rb

@@ -30,7 +30,7 @@ module Decidim
         attr_reader :form, :answer
 
         def invalid?
-          form.election.started? || form.invalid?
+          form.election.blocked? || form.invalid?
         end
 
         def create_answers_from_accepted_proposals

data/app/commands/decidim/elections/admin/publish_election.rb

@@ -19,7 +19,7 @@ module Decidim
         # Broadcasts :ok if published, :invalid otherwise.
         def call
           publish_election
-          publish_event
+          publish_event unless election.previously_published?
 
           broadcast(:ok, election)
         end

data/app/commands/decidim/elections/admin/update_answer.rb

@@ -41,7 +41,7 @@ module Decidim
         attr_reader :form, :answer, :gallery
 
         def invalid?
-          form.election.started? || form.invalid?
+          form.election.blocked? || form.invalid?
         end
 
         def update_answer

data/app/commands/decidim/elections/admin/update_question.rb

@@ -27,7 +27,7 @@ module Decidim
         attr_reader :form, :question
 
         def invalid?
-          question.election.started? || form.invalid?
+          question.election.blocked? || form.invalid?
         end
 
         def update_question!

data/app/controllers/decidim/elections/admin/trustees_participatory_spaces_controller.rb

@@ -72,7 +72,7 @@ module Decidim
         private
 
         def trustee_participatory_space
-          @trustee_participatory_space ||= TrusteesParticipatorySpace.find_by(id: params[:id])
+          @trustee_participatory_space ||= TrusteesParticipatorySpace.find_by(id: params[:id], participatory_space: current_participatory_space)
         end
 
         def trustees

data/app/controllers/decidim/elections/trustee_zone/application_controller.rb

@@ -13,6 +13,11 @@ module Decidim
 
         before_action :ensure_configured_bulletin_board!
 
+        register_permissions(::Decidim::Elections::TrusteeZone::ApplicationController,
+                             ::Decidim::Elections::Permissions,
+                             ::Decidim::Admin::Permissions,
+                             ::Decidim::Permissions)
+
         private
 
         def ensure_configured_bulletin_board!
@@ -34,10 +39,7 @@ module Decidim
         end
 
         def permission_class_chain
-          [
-            Decidim::Elections::Permissions,
-            Decidim::Permissions
-          ]
+          ::Decidim.permissions_registry.chain_for(::Decidim::Elections::TrusteeZone::ApplicationController)
         end
       end
     end

data/app/controllers/decidim/votings/admin/exports_controller.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Votings
+    module Admin
+      # This controller allows exporting things.
+      # It is targeted for customizations for exporting things that lives under
+      # a participatory process.
+      class ExportsController < Decidim::Admin::ExportsController
+        include VotingAdmin
+      end
+    end
+  end
+end

data/app/controllers/decidim/votings/admin/reminders_controller.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Votings
+    module Admin
+      # This controller allows to send reminders.
+      # It is targeted for customizations for reminder things that lives under
+      # votings.
+      class RemindersController < Decidim::Admin::RemindersController
+        include VotingAdmin
+      end
+    end
+  end
+end

data/app/controllers/decidim/votings/admin/votings_landing_page_content_blocks_controller.rb

@@ -18,7 +18,7 @@ module Decidim
         end
 
         def scoped_resource
-          @scoped_resource ||= Voting.find_by(slug: params[:voting_slug])
+          @scoped_resource ||= Voting.find_by(slug: params[:voting_slug], organization: current_organization)
         end
 
         def enforce_permission_to_update_resource

data/app/controllers/decidim/votings/admin/votings_landing_page_controller.rb

@@ -16,7 +16,7 @@ module Decidim
         end
 
         def scoped_resource
-          @scoped_resource ||= Voting.find_by(slug: params[:voting_slug])
+          @scoped_resource ||= Voting.find_by(slug: params[:voting_slug], organization: current_organization)
         end
 
         def enforce_permission_to_update_resource

data/app/controllers/decidim/votings/polling_officer_zone/closures_controller.rb

@@ -111,7 +111,10 @@ module Decidim
         end
 
         def election
-          @election ||= Decidim::Elections::Election.includes(questions: :answers).find_by(id: params[:election_id])
+          @election ||= Decidim::Elections::Election.joins(:component)
+                                                    .where(component: { participatory_space: current_organization.participatory_spaces })
+                                                    .includes(questions: :answers)
+                                                    .find_by(id: params[:election_id])
         end
 
         def polling_station

data/app/controllers/decidim/votings/polling_officer_zone/in_person_votes_controller.rb

@@ -121,7 +121,10 @@ module Decidim
         end
 
         def election
-          @election ||= Decidim::Elections::Election.find(params[:election_id])
+          @election ||= Decidim::Elections::Election.joins(:component)
+                                                    .where(component: { participatory_space: current_organization.participatory_spaces })
+                                                    .includes(questions: :answers)
+                                                    .find_by(id: params[:election_id])
         end
 
         def polling_officer

data/app/controllers/decidim/votings/votings_controller.rb

@@ -103,7 +103,7 @@ module Decidim
       end
 
       def election
-        @election ||= Decidim::Elections::Election.find(params[:election_id])
+        @election ||= Decidim::Elections::Election.where(component: current_participatory_space.components).find(params[:election_id])
       end
 
       def elections

data/app/forms/decidim/elections/admin/setup_form.rb

@@ -41,7 +41,8 @@ module Decidim
             [:max_selections, {}, election.valid_questions?],
             [:published, {}, election.published_at.present?],
             [:component_published, {}, election.component.published?],
-            [:time_before, { hours: Decidim::Elections.setup_minimum_hours_before_start }, election.minimum_hours_before_start?],
+            [:time_before, { hours: I18n.t("datetime.distance_in_words.x_hours", count: Decidim::Elections.setup_minimum_hours_before_start) },
+             election.minimum_hours_before_start?],
             [:trustees_number, { number: bulletin_board.number_of_trustees }, participatory_space_trustees_with_public_key.size >= bulletin_board.number_of_trustees]
           ].freeze
         end

data/app/forms/decidim/votings/admin/voting_role_form.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Votings
+    module Admin
+      # Base class to be inherited by other forms that have roles
+      # in the Votings space
+      class VotingRoleForm < Decidim::Form
+        attribute :name, String
+        attribute :email, String
+        attribute :user_id, Integer
+        attribute :existing_user, Boolean, default: false
+
+        validates :email, presence: true, format: { with: ::Devise.email_regexp }, unless: ->(form) { form.existing_user }
+        validates :name, presence: true, format: { with: UserBaseEntity::REGEXP_NAME }, unless: ->(form) { form.existing_user }
+        validates :user, presence: true, if: ->(form) { form.existing_user }
+
+        def map_model(model)
+          self.user_id = model.decidim_user_id
+          self.existing_user = user_id.present?
+        end
+
+        def user
+          @user ||= current_organization.users.find_by(id: user_id)
+        end
+      end
+    end
+  end
+end

data/app/permissions/decidim/elections/admin/permissions.rb

@@ -24,10 +24,8 @@ module Decidim
             case permission_action.action
             when :create, :read
               allow!
-            when :delete, :update, :unpublish
+            when :delete, :update, :unpublish, :publish
               allow_if_not_blocked
-            when :publish
-              allow_if_valid_and_not_blocked
             end
           when :trustees
             case permission_action.action
@@ -80,10 +78,6 @@ module Decidim
           toggle_allow(election && !election.blocked?)
         end
 
-        def allow_if_valid_and_not_blocked
-          toggle_allow(election && !election.blocked? && election.valid_questions?)
-        end
-
         def allow_if_not_related_to_any_election
           toggle_allow(trustee_participatory_space.trustee.elections.empty?)
         end

data/app/permissions/decidim/votings/admin/permissions.rb

@@ -120,7 +120,7 @@ module Decidim
               toggle_allow(user.admin? && (voting.dataset.blank? || voting.dataset.init_data?) && ballot_style.present?)
             end
           when :component_data
-            toggle_allow(user.admin?) if permission_action.action == :import
+            toggle_allow(user.admin?) if [:import, :export].member? permission_action.action
           end
         end
 

data/app/views/decidim/elections/admin/elections/edit.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t(".title")) %>
 <%= decidim_form_for(@form, html: { class: "form edit_election" }) do |f| %>
   <%= render partial: "form", object: f, locals: { title: t(".title") } %>
 

data/app/views/decidim/elections/admin/elections/index.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t(".title")) %>
 <div class="card">
   <div class="card-divider">
     <h2 class="card-title">

data/app/views/decidim/elections/admin/elections/new.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t(".title")) %>
 <%= decidim_form_for(@form, html: { class: "form new_election" }) do |f| %>
   <%= render partial: "form", object: f, locals: { title: t(".title") } %>
 

data/app/views/decidim/elections/admin/trustees_participatory_spaces/index.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t(".title")) %>
 <div class="card" id="trustees">
   <div class="card-divider">
     <h2 class="card-title">

data/app/views/decidim/elections/admin/trustees_participatory_spaces/new.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t(".title")) %>
 <%= decidim_form_for(@form, url: trustees_path, html: { class: "form new_trustee" }) do |f| %>
   <%= render partial: "form", object: f, locals: { title: t(".title") } %>
 

data/app/views/decidim/elections/elections/show.html.erb

@@ -45,7 +45,7 @@ edit_link(
   <% end %>
   <div class="columns medium-8 mediumlarge-7">
     <div class="section">
-      <p><%= decidim_sanitize_editor(simple_format(translated_attribute(election.description)), strip_tags: true) %></p>
+      <p><%= decidim_sanitize_editor_admin(translated_attribute(election.description)) %></p>
 
       <%= cell("decidim/elections/election_vote_cta", election) %>
 

data/app/views/decidim/votings/admin/ballot_styles/edit.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t(".title")) %>
 <%= decidim_form_for([current_voting, @form], url: { action: "update" }, html: { class: "form edit_ballot_style" })  do |f| %>
   <%= render partial: "form", object: f, locals: { title: t(".title") } %>
 

data/app/views/decidim/votings/admin/ballot_styles/index.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t(".title")) %>
 <div class="callout warning">
   <%= icon "info" %>
   <span class="callout-text"><%= t("explanation_callout", scope: "decidim.votings.admin.ballot_styles.index") %></span>

data/app/views/decidim/votings/admin/ballot_styles/new.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t(".title")) %>
 <%= decidim_form_for([current_participatory_space, @form], html: { class: "form new_ballot_style" }) do |f| %>
   <%= render partial: "form", object: f, locals: { title: t(".title") } %>
 

data/app/views/decidim/votings/admin/votings/_form.html.erb

@@ -11,7 +11,7 @@
     </div>
 
     <div class="row column">
-      <%= form.translated :editor, :description, toolbar: :full, lines: 25 %>
+      <%= form.translated :editor, :description %>
     </div>
 
     <div class="row">

data/app/views/decidim/votings/admin/votings/edit.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t("votings.edit.update", scope: "decidim.votings.admin")) %>
 <%= decidim_form_for @form,
                      method: :patch,
                      url: voting_path(@current_voting),

data/app/views/decidim/votings/admin/votings/index.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t("decidim.votings.admin.titles.votings")) %>
 <div class="card with-overflow" id="votings">
   <div class="card-divider">
     <h2 class="card-title">

data/app/views/decidim/votings/admin/votings/new.html.erb

@@ -1,5 +1,4 @@
 <% add_decidim_page_title(t("votings.new.title", scope: "decidim.votings.admin")) %>
-
 <h2 class="voting-title-summary">
   <%= t("votings.new.title", scope: "decidim.votings.admin") %>
 </h2>

data/app/views/decidim/votings/census/admin/census/_new_census.html.erb

@@ -12,7 +12,7 @@
                             method: :post,
                             html: { class: "form new_census" }) do |form| %>
         <div class="field">
-          <%= form.upload :file, optional: false, help_i18n_scope: "decidim.votings.census.admin.census.new.file_help" %>
+          <%= form.upload :file, required: true, help_i18n_scope: "decidim.votings.census.admin.census.new.file_help" %>
         </div>
 
         <%= submit_tag t("submit", scope: "decidim.votings.census.admin.census.new"), class: "button" %>

data/app/views/decidim/votings/census/admin/census/show.html.erb

@@ -1,3 +1,4 @@
+<% add_decidim_page_title(t("show.heading", scope: "decidim.votings.census.admin.census")) %>
 <div class="card">
   <div class="card-divider">
     <h2 class="card-title">

data/config/locales/ar.yml

@@ -6,9 +6,21 @@ ar:
         description: الوصف
       election:
         description: الوصف
+      monitoring_committee_member:
+        name: الاسم
+      polling_officer:
+        name: الاسم
   decidim:
+    components:
+      elections:
+        name: الانتخابات
     elections:
       admin:
+        models:
+          answer:
+            name: الإجابة
+          question:
+            name: سؤال
         steps:
           tally_started:
             invalid: كانت هناك مشكلة في الإبلاغ عن الأمين المفقود
@@ -22,16 +34,33 @@ ar:
           results_title: النتائج
         results:
           percentage: "%{count}%"
+      models:
+        trustees_participatory_space:
+          fields:
+            name: الاسم
       trustee_zone:
         trustees:
           show:
             identification_keys:
               cancel: إلغاء
+      votes:
+        confirm:
+          answer: الإجابة
     votings:
       admin:
+        models:
+          monitoring_committee_member:
+            fields:
+              name: الاسم
+          polling_officer:
+            fields:
+              name: الاسم
         monitoring_committee_election_results:
           actions:
             title: الإجراءات
+      monitoring_committee_members:
+        actions:
+          destroy: حذف
       polling_officer_zone:
         closures:
           edit:
@@ -39,3 +68,16 @@ ar:
               close_modal: غلق
           sign:
             cancel: إلغاء
+        in_person_votes:
+          verify_document:
+            name: الاسم
+        polling_officers:
+          index:
+            polling_station:
+              name: الاسم
+      polling_officers:
+        actions:
+          destroy: حذف
+      polling_stations:
+        actions:
+          destroy: حذف

data/config/locales/ca.yml

@@ -688,10 +688,10 @@ ca:
         header:
           ballot_decision: Envia o audita el teu vot
           casting: El vot s'està dipositant
-          confirm: Confirma el teu vot
+          confirm: Confirmar el teu vot
           confirmed: Vot confirmat
           encrypting: El vot s'està xifrant
-          failed: Error en el vot
+          failed: Vot fallit
         messages:
           invalid_token: La sessió de la cabina de votació no és vàlida. Prova de votar de nou.
           not_allowed: No pots votar en aquesta votació en aquest moment.
@@ -823,15 +823,15 @@ ca:
             description:
               name: Descripció de la votació
             elections:
-              name: Eleccions de la votació
+              name: Eleccions
             header:
               name: Capçalera de la votació
             html_block_1:
-              name: Bloc html 1 de votació
+              name: Bloc html 1 de la votació
             html_block_2:
-              name: Bloc html 2 de votació
+              name: Bloc html 2 de la votació
             html_block_3:
-              name: Bloc html 3 de votació
+              name: Bloc html 3 de la votació
             metrics:
               name: Mètriques de la votació
             polling_stations:
@@ -1415,7 +1415,7 @@ ca:
         footer_button_text:
           participate: Participa
           view: Veure
-          vote: Vota
+          vote: Votar
         unspecified: Sense especificar
         voting_type:
           hybrid: Híbrida

data/config/locales/cs.yml

@@ -842,14 +842,10 @@ cs:
           highlighted_votings:
             max_results: Maximální počet prvků k zobrazení
           landing_page:
-            attachments_and_folders:
-              name: Přílohy a složky hlasování
             description:
               name: Popis hlasování
             elections:
               name: Hlasovací volby
-            header:
-              name: Záhlaví hlasování
             html_block_1:
               name: Html blok 1 hlasování
             html_block_2: