decidim-decidim_awesome 0.8.0 → 0.12.0

data/app/commands/decidim/decidim_awesome/admin/create_custom_redirect.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class CreateCustomRedirect < Rectify::Command
+      class CreateCustomRedirect < Command
         # Public: Initializes the command.
         #
         def initialize(form)

data/app/commands/decidim/decidim_awesome/admin/create_menu_hack.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class CreateMenuHack < Rectify::Command
+      class CreateMenuHack < Command
         # Public: Initializes the command.
         #
         def initialize(form, menu_name)

data/app/commands/decidim/decidim_awesome/admin/create_proposal_custom_field.rb

@@ -3,14 +3,15 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class CreateProposalCustomField < Rectify::Command
+      class CreateProposalCustomField < Command
         include NeedsConstraintHelpers
 
         # Public: Initializes the command.
         #
-        def initialize(organization)
+        def initialize(organization, config_var = :proposal_custom_fields)
           @organization = organization
           @ident = rand(36**8).to_s(36)
+          @config_var = config_var
         end
 
         # Executes the command. Broadcasts these events:
@@ -20,13 +21,13 @@ module Decidim
         #
         # Returns nothing.
         def call
-          fields = AwesomeConfig.find_or_initialize_by(var: :proposal_custom_fields, organization: @organization)
+          fields = AwesomeConfig.find_or_initialize_by(var: @config_var, organization: @organization)
           fields.value = {} unless fields.value.is_a? Hash
           # TODO: prevent (unlikely) colisions with exisiting values
           fields.value[@ident] = default_definition
           fields.save!
 
-          create_constraint_never(:proposal_custom_field)
+          create_constraint_never(@config_var == :proposal_custom_fields ? :proposal_custom_field : :proposal_private_custom_field)
 
           broadcast(:ok, @ident)
         rescue StandardError => e

data/app/commands/decidim/decidim_awesome/admin/create_scoped_admin.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class CreateScopedAdmin < Rectify::Command
+      class CreateScopedAdmin < Command
         include NeedsConstraintHelpers
 
         # Public: Initializes the command.

data/app/commands/decidim/decidim_awesome/admin/create_scoped_style.rb

@@ -3,12 +3,13 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class CreateScopedStyle < Rectify::Command
+      class CreateScopedStyle < Command
         # Public: Initializes the command.
         #
-        def initialize(organization)
+        def initialize(organization, config_var = :scoped_styles)
           @organization = organization
           @ident = rand(36**8).to_s(36)
+          @config_var = config_var
         end
 
         # Executes the command. Broadcasts these events:
@@ -18,7 +19,7 @@ module Decidim
         #
         # Returns nothing.
         def call
-          styles = AwesomeConfig.find_or_initialize_by(var: :scoped_styles, organization: @organization)
+          styles = AwesomeConfig.find_or_initialize_by(var: @config_var, organization: @organization)
           styles.value = {} unless styles.value.is_a? Hash
           # TODO: prevent (unlikely) colisions with exisiting values
           styles.value[@ident] = ""

data/app/commands/decidim/decidim_awesome/admin/destroy_constraint.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class DestroyConstraint < Rectify::Command
+      class DestroyConstraint < Command
         include NeedsConstraintHelpers
 
         # Public: Initializes the command.

data/app/commands/decidim/decidim_awesome/admin/destroy_custom_redirect.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class DestroyCustomRedirect < Rectify::Command
+      class DestroyCustomRedirect < Command
         # Public: Initializes the command.
         #
         # item - the redirections item to destroy
@@ -11,7 +11,7 @@ module Decidim
         def initialize(item, organization)
           @item = item
           @organization = organization
-          @redirections = AwesomeConfig.find_by(var: :custom_redirects, organization: organization)
+          @redirections = AwesomeConfig.find_by(var: :custom_redirects, organization:)
         end
 
         # Executes the command. Broadcasts these events:

data/app/commands/decidim/decidim_awesome/admin/destroy_menu_hack.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class DestroyMenuHack < Rectify::Command
+      class DestroyMenuHack < Command
         # Public: Initializes the command.
         #
         # item - the menu item to destroy
@@ -11,7 +11,7 @@ module Decidim
         def initialize(item, menu_name, organization)
           @item = item
           @organization = organization
-          @menu = AwesomeConfig.find_by(var: menu_name, organization: organization)
+          @menu = AwesomeConfig.find_by(var: menu_name, organization:)
         end
 
         # Executes the command. Broadcasts these events:

data/app/commands/decidim/decidim_awesome/admin/destroy_proposal_custom_field.rb

@@ -3,14 +3,15 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class DestroyProposalCustomField < Rectify::Command
+      class DestroyProposalCustomField < Command
         # Public: Initializes the command.
         #
         # key - the key to destroy inise proposal_custom_fields
         # organization
-        def initialize(key, organization)
+        def initialize(key, organization, config_var = :proposal_custom_fields)
           @key = key
           @organization = organization
+          @config_var = config_var
         end
 
         # Executes the command. Broadcasts these events:
@@ -20,14 +21,16 @@ module Decidim
         #
         # Returns nothing.
         def call
-          fields = AwesomeConfig.find_by(var: :proposal_custom_fields, organization: @organization)
+          fields = AwesomeConfig.find_by(var: @config_var, organization: @organization)
           return broadcast(:invalid, "Not a hash") unless fields&.value.is_a? Hash
           return broadcast(:invalid, "#{key} key invalid") unless fields.value.has_key?(@key)
 
           fields.value.except!(@key)
           fields.save!
+
           # remove constrains associated (a new config var is generated automatically, by removing it, it will trigger destroy on dependents)
-          constraint = AwesomeConfig.find_by(var: "proposal_custom_field_#{@key}", organization: @organization)
+          constraint = @config_var == :proposal_custom_fields ? :proposal_custom_field : :proposal_private_custom_field
+          constraint = AwesomeConfig.find_by(var: "#{constraint}_#{@key}", organization: @organization)
           constraint.destroy! if constraint.present?
 
           broadcast(:ok, @key)

data/app/commands/decidim/decidim_awesome/admin/destroy_scoped_admin.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class DestroyScopedAdmin < Rectify::Command
+      class DestroyScopedAdmin < Command
         # Public: Initializes the command.
         #
         # key - the key to destroy inside scoped_admins

data/app/commands/decidim/decidim_awesome/admin/destroy_scoped_style.rb

@@ -3,14 +3,15 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class DestroyScopedStyle < Rectify::Command
+      class DestroyScopedStyle < Command
         # Public: Initializes the command.
         #
-        # key - the key to destroy inside scoped_styles
+        # key - the key to destroy inside scoped_styles/scoped_admin_styles
         # organization
-        def initialize(key, organization)
+        def initialize(key, organization, config_var = :scoped_styles)
           @key = key
           @organization = organization
+          @config_var = config_var
         end
 
         # Executes the command. Broadcasts these events:
@@ -20,14 +21,15 @@ module Decidim
         #
         # Returns nothing.
         def call
-          styles = AwesomeConfig.find_by(var: :scoped_styles, organization: @organization)
+          styles = AwesomeConfig.find_by(var: @config_var, organization: @organization)
           return broadcast(:invalid, "Not a hash") unless styles&.value.is_a? Hash
           return broadcast(:invalid, "#{key} key invalid") unless styles.value.has_key?(@key)
 
           styles.value.except!(@key)
           styles.save!
           # remove constrains associated (a new config var is generated automatically, by removing it, it will trigger destroy on dependents)
-          constraint = AwesomeConfig.find_by(var: "scoped_style_#{@key}", organization: @organization)
+          constraint = @config_var == :scoped_styles ? :scoped_style : :scoped_admin_style
+          constraint = AwesomeConfig.find_by(var: "#{constraint}_#{@key}", organization: @organization)
           constraint.destroy! if constraint.present?
 
           broadcast(:ok, @key)

data/app/commands/decidim/decidim_awesome/admin/rename_scope_label.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class RenameScopeLabel < Rectify::Command
+      class RenameScopeLabel < Command
         # Public: Initializes the command.
         #
         # params - A constraint params
@@ -34,7 +34,7 @@ module Decidim
             end
           end
 
-          broadcast(:ok, { scope: scope, key: @text })
+          broadcast(:ok, { scope:, key: @text })
         rescue StandardError => e
           broadcast(:invalid, e.message)
         end

data/app/commands/decidim/decidim_awesome/admin/update_config.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class UpdateConfig < Rectify::Command
+      class UpdateConfig < Command
         # Public: Initializes the command.
         #
         # form - A config form
@@ -27,10 +27,9 @@ module Decidim
           begin
             form.attributes.each do |key, val|
               # ignore nil attributes (must specifically be set to false if necessary)
-              next unless form.valid_keys.include?(key)
+              next unless form.valid_keys.include?(key.to_sym)
 
               setting = AwesomeConfig.find_or_initialize_by(var: key, organization: form.current_organization)
-
               setting.value = val.respond_to?(:attributes) ? val.attributes : val
               setting.save!
             end

data/app/commands/decidim/decidim_awesome/admin/update_constraint.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class UpdateConstraint < Rectify::Command
+      class UpdateConstraint < Command
         # Public: Initializes the command.
         #
         # form - A constraint form
@@ -18,7 +18,7 @@ module Decidim
         #
         # Returns nothing.
         def call
-          return broadcast(:invalid) if form.invalid?
+          return broadcast(:invalid, form.errors.full_messages.join(". ")) if form.invalid?
           return broadcast(:invalid) if attributes.blank?
 
           begin
@@ -36,7 +36,7 @@ module Decidim
         attr_reader :form
 
         def attributes
-          form.attributes.filter { |_i, v| v.present? }
+          form.attributes.filter { |key, val| key != "id" && val.present? }
         end
       end
     end

data/app/commands/decidim/decidim_awesome/admin/update_custom_redirect.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class UpdateCustomRedirect < Rectify::Command
+      class UpdateCustomRedirect < Command
         # Public: Initializes the command.
         #
         def initialize(form, item)
@@ -38,8 +38,8 @@ module Decidim
         delegate :to_params, to: :form
 
         def url_exists?
-          return unless redirects
-          return unless redirects.value.is_a? Hash
+          return false unless redirects
+          return false unless redirects.value.is_a? Hash
 
           redirects.value[item.origin].present?
         end

data/app/commands/decidim/decidim_awesome/admin/update_menu_hack.rb

@@ -3,7 +3,7 @@
 module Decidim
   module DecidimAwesome
     module Admin
-      class UpdateMenuHack < Rectify::Command
+      class UpdateMenuHack < Command
         # Public: Initializes the command.
         #
         def initialize(form, menu_name)

data/app/commands/decidim/decidim_awesome/command.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    class Command < ::Decidim::Command
+    end
+  end
+end

data/app/commands/decidim/decidim_awesome/create_editor_image.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module DecidimAwesome
-    class CreateEditorImage < Rectify::Command
+    class CreateEditorImage < Decidim::Command
       # Creates a blueprint.
       #
       # form - The form with the data.
@@ -13,7 +13,7 @@ module Decidim
       # Executes the command. Broadcasts these events:
       #
       # - :ok when everything is valid
-      # - :invalid if the form wasn't valid and we couldn't proceed.
+      # - :invalid if the form wasn't valid, and we couldn't proceed.
       #
       # Returns nothing.
       def call

data/app/controllers/concerns/decidim/decidim_awesome/admin/maintenance_context.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    module Admin
+      module MaintenanceContext
+        extend ActiveSupport::Concern
+
+        included do
+          layout "decidim/decidim_awesome/admin/maintenance"
+          helper_method :current_view, :available_views, :present_private_data
+
+          private
+
+          def present_private_data(model)
+            PrivateDataPresenter.new(model)
+          end
+
+          def current_view
+            return params[:id] if available_views.include?(params[:id])
+
+            available_views.keys.first
+          end
+
+          def available_views
+            {
+              "private_data" => {
+                title: I18n.t("private_data", scope: "decidim.decidim_awesome.admin.menu.maintenance"),
+                icon: "spy-line",
+                path: decidim_admin_decidim_awesome.maintenance_path("private_data")
+              },
+              "checks" => {
+                title: I18n.t("checks", scope: "decidim.decidim_awesome.admin.menu.maintenance"),
+                icon: "pulse",
+                path: decidim_admin_decidim_awesome.checks_maintenance_index_path
+              }
+            }
+          end
+        end
+      end
+    end
+  end
+end

data/app/controllers/concerns/decidim/decidim_awesome/admin_accountability/admin/filterable.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require "active_support/concern"
+
+module Decidim
+  module DecidimAwesome
+    module AdminAccountability
+      module Admin
+        module Filterable
+          extend ActiveSupport::Concern
+
+          included do
+            include Decidim::Admin::Filterable
+
+            helper Decidim::DecidimAwesome::AdminAccountability::Admin::FilterableHelper
+
+            private
+
+            def base_query
+              collection
+            end
+
+            def filters
+              [:role_type_eq, :participatory_space_type_eq]
+            end
+
+            def filters_with_values
+              return { admin_role_type: [] } if global?
+
+              { role_type_eq: role_types, participatory_space_type_eq: participatory_space_types }
+            end
+
+            def dynamically_translated_filters
+              [:role_type_eq, :participatory_space_type_eq]
+            end
+
+            def extra_allowed_params
+              [:per_page, :admins, :admin_role_type]
+            end
+
+            def translated_role_type_eq(role)
+              I18n.t(role, scope: "decidim.decidim_awesome.admin.admin_accountability.roles")
+            end
+
+            def translated_participatory_space_type_eq(item_type)
+              item_type.gsub("UserRole", "").safe_constantize&.model_name&.human&.pluralize || item_type
+            end
+
+            def search_field_predicate
+              :user_name_or_user_email_cont
+            end
+
+            def participatory_space_types
+              @participatory_space_types ||= collection.pluck(:item_type).uniq.sort
+            end
+
+            def role_types
+              @role_types ||= PaperTrailVersion.safe_user_roles.map do |role_class|
+                role_class.safe_constantize.select(:role).distinct.pluck(:role)
+              end.union.flatten.sort
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/app/controllers/concerns/decidim/decidim_awesome/admin_accountability/admin/filterable_helper.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    module AdminAccountability
+      module Admin
+        module FilterableHelper
+          def extra_dropdown_submenu_options_items(_filter, _i18n_scope)
+            Decidim.user_roles.sort.map do |role_type|
+              link_to(I18n.t(role_type, scope: "decidim.decidim_awesome.admin.admin_accountability.admin_roles"),
+                      url_for(export_params.merge({ admin_role_type: role_type })))
+            end
+          end
+
+          def applied_filters_tags(i18n_ctx)
+            admin_role_type = PaperTrailVersion.safe_admin_role_type(params[:admin_role_type])
+            if global? && admin_role_type.present?
+              content_tag(:span, class: "label secondary") do
+                concat "#{i18n_filter_label(:admin_role_type, filterable_i18n_scope_from_ctx(i18n_ctx))}: "
+                concat t("decidim.decidim_awesome.admin.admin_accountability.admin_roles.#{admin_role_type}", default: admin_role_type)
+                concat icon_link_to(
+                  "close-circle-line",
+                  url_for(export_params.except(:admin_role_type)),
+                  t("decidim.admin.actions.cancel"),
+                  class: "action-icon--remove"
+                )
+              end
+            else
+              ransack_params.slice(*filters).map do |filter, value|
+                applied_filter_tag(filter, value, filterable_i18n_scope_from_ctx(i18n_ctx))
+              end.join.html_safe
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/app/controllers/concerns/decidim/decidim_awesome/check_login_authorizations.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    module CheckLoginAuthorizations
+      extend ActiveSupport::Concern
+
+      included do
+        include ::Decidim::DecidimAwesome::NeedsAwesomeConfig
+        before_action :check_required_login_authorizations
+      end
+
+      private
+
+      def check_required_login_authorizations
+        return unless user_signed_in?
+        return unless current_user.confirmed?
+        return if current_user.blocked?
+        return if allowed_controllers.include?(controller_name)
+
+        unless user_is_authorized?
+          flash[:alert] = I18n.t("decidim.decidim_awesome.session.authorization_is_required",
+                                 authorizations: required_authorizations.map(&:fullname).join(", "))
+          redirect_to decidim_decidim_awesome.required_authorizations_path(redirect_url: request.fullpath)
+        end
+      end
+
+      def user_is_authorized?
+        return true if required_authorizations.blank?
+
+        @user_is_authorized ||= if awesome_config[:force_authorization_with_any_method]
+                                  current_authorizations.any?
+                                else
+                                  current_authorizations.count == required_authorizations.count
+                                end
+      end
+
+      def required_authorizations
+        return unless awesome_config[:force_authorization_after_login].is_a?(Array)
+
+        @required_authorizations ||= Decidim::Verifications::Adapter.from_collection(
+          awesome_config[:force_authorization_after_login] & current_organization.available_authorizations & Decidim.authorization_workflows.map(&:name)
+        )
+      end
+
+      def current_authorizations
+        @current_authorizations ||= Decidim::Verifications::Authorizations.new(
+          organization: current_organization,
+          user: current_user,
+          name: required_authorizations.map(&:name),
+          granted: true
+        )
+      end
+
+      def allowed_controllers
+        %w(required_authorizations authorizations upload_validations timeouts editor_images locales pages tos) + awesome_config[:force_authorization_allowed_controller_names].to_a
+      end
+    end
+  end
+end

data/app/controllers/concerns/decidim/decidim_awesome/content_security_policy.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    module ContentSecurityPolicy
+      extend ActiveSupport::Concern
+
+      included do
+        after_action :append_awesome_csp_directives
+      end
+
+      private
+
+      def append_awesome_csp_directives
+        # this is necessary for custom fields
+        content_security_policy.append_csp_directive("font-src", "data:") if DecidimAwesome.enabled?(:proposal_custom_fields)
+        append_awesome_intergram_directives
+      end
+
+      def append_awesome_intergram_directives
+        return unless DecidimAwesome.enabled?(:intergram_for_admins) || DecidimAwesome.enabled?(:intergram_for_public)
+
+        intergram = URI.parse(DecidimAwesome.intergram_url)
+        if intergram.host && intergram.scheme
+          content_security_policy.append_csp_directive("script-src", "#{intergram.scheme}://#{intergram.host}")
+          content_security_policy.append_csp_directive("frame-src", "#{intergram.scheme}://#{intergram.host}")
+          # this script is in the intergram code, but does not look necessary to work
+          # content_security_policy.append_csp_directive("frame-src", "http://www.loadmill.com")
+          # content_security_policy.append_csp_directive("frame-src", "http://app.loadmill.com")
+        end
+      end
+    end
+  end
+end

data/app/controllers/concerns/decidim/decidim_awesome/limit_pending_amendments.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    module LimitPendingAmendments
+      extend ActiveSupport::Concern
+
+      included do
+        # rubocop:disable Rails/LexicallyScopedActionFilter
+        before_action :limit_pending_amendments, only: [:new, :create]
+        # rubocop:enable Rails/LexicallyScopedActionFilter
+
+        private
+
+        def limit_pending_amendments
+          return unless amendable&.amendments && amendable&.component&.settings.try(:limit_pending_amendments)
+          return unless amendable.component.settings.try(:amendments_enabled)
+          return unless amendable.component.current_settings.try(:amendment_creation_enabled)
+
+          return unless existing_emendations.any?
+
+          flash[:alert] = t("pending_limit_reached", scope: "decidim.decidim_awesome.amendments", emendation: translated_attribute(existing_emendations.first.title))
+          redirect_back(fallback_location: Decidim::ResourceLocatorPresenter.new(amendable).path)
+        end
+
+        def existing_emendations
+          @existing_emendations ||= begin
+            existing = amendable.amendments.where(state: :evaluating)
+            existing.filter_map { |amendment| !amendment.emendation&.hidden? && amendment.emendation }
+          end
+        end
+      end
+    end
+  end
+end

data/app/controllers/concerns/decidim/decidim_awesome/needs_awesome_config.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "decidim/decidim_awesome/awesome_helpers"
-
 module Decidim
   module DecidimAwesome
     module NeedsAwesomeConfig

data/app/controllers/concerns/decidim/decidim_awesome/not_found_redirect.rb

@@ -43,14 +43,14 @@ module Decidim
           return unless redirects.is_a? Hash
 
           path, query = fullpath.split("?")
-          destination = redirects.dig(path.downcase, "destination")
-          pass_query = redirects.dig(path.downcase, "pass_query")
+          destination = redirects.dig(path, "destination")
+          pass_query = redirects.dig(path, "pass_query")
           if pass_query.present?
             union = destination.include?("?") ? "&" : "?"
             destination = "#{destination}#{union}#{query}"
           end
 
-          return destination.strip if destination.present?
+          destination.strip if destination.present?
         end
       end
     end