decidim-core 0.29.4 → 0.30.0.rc1

data/app/jobs/decidim/open_data_job.rb

@@ -4,13 +4,13 @@ module Decidim
   class OpenDataJob < ApplicationJob
     queue_as :exports
 
-    def perform(organization)
-      path = Rails.root.join("tmp/#{organization.open_data_file_path}")
+    def perform(organization, resource = nil)
+      path = Rails.root.join("tmp/#{organization.open_data_file_path(resource)}")
 
-      exporter = OpenDataExporter.new(organization, path)
+      exporter = OpenDataExporter.new(organization, path, resource)
       raise "Could not generate Open Data export" unless exporter.export.positive?
 
-      organization.open_data_file.attach(io: File.open(path, "rb"), filename: organization.open_data_file_path)
+      organization.open_data_files.attach(io: File.open(path, "rb"), filename: organization.open_data_file_path(resource))
       # Deletes the temporary file file
       File.delete(path)
     end

data/app/mailers/decidim/export_mailer.rb

@@ -8,21 +8,16 @@ module Decidim
     # zipped file.
     #
     # user        - The user to be notified.
-    # export_name - The name of the export.
-    # export_data - The data containing the result of the export.
+    # private_export - The PrivateExport instance where the export data has been attached.
     #
     # Returns nothing.
-    def export(user, export_name, export_data)
+    def export(user, private_export)
       @user = user
       @organization = user.organization
-
-      filename = export_data.filename(export_name)
-      filename_without_extension = export_data.filename(export_name, extension: false)
-
-      attachments["#{filename_without_extension}.zip"] = FileZipper.new(filename, export_data.read).zip
+      @private_export = private_export
 
       with_user(user) do
-        mail(to: "#{user.name} <#{user.email}>", subject: I18n.t("decidim.export_mailer.subject", name: filename))
+        mail(to: "#{user.name} <#{user.email}>", subject: I18n.t("decidim.export_mailer.subject", name: private_export.export_type))
       end
     end
 
@@ -30,13 +25,13 @@ module Decidim
     # the result of a download_your_data export in a zipped file.
     #
     # user - The user to be notified.
+    # private_export - The PrivateExport instance where the export data has been attached.
     #
     # Returns nothing.
-    def download_your_data_export(user, filename, password)
+    def download_your_data_export(user, private_export)
       @user = user
       @organization = user.organization
-      @filename = filename
-      @password = password
+      @private_export = private_export
 
       with_user(user) do
         mail(to: "#{user.name} <#{user.email}>", subject: I18n.t("decidim.export_mailer.subject", name: user.name))

data/app/mailers/decidim/notifications_digest_mailer.rb

@@ -14,13 +14,7 @@ module Decidim
         @organization = user.organization
         @notifications_digest = Decidim::NotificationsDigestPresenter.new(user)
         @display_see_more_message = notifications.size > SIZE_LIMIT
-        # Note that this could be improved by adding a "type" column to the notifications table
-        # This fix can generate lists of notifications that are below the SIZE_LIMIT
-        @notifications = notifications[0...SIZE_LIMIT].filter_map do |notification|
-          next unless notification.event_class_instance.respond_to?(:email_intro)
-
-          Decidim::NotificationToMailerPresenter.new(notification)
-        end
+        @notifications = notifications[0...SIZE_LIMIT].map { |notification| Decidim::NotificationToMailerPresenter.new(notification) }
 
         mail(to: user.email, subject: @notifications_digest.subject)
       end

data/app/mailers/decidim/reported_mailer.rb

@@ -21,29 +21,13 @@ module Decidim
       end
     end
 
-    # This is used when a user with special rights (like an administrator, a space administrator or a moderator) hides a resource
-    def hidden_manually(user, report, current_user)
+    def hide(user, report)
       with_user(user) do
         @report = report
         @participatory_space = @report.moderation.participatory_space
-        @reportable = @report.moderation.reportable
-        @organization = user.organization
-        @user = user
-        @moderator = current_user
-        subject = I18n.t("hidden_manually.subject", scope: "decidim.reported_mailer", moderator: @moderator.name)
-        mail(to: user.email, subject:)
-      end
-    end
-
-    # This is meant to be used when a resource is hidden by an algorithm, such as the `decidim-ai` module, or the `Decidim.max_reports_before_hiding` feature.
-    def hidden_automatically(user, report)
-      with_user(user) do
-        @report = report
-        @participatory_space = @report.moderation.participatory_space
-        @reportable = @report.moderation.reportable
         @organization = user.organization
         @user = user
-        subject = I18n.t("hidden_automatically.subject", scope: "decidim.reported_mailer")
+        subject = I18n.t("hide.subject", scope: "decidim.reported_mailer")
         mail(to: user.email, subject:)
       end
     end

data/app/models/decidim/action_log.rb

@@ -5,6 +5,7 @@ module Decidim
   # for transparency reasons, to log all actions so all other users can
   # see the actions being performed.
   class ActionLog < ApplicationRecord
+    include Decidim::Taxonomizable
     include Decidim::ScopableParticipatorySpace
 
     belongs_to :organization,
@@ -156,7 +157,15 @@ module Decidim
 
     def self.publicable_public_resource_types
       @publicable_public_resource_types ||= public_resource_types
-                                            .select { |klass| klass.constantize.column_names.include?("published_at") }
+                                            .select { |klass| klass.constantize.column_names.include?("published_at") } - publicable_exceptions
+    end
+
+    def self.publicable_exceptions
+      @publicable_exceptions = %w(
+        Decidim::Blogs::Post
+      ).select do |klass|
+        klass.safe_constantize.present?
+      end
     end
 
     def self.ransackable_scopes(auth_object = nil)
@@ -167,6 +176,16 @@ module Decidim
       base + [:with_participatory_space]
     end
 
+    def self.ransackable_attributes(auth_object = nil)
+      return [] unless auth_object&.admin?
+
+      %w(created_at)
+    end
+
+    def self.ransackable_associations(_auth_object = nil)
+      %w(user)
+    end
+
     # Overwrites the method so that records cannot be modified.
     #
     # Returns a Boolean.

data/app/models/decidim/category.rb

@@ -47,6 +47,10 @@ module Decidim
     # Allow ransacker to search for a key in a hstore column (`name`.`en`)
     ransacker_i18n :name
 
+    def self.ransackable_attributes(_auth_object = nil)
+      %w(description id name)
+    end
+
     private
 
     # This is done since we only allow one level of subcategories.

data/app/models/decidim/component.rb

@@ -6,11 +6,14 @@ module Decidim
   # component that spans over several steps.
   class Component < ApplicationRecord
     include HasSettings
+    include HasTaxonomySettings
     include Publicable
     include Traceable
     include Loggable
     include Decidim::ShareableWithToken
     include ScopableComponent
+    include Decidim::SoftDeletable
+    include TranslatableAttributes
 
     belongs_to :participatory_space, polymorphic: true
 
@@ -19,7 +22,7 @@ module Decidim
 
     default_scope { registered_component_manifests.registered_space_manifests.order(arel_table[:weight].asc, arel_table[:manifest_name].asc) }
 
-    delegate :organization, :categories, to: :participatory_space
+    delegate :organization, to: :participatory_space
 
     def self.log_presenter_class_for(_log)
       Decidim::AdminLog::ComponentPresenter
@@ -61,7 +64,7 @@ module Decidim
       {
         :host => organization.host,
         :component_id => id,
-        "#{participatory_space.underscored_name}_slug".to_sym => participatory_space.slug
+        :"#{participatory_space.underscored_name}_slug" => participatory_space.slug
       }
     end
 
@@ -82,6 +85,14 @@ module Decidim
       name
     end
 
+    def hierarchy_title
+      [
+        I18n.t("decidim.admin.menu.#{participatory_space.class.name.demodulize.underscore.pluralize}"),
+        translated_attribute(participatory_space.title),
+        translated_attribute(name)
+      ].join(" / ")
+    end
+
     # Public: Returns an empty description
     def resource_description; end
 
@@ -92,9 +103,20 @@ module Decidim
       participatory_space.can_participate?(user)
     end
 
+    def private_non_transparent_space?
+      return false unless participatory_space.respond_to?(:private_space?)
+      return false unless participatory_space.private_space?
+
+      if participatory_space.respond_to?(:is_transparent?)
+        !participatory_space.is_transparent?
+      else
+        true
+      end
+    end
+
     # Public: Public URL for component with given share token as query parameter
     def shareable_url(share_token)
-      EngineRouter.main_proxy(self).root_path(self, share_token: share_token.token)
+      EngineRouter.main_proxy(self).root_url(self, share_token: share_token.token)
     end
 
     delegate :serializes_specific_data?, to: :manifest

data/app/models/decidim/metric.rb

@@ -9,6 +9,7 @@ module Decidim
     belongs_to :participatory_space, foreign_type: "participatory_space_type", polymorphic: true, optional: true
     belongs_to :related_object, foreign_type: "related_object_type", polymorphic: true, optional: true
     belongs_to :category, foreign_key: "decidim_category_id", class_name: "Decidim::Category", optional: true
+    belongs_to :taxonomy, foreign_key: "decidim_taxonomy_id", class_name: "Decidim::Taxonomy", optional: true
 
     validates :day, uniqueness: { scope:
                                   [
@@ -18,7 +19,7 @@ module Decidim
                                     :participatory_space_id,
                                     :related_object_type,
                                     :related_object_id,
-                                    :decidim_category_id
+                                    :decidim_taxonomy_id
                                   ] }
   end
 end

data/app/models/decidim/moderation.rb

@@ -30,5 +30,21 @@ module Decidim
     ransacker :reportable_type_string do
       Arel.sql(%{cast("decidim_moderations"."decidim_reportable_type" as text)})
     end
+
+    def self.ransackable_attributes(_auth_object = nil)
+      %w(reported_id_string reported_content created_at)
+    end
+
+    def self.ransackable_associations(_auth_object = nil)
+      []
+    end
+
+    def title
+      return reportable.reported_title if reportable.respond_to?(:reported_title)
+      return reportable.title if reportable.respond_to?(:title)
+      return reportable.name if reportable.respond_to?(:name)
+
+      reportable.id.to_s
+    end
   end
 end

data/app/models/decidim/newsletter.rb

@@ -26,23 +26,23 @@ module Decidim
       sent_at.present?
     end
 
-    def sent_scopes_ids
-      extended_data["scope_ids"] || []
+    def sent_to_all_users?
+      extended_data["send_to_all_users"]
     end
 
-    def sent_scopes
-      @sent_scopes ||= organization.scopes.where(id: sent_scopes_ids)
+    def sent_to_verified_users?
+      extended_data["send_to_verified_users"]
     end
 
-    def sended_to_all_users?
-      extended_data["send_to_all_users"]
+    def sent_to_users_with_verification_types
+      extended_data["verification_types"]
     end
 
-    def sended_to_followers?
+    def sent_to_followers?
       extended_data["send_to_followers"]
     end
 
-    def sended_to_participants?
+    def sent_to_participants?
       extended_data["send_to_participants"]
     end
 
@@ -50,6 +50,10 @@ module Decidim
       extended_data["participatory_space_types"]
     end
 
+    def sent_to_private_members?
+      extended_data["send_to_private_members"]
+    end
+
     def template
       @template ||= Decidim::ContentBlock
                     .for_scope(:newsletter_template, organization:)

data/app/models/decidim/organization.rb

@@ -35,6 +35,8 @@ module Decidim
 
     has_many :templates, foreign_key: "decidim_organization_id", class_name: "Decidim::Templates::Template", dependent: :destroy if defined? Decidim::Templates
 
+    has_many :taxonomies, foreign_key: "decidim_organization_id", class_name: "Decidim::Taxonomy", inverse_of: :organization, dependent: :destroy
+
     # Users registration mode. Whether users can register or access the system. Does not affect users that access through Omniauth integrations.
     #  enabled: Users registration and sign in are enabled (default value).
     #  existing: Users cannot be registered in the system. Only existing users can sign in.
@@ -58,7 +60,7 @@ module Decidim
     has_one_attached :highlighted_content_banner_image
     validates_upload :highlighted_content_banner_image, uploader: Decidim::ImageUploader
 
-    has_one_attached :open_data_file
+    has_many_attached :open_data_files
 
     validate :unique_name
 
@@ -148,8 +150,10 @@ module Decidim
       !users_registration_mode_disabled?
     end
 
-    def open_data_file_path
-      "#{host}-open-data.zip"
+    def open_data_file_path(resource = nil)
+      return "#{host}-open-data.zip" if resource.nil?
+
+      "#{host}-open-data-#{resource}.csv"
     end
 
     def enabled_omniauth_providers

data/app/models/decidim/participatory_space_private_user.rb

@@ -5,15 +5,25 @@ module Decidim
   class ParticipatorySpacePrivateUser < ApplicationRecord
     include Decidim::DownloadYourData
     include ParticipatorySpaceUser
+    include Decidim::TranslatableResource
 
     belongs_to :privatable_to, polymorphic: true
 
+    translatable_fields :role
+
+    delegate :email, :name, to: :user
+
     scope :by_participatory_space, ->(privatable_to) { where(privatable_to_id: privatable_to.id, privatable_to_type: privatable_to.class.to_s) }
+    scope :published, -> { where(published: true) }
 
     def self.user_collection(user)
       where(decidim_user_id: user.id)
     end
 
+    def self.private_user_ids_for_participatory_spaces(spaces)
+      joins(:user).where(privatable_to: spaces).distinct.pluck(:decidim_user_id)
+    end
+
     def self.export_serializer
       Decidim::DownloadYourDataSerializers::DownloadYourDataParticipatorySpacePrivateUserSerializer
     end
@@ -26,6 +36,16 @@ module Decidim
       Arel.sql(%{("invitation_sent_at")::text})
     end
 
+    def self.ransackable_attributes(auth_object = nil)
+      return [] unless auth_object&.admin?
+
+      %w(name nickname email invitation_accepted_at last_sign_in_at invitation_sent_at role)
+    end
+
+    def self.ransackable_associations(_auth_object = nil)
+      %w(user)
+    end
+
     def target_space_association = :privatable_to
   end
 end

data/app/models/decidim/private_export.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Decidim
+  class PrivateExport < ApplicationRecord
+    belongs_to :attached_to, polymorphic: true
+
+    has_one_attached :file
+    validates :content_type, presence: true
+
+    before_validation :set_content_type_and_size, if: :attached?
+    delegate :attached?, to: :file
+
+    default_scope { order(created_at: :desc) }
+
+    def expired?
+      expires_at < Time.zone.now
+    end
+
+    def set_content_type_and_size
+      self.content_type = file.content_type
+      self.file_size = file.byte_size
+    end
+  end
+end

data/app/models/decidim/push_notification_message.rb

@@ -26,7 +26,7 @@ module Decidim
     end
 
     def url
-      EngineRouter.new("decidim", {}).public_send(:conversation_path, host: organization.host, id: @conversation)
+      EngineRouter.new("decidim", {}).conversation_path(host: organization.host, id: @conversation)
     end
 
     private

data/app/models/decidim/report.rb

@@ -5,7 +5,7 @@ module Decidim
   class Report < ApplicationRecord
     include Decidim::DownloadYourData
 
-    REASONS = %w(spam offensive does_not_belong hidden_during_block parent_hidden).freeze
+    REASONS = %w(spam offensive does_not_belong hidden_during_block).freeze
 
     belongs_to :moderation, foreign_key: "decidim_moderation_id", class_name: "Decidim::Moderation"
     belongs_to :user, foreign_key: "decidim_user_id", class_name: "Decidim::User"

data/app/models/decidim/scope.rb

@@ -76,6 +76,10 @@ module Decidim
     # Allow ransacker to search for a key in a hstore column (`name`.`en`)
     ransacker_i18n :name
 
+    def self.ransackable_attributes(_auth_object = nil)
+      %w(name id)
+    end
+
     private
 
     def forbid_cycles

data/app/models/decidim/share_token.rb

@@ -2,33 +2,63 @@
 
 module Decidim
   class ShareToken < ApplicationRecord
-    validates :token, presence: true, uniqueness: { scope: [:decidim_organization_id, :token_for_type, :token_for_id] }
+    include Decidim::Traceable
 
     belongs_to :organization, foreign_key: "decidim_organization_id", class_name: "Decidim::Organization"
     belongs_to :user, foreign_key: "decidim_user_id", class_name: "Decidim::User"
     belongs_to :token_for, foreign_type: "token_for_type", polymorphic: true
 
-    after_initialize :generate, :set_default_expiration
+    validates :token, presence: true, uniqueness: { scope: [:decidim_organization_id, :token_for_type, :token_for_id] }
+    # validates token no spaces or strange characters
+    validates :token, format: { with: /\A[a-zA-Z0-9_-]+\z/ }
+
+    after_initialize :generate
+
+    def self.log_presenter_class_for(_log)
+      Decidim::AdminLog::ShareTokenPresenter
+    end
 
-    def self.use!(token_for:, token:)
+    def self.use!(token_for:, token:, user: nil)
       record = find_by!(token_for:, token:)
-      record.use!
+      record.use!(user:)
     end
 
-    def use!
+    def use!(user: nil)
       return raise StandardError, "Share token '#{token}' for '#{token_for_type}' with id = #{token_for_id} has expired." if expired?
+      return raise StandardError, "Share token '#{token}' for '#{token_for_type}' with id = #{token_for_id} requires a registered user." if registered_only? && user.nil?
 
       update!(times_used: times_used + 1, last_used_at: Time.zone.now)
     end
 
     def expired?
-      expires_at.past?
+      expires_at.past? unless expires_at.nil?
     end
 
     def url
       token_for.shareable_url(self)
     end
 
+    def participatory_space
+      return token_for if token_for.try(:manifest).is_a?(Decidim::ParticipatorySpaceManifest)
+      return token_for.participatory_space if token_for.respond_to?(:participatory_space)
+
+      component&.participatory_space
+    end
+
+    def component
+      return token_for if token_for.is_a?(Decidim::Component)
+
+      token_for.component if token_for.respond_to?(:component)
+    end
+
+    def self.ransackable_attributes(_auth_object = nil)
+      %w(token expires_at last_used_at registered_only times_used)
+    end
+
+    def self.ransackable_associations(_auth_object = nil)
+      %w(organization token_for user)
+    end
+
     private
 
     def generate
@@ -39,9 +69,5 @@ module Decidim
         break if ShareToken.find_by(token:).blank?
       end
     end
-
-    def set_default_expiration
-      self.expires_at ||= 1.day.from_now
-    end
   end
 end

data/app/models/decidim/taxonomization.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Decidim
+  # Represents the link between a taxonomy and any taxonomizable entity.
+  class Taxonomization < ApplicationRecord
+    belongs_to :taxonomy,
+               class_name: "Decidim::Taxonomy",
+               counter_cache: :taxonomizations_count,
+               inverse_of: :taxonomizations
+
+    belongs_to :taxonomizable, polymorphic: true
+
+    validate :prevent_root_taxonomization
+
+    private
+
+    def prevent_root_taxonomization
+      return unless taxonomy.root?
+
+      errors.add(:taxonomy, :invalid)
+    end
+  end
+end