decidim-core 0.28.2 → 0.29.0.rc2

data/lib/decidim/core.rb

@@ -53,6 +53,8 @@ module Decidim
   autoload :Menu, "decidim/menu"
   autoload :MenuItem, "decidim/menu_item"
   autoload :MenuRegistry, "decidim/menu_registry"
+  autoload :AdminFilter, "decidim/admin_filter"
+  autoload :AdminFiltersRegistry, "decidim/admin_filters_registry"
   autoload :ManifestRegistry, "decidim/manifest_registry"
   autoload :AssetRouter, "decidim/asset_router"
   autoload :EngineRouter, "decidim/engine_router"
@@ -102,7 +104,6 @@ module Decidim
   autoload :ShareableWithToken, "decidim/shareable_with_token"
   autoload :RecordEncryptor, "decidim/record_encryptor"
   autoload :AttachmentAttributes, "decidim/attachment_attributes"
-  autoload :CarrierWaveMigratorService, "decidim/carrier_wave_migrator_service"
   autoload :ReminderRegistry, "decidim/reminder_registry"
   autoload :ReminderManifest, "decidim/reminder_manifest"
   autoload :ManifestMessages, "decidim/manifest_messages"
@@ -124,6 +125,14 @@ module Decidim
   autoload :IconRegistry, "decidim/icon_registry"
   autoload :HasConversations, "decidim/has_conversations"
 
+  module Commands
+    autoload :CreateResource, "decidim/commands/create_resource"
+    autoload :UpdateResource, "decidim/commands/update_resource"
+    autoload :DestroyResource, "decidim/commands/destroy_resource"
+    autoload :ResourceHandler, "decidim/commands/resource_handler"
+    autoload :HookError, "decidim/commands/hook_error"
+  end
+
   include ActiveSupport::Configurable
   # Loads seeds from all engines.
   def self.seed!
@@ -171,7 +180,7 @@ module Decidim
 
   def self.seed_gamification_badges!
     Gamification.badges.each do |badge|
-      puts "Setting random values for the \"#{badge.name}\" badge..."
+      puts "Setting random values for the \"#{badge.name}\" badge..." # rubocop:disable Rails/Output
       User.all.find_each do |user|
         Gamification::BadgeScore.find_or_create_by!(
           user:,
@@ -305,7 +314,7 @@ module Decidim
     end
   end
 
-  # Exposes a configuration option: the whitelist ips
+  # Exposes a configuration option: the IPs that are allowed to access the system
   config_accessor :system_accesslist_ips do
     []
   end
@@ -432,7 +441,7 @@ module Decidim
     ";"
   end
 
-  # Exposes a configuration option: HTTP_X_FORWADED_HOST header follow-up.
+  # Exposes a configuration option: HTTP_X_FORWARDED_HOST header follow-up.
   # If a caching system is in place, it can also allow cache and log poisoning attacks,
   # allowing attackers to control the contents of caches and logs that could be used for other attacks.
   config_accessor :follow_http_x_forwarded_host do
@@ -552,6 +561,11 @@ module Decidim
     %w(terms-of-service)
   end
 
+  # The default max last activity users to be shown
+  config_accessor :default_max_last_activity_users do
+    6
+  end
+
   # List of additional content security policies to be appended to the default ones
   # This is useful for adding custom CSPs for external services like Here Maps, YouTube, etc.
   # Read more: https://docs.decidim.org/en/develop/configure/initializer#_content_security_policy
@@ -757,6 +771,10 @@ module Decidim
     @icons ||= Decidim::IconRegistry.new
   end
 
+  def self.admin_filter(name, &)
+    AdminFiltersRegistry.register(name.to_sym, &)
+  end
+
   # Public: Stores an instance of ViewHooks
   def self.view_hooks
     @view_hooks ||= ViewHooks.new
@@ -821,11 +839,11 @@ module Decidim
   end
 
   def self.register_assets_path(path)
-    Rails.autoloaders.main.ignore(path) if Rails.configuration.autoloader == :zeitwerk
+    Rails.autoloaders.main.ignore(path)
   end
 
   # Checks if a particular decidim gem is installed and needed by this
-  # particular instance. Preferrably this happens through bundler by inspecting
+  # particular instance. Preferably this happens through bundler by inspecting
   # the Gemfile of the instance but when Decidim is used without bundler, this
   # will check:
   # 1. If the gem is globally available or not in the loaded specs, i.e. the

data/lib/decidim/dependency_resolver.rb

@@ -86,7 +86,7 @@ module Decidim
       File.exist?(path)
     end
 
-    # Checks if the module for the gem speficiation has been loaded through
+    # Checks if the module for the gem specification has been loaded through
     # `require "decidim/foo"`.
     #
     # @param spec [Bundler::LazySpecification, Gem::Specification, String] The
@@ -179,8 +179,8 @@ module Decidim
       # @yield [dependency] Yields each dependency to be processed to the
       #   provided block to check if that dependency needs to be processed or
       #   not.
-      # @yieldparam [Gem::Dependency] The runtime dependency being processed.
-      # @yieldreturn [Boolean] A boolean indicating whether this dependency
+      # @yield param [Gem::Dependency] The runtime dependency being processed.
+      # @yield return [Boolean] A boolean indicating whether this dependency
       #   needs to be processed or not. True indicates it needs to be processed
       #   and false indicates processing is not needed.
       # @return [Bundler::LazySpecification, nil] The specification for the gem

data/lib/decidim/diffy_extension.rb

@@ -23,7 +23,7 @@ module Decidim
       end
     end
 
-    # The private "split" method SplitDiff needs to be overriden to take into
+    # The private "split" method SplitDiff needs to be overridden to take into
     # account the new :unescaped_html format, and the fact that the tags
     # <ins> <del> are not there anymore
     Diffy::SplitDiff.module_eval do

data/lib/decidim/download_your_data_serializers/download_your_data_user_serializer.rb

@@ -5,6 +5,7 @@ module Decidim
   module DownloadYourDataSerializers
     class DownloadYourDataUserSerializer < Decidim::Exporters::Serializer
       include Decidim::ResourceHelper
+      include Decidim::TranslatableAttributes
 
       # Public: Exports a hash with the serialized data for this user.
       def serialize
@@ -16,7 +17,7 @@ module Decidim
           locale: resource.locale,
           organization: {
             id: resource.organization.try(:id),
-            name: resource.organization.try(:name)
+            name: translated_attribute(resource.organization.try(:name))
           },
           newsletter_notifications_at: resource.newsletter_notifications_at,
           notifications_sending_frequency: resource.notifications_sending_frequency,

data/lib/decidim/engine_router.rb

@@ -42,12 +42,12 @@ module Decidim
       route_helper?(method_name) || super
     end
 
-    def method_missing(method_name, *args)
+    def method_missing(method_name, *)
       return super unless route_helper?(method_name)
 
       filter_slug_params!(method_name)
 
-      send(engine).send(method_name, *args)
+      send(engine).send(method_name, *)
     end
 
     private

data/lib/decidim/events/base_event.rb

@@ -77,6 +77,25 @@ module Decidim
 
       def resource_text; end
 
+      # The cell that will be used to render the action or nil if not action needs to be rendered.
+      #
+      # @return [nil] - if no action needs to be rendered
+      # @return [String] - if String, it is the cell to be rendered. Make it return with "decidim/notification_actions/buttons"
+      #                    in your event implementation to render the buttons cell
+      def action_cell; end
+
+      # The data that will be passed to the action cell
+      #
+      # @return [nil] - If no data needs to be rendered
+      # @return [Array<Hash{Symbol => String}>] - For the buttons cell, it should be an array of hashes with the following keys:
+      #   - url: the URL to which the button will point
+      #   - label: the label of the button (optional if i18n_label is present)
+      #   - i18n_label: the i18n key of the label (optional if label is present)
+      #   - icon: the icon of the button (optional)
+      #   - method: the HTTP method of the request (optional)
+      #   - class: the class of the button (optional)
+      def action_data; end
+
       def organization
         resource.try(:organization)
       end

data/lib/decidim/events/simple_event.rb

@@ -11,6 +11,7 @@ module Decidim
       include Decidim::Events::EmailEvent
       include Decidim::Events::NotificationEvent
       include Decidim::ComponentPathHelper
+      include Decidim::OrganizationHelper
 
       delegate :created_at, to: :resource
 

data/lib/decidim/exporters/export_manifest.rb

@@ -32,7 +32,7 @@ module Decidim
       end
 
       # Public: Sets the +collection block+ when a block is given, or returns
-      # the previously setted +collection block+ if no block is provided.
+      # the previously set +collection block+ if no block is provided.
       #
       # The +collection block+ knows how to obtain the collection of elements
       # to be serialized by the +Serializer+.

data/lib/decidim/faker/localized.rb

@@ -135,9 +135,9 @@ module Decidim
         end.with_indifferent_access
       end
 
-      # Wrapps a text build by the block with some other text.
+      # Wraps a text build by the block with some other text.
       #
-      # before - The String text to inject at the begining of each value.
+      # before - The String text to inject at the beginning of each value.
       # after  - The String text to inject at the end of each value.
       # block  - A Block that generates a Hash with a text for each locale.
       #
@@ -164,7 +164,7 @@ module Decidim
       end
 
       # Runs the given block for each of the available locales in Decidim,
-      # momentarilly setting the locale to the current one.
+      # momentarily setting the locale to the current one.
       #
       # Returns a Hash with a value for each locale.
       def self.localized

data/lib/decidim/form_builder.rb

@@ -122,7 +122,7 @@ module Decidim
     def hashtaggable_text_field(type, name, locale, options = {})
       options[:hashtaggable] = true if type.to_sym == :editor
 
-      content_tag(:div, class: "hashtags__container") do
+      content_tag(:div) do
         if options[:value]
           send(type, name_with_locale(name, locale), options.merge(label: options[:label], value: options[:value][locale]))
         else
@@ -202,7 +202,7 @@ module Decidim
 
       content_tag(
         :div,
-        class: "editor #{"hashtags__container" if editor_options[:editor]["class"].include?("js-hashtags")}",
+        class: "editor",
         id: "#{sanitize_for_dom_selector(@object_name)}_#{sanitize_for_dom_selector(name)}"
       ) do
         template = ""
@@ -416,9 +416,9 @@ module Decidim
     # options      - A Hash with options to build the field.
     #              * max_file_size: Maximum size for the file (If you really want to change max
     #                 file size you should probably change it in validator).
-    #              * resouce_name: Name of the resource (e.g. user)
+    #              * resource_name: Name of the resource (e.g. user)
     #              * resource_class: Attribute's resource class (e.g. Decidim::User)
-    #              * resouce_class: Class of the resource (e.g. user)
+    #              * resource_class: Class of the resource (e.g. user)
     #              * required: Whether the file is required or not (false by default).
     #              * titled: Whether the file can have title or not.
     #              * show_current: Whether the current file is displayed next to the button.

data/lib/decidim/hashtag.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Decidim
-  # A hasthag is used to categorize components
+  # A hashtag is used to categorize components
   class Hashtag < ApplicationRecord
     self.table_name = "decidim_hashtags"
 

data/lib/decidim/jsonb_attributes.rb

@@ -4,7 +4,7 @@ require "active_support/concern"
 
 module Decidim
   # A set of convenient methods to generate dynamic jsonb objects in a way is
-  # compatible with AttirubteObject and ActiveModel thus making it easy to
+  # compatible with AttributeObject and ActiveModel thus making it easy to
   # integrate into Rails forms and similar workflows.
   module JsonbAttributes
     extend ActiveSupport::Concern
@@ -20,15 +20,15 @@ module Decidim
       #   jsonb_attribute(:settings, [[:custom_setting, String], [:another_setting, Boolean])
       #   # This will generate `custom_setting`, `custom_setting=` and
       #   # `another_setting`, `another_setting=` and will keep them
-      #   # syncronized with a hash in `settings`:
+      #   # synchronized with a hash in `settings`:
       #   # settings = { "custom_setting" => "demo", "another_setting" => "demo"}
       #
       # Returns nothing.
-      def jsonb_attribute(name, fields, *options)
+      def jsonb_attribute(name, fields, *)
         attribute(name, { String => Object }, default: {})
 
         fields.each do |f, type|
-          attribute f, type, *options
+          attribute(f, type, *)
           define_method f do
             field = public_send(name) || {}
             field[f.to_s] || field[f.to_sym]

data/lib/decidim/manifest_messages.rb

@@ -16,8 +16,8 @@ module Decidim
       @store[key] = block
     end
 
-    def render(key, context = nil, **extra)
-      context.instance_exec(**extra, &@store[key]) if @store[key]
+    def render(key, context = nil, **)
+      context.instance_exec(**, &@store[key]) if @store[key]
     end
   end
 end

data/lib/decidim/organization_settings.rb

@@ -79,7 +79,7 @@ module Decidim
       #   Decidim.organization_settings(org).target_config_accessor
       #   #=> returns the organization specific setting
       #
-      #   Decidim.organization_settings(model_beloging_to_org).target_config_accessor
+      #   Decidim.organization_settings(model_belonging_to_org).target_config_accessor
       #   #=> returns the organization specific setting for model's organization
       #
       #   Decidim.organization_settings(nil).target_config_accessor
@@ -104,9 +104,9 @@ module Decidim
         {
           "upload" => {
             "allowed_file_extensions" => {
-              "default" => %w(jpg jpeg png pdf rtf txt),
-              "admin" => %w(jpg jpeg png pdf doc docx xls xlsx ppt pptx ppx rtf txt odt ott odf otg ods ots),
-              "image" => %w(jpg jpeg png)
+              "default" => %w(jpg jpeg png webp pdf rtf txt),
+              "admin" => %w(jpg jpeg png webp pdf doc docx xls xlsx ppt pptx ppx rtf txt odt ott odf otg ods ots),
+              "image" => %w(jpg jpeg png webp)
             },
             "allowed_content_types" => {
               "default" => %w(
@@ -190,7 +190,7 @@ module Decidim
 
     private
 
-    # Generates a final settigns configuration struct from the given settings
+    # Generates a final settings configuration struct from the given settings
     # hash. Combines the given defaults with the settings hash.
     #
     # @param hash [Hash] The configurations hash.

data/lib/decidim/paddable.rb

@@ -59,7 +59,7 @@ module Decidim
         @pad_id ||= [reference, token].join("-").slice(0, 50)
       end
 
-      # compatibilize with old versions if no salt available (less secure)
+      # compatibility with old versions if no salt available (less secure)
       def token
         if defined?(salt) && salt.present?
           tokenizer = Decidim::Tokenizer.new(salt:)

data/lib/decidim/participable.rb

@@ -31,7 +31,7 @@ module Decidim
 
       def mounted_params
         {
-          host: organization.host,
+          :host => organization.host,
           "#{underscored_name}_slug".to_sym => slug
         }
       end

data/lib/decidim/participatory_space_manifest.rb

@@ -98,7 +98,7 @@ module Decidim
     #
     # Returns nothing.
     def seed!
-      print "Creating seeds for the #{name} space...\n" unless Rails.env.test?
+      print "Creating seeds for the #{name} space...\n" unless Rails.env.test? # rubocop:disable Rails/Output
       @seeds&.call
     end
 

data/lib/decidim/resourceable.rb

@@ -111,7 +111,7 @@ module Decidim
       end
 
       # Check only the resource visibility not its hierarchy.
-      # This method is intended to be overriden by classes that include this module and have the
+      # This method is intended to be overridden by classes that include this module and have the
       # need to impose its own visibility rules.
       #
       # @return If the resource is also Publicable checks if the resource is published, otherwise returns true by default.

data/lib/decidim/search_resource_fields_mapper.rb

@@ -13,8 +13,8 @@ module Decidim
     #
     # @param declared_fields: A Hash with the mappings between a SearchableResource attributes and
     #    any given model. Mapped fields are:
-    # - scope_id: The field where the scope is setted in the model, if any.
-    # - participatory_space: The field where the ParticipatorySpace is setted in the model.
+    # - scope_id: The field where the scope is set in the model, if any.
+    # - participatory_space: The field where the ParticipatorySpace is set in the model.
     # - datetime: The field that describes where in time the model is placed.
     # - A, B, C, D: Weighted text fields.
     #

data/lib/decidim/searchable.rb

@@ -74,7 +74,7 @@ module Decidim
       after_destroy do |searchable|
         remove_from_index(searchable) if self.class.search_resource_fields_mapper
       end
-      # after_create and after_update callbacks are dynamically setted in `searchable_fields` method.
+      # after_create and after_update callbacks are dynamically set in `searchable_fields` method.
 
       # Public: after_create callback to index the model as a SearchableResource, if configured so.
       #
@@ -178,8 +178,8 @@ module Decidim
       # }
       #
       # `conditions` must be a Hash that only accepts a boolean or a Proc that will be evaluated on runtime and returns a boolean for the following keys:
-      # - index_on_create: Whether to index, or not, the current searchabe when it is created. Defaults to true.
-      # - index_on_update: Whether to index, or not, the current searchabe when it is updated. Defaults to true.
+      # - index_on_create: Whether to index, or not, the current searchable when it is created. Defaults to true.
+      # - index_on_update: Whether to index, or not, the current searchable when it is updated. Defaults to true.
       #
       def searchable_fields(declared_fields, conditions = {})
         @search_resource_indexable_fields = SearchResourceFieldsMapper.new(declared_fields)

data/lib/decidim/seeds.rb

@@ -17,6 +17,27 @@ module Decidim
       @admin_user ||= Decidim::User.find_by(organization:, email: "admin@example.org")
     end
 
+    def find_or_initialize_user_by(email:)
+      user = Decidim::User.find_or_initialize_by(email:)
+      user.update!(
+        name: ::Faker::Name.name,
+        nickname: ::Faker::Twitter.unique.screen_name,
+        password: "decidim123456789",
+        organization:,
+        confirmed_at: Time.current,
+        locale: I18n.default_locale,
+        personal_url: ::Faker::Internet.url,
+        about: ::Faker::Lorem.paragraph(sentence_count: 2),
+        avatar: random_avatar,
+        accepted_tos_version: organization.tos_version + 1.hour,
+        newsletter_notifications_at: Time.current,
+        tos_agreement: true,
+        password_updated_at: Time.current
+      )
+
+      user
+    end
+
     def random_scope(participatory_space:)
       if participatory_space.scope
         scopes = participatory_space.scope.descendants
@@ -86,10 +107,51 @@ module Decidim
       )
     end
 
+    def create_report!(reportable:, current_user:)
+      moderation = Moderation.find_or_create_by!(reportable:, participatory_space: reportable.participatory_space)
+
+      Decidim::Report.create!(
+        moderation:,
+        user: current_user,
+        locale: I18n.locale,
+        reason: "spam",
+        details: "From the seeds"
+      )
+    rescue ActiveRecord::RecordInvalid
+      # Ignore in case we have an error in the report creation.
+      # Most likely is a "Validation failed: User has already been taken"
+    end
+
+    def hide_report!(reportable:)
+      moderation = Moderation.find_or_create_by!(reportable:, participatory_space: reportable.participatory_space)
+      moderation.update!(hidden_at: Time.zone.now)
+    end
+
+    def create_user_report!(reportable:, current_user:)
+      moderation = UserModeration.find_or_create_by!(user: reportable)
+
+      UserReport.create!(
+        moderation:,
+        user: current_user,
+        reason: "spam",
+        details: "From the seeds"
+      )
+    end
+
     def seed_components_manifests!(participatory_space:)
       Decidim.component_manifests.each do |manifest|
         manifest.seed!(participatory_space.reload)
       end
     end
+
+    def random_avatar
+      file_number = format("%03d", rand(1...100))
+
+      create_blob!(seeds_file: "avatars/#{file_number}.jpg", filename: "#{file_number}.jpg", content_type: "image/jpeg")
+    end
+
+    def create_follow!(user, followable)
+      Decidim::Follow.create!(followable:, user:)
+    end
   end
 end

data/lib/decidim/stats_registry.rb

@@ -40,7 +40,7 @@ module Decidim
     # Public: Returns a number returned by executing the corresponding block.
     #
     # name - The name of the stat
-    # context - An arbritrary context object to compute the result.
+    # context - An arbitrary context object to compute the result.
     # start_at - A date to filter resources created after it
     # end_at - A date to filter resources created before it.
     #
@@ -54,7 +54,7 @@ module Decidim
 
     # Public: Resolves every stat with the given context and return an enumerator
     #
-    # context - An arbritrary context object to compute the result.
+    # context - An arbitrary context object to compute the result.
     # start_at - A date to filter resources created after it
     # end_at - A date to filter resources created before it
     #

data/lib/decidim/translatable_attributes.rb

@@ -17,7 +17,7 @@ module Decidim
       # type - The attribute's type
       # options - Options to send to the form class when defining the attribute.
       # block - An optional block to be called for each attribute name and
-      # locale. The block will receive two arguments, one with the attriubte
+      # locale. The block will receive two arguments, one with the attribute
       # name and another with the locale.
       #
       #
@@ -34,12 +34,12 @@ module Decidim
       #   end
       #
       # Returns nothing.
-      def translatable_attribute(name, type, **options)
+      def translatable_attribute(name, type, **)
         attribute(name, { String => Object }, default: {})
 
         locales.each do |locale|
           attribute_name = "#{name}_#{locale}".gsub("-", "__")
-          attribute attribute_name, type, **options
+          attribute(attribute_name, type, **)
 
           define_method attribute_name do
             field = public_send(name) || {}

data/lib/decidim/translatable_resource.rb

@@ -19,7 +19,7 @@ module Decidim
           method_name = "#{field}="
 
           # We are overriding the attribute setter method so that we can reuse the
-          # machine translations. This is to fix a bug encoutered when updating
+          # machine translations. This is to fix a bug encountered when updating
           # the resource from a FormObject. The FormObject on the `#create`
           # action in the controller does not have the machine translations loaded,
           # so they are effectively lost whenever a resource is updated.

data/lib/decidim/view_hooks.rb

@@ -87,7 +87,7 @@ module Decidim
     # Internal class to encapsulate each view registered on a view hook.
     class ViewHook
       # priority - a Number (Integer|Float) to sort the block.
-      # block - a block that will bbe rendered in a view context.
+      # block - a block that will be rendered in a view context.
       def initialize(priority, block)
         @priority = priority
         @block = block

data/lib/decidim/view_model.rb

@@ -17,8 +17,12 @@ module Decidim
     include Decidim::MarkupHelper
     include Decidim::LayoutHelper
     include Decidim::SanitizeHelper
+    include Decidim::ApplicationHelper
+    include Decidim::IconHelper
 
+    delegate :helper_method, to: :controller
     delegate :current_organization, to: :controller
+    delegate_missing_to :view_context
 
     cache :show, if: :perform_caching?, expires_in: :cache_expiry_time do
       cache_hash

data/lib/decidim/webpacker/esbuild.config.js

@@ -0,0 +1,14 @@
+// eslint-disable-next-line no-undef
+module.exports = {
+  options: {
+    tsconfigRaw: JSON.stringify({}),
+    target: "es2015"
+  },
+  bundle: true,
+  sourcemap: true,
+  minify: true,
+  outdir: "public",
+  outExtension: {
+    ".css": ".scss"
+  }
+};

data/lib/decidim/webpacker/shakapacker.yml

@@ -22,12 +22,12 @@ default: &default
   cache_manifest: false
 
   # Select loader to use, available options are 'babel' (default), 'swc' or 'esbuild'
-  webpack_loader: 'babel'
+  webpack_loader: 'esbuild'
 
   # Set to true to enable check for matching versions of shakapacker gem and NPM package - will raise an error if there is a mismatch or wildcard versioning is used
   ensure_consistent_versioning: true
 
-  # Select whether the compiler will use SHA digest ('digest' option) or most most recent modified timestamp ('mtime') to determine freshness
+  # Select whether the compiler will use SHA digest ('digest' option) or most recent modified timestamp ('mtime') to determine freshness
   compiler_strategy: digest
 
   # Select whether the compiler will always use a content hash and not just in production

data/lib/decidim/webpacker/tsconfig.json

@@ -0,0 +1,11 @@
+{
+  "compilerOptions": {
+    "strict": true,                                      /* Enable all strict type-checking options. */
+    "removeComments": true,                              /* Disable emitting comments. */
+    "allowJs": true,                                     /* Allow JavaScript files to be a part of your program. Use the `checkJS` option to get errors from these files. */
+    "module": "commonjs",                                /* Specify what module code is generated. */
+    "incremental": true,                                 /* Enable incremental compilation */
+    "target": "es6",                                     /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "skipLibCheck": true,                                /* Skip type checking all .d.ts files. */
+  }
+}