decidim-core 0.28.1 → 0.29.0.rc1

data/app/models/decidim/attachment.rb

@@ -9,6 +9,7 @@ module Decidim
     include Traceable
 
     before_save :set_content_type_and_size, if: :attached?
+    before_validation :set_link_content_type_and_size, if: :link?
 
     translatable_fields :title, :description
     belongs_to :attachment_collection, class_name: "Decidim::AttachmentCollection", optional: true
@@ -61,15 +62,33 @@ module Decidim
       !photo?
     end
 
+    # Whether this attachment is a link or not.
+    #
+    # Returns Boolean.
+    def link?
+      link.present?
+    end
+
     # Which kind of file this is.
     #
     # Returns String.
     def file_type
-      url&.split(".")&.last&.downcase
+      if file?
+        url&.split(".")&.last&.downcase
+      elsif link?
+        "link"
+      end
     end
 
+    # The URL that points to the attachment
+    #
+    # Returns String.
     def url
-      attached_uploader(:file).path
+      if file?
+        attached_uploader(:file).path
+      elsif link?
+        link
+      end
     end
 
     # The URL to download the thumbnail of the file. Only works with images.
@@ -95,6 +114,11 @@ module Decidim
       self.file_size = file.byte_size
     end
 
+    def set_link_content_type_and_size
+      self.content_type = "text/uri-list"
+      self.file_size = 0
+    end
+
     def self.log_presenter_class_for(_log)
       Decidim::AdminLog::AttachmentPresenter
     end

data/app/models/decidim/authorization.rb

@@ -101,7 +101,7 @@ module Decidim
       @workflow_manifest ||= Decidim::Verifications.find_workflow_manifest(name)
     end
 
-    # Calculates when this authorization can be reseted, if desired.
+    # Calculates when this authorization can be reset, if desired.
     #
     # **time_between_renewals** is defined in `workflow_manifest.time_between_renewals`
     # defaults to 1 day

data/app/models/decidim/authorization_transfer.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Rails/HelperInstanceVariable
 module Decidim
   # An authorization transfer object is created when the user authorizes
   # themselves with the same unique ID as some other user had used in the past.

data/app/models/decidim/component.rb

@@ -56,8 +56,8 @@ module Decidim
     # Public: The hash of contextual params when the component is mounted.
     def mounted_params
       {
-        host: organization.host,
-        component_id: id,
+        :host => organization.host,
+        :component_id => id,
         "#{participatory_space.underscored_name}_slug".to_sym => participatory_space.slug
       }
     end

data/app/models/decidim/content_block.rb

@@ -134,7 +134,7 @@ module Decidim
       images_container.save
     end
 
-    # On instance reloading we need to remove the `images_cointainer` cached
+    # On instance reloading we need to remove the `images_container` cached
     # class so it gets regenerated with the new values.
     def reload_images
       @images_container = nil

data/app/models/decidim/messaging/message.rb

@@ -34,7 +34,7 @@ module Decidim
 
       #
       # Associates receipts for this message for each of the given users,
-      # including also a receipt for the remitent (sender) of the message.
+      # including also a receipt for the remittant (sender) of the message.
       # Receipts are unread by default, except for the sender's receipt.
       #
       # If the sender is a UserGroup then receipts will be created for its managers
@@ -64,7 +64,7 @@ module Decidim
 
       private
 
-      # returns all posible recipients from a list of users or groups
+      # returns all possible recipients from a list of users or groups
       def all_recipients(recipients)
         users = recipients.flat_map do |recipient|
           recipient.is_a?(UserGroup) ? recipient.managers : recipient

data/app/models/decidim/newsletter.rb

@@ -46,7 +46,7 @@ module Decidim
       extended_data["send_to_participants"]
     end
 
-    def sended_to_partipatory_spaces
+    def sent_to_participatory_spaces
       extended_data["participatory_space_types"]
     end
 
@@ -56,16 +56,16 @@ module Decidim
                     .find_by(scoped_resource_id: id)
     end
 
-    def url(**kwargs)
-      proxy_url(:newsletter_url, id:, **kwargs)
+    def url(**)
+      proxy_url(:newsletter_url, id:, **)
     end
 
-    def notifications_settings_url(**kwargs)
-      proxy_url(__method__, **kwargs)
+    def notifications_settings_url(**)
+      proxy_url(__method__, **)
     end
 
-    def unsubscribe_newsletters_url(**kwargs)
-      proxy_url(__method__, **kwargs)
+    def unsubscribe_newsletters_url(**)
+      proxy_url(__method__, **)
     end
 
     def organization_official_url
@@ -82,10 +82,10 @@ module Decidim
       errors.add(:author, :invalid) unless author.organization == organization
     end
 
-    def proxy_url(method, **kwargs)
+    def proxy_url(method, **)
       return "#" unless sent?
 
-      router.public_send(method, host: organization.host, **kwargs)
+      router.public_send(method, host: organization.host, **)
     end
 
     def router

data/app/models/decidim/notification.rb

@@ -9,12 +9,12 @@ module Decidim
 
     # Daily notifications should contain all notifications within the previous
     # day from the given day.
-    scope :daily, ->(time: Time.now.utc) { where(created_at: (time - 1.day).all_day) }
+    scope :daily, ->(time = Time.now.utc) { where(created_at: (time - 1.day).all_day) }
 
     # Weekly notifications should contain all notifications within the previous
     # week counting from the end of the previous day until the start of the day
     # 1 week ago from the previous day.
-    scope :weekly, lambda { |time: Time.now.utc|
+    scope :weekly, lambda { |time = Time.now.utc|
       end_of_previous_day = (time - 1.day).end_of_day
       where(created_at: (end_of_previous_day - 7.days).beginning_of_day..end_of_previous_day)
     }

data/app/models/decidim/organization.rb

@@ -15,7 +15,7 @@ module Decidim
     SOCIAL_HANDLERS = [:twitter, :facebook, :instagram, :youtube, :github].freeze
     AVAILABLE_MACHINE_TRANSLATION_DISPLAY_PRIORITIES = %w(original translation).freeze
 
-    translatable_fields :description, :cta_button_text, :omnipresent_banner_title, :omnipresent_banner_short_description,
+    translatable_fields :name, :description, :cta_button_text, :omnipresent_banner_title, :omnipresent_banner_short_description,
                         :highlighted_content_banner_title, :highlighted_content_banner_short_description, :highlighted_content_banner_action_title,
                         :highlighted_content_banner_action_subtitle, :welcome_notification_subject, :welcome_notification_body, :id_documents_explanation_text,
                         :admin_terms_of_service_body
@@ -41,7 +41,7 @@ module Decidim
     #  disable: Users cannot register or sign in.
     enum users_registration_mode: [:enabled, :existing, :disabled], _prefix: true
 
-    validates :name, :host, uniqueness: true
+    validates :host, uniqueness: true
     validates :reference_prefix, presence: true
     validates :time_zone, presence: true, time_zone: true
     validates :default_locale, inclusion: { in: :available_locales }
@@ -60,6 +60,27 @@ module Decidim
 
     has_one_attached :open_data_file
 
+    validate :unique_name
+
+    def unique_name
+      base_query = new_record? ? Decidim::Organization.all : Decidim::Organization.where.not(id:).all
+
+      organization_names = []
+
+      base_query.pluck(:name).each do |value|
+        organization_names += value.except("machine_translations").values
+        organization_names += value.fetch("machine_translations", {}).values
+      end
+
+      organization_names = organization_names.map(&:downcase).compact_blank
+
+      name.each do |language, value|
+        next if value.is_a?(Hash)
+
+        errors.add("name_#{language}", :taken) if organization_names.include?(value.downcase)
+      end
+    end
+
     def self.log_presenter_class_for(_log)
       Decidim::AdminLog::OrganizationPresenter
     end

data/app/models/decidim/push_notification_message.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Decidim
-  # A messsage from a conversation that will be sent as a push notification
+  # A message from a conversation that will be sent as a push notification
   class PushNotificationMessage
     class InvalidActionError < StandardError; end
 

data/app/models/decidim/resource_link.rb

@@ -7,7 +7,7 @@ module Decidim
   # In order to group the relations between resources you need to specify a name.
   #
   # Some examples could be: proposals that have been created in a meeting or
-  # projects that are a result of merging diffrent proposals.
+  # projects that are a result of merging different proposals.
   class ResourceLink < ApplicationRecord
     belongs_to :from, polymorphic: true
     belongs_to :to, polymorphic: true

data/app/models/decidim/user.rb

@@ -311,8 +311,8 @@ module Decidim
     private
 
     # Changes default Devise behaviour to use ActiveJob to send async emails.
-    def send_devise_notification(notification, *args)
-      devise_mailer.send(notification, self, *args).deliver_later
+    def send_devise_notification(notification, *)
+      devise_mailer.send(notification, self, *).deliver_later
     end
 
     def all_roles_are_valid

data/app/models/decidim/user_group.rb

@@ -202,13 +202,13 @@ module Decidim
       document_number.present?
     end
 
-    # Overwites method in `Decidim::Validatable`, as user groups do not have a
+    # Overrides method in `Decidim::Validatable`, as user groups do not have a
     # password.
     def password_required?
       false
     end
 
-    # Overwites method in `Decidim::Validatable`, as user groups do not have a
+    # Overrides method in `Decidim::Validatable`, as user groups do not have a
     # password.
     def password
       nil

data/app/packs/src/decidim/a11y.js

@@ -104,6 +104,20 @@ const createDropdown = (component) => {
     });
   }
 
+  // Disable focus on children elements so we can pass the AXE accessibility tests
+  const dropdownMenu = document.getElementById(dropdownOptions.dropdown);
+  if (dropdownMenu.getAttribute("aria-hidden") === "true") {
+    dropdownMenu.
+      querySelectorAll("a, input, button").
+      forEach((element) => { element.tabIndex = -1 })
+  }
+
+  component.addEventListener("click", () => {
+    dropdownMenu.
+      querySelectorAll("a, input, button").
+      forEach((element) => { element.tabIndex = 0 })
+  })
+
   Dropdowns.render(component.id, dropdownOptions);
 }
 
@@ -176,10 +190,56 @@ const createDialog = (component) => {
   })
 }
 
+/**
+ * Announces a message to the screen reader dynamically.
+ *
+ * This should not be called consecutively multiple times because the screen
+ * reader may not read all the messages if the content is changed quickly.
+ *
+ * @param {String} message The message to be announced
+ * @param {String} mode The mode for the announcement, either "assertive"
+ *   (default) or "polite".
+ * @return {void}
+ */
+const announceForScreenReader = (message, mode = "assertive") => {
+  if (!message || typeof message !== "string" || message.length < 1) {
+    return;
+  }
+
+  let element = document.getElementById("screen-reader-announcement");
+  if (!element) {
+    element = document.createElement("div");
+    element.setAttribute("id", "screen-reader-announcement");
+    element.classList.add("sr-only");
+    element.setAttribute("aria-atomic", true);
+    document.body.append(element);
+  }
+  if (mode === "polite") {
+    element.setAttribute("aria-live", mode);
+  } else {
+    element.setAttribute("aria-live", "assertive");
+  }
+
+  element.innerHTML = "";
+
+  setTimeout(() => {
+    // Wrap the text in a span with a random attribute value that changes every
+    // time to try to indicate to the screen reader the content has changed. This
+    // helps reading the message aloud if the message is exactly the same as the
+    // last time.
+    const randomIdentifier = `announcement-${new Date().getUTCMilliseconds()}-${Math.floor(Math.random() * 10000000)}`;
+    const announce = document.createElement("span")
+    announce.setAttribute("data-random", randomIdentifier);
+    announce.textContent = message;
+    element.append(announce);
+  }, 100);
+};
+
 export {
   createAccordion,
   createDialog,
   createDropdown,
+  announceForScreenReader,
   Accordions,
   Dialogs,
   Dropdowns

data/app/packs/src/decidim/abide_form_validator_fixer.js

@@ -0,0 +1,44 @@
+/**
+ * This script modifies the behavior of Abide form validation to address the issue of form validation errors
+ * appearing prematurely in input fields.
+ *
+ * The primary goal is to hide error messages until the input field loses focus.
+ */
+
+class AbideFormValidatorFixer {
+  initialize() {
+    const forms = document.querySelectorAll("main [data-live-validate='true']");
+
+    forms.forEach((form) => {
+      if (this.isElementVisible(form)) {
+        this.setupForm(form);
+      }
+    });
+  }
+
+  isElementVisible(element) {
+    return element.offsetParent !== null && getComputedStyle(element).display !== "none";
+  }
+
+  setupForm(form) {
+    const inputs = form.querySelectorAll("input");
+
+    inputs.forEach((input) => {
+      const errorElement = input.closest("label")?.querySelector(".form-error") || input.parentElement.querySelector(".form-error");
+      if (!errorElement) {
+        return;
+      }
+      form.removeAttribute("data-live-validate");
+      input.addEventListener("input", this.hideErrorElement.bind(this, errorElement));
+    });
+  }
+
+  hideErrorElement(errorElement) {
+    errorElement.classList.remove("is-visible");
+  }
+}
+
+document.addEventListener("DOMContentLoaded", () => {
+  const validatorFixer = new AbideFormValidatorFixer();
+  validatorFixer.initialize();
+});

data/app/packs/src/decidim/attachments/file_or_link_tabs.js

@@ -0,0 +1,55 @@
+/**
+ * This file controls the behavior of the |File| and |Link| tabs in the
+ * attachment form. It disables the |File| tab when a link is present and
+ * vice versa.
+ */
+
+const getFileButton = (container) =>
+  container.querySelector("button#trigger-file");
+const getLinkButton = (container) =>
+  container.querySelector("button#trigger-link");
+const getLinkInput = (container) =>
+  container.querySelector("input#attachment_link");
+const getUploadsContainer = (container) =>
+  container.querySelector("div[data-active-uploads]");
+
+const hasUploads = (container) => container.querySelectorAll("div").length > 0;
+
+const updateTabsState = (container) => {
+  const fileButton = getFileButton(container);
+  const linkButton = getLinkButton(container);
+  const linkInput = getLinkInput(container);
+  const uploadsContainer = getUploadsContainer(container);
+
+  const disableFileButton = Boolean(linkInput?.value);
+  const disableLinkButton = hasUploads(uploadsContainer);
+
+  fileButton.disabled = disableFileButton;
+  linkButton.disabled = disableLinkButton;
+};
+
+const initializeTabs = (container) => {
+  const linkInput = getLinkInput(container);
+  const uploadsContainer = getUploadsContainer(container);
+
+  linkInput.addEventListener("change", () => {
+    updateTabsState(container);
+  });
+
+  uploadsContainer.addEventListener("DOMSubtreeModified", () => {
+    updateTabsState(container);
+    console.log("DOMSubtreeModified");
+  });
+
+  updateTabsState(container);
+};
+
+document.addEventListener("DOMContentLoaded", () => {
+  const tabs = document.querySelectorAll(
+    "div[data-file-or-link-tabs-controller]"
+  );
+
+  tabs.forEach((container) => {
+    initializeTabs(container);
+  });
+});

data/app/packs/src/decidim/attachments/index.js

@@ -0,0 +1 @@
+import "src/decidim/attachments/file_or_link_tabs"

data/app/packs/src/decidim/back_to_list.js

@@ -2,7 +2,7 @@
  * Changes "Back to list" links to the one saved in sessionStorage API
  * To apply this to a link, at least one element must have the class "js-back-to-list".
  * For this to work it needs the filteredParams in SessionStorage, that is saved on FormFilterComponent.
- * @param {NodeList} links - Hyperlinks elements that point to the filters page that will use the fitererd params
+ * @param {NodeList} links - Hyperlinks elements that point to the filters page that will use the filtered params
  * @returns {void}
  */
 export default function backToListLink(links) {

data/app/packs/src/decidim/check_boxes_tree.js

@@ -22,7 +22,7 @@ export default class CheckBoxesTree {
   /**
    * Set checkboxes as checked if included in given values
    * @public
-   * @param {Array} checkboxes - array of checkboxs to check
+   * @param {Array} checkboxes - array of checkboxes to check
    * @param {Array} values - values of checkboxes that should be checked
    * @returns {Void} - Returns nothing.
    */

data/app/packs/src/decidim/data_consent/consent_manager.js

@@ -75,7 +75,7 @@ class ConsentManager {
 
   triggerWarnings() {
     document.querySelectorAll(".disabled-iframe").forEach((original) => {
-      if (original.querySelector(".dataconsent-warning")) {
+      if (original.querySelector("[data-dataconsent-warning]")) {
         return;
       }
 

data/app/packs/src/decidim/data_consent/consent_manager.test.js

@@ -75,7 +75,7 @@ describe("ConsentManager", () => {
             <div class="dc-switch">
               <input class="switch-input" checked="checked" id="dc-essential" type="checkbox" name="essential" disabled="">
               <label class="switch-paddle" for="dc-essential">
-                <span class="show-for-sr">Toggle Essential</span>
+                <span>Toggle Essential</span>
               </label>
             </div>
           </div>
@@ -119,7 +119,7 @@ describe("ConsentManager", () => {
             <div class="dc-switch">
               <input class="switch-input" id="dc-preferences" type="checkbox" name="preferences">
               <label class="switch-paddle" for="dc-preferences">
-                <span class="show-for-sr">Toggle Preferences</span>
+                <span>Toggle Preferences</span>
               </label>
             </div>
           </div>
@@ -139,7 +139,7 @@ describe("ConsentManager", () => {
             <div class="dc-switch">
               <input class="switch-input" id="dc-analytics" type="checkbox" name="analytics">
               <label class="switch-paddle" for="dc-analytics">
-                <span class="show-for-sr">Toggle Analytics and statistics</span>
+                <span>Toggle Analytics and statistics</span>
               </label>
             </div>
           </div>
@@ -159,7 +159,7 @@ describe("ConsentManager", () => {
             <div class="dc-switch">
               <input class="switch-input" id="dc-marketing" type="checkbox" name="marketing">
               <label class="switch-paddle" for="dc-marketing">
-                <span class="show-for-sr">Toggle Marketing</span>
+                <span>Toggle Marketing</span>
               </label>
             </div>
           </div>
@@ -182,7 +182,7 @@ describe("ConsentManager", () => {
     </div>
   `;
   const cookieWarningContent = `
-    <div class="dataconsent-warning padding-1 hide">
+    <div data-dataconsent-warning class="hide">
       <p>You need to enable all cookies in order to see this content.</p>
       <a href="#" class="button margin-vertical-2" data-open="dc-modal">
         Change cookie settings
@@ -226,7 +226,7 @@ describe("ConsentManager", () => {
       modal: modal,
       categories: categories,
       cookieName: "decidim-consent",
-      warningElement: document.querySelector(".dataconsent-warning")
+      warningElement: document.querySelector("[data-dataconsent-warning]")
     });
   });
 

data/app/packs/src/decidim/data_consent/index.js

@@ -78,7 +78,7 @@ document.addEventListener("DOMContentLoaded", () => {
     modal: modal,
     categories: categories,
     cookieName: window.Decidim.config.get("consent_cookie_name"),
-    warningElement: document.querySelector(".dataconsent-warning")
+    warningElement: document.querySelector("[data-dataconsent-warning]")
   });
 
   initDisabledIframes(manager);