decidim-core 0.27.4 → 0.27.6

data/lib/decidim/core/test/shared_examples/amendable/amendment_created_event_examples.rb

@@ -12,36 +12,16 @@ shared_examples "amendment created event" do
   end
 
   it_behaves_like "a simple event"
+  it_behaves_like "a simple event email"
+  it_behaves_like "a simple event notification"
 
   let(:emendation_author_nickname) { "@#{emendation.creator_author.nickname}" }
   let(:emendation_path) { Decidim::ResourceLocatorPresenter.new(emendation).path }
   let(:emendation_author_path) { Decidim::UserPresenter.new(emendation.creator_author).profile_path }
   let(:amendable_path) { Decidim::ResourceLocatorPresenter.new(amendable).path }
 
-  describe "email_subject" do
-    it "is generated correctly" do
-      expect(subject.email_subject).to eq("New amendment for #{amendable_title}")
-    end
-  end
-
-  describe "email_intro" do
-    it "is generated correctly" do
-      expect(subject.email_intro)
-        .to eq("A new amendment has been created for #{amendable_title}. You can see it from this page:")
-    end
-  end
-
-  describe "email_outro" do
-    it "is generated correctly" do
-      expect(subject.email_outro)
-        .to eq("You have received this notification because you are following #{amendable_title}. You can stop receiving notifications following the previous link.")
-    end
-  end
-
-  describe "notification_title" do
-    it "is generated correctly" do
-      expect(subject.notification_title)
-        .to eq("A new amendment has been created for <a href=\"#{amendable_path}\">#{amendable_title}</a>.")
-    end
-  end
+  let(:email_subject) { "New amendment for #{amendable_title}" }
+  let(:email_intro) { "A new amendment has been created for #{amendable_title}. You can see it from this page:" }
+  let(:email_outro) { "You have received this notification because you are following #{amendable_title}. You can stop receiving notifications following the previous link." }
+  let(:notification_title) { "A new amendment has been created for <a href=\"#{amendable_path}\">#{amendable_title}</a>." }
 end

data/lib/decidim/core/test/shared_examples/amendable/amendment_promoted_event_examples.rb

@@ -7,36 +7,18 @@ shared_examples "amendment promoted event" do
   let(:event_name) { "decidim.events.amendments.amendment_promoted" }
 
   it_behaves_like "a simple event"
+  it_behaves_like "a simple event email"
+  it_behaves_like "a simple event notification"
 
   let(:emendation_author_nickname) { "@#{emendation.creator_author.nickname}" }
   let(:emendation_path) { Decidim::ResourceLocatorPresenter.new(emendation).path }
   let(:emendation_author_path) { Decidim::UserPresenter.new(emendation.creator_author).profile_path }
   let(:amendable_path) { Decidim::ResourceLocatorPresenter.new(amendable).path }
 
-  describe "email_subject" do
-    it "is generated correctly" do
-      expect(subject.email_subject).to eq("An amendment from #{emendation_author_nickname} has been published as a new proposal")
-    end
-  end
-
-  describe "email_intro" do
-    it "is generated correctly" do
-      expect(subject.email_intro)
-        .to eq("A rejected amendment for #{amendable_title} has been published as a new #{amendable_type}. You can see it from this page:")
-    end
-  end
-
-  describe "email_outro" do
-    it "is generated correctly" do
-      expect(subject.email_outro)
-        .to eq("You have received this notification because you are following #{amendable_title}. You can stop receiving notifications following the previous link.")
-    end
-  end
-
-  describe "notification_title" do
-    it "is generated correctly" do
-      expect(subject.notification_title)
-        .to eq("A <a href=\"#{emendation_path}\">rejected amendment</a> for <a href=\"#{amendable_path}\">#{amendable_title}</a> has been published as a new #{amendable_type} by <a href=\"#{emendation_author_path}\">#{emendation_author_nickname}</a>.") # rubocop:disable Layout/LineLength
-    end
-  end
+  let(:email_subject) { "An amendment from #{emendation_author_nickname} has been published as a new proposal" }
+  let(:email_intro) { "A rejected amendment for #{amendable_title} has been published as a new #{amendable_type}. You can see it from this page:" }
+  let(:email_outro) { "You have received this notification because you are following #{amendable_title}. You can stop receiving notifications following the previous link." }
+  # rubocop:disable Layout/LineLength
+  let(:notification_title) { "A <a href=\"#{emendation_path}\">rejected amendment</a> for <a href=\"#{amendable_path}\">#{amendable_title}</a> has been published as a new #{amendable_type} by <a href=\"#{emendation_author_path}\">#{emendation_author_nickname}</a>." }
+  # rubocop:enable Layout/LineLength
 end

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -48,6 +48,38 @@ shared_examples "comments" do
     expect(page).to have_css(".comments > div:nth-child(2)", text: "Most Rated Comment")
   end
 
+  context "when there are comments and replies" do
+    let!(:single_comment) { create(:comment, commentable: commentable) }
+    let!(:reply) { create(:comment, commentable: single_comment, root_commentable: commentable) }
+
+    it "displays the show replies link on comment with reply" do
+      visit resource_path
+      expect(page).not_to have_content("Comments are disabled at this time")
+      expect(page).to have_css(".comment", minimum: 1)
+
+      within "#comment_#{single_comment.id}" do
+        expect(page).to have_content "Hide replies"
+      end
+    end
+
+    context "when there is a comment with the same parent id but different type with replies" do
+      let!(:other_component) { create(:component, manifest_name: :dummy, organization: organization) }
+      let!(:other_commentable) { create(:dummy_resource, component: other_component, author: user, id: single_comment.id) }
+      let!(:reply) { create(:comment, commentable: other_commentable, root_commentable: other_commentable) }
+      let!(:other_reply) { create(:comment, commentable: reply, root_commentable: other_commentable) }
+
+      it "displays the show replies link on comment with reply" do
+        visit resource_path
+        expect(page).not_to have_content("Comments are disabled at this time")
+        expect(page).to have_css(".comment", minimum: 1)
+
+        within "#comment_#{single_comment.id}" do
+          expect(page).not_to have_content "Hide replies"
+        end
+      end
+    end
+  end
+
   context "when there are deleted comments" do
     let(:deleted_comment) { comments[0] }
 
@@ -838,5 +870,29 @@ shared_examples "comments" do
         expect(page).to have_link "#decidim", href: "/search?term=%23decidim"
       end
     end
+
+    describe "export_serializer" do
+      let(:comment) { comments.first }
+
+      it "returns the serializer for the comment" do
+        expect(comment.class.export_serializer).to eq(Decidim::Comments::CommentSerializer)
+      end
+
+      context "with instance" do
+        subject { comment.class.export_serializer.new(comment).serialize }
+
+        it { is_expected.to have_key(:id) }
+        it { is_expected.to have_key(:created_at) }
+        it { is_expected.to have_key(:body) }
+        it { is_expected.to have_key(:locale) }
+        it { is_expected.to have_key(:author) }
+        it { is_expected.to have_key(:alignment) }
+        it { is_expected.to have_key(:depth) }
+        it { is_expected.to have_key(:user_group) }
+        it { is_expected.to have_key(:commentable_id) }
+        it { is_expected.to have_key(:commentable_type) }
+        it { is_expected.to have_key(:root_commentable_url) }
+      end
+    end
   end
 end

data/lib/decidim/core/test/shared_examples/embed_resource_examples.rb

@@ -1,5 +1,50 @@
 # frozen_string_literal: true
 
+require "decidim/admin/test/admin_participatory_space_access_examples"
+
+shared_examples "rendering the embed page correctly" do
+  before do
+    visit widget_path
+  end
+
+  it "renders" do
+    if resource.title.is_a?(Hash)
+      expect(page).to have_i18n_content(resource.title)
+    else
+      expect(page).to have_content(resource.title)
+    end
+
+    expect(page).to have_content(organization.name)
+  end
+end
+
+shared_examples "rendering the embed link in the resource page" do
+  before do
+    visit resource_locator(resource).path
+  end
+
+  it "has the embed link" do
+    expect(page).to have_button("Embed")
+  end
+end
+
+shared_examples "showing the unauthorized message in the widget_path" do
+  it do
+    visit widget_path
+    expect(page).to have_content "You are not authorized to perform this action"
+  end
+end
+
+shared_examples "not rendering the embed link in the resource page" do
+  before do
+    visit resource_locator(resource).path
+  end
+
+  it "does not have the embed link" do
+    expect(page).to have_no_button("Embed")
+  end
+end
+
 shared_examples_for "an embed resource" do |options|
   if options.is_a?(Hash) && options[:skip_space_checks]
     let(:organization) { resource.organization }
@@ -11,22 +56,29 @@ shared_examples_for "an embed resource" do |options|
     include_context "with a component"
   end
 
-  context "when visiting the embed page for a resource" do
-    before do
-      visit resource_locator(resource).path
-      visit "#{current_path}/embed"
-    end
+  unless options.is_a?(Hash) && options[:skip_publication_checks]
+    context "when the resource is not published" do
+      before do
+        resource.unpublish!
+      end
+
+      it_behaves_like "not rendering the embed link in the resource page"
 
-    it "renders the page correctly" do
-      if resource.title.is_a?(Hash)
-        expect(page).to have_i18n_content(resource.title)
-      else
-        expect(page).to have_content(resource.title)
+      it_behaves_like "a 404 page" do
+        let(:target_path) { widget_path }
       end
+    end
+  end
+
+  it_behaves_like "rendering the embed link in the resource page" unless options.is_a?(Hash) && options[:skip_link_checks]
 
-      expect(page).to have_content(organization.name)
+  context "when visiting the embed page for a resource" do
+    before do
+      visit widget_path
     end
 
+    it_behaves_like "rendering the embed page correctly"
+
     unless options.is_a?(Hash) && options[:skip_space_checks]
       context "when the participatory_space is a process" do
         it "shows the process name" do
@@ -47,3 +99,127 @@ shared_examples_for "an embed resource" do |options|
     end
   end
 end
+
+shared_examples_for "a private embed resource" do
+  let(:organization) { resource.organization }
+  let!(:other_user) { create(:user, :confirmed, organization: organization) }
+  let!(:participatory_space_private_user) { create(:participatory_space_private_user, user: other_user, privatable_to: resource) }
+
+  before do
+    switch_to_host(organization.host)
+  end
+
+  context "when the resource is private" do
+    before do
+      resource.update!(private_space: true)
+      resource.update!(is_transparent: false) if resource.respond_to?(:is_transparent)
+    end
+
+    context "and user is a visitor" do
+      let(:user) { nil }
+
+      it_behaves_like "not rendering the embed link in the resource page"
+
+      it_behaves_like "a 404 page" do
+        let(:target_path) { widget_path }
+      end
+    end
+
+    context "and user is a registered user" do
+      let(:user) { create(:user, :confirmed, organization: organization) }
+
+      before do
+        sign_in user, scope: :user
+      end
+
+      it_behaves_like "not rendering the embed link in the resource page"
+
+      it_behaves_like "a 404 page" do
+        let(:target_path) { widget_path }
+      end
+    end
+
+    context "and user is a private user" do
+      let(:user) { other_user }
+
+      before do
+        sign_in user, scope: :user
+      end
+
+      it_behaves_like "a 404 page" do
+        let(:target_path) { widget_path }
+      end
+    end
+  end
+end
+
+shared_examples_for "a transparent private embed resource" do
+  let(:organization) { resource.organization }
+  let!(:other_user) { create(:user, :confirmed, organization: organization) }
+  let!(:participatory_space_private_user) { create(:participatory_space_private_user, user: other_user, privatable_to: resource) }
+
+  before do
+    switch_to_host(organization.host)
+  end
+
+  context "when the resource is private" do
+    before do
+      resource.update!(private_space: true)
+      resource.update!(is_transparent: true) if resource.respond_to?(:is_transparent)
+    end
+
+    context "and user is a visitor" do
+      let(:user) { nil }
+
+      it_behaves_like "rendering the embed page correctly"
+    end
+
+    context "and user is a registered user" do
+      let(:user) { create(:user, :confirmed, organization: organization) }
+
+      before do
+        sign_in user, scope: :user
+      end
+
+      it_behaves_like "rendering the embed page correctly"
+    end
+
+    context "and user is a private user" do
+      let(:user) { other_user }
+
+      before do
+        sign_in user, scope: :user
+      end
+
+      it_behaves_like "rendering the embed page correctly"
+    end
+  end
+end
+
+shared_examples_for "a moderated embed resource" do
+  include_context "with a component"
+
+  context "when the resource is moderated" do
+    let!(:moderation) { create(:moderation, reportable: resource, hidden_at: 2.days.ago) }
+
+    it_behaves_like "a 404 page" do
+      let(:target_path) { widget_path }
+    end
+  end
+end
+
+shared_examples_for "a withdrawn embed resource" do
+  include_context "with a component"
+
+  context "when the resource is withdrawn" do
+    before do
+      resource.update!(state: "withdrawn")
+    end
+
+    it_behaves_like "not rendering the embed link in the resource page"
+
+    it_behaves_like "a 404 page" do
+      let(:target_path) { widget_path }
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/errors.rb

@@ -18,6 +18,8 @@ shared_examples_for "a 404 page" do
       expect(page).to have_content("The page you're looking for can't be found")
 
       expect(page).to have_http_status(:not_found)
+
+      expect(page).to have_current_path(target_path)
     end
   end
 end

data/lib/decidim/core/test/shared_examples/has_attachment_collections.rb

@@ -14,14 +14,14 @@ shared_examples_for "has attachment collections" do
 
     it "shows them" do
       within ".attachments .documents" do
-        expect(page).to have_content(/#{translated(attachment_collection.name, locale: :en)}/i)
+        expect(page).to have_content(translated(attachment_collection.name))
       end
     end
 
     it "show their documents" do
       within ".attachments .documents #docs-collection-#{attachment_collection.id}", visible: false do
-        expect(page).to have_content(:all, /#{translated(document.title, locale: :en)}/i)
-        expect(page).not_to have_content(:all, /#{translated(other_document.title, locale: :en)}/i)
+        expect(page).to have_content(:all, translated(document.title))
+        expect(page).not_to have_content(:all, translated(other_document.title))
       end
     end
   end
@@ -39,7 +39,9 @@ shared_examples_for "has attachment collections" do
 
     it "shows them ordered" do
       within ".attachments .documents" do
-        expect(translated(first_attachment_collection.name, locale: :en)).to appear_before(translated(last_attachment_collection.name, locale: :en))
+        expect(decidim_escape_translated(first_attachment_collection.name).gsub(""",
+                                                                                "\"")).to appear_before(decidim_escape_translated(last_attachment_collection.name).gsub(""",
+                                                                                                                                                                        "\""))
       end
     end
   end
@@ -55,8 +57,8 @@ shared_examples_for "has attachment collections" do
 
     it "is not present" do
       within ".attachments .documents" do
-        expect(page).to have_content(/#{translated(attachment_collection.name, locale: :en)}/i)
-        expect(page).not_to have_content(/#{translated(empty_attachment_collection.name, locale: :en)}/i)
+        expect(page).to have_content(translated(attachment_collection.name))
+        expect(page).not_to have_content(translated(empty_attachment_collection.name))
       end
     end
   end

data/lib/decidim/core/test/shared_examples/has_attachments.rb

@@ -14,7 +14,7 @@ shared_examples_for "has attachments" do
 
     it "shows them" do
       within "div.wrapper .documents" do
-        expect(page).to have_content(/#{translated(document.title, locale: :en)}/i)
+        expect(page).to have_content(translated(document.title))
       end
 
       within "div.wrapper .images" do
@@ -27,7 +27,7 @@ shared_examples_for "has attachments" do
     let!(:last_document) { create(:attachment, :with_pdf, attached_to: attached_to, weight: 2) }
     let!(:first_document) { create(:attachment, :with_pdf, attached_to: attached_to, weight: 1) }
     let!(:last_image) { create(:attachment, attached_to: attached_to, weight: 2) }
-    let!(:fist_image) { create(:attachment, attached_to: attached_to, weight: 1) }
+    let!(:first_image) { create(:attachment, attached_to: attached_to, weight: 1) }
 
     before do
       visit current_path
@@ -35,11 +35,11 @@ shared_examples_for "has attachments" do
 
     it "shows them ordered" do
       within "div.wrapper .documents" do
-        expect(translated(first_document.title, locale: :en)).to appear_before(translated(last_document.title, locale: :en))
+        expect(decidim_escape_translated(first_document.title).gsub(""", "\"")).to appear_before(decidim_escape_translated(last_document.title).gsub(""", "\""))
       end
 
       within "div.wrapper .images" do
-        expect(strip_tags(translated(fist_image.title, locale: :en))).to appear_before(strip_tags(translated(last_image.title, locale: :en)))
+        expect(strip_tags(translated(first_image.title, locale: :en))).to appear_before(strip_tags(translated(last_image.title, locale: :en)))
       end
     end
   end

data/lib/decidim/core/test/shared_examples/has_category.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 shared_examples_for "has category" do
+  let(:participatory_space) { subject.participatory_space }
+
   context "when the category is from another organization" do
     before do
       subject.category = create(:category)
@@ -8,4 +10,29 @@ shared_examples_for "has category" do
 
     it { is_expected.not_to be_valid }
   end
+
+  context "when the category is from the same organization" do
+    before do
+      subject.category = create(:category, participatory_space: participatory_space)
+    end
+
+    it { is_expected.to be_valid }
+  end
+
+  context "when the resource is being deleted" do
+    before do
+      subject.category = create(:category, participatory_space: participatory_space)
+      subject.save!
+    end
+
+    it "persists the categorization" do
+      expect(subject.categorization).to be_persisted
+    end
+
+    it "deletes the categorization" do
+      expect(Decidim::Categorization.count).to eq(1)
+      expect { subject.destroy }.to change(Decidim::Categorization, :count).by(-1)
+      expect(Decidim::Categorization.count).to eq(0)
+    end
+  end
 end

data/lib/decidim/core/test/shared_examples/has_reference.rb

@@ -8,7 +8,7 @@ shared_examples_for "has reference" do
 
     context "when there is not a custom resource reference generator present" do
       it "generates a valid reference" do
-        expect(subject.reference).to match(/[A-z]+/)
+        expect(subject.reference).to match(/[a-zA-Z]+/)
       end
     end
 

data/lib/decidim/core/test/shared_examples/has_space_in_mcell_examples.rb

@@ -8,8 +8,7 @@ shared_examples_for "has space in m-cell" do
     let(:show_space) { true }
 
     it "renders the space where the model belongs to" do
-      expect(cell_html).to have_selector(".card__top .card__content.text-small")
-      expect(cell_html).to have_content(translated(model.component.participatory_space.title, locale: :en))
+      expect(cell_html).to have_content(translated(model.component.participatory_space.title))
     end
   end
 end

data/lib/decidim/core/test/shared_examples/resource_endorsed_event_examples.rb

@@ -35,17 +35,20 @@ shared_examples_for "resource endorsed event" do
   end
 
   describe "email_intro" do
+    let(:resource_title) { decidim_sanitize_translated(resource.title) }
     it "is generated correctly" do
       expect(subject.email_intro)
-        .to eq("#{author.name} #{author_presenter.nickname}, who you are following," \
-               " has just endorsed \"#{translated resource.title}\" and we think it may be interesting to you. Check it out and contribute:")
+        .to eq("#{author.name} #{author_presenter.nickname}, who you are following, " \
+               "has just endorsed \"#{resource_title}\" and we think it may be interesting to you. Check it out and contribute:")
     end
   end
 
   describe "notification_title" do
+    let(:resource_title) { decidim_sanitize_translated(resource.title) }
+
     it "is generated correctly" do
       expect(subject.notification_title)
-        .to include("The <a href=\"#{resource_path}\">#{translated resource.title}</a> #{resource_type} has been endorsed by ")
+        .to include("The <a href=\"#{resource_path}\">#{resource_title}</a> #{resource_type} has been endorsed by ")
 
       expect(subject.notification_title)
         .to include("<a href=\"/profiles/#{author.nickname}\">#{author.name} #{author_presenter.nickname}</a>.")

data/lib/decidim/core/test/shared_examples/resource_locator_presenter_examples.rb

@@ -0,0 +1,134 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples "generates routes without query strings on slug" do
+  let(:organization) { create(:organization, host: "1.lvh.me") }
+  let(:participatory_space) { create(factory_name, organization: organization) }
+  let(:component) { create(:component, id: 1, participatory_space: participatory_space) }
+  let(:resource) { create(:dummy_resource, id: 1, component: component) }
+
+  context "with a component resource" do
+    describe "#url" do
+      subject { described_class.new(resource).url }
+
+      it { is_expected.to eq("http://1.lvh.me:#{Capybara.server_port}/#{route_fragment}/f/1/dummy_resources/1") }
+
+      context "when specific port configured" do
+        before do
+          allow(ActionMailer::Base)
+            .to receive(:default_url_options)
+            .and_return(port: 3000)
+        end
+
+        it { is_expected.to eq("http://1.lvh.me:3000/#{route_fragment}/f/1/dummy_resources/1") }
+      end
+    end
+
+    describe "#path" do
+      subject { described_class.new(resource).path }
+
+      it { is_expected.to eq("/#{route_fragment}/f/1/dummy_resources/1") }
+    end
+
+    describe "#show" do
+      subject { described_class.new(participatory_space).show }
+
+      it { is_expected.to eq("/admin/#{admin_route_fragment}") }
+    end
+
+    describe "#edit" do
+      subject { described_class.new(participatory_space).edit }
+
+      it { is_expected.to eq("/admin/#{admin_route_fragment}/edit") }
+    end
+  end
+
+  context "with a polymorphic resource" do
+    let(:nested_resource) do
+      create(:nested_dummy_resource, id: 1, dummy_resource: resource)
+    end
+
+    describe "#url" do
+      subject { described_class.new([resource, nested_resource]).url }
+
+      it { is_expected.to eq("http://1.lvh.me:#{Capybara.server_port}/#{route_fragment}/f/1/dummy_resources/1/nested_dummy_resources/1") }
+
+      context "when specific port configured" do
+        before do
+          allow(ActionMailer::Base)
+            .to receive(:default_url_options)
+            .and_return(port: 3000)
+        end
+
+        it { is_expected.to eq("http://1.lvh.me:3000/#{route_fragment}/f/1/dummy_resources/1/nested_dummy_resources/1") }
+      end
+    end
+
+    describe "#path" do
+      subject { described_class.new([resource, nested_resource]).path }
+
+      it { is_expected.to eq("/#{route_fragment}/f/1/dummy_resources/1/nested_dummy_resources/1") }
+    end
+
+    describe "#index" do
+      subject { described_class.new([resource, nested_resource]).index }
+
+      it { is_expected.to eq("/#{route_fragment}/f/1/dummy_resources/1/nested_dummy_resources") }
+    end
+
+    describe "#admin_index" do
+      subject { described_class.new([resource, nested_resource]).admin_index }
+
+      it { is_expected.to eq("/admin/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources") }
+    end
+
+    describe "#show" do
+      subject { described_class.new([resource, nested_resource]).show }
+
+      it { is_expected.to eq("/admin/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources/1") }
+    end
+
+    describe "#edit" do
+      subject { described_class.new([resource, nested_resource]).edit }
+
+      it { is_expected.to eq("/admin/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources/1/edit") }
+    end
+  end
+
+  context "with a participatory_space" do
+    describe "#url" do
+      subject { described_class.new(participatory_space).url }
+
+      it { is_expected.to eq("http://1.lvh.me:#{Capybara.server_port}/#{route_fragment}") }
+
+      context "when specific port configured" do
+        before do
+          allow(ActionMailer::Base)
+            .to receive(:default_url_options)
+            .and_return(port: 3000)
+        end
+
+        it { is_expected.to eq("http://1.lvh.me:3000/#{route_fragment}") }
+      end
+    end
+
+    describe "#path" do
+      subject { described_class.new(participatory_space).path }
+
+      it { is_expected.to eq("/#{route_fragment}") }
+    end
+
+    describe "#show" do
+      subject { described_class.new(participatory_space).show }
+
+      it { is_expected.to eq("/admin/#{admin_route_fragment}") }
+    end
+
+    describe "#edit" do
+      subject { described_class.new(participatory_space).edit }
+
+      it { is_expected.to eq("/admin/#{admin_route_fragment}/edit") }
+    end
+  end
+end