decidim-core 0.26.5 → 0.27.0.rc1

data/lib/decidim/content_renderers/user_renderer.rb

@@ -10,7 +10,7 @@ module Decidim
     # @see BaseRenderer Examples of how to use a content renderer
     class UserRenderer < BaseRenderer
       # Matches a global id representing a Decidim::User
-      GLOBAL_ID_REGEX = %r{gid://[\w-]+/Decidim::User/\d+}.freeze
+      GLOBAL_ID_REGEX = %r{gid://[\w-]+/Decidim::User/\d+}
 
       # Replaces found Global IDs matching an existing user with
       # a link to their profile. The Global IDs representing an

data/lib/decidim/controller_helpers.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2016 Andy Pike - The MIT license
+#
+# This file has been copied from https://github.com/andypike/rectify/blob/master/lib/rectify/controller_helpers.rb
+# We have done this so we can decouple Decidim from any Virtus dependency, which is a dead project
+# Please follow Decidim discussion to understand more https://github.com/decidim/decidim/discussions/7234
+module Decidim
+  module ControllerHelpers
+    def self.included(base_class)
+      base_class.helper_method(:presenter)
+    end
+
+    def present(presenter, options = {})
+      presenter_type = options.fetch(:for, :template)
+
+      presenter.attach_controller(self)
+      rectify_presenters[presenter_type] = presenter
+    end
+
+    def presenter(presenter_type = :template)
+      rectify_presenters[presenter_type]
+    end
+
+    def expose(presentation_data)
+      presentation_data.each do |attribute, value|
+        if presenter.respond_to?("#{attribute}=")
+          presenter.public_send("#{attribute}=", value)
+        else
+          instance_variable_set("@#{attribute}", value)
+        end
+      end
+    end
+
+    private
+
+    def rectify_presenters
+      @rectify_presenters ||= {}
+    end
+  end
+end

data/lib/decidim/core/engine.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "rails"
+require "decidim/rails"
 require "active_support/all"
 require "action_view/railtie"
 
@@ -13,7 +13,6 @@ require "devise-i18n"
 require "devise_invitable"
 require "foundation_rails_helper"
 require "active_link_to"
-require "rectify"
 require "carrierwave"
 require "rails-i18n"
 require "date_validator"
@@ -39,7 +38,7 @@ require "mime-types"
 require "diffy"
 require "social-share-button"
 require "ransack"
-require "searchlight"
+require "wisper"
 require "webpacker"
 
 # Needed for the assets:precompile task, for configuring webpacker instance
@@ -49,9 +48,6 @@ require "decidim/api"
 require "decidim/middleware/strip_x_forwarded_host"
 require "decidim/middleware/current_organization"
 
-# Backport cookie handling extensions for Rails 6.0
-require "decidim/middleware/rails_cookies"
-
 module Decidim
   module Core
     # Decidim's core Rails Engine.
@@ -67,6 +63,10 @@ module Decidim
         end
       end
 
+      initializer "decidim.action_mailer" do |app|
+        app.config.action_mailer.deliver_later_queue_name = :mailers
+      end
+
       initializer "decidim.middleware" do |app|
         app.config.middleware.insert_before Warden::Manager, Decidim::Middleware::CurrentOrganization
         app.config.middleware.insert_before Warden::Manager, Decidim::Middleware::StripXForwardedHost
@@ -92,6 +92,17 @@ module Decidim
         Decidim::Api.add_orphan_type Decidim::Core::UserGroupType
       end
 
+      initializer "decidim.ransack" do
+        Ransack.configure do |config|
+          # Avoid turning parameter values such as user_id[]=1&user_id[]=2 into
+          # { user_id: [true, "2"] }. This option allows us to handle the type
+          # convertions manually instead for each case.
+          # See: https://github.com/activerecord-hackery/ransack/issues/593
+          # See: https://github.com/activerecord-hackery/ransack/pull/742
+          config.sanitize_custom_scope_booleans = false
+        end
+      end
+
       initializer "decidim.i18n_exceptions" do
         ActionView::Base.raise_on_missing_translations = true unless Rails.env.production?
       end
@@ -122,16 +133,15 @@ module Decidim
         next if Decidim.maps.present?
         next if Decidim.geocoder.blank?
 
-        legacy_api_key ||= begin
-          if Decidim.geocoder[:here_api_key].present?
-            Decidim.geocoder.fetch(:here_api_key)
-          elsif Decidim.geocoder[:here_app_id].present?
-            [
-              Decidim.geocoder.fetch(:here_app_id),
-              Decidim.geocoder.fetch(:here_app_code)
-            ]
-          end
-        end
+        legacy_api_key ||= if Decidim.geocoder[:here_api_key].present?
+                             Decidim.geocoder.fetch(:here_api_key)
+                           elsif Decidim.geocoder[:here_app_id].present?
+                             [
+                               Decidim.geocoder.fetch(:here_app_id),
+                               Decidim.geocoder.fetch(:here_app_code)
+                             ]
+                           end
+
         next unless legacy_api_key
 
         ActiveSupport::Deprecation.warn(
@@ -167,6 +177,7 @@ module Decidim
 
         Decidim.stats.register :processes_count, priority: StatsRegistry::HIGH_PRIORITY do |organization, start_at, end_at|
           processes = ParticipatoryProcesses::OrganizationPrioritizedParticipatoryProcesses.new(organization)
+
           processes = processes.where("created_at >= ?", start_at) if start_at.present?
           processes = processes.where("created_at <= ?", end_at) if end_at.present?
           processes.count
@@ -221,9 +232,9 @@ module Decidim
                         decidim.user_interests_path,
                         position: 1.4
 
-          menu.add_item :data_portability,
+          menu.add_item :download_your_data,
                         t("my_data", scope: "layouts.decidim.user_profile"),
-                        decidim.data_portability_path,
+                        decidim.download_your_data_path,
                         position: 1.5
 
           menu.add_item :delete_account,
@@ -254,7 +265,7 @@ module Decidim
         Cell::ViewModel.view_paths << File.expand_path("#{Decidim::Core::Engine.root}/app/views") # for partials
       end
 
-      initializer "doorkeeper", before: "doorkeeper.params.filter" do
+      initializer "doorkeeper" do
         Doorkeeper.configure do
           orm :active_record
 
@@ -531,6 +542,11 @@ module Decidim
       end
 
       initializer "decidim.core.add_badges" do
+        Decidim::Gamification.register_badge(:invitations) do |badge|
+          badge.levels = [1, 5, 10, 30, 50]
+          badge.reset = ->(user) { Decidim::User.where(invited_by: user.id).count }
+        end
+
         Decidim::Gamification.register_badge(:followers) do |badge|
           badge.levels = [1, 15, 30, 60, 100]
           badge.reset = ->(user) { user.followers.count }

data/lib/decidim/core/test/factories.rb

@@ -17,8 +17,8 @@ FactoryBot.define do
     "#{Faker::Lorem.sentence(word_count: 3)} #{n}".delete("'")
   end
 
-  sequence(:name) do |n|
-    "#{Faker::Name.name} #{n}".delete("'")
+  sequence(:name) do |_|
+    Faker::Name.name.delete("'")
   end
 
   sequence(:nickname) do |n|
@@ -125,8 +125,6 @@ FactoryBot.define do
 
   factory :user, class: "Decidim::User" do
     email { generate(:email) }
-    password { "decidim123456" }
-    password_confirmation { password }
     name { generate(:name) }
     nickname { generate(:nickname) }
     organization
@@ -137,8 +135,10 @@ FactoryBot.define do
     about { "<script>alert(\"ABOUT\");</script>#{Faker::Lorem.paragraph(sentence_count: 2)}" }
     confirmation_sent_at { Time.current }
     accepted_tos_version { organization.tos_version }
-    email_on_notification { true }
+    notifications_sending_frequency { "real_time" }
     email_on_moderations { true }
+    password_updated_at { Time.current }
+    previous_passwords { [] }
     extended_data { {} }
 
     trait :confirmed do
@@ -148,7 +148,7 @@ FactoryBot.define do
     trait :blocked do
       blocked { true }
       blocked_at { Time.current }
-      extended_data { { "user_name": generate(:name) } }
+      extended_data { { user_name: generate(:name) } }
       name { "Blocked user" }
     end
 
@@ -183,6 +183,14 @@ FactoryBot.define do
       officialized_at { Time.current }
       officialized_as { generate_localized_title }
     end
+
+    after(:build) do |user, evaluator|
+      # We have specs that call e.g. `create(:user, admin: true)` where we need
+      # to do this to ensure the user creation does not fail due to the short
+      # password.
+      user.password ||= evaluator.password || "decidim123456789"
+      user.password_confirmation ||= evaluator.password_confirmation || user.password
+    end
   end
 
   factory :participatory_space_private_user, class: "Decidim::ParticipatorySpacePrivateUser" do
@@ -226,20 +234,13 @@ FactoryBot.define do
       confirmed_at { Time.current }
     end
 
-    trait :blocked do
-      blocked { true }
-      blocked_at { Time.current }
-      extended_data { { user_name: generate(:name) } }
-      name { "Blocked user group" }
-    end
-
     after(:build) do |user_group, evaluator|
-      user_group.extended_data = user_group.extended_data.merge({
-                                                                  document_number: evaluator.document_number,
-                                                                  phone: evaluator.phone,
-                                                                  rejected_at: evaluator.rejected_at,
-                                                                  verified_at: evaluator.verified_at
-                                                                })
+      user_group.extended_data = {
+        document_number: evaluator.document_number,
+        phone: evaluator.phone,
+        rejected_at: evaluator.rejected_at,
+        verified_at: evaluator.verified_at
+      }
     end
 
     after(:create) do |user_group, evaluator|
@@ -721,8 +722,8 @@ FactoryBot.define do
 
   factory :user_report, class: "Decidim::UserReport" do
     reason { "spam" }
-    moderation { build(:user_moderation) }
-    user { build(:user, organization: moderation.organization) }
+    moderation { create(:user_moderation, user: user) }
+    user { build(:user) }
   end
 
   factory :user_moderation, class: "Decidim::UserModeration" do
@@ -763,4 +764,36 @@ FactoryBot.define do
     author { create(:user, :admin, :confirmed, organization: organization) }
     file { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
   end
+
+  factory :reminder, class: "Decidim::Reminder" do
+    user { build(:user) }
+    component { build(:dummy_component, organization: user.organization) }
+  end
+
+  factory :reminder_record, class: "Decidim::ReminderRecord" do
+    reminder { create(:reminder) }
+    remindable { build(:dummy_resource) }
+  end
+
+  factory :reminder_delivery, class: "Decidim::ReminderDelivery" do
+    reminder { create(:reminder) }
+  end
+
+  factory :short_link, class: "Decidim::ShortLink" do
+    target { create(:component, manifest_name: "dummy") }
+    route_name { nil }
+    params { {} }
+
+    before(:create) do |object|
+      object.organization ||= object.target if object.target.is_a?(Decidim::Organization)
+      object.organization ||= object.target.try(:organization) || create(:organization)
+      object.identifier ||= Decidim::ShortLink.unique_identifier_within(object.organization)
+      object.mounted_engine_name ||=
+        if object.target.respond_to?(:participatory_space)
+          "decidim_#{object.target.participatory_space.underscored_name}_dummy"
+        else
+          "decidim"
+        end
+    end
+  end
 end

data/lib/decidim/core/test/shared_examples/admin_resource_gallery_examples.rb

@@ -4,8 +4,14 @@ shared_examples "admin creates resource gallery" do
   context "when uploading images" do
     let(:uploaded_photos) do
       [
-        Decidim::Dev.test_file("city.jpeg", "image/jpeg"),
-        Decidim::Dev.test_file("city2.jpeg", "image/jpeg")
+        {
+          title: "Picture of the city",
+          file: ActiveStorage::Blob.create_and_upload!(io: Decidim::Dev.test_file("city.jpeg", "image/jpeg"), filename: "city.jpeg").signed_id
+        },
+        {
+          title: "Picture of another city",
+          file: ActiveStorage::Blob.create_and_upload!(io: Decidim::Dev.test_file("city2.jpeg", "image/jpeg"), filename: "city2.jpeg").signed_id
+        }
       ]
     end
     let(:photos) { [] }
@@ -33,8 +39,14 @@ shared_examples "admin manages resource gallery" do
   context "when managing images" do
     let(:uploaded_photos) do
       [
-        Decidim::Dev.test_file("city.jpeg", "image/jpeg"),
-        Decidim::Dev.test_file("city2.jpeg", "image/jpeg")
+        {
+          title: "Picture of the city",
+          file: ActiveStorage::Blob.create_and_upload!(io: Decidim::Dev.test_file("city.jpeg", "image/jpeg"), filename: "city.jpeg").signed_id
+        },
+        {
+          title: "Picture of another city",
+          file: ActiveStorage::Blob.create_and_upload!(io: Decidim::Dev.test_file("city2.jpeg", "image/jpeg"), filename: "city2.jpeg").signed_id
+        }
       ]
     end
     let(:photos) { [] }

data/lib/decidim/core/test/shared_examples/amendable/amendment_form_examples.rb

@@ -21,7 +21,7 @@ shared_examples "an amendment form" do
 
     it "only adds errors to this field" do
       subject.valid?
-      expect(subject.errors.keys).to eq [:title]
+      expect(subject.errors.attribute_names).to eq [:title]
     end
   end
 

data/lib/decidim/core/test/shared_examples/authorable_interface_examples.rb

@@ -25,7 +25,7 @@ shared_examples_for "authorable interface" do
         model.update(author: author, user_group: nil)
       end
 
-      it "includes the user's ID" do
+      it "includes the user's name" do
         expect(response["author"]["name"]).to eq(author.name)
       end
     end
@@ -38,9 +38,22 @@ shared_examples_for "authorable interface" do
         model.update(user_group: user_group, author: nil)
       end
 
-      it "includes the user's ID" do
+      it "includes the user group's name" do
         expect(response["author"]["name"]).to eq(user_group.name)
       end
     end
+
+    describe "with an organization" do
+      let(:organization) { model.participatory_space.organization }
+      let(:query) { "{ author { name } }" }
+
+      before do
+        model.update(author: organization, user_group: nil)
+      end
+
+      it "does not return a main author" do
+        expect(response["author"]).to eq(nil)
+      end
+    end
   end
 end

data/lib/decidim/core/test/shared_examples/coauthorable_interface_examples.rb

@@ -65,7 +65,7 @@ shared_examples_for "coauthorable interface" do
           expect(response["authors"]).to include("name" => coauthor.name)
         end
 
-        it "do not return a main author" do
+        it "does not return a main author" do
           expect(response["author"]).to eq(nil)
         end
       end
@@ -82,7 +82,7 @@ shared_examples_for "coauthorable interface" do
           expect(response["authors"]).to include("name" => coauthor.name)
         end
 
-        it "do not return a main author" do
+        it "does not return a main author" do
           expect(response["author"]).to eq(nil)
         end
       end

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -121,6 +121,209 @@ shared_examples "comments" do
         end
       end
 
+      it "updates the numbers of characters left correctly" do
+        within ".add-comment form" do
+          fill_in "add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}", with: "This is a new comment."
+          expect(page).to have_content("1978 characters left")
+        end
+      end
+
+      context "when working with the screen reader character counter" do
+        let(:field_id) { "add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}" }
+        let(:field) { page.find("##{field_id}") }
+
+        before do
+          # Make sure the focus stays in the comment form during these tests
+          # because only then the screen reader
+          page.execute_script("document.getElementById('#{field_id}').focus()")
+        end
+
+        it "updates the numbers of characters left correctly for screen reader" do
+          within ".add-comment form" do
+            fill_in field_id, with: "This is a new comment."
+
+            # The screen reader character counter should update only when the user
+            # reaches 10% interval of the total characters available not to
+            # announce the remaining characters after every keystroke.
+            field.native.send_keys " Sending some new text."
+            within ".remaining-character-count" do
+              expect(page).to have_content("1955 characters left") # Normal
+            end
+            within ".remaining-character-count-sr" do
+              expect(page).to have_content("2000 characters left") # Screen reader
+            end
+
+            # After 10% of the total characters is reached, it should be updated
+            # to the screen reader section to announce it.
+            field.native.send_keys "a" * 155
+            within ".remaining-character-count" do
+              expect(page).to have_content("1800 characters left") # Normal
+            end
+            within ".remaining-character-count-sr" do
+              expect(page).to have_content("1800 characters left") # Screen reader
+            end
+
+            # After continuing typing after the announcement, the screen reader
+            # characters should stay the same (announced on the next 10%
+            # interval).
+            field.native.send_keys "b"
+            within ".remaining-character-count" do
+              expect(page).to have_content("1799 characters left") # Normal
+            end
+            within ".remaining-character-count-sr" do
+              expect(page).to have_content("1800 characters left") # Screen reader
+            end
+
+            # When text is removed at the interval, the screen reader should
+            # update back to the previous interval.
+            field.native.send_keys [:backspace, :backspace, :backspace, :backspace]
+            within ".remaining-character-count" do
+              expect(page).to have_content("1803 characters left") # Normal
+            end
+            within ".remaining-character-count-sr" do
+              expect(page).to have_content("1800 characters left") # Screen reader
+            end
+
+            # After continuing typing after the removal of characters, we should
+            # stay in the "latest announcement" not to confuse the user as
+            # - "1800 characters left" (actual 1803)
+            # - Type in one character
+            # - "1900 characters left" (actual 1802)
+            field.native.send_keys "b"
+            within ".remaining-character-count" do
+              expect(page).to have_content("1802 characters left") # Normal
+            end
+            within ".remaining-character-count-sr" do
+              expect(page).to have_content("1800 characters left") # Screen reader
+            end
+
+            # After the input is blurred, the screen reader character counter
+            # should show the actual amount of characters left.
+            page.execute_script("document.getElementById('#{field_id}').blur()")
+            within ".remaining-character-count" do
+              expect(page).to have_content("1802 characters left") # Normal
+            end
+            within ".remaining-character-count-sr" do
+              expect(page).to have_content("1802 characters left") # Screen reader
+            end
+          end
+        end
+
+        context "when reaching the announce after every threshold" do
+          it "updates the numbers of characters left correctly for screen reader" do
+            within ".add-comment form" do
+              # Test that when reaching the "announce after every" threshold, the
+              # characters are announced after every keystroke.
+              fill_in field_id, with: "a" * 1989
+              within ".remaining-character-count" do
+                expect(page).to have_content("11 characters left") # Normal
+              end
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("200 characters left") # Screen reader
+              end
+
+              (2..10).reverse_each do |remaining|
+                field.native.send_keys "b"
+                within ".remaining-character-count-sr" do
+                  expect(page).to have_content("#{remaining} characters left")
+                end
+              end
+
+              field.native.send_keys "b"
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("1 character left")
+              end
+
+              field.native.send_keys "c"
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("0 characters left")
+              end
+
+              # Test that the SR counter will stick at the last announced
+              # threshold if the next threshold is not hit and text is removed.
+              # This prevents weird announcements such as:
+              # - 0 characters left
+              # - Remove 10 characters
+              # - 10 characters left
+              # - Remove 1 character
+              # - 200 characters left
+              page.execute_script("document.getElementById('#{field_id}').setSelectionRange(1850, 2000)")
+              field.native.send_keys [:backspace]
+              within ".remaining-character-count" do
+                expect(page).to have_content("150 characters left") # Normal
+              end
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("0 characters left") # Screen reader
+              end
+
+              field.native.send_keys "d"
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("0 characters left")
+              end
+            end
+          end
+        end
+
+        context "when deleting text the announce after every threshold" do
+          it "updates the numbers of characters left correctly for screen reader" do
+            within ".add-comment form" do
+              fill_in field_id, with: "a" * 2000
+              within ".remaining-character-count" do
+                expect(page).to have_content("0 characters left") # Normal
+              end
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("0 characters left") # Screen reader
+              end
+
+              # Test that the SR counter updates correctly after hitting the
+              # next threshold.
+              page.execute_script("document.getElementById('#{field_id}').setSelectionRange(1800, 2000)")
+              field.native.send_keys [:backspace]
+              within ".remaining-character-count" do
+                expect(page).to have_content("200 characters left") # Normal
+              end
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("200 characters left") # Screen reader
+              end
+
+              # The SR counter should stay at the correct boundary.
+              field.native.send_keys [:backspace, :backspace]
+              within ".remaining-character-count" do
+                expect(page).to have_content("202 characters left") # Normal
+              end
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("200 characters left") # Screen reader
+              end
+
+              # It stays at the correct boundary when starting to type again.
+              field.native.send_keys "b"
+              within ".remaining-character-count" do
+                expect(page).to have_content("201 characters left") # Normal
+              end
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("200 characters left") # Screen reader
+              end
+
+              field.native.send_keys "c"
+              within ".remaining-character-count" do
+                expect(page).to have_content("200 characters left") # Normal
+              end
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("200 characters left") # Screen reader
+              end
+
+              field.native.send_keys "d"
+              within ".remaining-character-count" do
+                expect(page).to have_content("199 characters left") # Normal
+              end
+              within ".remaining-character-count-sr" do
+                expect(page).to have_content("200 characters left") # Screen reader
+              end
+            end
+          end
+        end
+      end
+
       context "when component is present and has a default comments length params" do
         it "displays the numbers of characters left" do
           if component.present?

data/lib/decidim/core/test/shared_examples/localised_email.rb

@@ -9,7 +9,7 @@ shared_examples "localised email" do
     let(:locale) { "ca" }
 
     it "uses the user's locale" do
-      expect(mail.subject).to eq(subject)
+      expect(mail.subject).to eq(mail_subject)
       expect(mail.body.encoded).to match(body)
     end
   end

data/lib/decidim/core/test/shared_examples/logo_email.rb

@@ -15,7 +15,7 @@ shared_examples "email with logo" do
 
     it "includes organization logo with full link" do
       expect(mail.body).to include("alt=\"#{organization.name}\"")
-      expect(mail.body).to match(%r{https{0,1}://#{organization.host}#{logo_path}})
+      expect(mail.body).to match(%r{https{0,1}://#{organization.host}:#{Capybara.server_port}#{logo_path}})
     end
   end
 end

data/lib/decidim/core/test/shared_examples/map_examples.rb

@@ -24,7 +24,7 @@ shared_context "with frontend map builder" do
     end
   end
   let(:organization) { create(:organization) }
-  let(:template) { template_class.new(ActionView::LookupContext.new(nil)) }
+  let(:template) { template_class.new(ActionView::LookupContext.new(ActionController::Base.view_paths), {}, []) }
   let(:options) { {} }
   let(:js_options) { options.transform_keys { |k| k.to_s.camelize(:lower) }.to_h }
 
@@ -103,6 +103,7 @@ shared_context "with frontend map elements" do
     final_html = html_document
     Rails.application.routes.draw do
       get "test_dynamic_map", to: ->(_) { [200, {}, [final_html]] }
+      get "offline", to: ->(_) { [200, {}, [""]] }
     end
 
     visit "/test_dynamic_map"
@@ -180,7 +181,6 @@ shared_examples "a record with front-end geocoding address field" do |geocoded_m
   it "calls the front-end geocoder when an address is written", :slow do
     within view_options[:within_selector] do
       fill_in_geocoding view_options[:address_field], with: geocoded_address_value
-      find(".tribute-container ul#results li", match: :first).click
       find("*[type=submit]").click
     end