decidim-core 0.24.0.rc1 → 0.24.3

data/lib/decidim/core/test/shared_examples/controller_render_views.rb

@@ -3,9 +3,7 @@
 shared_context "with controller rendering the view" do
   # Fix "No route matches" errors with the view.
   before do
-    controller.class_eval do
-      helper_method :polymorphic_path, :url_for
-
+    controller.view_context_class.class_eval do
       # Needed for the form_for to work (through decidim_form_for)
       # The path shouldn't matter in the controller specs.
       def polymorphic_path(_record, _options)
@@ -20,6 +18,13 @@ shared_context "with controller rendering the view" do
     end
   end
 
+  after do
+    # Ensure that the customized view context class is not being kept in the
+    # cache variable. Otherwise we might mess up the following specs using the
+    # same controller in the same run.
+    controller.class.remove_instance_variable(:@view_context_class)
+  end
+
   # Rendering of the view is necessary to see the view renders correctly
   # when there are errors on the form. This is hard to test with a
   # system test because there is some JS blocking us to submit the form

data/lib/decidim/core/test/shared_examples/localised_email.rb

@@ -22,4 +22,12 @@ shared_examples "localised email" do
       expect(mail.body.encoded).to match(default_body)
     end
   end
+
+  context "when the user doesn't have an email" do
+    let(:user) { create(:user, :deleted) }
+
+    it "does nothing" do
+      expect(mail.deliver_now).to be_nil
+    end
+  end
 end

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.24.0.rc1"
+      "0.24.3"
     end
   end
 end

data/lib/decidim/exporters/csv.rb

@@ -43,7 +43,7 @@ module Decidim
       def headers
         return [] if processed_collection.empty?
 
-        processed_collection.first.keys
+        processed_collection.inject([]) { |keys, resource| keys | resource.keys }
       end
 
       def processed_collection

data/lib/decidim/followable.rb

@@ -6,7 +6,12 @@ module Decidim
     extend ActiveSupport::Concern
 
     included do
-      has_many :follows, as: :followable, foreign_key: "decidim_followable_id", foreign_type: "decidim_followable_type", class_name: "Decidim::Follow"
+      has_many :follows,
+               as: :followable,
+               foreign_key: "decidim_followable_id",
+               foreign_type: "decidim_followable_type",
+               class_name: "Decidim::Follow",
+               counter_cache: :follows_count
       has_many :followers, through: :follows, source: :user
     end
 

data/lib/decidim/geocodable.rb

@@ -27,6 +27,10 @@ module Decidim
     included do
       include Geocoder::Store::ActiveRecord
 
+      def geocoded_and_valid?
+        geocoded? && to_coordinates.none?(&:nan?)
+      end
+
       private
 
       # rubocop:disable Style/OptionalBooleanParameter

data/lib/decidim/record_encryptor.rb

@@ -103,7 +103,7 @@ module Decidim
 
     def decrypt_value(value)
       Decidim::AttributeEncryptor.decrypt(value)
-    rescue ActiveSupport::MessageEncryptor::InvalidMessage
+    rescue ActiveSupport::MessageEncryptor::InvalidMessage, ActiveSupport::MessageVerifier::InvalidSignature
       # Support for legacy unencrypted values. This is necessary e.g. when
       # migrating the original unencrypted values to encrypted values.
       value
@@ -116,7 +116,25 @@ module Decidim
     def decrypt_hash_values(hash)
       return hash unless hash.is_a?(Hash)
 
-      hash.transform_values { |value| ActiveSupport::JSON.decode(decrypt_value(value)) }
+      hash.transform_values do |value|
+        # If the value is not a String, it is likely a legacy unencrypted hash
+        # value. Also, `ActiveSupport::JSON.decode` expects the value passed to
+        # it to be a String. Otherwise it would raise a TypeError.
+        next value unless value.is_a?(String)
+
+        decrypted_value = decrypt_value(value)
+
+        # When handling legacy unencrypted hash values, the decrypted values
+        # could not be valid JSON strings. They could be normal strings that
+        # cannot be JSON decoded.
+        begin
+          ActiveSupport::JSON.decode(decrypted_value)
+        rescue TypeError
+          ""
+        rescue JSON::ParserError
+          decrypted_value
+        end
+      end
     end
 
     def encrypt_hash_values(hash)

data/lib/decidim/reportable.rb

@@ -26,14 +26,14 @@ module Decidim
       #
       # Returns Boolean.
       def hidden?
-        moderation&.hidden_at&.present?
+        moderation&.hidden_at&.present? || false
       end
 
       # Public: Checks if the reportable has been reported or not.
       #
       # Returns Boolean.
       def reported?
-        moderation&.report_count&.positive?
+        moderation&.report_count&.positive? || false
       end
 
       # Public: The reported content url

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim-core
 version: !ruby/object:Gem::Version
-  version: 0.24.0.rc1
+  version: 0.24.3
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-01 00:00:00.000000000 Z
+date: 2021-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_link_to
@@ -88,14 +88,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.2.1
 - !ruby/object:Gem::Dependency
   name: cells-erb
   requirement: !ruby/object:Gem::Requirement
@@ -608,14 +608,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.4.5
+        version: 5.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.4.5
+        version: 5.2.6
 - !ruby/object:Gem::Dependency
   name: rails-i18n
   requirement: !ruby/object:Gem::Requirement
@@ -858,28 +858,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.24.0.rc1
+        version: 0.24.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.24.0.rc1
+        version: 0.24.3
 - !ruby/object:Gem::Dependency
   name: decidim-dev
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.24.0.rc1
+        version: 0.24.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.24.0.rc1
+        version: 0.24.3
 description: Adds core features so other engines can hook into the framework.
 email:
 - josepjaume@gmail.com
@@ -955,6 +955,7 @@ files:
 - app/assets/javascripts/decidim/form_filter.component.test.js
 - app/assets/javascripts/decidim/form_validator.es6
 - app/assets/javascripts/decidim/foundation.js.es6
+- app/assets/javascripts/decidim/gallery.js.es6
 - app/assets/javascripts/decidim/geocoding.js.es6
 - app/assets/javascripts/decidim/geocoding/attach_input.js.es6
 - app/assets/javascripts/decidim/geocoding/format_address.js.es6
@@ -1370,6 +1371,7 @@ files:
 - app/controllers/concerns/decidim/flaggable.rb
 - app/controllers/concerns/decidim/force_authentication.rb
 - app/controllers/concerns/decidim/form_factory.rb
+- app/controllers/concerns/decidim/has_stored_path.rb
 - app/controllers/concerns/decidim/http_caching_disabler.rb
 - app/controllers/concerns/decidim/impersonate_users.rb
 - app/controllers/concerns/decidim/locale_switcher.rb
@@ -1492,6 +1494,7 @@ files:
 - app/helpers/decidim/aria_selected_link_to_helper.rb
 - app/helpers/decidim/attachments_helper.rb
 - app/helpers/decidim/authorization_form_helper.rb
+- app/helpers/decidim/cache_helper.rb
 - app/helpers/decidim/card_helper.rb
 - app/helpers/decidim/categories_helper.rb
 - app/helpers/decidim/cells_helper.rb
@@ -2190,6 +2193,8 @@ files:
 - db/migrate/20201218144706_update_table_block_user_functionality.rb
 - db/migrate/20201218145252_rename_decidim_user_fields_for_block_functionality.rb
 - db/migrate/20210208134328_add_email_on_moderations_to_users.rb
+- db/migrate/20210302150803_invalidate_all_sessions_for_deleted_users.rb
+- db/migrate/20210310120640_add_followable_counter_cache_to_users.rb
 - db/seeds.rb
 - db/seeds/homepage_image.jpg
 - lib/decidim/action_authorization.rb
@@ -2373,7 +2378,6 @@ files:
 - lib/decidim/core/test/shared_examples/timestamps_interface_examples.rb
 - lib/decidim/core/test/shared_examples/traceable_interface_examples.rb
 - lib/decidim/core/test/shared_examples/uncommentable_component_examples.rb
-- lib/decidim/core/test/shared_examples/user_localised_email_examples.rb
 - lib/decidim/core/test/shared_examples/with_endorsable_permissions_examples.rb
 - lib/decidim/core/version.rb
 - lib/decidim/data_portability.rb
@@ -2590,9 +2594,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.1.2
 signing_key:

data/lib/decidim/core/test/shared_examples/user_localised_email_examples.rb

@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-shared_examples "user localised email" do
-  let(:user) { create(:user, locale: locale, organization: organization) }
-
-  context "when the user has a custom locale" do
-    let(:locale) { "ca" }
-
-    it "uses the user's locale" do
-      expect(mail.subject).to eq(subject)
-      expect(mail.body.encoded).to match(body)
-    end
-  end
-
-  context "when the user does not have a custom locale" do
-    let(:locale) { nil }
-
-    it "uses the default locale" do
-      expect(mail.subject).to eq(default_subject)
-      expect(mail.body.encoded).to match(default_body)
-    end
-  end
-end