decidim-core 0.20.0 → 0.23.1.rc1

data/lib/decidim/core/test/shared_examples/admin_resource_gallery_examples.rb

@@ -0,0 +1,79 @@
+# frozen_string_literal: true
+
+shared_examples "admin creates resource gallery" do
+  context "when uploading images", processing_uploads_for: Decidim::AttachmentUploader do
+    let(:uploaded_photos) do
+      [
+        Decidim::Dev.test_file("city.jpeg", "image/jpeg"),
+        Decidim::Dev.test_file("city2.jpeg", "image/jpeg")
+      ]
+    end
+    let(:photos) { [] }
+
+    it "creates a gallery for the resource" do
+      expect { command.call }.to change(Decidim::Attachment, :count).by(uploaded_photos.count)
+
+      resource = resource_class.last
+      expect(resource.photos.count).to eq(2)
+      last_attachment = Decidim::Attachment.last
+      expect(last_attachment.attached_to).to eq(resource)
+    end
+
+    context "when gallery is left blank" do
+      let(:uploaded_photos) { [] }
+
+      it "broadcasts ok" do
+        expect { command.call }.to broadcast(:ok)
+      end
+    end
+  end
+end
+
+shared_examples "admin manages resource gallery" do
+  context "when managing images", processing_uploads_for: Decidim::AttachmentUploader do
+    let(:uploaded_photos) do
+      [
+        Decidim::Dev.test_file("city.jpeg", "image/jpeg"),
+        Decidim::Dev.test_file("city2.jpeg", "image/jpeg")
+      ]
+    end
+    let(:photos) { [] }
+
+    it "creates a gallery for the resource" do
+      expect { command.call }.to change(Decidim::Attachment, :count).by(uploaded_photos.count)
+      resource = resource_class.last
+      expect(resource.photos.count).to eq(2)
+      last_attachment = Decidim::Attachment.last
+      expect(last_attachment.attached_to).to eq(resource)
+    end
+
+    context "when gallery is left blank" do
+      let(:uploaded_photos) { [] }
+
+      it "broadcasts ok" do
+        expect { command.call }.to broadcast(:ok)
+      end
+    end
+
+    context "when images are removed" do
+      let!(:image1) { create(:attachment, :with_image, attached_to: resource) }
+      let!(:image2) { create(:attachment, :with_image, attached_to: resource) }
+      let(:uploaded_photos) { [] }
+      let(:current_photos) { [image1.id.to_s] }
+
+      it "to decrease the number of photos in the gallery" do
+        expect(resource.attachments.count).to eq(2)
+        expect(resource.photos.count).to eq(2)
+        expect { command.call }.to change(Decidim::Attachment, :count).by(-1)
+        expect(resource.attachments.count).to eq(1)
+        expect(resource.photos.count).to eq(1)
+      end
+    end
+  end
+end
+
+shared_examples "admin destroys resource gallery" do
+  it "destroys the attached image" do
+    expect { command.call }.to change(Decidim::Attachment, :count).by(-1)
+  end
+end

data/lib/decidim/core/test/shared_examples/amendable/accept_amendment_examples.rb

@@ -26,18 +26,18 @@ shared_examples "accept amendment" do
           amendable.creator_author,
           { state: "accepted" },
           visibility: "public-only"
-        ).and_call_original
+        ).and_return(amendment)
 
       expect(Decidim.traceability)
-        .to receive(:update!)
+        .to receive(:perform_action!)
         .with(
+          :update,
           amendable,
           emendation.creator_author,
-          { body: emendation.body, title: emendation.title },
           visibility: "public-only"
         ).and_call_original
 
-      expect { command.call }.to change(Decidim::ActionLog, :count).by(2)
+      command.call
     end
 
     it "notifies the change" do

data/lib/decidim/core/test/shared_examples/amendable_interface_examples.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "amendable interface" do
+  describe "amendments" do
+    let(:query) { "{ amendments { id } }" }
+
+    it "includes the amendments id" do
+      amendments_ids = response["amendments"].map { |amendment| amendment["id"].to_i }
+      expect(amendments_ids).to include(*model.amendments.map(&:id))
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/amendable_proposals_interface_examples.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "amendable proposals interface" do
+  describe "amendments" do
+    let(:query) do
+      '{ amendments {
+      state
+      amendable { ...on Proposal { title { translation(locale: "en") } } }
+      amendableType
+      emendation { ...on Proposal { title { translation(locale: "en") } } }
+      emendationType
+      amender { name }
+    } }'
+    end
+
+    it "includes the amendments states" do
+      amendments_states = response["amendments"].map { |amendment| amendment["state"] }
+      expect(amendments_states).to include(*model.amendments.map(&:state))
+    end
+
+    it "amendable types matches Proposals Type" do
+      response["amendments"].each do |amendment|
+        expect(amendment["amendableType"]).to eq("Decidim::Proposals::Proposal")
+      end
+    end
+
+    it "emendation types matches Proposals Type" do
+      response["amendments"].each do |amendment|
+        expect(amendment["emendationType"]).to eq("Decidim::Proposals::Proposal")
+      end
+    end
+
+    it "returns amendable as parent proposal" do
+      amendment_amendables = response["amendments"].map { |amendment| amendment["amendable"] }.map { |title| title["title"]["translation"] }
+      expect(amendment_amendables).to include(*model.amendments.map(&:amendable).map { |p| p.title["en"] })
+    end
+
+    it "returns emendations received" do
+      amendment_emendations = response["amendments"].map { |amendment| amendment["emendation"] }.map { |title| title["title"]["translation"] }
+      expect(amendment_emendations).to include(*model.amendments.map(&:emendation).map { |p| p.title["en"] })
+    end
+
+    it "returns amender as emendation author" do
+      amendment_amenders = response["amendments"].map { |amendment| amendment["amender"] }
+      expect(amendment_amenders).to include(*model.amendments.map(&:amender).map { |p| { "name" => p.name } })
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/authorable_interface_examples.rb

@@ -5,6 +5,9 @@ require "spec_helper"
 shared_examples_for "authorable interface" do
   describe "author" do
     describe "when author is not present" do
+      let(:author) { nil }
+      let(:query) { "{ author { name } }" }
+
       before do
         model.update(author: author)
       end

data/lib/decidim/core/test/shared_examples/back_to_list_button_examples.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+shared_examples "going back to list button" do
+  it "shows the back button" do
+    expect(page).to have_link(href: main_component_path(component) + manifest_name)
+  end
+
+  context "when clicking the back button" do
+    before do
+      click_link(href: main_component_path(component) + manifest_name)
+    end
+
+    it "redirect the user to component index" do
+      expect(page).to have_current_path(main_component_path(component) + manifest_name)
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/coauthorable_interface_examples.rb

@@ -27,5 +27,65 @@ shared_examples_for "coauthorable interface" do
         expect(response["author"]["name"]).to eq(user_group.name)
       end
     end
+
+    describe "with a several coauthors" do
+      let(:query) { "{ author { name } authors { name } authorsCount }" }
+      let(:coauthor) { create(:user, :confirmed, organization: model.participatory_space.organization) }
+
+      before do
+        model.add_coauthor coauthor
+        model.save!
+      end
+
+      context "when both are users" do
+        it "returns 2 total co-authors" do
+          expect(response["authorsCount"]).to eq(2)
+        end
+
+        it "returns an array of authors" do
+          expect(response["authors"].count).to eq(2)
+          expect(response["authors"]).to include("name" => author.name)
+          expect(response["authors"]).to include("name" => coauthor.name)
+        end
+
+        it "returns a main author" do
+          expect(response["author"]["name"]).to eq(author.name)
+        end
+      end
+
+      context "when author is the organization" do
+        let(:model) { create(:proposal, :official, component: component) }
+
+        it "returns 2 total co-authors" do
+          expect(response["authorsCount"]).to eq(2)
+        end
+
+        it "returns 1 author in authors array" do
+          expect(response["authors"].count).to eq(1)
+          expect(response["authors"]).to include("name" => coauthor.name)
+        end
+
+        it "do not return a main author" do
+          expect(response["author"]).to eq(nil)
+        end
+      end
+
+      context "when author is a meeting" do
+        let(:model) { create(:proposal, :official_meeting, component: component) }
+
+        it "returns 2 total co-authors" do
+          expect(response["authorsCount"]).to eq(2)
+        end
+
+        it "returns 1 author in authors array" do
+          expect(response["authors"].count).to eq(1)
+          expect(response["authors"]).to include("name" => coauthor.name)
+        end
+
+        it "do not return a main author" do
+          expect(response["author"]).to eq(nil)
+        end
+      end
+    end
   end
 end

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -9,16 +9,20 @@ shared_examples "comments" do
     switch_to_host(organization.host)
   end
 
-  it "shows the list of comments for the resorce" do
+  after do
+    expect_no_js_errors
+  end
+
+  it "shows the list of comments for the resource" do
     visit resource_path
 
     expect(page).to have_selector("#comments")
-    expect(page).to have_selector("article.comment", count: comments.length)
+    expect(page).to have_selector(".comment", count: comments.length)
 
     within "#comments" do
       comments.each do |comment|
         expect(page).to have_content comment.author.name
-        expect(page).to have_content comment.body
+        expect(page).to have_content comment.body.values.first
       end
     end
   end
@@ -34,7 +38,13 @@ shared_examples "comments" do
     expect(page).to have_css(".comment", minimum: 1)
     page.find(".order-by .dropdown.menu .is-dropdown-submenu-parent").hover
 
-    click_link "Best rated"
+    within ".comments" do
+      within ".order-by__dropdown" do
+        click_link "Older" # Opens the dropdown
+        click_link "Best rated"
+      end
+    end
+
     expect(page).to have_css(".comments > div:nth-child(2)", text: "Most Rated Comment")
   end
 
@@ -55,6 +65,35 @@ shared_examples "comments" do
       expect(page).to have_selector(".add-comment form")
     end
 
+    context "when no default comments length specified" do
+      it "displays the numbers of characters left" do
+        within ".add-comment form" do
+          expect(page).to have_content("1000 characters left")
+        end
+      end
+    end
+
+    context "when organization has a default comments length params" do
+      let!(:organization) { create(:organization, comments_max_length: 2000) }
+
+      it "displays the numbers of characters left" do
+        within ".add-comment form" do
+          expect(page).to have_content("2000 characters left")
+        end
+      end
+
+      context "when component has a default comments length params" do
+        it "displays the numbers of characters left" do
+          component.update!(settings: { comments_max_length: 3000 })
+          visit current_path
+
+          within ".add-comment form" do
+            expect(page).to have_content("3000 characters left")
+          end
+        end
+      end
+    end
+
     context "when user adds a new comment" do
       before do
         within ".add-comment form" do
@@ -64,7 +103,7 @@ shared_examples "comments" do
       end
 
       it "shows comment to the user" do
-        expect(page).to have_comment_from(user, "This is a new comment")
+        expect(page).to have_comment_from(user, "This is a new comment", wait: 20)
       end
     end
 
@@ -86,7 +125,7 @@ shared_examples "comments" do
           click_button "Send"
         end
 
-        expect(page).to have_comment_from(user_group, "This is a new comment")
+        expect(page).to have_comment_from(user_group, "This is a new comment", wait: 20)
       end
     end
 
@@ -110,7 +149,7 @@ shared_examples "comments" do
           click_button "Send"
         end
 
-        expect(page).to have_selector(".comment-thread .comment--nested")
+        expect(page).to have_selector(".comment-thread .comment--nested", wait: 20)
         expect(page).to have_selector(".comment__additionalreply")
         expect(page).to have_reply_to(comment, "This is a reply")
       end
@@ -150,7 +189,7 @@ shared_examples "comments" do
             end
 
             within "#comments" do
-              expect(page).to have_selector "span.success.label", text: "In favor"
+              expect(page).to have_selector "span.success.label", text: "In favor", wait: 20
             end
           else
             expect(page).to have_no_selector(".opinion-toggle--ok")
@@ -229,6 +268,15 @@ shared_examples "comments" do
           expect(page).not_to have_selector(".tribute-container")
         end
       end
+
+      context "when mentioning a group" do
+        let!(:mentioned_group) { create(:user_group, :confirmed, organization: organization) }
+        let(:content) { "A confirmed user group mention: @#{mentioned_group.nickname}" }
+
+        it "shows the tribute container" do
+          expect(page).to have_selector(".tribute-container")
+        end
+      end
     end
 
     describe "mentions", :slow do
@@ -247,7 +295,7 @@ shared_examples "comments" do
         let(:content) { "A valid user mention: @#{mentioned_user.nickname}." }
 
         it "replaces the mention with a link to the user's profile" do
-          expect(page).to have_comment_from(user, "A valid user mention: @#{mentioned_user.nickname}")
+          expect(page).to have_comment_from(user, "A valid user mention: @#{mentioned_user.nickname}", wait: 20)
           expect(page).to have_link "@#{mentioned_user.nickname}", href: "/profiles/#{mentioned_user.nickname}"
         end
       end
@@ -257,7 +305,7 @@ shared_examples "comments" do
         let(:content) { "This text mentions a user outside current organization: @#{mentioned_user.nickname}" }
 
         it "ignores the mention" do
-          expect(page).to have_comment_from(user, "This text mentions a user outside current organization: @#{mentioned_user.nickname}")
+          expect(page).to have_comment_from(user, "This text mentions a user outside current organization: @#{mentioned_user.nickname}", wait: 20)
           expect(page).not_to have_link "@#{mentioned_user.nickname}"
         end
       end
@@ -266,10 +314,28 @@ shared_examples "comments" do
         let(:content) { "This text mentions a @nonexistent user" }
 
         it "ignores the mention" do
-          expect(page).to have_comment_from(user, "This text mentions a @nonexistent user")
+          expect(page).to have_comment_from(user, "This text mentions a @nonexistent user", wait: 20)
           expect(page).not_to have_link "@nonexistent"
         end
       end
     end
+
+    describe "hashtags", :slow do
+      let(:content) { "A comment with a hashtag #decidim" }
+
+      before do
+        visit resource_path
+
+        within ".add-comment form" do
+          fill_in "add-comment-#{commentable.commentable_type}-#{commentable.id}", with: content
+          click_button "Send"
+        end
+      end
+
+      it "replaces the hashtag with a link to the hashtag search" do
+        expect(page).to have_comment_from(user, "A comment with a hashtag #decidim", wait: 20)
+        expect(page).to have_link "#decidim", href: "/search?term=%23decidim"
+      end
+    end
   end
 end

data/lib/decidim/core/test/shared_examples/edit_link_shared_examples.rb

@@ -1,10 +1,14 @@
 # frozen_string_literal: true
 
+# When using these shared examples, make sure there are no prior requests within
+# the same group of examples where this is included. Otherwise you may end up
+# in race conditions that cause these to fail as explained at:
+# https://github.com/decidim/decidim/pull/6161
 shared_examples "editable content for admins" do
   describe "edit link" do
     before do
       relogin_as user
-      visit current_path
+      visit target_path
     end
 
     context "when I'm an admin user" do