decidim-core 0.19.1 → 0.23.0

data/lib/decidim/core/test/shared_examples/searchable_resources_shared_context.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+RSpec.shared_context "when a resource is ready for global search" do
+  let!(:organization) { create(:organization) }
+  let!(:author) { create(:user, :admin, organization: organization) }
+  let!(:scope1) { create :scope, organization: organization }
+
+  let(:test_locales) { [:ca, :en, :es] }
+  let(:description_1) do
+    Decidim::Faker::Localized.prefixed("Poemes als terrats de l'Empordà, Ow!", test_locales)
+  end
+end

data/lib/decidim/core/test/shared_examples/searchable_results_examples.rb

@@ -12,16 +12,29 @@ shared_examples "searchable results" do
     before do
       expect(searchables).not_to be_empty
       expect(term).not_to be_empty
+    end
 
+    it "contains these searchables" do
       fill_in "term", with: term
       find("input#term").native.send_keys :enter
-    end
 
-    it "contains these searchables" do
       expect(page).to have_current_path decidim.search_path, ignore_query: true
       expect(page).to have_content(/results for the search: "#{term}"/i)
       expect(page).to have_selector(".filters__section")
       expect(page.find("#search-count .section-heading").text.to_i).to be_positive
     end
+
+    it "finds content by hashtag" do
+      if respond_to?(:hashtag)
+        fill_in "term", with: hashtag
+        find("input#term").native.send_keys :enter
+
+        expect(page.find("#search-count .section-heading").text.to_i).to be_positive
+
+        within "#results" do
+          expect(page).to have_content(hashtag)
+        end
+      end
+    end
   end
 end

data/lib/decidim/core/test/shared_examples/simple_event.rb

@@ -29,6 +29,7 @@ shared_context "when a simple event" do
   let(:resource_path) { resource_locator(resource).path }
   let(:resource_url) { resource_locator(resource).url }
   let(:resource_title) { resource.title["en"] }
+  # to be used when resource is a component resource, not a participatory space, in which case should be overriden
   let(:participatory_space) { resource.participatory_space }
   let(:participatory_space_title) { participatory_space.title["en"] }
   let(:participatory_space_path) { Decidim::ResourceLocatorPresenter.new(participatory_space).path }
@@ -88,6 +89,13 @@ shared_examples_for "a simple event" do |skip_space_checks|
     end
   end
 
+  describe "safe_resource_text" do
+    it "is generated correctly" do
+      expect(subject.safe_resource_text).to be_kind_of(String)
+      expect(subject.safe_resource_text).to be_html_safe
+    end
+  end
+
   describe "notification_title" do
     it "is generated correctly" do
       expect(subject.notification_title).to be_kind_of(String)

data/lib/decidim/core/test/shared_examples/system_endorse_resource_examples.rb

@@ -0,0 +1,166 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_context "with resources to be endorsed or not" do
+  include_context "with a component"
+
+  # Should be overriden and create one main resource
+  let!(:resource) {}
+  # the name of the resource to be clicked from the component view
+  let(:resource_name) {}
+  # Should be overriden and create 3 extra resources in the current component
+  let!(:resources) {}
+end
+
+shared_examples "Endorse resource system specs" do
+  def expect_page_not_to_include_endorsements
+    expect(page).to have_no_button("Endorse")
+    expect(page).to have_no_css("#resource-#{resource.id}-endorsements-count")
+  end
+
+  def visit_resource
+    visit_component
+    click_link resource_name
+  end
+
+  context "when endorsements are not enabled" do
+    let(:component_traits) { [:with_votes_enabled, :with_endorsements_disabled] }
+
+    context "when the user is not logged in" do
+      it "doesn't show the endorse resource button and counts" do
+        visit_resource
+        expect_page_not_to_include_endorsements
+      end
+    end
+
+    context "when the user is logged in" do
+      before do
+        login_as user, scope: :user
+      end
+
+      it "doesn't show the endorse resource button and counts" do
+        visit_resource
+        expect_page_not_to_include_endorsements
+      end
+    end
+  end
+
+  context "when endorsements are enabled but blocked" do
+    let(:component_traits) { [:with_endorsements_enabled, :with_endorsements_blocked] }
+
+    it "shows the endorsements count and the endorse button is disabled" do
+      visit_resource
+      expect(page).to have_css(".buttons__row span[disabled]")
+    end
+  end
+
+  context "when endorsements are enabled" do
+    let(:component_traits) { [:with_votes_enabled, :with_endorsements_enabled] }
+
+    context "when the user is not logged in" do
+      it "is given the option to sign in" do
+        visit_resource
+        within ".buttons__row", match: :first do
+          click_button "Endorse"
+        end
+
+        expect(page).to have_css("#loginModal", visible: :visible)
+      end
+    end
+
+    context "when the user is logged in" do
+      before do
+        login_as user, scope: :user
+      end
+
+      context "when the resource is not endorsed yet" do
+        it "is able to endorse the resource" do
+          visit_resource
+          within ".buttons__row" do
+            click_button "Endorse"
+            expect(page).to have_button("Endorsed")
+          end
+
+          within "#resource-#{resource.id}-endorsements-count" do
+            expect(page).to have_content("1")
+          end
+        end
+      end
+
+      context "when the resource is already endorsed" do
+        let!(:endorsement) { create(:endorsement, resource: resource, author: user) }
+
+        it "is not able to endorse it again" do
+          visit_resource
+          within ".buttons__row" do
+            expect(page).to have_button("Endorsed")
+            expect(page).to have_no_button("Endorse ")
+          end
+
+          within "#resource-#{resource.id}-endorsements-count" do
+            expect(page).to have_content("1")
+          end
+        end
+
+        it "is able to undo the endorsement" do
+          visit_resource
+          within ".buttons__row" do
+            click_button "Endorsed"
+            expect(page).to have_button("Endorse")
+          end
+
+          within "#resource-#{resource.id}-endorsements-count" do
+            expect(page).to have_content("0")
+          end
+        end
+      end
+
+      context "when verification is required" do
+        let(:permissions) do
+          {
+            endorse: {
+              authorization_handlers: {
+                "dummy_authorization_handler" => { "options" => {} }
+              }
+            }
+          }
+        end
+
+        before do
+          organization.available_authorizations = ["dummy_authorization_handler"]
+          organization.save!
+          component.update(permissions: permissions)
+        end
+
+        context "when user is NOT verified" do
+          it "is NOT able to endorse" do
+            visit_resource
+            within ".buttons__row", match: :first do
+              click_button "Endorse"
+            end
+            expect(page).to have_css("#authorizationModal", visible: :visible)
+          end
+        end
+
+        context "when user IS verified" do
+          before do
+            handler_params = { user: user }
+            handler_name = "dummy_authorization_handler"
+            handler = Decidim::AuthorizationHandler.handler_for(handler_name, handler_params)
+
+            Decidim::Authorization.create_or_update_from(handler)
+          end
+
+          it "IS able to endorse", :slow do
+            visit_resource
+            within ".buttons__row", match: :first do
+              click_button "Endorse"
+            end
+            expect(page).to have_button("Endorsed")
+          end
+        end
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/timestamps_interface_examples.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "timestamps interface" do
+  describe "createdAt" do
+    let(:query) { "{ createdAt }" }
+
+    it "returns when was this query created at" do
+      expect(response["createdAt"]).to eq(model.created_at.to_time.iso8601)
+    end
+  end
+
+  describe "updatedAt" do
+    let(:query) { "{ updatedAt }" }
+
+    it "returns when was this query updated at" do
+      expect(response["updatedAt"]).to eq(model.updated_at.to_time.iso8601)
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/traceable_interface_examples.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "traceable interface" do
+  describe "traceable", versioning: true do
+    let(:version_author) { try(:author) || model.try(:creator_identity) || model.try(:normalized_author) }
+
+    before { Decidim.traceability.update!(model, version_author, title: { en: "test" }) }
+
+    context "when field createdAt" do
+      let(:query) { "{ versions { createdAt } }" }
+
+      it "returns created_at field of the version to iso format" do
+        dates = response["versions"].map { |version| version["createdAt"] }
+        expect(dates).to include(*model.versions.map { |version| version.created_at.to_time.iso8601 })
+      end
+    end
+
+    context "when field id" do
+      let(:query) { "{ versions { id } }" }
+
+      it "returns ID field of the version" do
+        ids = response["versions"].map { |version| version["id"].to_i }
+        expect(ids).to include(*model.versions.map(&:id))
+      end
+    end
+
+    context "when field editor" do
+      let(:query) { "{ versions { editor { name } } }" }
+
+      it "returns editor field of the versions" do
+        editors = response["versions"].map { |version| version["editor"]["name"] if version["editor"] }
+        expect(editors).to include(*model.versions.map { |version| version.editor.name if version.respond_to? :editor })
+      end
+    end
+
+    context "when field changeset" do
+      let(:query) { "{ versions { changeset } }" }
+
+      it "returns changeset field of the versions" do
+        changesets = response["versions"].map { |version| version["changeset"] }
+        expect(changesets).to include(*model.versions.map(&:changeset))
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/uncommentable_component_examples.rb

@@ -14,7 +14,7 @@ shared_examples "an uncommentable component" do
 
     visit_component
 
-    ressources.each do |ressource|
+    resources.each do |ressource|
       expect(page).not_to have_link(resource_locator(ressource).path)
     end
   end

data/lib/decidim/core/test/shared_examples/with_endorsable_permissions_examples.rb

@@ -0,0 +1,89 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+# users of this test should delare the `subject` variable.
+shared_examples "with endorsable permissions can perform actions related to endorsable" do
+  let(:action_subject) { :endorsement }
+  let(:resource) { create :dummy_resource }
+  before do
+    context[:current_settings] = double(current_settings)
+    context[:resource] = resource
+  end
+
+  describe "endorsing" do
+    describe "when endorsing" do
+      let(:action_name) { :create }
+
+      context "when endorsements are disabled" do
+        let(:current_settings) do
+          {
+            endorsements_enabled: false,
+            endorsements_blocked: false
+          }
+        end
+
+        it { is_expected.to eq false }
+      end
+
+      context "when endorsements are blocked" do
+        let(:current_settings) do
+          {
+            endorsements_enabled: true,
+            endorsements_blocked: true
+          }
+        end
+
+        it { is_expected.to eq false }
+      end
+
+      context "when user is authorized" do
+        let(:current_settings) do
+          {
+            endorsements_enabled: true,
+            endorsements_blocked: false
+          }
+        end
+
+        it { is_expected.to eq true }
+      end
+    end
+  end
+
+  describe "unendorsing" do
+    let(:action_name) { :unendorse }
+
+    context "when endorsements are disabled" do
+      let(:current_settings) do
+        {
+          endorsements_enabled: false,
+          endorsements_blocked: false
+        }
+      end
+
+      it { is_expected.to eq false }
+    end
+
+    context "when endorsements are blocked" do
+      let(:current_settings) do
+        {
+          endorsements_enabled: true,
+          endorsements_blocked: true
+        }
+      end
+
+      it { is_expected.to eq false }
+    end
+
+    context "when user is authorized" do
+      let(:current_settings) do
+        {
+          endorsements_enabled: true,
+          endorsements_blocked: false
+        }
+      end
+
+      it { is_expected.to eq true }
+    end
+  end
+end

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.19.1"
+      "0.23.0"
     end
   end
 end

data/lib/decidim/deprecations.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Decidim
+  #
+  # This class handles all logic regarding deprecated methods.
+  #
+  module Deprecations
+    # Define a deprecated alias for a method
+    #
+    # @param [Symbol] old_name - name of the method to deprecate
+    # @param [Symbol] replacement - name of the new method to use
+    def deprecated_alias(old_name, replacement)
+      define_method(old_name) do |*args, &block|
+        ActiveSupport::Deprecation.warn "##{old_name} deprecated (please use ##{replacement})"
+        send replacement, *args, &block
+      end
+    end
+  end
+end

data/lib/decidim/diffy_extension.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module Decidim
+  # Extending Diffy gem to accomodate the needs of app/cells/decidim/diff_cell.rb
+  module DiffyExtension
+    # HtmlFormatter that returns basic html output (no inline highlighting)
+    # and does not escape HTML tags.
+    class UnescapedHtmlFormatter < Diffy::HtmlFormatter
+      # We exclude the tags `del` and `ins` so the diffy styling does not apply.
+      TAGS = (UserInputScrubber.new.tags.to_a - %w(del ins)).freeze
+
+      def to_s
+        str = wrap_lines(@diff.map { |line| wrap_line(line) })
+        ActionView::Base.new.sanitize(str, tags: TAGS)
+      end
+    end
+
+    # Adding a new method to Diffy::Format so we can pass the
+    # `:unescaped_html` option when calling Diffy::Diff#to_s.
+    Diffy::Format.module_eval do
+      def unescaped_html
+        UnescapedHtmlFormatter.new(self, options).to_s
+      end
+    end
+
+    # The private "split" method SplitDiff needs to be overriden to take into
+    # account the new :unescaped_html format, and the fact that the tags
+    # <ins> <del> are not there anymore
+    Diffy::SplitDiff.module_eval do
+      private
+
+      def split
+        return [split_left, split_right] unless @format == :unescaped_html
+
+        [unescaped_split_left, unescaped_split_right]
+      end
+
+      def unescaped_split_left
+        @diff.gsub(%r{<li class="ins">([\s\S]*?)<\/li>}, "")
+      end
+
+      def unescaped_split_right
+        @diff.gsub(%r{<li class="del">([\s\S]*?)<\/li>}, "")
+      end
+    end
+  end
+end