danger-wcc 0.0.2

data/spec/wcc/todos_spec.rb

@@ -0,0 +1,96 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:html_link) do |text|
+        "<a href=\"github_html_link\">#{text}</a>"
+      end
+    end
+
+    describe 'todos' do
+      it 'Warns when TODO added' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff('spec/fixtures/todo.rb', 'todo_no_link')])
+
+        # act
+        @my_plugin.todos
+
+        expect(@dangerfile.violation_report[:warnings])
+          .to eq([Violation.new('TODO added in '\
+            '<a href="github_html_link">spec/fixtures/todo.rb</a>'\
+              ' - is there a card associated with that?',
+            false,
+            'spec/fixtures/todo.rb',
+            9)])
+      end
+
+      it 'Does not warn when TODO removed' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff('spec/fixtures/todo.rb', 'todo_removed')])
+
+        # act
+        @my_plugin.todos
+
+        expect(@dangerfile.violation_report[:warnings])
+          .to eq([])
+      end
+
+      it 'Does not warn when no TODO in diff' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff('spec/fixtures/todo.rb', 'no_todo')])
+
+        # act
+        @my_plugin.todos
+
+        expect(@dangerfile.violation_report[:warnings])
+          .to eq([])
+      end
+
+      it 'Sends message when todo has link' do
+        allow(@git).to receive(:diff)
+          .and_return(
+            [load_diff('spec/fixtures/todo.rb', 'todo_link_same_line')]
+          )
+
+        # act
+        @my_plugin.todos
+
+        expect(@dangerfile.violation_report[:messages])
+          .to eq([Violation.new('TODO added in '\
+            '<a href="github_html_link">spec/fixtures/todo.rb</a> '\
+              'referencing [https://zube.io/watermark/asdf1234]'\
+              '(https://zube.io/watermark/asdf1234)',
+            false,
+            'spec/fixtures/todo.rb',
+            13)])
+      end
+
+      it 'Sends message when todo below link' do
+        allow(@git).to receive(:diff)
+          .and_return(
+            [load_diff('spec/fixtures/todo.rb', 'todo_link_next_line')]
+          )
+
+        # act
+        @my_plugin.todos
+
+        expect(@dangerfile.violation_report[:messages])
+          .to eq([Violation.new('TODO added in '\
+            '<a href="github_html_link">spec/fixtures/todo.rb</a> '\
+              'referencing [https://www.github.com/watermarkchurch/asdf/1234]'\
+              '(https://www.github.com/watermarkchurch/asdf/1234)',
+            false,
+            'spec/fixtures/todo.rb',
+            18)])
+      end
+    end
+  end
+end

data/spec/wcc/utils_spec.rb

@@ -0,0 +1,134 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:pr_json)
+        .and_return(JSON.parse(load_fixture('github_pr.json')))
+    end
+
+    describe 'utils#find_in_diff' do
+      it 'returns empty list when no files in diff' do
+        allow(@git).to receive(:diff)
+          .and_return([])
+
+        # act
+        lines = @my_plugin.find_in_diff(/.*/i)
+
+        # assert
+        expect(lines).to eq([])
+      end
+
+      it 'returns list with matching added lines' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff('spec/fixtures/todo.rb', 'no_todo')])
+
+        # act
+        lines = @my_plugin.find_in_diff(/(module|def|end)/i)
+
+        # assert
+        expect(lines.map(&:content)).to eq(
+          [
+            '+module Todo',
+            '+  def this_should_not_trigger_todo',
+            '+  end',
+            '+end'
+          ]
+        )
+      end
+
+      it 'executes block for each matching line' do
+        allow(@git).to receive(:diff)
+          .and_return(
+            [
+              load_diff('spec/fixtures/todo.rb', 'no_todo'),
+              load_diff('spec/fixtures/find_in_diff.rb',
+                'find_in_diff_2_chunks')
+            ]
+          )
+
+        lines = []
+
+        # act
+        @my_plugin.find_in_diff(/\#\s*(.+)$/i) do |match, line, hunk, file|
+          lines.push({
+            group: match.captures[0],
+            line: line,
+            hunk: hunk,
+            file: file
+          })
+        end
+
+        # assert
+        expect(lines.map { |l| l[:line].content }).to eq(
+          [
+            '+# frozen_string_literal: true',
+            '+    # This should appear in hunk 1',
+            '+    # This should appear in hunk 2'
+          ]
+        )
+        expect(lines.map { |l| l[:group] }).to eq(
+          [
+            'frozen_string_literal: true',
+            'This should appear in hunk 1',
+            'This should appear in hunk 2'
+          ]
+        )
+        expect(lines.map { |l| l[:hunk].range_info.new_range.start }).to eq(
+          [
+            1,
+            1,
+            14
+          ]
+        )
+      end
+    end
+
+    describe 'utils#run_and_diff' do
+      it 'runs command and builds diff' do
+        # setup
+        File.write('README.md', 'something else')
+        begin
+          # act
+          diff = @my_plugin.run_and_diff('cat README.md')
+          diff = GitDiff.from_string(diff)
+
+          # assert
+          expect(diff.files[0].hunks[0].lines.size).to be > 1
+          additions = diff.files[0].hunks[0].lines.select(&:addition?)
+          expect(additions.length).to eq(1)
+          expect(additions[0].content).to eq('+something else')
+        ensure
+          `git checkout HEAD -- README.md`
+        end
+      end
+
+      it 'runs command from block' do
+        # setup
+        dir = Dir.pwd
+
+        # act
+        diff = @my_plugin.run_and_diff { Dir.pwd }
+        diff = GitDiff.from_string(diff)
+
+        # assert
+        expect(diff.files[0].hunks[0].lines.size).to be > 1
+
+        additions = diff.files[0].hunks[0].lines.select(&:addition?)
+        expect(additions.length).to eq(1)
+        expect(additions[0].content).to eq("+#{dir}")
+
+        deletions = diff.files[0].hunks[0].lines.select(&:deletion?)
+        expect(deletions.length).to eq(1)
+        expect(deletions[0].content).to_not include(dir)
+      end
+    end
+  end
+end

data/spec/wcc_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerWCC do
+    it 'should be a plugin' do
+      expect(Danger::DangerWCC.new(nil)).to be_a Danger::Plugin
+    end
+
+    #
+    # You should test your custom attributes and methods here
+    #
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @my_plugin = @dangerfile.wcc
+      end
+    end
+  end
+end

metadata

@@ -0,0 +1,393 @@
+--- !ruby/object:Gem::Specification
+name: danger-wcc
+version: !ruby/object:Gem::Version
+  version: 0.0.2
+platform: ruby
+authors:
+- Watermark Dev
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2018-01-23 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: brakeman
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: danger-plugin-api
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: flay
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: git_diff
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.3'
+- !ruby/object:Gem::Dependency
+  name: reek
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+- !ruby/object:Gem::Dependency
+  name: guard-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.0
+- !ruby/object:Gem::Dependency
+  name: listen
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.7
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: A Danger plugin for Watermark Church custom rules.
+email:
+- dev@watermark.org
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".circleci/config.yml"
+- ".gitignore"
+- ".rubocop.yml"
+- ".ruby-version"
+- ".travis.yml"
+- Dangerfile
+- Gemfile
+- Guardfile
+- LICENSE
+- README.md
+- Rakefile
+- danger-wcc.gemspec
+- lib/danger_plugin.rb
+- lib/version.rb
+- lib/wcc/commit_lint.rb
+- lib/wcc/commit_lint/README.md
+- lib/wcc/commit_lint/commit_check.rb
+- lib/wcc/commit_lint/empty_line_check.rb
+- lib/wcc/commit_lint/subject_cap_check.rb
+- lib/wcc/commit_lint/subject_length_check.rb
+- lib/wcc/commit_lint/subject_period_check.rb
+- lib/wcc/commit_lint/subject_words_check.rb
+- lib/wcc/default.jshintrc
+- lib/wcc/defaults.reek
+- lib/wcc/github.rb
+- lib/wcc/jshint.rb
+- lib/wcc/plugin.rb
+- lib/wcc/reek.rb
+- lib/wcc/rubocop_exceptions.rb
+- lib/wcc/todos.rb
+- lib/wcc/utils.rb
+- spec/fixtures/brakeman/a.tmp
+- spec/fixtures/brakeman/b.tmp
+- spec/fixtures/brakeman/brakeman.diff
+- spec/fixtures/brakeman/brakeman.out
+- spec/fixtures/exception_context.diff
+- spec/fixtures/exception_insert_context.diff
+- spec/fixtures/exception_misspelled.diff
+- spec/fixtures/exception_multiline_context.diff
+- spec/fixtures/exception_reenabled.diff
+- spec/fixtures/find_in_diff.rb
+- spec/fixtures/find_in_diff_2_chunks.diff
+- spec/fixtures/flay.diff
+- spec/fixtures/flay.txt
+- spec/fixtures/github/labels.json
+- spec/fixtures/github_pr.json
+- spec/fixtures/jshint/a.tmp
+- spec/fixtures/jshint/b.tmp
+- spec/fixtures/jshint/jshint.diff
+- spec/fixtures/jshint/out.jshint
+- spec/fixtures/no_exception.diff
+- spec/fixtures/no_todo.diff
+- spec/fixtures/reek/line_numbers.reek
+- spec/fixtures/reek/reek.diff
+- spec/fixtures/rubocop_exception.rb
+- spec/fixtures/todo.rb
+- spec/fixtures/todo_link_next_line.diff
+- spec/fixtures/todo_link_same_line.diff
+- spec/fixtures/todo_no_link.diff
+- spec/fixtures/todo_removed.diff
+- spec/fixtures_helper.rb
+- spec/spec_helper.rb
+- spec/wcc/commit_lint_spec.rb
+- spec/wcc/github_spec.rb
+- spec/wcc/jshint_spec.rb
+- spec/wcc/plugin_spec.rb
+- spec/wcc/reek_spec.rb
+- spec/wcc/rubocop_exceptions_spec.rb
+- spec/wcc/todos_spec.rb
+- spec/wcc/utils_spec.rb
+- spec/wcc_spec.rb
+homepage: https://github.com/watermarkchurch/danger-wcc
+licenses:
+- Apache-2.0
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.6.11
+signing_key: 
+specification_version: 4
+summary: A Danger plugin for Watermark Church custom rules.
+test_files:
+- spec/fixtures/brakeman/a.tmp
+- spec/fixtures/brakeman/b.tmp
+- spec/fixtures/brakeman/brakeman.diff
+- spec/fixtures/brakeman/brakeman.out
+- spec/fixtures/exception_context.diff
+- spec/fixtures/exception_insert_context.diff
+- spec/fixtures/exception_misspelled.diff
+- spec/fixtures/exception_multiline_context.diff
+- spec/fixtures/exception_reenabled.diff
+- spec/fixtures/find_in_diff.rb
+- spec/fixtures/find_in_diff_2_chunks.diff
+- spec/fixtures/flay.diff
+- spec/fixtures/flay.txt
+- spec/fixtures/github/labels.json
+- spec/fixtures/github_pr.json
+- spec/fixtures/jshint/a.tmp
+- spec/fixtures/jshint/b.tmp
+- spec/fixtures/jshint/jshint.diff
+- spec/fixtures/jshint/out.jshint
+- spec/fixtures/no_exception.diff
+- spec/fixtures/no_todo.diff
+- spec/fixtures/reek/line_numbers.reek
+- spec/fixtures/reek/reek.diff
+- spec/fixtures/rubocop_exception.rb
+- spec/fixtures/todo.rb
+- spec/fixtures/todo_link_next_line.diff
+- spec/fixtures/todo_link_same_line.diff
+- spec/fixtures/todo_no_link.diff
+- spec/fixtures/todo_removed.diff
+- spec/fixtures_helper.rb
+- spec/spec_helper.rb
+- spec/wcc/commit_lint_spec.rb
+- spec/wcc/github_spec.rb
+- spec/wcc/jshint_spec.rb
+- spec/wcc/plugin_spec.rb
+- spec/wcc/reek_spec.rb
+- spec/wcc/rubocop_exceptions_spec.rb
+- spec/wcc/todos_spec.rb
+- spec/wcc/utils_spec.rb
+- spec/wcc_spec.rb