danger-wcc 0.0.2

data/spec/wcc/github_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../spec_helper', __FILE__)
+require 'webmock'
+
+module Danger
+  include FixturesHelper
+
+  API_URL = 'https://api.github.com'
+
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:pr_json)
+        .and_return(JSON.parse(load_fixture('github_pr.json')))
+    end
+
+    describe 'github' do
+      before do
+        stub_request(:get, API_URL + '/repos/watermarkchurch/danger-wcc/labels')
+          .with(query: hash_excluding({ 'anything' => 1 }))
+          .to_return(
+            body: load_fixture('github/labels.json'),
+            headers: { 'Content-Type' => 'application/json' }
+          )
+      end
+
+      it '#labels returns array of existing labels' do
+        # act
+        labels = @my_plugin.labels
+
+        # assert
+        expect(labels.length).to eq(10)
+      end
+
+      it '#add_labels adds existing labels to issue' do
+        stub = stub_request(:post,
+          API_URL + '/repos/watermarkchurch/danger-wcc/issues/2/labels')
+          .with(body: '["backlog","bug","duplicate"]')
+
+        # act
+        @my_plugin.add_labels('backlog', 'bug', 'duplicate')
+
+        # assert
+        expect(stub).to have_been_requested
+      end
+
+      it '#add_labels creates new labels before adding to issue' do
+        stub = stub_request(:post,
+          API_URL + '/repos/watermarkchurch/danger-wcc/labels')
+          .with(body: '{"name":"new_label","color":"ffffff"}')
+        stub_request(:post,
+          API_URL + '/repos/watermarkchurch/danger-wcc/issues/2/labels')
+          .with(body: '["backlog","new_label"]')
+
+        # act
+        @my_plugin.add_labels('backlog', 'new_label')
+
+        # assert
+        expect(stub).to have_been_requested
+      end
+    end
+  end
+end

data/spec/wcc/jshint_spec.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:pr_json)
+        .and_return(JSON.parse(load_fixture('github_pr.json')))
+      allow(subject).to receive(:run)
+        .with(/npm/)
+        .and_return('')
+      allow(subject).to receive(:run_and_diff)
+        .and_return(load_fixture('jshint/jshint.diff'))
+      allow(subject).to receive(:run)
+        .with(/\/tmp\/.+\/jshint/)
+        .and_return(load_fixture('jshint/out.jshint'))
+      allow(Dir).to receive(:exist?)
+        .with('app/assets/javascripts')
+        .and_return(true)
+    end
+
+    describe 'jshint' do
+      let(:subject) { Danger::DangerWCC::Jshint.new(@my_plugin) }
+
+      after do
+        File.delete('.jshint') if File.file?('.jshint')
+      end
+
+      it 'runs jshint and parses diff' do
+        # act
+        subject.perform
+
+        # assert
+        warnings = @dangerfile.violation_report[:warnings]
+        expect(warnings.length).to eq(2)
+
+        expect(warnings[0].message)
+          .to eq("Misleading line break before '+'; readers may interpret this"\
+          ' as an expression boundary.')
+        expect(warnings[0].file).to eq('app/assets/javascripts/comment.js')
+        expect(warnings[0].line).to eq(42)
+
+        expect(warnings.last.message)
+          .to eq("['AM'] is better written in dot notation.")
+        expect(warnings.last.file).to eq('app/assets/javascripts/mobiscroll.js')
+        expect(warnings.last.line).to eq(3)
+      end
+
+      it 'writes .jshint only if .jshint doesnt exist' do
+        begin
+          File.write('.jshint', '{}')
+
+          subject.perform
+
+          expect(File.read('.jshint')).to eq('{}')
+        ensure
+          File.delete('.jshint')
+        end
+      end
+    end
+  end
+end

data/spec/wcc/plugin_spec.rb

@@ -0,0 +1,134 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:html_link) do |text|
+        "<a href=\"github_html_link\">#{text}</a>"
+      end
+    end
+
+    describe 'all' do
+      it 'runs all checks and passes default options' do
+        Danger::DangerWCC::CHECKS.each do |check|
+          expect(@my_plugin).to receive(check)
+            .with({})
+        end
+
+        # act
+        @my_plugin.all
+      end
+
+      it 'errors if all checks disabled' do
+        disabled = Danger::DangerWCC::CHECKS
+        options = disabled.each_with_object({}) { |v, h| h[v] = false; }
+
+        # expect
+        disabled.each do |check|
+          expect(@my_plugin).to_not receive(check)
+        end
+
+        # act
+        expect {
+          @my_plugin.all(options)
+        }.to raise_error(ArgumentError)
+      end
+
+      it 'runs only enabled checks' do
+        enabled = %i[todos commit_lint]
+        disabled =
+          Danger::DangerWCC::CHECKS.reject do |check|
+            enabled.include?(check)
+          end
+        options = disabled.each_with_object({}) { |v, h| h[v] = false; }
+
+        # expect
+        enabled.each do |check|
+          expect(@my_plugin).to receive(check)
+        end
+        disabled.each do |check|
+          expect(@my_plugin).to_not receive(check)
+        end
+
+        # act
+        @my_plugin.all options
+      end
+
+      it 'passes options' do
+        options =
+          Danger::DangerWCC::CHECKS.each_with_object({}) do |v, h|
+            h[v] = false
+          end
+        options[:commit_lint] = { test: { options: 1 } }
+
+        # expect
+        expect(@my_plugin).to receive(:commit_lint)
+          .with({ test: { options: 1 } })
+
+        # act
+        @my_plugin.all options
+      end
+    end
+
+    describe 'brakeman' do
+      it 'runs brakeman and parses diff' do
+        allow(@my_plugin).to receive(:run_and_diff)
+          .with(/^bundle exec brakeman/)
+          .and_return(load_fixture('brakeman/brakeman.diff'))
+        allow(@my_plugin).to receive(:run)
+          .with(/^bundle exec brakeman/)
+          .and_return(load_fixture('brakeman/brakeman.out'))
+
+        # act
+        @my_plugin.brakeman
+
+        # expect
+        warnings = @dangerfile.violation_report[:errors]
+        expect(warnings.length).to eq(2)
+
+        expect(warnings[0].message)
+          .to match(/SSL Verification Bypass/)
+        expect(warnings[0].file)
+          .to eq('app/controllers/wmoauth_controller.rb')
+        expect(warnings[0].line).to eq(78)
+
+        expect(warnings[1].message)
+          .to match(/Unescaped model attribute near line/)
+        expect(warnings[1].file)
+          .to eq('app/views/sections/_discussion_questions.html.erb')
+        expect(warnings[1].line).to eq(4)
+      end
+    end
+
+    describe 'flay' do
+      it 'runs flay and reports only where changed' do
+        allow(@my_plugin).to receive(:run)
+          .with(/flay/)
+          .and_return(load_fixture('flay.txt'))
+
+        allow(@git).to receive(:diff)
+          .and_return([load_diff(
+            'app/models/discourse.rb',
+            'flay'
+          )])
+
+        # act
+        @my_plugin.flay
+
+        # assert
+        warnings = @dangerfile.violation_report[:warnings]
+        expect(warnings.length).to eq(1)
+        expect(warnings[0].message)
+          .to eq("IDENTICAL code found in :if (mass*2 = 152) at:\n"\
+          '  <a href="github_html_link">app/models/discourse.rb#L177</a>')
+      end
+    end
+  end
+end

data/spec/wcc/reek_spec.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:pr_json)
+        .and_return(JSON.parse(load_fixture('github_pr.json')))
+      allow(@github).to receive(:html_link) do |text|
+        "<a href=\"github_html_link\">#{text}</a>"
+      end
+    end
+
+    describe 'reek' do
+      let(:subject) { Danger::DangerWCC::Reek.new(@my_plugin) }
+
+      after do
+        File.delete('defaults.reek') if File.file?('defaults.reek')
+      end
+
+      it 'runs reek and parses diff' do
+        allow(subject).to receive(:run_and_diff)
+          .and_return(load_fixture('reek/reek.diff'))
+        allow(subject).to receive(:run)
+          .with(/^bundle exec reek/)
+          .and_return(load_fixture('reek/line_numbers.reek'))
+
+        # act
+        subject.perform
+
+        # expect
+        warnings = @dangerfile.violation_report[:warnings]
+        expect(warnings.length).to eq(6)
+
+        expect(warnings[0].message)
+          .to eq('TooManyStatements: Danger::DangerWCC#reek has approx 7 '\
+          'statements [https://github.com/troessner/reek/blob/master/docs/'\
+          'Too-Many-Statements.md](https://github.com/troessner/reek/blob/'\
+          'master/docs/Too-Many-Statements.md)')
+        expect(warnings[0].file).to eq('lib/wcc/plugin.rb')
+        expect(warnings[0].line).to eq(53)
+
+        expect(warnings.last.message)
+          .to eq('IrresponsibleModule: Danger has no descriptive comment '\
+          '[https://github.com/troessner/reek/blob/master/docs/'\
+          'Irresponsible-Module.md](https://github.com/troessner/reek/blob/'\
+          'master/docs/Irresponsible-Module.md)')
+        expect(warnings.last.file).to eq('spec/wcc/plugin_spec.rb')
+        expect(warnings.last.line).to eq(5)
+      end
+
+      it 'writes defaults.reek only if .reek doesnt exist' do
+        begin
+          File.write('.reek', '')
+
+          subject.perform
+
+          expect(File.file?('defaults.reek')).to be false
+        ensure
+          File.delete('.reek')
+        end
+      end
+    end
+  end
+end

data/spec/wcc/rubocop_exceptions_spec.rb

@@ -0,0 +1,136 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:html_link) do |text|
+        "<a href=\"github_html_link\">#{text}</a>"
+      end
+    end
+
+    describe 'rubocop exceptions' do
+      it 'Warns when Rubocop exception added without context' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff(
+            'spec/fixtures/rubocop_exception.rb',
+            'exception_reenabled'
+          )])
+
+        # act
+        @my_plugin.rubocop_exceptions
+
+        expect(@dangerfile.violation_report[:warnings])
+          .to eq([Violation.new('Rubocop rule Rails/SomeRule disabled in '\
+            '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
+              "  \nPlease provide an explanation why this rule was disabled.",
+            false,
+            'spec/fixtures/rubocop_exception.rb',
+            5)])
+      end
+
+      it 'Errors when rubocop exception not reenabled' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff(
+            'spec/fixtures/rubocop_exception.rb',
+            'exception_misspelled'
+          )])
+
+        # act
+        @my_plugin.rubocop_exceptions
+
+        expect(@dangerfile.violation_report[:errors])
+          .to eq([Violation.new('Rubocop rule Lint/SomeLint disabled in '\
+            '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
+              "  \nPlease provide an explanation why this rule was disabled."\
+              "\n\nThe rule was not reenabled!\n"\
+              'Please add a `rubocop:enable` comment so the rule is disabled '\
+              'for the minimal scope.',
+            false,
+            'spec/fixtures/rubocop_exception.rb',
+            10)])
+      end
+
+      it 'Messages when exception added with context' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff(
+            'spec/fixtures/rubocop_exception.rb',
+            'exception_context'
+          )])
+
+        # act
+        @my_plugin.rubocop_exceptions
+
+        expect(@dangerfile.violation_report[:messages])
+          .to eq([Violation.new('Rubocop rule Metrics/LineLength disabled in '\
+            '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
+            "  explanation:\n\t> Disabling because I want to.",
+            false,
+            'spec/fixtures/rubocop_exception.rb',
+            15)])
+      end
+
+      it 'Messages when exception added with multiline context' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff(
+            'spec/fixtures/rubocop_exception.rb',
+            'exception_multiline_context'
+          )])
+
+        # act
+        @my_plugin.rubocop_exceptions
+
+        expect(@dangerfile.violation_report[:messages])
+          .to eq([Violation.new('Rubocop rule Layout/AlignHash disabled in '\
+            '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
+            '  explanation:'\
+            "\n\t> I want to disable this because.."\
+            "\n\t> I forgot the reasons.",
+            false,
+            'spec/fixtures/rubocop_exception.rb',
+            30)])
+      end
+
+      it 'Messages when exception added in between existing comments' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff(
+            'spec/fixtures/rubocop_exception.rb',
+            'exception_insert_context'
+          )])
+
+        # act
+        @my_plugin.rubocop_exceptions
+
+        expect(@dangerfile.violation_report[:messages])
+          .to eq([Violation.new('Rubocop rule Metrics/ABC disabled in '\
+            '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
+            '  explanation:'\
+            "\n\t> here is my comment why we are disabling ABC",
+            false,
+            'spec/fixtures/rubocop_exception.rb',
+            21)])
+      end
+
+      it 'Does not message when no exception added' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff(
+            'spec/fixtures/rubocop_exception.rb',
+            'no_exception'
+          )])
+
+        # act
+        @my_plugin.rubocop_exceptions
+
+        expect(@dangerfile.violation_report[:messages]).to eq([])
+        expect(@dangerfile.violation_report[:warnings]).to eq([])
+        expect(@dangerfile.violation_report[:errors]).to eq([])
+      end
+    end
+  end
+end