danger-wcc 0.0.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +7 -0
- data/.circleci/config.yml +46 -0
- data/.gitignore +6 -0
- data/.rubocop.yml +219 -0
- data/.ruby-version +1 -0
- data/.travis.yml +12 -0
- data/Dangerfile +5 -0
- data/Gemfile +6 -0
- data/Guardfile +35 -0
- data/LICENSE +201 -0
- data/README.md +2 -0
- data/Rakefile +25 -0
- data/danger-wcc.gemspec +58 -0
- data/lib/danger_plugin.rb +3 -0
- data/lib/version.rb +5 -0
- data/lib/wcc/commit_lint.rb +158 -0
- data/lib/wcc/commit_lint/README.md +3 -0
- data/lib/wcc/commit_lint/commit_check.rb +19 -0
- data/lib/wcc/commit_lint/empty_line_check.rb +22 -0
- data/lib/wcc/commit_lint/subject_cap_check.rb +22 -0
- data/lib/wcc/commit_lint/subject_length_check.rb +28 -0
- data/lib/wcc/commit_lint/subject_period_check.rb +22 -0
- data/lib/wcc/commit_lint/subject_words_check.rb +22 -0
- data/lib/wcc/default.jshintrc +5 -0
- data/lib/wcc/defaults.reek +131 -0
- data/lib/wcc/github.rb +24 -0
- data/lib/wcc/jshint.rb +63 -0
- data/lib/wcc/plugin.rb +128 -0
- data/lib/wcc/reek.rb +56 -0
- data/lib/wcc/rubocop_exceptions.rb +99 -0
- data/lib/wcc/todos.rb +78 -0
- data/lib/wcc/utils.rb +136 -0
- data/spec/fixtures/brakeman/a.tmp +13 -0
- data/spec/fixtures/brakeman/b.tmp +14 -0
- data/spec/fixtures/brakeman/brakeman.diff +20 -0
- data/spec/fixtures/brakeman/brakeman.out +14 -0
- data/spec/fixtures/exception_context.diff +15 -0
- data/spec/fixtures/exception_insert_context.diff +14 -0
- data/spec/fixtures/exception_misspelled.diff +14 -0
- data/spec/fixtures/exception_multiline_context.diff +20 -0
- data/spec/fixtures/exception_reenabled.diff +13 -0
- data/spec/fixtures/find_in_diff.rb +21 -0
- data/spec/fixtures/find_in_diff_2_chunks.diff +24 -0
- data/spec/fixtures/flay.diff +17 -0
- data/spec/fixtures/flay.txt +18 -0
- data/spec/fixtures/github/labels.json +72 -0
- data/spec/fixtures/github_pr.json +325 -0
- data/spec/fixtures/jshint/a.tmp +5 -0
- data/spec/fixtures/jshint/b.tmp +7 -0
- data/spec/fixtures/jshint/jshint.diff +13 -0
- data/spec/fixtures/jshint/out.jshint +7 -0
- data/spec/fixtures/no_exception.diff +10 -0
- data/spec/fixtures/no_todo.diff +13 -0
- data/spec/fixtures/reek/line_numbers.reek +121 -0
- data/spec/fixtures/reek/reek.diff +50 -0
- data/spec/fixtures/rubocop_exception.rb +39 -0
- data/spec/fixtures/todo.rb +21 -0
- data/spec/fixtures/todo_link_next_line.diff +14 -0
- data/spec/fixtures/todo_link_same_line.diff +13 -0
- data/spec/fixtures/todo_no_link.diff +13 -0
- data/spec/fixtures/todo_removed.diff +13 -0
- data/spec/fixtures_helper.rb +19 -0
- data/spec/spec_helper.rb +73 -0
- data/spec/wcc/commit_lint_spec.rb +392 -0
- data/spec/wcc/github_spec.rb +67 -0
- data/spec/wcc/jshint_spec.rb +68 -0
- data/spec/wcc/plugin_spec.rb +134 -0
- data/spec/wcc/reek_spec.rb +71 -0
- data/spec/wcc/rubocop_exceptions_spec.rb +136 -0
- data/spec/wcc/todos_spec.rb +96 -0
- data/spec/wcc/utils_spec.rb +134 -0
- data/spec/wcc_spec.rb +21 -0
- metadata +393 -0
@@ -0,0 +1,325 @@
|
|
1
|
+
{
|
2
|
+
"url": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls/2",
|
3
|
+
"id": 163318535,
|
4
|
+
"html_url": "https://github.com/watermarkchurch/danger-wcc/pull/2",
|
5
|
+
"diff_url": "https://github.com/watermarkchurch/danger-wcc/pull/2.diff",
|
6
|
+
"patch_url": "https://github.com/watermarkchurch/danger-wcc/pull/2.patch",
|
7
|
+
"issue_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues/2",
|
8
|
+
"number": 2,
|
9
|
+
"state": "open",
|
10
|
+
"locked": false,
|
11
|
+
"title": "Brakeman",
|
12
|
+
"user": {
|
13
|
+
"login": "gburgett",
|
14
|
+
"id": 430257,
|
15
|
+
"avatar_url": "https://avatars2.githubusercontent.com/u/430257?v=4",
|
16
|
+
"gravatar_id": "",
|
17
|
+
"url": "https://api.github.com/users/gburgett",
|
18
|
+
"html_url": "https://github.com/gburgett",
|
19
|
+
"followers_url": "https://api.github.com/users/gburgett/followers",
|
20
|
+
"following_url": "https://api.github.com/users/gburgett/following{/other_user}",
|
21
|
+
"gists_url": "https://api.github.com/users/gburgett/gists{/gist_id}",
|
22
|
+
"starred_url": "https://api.github.com/users/gburgett/starred{/owner}{/repo}",
|
23
|
+
"subscriptions_url": "https://api.github.com/users/gburgett/subscriptions",
|
24
|
+
"organizations_url": "https://api.github.com/users/gburgett/orgs",
|
25
|
+
"repos_url": "https://api.github.com/users/gburgett/repos",
|
26
|
+
"events_url": "https://api.github.com/users/gburgett/events{/privacy}",
|
27
|
+
"received_events_url": "https://api.github.com/users/gburgett/received_events",
|
28
|
+
"type": "User",
|
29
|
+
"site_admin": false
|
30
|
+
},
|
31
|
+
"body": "Add Brakeman to plugin",
|
32
|
+
"created_at": "2018-01-16 23: 59: 38 UTC",
|
33
|
+
"updated_at": "2018-01-17 00: 12: 05 UTC",
|
34
|
+
"closed_at": null,
|
35
|
+
"merged_at": null,
|
36
|
+
"merge_commit_sha": "43a0be7dea008f6b8a027f7150af57ad499df88c",
|
37
|
+
"assignee": null,
|
38
|
+
"assignees": [],
|
39
|
+
"requested_reviewers": [],
|
40
|
+
"milestone": null,
|
41
|
+
"commits_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls/2/commits",
|
42
|
+
"review_comments_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls/2/comments",
|
43
|
+
"review_comment_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls/comments{/number}",
|
44
|
+
"comments_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues/2/comments",
|
45
|
+
"statuses_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/statuses/8eba1f974cf91635c6728e0f3a5bc6f42e70eb9a",
|
46
|
+
"head": {
|
47
|
+
"label": "watermarkchurch:brakeman",
|
48
|
+
"ref": "brakeman",
|
49
|
+
"sha": "8eba1f974cf91635c6728e0f3a5bc6f42e70eb9a",
|
50
|
+
"user": {
|
51
|
+
"login": "watermarkchurch",
|
52
|
+
"id": 2896397,
|
53
|
+
"avatar_url": "https://avatars3.githubusercontent.com/u/2896397?v=4",
|
54
|
+
"gravatar_id": "",
|
55
|
+
"url": "https://api.github.com/users/watermarkchurch",
|
56
|
+
"html_url": "https://github.com/watermarkchurch",
|
57
|
+
"followers_url": "https://api.github.com/users/watermarkchurch/followers",
|
58
|
+
"following_url": "https://api.github.com/users/watermarkchurch/following{/other_user}",
|
59
|
+
"gists_url": "https://api.github.com/users/watermarkchurch/gists{/gist_id}",
|
60
|
+
"starred_url": "https://api.github.com/users/watermarkchurch/starred{/owner}{/repo}",
|
61
|
+
"subscriptions_url": "https://api.github.com/users/watermarkchurch/subscriptions",
|
62
|
+
"organizations_url": "https://api.github.com/users/watermarkchurch/orgs",
|
63
|
+
"repos_url": "https://api.github.com/users/watermarkchurch/repos",
|
64
|
+
"events_url": "https://api.github.com/users/watermarkchurch/events{/privacy}",
|
65
|
+
"received_events_url": "https://api.github.com/users/watermarkchurch/received_events",
|
66
|
+
"type": "Organization",
|
67
|
+
"site_admin": false
|
68
|
+
},
|
69
|
+
"repo": {
|
70
|
+
"id": 116075817,
|
71
|
+
"name": "danger-wcc",
|
72
|
+
"full_name": "watermarkchurch/danger-wcc",
|
73
|
+
"owner": {
|
74
|
+
"login": "watermarkchurch",
|
75
|
+
"id": 2896397,
|
76
|
+
"avatar_url": "https://avatars3.githubusercontent.com/u/2896397?v=4",
|
77
|
+
"gravatar_id": "",
|
78
|
+
"url": "https://api.github.com/users/watermarkchurch",
|
79
|
+
"html_url": "https://github.com/watermarkchurch",
|
80
|
+
"followers_url": "https://api.github.com/users/watermarkchurch/followers",
|
81
|
+
"following_url": "https://api.github.com/users/watermarkchurch/following{/other_user}",
|
82
|
+
"gists_url": "https://api.github.com/users/watermarkchurch/gists{/gist_id}",
|
83
|
+
"starred_url": "https://api.github.com/users/watermarkchurch/starred{/owner}{/repo}",
|
84
|
+
"subscriptions_url": "https://api.github.com/users/watermarkchurch/subscriptions",
|
85
|
+
"organizations_url": "https://api.github.com/users/watermarkchurch/orgs",
|
86
|
+
"repos_url": "https://api.github.com/users/watermarkchurch/repos",
|
87
|
+
"events_url": "https://api.github.com/users/watermarkchurch/events{/privacy}",
|
88
|
+
"received_events_url": "https://api.github.com/users/watermarkchurch/received_events",
|
89
|
+
"type": "Organization",
|
90
|
+
"site_admin": false
|
91
|
+
},
|
92
|
+
"private": true,
|
93
|
+
"html_url": "https://github.com/watermarkchurch/danger-wcc",
|
94
|
+
"description": "Danger plugin for Watermark's build process",
|
95
|
+
"fork": false,
|
96
|
+
"url": "https://api.github.com/repos/watermarkchurch/danger-wcc",
|
97
|
+
"forks_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/forks",
|
98
|
+
"keys_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/keys{/key_id}",
|
99
|
+
"collaborators_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/collaborators{/collaborator}",
|
100
|
+
"teams_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/teams",
|
101
|
+
"hooks_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/hooks",
|
102
|
+
"issue_events_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues/events{/number}",
|
103
|
+
"events_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/events",
|
104
|
+
"assignees_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/assignees{/user}",
|
105
|
+
"branches_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/branches{/branch}",
|
106
|
+
"tags_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/tags",
|
107
|
+
"blobs_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/blobs{/sha}",
|
108
|
+
"git_tags_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/tags{/sha}",
|
109
|
+
"git_refs_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/refs{/sha}",
|
110
|
+
"trees_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/trees{/sha}",
|
111
|
+
"statuses_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/statuses/{sha}",
|
112
|
+
"languages_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/languages",
|
113
|
+
"stargazers_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/stargazers",
|
114
|
+
"contributors_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/contributors",
|
115
|
+
"subscribers_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/subscribers",
|
116
|
+
"subscription_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/subscription",
|
117
|
+
"commits_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/commits{/sha}",
|
118
|
+
"git_commits_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/commits{/sha}",
|
119
|
+
"comments_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/comments{/number}",
|
120
|
+
"issue_comment_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues/comments{/number}",
|
121
|
+
"contents_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/contents/{+path}",
|
122
|
+
"compare_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/compare/{base}...{head}",
|
123
|
+
"merges_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/merges",
|
124
|
+
"archive_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/{archive_format}{/ref}",
|
125
|
+
"downloads_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/downloads",
|
126
|
+
"issues_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues{/number}",
|
127
|
+
"pulls_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls{/number}",
|
128
|
+
"milestones_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/milestones{/number}",
|
129
|
+
"notifications_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/notifications{?since,all,participating}",
|
130
|
+
"labels_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/labels{/name}",
|
131
|
+
"releases_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/releases{/id}",
|
132
|
+
"deployments_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/deployments",
|
133
|
+
"created_at": "2018-01-03 01: 27: 50 UTC",
|
134
|
+
"updated_at": "2018-01-03 01: 28: 28 UTC",
|
135
|
+
"pushed_at": "2018-01-17 00: 11: 31 UTC",
|
136
|
+
"git_url": "git://github.com/watermarkchurch/danger-wcc.git",
|
137
|
+
"ssh_url": "git@github.com:watermarkchurch/danger-wcc.git",
|
138
|
+
"clone_url": "https://github.com/watermarkchurch/danger-wcc.git",
|
139
|
+
"svn_url": "https://github.com/watermarkchurch/danger-wcc",
|
140
|
+
"homepage": null,
|
141
|
+
"size": 83,
|
142
|
+
"stargazers_count": 0,
|
143
|
+
"watchers_count": 0,
|
144
|
+
"language": "Ruby",
|
145
|
+
"has_issues": true,
|
146
|
+
"has_projects": true,
|
147
|
+
"has_downloads": true,
|
148
|
+
"has_wiki": true,
|
149
|
+
"has_pages": false,
|
150
|
+
"forks_count": 0,
|
151
|
+
"mirror_url": null,
|
152
|
+
"archived": false,
|
153
|
+
"open_issues_count": 2,
|
154
|
+
"license": {
|
155
|
+
"key": "mit",
|
156
|
+
"name": "MIT License",
|
157
|
+
"spdx_id": "MIT",
|
158
|
+
"url": "https://api.github.com/licenses/mit"
|
159
|
+
},
|
160
|
+
"forks": 0,
|
161
|
+
"open_issues": 2,
|
162
|
+
"watchers": 0,
|
163
|
+
"default_branch": "master"
|
164
|
+
}
|
165
|
+
},
|
166
|
+
"base": {
|
167
|
+
"label": "watermarkchurch:master",
|
168
|
+
"ref": "master",
|
169
|
+
"sha": "b73beab96dd5df19ca50844e89799a785c4db866",
|
170
|
+
"user": {
|
171
|
+
"login": "watermarkchurch",
|
172
|
+
"id": 2896397,
|
173
|
+
"avatar_url": "https://avatars3.githubusercontent.com/u/2896397?v=4",
|
174
|
+
"gravatar_id": "",
|
175
|
+
"url": "https://api.github.com/users/watermarkchurch",
|
176
|
+
"html_url": "https://github.com/watermarkchurch",
|
177
|
+
"followers_url": "https://api.github.com/users/watermarkchurch/followers",
|
178
|
+
"following_url": "https://api.github.com/users/watermarkchurch/following{/other_user}",
|
179
|
+
"gists_url": "https://api.github.com/users/watermarkchurch/gists{/gist_id}",
|
180
|
+
"starred_url": "https://api.github.com/users/watermarkchurch/starred{/owner}{/repo}",
|
181
|
+
"subscriptions_url": "https://api.github.com/users/watermarkchurch/subscriptions",
|
182
|
+
"organizations_url": "https://api.github.com/users/watermarkchurch/orgs",
|
183
|
+
"repos_url": "https://api.github.com/users/watermarkchurch/repos",
|
184
|
+
"events_url": "https://api.github.com/users/watermarkchurch/events{/privacy}",
|
185
|
+
"received_events_url": "https://api.github.com/users/watermarkchurch/received_events",
|
186
|
+
"type": "Organization",
|
187
|
+
"site_admin": false
|
188
|
+
},
|
189
|
+
"repo": {
|
190
|
+
"id": 116075817,
|
191
|
+
"name": "danger-wcc",
|
192
|
+
"full_name": "watermarkchurch/danger-wcc",
|
193
|
+
"owner": {
|
194
|
+
"login": "watermarkchurch",
|
195
|
+
"id": 2896397,
|
196
|
+
"avatar_url": "https://avatars3.githubusercontent.com/u/2896397?v=4",
|
197
|
+
"gravatar_id": "",
|
198
|
+
"url": "https://api.github.com/users/watermarkchurch",
|
199
|
+
"html_url": "https://github.com/watermarkchurch",
|
200
|
+
"followers_url": "https://api.github.com/users/watermarkchurch/followers",
|
201
|
+
"following_url": "https://api.github.com/users/watermarkchurch/following{/other_user}",
|
202
|
+
"gists_url": "https://api.github.com/users/watermarkchurch/gists{/gist_id}",
|
203
|
+
"starred_url": "https://api.github.com/users/watermarkchurch/starred{/owner}{/repo}",
|
204
|
+
"subscriptions_url": "https://api.github.com/users/watermarkchurch/subscriptions",
|
205
|
+
"organizations_url": "https://api.github.com/users/watermarkchurch/orgs",
|
206
|
+
"repos_url": "https://api.github.com/users/watermarkchurch/repos",
|
207
|
+
"events_url": "https://api.github.com/users/watermarkchurch/events{/privacy}",
|
208
|
+
"received_events_url": "https://api.github.com/users/watermarkchurch/received_events",
|
209
|
+
"type": "Organization",
|
210
|
+
"site_admin": false
|
211
|
+
},
|
212
|
+
"private": true,
|
213
|
+
"html_url": "https://github.com/watermarkchurch/danger-wcc",
|
214
|
+
"description": "Danger plugin for Watermark's build process",
|
215
|
+
"fork": false,
|
216
|
+
"url": "https://api.github.com/repos/watermarkchurch/danger-wcc",
|
217
|
+
"forks_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/forks",
|
218
|
+
"keys_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/keys{/key_id}",
|
219
|
+
"collaborators_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/collaborators{/collaborator}",
|
220
|
+
"teams_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/teams",
|
221
|
+
"hooks_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/hooks",
|
222
|
+
"issue_events_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues/events{/number}",
|
223
|
+
"events_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/events",
|
224
|
+
"assignees_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/assignees{/user}",
|
225
|
+
"branches_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/branches{/branch}",
|
226
|
+
"tags_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/tags",
|
227
|
+
"blobs_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/blobs{/sha}",
|
228
|
+
"git_tags_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/tags{/sha}",
|
229
|
+
"git_refs_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/refs{/sha}",
|
230
|
+
"trees_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/trees{/sha}",
|
231
|
+
"statuses_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/statuses/{sha}",
|
232
|
+
"languages_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/languages",
|
233
|
+
"stargazers_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/stargazers",
|
234
|
+
"contributors_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/contributors",
|
235
|
+
"subscribers_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/subscribers",
|
236
|
+
"subscription_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/subscription",
|
237
|
+
"commits_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/commits{/sha}",
|
238
|
+
"git_commits_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/git/commits{/sha}",
|
239
|
+
"comments_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/comments{/number}",
|
240
|
+
"issue_comment_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues/comments{/number}",
|
241
|
+
"contents_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/contents/{+path}",
|
242
|
+
"compare_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/compare/{base}...{head}",
|
243
|
+
"merges_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/merges",
|
244
|
+
"archive_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/{archive_format}{/ref}",
|
245
|
+
"downloads_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/downloads",
|
246
|
+
"issues_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues{/number}",
|
247
|
+
"pulls_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls{/number}",
|
248
|
+
"milestones_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/milestones{/number}",
|
249
|
+
"notifications_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/notifications{?since,all,participating}",
|
250
|
+
"labels_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/labels{/name}",
|
251
|
+
"releases_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/releases{/id}",
|
252
|
+
"deployments_url": "https://api.github.com/repos/watermarkchurch/danger-wcc/deployments",
|
253
|
+
"created_at": "2018-01-03 01: 27: 50 UTC",
|
254
|
+
"updated_at": "2018-01-03 01: 28: 28 UTC",
|
255
|
+
"pushed_at": "2018-01-17 00: 11: 31 UTC",
|
256
|
+
"git_url": "git://github.com/watermarkchurch/danger-wcc.git",
|
257
|
+
"ssh_url": "git@github.com:watermarkchurch/danger-wcc.git",
|
258
|
+
"clone_url": "https://github.com/watermarkchurch/danger-wcc.git",
|
259
|
+
"svn_url": "https://github.com/watermarkchurch/danger-wcc",
|
260
|
+
"homepage": null,
|
261
|
+
"size": 83,
|
262
|
+
"stargazers_count": 0,
|
263
|
+
"watchers_count": 0,
|
264
|
+
"language": "Ruby",
|
265
|
+
"has_issues": true,
|
266
|
+
"has_projects": true,
|
267
|
+
"has_downloads": true,
|
268
|
+
"has_wiki": true,
|
269
|
+
"has_pages": false,
|
270
|
+
"forks_count": 0,
|
271
|
+
"mirror_url": null,
|
272
|
+
"archived": false,
|
273
|
+
"open_issues_count": 2,
|
274
|
+
"license": {
|
275
|
+
"key": "mit",
|
276
|
+
"name": "MIT License",
|
277
|
+
"spdx_id": "MIT",
|
278
|
+
"url": "https://api.github.com/licenses/mit"
|
279
|
+
},
|
280
|
+
"forks": 0,
|
281
|
+
"open_issues": 2,
|
282
|
+
"watchers": 0,
|
283
|
+
"default_branch": "master"
|
284
|
+
}
|
285
|
+
},
|
286
|
+
"_links": {
|
287
|
+
"self": {
|
288
|
+
"href": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls/2"
|
289
|
+
},
|
290
|
+
"html": {
|
291
|
+
"href": "https://github.com/watermarkchurch/danger-wcc/pull/2"
|
292
|
+
},
|
293
|
+
"issue": {
|
294
|
+
"href": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues/2"
|
295
|
+
},
|
296
|
+
"comments": {
|
297
|
+
"href": "https://api.github.com/repos/watermarkchurch/danger-wcc/issues/2/comments"
|
298
|
+
},
|
299
|
+
"review_comments": {
|
300
|
+
"href": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls/2/comments"
|
301
|
+
},
|
302
|
+
"review_comment": {
|
303
|
+
"href": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls/comments{/number}"
|
304
|
+
},
|
305
|
+
"commits": {
|
306
|
+
"href": "https://api.github.com/repos/watermarkchurch/danger-wcc/pulls/2/commits"
|
307
|
+
},
|
308
|
+
"statuses": {
|
309
|
+
"href": "https://api.github.com/repos/watermarkchurch/danger-wcc/statuses/8eba1f974cf91635c6728e0f3a5bc6f42e70eb9a"
|
310
|
+
}
|
311
|
+
},
|
312
|
+
"author_association": "COLLABORATOR",
|
313
|
+
"merged": false,
|
314
|
+
"mergeable": true,
|
315
|
+
"rebaseable": true,
|
316
|
+
"mergeable_state": "clean",
|
317
|
+
"merged_by": null,
|
318
|
+
"comments": 1,
|
319
|
+
"review_comments": 5,
|
320
|
+
"maintainer_can_modify": false,
|
321
|
+
"commits": 3,
|
322
|
+
"additions": 89,
|
323
|
+
"deletions": 17,
|
324
|
+
"changed_files": 9
|
325
|
+
}
|
@@ -0,0 +1,5 @@
|
|
1
|
+
app/assets/javascripts/comment.js: Misleading line break before '+'; readers may interpret this as an expression boundary.
|
2
|
+
app/assets/javascripts/comment.js: Expected an assignment or function call and instead saw an expression.
|
3
|
+
|
4
|
+
app/assets/javascripts/mobiscroll.js: 'i' is already defined.
|
5
|
+
app/assets/javascripts/mobiscroll.js: 'i' is already defined.
|
@@ -0,0 +1,7 @@
|
|
1
|
+
app/assets/javascripts/comment.js: Misleading line break before '+'; readers may interpret this as an expression boundary.
|
2
|
+
app/assets/javascripts/comment.js: Misleading line break before '+'; readers may interpret this as an expression boundary.
|
3
|
+
app/assets/javascripts/comment.js: Expected an assignment or function call and instead saw an expression.
|
4
|
+
|
5
|
+
app/assets/javascripts/mobiscroll.js: 'i' is already defined.
|
6
|
+
app/assets/javascripts/mobiscroll.js: ['AM'] is better written in dot notation.
|
7
|
+
app/assets/javascripts/mobiscroll.js: 'i' is already defined.
|
@@ -0,0 +1,13 @@
|
|
1
|
+
diff --git a/a.tmp b/b.tmp
|
2
|
+
index ff7f90c..c33d9e4 100644
|
3
|
+
--- a/a.tmp
|
4
|
+
+++ b/b.tmp
|
5
|
+
@@ -1,5 +1,7 @@
|
6
|
+
app/assets/javascripts/comment.js: Misleading line break before '+'; readers may interpret this as an expression boundary.
|
7
|
+
+app/assets/javascripts/comment.js: Misleading line break before '+'; readers may interpret this as an expression boundary.
|
8
|
+
app/assets/javascripts/comment.js: Expected an assignment or function call and instead saw an expression.
|
9
|
+
|
10
|
+
app/assets/javascripts/mobiscroll.js: 'i' is already defined.
|
11
|
+
+app/assets/javascripts/mobiscroll.js: ['AM'] is better written in dot notation.
|
12
|
+
app/assets/javascripts/mobiscroll.js: 'i' is already defined.
|
13
|
+
|
@@ -0,0 +1,7 @@
|
|
1
|
+
app/assets/javascripts/comment.js: line 33, col 10, Misleading line break before '+'; readers may interpret this as an expression boundary.
|
2
|
+
app/assets/javascripts/comment.js: line 42, col 10, Misleading line break before '+'; readers may interpret this as an expression boundary.
|
3
|
+
app/assets/javascripts/comment.js: line 77, col 35, Expected an assignment or function call and instead saw an expression.
|
4
|
+
|
5
|
+
app/assets/javascripts/mobiscroll.js: line 3, col 110, 'i' is already defined.
|
6
|
+
app/assets/javascripts/mobiscroll.js: line 3, col 127, ['AM'] is better written in dot notation.
|
7
|
+
app/assets/javascripts/mobiscroll.js: line 8, col 2157, 'i' is already defined.
|
@@ -0,0 +1,10 @@
|
|
1
|
+
diff --git a/spec/fixtures/rubocop_exception.rb b/spec/fixtures/rubocop_exception.rb
|
2
|
+
index e69de29..663661c 100644
|
3
|
+
--- a/spec/fixtures/rubocop_exception.rb
|
4
|
+
+++ b/spec/fixtures/rubocop_exception.rb
|
5
|
+
@@ -0,0 +1,5 @@
|
6
|
+
+
|
7
|
+
+# frozen_string_literal: true
|
8
|
+
+
|
9
|
+
+module RubocopException
|
10
|
+
+end
|
@@ -0,0 +1,13 @@
|
|
1
|
+
diff --git a/spec/fixtures/todo.rb b/spec/fixtures/todo.rb
|
2
|
+
index e69de29..22ca05f 100644
|
3
|
+
--- a/spec/fixtures/todo.rb
|
4
|
+
+++ b/spec/fixtures/todo.rb
|
5
|
+
@@ -0,0 +1,8 @@
|
6
|
+
+
|
7
|
+
+
|
8
|
+
+# frozen_string_literal: true
|
9
|
+
+
|
10
|
+
+module Todo
|
11
|
+
+ def this_should_not_trigger_todo
|
12
|
+
+ end
|
13
|
+
+end
|
@@ -0,0 +1,121 @@
|
|
1
|
+
lib/wcc/commit_lint/commit_check.rb -- 4 warnings:
|
2
|
+
lib/wcc/commit_lint/commit_check.rb:6: ControlParameter: CommitCheck#self.fail? is controlled by argument 'options' [https://github.com/troessner/reek/blob/master/docs/Control-Parameter.md]
|
3
|
+
lib/wcc/commit_lint/commit_check.rb:4: IrresponsibleModule: CommitCheck has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
4
|
+
lib/wcc/commit_lint/commit_check.rb:9: UnusedParameters: CommitCheck#initialize has unused parameter 'message' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
|
5
|
+
lib/wcc/commit_lint/commit_check.rb:9: UnusedParameters: CommitCheck#initialize has unused parameter 'options' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
|
6
|
+
lib/wcc/commit_lint/empty_line_check.rb -- 1 warning:
|
7
|
+
lib/wcc/commit_lint/empty_line_check.rb:4: IrresponsibleModule: EmptyLineCheck has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
8
|
+
lib/wcc/commit_lint/subject_cap_check.rb -- 1 warning:
|
9
|
+
lib/wcc/commit_lint/subject_cap_check.rb:4: IrresponsibleModule: SubjectCapCheck has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
10
|
+
lib/wcc/commit_lint/subject_length_check.rb -- 2 warnings:
|
11
|
+
lib/wcc/commit_lint/subject_length_check.rb:25: DuplicateMethodCall: SubjectLengthCheck#fail? calls '@subject.length' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
12
|
+
lib/wcc/commit_lint/subject_length_check.rb:4: IrresponsibleModule: SubjectLengthCheck has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
13
|
+
lib/wcc/commit_lint/subject_period_check.rb -- 1 warning:
|
14
|
+
lib/wcc/commit_lint/subject_period_check.rb:4: IrresponsibleModule: SubjectPeriodCheck has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
15
|
+
lib/wcc/commit_lint/subject_words_check.rb -- 1 warning:
|
16
|
+
lib/wcc/commit_lint/subject_words_check.rb:4: IrresponsibleModule: SubjectWordsCheck has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
17
|
+
lib/wcc/commit_lint.rb -- 4 warnings:
|
18
|
+
lib/wcc/commit_lint.rb:143: DuplicateMethodCall: Danger::DangerWCC::CommitLint#warning_checks calls '@config[:warn]' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
19
|
+
lib/wcc/commit_lint.rb:149: FeatureEnvy: Danger::DangerWCC::CommitLint#messages refers to 'commit' more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
|
20
|
+
lib/wcc/commit_lint.rb:90: NestedIterators: Danger::DangerWCC::CommitLint#check_messages contains iterators nested 2 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
|
21
|
+
lib/wcc/commit_lint.rb:101: UncommunicativeVariableName: Danger::DangerWCC::CommitLint#check_and_issue has the variable name 'c' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
22
|
+
lib/wcc/github.rb -- 3 warnings:
|
23
|
+
lib/wcc/github.rb:20: DuplicateMethodCall: Github#add_labels calls 'github.api' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
24
|
+
lib/wcc/github.rb:3: IrresponsibleModule: Github has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
25
|
+
lib/wcc/github.rb:19: UncommunicativeVariableName: Github#add_labels has the variable name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
26
|
+
lib/wcc/plugin.rb -- 3 warnings:
|
27
|
+
lib/wcc/plugin.rb:53: TooManyStatements: Danger::DangerWCC#reek has approx 7 statements [https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md]
|
28
|
+
lib/wcc/plugin.rb:60: UncommunicativeVariableName: Danger::DangerWCC#reek has the variable name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
29
|
+
lib/wcc/plugin.rb:61: UncommunicativeVariableName: Danger::DangerWCC#reek has the variable name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
30
|
+
lib/wcc/rubocop_exceptions.rb -- 25 warnings:
|
31
|
+
lib/wcc/rubocop_exceptions.rb:32: DuplicateMethodCall: Danger::DangerWCC::RubocopExceptions#build_message calls 'e[:context_lines]' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
32
|
+
lib/wcc/rubocop_exceptions.rb:80: DuplicateMethodCall: Danger::DangerWCC::RubocopExceptions#find_context calls 'l.content' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
33
|
+
lib/wcc/rubocop_exceptions.rb:57: DuplicateMethodCall: Danger::DangerWCC::RubocopExceptions#find_new_exceptions calls 'file.b_path' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
34
|
+
lib/wcc/rubocop_exceptions.rb:86: DuplicateMethodCall: Danger::DangerWCC::RubocopExceptions#find_reenable calls 'file_contents.lines' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
35
|
+
lib/wcc/rubocop_exceptions.rb:71: DuplicateMethodCall: Danger::DangerWCC::RubocopExceptions#make_violation calls 'hunk.lines' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
36
|
+
lib/wcc/rubocop_exceptions.rb:64: DuplicateMethodCall: Danger::DangerWCC::RubocopExceptions#make_violation calls 'line.line_number' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
37
|
+
lib/wcc/rubocop_exceptions.rb:64: DuplicateMethodCall: Danger::DangerWCC::RubocopExceptions#make_violation calls 'line.line_number.right' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
38
|
+
lib/wcc/rubocop_exceptions.rb:95: DuplicateMethodCall: Danger::DangerWCC::RubocopExceptions#rubocop_line? calls 'l.content' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
39
|
+
lib/wcc/rubocop_exceptions.rb:29: FeatureEnvy: Danger::DangerWCC::RubocopExceptions#build_message refers to 'e' more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
|
40
|
+
lib/wcc/rubocop_exceptions.rb:80: FeatureEnvy: Danger::DangerWCC::RubocopExceptions#find_context refers to 'l' more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
|
41
|
+
lib/wcc/rubocop_exceptions.rb:6: IrresponsibleModule: Danger::DangerWCC::RubocopExceptions has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
42
|
+
lib/wcc/rubocop_exceptions.rb:62: LongParameterList: Danger::DangerWCC::RubocopExceptions#make_violation has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
|
43
|
+
lib/wcc/rubocop_exceptions.rb:90: NilCheck: Danger::DangerWCC::RubocopExceptions#find_reenable performs a nil-check [https://github.com/troessner/reek/blob/master/docs/Nil-Check.md]
|
44
|
+
lib/wcc/rubocop_exceptions.rb:70: NilCheck: Danger::DangerWCC::RubocopExceptions#make_violation performs a nil-check [https://github.com/troessner/reek/blob/master/docs/Nil-Check.md]
|
45
|
+
lib/wcc/rubocop_exceptions.rb:28: UncommunicativeParameterName: Danger::DangerWCC::RubocopExceptions#build_message has the parameter name 'e' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Parameter-Name.md]
|
46
|
+
lib/wcc/rubocop_exceptions.rb:45: UncommunicativeParameterName: Danger::DangerWCC::RubocopExceptions#message_severity has the parameter name 'e' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Parameter-Name.md]
|
47
|
+
lib/wcc/rubocop_exceptions.rb:94: UncommunicativeParameterName: Danger::DangerWCC::RubocopExceptions#rubocop_line? has the parameter name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Parameter-Name.md]
|
48
|
+
lib/wcc/rubocop_exceptions.rb:79: UncommunicativeVariableName: Danger::DangerWCC::RubocopExceptions#find_context has the variable name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
49
|
+
lib/wcc/rubocop_exceptions.rb:56: UncommunicativeVariableName: Danger::DangerWCC::RubocopExceptions#find_new_exceptions has the variable name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
50
|
+
lib/wcc/rubocop_exceptions.rb:88: UncommunicativeVariableName: Danger::DangerWCC::RubocopExceptions#find_reenable has the variable name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
51
|
+
lib/wcc/rubocop_exceptions.rb:89: UncommunicativeVariableName: Danger::DangerWCC::RubocopExceptions#find_reenable has the variable name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
52
|
+
lib/wcc/rubocop_exceptions.rb:18: UncommunicativeVariableName: Danger::DangerWCC::RubocopExceptions#perform has the variable name 'e' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
53
|
+
lib/wcc/rubocop_exceptions.rb:84: UtilityFunction: Danger::DangerWCC::RubocopExceptions#find_reenable doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
|
54
|
+
lib/wcc/rubocop_exceptions.rb:45: UtilityFunction: Danger::DangerWCC::RubocopExceptions#message_severity doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
|
55
|
+
lib/wcc/rubocop_exceptions.rb:94: UtilityFunction: Danger::DangerWCC::RubocopExceptions#rubocop_line? doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
|
56
|
+
lib/wcc/todos.rb -- 18 warnings:
|
57
|
+
lib/wcc/todos.rb:61: DuplicateMethodCall: Danger::DangerWCC::Todos#find_link_in_context calls 'line.line_number' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
58
|
+
lib/wcc/todos.rb:61: DuplicateMethodCall: Danger::DangerWCC::Todos#find_link_in_context calls 'line.line_number.right' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
59
|
+
lib/wcc/todos.rb:28: DuplicateMethodCall: Danger::DangerWCC::Todos#issue_message calls 'result[:file]' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
60
|
+
lib/wcc/todos.rb:26: DuplicateMethodCall: Danger::DangerWCC::Todos#issue_message calls 'result[:file_link]' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
61
|
+
lib/wcc/todos.rb:28: DuplicateMethodCall: Danger::DangerWCC::Todos#issue_message calls 'result[:line]' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
62
|
+
lib/wcc/todos.rb:25: DuplicateMethodCall: Danger::DangerWCC::Todos#issue_message calls 'result[:link]' 3 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
63
|
+
lib/wcc/todos.rb:47: DuplicateMethodCall: Danger::DangerWCC::Todos#make_violation calls 'file.b_path' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
64
|
+
lib/wcc/todos.rb:61: FeatureEnvy: Danger::DangerWCC::Todos#find_link_in_context refers to 'line' more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
|
65
|
+
lib/wcc/todos.rb:25: FeatureEnvy: Danger::DangerWCC::Todos#issue_message refers to 'result' more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
|
66
|
+
lib/wcc/todos.rb:6: IrresponsibleModule: Danger::DangerWCC::Todos has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
67
|
+
lib/wcc/todos.rb:50: NilCheck: Danger::DangerWCC::Todos#make_violation performs a nil-check [https://github.com/troessner/reek/blob/master/docs/Nil-Check.md]
|
68
|
+
lib/wcc/todos.rb:72: NilCheck: Danger::DangerWCC::Todos#max performs a nil-check [https://github.com/troessner/reek/blob/master/docs/Nil-Check.md]
|
69
|
+
lib/wcc/todos.rb:71: UncommunicativeParameterName: Danger::DangerWCC::Todos#max has the parameter name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Parameter-Name.md]
|
70
|
+
lib/wcc/todos.rb:71: UncommunicativeParameterName: Danger::DangerWCC::Todos#max has the parameter name 'b' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Parameter-Name.md]
|
71
|
+
lib/wcc/todos.rb:62: UncommunicativeVariableName: Danger::DangerWCC::Todos#find_link_in_context has the variable name 'i' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
72
|
+
lib/wcc/todos.rb:62: UncommunicativeVariableName: Danger::DangerWCC::Todos#find_link_in_context has the variable name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
73
|
+
lib/wcc/todos.rb:63: UncommunicativeVariableName: Danger::DangerWCC::Todos#find_link_in_context has the variable name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
74
|
+
lib/wcc/todos.rb:71: UtilityFunction: Danger::DangerWCC::Todos#max doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
|
75
|
+
lib/wcc/utils.rb -- 17 warnings:
|
76
|
+
lib/wcc/utils.rb:87: ControlParameter: Utils#issue is controlled by argument 'severity' [https://github.com/troessner/reek/blob/master/docs/Control-Parameter.md]
|
77
|
+
lib/wcc/utils.rb:27: DuplicateMethodCall: Utils#find_in_diff calls 'l.content' 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
|
78
|
+
lib/wcc/utils.rb:27: FeatureEnvy: Utils#find_in_diff refers to 'l' more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
|
79
|
+
lib/wcc/utils.rb:6: IrresponsibleModule: Utils has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
80
|
+
lib/wcc/utils.rb:86: LongParameterList: Utils#issue has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
|
81
|
+
lib/wcc/utils.rb:52: LongYieldList: Utils#each_addition_in_diff yields 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Yield-List.md]
|
82
|
+
lib/wcc/utils.rb:31: LongYieldList: Utils#find_in_diff yields 5 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Yield-List.md]
|
83
|
+
lib/wcc/utils.rb:52: NestedIterators: Utils#each_addition_in_diff contains iterators nested 3 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
|
84
|
+
lib/wcc/utils.rb:42: NestedIterators: Utils#each_file_in_diff contains iterators nested 2 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
|
85
|
+
lib/wcc/utils.rb:27: NestedIterators: Utils#find_in_diff contains iterators nested 3 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
|
86
|
+
lib/wcc/utils.rb:61: NilCheck: Utils#run_and_diff performs a nil-check [https://github.com/troessner/reek/blob/master/docs/Nil-Check.md]
|
87
|
+
lib/wcc/utils.rb:48: TooManyStatements: Utils#each_addition_in_diff has approx 6 statements [https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md]
|
88
|
+
lib/wcc/utils.rb:24: TooManyStatements: Utils#find_in_diff has approx 7 statements [https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md]
|
89
|
+
lib/wcc/utils.rb:58: TooManyStatements: Utils#run_and_diff has approx 18 statements [https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md]
|
90
|
+
lib/wcc/utils.rb:52: UncommunicativeVariableName: Utils#each_addition_in_diff has the variable name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
91
|
+
lib/wcc/utils.rb:27: UncommunicativeVariableName: Utils#find_in_diff has the variable name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
92
|
+
lib/wcc/utils.rb:16: UncommunicativeVariableName: Utils#parsed_diffs has the variable name 'd' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
93
|
+
spec/fixtures/find_in_diff.rb -- 3 warnings:
|
94
|
+
spec/fixtures/find_in_diff.rb:3: IrresponsibleModule: FindInDiff has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
95
|
+
spec/fixtures/find_in_diff.rb:4: UncommunicativeMethodName: FindInDiff#added_hunk_1 has the name 'added_hunk_1' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
|
96
|
+
spec/fixtures/find_in_diff.rb:18: UncommunicativeMethodName: FindInDiff#added_hunk_2 has the name 'added_hunk_2' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
|
97
|
+
spec/fixtures/rubocop_exception.rb -- 1 warning:
|
98
|
+
spec/fixtures/rubocop_exception.rb:4: IrresponsibleModule: RubocopException has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
99
|
+
spec/fixtures/todo.rb -- 1 warning:
|
100
|
+
spec/fixtures/todo.rb:5: IrresponsibleModule: Todo has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
101
|
+
spec/fixtures_helper.rb -- 2 warnings:
|
102
|
+
spec/fixtures_helper.rb:4: IrresponsibleModule: FixturesHelper has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
103
|
+
spec/fixtures_helper.rb:15: UtilityFunction: FixturesHelper#load_fixture doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
|
104
|
+
spec/wcc/commit_lint_spec.rb -- 3 warnings:
|
105
|
+
spec/wcc/commit_lint_spec.rb:33: IrresponsibleModule: Danger has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
106
|
+
spec/wcc/commit_lint_spec.rb:370: UncommunicativeVariableName: Danger has the variable name 'i' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
107
|
+
spec/wcc/commit_lint_spec.rb:29: UtilityFunction: report_counts doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
|
108
|
+
spec/wcc/github_spec.rb -- 1 warning:
|
109
|
+
spec/wcc/github_spec.rb:6: IrresponsibleModule: Danger has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
110
|
+
spec/wcc/plugin_spec.rb -- 1 warning:
|
111
|
+
spec/wcc/plugin_spec.rb:5: IrresponsibleModule: Danger has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
112
|
+
spec/wcc/rubocop_exceptions_spec.rb -- 1 warning:
|
113
|
+
spec/wcc/rubocop_exceptions_spec.rb:5: IrresponsibleModule: Danger has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
114
|
+
spec/wcc/todos_spec.rb -- 1 warning:
|
115
|
+
spec/wcc/todos_spec.rb:5: IrresponsibleModule: Danger has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
116
|
+
spec/wcc/utils_spec.rb -- 2 warnings:
|
117
|
+
spec/wcc/utils_spec.rb:5: IrresponsibleModule: Danger has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
118
|
+
spec/wcc/utils_spec.rb:66: UncommunicativeVariableName: Danger has the variable name 'l' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
|
119
|
+
spec/wcc_spec.rb -- 1 warning:
|
120
|
+
spec/wcc_spec.rb:5: IrresponsibleModule: Danger has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
|
121
|
+
97 total warnings
|