danger-dangermattic 1.0.0

data/spec/pr_size_checker_spec.rb

@@ -0,0 +1,250 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::PRSizeChecker do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.pr_size_checker
+      end
+
+      context 'when checking a PR diff size' do
+        before do
+          allow(@plugin.git).to receive_messages(added_files: [], modified_files: [], deleted_files: [])
+        end
+
+        shared_examples 'using the default diff size counter, without a file selector' do |type|
+          let(:diff_counter_for_type) do
+            type_hash = {
+              insertions: :insertions,
+              deletions: :deletions,
+              all: :lines_of_code
+            }
+
+            type_hash[type]
+          end
+
+          it 'reports a warning when using default parameters in a PR that has larger diff than the maximum' do
+            allow(@plugin.git).to receive(diff_counter_for_type).and_return(501)
+
+            @plugin.check_diff_size(max_size: 500, type: type)
+
+            expect(@dangerfile).to report_warnings([format(described_class::DEFAULT_DIFF_SIZE_MESSAGE_FORMAT, 500)])
+          end
+
+          it 'does nothing when using default parameters in a PR that has equal diff than the maximum' do
+            allow(@plugin.git).to receive(diff_counter_for_type).and_return(500)
+
+            @plugin.check_diff_size(max_size: 500, type: type)
+
+            expect(@dangerfile).to not_report
+          end
+
+          it 'does nothing when using default parameters in a PR that has smaller diff than the maximum' do
+            allow(@plugin.git).to receive(diff_counter_for_type).and_return(499)
+
+            @plugin.check_diff_size(max_size: 500, type: type)
+
+            expect(@dangerfile).to not_report
+          end
+
+          context 'when reporting a custom error or warning with a custom max_size' do
+            shared_examples 'reporting diff size custom warnings or errors' do |report_type, message|
+              it 'reports an error using a custom message and a custom PR body size' do
+                allow(@plugin.git).to receive(diff_counter_for_type).and_return(600)
+
+                if message
+                  @plugin.check_diff_size(max_size: 599, type: type, message: message, report_type: report_type)
+                else
+                  @plugin.check_diff_size(max_size: 599, type: type, report_type: report_type)
+                end
+
+                message ||= format(described_class::DEFAULT_DIFF_SIZE_MESSAGE_FORMAT, 599)
+
+                expect_warning_or_error(report_type: report_type, message: message)
+              end
+            end
+
+            context 'when fail on error is false and a custom message is given' do
+              include_examples 'reporting diff size custom warnings or errors', false, 'this is my custom warning message'
+            end
+
+            context 'when fail on error is false' do
+              include_examples 'reporting diff size custom warnings or errors', false
+            end
+
+            context 'when fail on error is true' do
+              include_examples 'reporting diff size custom warnings or errors', true
+            end
+
+            context 'when a custom error message is given and fail on error is true' do
+              include_examples 'reporting diff size custom warnings or errors', true, 'this is my custom error message'
+            end
+          end
+        end
+
+        shared_examples 'using a file selector to filter and count the changes in a diff' do |type, max_sizes|
+          context 'when using a files filter that will regard the diff as too large' do
+            it 'reports a warning' do
+              prepare_diff_with_test_files
+
+              @plugin.check_diff_size(
+                max_size: max_sizes[0],
+                file_selector: ->(path) { File.dirname(path).start_with?('src/test/java') },
+                type: type
+              )
+
+              expect(@dangerfile).to report_warnings([format(described_class::DEFAULT_DIFF_SIZE_MESSAGE_FORMAT, max_sizes[0])])
+            end
+
+            it 'reports a custom error' do
+              prepare_diff_with_test_files
+
+              custom_message = 'diff size too large custom file filter and error message'
+              @plugin.check_diff_size(
+                max_size: max_sizes[1],
+                file_selector: ->(path) { File.extname(path) == '.java' },
+                type: type,
+                message: custom_message,
+                report_type: :error
+              )
+
+              expect(@dangerfile).to report_errors([custom_message])
+            end
+          end
+
+          it 'does nothing when a files filter is used but the max size is greater than or equal to the diff size' do
+            prepare_diff_with_test_files
+
+            @plugin.check_diff_size(
+              max_size: max_sizes[2],
+              file_selector: ->(path) { File.extname(path).match(/^(.java|.kt)$/) },
+              type: type
+            )
+
+            expect(@dangerfile).to not_report
+          end
+
+          def prepare_diff_with_test_files
+            added_test_file = 'src/test/java/org/magic/MagicTests.kt'
+            added_config = 'config.xml'
+            added_file = 'MyNewSorcery.java'
+            modified_file1 = 'src/java/PotionIngredients.java'
+            modified_file2 = 'src/java/Potion.kt'
+            modified_strings = 'src/main/res/values/strings.xml'
+            deleted_file1 = 'src/java/org/Fire.kt'
+            deleted_file2 = 'BlackCat.kt'
+            deleted_test_file = 'src/test/java/org/magic/Power.java'
+            deleted_strings = 'src/main/res/values-de/strings.xml'
+
+            allow(@plugin.git).to receive_messages(added_files: [added_config, added_file], modified_files: [modified_file1, modified_file2, added_test_file, modified_strings], deleted_files: [deleted_file1, deleted_test_file, deleted_strings, deleted_file2])
+
+            allow(@plugin.git).to receive(:diff).and_return(instance_double(Git::Diff))
+            expected_files = { added_test_file => {}, added_config => {}, added_file => {}, modified_file1 => {}, modified_file2 => {}, modified_strings => {}, deleted_file1 => {}, deleted_file2 => {}, deleted_test_file => {}, deleted_strings => {} }
+            allow(@plugin.git.diff).to receive(:stats).and_return({ files: expected_files })
+
+            allow(@plugin.git).to receive(:info_for_file).with(added_test_file).and_return({ insertions: 201 })
+            allow(@plugin.git).to receive(:info_for_file).with(added_config).and_return({ insertions: 311 })
+            allow(@plugin.git).to receive(:info_for_file).with(added_file).and_return({ insertions: 13 })
+            allow(@plugin.git).to receive(:info_for_file).with(modified_file1).and_return({ insertions: 127, deletions: 159 })
+            allow(@plugin.git).to receive(:info_for_file).with(modified_file2).and_return({ insertions: 43, deletions: 37 })
+            allow(@plugin.git).to receive(:info_for_file).with(modified_strings).and_return({ insertions: 432, deletions: 297 })
+            allow(@plugin.git).to receive(:info_for_file).with(deleted_file1).and_return({ deletions: 246 })
+            allow(@plugin.git).to receive(:info_for_file).with(deleted_file2).and_return({ deletions: 493 })
+            allow(@plugin.git).to receive(:info_for_file).with(deleted_test_file).and_return({ deletions: 222 })
+            allow(@plugin.git).to receive(:info_for_file).with(deleted_strings).and_return({ deletions: 593 })
+          end
+        end
+
+        context 'with the entire diff' do
+          include_examples 'using the default diff size counter, without a file selector', :all
+          include_examples 'using a file selector to filter and count the changes in a diff', :all, [422, 520, 1541]
+        end
+
+        context 'with the insertions in the diff' do
+          include_examples 'using the default diff size counter, without a file selector', :insertions
+          include_examples 'using a file selector to filter and count the changes in a diff', :insertions, [200, 139, 384]
+        end
+
+        context 'with the deletions in the diff' do
+          include_examples 'using the default diff size counter, without a file selector', :deletions
+          include_examples 'using a file selector to filter and count the changes in a diff', :deletions, [221, 380, 1157]
+        end
+      end
+
+      context 'when checking a PR body size' do
+        it 'reports a warning when using default parameters in a PR that has a smaller body text length than the minimum' do
+          allow(@plugin.github).to receive(:pr_body).and_return('PR body')
+
+          @plugin.check_pr_body(min_length: 15)
+
+          expect(@dangerfile).to report_warnings([format(described_class::DEFAULT_MIN_PR_BODY_MESSAGE_FORMAT, 15)])
+        end
+
+        it 'does nothing when using default parameters in a PR that has a bigger PR body text length than the minimum' do
+          allow(@plugin.github).to receive(:pr_body).and_return('some test PR body')
+
+          @plugin.check_pr_body(min_length: 10)
+
+          expect(@dangerfile).to not_report
+        end
+
+        it 'reports a warning when using default parameters in a PR that has an equal PR body text length than the minimum' do
+          allow(@plugin.github).to receive(:pr_body).and_return('some test-')
+
+          @plugin.check_pr_body(min_length: 10)
+
+          expect(@dangerfile).to report_warnings([format(described_class::DEFAULT_MIN_PR_BODY_MESSAGE_FORMAT, 10)])
+        end
+
+        context 'when reporting a custom error or warning with a custom min_length' do
+          shared_examples 'reporting PR length check custom warnings or errors' do |report_type, message|
+            it 'reports an error when using a custom message and a custom minimum PR body text length' do
+              allow(@plugin.github).to receive(:pr_body).and_return('still too short message')
+
+              if message
+                @plugin.check_pr_body(min_length: 25, message: message, report_type: report_type)
+              else
+                @plugin.check_pr_body(min_length: 25, report_type: report_type)
+              end
+
+              message ||= format(described_class::DEFAULT_MIN_PR_BODY_MESSAGE_FORMAT, 25)
+
+              expect_warning_or_error(report_type: report_type, message: message)
+            end
+          end
+
+          context 'when fail on error is false and a custom message is given' do
+            include_examples 'reporting PR length check custom warnings or errors', false, 'this is my custom warning message'
+          end
+
+          context 'when fail on error is false' do
+            include_examples 'reporting PR length check custom warnings or errors', false
+          end
+
+          context 'when fail on error is true' do
+            include_examples 'reporting PR length check custom warnings or errors', true
+          end
+
+          context 'when a custom error message is given and fail on error is true' do
+            include_examples 'reporting PR length check custom warnings or errors', true, 'this is my custom error message'
+          end
+        end
+      end
+
+      def expect_warning_or_error(report_type:, message:)
+        if report_type == :error
+          expect(@dangerfile).to report_errors([message])
+        elsif report_type == :warning
+          expect(@dangerfile).to report_warnings([message])
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,115 @@
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift(File.expand_path('../lib', __dir__))
+
+require 'pry'
+
+require 'rspec'
+require 'danger'
+
+if `git remote -v` == ''
+  puts 'You cannot run tests without setting a local git remote on this repo'
+  puts 'It\'s a weird side-effect of Danger\'s internals.'
+  exit(0)
+end
+
+RSpec.configure do |config|
+  config.filter_gems_from_backtrace 'bundler'
+  config.color = true
+  config.tty = true
+end
+
+require 'danger_plugin'
+
+# These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
+# If you are expanding these files, see if it's already been done ^.
+
+# A silent version of the user interface,
+# it comes with an extra function `.string` which will
+# strip all ANSI colours from the string.
+
+# rubocop:disable Lint/NestedMethodDefinition
+def testing_ui
+  @output = StringIO.new
+  def @output.winsize
+    [20, 9999]
+  end
+
+  cork = Cork::Board.new(out: @output)
+  def cork.string
+    out.string.gsub(/\e\[([;\d]+)?m/, '')
+  end
+  cork
+end
+# rubocop:enable Lint/NestedMethodDefinition
+
+# Example environment (ENV)
+def testing_env
+  {
+    'HAS_JOSH_K_SEAL_OF_APPROVAL' => 'true',
+    'TRAVIS_PULL_REQUEST' => '800',
+    'TRAVIS_REPO_SLUG' => 'artsy/eigen',
+    'TRAVIS_COMMIT_RANGE' => '759adcbd0d8f...13c4dc8bb61d',
+    'DANGER_GITHUB_API_TOKEN' => '123sbdq54erfsd3422gdfio'
+  }
+end
+
+# A stubbed out Dangerfile for use in tests
+def testing_dangerfile
+  env = Danger::EnvironmentManager.new(testing_env)
+  Danger::Dangerfile.new(env, testing_ui)
+end
+
+def fixture(name)
+  File.read("spec/fixtures/#{name}")
+end
+
+# custom matchers
+
+RSpec::Matchers.define :report_warnings do |expected_warnings|
+  match do |dangerfile|
+    dangerfile.status_report[:warnings].eql?(expected_warnings) &&
+      dangerfile.status_report[:errors]&.empty? &&
+      dangerfile.status_report[:messages]&.empty?
+  end
+
+  failure_message do |dangerfile|
+    "expected warnings '#{expected_warnings}' to be reported, got instead:\n- Warnings: #{dangerfile.status_report[:warnings]}\n- Errors: #{dangerfile.status_report[:errors]}\n- Messages: #{dangerfile.status_report[:messages]}"
+  end
+end
+
+RSpec::Matchers.define :report_errors do |expected_errors|
+  match do |dangerfile|
+    dangerfile.status_report[:errors].eql?(expected_errors) &&
+      dangerfile.status_report[:warnings]&.empty? &&
+      dangerfile.status_report[:messages]&.empty?
+  end
+
+  failure_message do |dangerfile|
+    "expected errors '#{expected_errors}' to be reported, got instead:\n- Errors: #{dangerfile.status_report[:errors]}\n- Warnings: #{dangerfile.status_report[:warnings]}\n- Messages: #{dangerfile.status_report[:messages]}"
+  end
+end
+
+RSpec::Matchers.define :report_messages do |expected_messages|
+  match do |dangerfile|
+    dangerfile.status_report[:messages].eql?(expected_messages) &&
+      dangerfile.status_report[:errors]&.empty? &&
+      dangerfile.status_report[:warnings]&.empty?
+  end
+
+  failure_message do |dangerfile|
+    "expected messages '#{expected_messages}' to be reported, got instead:\n- Messages: #{dangerfile.status_report[:messages]}\n- Warnings: #{dangerfile.status_report[:warnings]}\n- Errors: #{dangerfile.status_report[:errors]}"
+  end
+end
+
+RSpec::Matchers.define :not_report do
+  match do |dangerfile|
+    dangerfile.status_report[:errors]&.empty? &&
+      dangerfile.status_report[:warnings]&.empty? &&
+      dangerfile.status_report[:messages]&.empty?
+  end
+
+  failure_message do |dangerfile|
+    "expected no warnings or errors to be reported, got instead:\n#{dangerfile.status_report}"
+  end
+end

data/spec/tracks_checker_spec.rb

@@ -0,0 +1,156 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::TracksChecker do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.tracks_checker
+      end
+
+      let(:track_files) do
+        [
+          'AnalyticsTracker.kt',
+          'AnalyticsEvent.kt',
+          'LoginAnalyticsTracker.kt',
+          'WooAnalyticsStat.swift'
+        ]
+      end
+
+      let(:tracks_matchers) do
+        [
+          /AnalyticsTracker\.track/
+        ]
+      end
+
+      describe '#check_tracks_changes' do
+        before do
+          allow(@plugin.git).to receive_messages(modified_files: [], added_files: [], deleted_files: [])
+
+          stub_const('GitDiffStruct', Struct.new(:type, :path, :patch))
+        end
+
+        context 'when checking changes in Tracks-related files' do
+          it 'reports a message with instructions for review when there are changes in Tracks-related files' do
+            tracks_label = '[Tracks]'
+            allow(@plugin.github).to receive(:pr_labels).and_return([tracks_label])
+            allow(@plugin.git_utils).to receive(:all_changed_files).and_return(['Test.kt', 'LoginAnalyticsTracker.kt', 'Test.java'])
+
+            @plugin.check_tracks_changes(tracks_files: track_files, tracks_usage_matchers: tracks_matchers, tracks_label: tracks_label)
+
+            expect(@dangerfile).to report_messages([TracksChecker::TRACKS_PR_INSTRUCTIONS + format(TracksChecker::TRACKS_NO_LABEL_INSTRUCTION_FORMAT, tracks_label)])
+          end
+
+          it 'reports a message with instructions for review without the label check when there are changes in Tracks-related files and no label parameter' do
+            allow(@plugin.git_utils).to receive(:all_changed_files).and_return(['Test.kt', 'LoginAnalyticsTracker.kt', 'Test.java'])
+
+            @plugin.check_tracks_changes(tracks_files: track_files, tracks_usage_matchers: tracks_matchers, tracks_label: nil)
+
+            expect(@dangerfile).to report_messages([TracksChecker::TRACKS_PR_INSTRUCTIONS])
+          end
+
+          it 'reports an error when there are changes in Tracks-related files but no Tracks label' do
+            allow(@plugin.github).to receive(:pr_labels).and_return([])
+            allow(@plugin.git_utils).to receive(:all_changed_files).and_return(['Test.kt', 'LoginAnalyticsTracker.kt', 'Test.java'])
+
+            tracks_label = 'TRACKS'
+            @plugin.check_tracks_changes(tracks_files: track_files, tracks_usage_matchers: tracks_matchers, tracks_label: tracks_label)
+
+            expect_label_checks(tracks_label)
+          end
+
+          it 'does nothing when there are no changes in Tracks-related files' do
+            modified_files = ['MyClass.swift']
+            allow(@plugin.git_utils).to receive(:all_changed_files).and_return(modified_files)
+            allow(@plugin.git_utils).to receive(:matching_lines_in_diff_files).with(files: modified_files, line_matcher: kind_of(Proc), change_type: nil).and_return([])
+
+            @plugin.check_tracks_changes(tracks_files: track_files, tracks_usage_matchers: tracks_matchers, tracks_label: nil)
+
+            expect(@dangerfile).to not_report
+          end
+        end
+
+        context 'when checking Tracks-related changes within a diff' do
+          it 'reports a message with instructions for review when there are matching changes' do
+            tracks_label = 'Tracks'
+            allow(@plugin.github).to receive(:pr_labels).and_return([tracks_label])
+            modified_files = ['MyClass.kt']
+            allow(@plugin.git_utils).to receive(:all_changed_files).and_return(modified_files)
+
+            allow(@plugin.git_utils).to receive(:matching_lines_in_diff_files).with(files: modified_files, line_matcher: kind_of(Proc), change_type: nil) do |args|
+              analytics_call_in_diff = '-                AnalyticsTracker.track("myEvent1")'
+              expect(args[:line_matcher].call(analytics_call_in_diff)).to be true
+
+              [analytics_call_in_diff]
+            end
+
+            @plugin.check_tracks_changes(tracks_files: track_files, tracks_usage_matchers: tracks_matchers, tracks_label: tracks_label)
+
+            expect(@dangerfile).to report_messages([TracksChecker::TRACKS_PR_INSTRUCTIONS + format(TracksChecker::TRACKS_NO_LABEL_INSTRUCTION_FORMAT, tracks_label)])
+          end
+
+          it 'reports a message with instructions without the label check for review when there are matching changes and no label parameter' do
+            modified_files = ['MyClass.kt']
+            allow(@plugin.git_utils).to receive(:all_changed_files).and_return(modified_files)
+
+            allow(@plugin.git_utils).to receive(:matching_lines_in_diff_files).with(files: modified_files, line_matcher: kind_of(Proc), change_type: nil) do |args|
+              analytics_call_in_diff = '-                AnalyticsTracker.track("evento")'
+              expect(args[:line_matcher].call(analytics_call_in_diff)).to be true
+
+              [analytics_call_in_diff]
+            end
+
+            @plugin.check_tracks_changes(tracks_files: track_files, tracks_usage_matchers: tracks_matchers, tracks_label: nil)
+
+            expect(@dangerfile).to report_messages([TracksChecker::TRACKS_PR_INSTRUCTIONS])
+          end
+
+          it 'reports a message with instructions for review and an error when there are matching changes and no label' do
+            allow(@plugin.github).to receive(:pr_labels).and_return([])
+            modified_files = ['MyClass.kt']
+            allow(@plugin.git_utils).to receive(:all_changed_files).and_return(modified_files)
+
+            allow(@plugin.git_utils).to receive(:matching_lines_in_diff_files).with(files: modified_files, line_matcher: kind_of(Proc), change_type: nil) do |args|
+              analytics_call_in_diff = '-                AnalyticsTracker.track("myEvent1")'
+              expect(args[:line_matcher].call(analytics_call_in_diff)).to be true
+
+              [analytics_call_in_diff]
+            end
+
+            tracks_label = 'TRACKS PR'
+            @plugin.check_tracks_changes(tracks_files: track_files, tracks_usage_matchers: tracks_matchers, tracks_label: tracks_label)
+
+            expect_label_checks(tracks_label)
+          end
+
+          it 'does nothing when there are no matching changes' do
+            modified_files = ['MyClass.kt']
+            allow(@plugin.git_utils).to receive(:all_changed_files).and_return(modified_files)
+
+            allow(@plugin.git_utils).to receive(:matching_lines_in_diff_files).with(files: modified_files, line_matcher: kind_of(Proc), change_type: nil) do |args|
+              analytics_call_in_diff = '+                AnalyticsHelper.log("event_1")'
+              expect(args[:line_matcher].call(analytics_call_in_diff)).to be false
+
+              []
+            end
+
+            @plugin.check_tracks_changes(tracks_files: track_files, tracks_usage_matchers: tracks_matchers, tracks_label: nil)
+
+            expect(@dangerfile).to not_report
+          end
+        end
+      end
+
+      def expect_label_checks(tracks_label)
+        expect(@dangerfile.status_report[:messages]).to eq [TracksChecker::TRACKS_PR_INSTRUCTIONS + format(TracksChecker::TRACKS_NO_LABEL_INSTRUCTION_FORMAT, tracks_label)]
+        expect(@dangerfile.status_report[:errors]).to eq [format(TracksChecker::TRACKS_NO_LABEL_MESSAGE_FORMAT, tracks_label)]
+      end
+    end
+  end
+end

data/spec/view_changes_checker_spec.rb

@@ -0,0 +1,168 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::ViewChangesChecker do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    shared_examples 'PR with view code changes' do |modified_files|
+      before do
+        allow(@plugin.git).to receive(:modified_files).and_return(modified_files)
+      end
+
+      it 'warns when a PR with view code changes does not have screenshots' do
+        allow(@plugin.github).to receive(:pr_body).and_return('PR Body')
+
+        @plugin.check
+
+        expect(@dangerfile).to report_warnings([ViewChangesChecker::MESSAGE])
+      end
+
+      it 'does nothing when a PR with view code changes has screenshots defined in markdown' do
+        allow(@plugin.github).to receive(:pr_body)
+          .and_return('PR [![Alt text](https://myimages.com/boo)](https://digitalocean.com) Body')
+
+        @plugin.check
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does nothing when a PR with view code changes has url to screenshots' do
+        allow(@plugin.github).to receive(:pr_body)
+          .and_return('<a href=\'https://myimages.com/boo.jpg\'>see secreenshot</a> Body')
+
+        @plugin.check
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does nothing when a PR with view code changes has a screenshot defined with a html tag with different attributes before src' do
+        allow(@plugin.github).to receive(:pr_body)
+          .and_return("see screenshot:\n<img width=300 hint=\"First screenshots\" src=\"https://github.com/bloom/DayOne-Apple/assets/4780/1f9e01a8-c63d-41d4-9ac8-fa9a5182ab55\"> body body")
+
+        @plugin.check
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does nothing when a PR with view code changes has a screenshot defined with a html tag' do
+        allow(@plugin.github).to receive(:pr_body)
+          .and_return("see screenshot:\n<img src=\"https://github.com/woocommerce/woocommerce-ios/assets/1864060/17d9227d-67e8-4efb-8c26-02b81e1b19d2\" width=\"375\"> body body")
+
+        @plugin.check
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does nothing when a PR with view code changes has a video defined with a html tag with different attributes before src' do
+        allow(@plugin.github).to receive(:pr_body)
+          .and_return("see video:\n<video width=300 hint=\"First video\" src=\"https://www.w3schools.com/tags/movie.mp4\"> body body")
+
+        @plugin.check
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does nothing when a PR with view code changes has a video defined with a html tag' do
+        allow(@plugin.github).to receive(:pr_body)
+          .and_return("see video:\n<video src=\"https://www.w3schools.com/tags/movie.mp4\" width=\"375\"> body body")
+
+        @plugin.check
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does nothing when a PR with view code changes has a video defined with a simple URL' do
+        allow(@plugin.github).to receive(:pr_body)
+          .and_return("see video:\nhttps://github.com/woocommerce/woocommerce-ios/assets/1864060/0e983305-5047-40a3-8829-734e0b582b96 body body")
+
+        @plugin.check
+
+        expect(@dangerfile).to not_report
+      end
+    end
+
+    shared_examples 'PR without view code changes' do |modified_files|
+      before do
+        allow(@plugin.git).to receive(:modified_files).and_return(modified_files)
+        allow(@plugin.github).to receive(:pr_body).and_return('Body')
+        @plugin.check
+      end
+
+      it 'does nothing' do
+        expect(@dangerfile).to not_report
+      end
+    end
+
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.view_changes_checker
+      end
+
+      context 'when checking an iOS PR' do
+        context 'with view code changes in Swift files' do
+          include_examples 'PR with view code changes', ['TestView.swift', 'SimpleViewHelper.m']
+        end
+
+        context 'with button changes in Swift files' do
+          include_examples 'PR with view code changes', ['SimpleViewHelper.m', 'MyAwesomeButton.swift']
+        end
+
+        context 'with view code changes in ObjC files' do
+          include_examples 'PR with view code changes', ['TestView.m', 'SimpleViewHelper.m']
+        end
+
+        context 'with button changes in ObjC files' do
+          include_examples 'PR with view code changes', ['SimpleViewHelper.m', 'MyAwesomeButton.m']
+        end
+
+        context 'with changes in a .xib file' do
+          include_examples 'PR with view code changes', ['SimpleViewHelper.m', 'top_bar.xib']
+        end
+
+        context 'with changes in a Storyboard' do
+          include_examples 'PR with view code changes', ['SimpleViewHelper.m', 'main_screen.storyboard']
+        end
+
+        context 'with no view changes' do
+          include_examples 'PR without view code changes',
+                           ['SimpleViewHelper.m', 'MyButtonTester.swift', 'Version.xcconfig']
+        end
+      end
+
+      context 'when checking an Android PR' do
+        context 'with view code changes in Kotlin files' do
+          include_examples 'PR with view code changes', ['SimpleViewHelper.kt', 'MySimpleView.kt']
+        end
+
+        context 'with button changes in Kotlin files' do
+          include_examples 'PR with view code changes', ['MyAwesomeButton.kt', 'SimpleViewHelper.java']
+        end
+
+        context 'with view code changes in Java files' do
+          include_examples 'PR with view code changes', ['TestView.java', 'SimpleViewHelper.kt']
+        end
+
+        context 'with button changes in Java files' do
+          include_examples 'PR with view code changes', ['SimpleViewHelper.kt', 'MyAwesomeButton.java']
+        end
+
+        context 'with view code changes in a XML file' do
+          include_examples 'PR with view code changes', ['test_view.xml', 'SimpleViewHelper.kt', 'strings.xml']
+        end
+
+        context 'with button changes in a XML file' do
+          include_examples 'PR with view code changes', ['SimpleViewHelper.kt', 'strings.xml', 'my_awesome_button.xml']
+        end
+
+        context 'with no view changes' do
+          include_examples 'PR without view code changes', ['SimpleViewHelper.java', 'values.xml', 'MyButtonTester.kt']
+        end
+      end
+    end
+  end
+end