danger-dangermattic 1.0.0

data/spec/android_release_checker_spec.rb

@@ -0,0 +1,93 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::AndroidReleaseChecker do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.android_release_checker
+
+        allow(@plugin.git).to receive_messages(added_files: [], modified_files: [], deleted_files: [])
+      end
+
+      context 'when changing the release notes' do
+        it 'reports a warning when a PR changes the release notes but not the Play Store strings file' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['metadata/release_notes.txt'])
+
+          @plugin.check_release_notes_and_play_store_strings
+
+          expect(@dangerfile).to report_messages([format(CommonReleaseChecker::MESSAGE_STORE_FILE_NOT_CHANGED, 'metadata/PlayStoreStrings.po', 'metadata/release_notes.txt')])
+        end
+
+        it 'does nothing when a PR changes the release notes and the AppStore strings file' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['Resources/release_notes.txt', 'Resources/AppStoreStrings.po'])
+
+          @plugin.check_release_notes_and_play_store_strings
+
+          expect(@dangerfile).to not_report
+        end
+
+        it 'does nothing when a PR does not change the release notes or the AppStore strings file' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['MyView.swift', 'Resources/AppStoreStrings.tmp'])
+
+          @plugin.check_release_notes_and_play_store_strings
+
+          expect(@dangerfile).to not_report
+        end
+      end
+
+      describe '#check_modified_localizable_strings_on_release' do
+        it 'reports a warning when a PR on a regular branch changes the source strings.xml' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['./src/main/res/values/strings.xml'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+          @plugin.check_modified_strings_on_release
+
+          expect(@dangerfile).to report_warnings([AndroidReleaseChecker::MESSAGE_STRINGS_FILE_UPDATED])
+        end
+
+        it 'reports an error when a PR on a regular branch changes the source strings.xml' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['./src/main/res/values/strings.xml'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+          @plugin.check_modified_strings_on_release(report_type: :error)
+
+          expect(@dangerfile).to report_errors([AndroidReleaseChecker::MESSAGE_STRINGS_FILE_UPDATED])
+        end
+
+        it 'reports a warning when a PR on a regular branch changes a translated strings.xml' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['src/main/res/values-fr/strings.xml'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('trunk')
+
+          @plugin.check_modified_strings_on_release
+
+          expect(@dangerfile).to report_warnings([AndroidReleaseChecker::MESSAGE_STRINGS_FILE_UPDATED])
+        end
+
+        it 'does nothing when a PR changes the strings.xml on a release branch' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['src/main/res/values/strings.xml'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+          @plugin.check_modified_strings_on_release
+
+          expect(@dangerfile).to not_report
+        end
+
+        it 'does nothing when a PR does not change the strings.xml on a regular branch' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['./path/to/view/model/MyViewModel.kt'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+          @plugin.check_modified_strings_on_release
+
+          expect(@dangerfile).to not_report
+        end
+      end
+    end
+  end
+end

data/spec/android_strings_checker_spec.rb

@@ -0,0 +1,185 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::AndroidStringsChecker do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.android_strings_checker
+
+        allow(@plugin.git).to receive_messages(added_files: [], modified_files: [], deleted_files: [])
+
+        stub_const('GitDiffStruct', Struct.new(:type, :path, :patch))
+      end
+
+      context 'when changing strings.xml files' do
+        it 'reports a warning when a PR adds a string resource reference inside a strings.xml file' do
+          strings_xml_path = './src/main/res/values/strings.xml'
+          allow(@plugin.git).to receive(:modified_files).and_return([strings_xml_path])
+
+          strings_xml_diff = <<~STRINGS
+            diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml
+            index 5794d472..772e2b99 100644
+            --- a/src/main/res/values/strings.xml
+            +++ b/src/main/res/values/strings.xml
+            @@ -1,3 +1,6 @@
+             <?xml version="1.0" encoding="UTF-8"?>
+             <resources xmlns:tools="http://schemas.android.com/tools">
+            +  <string name="select_categories">Select categories</string>
+            +  <string name="video_quality">Video Quality</string>
+            +  <string name="screen_title">@string/app_name</string>
+             </resources>
+          STRINGS
+
+          diff = GitDiffStruct.new('modified', strings_xml_path, strings_xml_diff)
+
+          allow(@plugin.git).to receive(:diff_for_file).with(strings_xml_path).and_return(diff)
+
+          @plugin.check_strings_do_not_refer_resource
+
+          expected_warning = <<~WARNING
+            #{AndroidStringsChecker::MESSAGE}
+            File `#{strings_xml_path}`:
+            ```diff
+            +  <string name="screen_title">@string/app_name</string>
+            ```
+          WARNING
+
+          expect(@dangerfile).to report_warnings([expected_warning])
+        end
+
+        it 'reports multiple warnings when a PR adds multiple string resource references inside multiple strings.xml files' do
+          main_strings_xml = './src/main/res/values/strings.xml'
+          ptbr_strings_xml = './src/main/res/values-pt-rBR/strings.xml'
+          strings_xml_paths = [main_strings_xml, ptbr_strings_xml]
+          allow(@plugin.git).to receive(:modified_files).and_return(strings_xml_paths)
+
+          main_xml_diff = <<~STRINGS
+            diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml
+            index 5794d472..772e2b99 100644
+            --- a/src/main/res/values/strings.xml
+            +++ b/src/main/res/values/strings.xml
+            @@ -1,3 +1,6 @@
+             <?xml version="1.0" encoding="UTF-8"?>
+             <resources xmlns:tools="http://schemas.android.com/tools">
+            +  <string name="select_categories">Select categories</string>
+            +  <string name="video_quality">Video Quality</string>
+            +  <string name="screen_title">@string/app_name</string>
+            +  <string name="screen_button">@string/button</string>
+            -  <string name="field_hint">@string/hint</string>
+             </resources>
+          STRINGS
+
+          main_diff = GitDiffStruct.new('modified', main_strings_xml, main_xml_diff)
+
+          allow(@plugin.git).to receive(:diff_for_file).with(main_strings_xml).and_return(main_diff)
+
+          ptbr_xml_diff = <<~STRINGS
+            diff --git a/src/main/res/values-pt-rBR/strings.xml b/src/main/res/values-pt-rBR/strings.xml
+            index 5794d472..772e2b99 100644
+            --- a/src/main/res/values-pt-rBR/strings.xml
+            +++ b/src/main/res/values-pt-rBR/strings.xml
+            @@ -1,3 +1,6 @@
+            <?xml version="1.0" encoding="UTF-8"?>
+            <resources xmlns:tools="http://schemas.android.com/tools">
+            +  <string name="video_quality">Video Quality</string>
+            +  <string name="popup_title">@string/app_name_title</string>
+            -  <string name="toast">@string/common_toast</string>
+            </resources>
+          STRINGS
+
+          ptbr_diff = GitDiffStruct.new('modified', ptbr_strings_xml, ptbr_xml_diff)
+
+          allow(@plugin.git).to receive(:diff_for_file).with(ptbr_strings_xml).and_return(ptbr_diff)
+
+          @plugin.check_strings_do_not_refer_resource
+
+          expected_warning = <<~WARNING
+            #{AndroidStringsChecker::MESSAGE}
+            File `#{main_strings_xml}`:
+            ```diff
+            +  <string name="screen_title">@string/app_name</string>
+            ```
+          WARNING
+
+          expected_warning2 = <<~WARNING
+            #{AndroidStringsChecker::MESSAGE}
+            File `#{main_strings_xml}`:
+            ```diff
+            +  <string name="screen_button">@string/button</string>
+            ```
+          WARNING
+
+          expected_warning3 = <<~WARNING
+            #{AndroidStringsChecker::MESSAGE}
+            File `#{ptbr_strings_xml}`:
+            ```diff
+            +  <string name="popup_title">@string/app_name_title</string>
+            ```
+          WARNING
+
+          expect(@dangerfile.status_report[:warnings]).to contain_exactly(expected_warning, expected_warning2, expected_warning3)
+        end
+
+        it 'does nothing when a PR adds a string resource reference inside a strings.xml file but with translatable=\"false\"' do
+          strings_xml_path = './src/main/res/values/strings.xml'
+          allow(@plugin.git).to receive(:modified_files).and_return([strings_xml_path])
+
+          strings_xml_diff = <<~STRINGS
+            diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml
+            index 5794d472..772e2b99 100644
+            --- a/src/main/res/values/strings.xml
+            +++ b/src/main/res/values/strings.xml
+            @@ -1,3 +1,6 @@
+             <?xml version="1.0" encoding="UTF-8"?>
+             <resources xmlns:tools="http://schemas.android.com/tools">
+            +  <string name="select_categories">Select categories</string>
+            +  <string name="video_quality">Video Quality</string>
+            +  <string name="screen_title" translatable="false">@string/app_name</string>
+             </resources>
+          STRINGS
+
+          diff = GitDiffStruct.new('modified', strings_xml_path, strings_xml_diff)
+
+          allow(@plugin.git).to receive(:diff_for_file).with(strings_xml_path).and_return(diff)
+
+          @plugin.check_strings_do_not_refer_resource
+
+          expect(@dangerfile).to not_report
+        end
+
+        it 'does nothing when a PR adds strings without resource references' do
+          strings_xml_path = './src/main/res/values/strings.xml'
+          allow(@plugin.git).to receive(:modified_files).and_return([strings_xml_path])
+
+          strings_xml_diff = <<~STRINGS
+            diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml
+            index 5794d472..772e2b99 100644
+            --- a/src/main/res/values/strings.xml
+            +++ b/src/main/res/values/strings.xml
+            @@ -1,3 +1,6 @@
+             <?xml version="1.0" encoding="UTF-8"?>
+             <resources xmlns:tools="http://schemas.android.com/tools">
+            +  <string name="select_categories">Select categories</string>
+            +  <string name="video_quality">Video Quality</string>
+             </resources>
+          STRINGS
+
+          diff = GitDiffStruct.new('modified', strings_xml_path, strings_xml_diff)
+
+          allow(@plugin.git).to receive(:diff_for_file).with(strings_xml_path).and_return(diff)
+
+          @plugin.check_strings_do_not_refer_resource
+
+          expect(@dangerfile).to not_report
+        end
+      end
+    end
+  end
+end

data/spec/android_unit_test_checker_spec.rb

@@ -0,0 +1,343 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::AndroidUnitTestChecker do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.android_unit_test_checker
+
+        allow(@plugin.github).to receive(:pr_labels).and_return(['my_label'])
+
+        stub_const('GitDiffStruct', Struct.new(:type, :path, :patch))
+      end
+
+      it 'reports the right errors when a PR adds new classes that do not have corresponding tests' do
+        added_files = %w[
+          src/main/java/org/wordpress/util/config/BloggingPromptsFeatureConfig.kt
+          Abc.java
+          src/androidTest/java/org/test/ToolTest.kt
+          Polygon.kt
+          Abcdef.kt
+          TestsINeedThem.java
+          TestsINeedThem2.kt
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files)
+
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        @plugin.check_missing_tests
+
+        classes = %w[
+          BloggingPromptsFeatureConfig
+          Abc
+          Polygon
+          Abcdef
+          TestsINeedThem
+          TestsINeedThem2
+          TestsINeedThem2AnotherClass
+        ]
+
+        expect_class_names_match_report(class_names: classes, error_report: @dangerfile.status_report[:errors])
+      end
+
+      it 'does not report errors when new classes have corresponding tests' do
+        added_files = %w[
+          Abc.java
+          src/androidTest/java/org/test/AbcTests.java
+          Polygon.kt
+          src/androidTest/java/org/test/PolygonTest.kt
+          TestsINeedThem.java
+          src/androidTest/java/org/test/AnotherTestClass.java
+          MyNewClass.java
+          src/androidTest/java/org/test/TestMyNewClass.java
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        @plugin.check_missing_tests
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does not report errors when we are deleting classes' do
+        deleted_files = %w[
+          Abc.java
+          Polygon.kt
+          TestsINeedThem.java
+        ]
+
+        diff = generate_delete_diff_from_fixtures(deleted_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        @plugin.check_missing_tests
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'reports errors when we remove test classes for classes we refactored' do
+        added_files = %w[
+          Abc.java
+          Polygon.kt
+          TestsINeedThem.kt
+        ]
+
+        removed_files = %w[
+          src/androidTest/java/org/test/AbcTests.java
+          src/androidTest/java/org/test/PolygonTest.kt
+          src/test/java/org/test/TestsINeedThem.java
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files) + generate_delete_diff_from_fixtures(removed_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        @plugin.check_missing_tests
+
+        classes = %w[
+          Abc
+          Polygon
+          TestsINeedThem
+        ]
+
+        expect_class_names_match_report(class_names: classes, error_report: @dangerfile.status_report[:errors])
+      end
+
+      it 'does nothing when a PR adds only tests' do
+        added_files = %w[
+          src/androidTest/java/org/test/AbcTests.java
+          src/androidTest/java/org/test/PolygonTest.kt
+          src/test/java/org/test/TestsINeedThem.java
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        @plugin.check_missing_tests
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does nothing when a PR adds classes that dont need tests' do
+        added_files = %w[
+          src/android/java/org/activities/MyActivity.kt
+          src/android/java/org/activities/MyJavaActivity.java
+          src/android/java/org/fragments/MyFragment.kt
+          src/android/java/org/fragments/MyNewJavaFragment.java
+          src/android/java/org/module/MyModule.java
+          src/android/java/org/view/MyRecyclerView.java
+          src/android/java/org/view/ActionCardViewHolder.kt
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        @plugin.check_missing_tests
+
+        expect(@dangerfile).to not_report
+      end
+
+      it 'does not report that a PR with the tests bypass label is missing tests' do
+        added_files = %w[
+          Abc.java
+          Abcdef.kt
+          TestsINeedThem2.kt
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+        allow(@plugin.github).to receive(:pr_labels).and_return(['unit-tests-exemption'])
+
+        @plugin.check_missing_tests
+
+        expected_warnings = [
+          'Class `Abc` is missing tests, but `unit-tests-exemption` label was set to ignore this.',
+          'Class `Abcdef` is missing tests, but `unit-tests-exemption` label was set to ignore this.',
+          'Class `TestsINeedThem2` is missing tests, but `unit-tests-exemption` label was set to ignore this.',
+          'Class `TestsINeedThem2AnotherClass` is missing tests, but `unit-tests-exemption` label was set to ignore this.'
+        ]
+        expect(@dangerfile).to report_warnings(expected_warnings)
+      end
+
+      it 'does not report errors when a PR without tests with a custom bypass label is missing tests' do
+        added_files = %w[
+          Abc.java
+          src/androidTest/java/org/test/AnotherTestClass.java
+          Abcdef.kt
+        ]
+
+        ignore_label = 'ignore-no-tests'
+
+        diff = generate_add_diff_from_fixtures(added_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+        allow(@plugin.github).to receive(:pr_labels).and_return([ignore_label])
+
+        @plugin.check_missing_tests(bypass_label: ignore_label)
+
+        expected_warnings = [
+          'Class `Abc` is missing tests, but `ignore-no-tests` label was set to ignore this.',
+          'Class `Abcdef` is missing tests, but `ignore-no-tests` label was set to ignore this.'
+        ]
+        expect(@dangerfile).to report_warnings(expected_warnings)
+      end
+
+      it 'does not report that added classes that need tests but with custom classes exception patterns are missing tests' do
+        added_files = %w[
+          src/androidTest/java/org/test/ToolTest.kt
+          AnotherViewHelper.kt
+          AbcdefgViewHelper.java
+          TestsINeedThem.java
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        classes_to_ignore = [
+          /ViewHelper$/
+        ].freeze
+
+        @plugin.check_missing_tests(classes_exceptions: classes_to_ignore)
+
+        classes = ['TestsINeedThem']
+        expect_class_names_match_report(class_names: classes, error_report: @dangerfile.status_report[:errors])
+      end
+
+      it 'does not report that added classes that need tests but with custom subclasses exception patterns are missing tests' do
+        added_files = %w[
+          AbcFeatureConfig.java
+          src/main/java/org/wordpress/android/widgets/NestedWebView.kt
+          src/androidTest/java/org/test/AnotherTestClass.java
+          src/main/java/org/wordpress/util/config/BloggingPromptsFeatureConfig.kt
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        subclasses_to_ignore = [
+          /FeatureConfig$/
+        ].freeze
+
+        @plugin.check_missing_tests(subclasses_exceptions: subclasses_to_ignore)
+
+        classes = ['NestedWebView']
+        expect_class_names_match_report(class_names: classes, error_report: @dangerfile.status_report[:errors])
+      end
+
+      it 'does not report that added classes with a path filter are missing tests' do
+        added_files = %w[
+          AbcFeatureConfig.java
+          AnotherViewHelper.kt
+          src/main/java/org/wordpress/util/config/BloggingPromptsFeatureConfig.kt
+        ]
+
+        diff = generate_add_diff_from_fixtures(added_files)
+        allow(@dangerfile.git).to receive(:diff).and_return(diff)
+
+        path_exceptions = ['src/main/java/org/wordpress/**', '*.java']
+
+        @plugin.check_missing_tests(path_exceptions: path_exceptions)
+
+        classes = ['AnotherViewHelper']
+        expect_class_names_match_report(class_names: classes, error_report: @dangerfile.status_report[:errors])
+      end
+
+      it 'does nothing when a PR moves code around with both additions and removals in the diff' do
+        shape_file = 'Shape.kt'
+
+        polygon_test_diff_str = <<~PATCH
+          diff --git a/PolygonTest.kt b/PolygonTest.kt
+          index 8c2bed6..ae81c49 100644
+          --- a/PolygonTest.kt
+          +++ b/PolygonTest.kt
+          @@ -1,8 +1,9 @@
+          -class PolygonTest {
+          -  val sut10: Shape = Polygon(sides = 10)
+          -  val sut5: Shape = Polygon(sides = 5)
+          -
+          -  fun testDraw() {
+          -    Polygon(sides = 5).draw()
+          +class ShapesTest {
+          +  fun testPentagon() {
+          +    draw(Polygon(sides = 5))
+          +  }
+          +
+          +  private fun draw(shape: Shape) {
+          +    shape.draw()
+            }
+          }
+        PATCH
+
+        shape_diff = generate_add_diff_from_fixtures([shape_file])
+        polygon_diff = GitDiffStruct.new('modified', 'project/src/androidTest/java/shapes/PolygonTest.kt', polygon_test_diff_str)
+
+        allow(@dangerfile.git).to receive(:diff).and_return(shape_diff + [polygon_diff])
+
+        @plugin.check_missing_tests
+
+        expect(@dangerfile).to not_report
+      end
+    end
+
+    def generate_add_diff_from_fixtures(paths)
+      paths.map do |path|
+        content = fixture(File.join('android_unit_test_checker', path))
+        diff_str = generate_add_diff(file_path: path, content: content)
+
+        GitDiffStruct.new('new', path, diff_str)
+      end
+    end
+
+    def generate_delete_diff_from_fixtures(paths)
+      paths.map do |path|
+        content = fixture(File.join('android_unit_test_checker', path))
+        diff_str = generate_delete_diff(file_path: path, content: content)
+
+        GitDiffStruct.new('deleted', path, diff_str)
+      end
+    end
+
+    def generate_delete_diff(file_path:, content:)
+      <<~PATCH
+        diff --git a/#{file_path} b/#{file_path}
+        deleted file mode 100644
+        index fd48a22..0000000
+        --- a/#{file_path}
+        +++ /dev/null
+        @@ -1 +0,0 @@
+        #{prefix_text_lines(content: content, prefix: '-')}
+        \
+      PATCH
+    end
+
+    def generate_add_diff(file_path:, content:)
+      <<~PATCH
+        diff --git a/#{file_path} b/#{file_path}
+        new file mode 100644
+        index 0000000..fd48a22
+        --- /dev/null
+        +++ b/#{file_path}
+        @@ -0,0 +1 @@
+        #{prefix_text_lines(content: content, prefix: '+')}
+        \
+      PATCH
+    end
+
+    def prefix_text_lines(content:, prefix:)
+      content.lines.map { |line| "#{prefix}#{line.chomp}" }.join("\n")
+    end
+
+    def expect_class_names_match_report(class_names:, error_report:)
+      expect(class_names.length).to eq(error_report.length)
+      class_names.zip(error_report).each do |cls, error|
+        expect(error).to include "Please add tests for class `#{cls}`"
+      end
+    end
+  end
+end

data/spec/common_release_checker_spec.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::CommonReleaseChecker do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe 'with the common_release_checker plugin' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.common_release_checker
+
+        allow(@plugin.git).to receive_messages(added_files: [], modified_files: [], deleted_files: [])
+      end
+
+      context 'when changing the internal release notes' do
+        it 'reports a warning when a PR on a release branch changes the internal release notes' do
+          notes_file = 'RELEASE-NOTES.txt'
+          allow(@plugin.git).to receive(:modified_files).and_return([notes_file])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+          @plugin.check_internal_release_notes_changed
+
+          expect(@dangerfile).to report_warnings([format(CommonReleaseChecker::MESSAGE_INTERNAL_RELEASE_NOTES_CHANGED, notes_file)])
+        end
+
+        it 'reports a warning when a PR on a release branch changes the internal release notes using a custom filename' do
+          notes_file = 'MY-CUSTOM-RELEASE-NOTES.md'
+          allow(@plugin.git).to receive(:modified_files).and_return([notes_file])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+          @plugin.check_internal_release_notes_changed(release_notes_file: notes_file)
+
+          expect(@dangerfile).to report_warnings([format(CommonReleaseChecker::MESSAGE_INTERNAL_RELEASE_NOTES_CHANGED, notes_file)])
+        end
+
+        it 'does nothing when a PR changes the release notes file on a regular branch' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['RELEASE-NOTES.txt'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+          @plugin.check_internal_release_notes_changed
+
+          expect(@dangerfile).to not_report
+        end
+
+        it 'does nothing when a PR changes a custom release notes file on a regular branch' do
+          notes_file = 'MY-CUSTOM-RELEASE-NOTES.md'
+          allow(@plugin.git).to receive(:modified_files).and_return([notes_file])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+          @plugin.check_internal_release_notes_changed(release_notes_file: notes_file)
+
+          expect(@dangerfile).to not_report
+        end
+
+        it 'does nothing when a PR ca warning when a PR does not change the release notes file on the release branch' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['./path/to/view/MyView.swift'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+          @plugin.check_internal_release_notes_changed
+
+          expect(@dangerfile).to not_report
+        end
+      end
+    end
+  end
+end