danger-dangermattic 1.0.0

data/spec/fixtures/android_unit_test_checker/Abc.java

@@ -0,0 +1,7 @@
+import java.utils.*;
+
+public class Abc {
+    public static void main(String[] args) {
+        System.out.println("");
+    }
+}

data/spec/fixtures/android_unit_test_checker/AbcFeatureConfig.java

@@ -0,0 +1,7 @@
+import java.util.*;
+
+abstract class AbcFeatureConfig
+extends
+MyNewFeatureConfig {
+    public abstract void wrangle();
+}

data/spec/fixtures/android_unit_test_checker/Abcdef.kt

@@ -0,0 +1,5 @@
+class Abcdef(private val name: String) {
+    fun testMe() {
+        println("")
+    }
+}

data/spec/fixtures/android_unit_test_checker/AbcdefgViewHelper.java

@@ -0,0 +1,7 @@
+import java.util.List;
+
+public final class AbcdefgViewHelper<T extends List<?>> {
+    public static void testMe() {
+        System.out.println("");
+    }
+}

data/spec/fixtures/android_unit_test_checker/AnotherViewHelper.kt

@@ -0,0 +1,7 @@
+class AnotherViewHelper<T>(val type: T)
+{
+    fun testMe()
+    {
+        println("")
+    }
+}

data/spec/fixtures/android_unit_test_checker/MyNewClass.java

@@ -0,0 +1,7 @@
+package src;
+
+final class MyNewClass {
+    public void testMe() {
+        System.out.println("");
+    }
+}

data/spec/fixtures/android_unit_test_checker/Polygon.kt

@@ -0,0 +1,3 @@
+abstract class Polygon {
+    abstract fun draw()
+}

data/spec/fixtures/android_unit_test_checker/Shape.kt

@@ -0,0 +1,10 @@
+open class Polygon(sides: Int): Shape {
+    override fun draw() {
+        for (i in 1..sides)
+            draw()
+    }
+}
+
+abstract class Shape {
+    abstract fun draw()
+}

data/spec/fixtures/android_unit_test_checker/TestsINeedThem.java

@@ -0,0 +1,5 @@
+public final class TestsINeedThem {
+    public void testMe() {
+        System.out.println("");
+    }
+}

data/spec/fixtures/android_unit_test_checker/TestsINeedThem.kt

@@ -0,0 +1,7 @@
+public final class TestsINeedThem
+{
+    fun myNewTest()
+    {
+        println("")
+    }
+}

data/spec/fixtures/android_unit_test_checker/TestsINeedThem2.kt

@@ -0,0 +1,12 @@
+public open class TestsINeedThem2 {
+    fun testMe2() {
+    }
+}
+
+class TestsINeedThem2AnotherClass
+{
+    fun thisNeedsATest()
+    {
+        println("thisNeedsATest")
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/android/java/org/activities/MyActivity.kt

@@ -0,0 +1,7 @@
+import android.content.Context
+import android.content.res.Configuration
+import androidx.appcompat.app.AppCompatActivity
+
+class MyActivity: AppCompatActivity {
+    fun myActivity() {}
+}

data/spec/fixtures/android_unit_test_checker/src/android/java/org/activities/MyJavaActivity.java

@@ -0,0 +1,7 @@
+package src.android.java.org.activities;
+
+import org.wordpress.android.ui.LocaleAwareActivity;
+
+public class MyJavaActivity extends LocaleAwareActivity {
+    public void myJavaActivity() {}
+}

data/spec/fixtures/android_unit_test_checker/src/android/java/org/fragments/MyFragment.kt

@@ -0,0 +1,6 @@
+import androidx.fragment.app.Fragment
+
+@AndroidEntryPoint
+class MyFragment : Fragment(R.layout.activity_log_item_detail) {
+    override fun onBackPressed() {}
+}

data/spec/fixtures/android_unit_test_checker/src/android/java/org/fragments/MyNewJavaFragment.java

@@ -0,0 +1,7 @@
+package src.android.java.org.fragments;
+
+import androidx.appcompat.app.AppCompatDialogFragment;
+
+public class MyNewJavaFragment<T> extends AppCompatDialogFragment<? extends T> {
+    public void myFragment() {}
+}

data/spec/fixtures/android_unit_test_checker/src/android/java/org/module/MyModule.java

@@ -0,0 +1,13 @@
+package src.android.java.org.module;
+
+import dagger.hilt.components.SingletonComponent;
+import dagger.android.AndroidInjectionModule;
+
+@InstallIn(SingletonComponent.class)
+@Module(includes = AndroidInjectionModule.class)
+public class MyModule {
+    @Provides
+    public static SharedPreferences provideSharedPrefs(@ApplicationContext Context context) {
+        return PreferenceManager.getDefaultSharedPreferences(context);
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/android/java/org/view/ActionCardViewHolder.kt

@@ -0,0 +1,22 @@
+// Taken from https://github.com/wordpress-mobile/WordPress-Android/blob/trunk/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/viewholders/ActionCardViewHolder.kt
+import android.view.ViewGroup
+import androidx.core.text.HtmlCompat
+import org.wordpress.android.databinding.StatsBlockListActionCardBinding
+import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.ListItemActionCard
+import org.wordpress.android.util.extensions.viewBinding
+
+class ActionCardViewHolder(
+    val parent: ViewGroup,
+    val binding: StatsBlockListActionCardBinding = parent.viewBinding(StatsBlockListActionCardBinding::inflate)
+) : BlockListItemViewHolder(binding.root) {
+    fun bind(
+        item: ListItemActionCard
+    ) = with(binding) {
+        actionTitle.text = parent.context.getString(item.titleResource)
+        actionMessage.text = HtmlCompat.fromHtml(parent.context.getString(item.text), HtmlCompat.FROM_HTML_MODE_LEGACY)
+        buttonPositive.setText(item.positiveButtonText)
+        buttonPositive.setOnClickListener { item.positiveAction.click() }
+        buttonNegative.setText(item.negativeButtonText)
+        buttonNegative.setOnClickListener { item.negativeAction.click() }
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/android/java/org/view/MyRecyclerView.java

@@ -0,0 +1,7 @@
+package src.android.java.org.view;
+
+public class MyRecyclerView extends RecyclerView {
+    public List<Items> list() {
+        
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/androidTest/java/org/test/AbcTests.java

@@ -0,0 +1,5 @@
+package src.androidTest.java.org.test;
+
+public class AbcTests {
+    public void Abc() { Abc.main([]) }
+}

data/spec/fixtures/android_unit_test_checker/src/androidTest/java/org/test/AnotherTestClass.java

@@ -0,0 +1,7 @@
+package src.androidTest.java.org.test;
+
+public class AnotherTestClass {
+    public void testWriteMeATest() {
+        new TestsINeedThem().writeMeATest()
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/androidTest/java/org/test/PolygonTest.kt

@@ -0,0 +1,4 @@
+class PolygonTest
+{
+    fun testDraw() { Polygon().draw() }
+}

data/spec/fixtures/android_unit_test_checker/src/androidTest/java/org/test/TestMyNewClass.java

@@ -0,0 +1,9 @@
+package src.androidTest.java.org.test;
+
+class TestMyNewClass
+{
+    public void testMe()
+    {
+        new MyNewClass().testMe()
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/androidTest/java/org/test/ToolTest.kt

@@ -0,0 +1,5 @@
+class ToolTest {
+    fun testMethod() {
+        
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/main/java/org/wordpress/android/widgets/NestedWebView.kt

@@ -0,0 +1,32 @@
+// example declaration taken from https://github.com/wordpress-mobile/WordPress-Android/blob/44282b137085ec230771fc2c87ad9a44610fbeb1/WordPress/src/main/java/org/wordpress/android/widgets/NestedWebView.kt
+package org.wordpress.android.widgets
+
+import android.annotation.SuppressLint
+import android.content.Context
+import android.util.AttributeSet
+import android.view.MotionEvent
+import androidx.core.view.NestedScrollingChild3
+import androidx.core.view.NestedScrollingChildHelper
+import androidx.core.view.ViewCompat
+import org.wordpress.android.ui.WPWebView
+import android.R as AndroidR
+
+class NestedWebView @JvmOverloads constructor(
+    context: Context,
+    attrs: AttributeSet? = null,
+    defStyleAttr: Int = AndroidR.attr.webViewStyle
+) : WPWebView(context, attrs, defStyleAttr), NestedScrollingChild3 {
+    private var lastY = 0
+    private val scrollOffset = IntArray(2)
+    private val scrollConsumed = IntArray(2)
+    private var nestedOffsetY = 0
+    private val nestedScrollingChildHelper: NestedScrollingChildHelper = NestedScrollingChildHelper(this)
+
+    override fun dispatchNestedPreFling(velocityX: Float, velocityY: Float): Boolean {
+        return nestedScrollingChildHelper.dispatchNestedPreFling(velocityX, velocityY)
+    }
+
+    init {
+        isNestedScrollingEnabled = true
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/main/java/org/wordpress/util/config/BloggingPromptsFeatureConfig.kt

@@ -0,0 +1,23 @@
+// Taken from https://github.com/wordpress-mobile/WordPress-Android/blob/44282b137085ec230771fc2c87ad9a44610fbeb1/WordPress/src/main/java/org/wordpress/android/util/config/BloggingPromptsFeatureConfig.kt
+package org.wordpress.android.util.config
+
+import org.wordpress.android.BuildConfig
+import org.wordpress.android.annotation.Feature
+import org.wordpress.android.util.config.BloggingPromptsFeatureConfig.Companion.BLOGGING_PROMPTS_REMOTE_FIELD
+import javax.inject.Inject
+
+@Feature(BLOGGING_PROMPTS_REMOTE_FIELD, true)
+class BloggingPromptsFeatureConfig
+@Inject constructor(appConfig: AppConfig) : FeatureConfig(
+    appConfig,
+    BuildConfig.BLOGGING_PROMPTS,
+    BLOGGING_PROMPTS_REMOTE_FIELD
+) {
+    override fun isEnabled(): Boolean {
+        return super.isEnabled() && BuildConfig.IS_JETPACK_APP
+    }
+
+    companion object {
+        const val BLOGGING_PROMPTS_REMOTE_FIELD = "blogging_prompts_remote_field"
+    }
+}

data/spec/fixtures/android_unit_test_checker/src/test/java/org/test/TestsINeedThem.java

@@ -0,0 +1,9 @@
+package src.test.java.org.test;
+
+class TestsINeedThemTests
+{
+    void testINeedTests()
+    {
+        new TestsINeedThem().testMe();
+    }
+}

data/spec/github_utils_spec.rb

@@ -0,0 +1,110 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::GithubUtils do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe 'with the common_release_checker plugin' do
+      let(:github) do
+        instance_double(Danger::DangerfileGitHubPlugin, {
+                          pr_json: {
+                            'base' => { 'repo' => { 'full_name' => 'Automattic/dangermattic' } },
+                            'number' => 42,
+                            'requested_teams' => [],
+                            'requested_reviewers' => []
+                          },
+                          api: instance_double(Octokit::Client),
+                          branch_for_base: 'main',
+                          pr_labels: [],
+                          pr_title: 'Some PR Title'
+                        })
+      end
+
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.github_utils
+
+        allow(@plugin).to receive(:github).and_return(github)
+      end
+
+      describe '#active_reviewers?' do
+        it 'returns true when there are active reviewers' do
+          allow(github.api).to receive(:pull_request_reviews).and_return(%w[review1 review2])
+          expect(@plugin.active_reviewers?).to be(true)
+        end
+
+        it 'returns false when there are no active reviewers' do
+          allow(github.api).to receive(:pull_request_reviews).and_return([])
+          expect(@plugin.active_reviewers?).to be(false)
+        end
+      end
+
+      describe '#requested_reviewers?' do
+        it 'returns true when there are requested reviewers' do
+          allow(github.pr_json).to receive(:[]).with('requested_teams').and_return(['team1'])
+          expect(@plugin.requested_reviewers?).to be(true)
+        end
+
+        it 'returns true when there are active reviewers' do
+          allow(github.api).to receive(:pull_request_reviews).and_return(%w[review1 review2])
+          expect(@plugin.requested_reviewers?).to be(true)
+        end
+
+        it 'returns false when there are no requested reviewers or active reviewers' do
+          allow(github.api).to receive(:pull_request_reviews).and_return([])
+          expect(@plugin.requested_reviewers?).to be(false)
+        end
+      end
+
+      describe '#main_branch?' do
+        it 'returns true when the branch is a main branch' do
+          allow(github).to receive(:branch_for_base).and_return('develop')
+          expect(@plugin.main_branch?).to be(true)
+        end
+
+        it 'returns false when the branch is not a main branch' do
+          allow(github).to receive(:branch_for_base).and_return('feature-branch')
+          expect(@plugin.main_branch?).to be(false)
+        end
+      end
+
+      describe '#release_branch?' do
+        it 'returns true when the branch is a release branch' do
+          allow(github).to receive(:branch_for_base).and_return('release/30.6.0')
+          expect(@plugin.release_branch?).to be(true)
+        end
+
+        it 'returns true when the branch is a hotfix branch' do
+          allow(github).to receive(:branch_for_base).and_return('hotfix/fix-bug')
+          expect(@plugin.release_branch?).to be(true)
+        end
+
+        it 'returns false when the branch is neither a release nor a hotfix branch' do
+          allow(github).to receive(:branch_for_base).and_return('feature-branch')
+          expect(@plugin.release_branch?).to be(false)
+        end
+      end
+
+      describe '#wip_feature?' do
+        it 'returns true when there is a WIP label' do
+          allow(github).to receive(:pr_labels).and_return(['WIP'])
+          expect(@plugin.wip_feature?).to be(true)
+        end
+
+        it 'returns true when there is WIP in the title' do
+          allow(github).to receive(:pr_title).and_return('WIP: Some PR Title')
+          expect(@plugin.wip_feature?).to be(true)
+        end
+
+        it 'returns false when there is no WIP label or WIP in the title' do
+          allow(github).to receive_messages(pr_labels: [], pr_title: 'Some PR Title')
+          expect(@plugin.wip_feature?).to be(false)
+        end
+      end
+    end
+  end
+end

data/spec/ios_release_checker_spec.rb

@@ -0,0 +1,191 @@
+# frozen_string_literal: true
+
+require_relative 'spec_helper'
+
+module Danger
+  describe Danger::IosReleaseChecker do
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.ios_release_checker
+
+        allow(@plugin.git).to receive_messages(added_files: [], modified_files: [], deleted_files: [])
+      end
+
+      context 'when changing the Core Data model' do
+        it 'reports a warning when a PR on a release branch changes a Core Data model' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['./path/to/model/Model.xcdatamodeld'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+          @plugin.check_core_data_model_changed
+
+          expect(@dangerfile).to report_warnings([IosReleaseChecker::MESSAGE_CORE_DATA_UPDATED])
+        end
+
+        it 'does nothing when a PR changes a Core Data model on a regular branch' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['./path/to/model/Model.xcdatamodeld'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+          @plugin.check_core_data_model_changed
+
+          expect(@dangerfile).to not_report
+        end
+
+        it 'does nothing when a PR ca warning when a PR does not change a Core Data model on the release branch' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['./path/to/view/model/MyViewModel.swift'])
+          allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+          @plugin.check_core_data_model_changed
+
+          expect(@dangerfile).to not_report
+        end
+      end
+
+      context 'when changing the Localizable.strings files' do
+        describe '#check_modified_localizable_strings_on_release' do
+          it 'reports a warning when a PR on a regular branch changes the source Localizable.strings' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['en.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+            @plugin.check_modified_localizable_strings_on_release
+
+            expect(@dangerfile).to report_warnings([IosReleaseChecker::MESSAGE_STRINGS_FILE_UPDATED])
+          end
+
+          it 'reports a warning when a PR on a regular branch changes a translated Localizable.strings' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['nl.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('trunk')
+
+            @plugin.check_modified_localizable_strings_on_release
+
+            expect(@dangerfile).to report_warnings([IosReleaseChecker::MESSAGE_STRINGS_FILE_UPDATED])
+          end
+
+          it 'does nothing when a PR changes the Localizable.strings on a release branch' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['en.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+            @plugin.check_modified_localizable_strings_on_release
+
+            expect(@dangerfile).to not_report
+          end
+
+          it 'does nothing when a PR does not change the Localizable.strings on a regular branch' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['./path/to/view/model/MyViewModel.swift'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+            @plugin.check_modified_localizable_strings_on_release
+
+            expect(@dangerfile).to not_report
+          end
+        end
+
+        describe '#check_modified_en_strings_on_regular_branch' do
+          it 'reports a warning when a PR on a release branch changes the source Localizable.strings' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['en.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+            @plugin.check_modified_en_strings_on_regular_branch
+
+            expect(@dangerfile).to report_warnings([IosReleaseChecker::MESSAGE_BASE_STRINGS_FILE_UPDATED])
+          end
+
+          it 'does nothing when a PR changes the Localizable.strings on a regular branch' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['en.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+            @plugin.check_modified_en_strings_on_regular_branch
+
+            expect(@dangerfile).to not_report
+          end
+
+          it 'does nothing when a PR on a release branch changes a translated Localizable.strings' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['nl.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+            @plugin.check_modified_en_strings_on_regular_branch
+
+            expect(@dangerfile).to not_report
+          end
+
+          it 'does nothing when a PR does not change the Localizable.strings on a release branch' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['./path/to/view/model/MyViewModel2.swift'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+            @plugin.check_modified_en_strings_on_regular_branch
+
+            expect(@dangerfile).to not_report
+          end
+        end
+
+        describe '#check_modified_translations_on_release_branch' do
+          it 'reports a warning when a PR on a regular branch changes a translation file' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['be.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+            @plugin.check_modified_translations_on_release_branch
+
+            expect(@dangerfile).to report_warnings([IosReleaseChecker::MESSAGE_TRANSLATION_FILE_UPDATED])
+          end
+
+          it 'does nothing when a PR changes a translation string on a release branch' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['fr.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('release/30.6')
+
+            @plugin.check_modified_translations_on_release_branch
+
+            expect(@dangerfile).to not_report
+          end
+
+          it 'does nothing when a PR on a regular branch changes the source Localizable.strings' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['./en.lproj/Localizable.strings'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+            @plugin.check_modified_translations_on_release_branch
+
+            expect(@dangerfile).to not_report
+          end
+
+          it 'does nothing when a PR does not change a translation file on a regular branch' do
+            allow(@plugin.git).to receive(:modified_files).and_return(['./path/to/view/model/MyViewModel3.swift'])
+            allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+
+            @plugin.check_modified_translations_on_release_branch
+
+            expect(@dangerfile).to not_report
+          end
+        end
+      end
+
+      context 'when changing the release notes' do
+        it 'reports a warning when a PR changes the release notes but not the AppStore strings file' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['Resources/release_notes.txt'])
+
+          @plugin.check_release_notes_and_app_store_strings
+
+          expect(@dangerfile).to report_messages([format(CommonReleaseChecker::MESSAGE_STORE_FILE_NOT_CHANGED, 'Resources/AppStoreStrings.po', 'Resources/release_notes.txt')])
+        end
+
+        it 'does nothing when a PR changes the release notes and the AppStore strings file' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['Resources/release_notes.txt', 'Resources/AppStoreStrings.po'])
+
+          @plugin.check_release_notes_and_app_store_strings
+
+          expect(@dangerfile).to not_report
+        end
+
+        it 'does nothing when a PR does not change the release notes or the AppStore strings file' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['MyView.swift', 'Resources/AppStoreStrings.tmp'])
+
+          @plugin.check_release_notes_and_app_store_strings
+
+          expect(@dangerfile).to not_report
+        end
+      end
+    end
+  end
+end