danconia 0.2.5 → 0.3.0

data/spec/danconia/stores/in_memory_spec.rb

@@ -0,0 +1,18 @@
+module Danconia
+  module Stores
+    describe InMemory do
+      context 'rates' do
+        it 'filters rates by type' do
+          subject.save_rates [
+            {pair: 'USDARS', rate: 3, rate_type: 'divisas'},
+            {pair: 'USDARS', rate: 4, rate_type: 'billetes'}
+          ]
+
+          expect(subject.rates(rate_type: 'divisas')).to match [include(rate: 3)]
+          expect(subject.rates(rate_type: 'billetes')).to match [include(rate: 4)]
+          expect(subject.rates).to match [include(rate: 3), include(rate: 4)]
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,8 +1,9 @@
 require 'danconia'
 require 'danconia/test_helpers'
+require 'danconia/integrations/active_record'
 require 'webmock/rspec'
 
-Dir["#{__dir__}/support/*.rb"].each { |f| require f }
+Dir["#{__dir__}/support/*.rb"].sort.each { |f| require f }
 
 RSpec.configure do |config|
   config.filter_run_when_matching :focus

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: danconia
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.3.0
 platform: ruby
 authors:
 - Emmanuel Nicolau
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-26 00:00:00.000000000 Z
+date: 2020-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -108,14 +122,44 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.80.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.80.0
 description: Multi-currency money library backed by BigDecimal
 email: emmanicolau@gmail.com
-executables: []
+executables:
+- console
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"
 - Gemfile
@@ -124,7 +168,9 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/console
 - danconia.gemspec
+- examples/bna.rb
 - examples/currency_layer.rb
 - examples/fixed_rates.rb
 - examples/single_currency.rb
@@ -133,21 +179,28 @@ files:
 - lib/danconia/currency.rb
 - lib/danconia/errors/api_error.rb
 - lib/danconia/errors/exchange_rate_not_found.rb
+- lib/danconia/exchange.rb
+- lib/danconia/exchanges/bna.rb
 - lib/danconia/exchanges/currency_layer.rb
-- lib/danconia/exchanges/exchange.rb
 - lib/danconia/exchanges/fixed_rates.rb
 - lib/danconia/integrations/active_record.rb
 - lib/danconia/kernel.rb
 - lib/danconia/money.rb
+- lib/danconia/pair.rb
 - lib/danconia/stores/active_record.rb
 - lib/danconia/stores/in_memory.rb
 - lib/danconia/test_helpers.rb
 - lib/danconia/version.rb
+- spec/danconia/exchanges/bna_spec.rb
 - spec/danconia/exchanges/currency_layer_spec.rb
-- spec/danconia/exchanges/fixed_rates_spec.rb
+- spec/danconia/exchanges/exchange_spec.rb
+- spec/danconia/exchanges/fixtures/bna/home.html
+- spec/danconia/exchanges/fixtures/currency_layer/failure.json
+- spec/danconia/exchanges/fixtures/currency_layer/success.json
 - spec/danconia/integrations/active_record_spec.rb
 - spec/danconia/money_spec.rb
 - spec/danconia/stores/active_record_spec.rb
+- spec/danconia/stores/in_memory_spec.rb
 - spec/spec_helper.rb
 - spec/support/database.rb
 homepage: https://github.com/eeng/danconia
@@ -175,10 +228,15 @@ signing_key:
 specification_version: 4
 summary: Multi-currency money library backed by BigDecimal
 test_files:
+- spec/danconia/exchanges/bna_spec.rb
 - spec/danconia/exchanges/currency_layer_spec.rb
-- spec/danconia/exchanges/fixed_rates_spec.rb
+- spec/danconia/exchanges/exchange_spec.rb
+- spec/danconia/exchanges/fixtures/bna/home.html
+- spec/danconia/exchanges/fixtures/currency_layer/failure.json
+- spec/danconia/exchanges/fixtures/currency_layer/success.json
 - spec/danconia/integrations/active_record_spec.rb
 - spec/danconia/money_spec.rb
 - spec/danconia/stores/active_record_spec.rb
+- spec/danconia/stores/in_memory_spec.rb
 - spec/spec_helper.rb
 - spec/support/database.rb

data/lib/danconia/exchanges/exchange.rb

@@ -1,31 +0,0 @@
-module Danconia
-  module Exchanges
-    class Exchange
-      attr_reader :store
-
-      def initialize store: Stores::InMemory.new
-        @store = store
-      end
-
-      def rate from, to
-        if from == 'USD' and direct_rate = @store.direct_rate(from, to)
-          direct_rate
-        elsif to == 'USD' and inverse_rate = @store.direct_rate(to, from)
-          (1.0 / inverse_rate).round 6
-        elsif from != 'USD' and to != 'USD' and from_in_usd = rate(from, 'USD') and to_per_usd = rate('USD', to)
-          (from_in_usd * to_per_usd).round 6
-        else
-          raise Errors::ExchangeRateNotFound.new(from, to)
-        end
-      end
-
-      def rates
-        @store.rates
-      end
-
-      def update_rates!
-        @store.save_rates fetch_rates
-      end
-    end
-  end
-end

data/spec/danconia/exchanges/fixed_rates_spec.rb

@@ -1,30 +0,0 @@
-require 'spec_helper'
-
-module Danconia
-  module Exchanges
-    describe FixedRates do
-      context 'rate' do
-        it 'returns the exchange rate value for the supplied currencies' do
-          exchange = FixedRates.new rates: {'USDEUR' => 3, 'USDARS' => 4}
-          expect(exchange.rate 'USD', 'EUR').to eq 3
-          expect(exchange.rate 'USD', 'ARS').to eq 4
-        end
-
-        it 'returns nil if not found' do
-          expect { subject.rate 'USD', 'EUR' }.to raise_error Errors::ExchangeRateNotFound
-        end
-
-        it 'if the direct conversion is not found, tries to find the inverse' do
-          exchange = FixedRates.new rates: {'USDEUR' => 3}
-          expect(exchange.rate 'EUR', 'USD').to eq (1.0 / 3).round 6
-        end
-
-        it 'if not direct nor inverse conversion is found and both are different than USD, tries to convert through USD' do
-          exchange = FixedRates.new rates: {'USDEUR' => 3, 'USDARS' => 6}
-          expect(exchange.rate 'EUR', 'ARS').to be_within(0.00001).of 2
-          expect(exchange.rate 'ARS', 'EUR').to be_within(0.00001).of 0.5
-        end
-      end
-    end
-  end
-end