RubyGems - danconia - Versions diffs - 0.2.5 → 0.3.0 - Mend

danconia 0.2.5 → 0.3.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (37) hide show

checksums.yaml +4 -4
data/.rubocop.yml +104 -0
data/.travis.yml +4 -0
data/Gemfile.lock +40 -17
data/README.md +16 -2
data/bin/console +7 -0
data/danconia.gemspec +5 -1
data/examples/bna.rb +35 -0
data/examples/currency_layer.rb +8 -4
data/examples/fixed_rates.rb +1 -3
data/examples/single_currency.rb +2 -3
data/lib/danconia.rb +6 -4
data/lib/danconia/currency.rb +2 -2
data/lib/danconia/exchange.rb +47 -0
data/lib/danconia/exchanges/bna.rb +61 -0
data/lib/danconia/exchanges/currency_layer.rb +14 -2
data/lib/danconia/exchanges/fixed_rates.rb +2 -4
data/lib/danconia/integrations/active_record.rb +13 -14
data/lib/danconia/money.rb +25 -24
data/lib/danconia/pair.rb +15 -0
data/lib/danconia/stores/active_record.rb +29 -6
data/lib/danconia/stores/in_memory.rb +4 -9
data/lib/danconia/version.rb +1 -1
data/spec/danconia/exchanges/bna_spec.rb +36 -0
data/spec/danconia/exchanges/currency_layer_spec.rb +28 -33
data/spec/danconia/exchanges/exchange_spec.rb +54 -0
data/spec/danconia/exchanges/fixtures/bna/home.html +124 -0
data/spec/danconia/exchanges/fixtures/currency_layer/failure.json +7 -0
data/spec/danconia/exchanges/fixtures/currency_layer/success.json +8 -0
data/spec/danconia/integrations/active_record_spec.rb +25 -5
data/spec/danconia/money_spec.rb +57 -15
data/spec/danconia/stores/active_record_spec.rb +81 -15
data/spec/danconia/stores/in_memory_spec.rb +18 -0
data/spec/spec_helper.rb +2 -1
metadata +67 -9
data/lib/danconia/exchanges/exchange.rb +0 -31
data/spec/danconia/exchanges/fixed_rates_spec.rb +0 -30

data/spec/danconia/exchanges/exchange_spec.rb ADDED

@@ -0,0 +1,54 @@
+module Danconia
+  module Exchanges
+    describe Exchange do
+      context 'rate' do
+        it 'returns the exchange rate value for the supplied currencies' do
+          exchange = fake_exchange('USDEUR' => 3, 'USDARS' => 4)
+          expect(exchange.rate('USD', 'EUR')).to eq 3
+          expect(exchange.rate('USD', 'ARS')).to eq 4
+        end
+        it 'if the direct conversion is not found, tries to find the inverse' do
+          exchange = fake_exchange('USDEUR' => 3)
+          expect(exchange.rate('EUR', 'USD')).to be_within(0.00001).of(1.0 / 3)
+        end
+        it 'if not direct nor inverse conversion is found, tries to convert through USD' do
+          exchange = fake_exchange('USDEUR' => 3, 'USDARS' => 6)
+          expect(exchange.rate('EUR', 'ARS')).to be_within(0.00001).of 2
+          expect(exchange.rate('ARS', 'EUR')).to be_within(0.00001).of 0.5
+        end
+        it 'pairs can have a different common currency' do
+          exchange = fake_exchange('EURARS' => 3, 'BRLARS' => 1.5)
+          expect(exchange.rate('EUR', 'ARS')).to eq 3
+          expect(exchange.rate('ARS', 'EUR')).to be_within(0.00001).of(1.0 / 3)
+          expect(exchange.rate('BRL', 'ARS')).to eq 1.5
+          expect(exchange.rate('EUR', 'BRL')).to eq 3 / 1.5
+        end
+        it 'raises an error if the conversion cannot be made' do
+          expect { fake_exchange({}).rate('USD', 'EUR') }.to raise_error Errors::ExchangeRateNotFound
+        end
+        it 'should allow to pass options to filter the rates' do
+          exchange = Class.new(Exchange) do
+            def rates type:
+              case type
+              when 'divisa' then {'USDARS' => 7}
+              when 'billete' then {'USDARS' => 8}
+              end
+            end
+          end.new
+          expect(exchange.rate('USD', 'ARS', type: 'divisa')).to eq 7
+          expect(exchange.rate('USD', 'ARS', type: 'billete')).to eq 8
+        end
+        def fake_exchange(rates)
+          FixedRates.new(rates: rates)
+        end
+      end
+    end
+  end
+end

data/spec/danconia/exchanges/fixtures/bna/home.html ADDED

@@ -0,0 +1,124 @@
+<!DOCTYPE html>
+<html lang="es" class="pc">
+<body>
+  <div id="rightHome">
+    <div class="col-md-3">
+      <div class="tabSmall">
+        <ul class="nav nav-tabs">
+          <li class="active"><a href="#billetes" data-toggle="tab">Cotización Billetes</a>
+            <div class="arrow"></div>
+          </li>
+          <li><a href="#divisas" data-toggle="tab">Cotización Divisas</a>
+            <div class="arrow"></div>
+          </li>
+        </ul>
+        <div class="tab-content">
+          <div class="tab-pane fade in active" id="billetes">
+            <table class="table cotizacion">
+              <thead>
+                <tr>
+                  <th class="fechaCot">1/9/2020</th>
+                  <th>Compra</th>
+                  <th>Venta</th>
+                </tr>
+              </thead>
+              <tbody>
+                <tr>
+                  <td class="tit">Dolar U.S.A</td>
+                  <td>73,2500</td>
+                  <td>78,2500</td>
+                </tr>
+                <tr>
+                  <td class="tit">Euro</td>
+                  <td>84,0000</td>
+                  <td>89,0000</td>
+                </tr>
+                <tr>
+                  <td class="tit">Real *</td>
+                  <td>1250,0000</td>
+                  <td>1450,0000</td>
+                </tr>
+              </tbody>
+            </table>
+            <a href="#" class="link-cotizacion" data-toggle="modal" data-target="#modalHistorico" id="buttonHistoricoBilletes">Ver histórico</a>
+            <div class="legal">Hora Actualización: 10:40</div>
+            <div class="legal">(*) cotización cada 100 unidades.</div>
+          </div>
+          <div class="tab-pane fade" id="divisas">
+            <table class="table cotizacion">
+              <thead>
+                <tr>
+                  <th class="fechaCot">31/8/2020</th>
+                  <th>Compra</th>
+                  <th>Venta</th>
+                </tr>
+              </thead>
+              <tbody>
+                <tr>
+                  <td class="tit">Dolar U.S.A</td>
+                  <td>73.9800</td>
+                  <td>74.1800</td>
+                </tr>
+                <tr>
+                  <td class="tit">Libra Esterlina</td>
+                  <td>98.8743</td>
+                  <td>99.3641</td>
+                </tr>
+                <tr>
+                  <td class="tit">Euro</td>
+                  <td>88.2581</td>
+                  <td>88.6822</td>
+                </tr>
+                <tr>
+                  <td class="tit">Franco Suizos *</td>
+                  <td>8188.4905</td>
+                  <td>8221.8519</td>
+                </tr>
+                <tr>
+                  <td class="tit">YENES *</td>
+                  <td>69.8238</td>
+                  <td>70.1124</td>
+                </tr>
+                <tr>
+                  <td class="tit">Dolares Canadienses *</td>
+                  <td>5675.3160</td>
+                  <td>5698.6457</td>
+                </tr>
+                <tr>
+                  <td class="tit">Coronas Danesas *</td>
+                  <td>1184.4394</td>
+                  <td>1195.0806</td>
+                </tr>
+                <tr>
+                  <td class="tit">Coronas Noruegas *</td>
+                  <td>845.1963</td>
+                  <td>854.8381</td>
+                </tr>
+                <tr>
+                  <td class="tit">Coronas Suecas *</td>
+                  <td>853.8596</td>
+                  <td>863.8369</td>
+                </tr>
+              </tbody>
+            </table>
+            <a href="#" class="link-cotizacion" data-toggle="modal" data-target="#modalHistorico" id="buttonHistoricoMonedas">Ver histórico</a>
+            <div class="legal">(*) cotización cada 100 unidades.</div>
+            <div class="legal leyenda">El tipo de cambio de cierre de divisa es suministrado al público a fines informativos, como referencia de la cotización de la divisa en el mercado mayorista al final de cada día.</div>
+          </div>
+        </div>
+      </div>
+    </div>
+</body>
+</html>

data/spec/danconia/exchanges/fixtures/currency_layer/failure.json ADDED

@@ -0,0 +1,7 @@
+{
+  "success": false,
+  "error": {
+    "code": 104,
+    "info": "Your monthly usage limit has been reached. Please upgrade your subscription plan."
+  }
+}

data/spec/danconia/exchanges/fixtures/currency_layer/success.json ADDED

@@ -0,0 +1,8 @@
+{
+  "success": true,
+  "source": "USD",
+  "quotes": {
+    "USDARS": 27.110001,
+    "USDAUD": 1.346196
+  }
+}

data/spec/danconia/integrations/active_record_spec.rb CHANGED

@@ -1,12 +1,10 @@
-require 'spec_helper'
 module Danconia
   describe Integrations::ActiveRecord, active_record: true do
     context 'single currency' do
       it 'setter' do
-        expect(Product.new(price: 1.536).read_attribute :price).to eq 1.54
-        expect(Product.new(price: nil).read_attribute :price).to eq nil
-        expect(Product.new(price: Money(3)).read_attribute :price).to eq 3
+        expect(Product.new(price: 1.536).read_attribute(:price)).to eq 1.54
+        expect(Product.new(price: nil).read_attribute(:price)).to eq nil
+        expect(Product.new(price: Money(3)).read_attribute(:price)).to eq 3
       end
       it 'getter' do
@@ -34,6 +32,28 @@ module Danconia
       end
     end
+    context 'exchange options support' do
+      let(:exchange) do
+        Class.new(Exchange) do
+          def rates rate_type:
+            case rate_type
+            when 'divisa' then {'USDARS' => 7}
+            when 'billete' then {'USDARS' => 8}
+            end
+          end
+        end.new
+      end
+      it 'allows to specify options that will be pass to the exchange when exchanging to other currencies' do
+        klass = Class.new(ActiveRecord::Base) do
+          self.table_name = 'products'
+          money :price, rate_type: 'divisa'
+        end
+        expect(klass.new(price: Money(10, 'USD')).price.exchange_to('ARS', exchange: exchange)).to eq Money(70, 'ARS')
+      end
+    end
     class Product < ActiveRecord::Base
       money :price, :tax, :discount, :cost
     end

data/spec/danconia/money_spec.rb CHANGED

@@ -1,5 +1,3 @@
-require 'spec_helper'
 module Danconia
   describe Money do
     context 'instantiation' do
@@ -39,16 +37,15 @@ module Danconia
       end
       it 'should exchange the other currency if it is different' do
-        expect(Money(1, 'ARS') + Money(1, 'USD', exchange: fake_exchange(rate: 4))).to eq Money(5, 'ARS')
+        m1 = Money(1, 'ARS', exchange_opts: {exchange: fake_exchange(rate: 4)})
+        expect(m1 + Money(1, 'USD')).to eq Money(5, 'ARS')
       end
       it 'should return a new object with the same options' do
-        e = fake_exchange
-        m1 = Money(4, decimals: 3, exchange: e)
+        m1 = Money(4, decimals: 3)
         m2 = m1 * 2
         expect(m2).to_not eql m1
         expect(m2.decimals).to eq 3
-        expect(m2.exchange).to eq e
       end
       it 'round should return a money object with the same currency' do
@@ -72,7 +69,7 @@ module Danconia
       end
       it 'should exchange to the source currency if they differ' do
-        TestHelpers.with_rates 'USDARS' => 4 do |config|
+        TestHelpers.with_rates 'USDARS' => 4 do |_config|
           expect(Money(3, 'ARS') < Money(1, 'USD')).to be true
           expect(Money(4, 'ARS') < Money(1, 'USD')).to be false
         end
@@ -121,17 +118,30 @@ module Danconia
     end
     context 'exchange_to' do
-      it 'should use the exchange passed to the instance to get the rate' do
-        expect(Money(2, 'USD', exchange: fake_exchange(rate: 3)).exchange_to('ARS')).to eq Money(6, 'ARS')
-      end
-      it 'should use the default exchange if not set' do
+      it 'should use a default exchange if not overriden' do
         TestHelpers.with_rates 'USDEUR' => 3, 'USDARS' => 4 do
           expect(Money(2, 'USD').exchange_to('EUR')).to eq Money(6, 'EUR')
           expect(Money(2, 'USD').exchange_to('ARS')).to eq Money(8, 'ARS')
         end
       end
+      it 'should allow to pass the exchange to the instance' do
+        m = Money(2, 'USD', exchange_opts: {exchange: fake_exchange(rate: 3)})
+        expect(m.exchange_to('ARS')).to eq Money(6, 'ARS')
+      end
+      it 'should allow to pass the exchange when converting' do
+        expect(Money(2, 'USD').exchange_to('ARS', exchange: fake_exchange(rate: 4))).to eq Money(8, 'ARS')
+      end
+      it 'when overriding the exchange, should preserve it in the new instances' do
+        m1 = Money(1, 'USD').exchange_to('ARS', exchange: fake_exchange(rate: 2))
+        m2 = m1 + Money(3, 'USD')
+        m3 = m2 * Money(1, 'USD')
+        expect(m2).to eq Money(8, 'ARS')
+        expect(m3).to eq Money(16, 'ARS')
+      end
       it 'if no rate if found should raise error' do
         expect { Money(2, 'USD').exchange_to('ARS') }.to raise_error Errors::ExchangeRateNotFound
       end
@@ -141,8 +151,8 @@ module Danconia
       end
       it 'should return a new object with the same opts' do
-        m1 = Money(1, 'USD', decimals: 0, exchange: fake_exchange(rate: 3))
-        m2 = m1.exchange_to('ARS')
+        m1 = Money(1, 'USD', decimals: 0)
+        m2 = m1.exchange_to('ARS', exchange: fake_exchange(rate: 3))
         expect(m2).to_not eql m1
         expect(m2.decimals).to eq 0
         expect(m1).to eq Money(1, 'USD')
@@ -152,6 +162,38 @@ module Danconia
         expect(Money(1, 'USD').exchange_to('')).to eq Money(1, 'USD')
         expect(Money(1, 'ARS').exchange_to('')).to eq Money(1, 'ARS')
       end
+      context 'opts' do
+        let(:exchange) do
+          Class.new(Exchange) do
+            def rates opts
+              case opts[:type]
+              when 'divisa' then {'USDARS' => 7}
+              when 'billete' then {'USDARS' => 8}
+              else {}
+              end
+            end
+          end.new
+        end
+        it 'allows to specify opts to pass to the exchange (filters for example)' do
+          expect(Money(1, 'USD').exchange_to('ARS', type: 'divisa', exchange: exchange)).to eq Money(7, 'ARS')
+          expect { Money(1, 'USD').exchange_to('ARS', exchange: exchange) }.to raise_error Errors::ExchangeRateNotFound
+        end
+        it 'should be preserved after operations' do
+          m1 = Money(1, 'USD').exchange_to('ARS', type: 'divisa', exchange: exchange)
+          m2 = m1 + Money(2, 'USD')
+          expect(m2).to eq Money(21, 'ARS')
+          expect(m1 < Money(2, 'USD')).to eq true
+        end
+        it 'should use the instance exchange_opts by default' do
+          m = Money(1, 'USD', exchange_opts: {exchange: exchange, type: 'billete'})
+          expect(m.exchange_to('ARS')).to eq Money(8, 'ARS')
+        end
+      end
     end
     context 'default_currency?' do
@@ -178,7 +220,7 @@ module Danconia
     end
     def fake_exchange args = {}
-      double 'exchange', args.reverse_merge(rate: nil)
+      double 'Danconia::Exchange', args.reverse_merge(rate: nil)
     end
   end
 end

data/spec/danconia/stores/active_record_spec.rb CHANGED

@@ -1,31 +1,97 @@
-require 'spec_helper'
 module Danconia
   module Stores
     describe ActiveRecord, active_record: true do
+      before do
+        ::ActiveRecord::Schema.define do
+          create_table :exchange_rates do |t|
+            t.string :pair, limit: 6
+            t.decimal :rate, precision: 12, scale: 6
+            t.string :rate_type
+            t.date :date
+          end
+        end
+      end
       context 'save_rates' do
         it 'should create or update the rates' do
           ExchangeRate.create! pair: 'USDEUR', rate: 2
-          expect { subject.save_rates 'USDEUR' => 3, 'USDARS' => 4 }.to change { ExchangeRate.count }.by 1
-          expect(subject.rates.map { |e| [e.pair, e.rate] }).to eq({'USDEUR' => 3, 'USDARS' => 4}.to_a)
+          expect do
+            subject.save_rates [{pair: 'USDEUR', rate: 3}, {pair: 'USDARS', rate: 4}]
+          end.to change { ExchangeRate.count }.by 1
+          expect(subject.rates).to match [
+            include(pair: 'USDEUR', rate: 3),
+            include(pair: 'USDARS', rate: 4)
+          ]
+        end
+        it 'allows to specify other keys to use as unique' do
+          store = ActiveRecord.new(unique_keys: %i[pair rate_type])
+          store.save_rates [
+            {pair: 'USDARS', rate: 3, rate_type: 'billetes'},
+            {pair: 'USDARS', rate: 4, rate_type: 'divisas'}
+          ]
+          store.save_rates [
+            {pair: 'USDARS', rate: 33, rate_type: 'billetes'}
+          ]
+          expect(subject.rates).to match [
+            include(pair: 'USDARS', rate: 33, rate_type: 'billetes'),
+            include(pair: 'USDARS', rate: 4, rate_type: 'divisas')
+          ]
+        end
+        it 'ignores fields not present in the database table' do
+          subject.save_rates [{pair: 'USDEUR', rate: 3, non_existant: 'ignoreme'}]
         end
       end
-      context '#direct_rate' do
-        it 'should find the rate for the pair' do
+      context 'rates' do
+        it 'returns an array like the one it received' do
           ExchangeRate.create! pair: 'USDEUR', rate: 2
-          expect(subject.direct_rate('USD', 'EUR')).to eq 2
-          expect(subject.direct_rate('USD', 'ARS')).to eq nil
+          ExchangeRate.create! pair: 'USDARS', rate: 40
+          expect(subject.rates).to match [
+            include(pair: 'USDEUR', rate: 2),
+            include(pair: 'USDARS', rate: 40)
+          ]
+        end
+        it 'allows to pass filters' do
+          store = ActiveRecord.new(unique_keys: %i[pair date])
+          store.save_rates [
+            {pair: 'USDEUR', rate: 10, date: Date.new(2020, 1, 1)},
+            {pair: 'USDEUR', rate: 20, date: Date.new(2020, 1, 2)},
+            {pair: 'USDEUR', rate: 30, date: Date.new(2020, 1, 3)}
+          ]
+          expect(store.rates.size).to eq 3
+          expect(store.rates(date: Date.new(2020, 1, 2))).to match [include(rate: 20)]
         end
       end
-      before do
-        ::ActiveRecord::Schema.define do
-          create_table :exchange_rates do |t|
-            t.string :pair, limit: 6
-            t.decimal :rate, precision: 12, scale: 6
-            t.index :pair, unique: true
-          end
+      context 'special date field' do
+        let(:store) do
+          store = ActiveRecord.new(unique_keys: %i[pair date], date_field: :date)
+          store.save_rates [
+            {pair: 'USDEUR', rate: 10, date: Date.new(2000, 1, 1)},
+            {pair: 'USDEUR', rate: 20, date: Date.new(2000, 1, 2)},
+            {pair: 'USDEUR', rate: 30, date: Date.new(2000, 1, 4)}
+          ]
+          store
+        end
+        it 'calling #rates with a particular date when there are rates for that date' do
+          expect(store.rates(date: Date.new(2000, 1, 2))).to match [include(rate: 20)]
+        end
+        it 'calling #rates with a particular date when there are not rates for that date should return the previous' do
+          expect(store.rates(date: Date.new(2000, 1, 3))).to match [include(rate: 20)]
+          expect(store.rates(date: Date.new(1999, 12, 31))).to eq []
+        end
+        it 'calling #rates without a particular date, uses today' do
+          expect(store.rates).to match [include(rate: 30)]
         end
       end
     end