danconia 0.2.5 → 0.3.0

data/lib/danconia/exchanges/bna.rb

@@ -0,0 +1,61 @@
+require 'danconia/errors/api_error'
+require 'net/http'
+require 'nokogiri'
+
+module Danconia
+  module Exchanges
+    # The BNA does not provide an API to pull the rates, so this implementation scrapes the home HTML directly.
+    # Returns rates of both types, "Billetes" and "Divisas", and only the "tipo de cambio vendedor" ones.
+    # See `examples/bna.rb` for a complete usage example.
+    class BNA < Exchange
+      attr_reader :store
+
+      def initialize store: Stores::InMemory.new
+        @store = store
+      end
+
+      def fetch_rates
+        response = Net::HTTP.get URI 'https://www.bna.com.ar/Personas'
+        scrape_rates(response, 'billetes') + scrape_rates(response, 'divisas')
+      end
+
+      def update_rates!
+        @store.save_rates fetch_rates
+      end
+
+      def rates rate_type:, date: nil
+        array_of_rates_to_hash @store.rates(rate_type: rate_type, date: date)
+      end
+
+      private
+
+      def scrape_rates response, type
+        doc = Nokogiri::XML(response).css("##{type}")
+
+        if doc.css('thead th:last-child').text != 'Venta'
+          raise Errors::APIError, "Could not scrape '#{type}' rates. Maybe the format changed?"
+        end
+
+        doc.css('tbody tr').map do |row|
+          pair = parse_pair(row.css('td:first-child').text) or next
+          rate = parse_rate(row.css('td:last-child').text, pair)
+          date = Date.parse(doc.css('.fechaCot').text)
+          {pair: pair, rate: rate, date: date, rate_type: type}
+        end.compact.presence or raise Errors::APIError, "Could not scrape '#{type}' rates. Maybe the format changed?"
+      end
+
+      def parse_pair cur_name
+        case cur_name
+        when 'Dolar U.S.A' then 'USDARS'
+        when 'Euro' then 'EURARS'
+        when 'Real *' then 'BRLARS'
+        end
+      end
+
+      def parse_rate str, pair
+        val = Float(str.tr(',', '.'))
+        pair == 'BRLARS' ? val / 100.0 : val
+      end
+    end
+  end
+end

data/lib/danconia/exchanges/currency_layer.rb

@@ -4,10 +4,14 @@ require 'json'
 
 module Danconia
   module Exchanges
+    # Fetches the rates from https://currencylayer.com/. The `access_key` must be provided.
+    # See `examples/currency_layer.rb` for a complete usage example.
     class CurrencyLayer < Exchange
-      def initialize access_key:, **args
-        super args
+      attr_reader :store
+
+      def initialize access_key:, store: Stores::InMemory.new
         @access_key = access_key
+        @store = store
       end
 
       def fetch_rates
@@ -18,6 +22,14 @@ module Danconia
           raise Errors::APIError, response
         end
       end
+
+      def update_rates!
+        @store.save_rates fetch_rates.map { |pair, rate| {pair: pair, rate: rate} }
+      end
+
+      def rates **_opts
+        array_of_rates_to_hash @store.rates
+      end
     end
   end
 end

data/lib/danconia/exchanges/fixed_rates.rb

@@ -1,13 +1,11 @@
 module Danconia
   module Exchanges
     class FixedRates < Exchange
-      def initialize rates: {}, **args
-        super args
+      def initialize rates: {}
         @rates = rates
-        update_rates!
       end
 
-      def fetch_rates
+      def rates **_opts
         @rates
       end
     end

data/lib/danconia/integrations/active_record.rb

@@ -1,4 +1,5 @@
 require 'active_record'
+require 'danconia/stores/active_record'
 
 module Danconia
   module Integrations
@@ -8,24 +9,22 @@ module Danconia
       end
 
       module ClassMethods
-        def money(*attr_names)
+        def money(*attr_names, **exchange_opts)
           attr_names.each do |attr_name|
             amount_column = attr_name
-            currency_column = "#{attr_name}_currency"
+            currency_column = :"#{attr_name}_currency"
 
-            class_eval <<-EOR, __FILE__, __LINE__ + 1
-              def #{attr_name}= value
-                write_attribute :#{amount_column}, value.is_a?(Money) ? value.amount : value
-                write_attribute :#{currency_column}, value.currency.code if respond_to?(:#{currency_column}) && value.is_a?(Money)
-              end
+            define_method "#{attr_name}=" do |value|
+              write_attribute amount_column, value.is_a?(Money) ? value.amount : value
+              write_attribute currency_column, value.currency.code if respond_to?(currency_column) && value.is_a?(Money)
+            end
 
-              def #{attr_name}
-                amount = read_attribute :#{amount_column}
-                currency = read_attribute :#{currency_column}
-                decimals = self.class.columns.detect { |c| c.name == '#{amount_column}' }.scale
-                Money.new amount, currency, decimals: decimals if amount
-              end
-            EOR
+            define_method attr_name do
+              amount = read_attribute amount_column
+              currency = read_attribute currency_column
+              decimals = self.class.columns.detect { |c| c.name == amount_column.to_s }.scale
+              Money.new amount, currency, decimals: decimals, exchange_opts: exchange_opts if amount
+            end
           end
         end
       end

data/lib/danconia/money.rb

@@ -4,13 +4,13 @@ require 'danconia/errors/exchange_rate_not_found'
 module Danconia
   class Money
     include Comparable
-    attr_reader :amount, :currency, :decimals, :exchange
+    attr_reader :amount, :currency, :decimals
 
-    def initialize amount, currency_code = nil, decimals: 2, exchange: Danconia.config.default_exchange
-      @decimals = decimals
+    def initialize(amount, currency_code = nil, decimals: 2, exchange_opts: {})
       @amount = parse amount
-      @currency = Currency.find(currency_code || Danconia.config.default_currency, exchange)
-      @exchange = exchange
+      @decimals = decimals
+      @currency = Currency.find(currency_code || Danconia.config.default_currency)
+      @exchange_opts = exchange_opts.reverse_merge(exchange: Danconia.config.default_exchange)
     end
 
     def format decimals: @decimals, **other_options
@@ -41,29 +41,22 @@ module Danconia
     end
 
     def <=> other
-      other = other.exchange_to(currency).amount if other.is_a? Money
-      amount <=> other
-    end
-
-    def exchange_to other_currency
-      other_currency = other_currency.presence && Currency.find(other_currency, exchange) || currency
-      rate = exchange_rate_to(other_currency.code)
-      clone_with amount * rate, other_currency
+      amount <=> amount_exchanged_to_this_currency(other)
     end
 
-    def exchange_rate_to to
-      from = currency.code
-      return 1 if from == to
-      exchange.rate from, to
+    def exchange_to other_currency, **opts
+      opts = @exchange_opts.merge(opts)
+      other_currency = other_currency.presence && Currency.find(other_currency) || currency
+      rate = opts[:exchange].rate currency.code, other_currency.code, opts.except(:exchange)
+      clone_with amount * rate, other_currency, opts
     end
 
-    %w(+ - * /).each do |op|
-      class_eval <<-EOR, __FILE__, __LINE__ + 1
+    %w[+ - * /].each do |op|
+      class_eval <<-RUBY, __FILE__, __LINE__ + 1
         def #{op} other
-          other = other.exchange_to(currency).amount if other.is_a? Money
-          clone_with amount #{op} other
+          clone_with(amount #{op} amount_exchanged_to_this_currency(other))
         end
-      EOR
+      RUBY
     end
 
     def round *args
@@ -100,8 +93,16 @@ module Danconia
       BigDecimal(object.to_s) rescue BigDecimal(0)
     end
 
-    def clone_with amount, currency = @currency
-      Money.new amount, currency, decimals: decimals, exchange: exchange
+    def clone_with amount, currency = @currency, exchange_opts = @exchange_opts
+      Money.new amount, currency, decimals: @decimals, exchange_opts: exchange_opts
+    end
+
+    def amount_exchanged_to_this_currency other
+      if other.is_a? Money
+        other.exchange_to(currency, @exchange_opts).amount
+      else
+        other
+      end
     end
   end
 end

data/lib/danconia/pair.rb

@@ -0,0 +1,15 @@
+module Danconia
+  Pair = Struct.new(:from, :to) do
+    def self.parse str
+      new str[0..2], str[3..-1]
+    end
+
+    def invert
+      Pair.new to, from
+    end
+
+    def to_s
+      [from, to].join
+    end
+  end
+end

data/lib/danconia/stores/active_record.rb

@@ -1,20 +1,43 @@
 module Danconia
   module Stores
+    # Store implementation that persist rates using ActiveRecord.
     class ActiveRecord
+      # @param unique_keys [Array] each save_rates will update records with this keys' values
+      # @param date_field [Symbol] used when storing daily rates
+      def initialize unique_keys: %i[pair], date_field: nil
+        @unique_keys = unique_keys
+        @date_field = date_field
+      end
+
+      # Creates or updates the rates by the `unique_keys` provided in the constructor.
+      #
+      # @param rates [Array] must be an array of maps.
       def save_rates rates
         ExchangeRate.transaction do
-          rates.each do |pair, rate|
-            ExchangeRate.where(pair: pair).first_or_initialize.update rate: rate
+          rates.each do |fields|
+            ExchangeRate
+              .where(fields.slice(*@unique_keys))
+              .first_or_initialize
+              .update(fields.slice(*ExchangeRate.column_names.map(&:to_sym)))
           end
         end
       end
 
-      def direct_rate from, to
-        ExchangeRate.find_by(pair: [from, to].join)&.rate
+      # Returns an array of maps like the one it received.
+      def rates **filters
+        ExchangeRate.where(process_filters(filters)).map { |er| er.attributes.symbolize_keys }
       end
 
-      def rates
-        ExchangeRate.all
+      private
+
+      def process_filters filters
+        if @date_field
+          param = filters.delete(@date_field) || Date.today
+          last_record = ExchangeRate.where(filters).where("#{@date_field} <= ?", param).order(@date_field => :desc).first
+          filters.merge(@date_field => (last_record[@date_field] if last_record))
+        else
+          filters
+        end
       end
     end
 

data/lib/danconia/stores/in_memory.rb

@@ -1,19 +1,14 @@
 module Danconia
   module Stores
     class InMemory
-      attr_reader :rates
-
-      def initialize rates: {}
-        save_rates rates
-      end
-
-      # @rates should be of a map of pair->rate like {'USDEUR' => 1.25}
       def save_rates rates
         @rates = rates
       end
 
-      def direct_rate from, to
-        @rates[[from, to].join]
+      def rates **filters
+        @rates.select do |r|
+          filters.all? { |k, v| r[k] == v }
+        end
       end
     end
   end

data/lib/danconia/version.rb

@@ -1,3 +1,3 @@
 module Danconia
-  VERSION = '0.2.5'
+  VERSION = '0.3.0'
 end

data/spec/danconia/exchanges/bna_spec.rb

@@ -0,0 +1,36 @@
+require 'danconia/exchanges/bna'
+
+module Danconia
+  module Exchanges
+    describe BNA do
+      subject { BNA.new }
+
+      context 'fetch_rates' do
+        it 'extracts the rates from the html' do
+          stub_request(:get, 'https://www.bna.com.ar/Personas').to_return body: fixture('home.html')
+          rates = subject.fetch_rates
+
+          expect(rates.select { |r| r[:rate_type] == 'billetes' }).to eq [
+            {pair: 'USDARS', rate: 78.25, date: Date.new(2020, 9, 1), rate_type: 'billetes'},
+            {pair: 'EURARS', rate: 89, date: Date.new(2020, 9, 1), rate_type: 'billetes'},
+            {pair: 'BRLARS', rate: 14.5, date: Date.new(2020, 9, 1), rate_type: 'billetes'}
+          ]
+
+          expect(rates.select { |r| r[:rate_type] == 'divisas' }).to eq [
+            {pair: 'USDARS', rate: 74.18, date: Date.new(2020, 8, 31), rate_type: 'divisas'},
+            {pair: 'EURARS', rate: 88.6822, date: Date.new(2020, 8, 31), rate_type: 'divisas'}
+          ]
+        end
+
+        it 'raise error if cannot parse the document' do
+          stub_request(:get, 'https://www.bna.com.ar/Personas').to_return body: 'some invalid html'
+          expect { subject.fetch_rates }.to raise_error Errors::APIError
+        end
+
+        def fixture file
+          File.read("#{__dir__}/fixtures/bna/#{file}")
+        end
+      end
+    end
+  end
+end

data/spec/danconia/exchanges/currency_layer_spec.rb

@@ -1,55 +1,50 @@
-require 'spec_helper'
+require 'danconia/exchanges/currency_layer'
 
 module Danconia
   module Exchanges
     describe CurrencyLayer do
-      subject { CurrencyLayer.new access_key: '[KEY]' }
-
       context 'fetch_rates' do
+        subject { CurrencyLayer.new access_key: '[KEY]' }
+
         it 'uses the API to retrive the rates' do
-          stub_request(:get, 'http://www.apilayer.net/api/live?access_key=[KEY]').to_return body: <<~END
-            {
-                "success": true,
-                "source": "USD",
-                "quotes": {
-                    "USDARS": 27.110001,
-                    "USDAUD": 1.346196
-                }
-            }
-          END
+          stub_request(:get, 'http://www.apilayer.net/api/live?access_key=[KEY]')
+            .to_return(body: fixture('success.json'))
+
           expect(subject.fetch_rates).to eq 'USDARS' => 27.110001, 'USDAUD' => 1.346196
         end
 
         it 'when the API returns an error' do
-          stub_request(:get, 'http://www.apilayer.net/api/live?access_key=[KEY]').to_return body: <<~END
-            {
-                "success": false,
-                "error": {
-                  "code": 104,
-                  "info": "Your monthly usage limit has been reached. Please upgrade your subscription plan."
-                }
-            }
-          END
+          stub_request(:get, 'http://www.apilayer.net/api/live?access_key=[KEY]')
+            .to_return(body: fixture('failure.json'))
+
           expect { subject.fetch_rates }.to raise_error Errors::APIError
         end
+
+        def fixture file
+          File.read("#{__dir__}/fixtures/currency_layer/#{file}")
+        end
       end
 
       context 'update_rates!' do
         it 'fetches the rates and stores them' do
-          expect(subject).to receive(:fetch_rates) { {'USDARS' => 3, 'USDAUD' => 4} }
-          subject.update_rates!
-          expect(subject.rates.size).to eq 2
-          expect(subject.rate('USD', 'ARS')).to eq 3
-          expect(subject.rate('USD', 'AUD')).to eq 4
+          store = double('store')
+          expect(store).to receive(:save_rates).with([{pair: 'USDARS', rate: 3}, {pair: 'USDAUD', rate: 4}])
+
+          exchange = CurrencyLayer.new(access_key: '...', store: store)
+          allow(exchange).to receive(:fetch_rates).and_return('USDARS' => 3, 'USDAUD' => 4)
+          exchange.update_rates!
         end
+      end
+
+      context 'rates' do
+        it 'converts the array from the store back to a map of pair to rates' do
+          store = double('store')
+          expect(store).to receive(:rates).and_return([{pair: 'USDARS', rate: 3}, {pair: 'USDAUD', rate: 4}])
 
-        it 'if a rate already exists should update it' do
-          subject.store.save_rates 'USDARS' => 3
-          expect(subject).to receive(:fetch_rates) { {'USDARS' => 3.1} }
-          subject.update_rates!
-          expect(subject.rate('USD', 'ARS')).to eq 3.1
+          exchange = CurrencyLayer.new(access_key: '...', store: store)
+          expect(exchange.rates).to eq 'USDARS' => 3, 'USDAUD' => 4
         end
       end
     end
   end
-end
+end