currency-rate 0.4.1 → 1.0.0

data/spec/lib/synchronizer_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+
+RSpec.describe CurrencyRate::Synchronizer do
+  before do
+    @storage_double = double("storage")
+    @synchronizer = CurrencyRate::Synchronizer.new(storage: @storage_double)
+  end
+
+  describe "#sync!" do
+    before do
+      @kraken_data = normalized_data_for :kraken
+      @crypto_adapters = ["KrakenAdapter"]
+      allow(CurrencyRate::KrakenAdapter.instance).to receive(:fetch_rates).and_return(@kraken_data)
+      allow(CurrencyRate.configuration).to receive(:crypto_adapters).and_return(@crypto_adapters)
+
+      @yahoo_data = normalized_data_for :yahoo
+      @fiat_adapters = ["YahooAdapter"]
+      allow(CurrencyRate::YahooAdapter.instance).to receive(:fetch_rates).and_return(@yahoo_data)
+      allow(CurrencyRate.configuration).to receive(:fiat_adapters).and_return(@fiat_adapters)
+    end
+
+    it "saves fetched rates to given storage" do
+      expect(@storage_double).to receive(:write).with("kraken", @kraken_data)
+      expect(@storage_double).to receive(:write).with("yahoo", @yahoo_data)
+      @synchronizer.sync!
+    end
+
+    context "when adapter returned nil data" do
+      before do
+        allow(CurrencyRate::KrakenAdapter.instance).to receive(:fetch_rates).and_return(nil)
+        allow(@storage_double).to receive(:write).with("yahoo", @yahoo_data)
+      end
+
+      it "doesn't try to save nil data to the storage" do
+        expect(@storage_double).not_to receive(:write).with("kraken", nil)
+        @synchronizer.sync!
+      end
+
+      it "doesn't throw an exception" do
+        expect { @synchronizer.sync! }.not_to raise_error
+      end
+
+      it "saves other successfully fetched adapters data" do
+        expect(@storage_double).to receive(:write).with("yahoo", @yahoo_data)
+        @synchronizer.sync!
+      end
+    end
+
+    context "when adapter fetching failed with and error" do
+      before do
+        allow(CurrencyRate::KrakenAdapter.instance).to receive(:fetch_rates).and_raise("Error!")
+        allow(@storage_double).to receive(:write).with("yahoo", @yahoo_data)
+      end
+
+      it "catches the exception" do
+        expect { @synchronizer.sync! }.not_to raise_error
+      end
+
+      it "continues fetching other adapters" do
+        expect(@storage_double).to receive(:write).with("yahoo", @yahoo_data)
+        @synchronizer.sync!
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,13 +1,28 @@
+require "yaml"
+require "byebug"
+require "webmock/rspec"
+
 require_relative "../lib/currency_rate"
-require 'webmock/rspec'
-require 'vcr'
 
-VCR.configure do |config|
-  config.cassette_library_dir = 'spec/fixtures/vcr'
-  config.hook_into :webmock
+Dir[File.join CurrencyRate.root, "spec/support/**/*.rb"].each { |f| require f }
+
+def exchange_data_for(name)
+  YAML.load_file File.join(CurrencyRate.root, "spec/fixtures/adapters/#{name}_adapter.yml")
+end
+
+def normalized_data_for(name)
+  floating = YAML.load_file File.join(CurrencyRate.root, "spec/fixtures/adapters/normalized/#{name}_adapter.yml")
+  floating.each { |k, v| floating[k] = BigDecimal.new(v.to_s) if k != "anchor" }
+end
+
+def data_for(name)
+  [exchange_data_for(name), normalized_data_for(name)]
+end
+
+RSpec.configure do |config|
+  config.default_formatter = "doc"
 end
 
-if ENV['VCR_OFF']
-  WebMock.allow_net_connect!
-  VCR.turn_off! ignore_cassettes: true
+CurrencyRate.configure do |config|
+  config.logger[:level] = :fatal
 end

data/spec/support/matchers/eq_any_of.rb

@@ -0,0 +1,3 @@
+RSpec::Matchers.define :eq_any_of do |values|
+  match { |actual| values.include? actual }
+end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: currency-rate
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Roman Snitko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-31 00:00:00.000000000 Z
+date: 2017-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: satoshi-unit
+  name: http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -24,20 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
@@ -81,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: vcr
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -105,60 +91,77 @@ files:
 - ".document"
 - ".rspec"
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
 - VERSION
 - currency-rate.gemspec
 - lib/adapter.rb
-- lib/core_ext/deep_get.rb
-- lib/crypto_adapter.rb
-- lib/crypto_adapters/average_rate_adapter.rb
-- lib/crypto_adapters/bitfinex_adapter.rb
-- lib/crypto_adapters/bitpay_adapter.rb
-- lib/crypto_adapters/bitstamp_adapter.rb
-- lib/crypto_adapters/btcchina_adapter.rb
-- lib/crypto_adapters/btce_adapter.rb
-- lib/crypto_adapters/coinbase_adapter.rb
-- lib/crypto_adapters/huobi_adapter.rb
-- lib/crypto_adapters/kraken_adapter.rb
-- lib/crypto_adapters/localbitcoins_adapter.rb
-- lib/crypto_adapters/okcoin_adapter.rb
+- lib/adapters/crypto/bitfinex_adapter.rb
+- lib/adapters/crypto/bitpay_adapter.rb
+- lib/adapters/crypto/bitstamp_adapter.rb
+- lib/adapters/crypto/btc_china_adapter.rb
+- lib/adapters/crypto/btc_e_adapter.rb
+- lib/adapters/crypto/coinbase_adapter.rb
+- lib/adapters/crypto/huobi_adapter.rb
+- lib/adapters/crypto/kraken_adapter.rb
+- lib/adapters/crypto/localbitcoins_adapter.rb
+- lib/adapters/crypto/okcoin_adapter.rb
+- lib/adapters/fiat/fixer_adapter.rb
+- lib/adapters/fiat/forge_adapter.rb
+- lib/adapters/fiat/yahoo_adapter.rb
+- lib/configuration.rb
 - lib/currency_rate.rb
-- lib/fiat_adapter.rb
-- lib/fiat_adapters/fixer_adapter.rb
-- lib/fiat_adapters/yahoo_adapter.rb
-- lib/storage.rb
-- spec/currency_rate_spec.rb
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/average_rate_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/bitfinex_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/bitpay_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/btcchina_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/btce_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/coinbase_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/huobi_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/kraken_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/localbitcoins_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/okcoin_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/fiat_adapters/fixer_adapter.yml
-- spec/fixtures/vcr/exchange_rate_adapters/fiat_adapters/yahoo_adapter.yml
-- spec/lib/crypto_adapter_spec.rb
-- spec/lib/crypto_adapters/average_rate_adapter_spec.rb
-- spec/lib/crypto_adapters/bitfinex_adapter_spec.rb
-- spec/lib/crypto_adapters/bitpay_adapter_spec.rb
-- spec/lib/crypto_adapters/bitstamp_adapter_spec.rb
-- spec/lib/crypto_adapters/btcchina_adapter_spec.rb
-- spec/lib/crypto_adapters/btce_adapter_spec.rb
-- spec/lib/crypto_adapters/coinbase_adapter_spec.rb
-- spec/lib/crypto_adapters/huobi_adapter_spec.rb
-- spec/lib/crypto_adapters/kraken_adapter_spec.rb
-- spec/lib/crypto_adapters/localbitcoins_adapter_spec.rb
-- spec/lib/crypto_adapters/okcoin_adapter_spec.rb
-- spec/lib/fiat_adapters/fixer_adapter_spec.rb
-- spec/lib/fiat_adapters/yahoo_adapter_spec.rb
-- spec/lib/storage_spec.rb
+- lib/fetcher.rb
+- lib/storage/file_storage.rb
+- lib/storage/serializers/yaml_serializer.rb
+- lib/synchronizer.rb
+- spec/fixtures/adapters/bitfinex_adapter.yml
+- spec/fixtures/adapters/bitpay_adapter.yml
+- spec/fixtures/adapters/bitstamp_adapter.yml
+- spec/fixtures/adapters/btc_china_adapter.yml
+- spec/fixtures/adapters/btce_adapter.yml
+- spec/fixtures/adapters/coinbase_adapter.yml
+- spec/fixtures/adapters/fixer_adapter.yml
+- spec/fixtures/adapters/forge_adapter.yml
+- spec/fixtures/adapters/huobi_adapter.yml
+- spec/fixtures/adapters/kraken_adapter.yml
+- spec/fixtures/adapters/localbitcoins_adapter.yml
+- spec/fixtures/adapters/normalized/bitfinex_adapter.yml
+- spec/fixtures/adapters/normalized/bitpay_adapter.yml
+- spec/fixtures/adapters/normalized/bitstamp_adapter.yml
+- spec/fixtures/adapters/normalized/btc_china_adapter.yml
+- spec/fixtures/adapters/normalized/btce_adapter.yml
+- spec/fixtures/adapters/normalized/coinbase_adapter.yml
+- spec/fixtures/adapters/normalized/fixer_adapter.yml
+- spec/fixtures/adapters/normalized/forge_adapter.yml
+- spec/fixtures/adapters/normalized/huobi_adapter.yml
+- spec/fixtures/adapters/normalized/kraken_adapter.yml
+- spec/fixtures/adapters/normalized/localbitcoins_adapter.yml
+- spec/fixtures/adapters/normalized/okcoin_adapter.yml
+- spec/fixtures/adapters/normalized/yahoo_adapter.yml
+- spec/fixtures/adapters/okcoin_adapter.yml
+- spec/fixtures/adapters/yahoo_adapter.yml
+- spec/lib/adapter_spec.rb
+- spec/lib/adapters/crypto/bitfinex_adapter_spec.rb
+- spec/lib/adapters/crypto/bitpay_adapter_spec.rb
+- spec/lib/adapters/crypto/bitstamp_adapter_spec.rb
+- spec/lib/adapters/crypto/btc_china_adapter_spec.rb
+- spec/lib/adapters/crypto/btc_e_adapter_spec.rb
+- spec/lib/adapters/crypto/coinbase_adapter_spec.rb
+- spec/lib/adapters/crypto/huobi_adapter_spec.rb
+- spec/lib/adapters/crypto/kraken_adapter_spec.rb
+- spec/lib/adapters/crypto/localbitcoins_adapter_spec.rb
+- spec/lib/adapters/crypto/okcoin_adapter_spec.rb
+- spec/lib/adapters/fiat/fixer_adapter_spec.rb
+- spec/lib/adapters/fiat/forge_adapter_spec.rb
+- spec/lib/adapters/fiat/yahoo_adapter_spec.rb
+- spec/lib/currency_rate_spec.rb
+- spec/lib/fetcher_spec.rb
+- spec/lib/storage/file_storage_spec.rb
+- spec/lib/synchronizer_spec.rb
 - spec/spec_helper.rb
+- spec/support/matchers/eq_any_of.rb
 homepage: http://github.com/snitko/currency-rate
 licenses:
 - MIT

data/Gemfile.lock

@@ -1,93 +0,0 @@
-GIT
-  remote: git@github.com:technicalpickles/jeweler.git
-  revision: afab16b95fbac811f3ab233e058d39eb4e300284
-  specs:
-    jeweler (2.3.7)
-      builder
-      bundler (>= 1)
-      git (>= 1.2.5)
-      github_api (~> 0.16.0)
-      highline (>= 1.6.15)
-      nokogiri (>= 1.5.10)
-      psych (~> 2.2)
-      rake
-      rdoc
-      semver2
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    addressable (2.4.0)
-    builder (3.2.3)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    descendants_tracker (0.0.4)
-      thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.2.5)
-    faraday (0.9.2)
-      multipart-post (>= 1.2, < 3)
-    git (1.3.0)
-    github_api (0.16.0)
-      addressable (~> 2.4.0)
-      descendants_tracker (~> 0.0.4)
-      faraday (~> 0.8, < 0.10)
-      hashie (>= 3.4)
-      mime-types (>= 1.16, < 3.0)
-      oauth2 (~> 1.0)
-    hashdiff (0.3.0)
-    hashie (3.5.5)
-    highline (1.7.8)
-    jwt (1.5.6)
-    mime-types (2.99.3)
-    mini_portile2 (2.2.0)
-    multi_json (1.12.1)
-    multi_xml (0.6.0)
-    multipart-post (2.0.0)
-    nokogiri (1.8.0)
-      mini_portile2 (~> 2.2.0)
-    oauth2 (1.4.0)
-      faraday (>= 0.8, < 0.13)
-      jwt (~> 1.0)
-      multi_json (~> 1.3)
-      multi_xml (~> 0.5)
-      rack (>= 1.2, < 3)
-    psych (2.2.4)
-    rack (2.0.3)
-    rake (12.0.0)
-    rdoc (5.1.0)
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.4)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
-    safe_yaml (1.0.4)
-    satoshi-unit (0.1.8)
-    semver2 (3.4.2)
-    thread_safe (0.3.6)
-    vcr (3.0.3)
-    webmock (2.0.3)
-      addressable (>= 2.3.6)
-      crack (>= 0.3.2)
-      hashdiff
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (~> 1.0)
-  jeweler (~> 2.3.7)!
-  rspec
-  satoshi-unit
-  vcr
-  webmock
-
-BUNDLED WITH
-   1.15.1

data/lib/core_ext/deep_get.rb

@@ -1,11 +0,0 @@
-class Hash
-  def deep_get(*args)
-    args.inject(self) do |intermediate, key|
-      if intermediate.respond_to?(:[])
-        intermediate[key]
-      else
-        return nil
-      end
-    end
-  end
-end

data/lib/crypto_adapter.rb

@@ -1,19 +0,0 @@
-module CurrencyRate
-
-  class CryptoAdapter < Adapter
-
-    SUPPORTED_CRYPTO_CURRENCIES = []
-
-    DECIMAL_PRECISION = 9
-
-    def rate_for(from,to)
-      super
-    end
-
-    def invert_rate(from,to,rate)
-      self.class::SUPPORTED_CRYPTO_CURRENCIES.include?(to) ? _invert_rate(rate) : rate
-    end
-
-  end
-
-end

data/lib/crypto_adapters/average_rate_adapter.rb

@@ -1,54 +0,0 @@
-module CurrencyRate
-  class AverageRateAdapter < CryptoAdapter
-
-    DEFAULT_CURRENCIES = ["USD", "BTC"]
-    SUPPORTED_CRYPTO_CURRENCIES = ["BTC"]
-
-    # Takes exchange rate adapters instances or classes as arguments
-    def self.instance(*adapters)
-      instance = super()
-      instance.instance_variable_set(:@adapters, adapters.map { |adapter| adapter.respond_to?(:instance) ? adapter.instance : adapter })
-      instance
-    end
-
-    def fetch_rates!
-      failed_fetches = 0
-      @adapters.each do |adapter|
-        begin
-          adapter.fetch_rates!
-        rescue FetchingFailed => e
-          failed_fetches += 1
-          raise e if failed_fetches == @adapters.size
-        end
-      end
-    end
-
-    def rate_for(from, to)
-      rates = []
-      @adapters.each do |adapter|
-        begin
-          rates << adapter.rate_for(from,to)
-        rescue CurrencyNotSupported
-          rates << nil
-        end
-      end
-
-      unless rates.select(&:nil?).size == @adapters.size
-        rates.compact!
-        rate = rates.inject {|sum, rate| sum + rate} / rates.size
-        invert_rate(from,to, rate)
-      else
-        raise CurrencyNotSupported
-      end
-    end
-
-    def get_rate_value_from_hash(rates_hash, *keys)
-      raise "This method is not supposed to be used in #{self.class}."
-    end
-
-    def rate_to_f(rate)
-      raise "This method is not supposed to be used in #{self.class}."
-    end
-
-  end
-end