cuke_linter 0.9.0 → 0.10.0

data/testing/rspec/spec/unit/linters/test_with_setup_step_as_final_step_linter_unit_spec.rb

@@ -0,0 +1,98 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::TestWithSetupStepAsFinalStepLinter do
+
+  let(:model_file_path) { 'some_file_path' }
+
+  it_should_behave_like 'a linter at the unit level'
+
+
+  it 'has a name' do
+    expect(subject.name).to eq('TestWithSetupStepAsFinalStepLinter')
+  end
+
+  describe 'linting' do
+
+    ['scenario', 'outline'].each do |model_type|
+
+      context "with a #{model_type} that has a setup step as its final step" do
+
+        let(:test_model) do
+          model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
+          model.steps = [CukeModeler::Step.new('When a step'),
+                         CukeModeler::Step.new('Given a step')]
+
+          model
+        end
+
+        it_should_behave_like 'a linter linting a bad model'
+
+
+        it 'records a problem' do
+          result = subject.lint(test_model)
+
+          expect(result[:problem]).to eq("Test has 'Given' as the final step.")
+        end
+
+      end
+
+      context "with a #{model_type} that does not have a setup step as its final step" do
+
+        context 'because it has no steps' do
+
+          context 'because its steps are empty' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+              model.steps = []
+
+              model
+            end
+
+            it_should_behave_like 'a linter linting a good model'
+
+          end
+
+          context 'because its steps are nil' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+              model.steps = nil
+
+              model
+            end
+
+            it_should_behave_like 'a linter linting a good model'
+
+          end
+
+        end
+
+        context 'because its final step is not a setup step' do
+
+          let(:test_model) do
+            model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+            model.steps = [CukeModeler::Step.new('Then a step')]
+
+            model
+          end
+
+          it_should_behave_like 'a linter linting a good model'
+
+        end
+
+      end
+
+    end
+
+
+    context 'a non-test model' do
+
+      let(:test_model) { CukeModeler::Model.new }
+
+      it_should_behave_like 'a linter linting a good model'
+
+    end
+  end
+end

data/testing/rspec/spec/unit/linters/test_with_too_many_steps_linter_unit_spec.rb

@@ -3,30 +3,7 @@ require_relative '../../../../../environments/rspec_env'
 
 RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
 
-  let(:good_data) do
-    model       = CukeLinter::ModelFactory.generate_scenario_model
-    model.steps = [:step_1]
-
-    model
-  end
-
-  let(:bad_data) do
-    model       = CukeLinter::ModelFactory.generate_scenario_model
-    model.steps = [:step_1,
-                   :step_2,
-                   :step_3,
-                   :step_4,
-                   :step_5,
-                   :step_6,
-                   :step_7,
-                   :step_8,
-                   :step_9,
-                   :step_10,
-                   :step_11]
-
-    model
-  end
-
+  let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
   it_should_behave_like 'a configurable linter at the unit level'
@@ -43,7 +20,7 @@ RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
       context "with a #{model_type} that has too many steps" do
 
         let(:test_model) do
-          model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+          model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
           model.steps = [:step_1,
                          :step_2,
                          :step_3,
@@ -59,22 +36,15 @@ RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
           model
         end
 
+        it_should_behave_like 'a linter linting a bad model'
+
+
         it 'records a problem' do
           result = subject.lint(test_model)
 
           expect(result[:problem]).to match(/^Test has too many steps. \d+ steps found \(max 10\)/)
         end
 
-        it 'records the location of the problem' do
-          test_model.source_line = 1
-          result                 = subject.lint(test_model)
-          expect(result[:location]).to eq('path_to_file:1')
-
-          test_model.source_line = 3
-          result                 = subject.lint(test_model)
-          expect(result[:location]).to eq('path_to_file:3')
-        end
-
         it 'includes the number of steps found in the problem record' do
           step_count = test_model.steps.count
           result     = subject.lint(test_model)
@@ -98,9 +68,7 @@ RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
             model
           end
 
-          it 'does not record a problem' do
-            expect(subject.lint(test_model)).to eq(nil)
-          end
+          it_should_behave_like 'a linter linting a good model'
 
         end
 
@@ -115,9 +83,7 @@ RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
               model
             end
 
-            it 'does not record a problem' do
-              expect(subject.lint(test_model)).to eq(nil)
-            end
+            it_should_behave_like 'a linter linting a good model'
 
           end
 
@@ -130,9 +96,7 @@ RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
               model
             end
 
-            it 'does not record a problem' do
-              expect(subject.lint(test_model)).to eq(nil)
-            end
+            it_should_behave_like 'a linter linting a good model'
 
           end
 
@@ -221,11 +185,7 @@ RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
 
       let(:test_model) { CukeModeler::Model.new }
 
-      it 'returns no result' do
-        result = subject.lint(test_model)
-
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_linter
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-09-12 00:00:00.000000000 Z
+date: 2019-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cuke_modeler
@@ -162,6 +162,7 @@ files:
 - ".simplecov"
 - ".travis.yml"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -179,6 +180,7 @@ files:
 - lib/cuke_linter/linters/background_does_more_than_setup_linter.rb
 - lib/cuke_linter/linters/element_with_too_many_tags_linter.rb
 - lib/cuke_linter/linters/example_without_name_linter.rb
+- lib/cuke_linter/linters/feature_with_too_many_different_tags_linter.rb
 - lib/cuke_linter/linters/feature_without_description_linter.rb
 - lib/cuke_linter/linters/feature_without_name_linter.rb
 - lib/cuke_linter/linters/feature_without_scenarios_linter.rb
@@ -187,9 +189,14 @@ files:
 - lib/cuke_linter/linters/single_test_background_linter.rb
 - lib/cuke_linter/linters/step_with_end_period_linter.rb
 - lib/cuke_linter/linters/step_with_too_many_characters_linter.rb
+- lib/cuke_linter/linters/test_should_use_background_linter.rb
+- lib/cuke_linter/linters/test_with_action_step_as_final_step_linter.rb
 - lib/cuke_linter/linters/test_with_no_action_step_linter.rb
 - lib/cuke_linter/linters/test_with_no_name_linter.rb
 - lib/cuke_linter/linters/test_with_no_verification_step_linter.rb
+- lib/cuke_linter/linters/test_with_setup_step_after_action_step_linter.rb
+- lib/cuke_linter/linters/test_with_setup_step_after_verification_step_linter.rb
+- lib/cuke_linter/linters/test_with_setup_step_as_final_step_linter.rb
 - lib/cuke_linter/linters/test_with_too_many_steps_linter.rb
 - lib/cuke_linter/version.rb
 - testing/cucumber/features/command_line.feature
@@ -202,6 +209,7 @@ files:
 - testing/cucumber/features/linters/background_does_more_than_setup.feature
 - testing/cucumber/features/linters/element_with_too_many_tags.feature
 - testing/cucumber/features/linters/example_without_name.feature
+- testing/cucumber/features/linters/feature_with_too_many_different_tags.feature
 - testing/cucumber/features/linters/feature_without_description.feature
 - testing/cucumber/features/linters/feature_without_name.feature
 - testing/cucumber/features/linters/feature_without_scenarios.feature
@@ -209,9 +217,14 @@ files:
 - testing/cucumber/features/linters/single_test_background.feature
 - testing/cucumber/features/linters/step_too_long.feature
 - testing/cucumber/features/linters/step_with_end_period.feature
+- testing/cucumber/features/linters/test_should_use_background.feature
+- testing/cucumber/features/linters/test_with_action_as_final_step.feature
 - testing/cucumber/features/linters/test_with_no_action_step.feature
 - testing/cucumber/features/linters/test_with_no_name.feature
 - testing/cucumber/features/linters/test_with_no_verification_step.feature
+- testing/cucumber/features/linters/test_with_setup_step_after_action_step.feature
+- testing/cucumber/features/linters/test_with_setup_step_after_verification_step.feature
+- testing/cucumber/features/linters/test_with_setup_step_as_final_step.feature
 - testing/cucumber/features/linters/test_with_too_many_steps.feature
 - testing/cucumber/step_definitions/action_steps.rb
 - testing/cucumber/step_definitions/setup_steps.rb
@@ -228,6 +241,7 @@ files:
 - testing/rspec/spec/integration/linters/background_does_more_than_setup_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/element_with_too_many_tags_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/example_without_name_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/feature_with_too_many_different_tags_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_without_description_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_without_name_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_without_scenarios_linter_integration_spec.rb
@@ -237,9 +251,14 @@ files:
 - testing/rspec/spec/integration/linters/single_test_background_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/step_with_end_period_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/step_with_too_many_characters_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_should_use_background_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_action_step_as_final_step_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_no_action_step_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_no_name_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_no_verification_step_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_setup_step_after_action_step_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_setup_step_after_verification_step_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_setup_step_as_final_step_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_too_many_steps_linter_integration_spec.rb
 - testing/rspec/spec/unit/cuke_linter_unit_spec.rb
 - testing/rspec/spec/unit/formatters/formatter_unit_specs.rb
@@ -248,6 +267,7 @@ files:
 - testing/rspec/spec/unit/linters/configurable_linter_unit_specs.rb
 - testing/rspec/spec/unit/linters/element_with_too_many_tags_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/example_without_name_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/feature_with_too_many_different_tags_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_without_description_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_without_name_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_without_scenarios_linter_unit_spec.rb
@@ -257,9 +277,14 @@ files:
 - testing/rspec/spec/unit/linters/single_test_background_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/step_with_end_period_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/step_with_too_many_characters_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_should_use_background_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_action_step_as_final_step_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_no_action_step_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_no_name_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_no_verification_step_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_setup_step_after_action_step_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_setup_step_after_verification_step_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_setup_step_as_final_step_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_too_many_steps_linter_unit_spec.rb
 homepage: https://github.com/enkessler/cuke_linter
 licenses: