cuke_linter 0.9.0 → 0.10.0

data/testing/rspec/spec/unit/linters/outline_with_single_example_row_linter_unit_spec.rb

@@ -3,27 +3,7 @@ require_relative '../../../../../environments/rspec_env'
 
 RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
 
-  let(:good_data) do
-    outline_text = 'Scenario Outline:
-                      * a step
-                    Examples:
-                      | param   |
-                      | value 1 |
-                      | value 2 |'
-
-    CukeLinter::ModelFactory.generate_outline_model(source_text: outline_text)
-  end
-
-  let(:bad_data) do
-    outline_text = 'Scenario Outline:
-                      * a step
-                    Examples:
-                      | param   |
-                      | value 1 |'
-
-    CukeLinter::ModelFactory.generate_outline_model(source_text: outline_text)
-  end
-
+  let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
 
@@ -45,9 +25,13 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
                        | param |
                        | value |'
 
-          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
+          CukeLinter::ModelFactory.generate_outline_model(parent_file_path: model_file_path,
+                                                          source_text:      gherkin)
         end
 
+        it_should_behave_like 'a linter linting a bad model'
+
+
         it 'records a problem' do
           result = subject.lint(test_model)
 
@@ -67,9 +51,13 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
                        | param |
                        | value |'
 
-          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
+          CukeLinter::ModelFactory.generate_outline_model(parent_file_path: model_file_path,
+                                                          source_text:      gherkin)
         end
 
+        it_should_behave_like 'a linter linting a bad model'
+
+
         it 'records a problem' do
           result = subject.lint(test_model)
 
@@ -78,27 +66,6 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
 
       end
 
-
-      it 'records the location of the problem' do
-        gherkin = 'Scenario Outline:
-                     * a step
-                   Examples:
-                     | param |
-                     | value |'
-
-        model_1 = CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin, parent_file_path: 'path_to_file')
-        model_2 = CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin, parent_file_path: 'path_to_file')
-
-        model_1.source_line = 1
-        model_2.source_line = 3
-
-        result = subject.lint(model_1)
-        expect(result[:location]).to eq('path_to_file:1')
-
-        result = subject.lint(model_2)
-        expect(result[:location]).to eq('path_to_file:3')
-      end
-
     end
 
     context 'an outline with more than one example row' do
@@ -116,9 +83,7 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
           CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
         end
 
-        it 'does not record a problem' do
-          expect(subject.lint(test_model)).to eq(nil)
-        end
+        it_should_behave_like 'a linter linting a good model'
 
       end
 
@@ -137,9 +102,7 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
           CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
         end
 
-        it 'does not record a problem' do
-          expect(subject.lint(test_model)).to eq(nil)
-        end
+        it_should_behave_like 'a linter linting a good model'
 
       end
 
@@ -158,9 +121,7 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
             model
           end
 
-          it 'does not record a problem' do
-            expect(subject.lint(test_model)).to eq(nil)
-          end
+          it_should_behave_like 'a linter linting a good model'
 
         end
 
@@ -172,9 +133,7 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
             model
           end
 
-          it 'does not record a problem' do
-            expect(subject.lint(test_model)).to eq(nil)
-          end
+          it_should_behave_like 'a linter linting a good model'
 
         end
 
@@ -191,9 +150,7 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
           CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
         end
 
-        it 'does not record a problem' do
-          expect(subject.lint(test_model)).to eq(nil)
-        end
+        it_should_behave_like 'a linter linting a good model'
 
       end
 
@@ -210,9 +167,7 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
           CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
         end
 
-        it 'does not record a problem' do
-          expect(subject.lint(test_model)).to eq(nil)
-        end
+        it_should_behave_like 'a linter linting a good model'
 
       end
 
@@ -220,11 +175,9 @@ RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
 
     context 'a non-outline model' do
 
-      it 'returns no result' do
-        result = subject.lint(CukeModeler::Model.new)
+      let(:test_model) { CukeModeler::Model.new }
 
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
   end

data/testing/rspec/spec/unit/linters/single_test_background_linter_unit_spec.rb

@@ -3,21 +3,7 @@ require_relative '../../../../../environments/rspec_env'
 
 RSpec.describe CukeLinter::SingleTestBackgroundLinter do
 
-  let(:good_data) do
-    CukeLinter::ModelFactory.generate_feature_model(source_text: 'Feature:
-                                                                    Background:
-                                                                      * a step
-                                                                    Scenario:
-                                                                    Scenario:').background
-  end
-
-  let(:bad_data) do
-    CukeLinter::ModelFactory.generate_feature_model(source_text: 'Feature:
-                                                                    Background:
-                                                                      * a step
-                                                                    Scenario:').background
-  end
-
+  let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
 
@@ -35,9 +21,10 @@ RSpec.describe CukeLinter::SingleTestBackgroundLinter do
         context "and that test is a #{model_type}" do
 
           let(:test_model) do
-            background_model = CukeLinter::ModelFactory.generate_feature_model(source_text: 'Feature:
-                                                                                               Background:
-                                                                                                 * a step').background
+            background_model = CukeLinter::ModelFactory.generate_feature_model(parent_file_path: model_file_path,
+                                                                               source_text:      'Feature:
+                                                                                                    Background:
+                                                                                                      * a step').background
 
             background_model.parent_model.tests.clear
             background_model.parent_model.tests << CukeLinter::ModelFactory.send("generate_#{model_type}_model")
@@ -45,22 +32,15 @@ RSpec.describe CukeLinter::SingleTestBackgroundLinter do
             background_model
           end
 
+          it_should_behave_like 'a linter linting a bad model'
+
+
           it 'records a problem' do
             result = subject.lint(test_model)
 
             expect(result[:problem]).to match('Background used with only one test')
           end
 
-          it 'records the location of the problem' do
-            test_model.source_line = 1
-            result                 = subject.lint(test_model)
-            expect(result[:location]).to eq('path_to_file:1')
-
-            test_model.source_line = 3
-            result                 = subject.lint(test_model)
-            expect(result[:location]).to eq('path_to_file:3')
-          end
-
         end
 
       end
@@ -81,9 +61,7 @@ RSpec.describe CukeLinter::SingleTestBackgroundLinter do
                                                                           |value|').background
       end
 
-      it 'does not record a problem' do
-        expect(subject.lint(test_model)).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
 
@@ -95,9 +73,7 @@ RSpec.describe CukeLinter::SingleTestBackgroundLinter do
                                                                           * a step').background
       end
 
-      it 'does not record a problem' do
-        expect(subject.lint(test_model)).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
 
@@ -105,12 +81,9 @@ RSpec.describe CukeLinter::SingleTestBackgroundLinter do
 
       let(:test_model) { CukeModeler::Model.new }
 
-      it 'returns no result' do
-        result = subject.lint(test_model)
-
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
+
   end
 end

data/testing/rspec/spec/unit/linters/step_with_end_period_linter_unit_spec.rb

@@ -3,14 +3,7 @@ require_relative '../../../../../environments/rspec_env'
 
 RSpec.describe CukeLinter::StepWithEndPeriodLinter do
 
-  let(:good_data) do
-    CukeLinter::ModelFactory.generate_step_model(source_text: '* without a period')
-  end
-
-  let(:bad_data) do
-    CukeLinter::ModelFactory.generate_step_model(source_text: '* with a period.')
-  end
-
+  let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
 
@@ -24,37 +17,28 @@ RSpec.describe CukeLinter::StepWithEndPeriodLinter do
     context "with a step that ends with a period" do
 
       let(:test_model) do
-        CukeLinter::ModelFactory.generate_step_model(source_text: '* with a period.')
+        CukeLinter::ModelFactory.generate_step_model(parent_file_path: model_file_path,
+                                                     source_text:      '* with a period.')
       end
 
+      it_should_behave_like 'a linter linting a bad model'
+
+
       it 'records a problem' do
         result = subject.lint(test_model)
 
         expect(result[:problem]).to match('Step ends with a period')
       end
 
-      it 'records the location of the problem' do
-        test_model.source_line = 1
-        result                 = subject.lint(test_model)
-        expect(result[:location]).to eq('path_to_file:1')
-
-        test_model.source_line = 3
-        result                 = subject.lint(test_model)
-        expect(result[:location]).to eq('path_to_file:3')
-      end
-
     end
 
     context "with a step that does not end with a period" do
 
-
       let(:test_model) do
         CukeLinter::ModelFactory.generate_step_model(source_text: '* without a period')
       end
 
-      it 'does not record a problem' do
-        expect(subject.lint(test_model)).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
 
@@ -62,12 +46,9 @@ RSpec.describe CukeLinter::StepWithEndPeriodLinter do
 
       let(:test_model) { CukeModeler::Model.new }
 
-      it 'returns no result' do
-        result = subject.lint(test_model)
-
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
+
   end
 end

data/testing/rspec/spec/unit/linters/step_with_too_many_characters_linter_unit_spec.rb

@@ -3,18 +3,7 @@ require_relative '../../../../../environments/rspec_env'
 
 RSpec.describe CukeLinter::StepWithTooManyCharactersLinter do
 
-  let(:good_data) do
-    CukeLinter::ModelFactory.generate_step_model(source_text: '* a short step')
-  end
-
-  let(:bad_data) do
-    long_step = <<~EOL.delete("\n")
-      * this is a very long string which will violate the linter 
-      rule which expects step rules to have fewer than one hundred 
-      and twenty characters
-    EOL
-    CukeLinter::ModelFactory.generate_step_model(source_text: long_step)
-  end
+  let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
   it_should_behave_like 'a configurable linter at the unit level'
@@ -30,30 +19,28 @@ RSpec.describe CukeLinter::StepWithTooManyCharactersLinter do
 
     context 'when the step is too long' do
 
-      let(:step_too_long_model) do
+      let(:test_model) do
         step = 'x' * (default_character_threshold + 1)
-        CukeLinter::ModelFactory.generate_step_model(source_text: "* #{step}")
+        CukeLinter::ModelFactory.generate_step_model(parent_file_path: model_file_path,
+                                                     source_text:      "* #{step}")
       end
 
-      it 'reports a problem' do
-        result = subject.lint(step_too_long_model)
+      it_should_behave_like 'a linter linting a bad model'
 
-        expect(result[:problem]).to match(/^Step is too long. \d+ characters found \(max 80\)/)
-      end
 
-      it 'records the location of the problem' do
-        result = subject.lint(step_too_long_model)
+      it 'reports a problem' do
+        result = subject.lint(test_model)
 
-        expect(result[:location]).to eq('path_to_file:4')
+        expect(result[:problem]).to match(/^Step is too long. \d+ characters found \(max 80\)/)
       end
 
       it 'includes the number of characters found in the problem record' do
-        character_count = step_too_long_model.text.length
-        result          = subject.lint(step_too_long_model)
+        character_count = test_model.text.length
+        result          = subject.lint(test_model)
         expect(result[:problem]).to eq("Step is too long. #{character_count} characters found (max 80)")
 
-        step_too_long_model.text += 'x'
-        result                   = subject.lint(step_too_long_model)
+        test_model.text += 'x'
+        result          = subject.lint(test_model)
         expect(result[:problem]).to eq("Step is too long. #{character_count + 1} characters found (max 80)")
       end
 
@@ -61,45 +48,36 @@ RSpec.describe CukeLinter::StepWithTooManyCharactersLinter do
 
     context 'when the step is the maximum length' do
 
-      let(:step_mex_length_model) do
+      let(:test_model) do
         step = 'x' * default_character_threshold
         CukeLinter::ModelFactory.generate_step_model(source_text: "* #{step}")
       end
 
-      it 'does not record a problem' do
-        result = subject.lint(step_mex_length_model)
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
 
     context 'when the step is below the maximum length' do
 
-      let(:step_below_length_model) do
+      let(:test_model) do
         step = 'x' * (default_character_threshold - 1)
         CukeLinter::ModelFactory.generate_step_model(source_text: "* #{step}")
       end
 
-      it 'does not record a problem' do
-        result = subject.lint(step_below_length_model)
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
 
     context 'when the step has no text' do
 
-      let(:step_with_nil_text_model) do
+      let(:test_model) do
         model      = CukeLinter::ModelFactory.generate_step_model
         model.text = nil
 
         model
       end
 
-      it 'does not record a problem' do
-        result = subject.lint(step_with_nil_text_model)
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
 
@@ -107,11 +85,7 @@ RSpec.describe CukeLinter::StepWithTooManyCharactersLinter do
 
       let(:test_model) { CukeModeler::Model.new }
 
-      it 'returns no result' do
-        result = subject.lint(test_model)
-
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end