cuke_linter 0.9.0 → 0.10.0

data/testing/rspec/spec/unit/linters/test_with_no_name_linter_unit_spec.rb

@@ -3,14 +3,7 @@ require_relative '../../../../../environments/rspec_env'
 
 RSpec.describe CukeLinter::TestWithNoNameLinter do
 
-  let(:good_data) do
-    CukeLinter::ModelFactory.generate_scenario_model(source_text: 'Scenario: some name')
-  end
-
-  let(:bad_data) do
-    CukeLinter::ModelFactory.generate_scenario_model(source_text: 'Scenario:')
-  end
-
+  let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
 
@@ -28,55 +21,41 @@ RSpec.describe CukeLinter::TestWithNoNameLinter do
         context 'because its name is empty' do
 
           let(:test_model) do
-            model      = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+            model      = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
             model.name = ''
 
             model
           end
 
+          it_should_behave_like 'a linter linting a bad model'
+
+
           it 'records a problem' do
             result = subject.lint(test_model)
 
             expect(result[:problem]).to eq('Test does not have a name.')
           end
 
-          it 'records the location of the problem' do
-            test_model.source_line = 1
-            result                 = subject.lint(test_model)
-            expect(result[:location]).to eq('path_to_file:1')
-
-            test_model.source_line = 3
-            result                 = subject.lint(test_model)
-            expect(result[:location]).to eq('path_to_file:3')
-          end
-
         end
 
         context 'because its name is nil' do
 
           let(:test_model) do
-            model      = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+            model      = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
             model.name = nil
 
             model
           end
 
+          it_should_behave_like 'a linter linting a bad model'
+
+
           it 'records a problem' do
             result = subject.lint(test_model)
 
             expect(result[:problem]).to eq('Test does not have a name.')
           end
 
-          it 'records the location of the problem' do
-            test_model.source_line = 1
-            result                 = subject.lint(test_model)
-            expect(result[:location]).to eq('path_to_file:1')
-
-            test_model.source_line = 3
-            result                 = subject.lint(test_model)
-            expect(result[:location]).to eq('path_to_file:3')
-          end
-
         end
 
       end
@@ -90,9 +69,7 @@ RSpec.describe CukeLinter::TestWithNoNameLinter do
           model
         end
 
-        it 'does not record a problem' do
-          expect(subject.lint(test_model)).to eq(nil)
-        end
+        it_should_behave_like 'a linter linting a good model'
 
       end
 
@@ -102,11 +79,7 @@ RSpec.describe CukeLinter::TestWithNoNameLinter do
 
       let(:test_model) { CukeModeler::Model.new }
 
-      it 'returns no result' do
-        result = subject.lint(test_model)
-
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
 

data/testing/rspec/spec/unit/linters/test_with_no_verification_step_linter_unit_spec.rb

@@ -3,16 +3,7 @@ require_relative '../../../../../environments/rspec_env'
 
 RSpec.describe CukeLinter::TestWithNoVerificationStepLinter do
 
-  let(:good_data) do
-    CukeLinter::ModelFactory.generate_scenario_model(source_text: 'Scenario:
-                                                                     Then a verification step')
-  end
-
-  let(:bad_data) do
-    CukeLinter::ModelFactory.generate_scenario_model(source_text: 'Scenario:
-                                                                     * no verification step')
-  end
-
+  let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
 
@@ -32,55 +23,41 @@ RSpec.describe CukeLinter::TestWithNoVerificationStepLinter do
           context 'because its steps are empty' do
 
             let(:test_model) do
-              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
               model.steps = []
 
               model
             end
 
+            it_should_behave_like 'a linter linting a bad model'
+
+
             it 'records a problem' do
               result = subject.lint(test_model)
 
               expect(result[:problem]).to eq("Test does not have a 'Then' step.")
             end
 
-            it 'records the location of the problem' do
-              test_model.source_line = 1
-              result                 = subject.lint(test_model)
-              expect(result[:location]).to eq('path_to_file:1')
-
-              test_model.source_line = 3
-              result                 = subject.lint(test_model)
-              expect(result[:location]).to eq('path_to_file:3')
-            end
-
           end
 
           context 'because its steps are nil' do
 
             let(:test_model) do
-              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
               model.steps = nil
 
               model
             end
 
+            it_should_behave_like 'a linter linting a bad model'
+
+
             it 'records a problem' do
               result = subject.lint(test_model)
 
               expect(result[:problem]).to eq("Test does not have a 'Then' step.")
             end
 
-            it 'records the location of the problem' do
-              test_model.source_line = 1
-              result                 = subject.lint(test_model)
-              expect(result[:location]).to eq('path_to_file:1')
-
-              test_model.source_line = 3
-              result                 = subject.lint(test_model)
-              expect(result[:location]).to eq('path_to_file:3')
-            end
-
           end
 
         end
@@ -88,28 +65,21 @@ RSpec.describe CukeLinter::TestWithNoVerificationStepLinter do
         context 'because none of its steps is a verification step' do
 
           let(:test_model) do
-            model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+            model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
             model.steps = [CukeModeler::Step.new('* not a verification step')]
 
             model
           end
 
+          it_should_behave_like 'a linter linting a bad model'
+
+
           it 'records a problem' do
             result = subject.lint(test_model)
 
             expect(result[:problem]).to eq("Test does not have a 'Then' step.")
           end
 
-          it 'records the location of the problem' do
-            test_model.source_line = 1
-            result                 = subject.lint(test_model)
-            expect(result[:location]).to eq('path_to_file:1')
-
-            test_model.source_line = 3
-            result                 = subject.lint(test_model)
-            expect(result[:location]).to eq('path_to_file:3')
-          end
-
         end
 
       end
@@ -128,9 +98,7 @@ RSpec.describe CukeLinter::TestWithNoVerificationStepLinter do
             model
           end
 
-          it 'does not record a problem' do
-            expect(subject.lint(test_model)).to eq(nil)
-          end
+          it_should_behave_like 'a linter linting a good model'
 
         end
 
@@ -143,9 +111,7 @@ RSpec.describe CukeLinter::TestWithNoVerificationStepLinter do
             model
           end
 
-          it 'does not record a problem' do
-            expect(subject.lint(test_model)).to eq(nil)
-          end
+          it_should_behave_like 'a linter linting a good model'
 
         end
 
@@ -206,11 +172,7 @@ RSpec.describe CukeLinter::TestWithNoVerificationStepLinter do
 
       let(:test_model) { CukeModeler::Model.new }
 
-      it 'returns no result' do
-        result = subject.lint(test_model)
-
-        expect(result).to eq(nil)
-      end
+      it_should_behave_like 'a linter linting a good model'
 
     end
   end

data/testing/rspec/spec/unit/linters/test_with_setup_step_after_action_step_linter_unit_spec.rb

@@ -0,0 +1,124 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::TestWithSetupStepAfterActionStepLinter do
+
+  let(:model_file_path) { 'some_file_path' }
+
+  it_should_behave_like 'a linter at the unit level'
+
+
+  it 'has a name' do
+    expect(subject.name).to eq('TestWithSetupStepAfterActionStepLinter')
+  end
+
+  describe 'linting' do
+
+    ['scenario', 'outline'].each do |model_type|
+
+      context "with a #{model_type} that has a setup step after an action step" do
+
+        let(:test_model) do
+          model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model",
+                                                      parent_file_path: model_file_path)
+          model.steps = [CukeModeler::Step.new('When a step'),
+                         CukeModeler::Step.new('Given a step')]
+
+          model
+        end
+
+        it_should_behave_like 'a linter linting a bad model'
+
+
+        it 'records a problem' do
+          result = subject.lint(test_model)
+
+          expect(result[:problem]).to eq("Test has 'Given' step after 'When' step.")
+        end
+
+      end
+
+      context "with a #{model_type} that does not have a setup step after an action step" do
+
+        context 'because it has no steps' do
+
+          context 'because its steps are empty' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+              model.steps = []
+
+              model
+            end
+
+            it_should_behave_like 'a linter linting a good model'
+
+          end
+
+          context 'because its steps are nil' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+              model.steps = nil
+
+              model
+            end
+
+            it_should_behave_like 'a linter linting a good model'
+
+          end
+
+        end
+
+        context 'because its setup steps come before its action steps' do
+
+          let(:test_model) do
+            model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+            model.steps = [CukeModeler::Step.new('* a step')]
+
+            model
+          end
+
+          it_should_behave_like 'a linter linting a good model'
+
+        end
+
+      end
+
+      context "with a #{model_type} that has an associated background" do
+
+        let(:test_model) do
+          feature_model = CukeLinter::ModelFactory.generate_feature_model(source_text: 'Feature:
+                                                                                          Background:
+                                                                                            Given a step
+                                                                                            When a step
+                                                                                            Given a step
+                                                                                            When a step')
+
+          model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+          model.steps = [CukeModeler::Step.new('Given a step')]
+
+          model.parent_model = feature_model
+          feature_model.tests << model
+
+          model
+        end
+
+        it 'does not consider those steps when linting' do
+          expect(subject.lint(test_model)).to eq(nil)
+        end
+
+      end
+
+    end
+
+
+    context 'a non-test model' do
+
+      let(:test_model) { CukeModeler::Model.new }
+
+      it_should_behave_like 'a linter linting a good model'
+
+    end
+  end
+end

data/testing/rspec/spec/unit/linters/test_with_setup_step_after_verification_step_linter_unit_spec.rb

@@ -0,0 +1,125 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::TestWithSetupStepAfterVerificationStepLinter do
+
+  let(:model_file_path) { 'some_file_path' }
+
+  it_should_behave_like 'a linter at the unit level'
+
+
+  it 'has a name' do
+    expect(subject.name).to eq('TestWithSetupStepAfterVerificationStepLinter')
+  end
+
+  describe 'linting' do
+
+    ['scenario', 'outline'].each do |model_type|
+
+      context "with a #{model_type} that has a setup step after a verification step" do
+
+        let(:test_model) do
+          model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model",
+                                                      parent_file_path: model_file_path)
+          model.steps = [CukeModeler::Step.new('Then a step'),
+                         CukeModeler::Step.new('Given a step')]
+
+          model
+        end
+
+        it_should_behave_like 'a linter linting a bad model'
+
+
+        it 'records a problem' do
+          result = subject.lint(test_model)
+
+          expect(result[:problem]).to eq("Test has 'Given' step after 'Then' step.")
+        end
+
+      end
+
+      context "with a #{model_type} that does not have a setup step after a verification step" do
+
+        context 'because it has no steps' do
+
+          context 'because its steps are empty' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+              model.steps = []
+
+              model
+            end
+
+            it_should_behave_like 'a linter linting a good model'
+
+          end
+
+          context 'because its steps are nil' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+              model.steps = nil
+
+              model
+            end
+
+            it_should_behave_like 'a linter linting a good model'
+
+          end
+
+        end
+
+        context 'because its setup steps come before its verification steps' do
+
+          let(:test_model) do
+            model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+            model.steps = [CukeModeler::Step.new('Given a step'),
+                           CukeModeler::Step.new('Then a step'),]
+
+            model
+          end
+
+          it_should_behave_like 'a linter linting a good model'
+
+        end
+
+      end
+
+      context "with a #{model_type} that has an associated background" do
+
+        let(:test_model) do
+          feature_model = CukeLinter::ModelFactory.generate_feature_model(source_text: 'Feature:
+                                                                                          Background:
+                                                                                            Given a step
+                                                                                            Then a step
+                                                                                            Given a step
+                                                                                            Then a step')
+
+          model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+          model.steps = [CukeModeler::Step.new('Given a step')]
+
+          model.parent_model = feature_model
+          feature_model.tests << model
+
+          model
+        end
+
+        it 'does not consider those steps when linting' do
+          expect(subject.lint(test_model)).to eq(nil)
+        end
+
+      end
+
+    end
+
+
+    context 'a non-test model' do
+
+      let(:test_model) { CukeModeler::Model.new }
+
+      it_should_behave_like 'a linter linting a good model'
+
+    end
+  end
+end