cucumber 3.1.0 → 3.1.1

data/lib/cucumber/multiline_argument/data_table/diff_matrices.rb

@@ -38,7 +38,7 @@ module Cucumber
           matched_cols = []
 
           header_values.each_with_index do |v, i|
-            mapped_index = unmatched_cols.index{|unmapped_col| unmapped_col.first == v}
+            mapped_index = unmatched_cols.index {|unmapped_col| unmapped_col.first == v}
             if mapped_index
               matched_cols << unmatched_cols.delete_at(mapped_index)
             else
@@ -68,7 +68,6 @@ module Cucumber
           array[0].is_a?(Array) ? array : [array]
         end
 
-
         def perform_diff
           inserted    = 0
           missing     = 0
@@ -77,13 +76,13 @@ module Cucumber
           changes.each do |change|
             if change.action == '-'
               @missing_row_pos = change.position + inserted
-              cell_matrix[missing_row_pos].each{|cell| cell.status = :undefined}
+              cell_matrix[missing_row_pos].each {|cell| cell.status = :undefined}
               row_indices.insert(missing_row_pos, nil)
               missing += 1
             else # '+'
               @insert_row_pos = change.position + missing
               inserted_row = change.element
-              inserted_row.each{|cell| cell.status = :comment}
+              inserted_row.each {|cell| cell.status = :comment}
               cell_matrix.insert(insert_row_pos, inserted_row)
               row_indices[insert_row_pos] = nil
               inspect_rows(cell_matrix[missing_row_pos], inserted_row) if last_change == '-'
@@ -109,7 +108,6 @@ module Cucumber
           end
         end
 
-
         def fill_in_missing_values
           other_table_cell_matrix.each_with_index do |other_row, i|
             row_index = row_indices.index(i)
@@ -123,7 +121,7 @@ module Cucumber
         end
 
         def missing_col
-          cell_matrix[0].find{|cell| cell.status == :undefined}
+          cell_matrix[0].find {|cell| cell.status == :undefined}
         end
 
         def surplus_col
@@ -134,7 +132,6 @@ module Cucumber
           cell_matrix[0] != original_header
         end
 
-
         def raise_error
           table = DataTable.from([[]])
           table.instance_variable_set :@cell_matrix, cell_matrix

data/lib/cucumber/multiline_argument/doc_string.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   module MultilineArgument
     class DocString < SimpleDelegator

data/lib/cucumber/platform.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Detect the platform we're running on so we can tweak behaviour
 # in various places.
 require 'rbconfig'
@@ -17,7 +18,7 @@ module Cucumber
       attr_accessor :use_full_backtrace
 
       # @private
-      def file_mode(m, encoding='UTF-8')
+      def file_mode(m, encoding = 'UTF-8')
         "#{m}:#{encoding}"
       end
     end

data/lib/cucumber/project_initializer.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
-module Cucumber
 
+module Cucumber
   # Generates generic file structure for a cucumber project
   class ProjectInitializer
     def run

data/lib/cucumber/rake/task.rb

@@ -1,10 +1,13 @@
 # frozen_string_literal: true
+
 require 'cucumber/platform'
 require 'cucumber/gherkin/formatter/ansi_escapes'
 begin
   # Support Rake > 0.8.7
   require 'rake/dsl_definition'
+  # rubocop:disable Lint/HandleExceptions
 rescue LoadError
+  # rubocop:enable Lint/HandleExceptions
 end
 
 module Cucumber
@@ -36,7 +39,7 @@ module Cucumber
 
         def initialize(libs, cucumber_opts, feature_files)
           raise 'libs must be an Array when running in-process' unless Array === libs
-          libs.reverse.each{|lib| $LOAD_PATH.unshift(lib)}
+          libs.reverse.each {|lib| $LOAD_PATH.unshift(lib)}
           @args = (
             cucumber_opts +
             feature_files
@@ -82,7 +85,7 @@ module Cucumber
         def cmd
           if use_bundler
             [
-              Cucumber::RUBY_BINARY,'-S', 'bundle', 'exec', 'cucumber',
+              Cucumber::RUBY_BINARY, '-S', 'bundle', 'exec', 'cucumber',
               @cucumber_opts, @feature_files
             ].flatten
           else
@@ -151,7 +154,7 @@ module Cucumber
 
       def runner(_task_args = nil) #:nodoc:
         cucumber_opts = [(ENV['CUCUMBER_OPTS'] ? ENV['CUCUMBER_OPTS'].split(/\s+/) : nil) || cucumber_opts_with_profile]
-        if(@fork)
+        if @fork
           return ForkedCucumberRunner.new(libs, binary, cucumber_opts, bundler, feature_files)
         end
         InProcessCucumberRunner.new(libs, cucumber_opts, feature_files)
@@ -166,7 +169,7 @@ module Cucumber
       end
 
       def make_command_line_safe(list)
-        list.map{|string| string.gsub(' ', '\ ')}
+        list.map {|string| string.gsub(' ', '\ ')}
       end
     end
   end

data/lib/cucumber/rspec/disable_option_parser.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'optparse'
 
 module Spec #:nodoc:

data/lib/cucumber/rspec/doubles.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'rspec/mocks'
 
 World(RSpec::Mocks::ExampleMethods)

data/lib/cucumber/running_test_case.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
+
 require 'delegate'
 
 module Cucumber
-  # Represents the current status of a running test case.
+  # Represents the current status of a running test case.
   #
   # This wraps a `Cucumber::Core::Test::Case` and delegates
   # many methods to that object.

data/lib/cucumber/runtime.rb

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
 # frozen_string_literal: true
+
 require 'fileutils'
 require 'multi_json'
 require 'cucumber/configuration'
@@ -105,7 +106,7 @@ module Cucumber
 
     # Returns Ast::DocString for +string_without_triple_quotes+.
     #
-    def doc_string(string_without_triple_quotes, content_type='', _line_offset=0)
+    def doc_string(string_without_triple_quotes, content_type = '', _line_offset = 0)
       location = Core::Ast::Location.of_caller
       Core::Ast::DocString.new(string_without_triple_quotes, content_type, location)
     end
@@ -214,7 +215,8 @@ module Cucumber
       formatter = factory.new(runtime_facade, path_or_io, cli_options)
       Formatter::LegacyApi::Adapter.new(
         Formatter::IgnoreMissingMessages.new(formatter),
-        results, @configuration)
+        results, @configuration
+      )
     end
 
     def accept_options?(factory)
@@ -245,7 +247,7 @@ module Cucumber
         filters << Cucumber::Core::Test::NameFilter.new(name_regexps)
         filters << Cucumber::Core::Test::LocationsFilter.new(filespecs.locations)
         filters << Filters::Randomizer.new(@configuration.seed) if @configuration.randomize?
-        # TODO: can we just use Glue::RegistryAndMore's step definitions directly?
+        # TODO: can we just use Glue::RegistryAndMore's step definitions directly?
         step_match_search = StepMatchSearch.new(@support_code.registry.method(:step_matches), @configuration)
         filters << Filters::ActivateSteps.new(step_match_search, @configuration)
         @configuration.filters.each do |filter|
@@ -277,7 +279,5 @@ module Cucumber
     def log
       Cucumber.logger
     end
-
   end
-
 end

data/lib/cucumber/runtime/after_hooks.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   class Runtime
     class AfterHooks

data/lib/cucumber/runtime/before_hooks.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'cucumber/hooks'
 
 module Cucumber

data/lib/cucumber/runtime/for_programming_languages.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'forwardable'
 require 'cucumber/core/ast/doc_string'
 
@@ -18,15 +19,15 @@ module Cucumber
       end
 
       def_delegators :@user_interface,
-        :embed,
-        :ask,
-        :puts,
-        :features_paths,
-        :step_match
+                     :embed,
+                     :ask,
+                     :puts,
+                     :features_paths,
+                     :step_match
 
       def_delegators :@support_code,
-        :invoke_dynamic_steps,
-        :invoke_dynamic_step
+                     :invoke_dynamic_steps,
+                     :invoke_dynamic_step
     end
   end
 end

data/lib/cucumber/runtime/step_hooks.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   class Runtime
     class StepHooks
@@ -13,6 +14,7 @@ module Cucumber
       end
 
       private
+
       def after_step_hooks(test_step)
         @hooks.map do |hook|
           action = ->(*args) { hook.invoke('AfterStep', [args, test_step]) }

data/lib/cucumber/runtime/support_code.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'cucumber/constantize'
 require 'cucumber/runtime/for_programming_languages'
 require 'cucumber/runtime/step_hooks'
@@ -8,14 +9,10 @@ require 'cucumber/gherkin/steps_parser'
 require 'cucumber/step_match_search'
 
 module Cucumber
-
   class Runtime
-
     class SupportCode
-
       require 'forwardable'
       class StepInvoker
-
         def initialize(support_code)
           @support_code = support_code
         end
@@ -48,7 +45,7 @@ module Cucumber
 
       attr_reader :registry
 
-      def initialize(user_interface, configuration=Configuration.default)
+      def initialize(user_interface, configuration = Configuration.default)
         @configuration = configuration
         # TODO: needs a better name, or inlining its methods
         @runtime_facade = Runtime::ForProgrammingLanguages.new(self, user_interface)
@@ -76,7 +73,7 @@ module Cucumber
       # steps which are compiled into test steps before execution.
       #
       # These are commonly called nested steps.
-      def invoke_dynamic_step(step_name, multiline_argument, _location=nil)
+      def invoke_dynamic_step(step_name, multiline_argument, _location = nil)
         matches = step_matches(step_name)
         raise UndefinedDynamicStep, step_name if matches.empty?
         matches.first.invoke(multiline_argument)
@@ -150,7 +147,6 @@ module Cucumber
       def log
         Cucumber.logger
       end
-
     end
   end
 end

data/lib/cucumber/runtime/user_interface.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
+
 require 'timeout'
 
 module Cucumber
   class Runtime
-
     module UserInterface
       attr_writer :visitor
 
@@ -33,7 +33,7 @@ module Cucumber
         STDOUT.flush
         puts(question)
 
-        answer = if(Cucumber::JRUBY)
+        answer = if Cucumber::JRUBY
                    jruby_gets(timeout_seconds)
                  else
                    mri_gets(timeout_seconds)
@@ -74,6 +74,5 @@ module Cucumber
         answer
       end
     end
-
   end
 end

data/lib/cucumber/step_argument.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   # Defines the location and value of a captured argument from the step
   # text

data/lib/cucumber/step_definition_light.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   # TODO: pointless, ancient, kill with fire.
   # Only used for keeping track of available and invoked step definitions
@@ -16,7 +17,7 @@ module Cucumber
     end
 
     def hash
-      regexp_source.hash + 31*location.to_s.hash
+      regexp_source.hash + 31 * location.to_s.hash
     end
   end
 end

data/lib/cucumber/step_definitions.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   class StepDefinitions
     def initialize(configuration = Configuration.default)

data/lib/cucumber/step_match.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
+
 require 'cucumber/multiline_argument'
 
 module Cucumber
-
   # Represents the match found between a Test Step and its activation
   class StepMatch #:nodoc:
     attr_reader :step_definition, :step_arguments
@@ -46,7 +46,7 @@ module Cucumber
     #
     #   lambda { |param| "[#{param}]" }
     #
-    def format_args(format = lambda{|a| a}, &proc)
+    def format_args(format = lambda {|a| a}, &proc)
       replace_arguments(@name_to_match, @step_arguments, format, &proc)
     end
 
@@ -66,7 +66,7 @@ module Cucumber
       @step_definition.expression.source.to_s.unpack('U*').length
     end
 
-    def replace_arguments(string, step_arguments, format, &proc)
+    def replace_arguments(string, step_arguments, format)
       s = string.dup
       offset = past_offset = 0
       step_arguments.each do |step_argument|
@@ -74,7 +74,7 @@ module Cucumber
         next if group.value.nil? || group.start < past_offset
 
         replacement = if block_given?
-                        proc.call(group.value)
+                        yield(group.value)
                       elsif Proc === format
                         format.call(group.value)
                       else
@@ -93,6 +93,7 @@ module Cucumber
     end
 
     private
+
     def deep_clone_args
       Marshal.load( Marshal.dump( args ) )
     end
@@ -145,7 +146,6 @@ module Cucumber
   end
 
   class AmbiguousStepMatch
-
     def initialize(error)
       @error = error
     end
@@ -153,7 +153,5 @@ module Cucumber
     def activate(test_step)
       return test_step.with_action { raise @error }
     end
-
   end
-
 end

data/lib/cucumber/step_match_search.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   module StepMatchSearch
     def self.new(search, configuration)
@@ -48,7 +49,6 @@ module Cucumber
           top_groups
         end
       end
-
     end
 
     require 'delegate'
@@ -62,6 +62,5 @@ module Cucumber
         @match_cache[step_name] = super(step_name)
       end
     end
-
   end
 end

data/lib/cucumber/term/ansicolor.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   module Term
     # The ANSIColor module can be used for namespacing and mixed into your own
@@ -6,34 +7,34 @@ module Cucumber
     module ANSIColor
       # :stopdoc:
       ATTRIBUTES = [
-        [ :clear        ,   0 ],
-        [ :reset        ,   0 ],     # synonym for :clear
-        [ :bold         ,   1 ],
-        [ :dark         ,   2 ],
-        [ :italic       ,   3 ],     # not widely implemented
-        [ :underline    ,   4 ],
-        [ :underscore   ,   4 ],     # synonym for :underline
-        [ :blink        ,   5 ],
-        [ :rapid_blink  ,   6 ],     # not widely implemented
-        [ :negative     ,   7 ],     # no reverse because of String#reverse
-        [ :concealed    ,   8 ],
-        [ :strikethrough,   9 ],     # not widely implemented
-        [ :black        ,  30 ],
-        [ :red          ,  31 ],
-        [ :green        ,  32 ],
-        [ :yellow       ,  33 ],
-        [ :blue         ,  34 ],
-        [ :magenta      ,  35 ],
-        [ :cyan         ,  36 ],
-        [ :white        ,  37 ],
-        [ :on_black     ,  40 ],
-        [ :on_red       ,  41 ],
-        [ :on_green     ,  42 ],
-        [ :on_yellow    ,  43 ],
-        [ :on_blue      ,  44 ],
-        [ :on_magenta   ,  45 ],
-        [ :on_cyan      ,  46 ],
-        [ :on_white     ,  47 ]
+        [:clear,         0],
+        [:reset,         0], # synonym for :clear
+        [:bold,          1],
+        [:dark,          2],
+        [:italic,        3], # not widely implemented
+        [:underline,     4],
+        [:underscore,    4], # synonym for :underline
+        [:blink,         5],
+        [:rapid_blink,   6], # not widely implemented
+        [:negative,      7], # no reverse because of String#reverse
+        [:concealed,     8],
+        [:strikethrough, 9], # not widely implemented
+        [:black,         30],
+        [:red,           31],
+        [:green,         32],
+        [:yellow,        33],
+        [:blue,          34],
+        [:magenta,       35],
+        [:cyan,          36],
+        [:white,         37],
+        [:on_black,      40],
+        [:on_red,        41],
+        [:on_green,      42],
+        [:on_yellow,     43],
+        [:on_blue,       44],
+        [:on_magenta,    45],
+        [:on_cyan,       46],
+        [:on_white,      47]
       ]
 
       ATTRIBUTE_NAMES = ATTRIBUTES.transpose.first
@@ -56,7 +57,7 @@ module Cucumber
       ATTRIBUTES.each do |c, v|
         eval %Q{
             def #{c}(string = nil)
-              result = ''
+              result = String.new
               result << "\e[#{v}m" if Cucumber::Term::ANSIColor.coloring?
               if block_given?
                 result << yield
@@ -77,7 +78,6 @@ module Cucumber
       # uncoloring strings.
       COLORED_REGEXP = /\e\[(?:[34][0-7]|[0-9])?m/
 
-
       def self.included(klass)
         if klass == String
           ATTRIBUTES.delete(:clear)