cucumber 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f84a6bf158202ae59a9b8db4a2659d3fbb54a8a5
-  data.tar.gz: 5f2c8a03f201b4867664044e46b235c65c384e91
+  metadata.gz: 6fc886b206588160432745dd94cb419b71dd3952
+  data.tar.gz: ade0e5e45e889f9717baa2d2dd8fad60932bf667
 SHA512:
-  metadata.gz: c24410fe9970358b71f76e01897bf3762e9a14b4d7424309d4f43fc113703e1f07e659acec28313b7958b2e97da05c4bc896ff9e0cc1cd94069f4c339831dab4
-  data.tar.gz: 03ef3f7b197165f8fe83613be7a05d4aa3990f94968b067e3d15539242cc04e24c5136b21d7985298b7062449b8ade8ac4c0707b73d27b90cf33ab480bc9573e
+  metadata.gz: f9f244e9f05394029284305f8aa39a0472507c498ca764f9c3141bc96d9521e6d37ad6ec5e898b893dc726bcd57c9537acb40e479d42660f8f3bf946adea2b92
+  data.tar.gz: d68d77df58b2f659b5689334eb2a8833ba7bf2beb977a0da20dcb25a28e3c69e8b20bc76ecf25117e6a71914b98f4f094db85f8860f8b2caee8fbdcff3c24b7a

data/CHANGELOG.md

@@ -10,7 +10,7 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ----
 
-## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v3.1.0...master) (Not released)
+## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v3.1.1...master) (Not released)
 
 ### Added
 
@@ -32,7 +32,43 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 * N/A
 
-## [3.1.0](https://github.com/cucumber/cucumber-ruby/compare/v3.0.2...3.1.0) (2017-11-28)
+### Improved
+
+* N/A
+
+## [3.1.1](https://github.com/cucumber/cucumber-ruby/compare/v3.1.0...v3.1.1) (2018-06-03)
+
+### Added
+
+* N/A
+
+### Changed
+
+* Add Rubocop to default Rake task ([#1256](https://github.com/cucumber/cucumber-ruby/pull/1256) [@jaysonesmith](https://github.com/jaysonesmith))
+* Upgraded `cucumber-expressions` dependency to ~> 6.0.0 ([#1299](https://github.com/cucumber/cucumber-ruby/pull/1299) [@aslakhellesoy](https://github.com/aslakhellesoy))
+* Upgraded to `gherkin` 5.1.0 ([#1299](https://github.com/cucumber/cucumber-ruby/pull/1299) [@aslakhellesoy](https://github.com/aslakhellesoy))
+
+### Deprecated
+
+* N/A
+
+### Removed
+
+* N/A
+
+### Fixed
+
+* Make `--fail-fast` play nice with `--retry` ([#1283](https://github.com/cucumber/cucumber-ruby/pull/1283) [@yrral86](https://github.com/yrral86))
+* Fix incompatible encodings error in JUnit formatter ([#1244](https://github.com/cucumber/cucumber-ruby/pull/1244) [@NickAb](https://github.com/NickAb)) (except on JRuby, see [#1259](https://github.com/cucumber/cucumber-ruby/pull/1259))
+* Fix the handling of failed hooks in the JUnit Formatter ([@brasmusson](https://github.com/brasmusson))
+* Fixed lengthy stacktrace when running `cucumber -f stepdefs` when steps aren't defined. ([#1286](https://github.com/cucumber/cucumber-ruby/pull/1286) [@xtrasimplicity](https://github.com/xtrasimplicity))
+* Fixed an error with HTML snippet generation when `frozen_string_literal` is enabled and the `Syntax` gem is not installed. ([#1287](https://github.com/cucumber/cucumber-ruby/pull/1287) [@xtrasimplicity](https://github.com/xtrasimplicity))
+
+### Improved
+
+* N/A
+
+## [3.1.0](https://github.com/cucumber/cucumber-ruby/compare/v3.0.2...v3.1.0) (2017-11-28)
 
 ### Added
 

data/CONTRIBUTING.md

@@ -79,6 +79,7 @@ Current release managers:
   * [Oleg Sukhodolsky](https://rubygems.org/profiles/os97673)
   * [Steve Tooke](https://rubygems.org/profiles/tooky)
   * [Björn Rasmusson](https://rubygems.org/profiles/brasmusson)
+  * [Andrew Walter](https://rubygems.org/profiles/xtrasimplicity)
 
 To grant release karma, issue the following commands:
 

data/README.md

@@ -16,20 +16,19 @@ your team.
 
 Where to get more info:
 
-  * The main website: https://cucumber.io/
-  * Documentation: https://github.com/cucumber/cucumber/wiki
-  * Ruby API Documentation: http://www.rubydoc.info/github/cucumber/cucumber-ruby/
-  * Support forum: https://groups.google.com/group/cukes
-  * Chat: ([Slack](https://cucumber.io/support#slack) and [Gitter](https://cucumber.io/support#gitter))
+ * The main website: https://cucumber.io/ 
+ * Documentation: https://docs.cucumber.io
+ * Ruby API Documentation: http://www.rubydoc.info/github/cucumber/cucumber-ruby/
+ * Support forum: https://groups.google.com/group/cukes
+ * Chat: ([Slack](https://cucumber.io/support#slack) and [Gitter](https://cucumber.io/support#gitter))
 
 See [CONTRIBUTING.md](CONTRIBUTING.md) for info on contributing to Cucumber.
 
 ## Supported platforms
-
+* Ruby 2.5
 * Ruby 2.4
 * Ruby 2.3
 * Ruby 2.2
-* Ruby 2.1
 * JRuby 9.1
 
 ## Code of Conduct

data/lib/autotest/cucumber.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'autotest'
 require 'autotest/cucumber_mixin'
 

data/lib/autotest/cucumber_mixin.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'autotest'
 require 'tempfile'
 require 'cucumber'

data/lib/autotest/cucumber_rails.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'autotest/rails'
 require 'autotest/cucumber_mixin'
 

data/lib/autotest/cucumber_rails_rspec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'autotest/cucumber_mixin'
 require 'autotest/rails_rspec'
 

data/lib/autotest/cucumber_rails_rspec2.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'autotest/cucumber_mixin'
 require 'autotest/rails_rspec2'
 

data/lib/autotest/cucumber_rspec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'autotest/cucumber_mixin'
 require 'autotest/rspec'
 

data/lib/autotest/cucumber_rspec2.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'autotest/cucumber_mixin'
 require 'autotest/rspec2'
 

data/lib/autotest/discover.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Autotest.add_discovery do
   if File.directory?('features')
     if ENV['AUTOFEATURE'] =~ /true/i

data/lib/cucumber.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'yaml'
 require 'cucumber/encoding'
 require 'cucumber/platform'

data/lib/cucumber/cli/configuration.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'logger'
 require 'cucumber/cli/options'
 require 'cucumber/cli/rerun_file'

data/lib/cucumber/cli/main.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'optparse'
 require 'cucumber'
 require 'logger'
@@ -13,7 +14,7 @@ module Cucumber
         end
       end
 
-      def initialize(args, _=nil, out=STDOUT, err=STDERR, kernel=Kernel)
+      def initialize(args, _ = nil, out = STDOUT, err = STDERR, kernel = Kernel)
         @args   = args
         @out    = out
         @err    = err
@@ -70,7 +71,6 @@ module Cucumber
 
       private
 
-
       def exit_ok
         @kernel.exit 0
       end

data/lib/cucumber/cli/options.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'cucumber/cli/profile_loader'
 require 'cucumber/formatter/ansicolor'
 require 'cucumber/glue/registry_and_more'
@@ -7,9 +8,9 @@ require 'cucumber/core/test/result'
 
 module Cucumber
   module Cli
-
     class Options
       INDENT = ' ' * 53
+      # rubocop:disable Layout/MultilineOperationIndentation
       BUILTIN_FORMATS = {
         'html'        => ['Cucumber::Formatter::Html',        'Generates a nice looking HTML report.'],
         'pretty'      => ['Cucumber::Formatter::Pretty',      'Prints the feature as is - in colours.'],
@@ -27,19 +28,20 @@ module Cucumber
         'json_pretty' => ['Cucumber::Formatter::JsonPretty',  'Prints the feature as prettified JSON'],
         'summary'     => ['Cucumber::Formatter::Summary',     'Summary output of feature and scenarios']
       }
+      # rubocop:enable Layout/MultilineOperationIndentation
       max = BUILTIN_FORMATS.keys.map(&:length).max
       FORMAT_HELP_MSG = [
-                          'Use --format rerun --out rerun.txt to write out failing',
-                          'features. You can rerun them with cucumber @rerun.txt.',
-                          'FORMAT can also be the fully qualified class name of',
-                          "your own custom formatter. If the class isn't loaded,",
-                          'Cucumber will attempt to require a file with a relative',
-                          'file name that is the underscore name of the class name.',
-                          'Example: --format Foo::BarZap -> Cucumber will look for',
-                          'foo/bar_zap.rb. You can place the file with this relative',
-                          'path underneath your features/support directory or anywhere',
-                          "on Ruby's LOAD_PATH, for example in a Ruby gem."
-                        ]
+        'Use --format rerun --out rerun.txt to write out failing',
+        'features. You can rerun them with cucumber @rerun.txt.',
+        'FORMAT can also be the fully qualified class name of',
+        "your own custom formatter. If the class isn't loaded,",
+        'Cucumber will attempt to require a file with a relative',
+        'file name that is the underscore name of the class name.',
+        'Example: --format Foo::BarZap -> Cucumber will look for',
+        'foo/bar_zap.rb. You can place the file with this relative',
+        'path underneath your features/support directory or anywhere',
+        "on Ruby's LOAD_PATH, for example in a Ruby gem."
+      ]
 
       FORMAT_HELP = (BUILTIN_FORMATS.keys.sort.map do |key|
         "  #{key}#{' ' * (max - key.length)} : #{BUILTIN_FORMATS[key][1]}"
@@ -51,11 +53,11 @@ module Cucumber
       FAIL_FAST_FLAG = '--fail-fast'
       RETRY_FLAG = '--retry'
       OPTIONS_WITH_ARGS = [
-                            '-r', '--require', '--i18n-keywords', '-f', '--format', '-o',
-                            '--out', '-t', '--tags', '-n', '--name', '-e', '--exclude',
-                            PROFILE_SHORT_FLAG, PROFILE_LONG_FLAG, RETRY_FLAG, '-l',
-                            '--lines', '--port', '-I', '--snippet-type'
-                          ]
+        '-r', '--require', '--i18n-keywords', '-f', '--format', '-o',
+        '--out', '-t', '--tags', '-n', '--name', '-e', '--exclude',
+        PROFILE_SHORT_FLAG, PROFILE_LONG_FLAG, RETRY_FLAG, '-l',
+        '--lines', '--port', '-I', '--snippet-type'
+      ]
       ORDER_TYPES = %w{defined random}
       TAG_LIMIT_MATCHER = /(?<tag_name>\@\w+):(?<limit>\d+)/x
 
@@ -95,25 +97,25 @@ module Cucumber
           opts.banner = banner
           opts.on('-r LIBRARY|DIR', '--require LIBRARY|DIR', *require_files_msg) {|lib| require_files(lib) }
 
-          if(Cucumber::JRUBY)
+          if Cucumber::JRUBY
             opts.on('-j DIR', '--jars DIR', 'Load all the jars under DIR') {|jars| load_jars(jars) }
           end
 
           opts.on("#{RETRY_FLAG} ATTEMPTS", *retry_msg) {|v| set_option :retry, v.to_i }
           opts.on('--i18n-languages', *i18n_languages_msg) { list_languages_and_exit }
-          opts.on('--i18n-keywords LANG', *i18n_keywords_msg) {|lang| set_language lang }
+          opts.on('--i18n-keywords LANG', *i18n_keywords_msg) {|lang| language lang }
           opts.on(FAIL_FAST_FLAG, 'Exit immediately following the first failing scenario') { set_option :fail_fast }
           opts.on('-f FORMAT', '--format FORMAT', *format_msg, *FORMAT_HELP) do |v|
             add_option :formats, [*parse_formats(v), @out_stream]
           end
           opts.on('--init', *init_msg) {|v| initialize_project }
-          opts.on('-o', '--out [FILE|DIR]', *out_msg) {|v| set_out_stream v }
+          opts.on('-o', '--out [FILE|DIR]', *out_msg) {|v| out_stream v }
           opts.on('-t TAG_EXPRESSION', '--tags TAG_EXPRESSION', *tags_msg) {|v| add_tag v }
           opts.on('-n NAME', '--name NAME', *name_msg) {|v| add_option :name_regexps, /#{v}/ }
           opts.on('-e', '--exclude PATTERN', *exclude_msg) {|v| add_option :excludes, Regexp.new(v) }
           opts.on(PROFILE_SHORT_FLAG, "#{PROFILE_LONG_FLAG} PROFILE", *profile_short_flag_msg) {|v| add_profile v }
           opts.on(NO_PROFILE_SHORT_FLAG, NO_PROFILE_LONG_FLAG, *no_profile_short_flag_msg) {|v| disable_profile_loading }
-          opts.on('-c', '--[no-]color', *color_msg) {|v| set_color v }
+          opts.on('-c', '--[no-]color', *color_msg) {|v| color v }
           opts.on('-d', '--dry-run', *dry_run_msg) { set_dry_run_and_duration }
           opts.on('-m', '--no-multiline', "Don't print multiline strings and tables under steps.") { set_option :no_multiline }
           opts.on('-s', '--no-source', "Don't print the file and line of the step definition with the steps.") { set_option :source, false }
@@ -133,7 +135,7 @@ module Cucumber
           opts.on('-x', '--expand', 'Expand Scenario Outline Tables in output.') { set_option :expand }
 
           opts.on('--order TYPE[:SEED]', 'Run examples in the specified order. Available types:',
-            *<<-TEXT.split("\n")) do |order|
+                  *<<-TEXT.split("\n")) do |order|
   [defined]     Run scenarios in the order they were defined (default).
   [random]      Shuffle scenarios before running.
 Specify SEED to reproduce the shuffling from a previous run.
@@ -152,7 +154,7 @@ TEXT
         @args.map! { |a| "#{a}:#{@options[:lines]}" } if @options[:lines]
 
         extract_environment_variables
-        @options[:paths] = @args.dup #whatver is left over
+        @options[:paths] = @args.dup # whatver is left over
 
         check_formatter_stream_conflicts()
 
@@ -201,11 +203,11 @@ TEXT
       end
 
       def exclude_msg
-        [ "Don't run feature files or require ruby files matching PATTERN" ]
+        ["Don't run feature files or require ruby files matching PATTERN"]
       end
 
       def format_msg
-        [ 'How to format features (Default: pretty). Available formats:' ]
+        ['How to format features (Default: pretty). Available formats:']
       end
 
       def i18n_languages_msg
@@ -229,7 +231,7 @@ TEXT
       end
 
       def lines_msg
-        [ 'Run given line numbers. Equivalent to FILE:LINE syntax' ]
+        ['Run given line numbers. Equivalent to FILE:LINE syntax']
       end
 
       def no_profile_short_flag_msg
@@ -249,7 +251,7 @@ TEXT
       end
 
       def retry_msg
-        [ 'Specify the number of times to retry failing tests (default: 0)' ]
+        ['Specify the number of times to retry failing tests (default: 0)']
       end
 
       def name_msg
@@ -273,7 +275,7 @@ TEXT
         [formatter, options_hash]
       end
 
-      def set_out_stream(v)
+      def out_stream(v)
         @options[:formats] << ['pretty', {}, nil] if @options[:formats].empty?
         @options[:formats][-1][2] = v
       end
@@ -332,12 +334,12 @@ TEXT
 
       def banner
         [
-         'Usage: cucumber [options] [ [FILE|DIR|URL][:LINE[:LINE]*] ]+', '',
-         'Examples:',
-         'cucumber examples/i18n/en/features',
-         'cucumber @rerun.txt (See --format rerun)',
-         'cucumber examples/i18n/it/features/somma.feature:6:98:113',
-         'cucumber -s -i http://rubyurl.com/eeCl', '', ''
+          'Usage: cucumber [options] [ [FILE|DIR|URL][:LINE[:LINE]*] ]+', '',
+          'Examples:',
+          'cucumber examples/i18n/en/features',
+          'cucumber @rerun.txt (See --format rerun)',
+          'cucumber examples/i18n/it/features/somma.feature:6:98:113',
+          'cucumber -s -i http://rubyurl.com/eeCl', '', ''
         ].join("\n")
       end
 
@@ -352,7 +354,7 @@ TEXT
         Dir["#{jars}/**/*.jar"].each {|jar| require jar}
       end
 
-      def set_language(lang)
+      def language(lang)
         require 'gherkin/dialect'
 
         return indicate_invalid_language_and_exit(lang) unless ::Gherkin::DIALECTS.keys.include? lang
@@ -391,7 +393,7 @@ TEXT
         tag_limits[tag_name] = limit
       end
 
-      def set_color(color)
+      def color(color)
         Cucumber::Term::ANSIColor.coloring = color
       end
 
@@ -403,7 +405,7 @@ TEXT
         @profiles << p
       end
 
-      def set_option(option, value=nil)
+      def set_option(option, value = nil)
         @options[option] = value.nil? ? true : value
       end
 
@@ -553,7 +555,8 @@ TEXT
         data = Cucumber::MultilineArgument::DataTable.from(
           ::Gherkin::DIALECTS.keys.map do |key|
             [key, ::Gherkin::DIALECTS[key].fetch('name'), ::Gherkin::DIALECTS[key].fetch('native')]
-          end)
+          end
+        )
         @out_stream.write(data.to_s({ color: false, prefixes: Hash.new('') }))
         Kernel.exit(0)
       end
@@ -573,7 +576,7 @@ TEXT
           :dry_run      => false,
           :formats      => [],
           :excludes     => [],
-          :tag_expressions  => [],
+          :tag_expressions => [],
           :tag_limits   => {},
           :name_regexps => [],
           :env_vars     => {},
@@ -585,6 +588,5 @@ TEXT
         }
       end
     end
-
   end
 end

data/lib/cucumber/cli/profile_loader.rb

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
+
 require 'yaml'
 
 module Cucumber
   module Cli
-
     class ProfileLoader
-
       def initialize
         @cucumber_yml = nil
       end
@@ -60,7 +59,7 @@ Defined profiles in cucumber.yml:
       def cucumber_yml
         return @cucumber_yml if @cucumber_yml
         unless cucumber_yml_defined?
-          raise(ProfilesNotDefinedError,"cucumber.yml was not found.  Current directory is #{Dir.pwd}.  Please refer to cucumber's documentation on defining profiles in cucumber.yml.  You must define a 'default' profile to use the cucumber command without any arguments.\nType 'cucumber --help' for usage.\n")
+          raise(ProfilesNotDefinedError, "cucumber.yml was not found.  Current directory is #{Dir.pwd}.  Please refer to cucumber's documentation on defining profiles in cucumber.yml.  You must define a 'default' profile to use the cucumber command without any arguments.\nType 'cucumber --help' for usage.\n")
         end
 
         require 'erb'
@@ -68,17 +67,17 @@ Defined profiles in cucumber.yml:
         begin
           @cucumber_erb = ERB.new(IO.read(cucumber_file), nil, '%').result(binding)
         rescue StandardError
-          raise(YmlLoadError,"cucumber.yml was found, but could not be parsed with ERB.  Please refer to cucumber's documentation on correct profile usage.\n#{$!.inspect}")
+          raise(YmlLoadError, "cucumber.yml was found, but could not be parsed with ERB.  Please refer to cucumber's documentation on correct profile usage.\n#{$!.inspect}")
         end
 
         begin
           @cucumber_yml = YAML.load(@cucumber_erb)
         rescue StandardError
-          raise(YmlLoadError,"cucumber.yml was found, but could not be parsed. Please refer to cucumber's documentation on correct profile usage.\n")
+          raise(YmlLoadError, "cucumber.yml was found, but could not be parsed. Please refer to cucumber's documentation on correct profile usage.\n")
         end
 
         if @cucumber_yml.nil? || !@cucumber_yml.is_a?(Hash)
-          raise(YmlLoadError,"cucumber.yml was found, but was blank or malformed. Please refer to cucumber's documentation on correct profile usage.\n")
+          raise(YmlLoadError, "cucumber.yml was found, but was blank or malformed. Please refer to cucumber's documentation on correct profile usage.\n")
         end
 
         return @cucumber_yml
@@ -90,7 +89,6 @@ Defined profiles in cucumber.yml:
       def cucumber_file
         @cucumber_file ||= Dir.glob('{,.config/,config/}cucumber{.yml,.yaml}').first
       end
-
     end
   end
 end