cucumber 3.1.0 → 3.1.1

data/lib/cucumber/filters/retry.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'cucumber/core/filter'
 require 'cucumber/running_test_case'
 require 'cucumber/events'
@@ -6,7 +7,6 @@ require 'cucumber/events'
 module Cucumber
   module Filters
     class Retry < Core::Filter.new(:configuration)
-
       def test_case(test_case)
         configuration.on_event(:test_case_finished) do |event|
           next unless retry_required?(test_case, event)
@@ -25,7 +25,7 @@ module Cucumber
       end
 
       def test_case_counts
-        @test_case_counts ||= Hash.new {|h,k| h[k] = 0 }
+        @test_case_counts ||= Hash.new {|h, k| h[k] = 0 }
       end
     end
   end

data/lib/cucumber/filters/tag_limits.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'cucumber/filters/gated_receiver'
 require 'cucumber/filters/tag_limits/test_case_index'
 require 'cucumber/filters/tag_limits/verifier'
@@ -12,7 +13,7 @@ module Cucumber
     end
 
     class TagLimits
-      def initialize(tag_limits, receiver=nil)
+      def initialize(tag_limits, receiver = nil)
         @tag_limits = tag_limits
         @gated_receiver = GatedReceiver.new(receiver)
         @test_case_index = TestCaseIndex.new
@@ -41,6 +42,5 @@ module Cucumber
       attr_reader :test_case_index
       attr_reader :verifier
     end
-
   end
 end

data/lib/cucumber/filters/tag_limits/test_case_index.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
+
 module Cucumber
   module Filters
     class TagLimits
-
       class TestCaseIndex
         def initialize
           @index = Hash.new { |hash, key| hash[key] = [] }
@@ -26,7 +26,6 @@ module Cucumber
 
         attr_accessor :index
       end
-
     end
   end
 end

data/lib/cucumber/filters/tag_limits/verifier.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
+
 module Cucumber
   module Filters
     class TagLimits
-
       class Verifier
         def initialize(tag_limits)
           @tag_limits = tag_limits
@@ -53,7 +53,6 @@ module Cucumber
           attr_reader :limit
           attr_reader :locations
         end
-
       end
     end
   end

data/lib/cucumber/formatter/ansicolor.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'cucumber/platform'
 require 'cucumber/term/ansicolor'
 
@@ -53,21 +54,21 @@ module Cucumber
     module ANSIColor
       include Cucumber::Term::ANSIColor
 
-      ALIASES = Hash.new do |h,k|
+      ALIASES = Hash.new do |h, k|
         if k.to_s =~ /(.*)_param/
           h[$1] + ',bold'
         end
       end.merge({
-        'undefined' => 'yellow',
-        'pending'   => 'yellow',
-        'flaky'     => 'yellow',
-        'failed'    => 'red',
-        'passed'    => 'green',
-        'outline'   => 'cyan',
-        'skipped'   => 'cyan',
-        'comment'   => 'grey',
-        'tag'       => 'cyan'
-      })
+                  'undefined' => 'yellow',
+                  'pending'   => 'yellow',
+                  'flaky'     => 'yellow',
+                  'failed'    => 'red',
+                  'passed'    => 'green',
+                  'outline'   => 'cyan',
+                  'skipped'   => 'cyan',
+                  'comment'   => 'grey',
+                  'tag'       => 'cyan'
+                })
 
       if ENV['CUCUMBER_COLORS'] # Example: export CUCUMBER_COLORS="passed=red:failed=yellow"
         ENV['CUCUMBER_COLORS'].split(':').each do |pair|
@@ -95,7 +96,7 @@ module Cucumber
           end
           # This resets the colour to the non-param colour
           def #{method_name}_param(string=nil, &proc)
-            #{ALIASES[method_name+'_param'].split(",").join("(") + "(string, &proc" + ")" * ALIASES[method_name+'_param'].split(",").length} + #{ALIASES[method_name].split(",").join(' + ')}
+            #{ALIASES[method_name + '_param'].split(",").join("(") + "(string, &proc" + ")" * ALIASES[method_name + '_param'].split(",").length} + #{ALIASES[method_name].split(",").join(' + ')}
           end
           EOF
           eval(code)

data/lib/cucumber/formatter/backtrace_filter.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
-require 'cucumber/platform'
 
+require 'cucumber/platform'
 
 module Cucumber
   module Formatter
@@ -49,6 +49,5 @@ module Cucumber
         @exception
       end
     end
-
   end
 end

data/lib/cucumber/formatter/console.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
+
 require 'cucumber/formatter/ansicolor'
 require 'cucumber/formatter/duration'
 require 'cucumber/gherkin/i18n'
 
 module Cucumber
   module Formatter
-
     # This module contains helper methods that are used by formatters that
     # print output to the terminal.
     #
@@ -111,7 +111,7 @@ module Cucumber
       # http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/10655
       def linebreaks(s, max)
         return s unless max && max > 0
-        s.gsub(/.{1,#{max}}(?:\s|\Z)/){($& + 5.chr).gsub(/\n\005/,"\n").gsub(/\005/,"\n")}.rstrip
+        s.gsub(/.{1,#{max}}(?:\s|\Z)/) {($& + 5.chr).gsub(/\n\005/, "\n").gsub(/\005/, "\n")}.rstrip
       end
 
       def collect_snippet_data(test_step, result)
@@ -127,9 +127,9 @@ module Cucumber
         return unless options[:snippets]
         return if runtime.steps(:undefined).empty?
 
-        snippet_text_proc = lambda { |step_keyword, step_name, multiline_arg|
+        snippet_text_proc = lambda do |step_keyword, step_name, multiline_arg|
           runtime.snippet_text(step_keyword, step_name, multiline_arg)
-        }
+        end
         do_print_snippets(snippet_text_proc)
       end
 
@@ -165,8 +165,8 @@ module Cucumber
         # no-op
       end
 
-      #define @delayed_messages = [] in your Formatter if you want to
-      #activate this feature
+      # define @delayed_messages = [] in your Formatter if you want to
+      # activate this feature
       def puts(*messages)
         if @delayed_messages
           @delayed_messages += messages
@@ -211,12 +211,12 @@ module Cucumber
         profiles_sentence = profiles.size == 1 ? profiles.first :
           "#{profiles[0...-1].join(', ')} and #{profiles.last}"
 
-        @io.puts "Using the #{profiles_sentence} profile#{'s' if profiles.size> 1}..."
+        @io.puts "Using the #{profiles_sentence} profile#{'s' if profiles.size > 1}..."
       end
 
       private
 
-      FORMATS = Hash.new{ |hash, format| hash[format] = method(format).to_proc }
+      FORMATS = Hash.new { |hash, format| hash[format] = method(format).to_proc }
 
       def format_for(*keys)
         key = keys.join('_').to_sym
@@ -241,9 +241,9 @@ module Cucumber
 
       def snippet_text(step_keyword, step_name, multiline_arg)
         keyword = Cucumber::Gherkin::I18n.code_keyword_for(step_keyword).strip
-        config.snippet_generators.map { |generator|
+        config.snippet_generators.map do |generator|
           generator.call(keyword, step_name, multiline_arg, config.snippet_type)
-        }.join("\n")
+        end.join("\n")
       end
 
       class SnippetData
@@ -252,7 +252,6 @@ module Cucumber
           @actual_keyword, @step = actual_keyword, step
         end
       end
-
     end
   end
 end

data/lib/cucumber/formatter/console_counts.rb

@@ -29,14 +29,14 @@ module Cucumber
       end
 
       def status_counts(summary)
-        counts = Core::Test::Result::TYPES.map { |status|
+        counts = Core::Test::Result::TYPES.map do |status|
           count = summary.total(status)
           [status, count]
-        }.select { |status, count|
+        end.select do |status, count|
           count > 0
-        }.map { |status, count|
+        end.map do |status, count|
           format_string("#{count} #{status}", status)
-        }
+        end
         "(#{counts.join(", ")})" if counts.any?
       end
     end

data/lib/cucumber/formatter/console_issues.rb

@@ -14,7 +14,7 @@ module Cucumber
             @previous_test_case = event.test_case
             @issues[event.result.to_sym] << event.test_case unless event.result.ok?(@config.strict)
           elsif event.result.passed?
-            @issues[:flaky] << event.test_case unless Core::Test::Result::Flaky.ok?(@config.strict)
+            @issues[:flaky] << event.test_case unless Core::Test::Result::Flaky.ok?(@config.strict.strict?(:flaky))
             @issues[:failed].delete(event.test_case)
           end
         end
@@ -34,10 +34,10 @@ module Cucumber
 
       def scenario_listing(type, test_cases)
         return [] if test_cases.empty?
-        [ format_string("#{type_heading(type)} Scenarios:", type) ] + test_cases.map { |test_case|
+        [format_string("#{type_heading(type)} Scenarios:", type)] + test_cases.map do |test_case|
           source = @config.source? ? format_string(" # #{test_case.keyword}: #{test_case.name}", :comment) : ''
           format_string("cucumber #{profiles_string}" + test_case.location, type) + source
-        }
+        end
       end
 
       def type_heading(type)

data/lib/cucumber/formatter/duration.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   module Formatter
     module Duration

data/lib/cucumber/formatter/duration_extractor.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
+
 module Cucumber
   module Formatter
-
     class DurationExtractor
       attr_reader :result_duration
       def initialize(result)

data/lib/cucumber/formatter/fail_fast.rb

@@ -1,20 +1,23 @@
 # frozen_string_literal: true
+
 require 'cucumber/formatter/io'
 require 'cucumber/formatter/console'
 
 module Cucumber
   module Formatter
-
     class FailFast
-
       def initialize(configuration)
+        @previous_test_case = nil
         configuration.on_event :test_case_finished do |event|
-          _test_case, result = *event.attributes
-          Cucumber.wants_to_quit = true unless result.ok?(configuration.strict)
+          test_case, result = *event.attributes
+          if test_case != @previous_test_case
+            @previous_test_case = event.test_case
+            Cucumber.wants_to_quit = true unless result.ok?(configuration.strict)
+          elsif result.passed?
+            Cucumber.wants_to_quit = false
+          end
         end
       end
-
     end
-
   end
 end

data/lib/cucumber/formatter/fanout.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
+
 module Cucumber
   module Formatter
-
     # Forwards any messages sent to this object to all recipients
     # that respond to that message.
     class Fanout < BasicObject
@@ -21,8 +21,6 @@ module Cucumber
       def respond_to_missing?(name, include_private = false)
         recipients.any? { |recipient| recipient.respond_to?(name, include_private) }
       end
-
     end
-
   end
 end

data/lib/cucumber/formatter/hook_query_visitor.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Cucumber
   module Formatter
     class HookQueryVisitor

data/lib/cucumber/formatter/html.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'erb'
 require 'cucumber/formatter/duration'
 require 'cucumber/formatter/io'
@@ -8,8 +9,7 @@ require 'pathname'
 module Cucumber
   module Formatter
     class Html
-
-      # TODO: remove coupling to types
+      # TODO: remove coupling to types
       AST_CLASSES = {
         Cucumber::Core::Ast::Scenario        => 'scenario',
         Cucumber::Core::Ast::ScenarioOutline => 'scenario outline'
@@ -42,13 +42,13 @@ module Cucumber
       def embed(src, mime_type, label)
         if image?(mime_type)
           src = src_is_file_or_data?(src) ? src : "data:#{standardize_mime_type(mime_type)},#{src}"
-          builder.embed(type: :image, src: set_path(src), label: label, id: next_id(:img))
+          builder.embed(type: :image, src: path(src), label: label, id: next_id(:img))
         else
           builder.embed(type: :text, src: src, label: label, id: next_id(:text))
         end
       end
 
-      def set_path(src)
+      def path(src)
         if @io.respond_to?(:path) && File.file?(src)
           out_dir = Pathname.new(File.dirname(File.absolute_path(@io.path)))
           src = Pathname.new(File.absolute_path(src)).relative_path_from(out_dir)
@@ -70,7 +70,7 @@ module Cucumber
       end
 
       def before_features(features)
-        @step_count = features && features.step_count || 0 #TODO: Make this work with core!
+        @step_count = features && features.step_count || 0 # TODO: Make this work with core!
 
         builder.build_document!
         builder.format_features! features
@@ -153,7 +153,7 @@ module Cucumber
       end
 
       def before_feature_element(feature_element)
-        @scenario_number+=1
+        @scenario_number += 1
         @scenario_red = false
         css_class = AST_CLASSES[feature_element.class]
         builder << "<div class='#{css_class}'>"
@@ -251,7 +251,7 @@ module Cucumber
         end
         @status = status
         return if @hide_this_step
-        set_scenario_color(status)
+        scenario_color(status)
         builder << "<li id='#{@step_id}' class='step #{status}'>"
       end
 
@@ -266,7 +266,7 @@ module Cucumber
           builder.pre do |pre|
             # TODO: snippet text should be an event sent to the formatter so we don't
             # have this couping to the runtime.
-            pre << @runtime.snippet_text(keyword,step_match.instance_variable_get('@name') || '', @step.multiline_arg)
+            pre << @runtime.snippet_text(keyword, step_match.instance_variable_get('@name') || '', @step.multiline_arg)
           end
         end
         builder << '</li>'
@@ -353,25 +353,22 @@ module Cucumber
         attributes = {:id => "#{@row_id}_#{@col_index}", :class => 'step'}
         attributes[:class] += " #{status}" if status
         build_cell(@cell_type, value, attributes)
-        set_scenario_color(status) if @inside_outline
+        scenario_color(status) if @inside_outline
         @col_index += 1
       end
 
       def puts(message)
         @delayed_messages << message
-        #builder.pre(message, :class => 'message')
       end
 
       def print_messages
         return if @delayed_messages.empty?
 
-          #builder.ol do
-          @delayed_messages.each do |ann|
-            builder.li(:class => 'step message') do
-              builder << ann
-            end
+        @delayed_messages.each do |ann|
+          builder.li(:class => 'step message') do
+            builder << ann
           end
-        #end
+        end
         empty_messages
       end
 
@@ -436,7 +433,7 @@ module Cucumber
         builder << extra unless extra == ''
       end
 
-      def set_scenario_color(status)
+      def scenario_color(status)
         if status.nil? || status == :undefined || status == :pending
           set_scenario_color_pending
         end
@@ -467,7 +464,7 @@ module Cucumber
       end
 
       def build_step(keyword, step_match, _status)
-        step_name = step_match.format_args(lambda{|param| %{<span class="param">#{param}</span>}})
+        step_name = step_match.format_args(lambda {|param| %{<span class="param">#{param}</span>}})
         builder.div(:class => 'step_name') do |div|
           builder.span(keyword, :class => 'keyword')
           builder.span(:class => 'step val') do |name|
@@ -492,7 +489,7 @@ module Cucumber
       def build_cell(cell_type, value, attributes)
         builder.__send__(cell_type, attributes) do
           builder.div do
-            builder.span(value,:class => 'step param')
+            builder.span(value, :class => 'step param')
           end
         end
       end
@@ -531,11 +528,11 @@ module Cucumber
       def print_stat_string(_features)
         string = String.new
         string << dump_count(@runtime.scenarios.length, 'scenario')
-        scenario_count = print_status_counts{|status| @runtime.scenarios(status)}
+        scenario_count = print_status_counts {|status| @runtime.scenarios(status)}
         string << scenario_count if scenario_count
         string << '<br />'
         string << dump_count(@runtime.steps.length, 'step')
-        step_count = print_status_counts{|status| @runtime.steps(status)}
+        step_count = print_status_counts {|status| @runtime.steps(status)}
         string << step_count if step_count
       end
 
@@ -547,7 +544,7 @@ module Cucumber
         return " (#{counts.join(', ')})" if counts.any?
       end
 
-      def dump_count(count, what, state=nil)
+      def dump_count(count, what, state = nil)
         [count, state, "#{what}#{count == 1 ? '' : 's'}"].compact.join(' ')
       end
 
@@ -568,7 +565,7 @@ module Cucumber
         def snippet(error)
           raw_code, line = snippet_for(error[0])
           highlighted = @@converter.convert(raw_code, false)
-          highlighted << "\n<span class=\"comment\"># gem install syntax to get syntax highlighting</span>" if @@converter.is_a?(NullConverter)
+          highlighted += "\n<span class=\"comment\"># gem install syntax to get syntax highlighting</span>" if @@converter.is_a?(NullConverter)
           post_process(highlighted, line)
         end
 
@@ -585,12 +582,12 @@ module Cucumber
         def lines_around(file, line)
           if File.file?(file)
             begin
-            lines = File.open(file).read.split("\n")
-          rescue ArgumentError
-            return "# Couldn't get snippet for #{file}"
-          end
-          min = [0, line-3].max
-            max = [line+1, lines.length-1].min
+              lines = File.open(file).read.split("\n")
+            rescue ArgumentError
+              return "# Couldn't get snippet for #{file}"
+            end
+            min = [0, line - 3].max
+            max = [line + 1, lines.length - 1].min
             selected_lines = []
             selected_lines.join("\n")
             lines[min..max].join("\n")
@@ -602,13 +599,12 @@ module Cucumber
         def post_process(highlighted, offending_line)
           new_lines = []
           highlighted.split("\n").each_with_index do |line, i|
-            new_line = "<span class=\"linenum\">#{offending_line+i-2}</span>#{line}"
+            new_line = "<span class=\"linenum\">#{offending_line + i - 2}</span>#{line}"
             new_line = "<span class=\"offending\">#{new_line}</span>" if i == 2
             new_lines << new_line
           end
           new_lines.join("\n")
         end
-
       end
     end
   end