cucumber 2.99.0 → 3.0.0

data/spec/cucumber/formatter/legacy_api/adapter_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cucumber/formatter/legacy_api/adapter'
 require 'cucumber/core'
 require 'cucumber/core/gherkin/writer'
@@ -13,9 +14,10 @@ module Cucumber
       include Core::Gherkin::Writer
       include Core
 
-      let(:report)    { Adapter.new(formatter, runtime.results, runtime.configuration) }
+      let!(:report)    { Adapter.new(formatter, runtime.results, runtime.configuration) }
       let(:formatter) { double('formatter').as_null_object }
       let(:runtime)   { Runtime.new }
+      let(:events)    { runtime.configuration.event_bus }
       let(:step_match_search) { SimpleStepDefinitionSearch.new }
 
       Failure = Class.new(StandardError)
@@ -57,7 +59,7 @@ module Cucumber
           source_location
         end
 
-        def invoke(pseudo_method, arguments, &block)
+        def invoke(_pseudo_method, _arguments, &_block)
           @proc.call
         end
       end
@@ -104,10 +106,12 @@ module Cucumber
                   step 'passing'
                 end
               end
-            end,
+            end
           ]
-          runner = Core::Test::Runner.new(report)
+          runner = Core::Test::Runner.new(events)
           compile gherkin_docs, runner, default_filters
+          events.test_run_finished
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
             :before_features,
               :before_feature,
@@ -144,68 +148,9 @@ module Cucumber
                   :after_steps,
                 :after_feature_element,
               :after_feature,
-            :after_features,
-          ]
-        end
-
-        it 'a scenario with no steps' do
-          execute_gherkin do
-            feature do
-              scenario
-            end
-          end
-
-          expect( formatter.legacy_messages ).to eq [
-              :before_features,
-                :before_feature,
-                  :before_tags,
-                  :after_tags,
-                  :feature_name,
-                  :before_feature_element,
-                    :before_tags,
-                      :after_tags,
-                    :scenario_name,
-                  :after_feature_element,
-                :after_feature,
-              :after_features,
-          ]
-        end
-
-        it 'a scenario with no steps coming after another scenario' do
-          execute_gherkin do
-            feature do
-              scenario do
-                step 'passing'
-              end
-              scenario
-            end
-          end
-          expect( formatter.legacy_messages ).to eq [
-              :before_features,
-                :before_feature,
-                  :before_tags,
-                  :after_tags,
-                  :feature_name,
-                  :before_feature_element,
-                    :before_tags,
-                      :after_tags,
-                    :scenario_name,
-                    :before_steps,
-                      :before_step,
-                        :before_step_result,
-                        :step_name,
-                        :after_step_result,
-                      :after_step,
-                    :after_steps,
-                  :after_feature_element,
-                  :before_feature_element,
-                    :before_tags,
-                      :after_tags,
-                    :scenario_name,
-                  :after_feature_element,
-                :after_feature,
-              :after_features,
+            :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a scenario with one step' do
@@ -216,6 +161,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -235,8 +182,9 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a scenario with two steps, one of them failing' do
@@ -273,7 +221,7 @@ module Cucumber
               :after_steps,
               :after_feature_element,
               :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -288,6 +236,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -319,8 +269,9 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and an empty scenario' do
@@ -332,6 +283,8 @@ module Cucumber
               scenario
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
             :before_features,
               :before_feature,
@@ -354,8 +307,9 @@ module Cucumber
                   :scenario_name,
                 :after_feature_element,
               :after_feature,
-            :after_features,
+            :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and two scenarios' do
@@ -372,6 +326,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -413,8 +369,9 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and one scenario and one scenario outline' do
@@ -435,6 +392,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -495,8 +454,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and one scenario outline and one scenario' do
@@ -517,6 +477,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -577,8 +539,9 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and two scenario outlines' do
@@ -603,6 +566,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -682,8 +647,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and one scenario outline with two rows' do
@@ -702,6 +668,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -755,8 +723,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and one scenario outline with two examples tables' do
@@ -778,6 +747,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -843,8 +814,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background with two steps' do
@@ -859,6 +831,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -893,8 +867,9 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background' do
@@ -937,7 +912,7 @@ module Cucumber
               :after_steps,
               :after_feature_element,
               :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -953,6 +928,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -991,8 +968,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'scenario outline after scenario' do
@@ -1010,6 +988,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1060,8 +1040,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'scenario outline before scenario' do
@@ -1079,6 +1060,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1129,8 +1112,9 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'scenario outline two rows' do
@@ -1146,6 +1130,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1189,8 +1175,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'scenario outline two examples tables' do
@@ -1209,6 +1196,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1264,8 +1253,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'two scenario outline' do
@@ -1287,6 +1277,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1356,8 +1348,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'failing scenario outline' do
@@ -1372,6 +1365,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1410,8 +1405,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a failing background and two scenarios' do
@@ -1428,6 +1424,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1470,8 +1468,9 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         context 'in expand mode' do
@@ -1491,6 +1490,8 @@ module Cucumber
                 end
               end
             end
+
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq [
                 :before_features,
                   :before_feature,
@@ -1531,15 +1532,16 @@ module Cucumber
                       :after_examples_array,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
+                :after_features
               ]
+            # rubocop:enable AlignArray
           end
         end
 
         context 'with exception in after step hook' do
 
           class FailingAfterStepHook
-            def find_after_step_hooks(test_case)
+            def find_after_step_hooks(_test_case)
               failing_hook = HookWrapper.new(proc { raise Failure })
               Runtime::StepHooks.new [failing_hook]
             end
@@ -1558,6 +1560,8 @@ module Cucumber
                 end
               end
             end
+
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1578,8 +1582,9 @@ module Cucumber
                       :after_steps,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
-                ])
+                :after_features
+              ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1605,6 +1610,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1625,8 +1631,9 @@ module Cucumber
                       :after_steps,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
-                ])
+                :after_features
+              ])
+            # rubocop:enable AlignArray
           end
 
           it 'prints the exception after the background name' do
@@ -1646,6 +1653,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1676,8 +1684,9 @@ module Cucumber
                       :after_steps,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
-                ])
+                :after_features
+              ])
+            # rubocop:enable AlignArray
           end
 
 
@@ -1699,6 +1708,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1738,8 +1748,9 @@ module Cucumber
                       :after_examples_array,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
+                :after_features
               ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1768,6 +1779,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1788,8 +1800,9 @@ module Cucumber
                       :after_steps,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
-                ])
+                :after_features
+              ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1816,6 +1829,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -1836,8 +1850,9 @@ module Cucumber
                     :exception,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
+            # rubocop:enable AlignArray
           end
 
           it 'prints the exception after the examples table row' do
@@ -1858,6 +1873,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -1897,8 +1913,9 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1925,6 +1942,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -1945,40 +1963,9 @@ module Cucumber
                     :exception,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
-            ])
-          end
-        end
-
-        context 'with an exception in an after hook but no steps' do
-          it 'prints the exception after the scenario name' do
-            filters = [
-              Filters::ActivateSteps.new(step_match_search, runtime.configuration),
-              Filters::ApplyAfterHooks.new(FailingAfterHook.new),
-              AddBeforeAndAfterHooks.new
-            ]
-            execute_gherkin(filters) do
-              feature do
-                scenario do
-                end
-              end
-            end
-
-            expect( formatter.legacy_messages ).to eq([
-              :before_features,
-                :before_feature,
-                  :before_tags,
-                  :after_tags,
-                  :feature_name,
-                  :before_feature_element,
-                    :before_tags,
-                    :after_tags,
-                    :scenario_name,
-                    :exception,
-                  :after_feature_element,
-                :after_feature,
-              :after_features,
+              :after_features
             ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -2000,10 +1987,12 @@ module Cucumber
             execute_gherkin(filters) do
               feature do
                 scenario do
+                  step 'passing'
                 end
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -2017,8 +2006,9 @@ module Cucumber
                     :exception,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -2044,7 +2034,7 @@ module Cucumber
                 end
               end
             end
-
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -2065,15 +2055,16 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
+            # rubocop:enable AlignArray
           end
         end
       end
 
       describe 'before_step_result message' do
         context 'when the step matches' do
-          it "sends the step match to the formatter" do
+          it 'sends the step match to the formatter' do
             expect(formatter).to receive(:before_step_result) do |_, step_match, *|
               expect(step_match).to be_a SimpleStepMatch
             end
@@ -2088,7 +2079,7 @@ module Cucumber
         end
 
         context "when the step doesn't match" do
-          it "sends a null object to the formatter" do
+          it 'sends a null object to the formatter' do
           end
         end
       end
@@ -2106,7 +2097,7 @@ module Cucumber
         end
       end
 
-      context "after_feature_element callback" do
+      context 'after_feature_element callback' do
         it 'passes an object reflecting the status of the scenario' do
           expect( formatter ).to receive(:after_feature_element).once do |scenario|
             expect( scenario ).to be_failed
@@ -2123,7 +2114,7 @@ module Cucumber
       end
 
       context 'in strict mode' do
-        let(:runtime) { Runtime.new strict: true }
+        let(:runtime) { Runtime.new strict: Cucumber::Core::Test::Result::StrictConfiguration.new([:undefined]) }
 
         it 'passes an exception to the formatter for undefined steps' do
           expect( formatter ).to receive(:exception) do |exception|
@@ -2156,18 +2147,20 @@ module Cucumber
           ]
         end
 
-        def method_missing(message, *args)
+        def method_missing(message, *_args)
           @messages << message
         end
 
-        def respond_to_missing?(name, include_private = false)
+        def respond_to_missing?(_name, _include_private = false)
           true
         end
       end
 
       def execute_gherkin(filters = default_filters, &gherkin)
-        runner = Core::Test::Runner.new(report)
+        runner = Core::Test::Runner.new(events)
         compile [gherkin(&gherkin)], runner, filters
+        events.test_run_finished
+        self
       end
 
       def default_filters